[INFO] cloning repository https://github.com/evanlh/masterblaster-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/evanlh/masterblaster-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fevanlh%2Fmasterblaster-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fevanlh%2Fmasterblaster-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 19937778a93846e33c1e1203b01bb9795af4ba1f [INFO] linting evanlh/masterblaster-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fevanlh%2Fmasterblaster-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/evanlh/masterblaster-rs [INFO] removed 0 missing tests [INFO] finished tweaking git repo https://github.com/evanlh/masterblaster-rs [INFO] tweaked toml for git repo https://github.com/evanlh/masterblaster-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/evanlh/masterblaster-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/evanlh/masterblaster-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rfd v0.15.4 [INFO] [stderr] Downloaded assert_no_alloc v1.1.2 [INFO] [stderr] Downloaded imgui-winit-support v0.13.0 [INFO] [stderr] Downloaded ringbuf v0.4.8 [INFO] [stderr] Downloaded chlorine v1.0.13 [INFO] [stderr] Downloaded binrw_derive v0.14.1 [INFO] [stderr] Downloaded binrw v0.14.1 [INFO] [stderr] Downloaded imgui v0.12.0 [INFO] [stderr] Downloaded regex-syntax v0.8.9 [INFO] [stderr] Downloaded imgui-glow-renderer v0.13.0 [INFO] [stderr] Downloaded ashpd v0.11.1 [INFO] [stderr] Downloaded imgui-sys v0.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3b666eb2416be01c3b92e0c60446ccb5ffbb3e89ba1a17b6ecfb5ed173d8d1b3 [INFO] running `Command { std: "docker" "start" "-a" "3b666eb2416be01c3b92e0c60446ccb5ffbb3e89ba1a17b6ecfb5ed173d8d1b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3b666eb2416be01c3b92e0c60446ccb5ffbb3e89ba1a17b6ecfb5ed173d8d1b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b666eb2416be01c3b92e0c60446ccb5ffbb3e89ba1a17b6ecfb5ed173d8d1b3", kill_on_drop: false }` [INFO] [stdout] 3b666eb2416be01c3b92e0c60446ccb5ffbb3e89ba1a17b6ecfb5ed173d8d1b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9cc7abab423a2d55e8225b8900f8c10d0ac5837812dcca9277f2cc9886f5807c [INFO] running `Command { std: "docker" "start" "-a" "9cc7abab423a2d55e8225b8900f8c10d0ac5837812dcca9277f2cc9886f5807c", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling cc v1.2.55 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking unicode-ident v1.0.22 [INFO] [stderr] Checking mb-ir v0.1.0 (/opt/rustwide/workdir/crates/mb-ir) [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling binrw_derive v0.14.1 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling toml_edit v0.23.10+spec-1.0.0 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stdout] warning: struct `ModEnvelope` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> crates/mb-ir/src/mod_envelope.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/mb-ir/src/song.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / return track.machine_node [INFO] [stdout] 107 | | .and_then(|id| self.graph.node(id)) [INFO] [stdout] 108 | | .map(|n| match n.node_type { [INFO] [stdout] 109 | | NodeType::Machine { is_tracker, .. } => { [INFO] [stdout] ... | [INFO] [stdout] 115 | | }) [INFO] [stdout] 116 | | .unwrap_or(false); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ track.machine_node [INFO] [stdout] 107 + .and_then(|id| self.graph.node(id)) [INFO] [stdout] 108 + .map(|n| match n.node_type { [INFO] [stdout] 109 + NodeType::Machine { is_tracker, .. } => { [INFO] [stdout] 110 + is_tracker [INFO] [stdout] 111 + } [INFO] [stdout] 112 + _ => { [INFO] [stdout] 113 + false [INFO] [stdout] 114 + } [INFO] [stdout] 115 + }) [INFO] [stdout] 116 ~ .unwrap_or(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/mb-ir/src/song.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | return (self.get_pattern_at(self.sequence[seq_idx].clip_idx as usize), self.sequence[seq_idx].start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - return (self.get_pattern_at(self.sequence[seq_idx].clip_idx as usize), self.sequence[seq_idx].start); [INFO] [stdout] 205 + (self.get_pattern_at(self.sequence[seq_idx].clip_idx as usize), self.sequence[seq_idx].start) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling binrw v0.14.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.2 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Compiling endi v1.1.1 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Checking syn v2.0.114 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Compiling imgui-sys v0.12.0 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking alsa-sys v0.3.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking ringbuf v0.4.8 [INFO] [stderr] Checking mint v0.5.9 [INFO] [stderr] Checking chlorine v1.0.13 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking mb-engine v0.1.0 (/opt/rustwide/workdir/crates/mb-engine) [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Compiling glutin v0.32.3 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/mb-engine/src/channel.rs:360:40 [INFO] [stdout] | [INFO] [stdout] 360 | if prev > target && value < target { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 361 | | target [INFO] [stdout] 362 | | } else if prev < target && value > target { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/mb-engine/src/channel.rs:362:47 [INFO] [stdout] | [INFO] [stdout] 362 | } else if prev < target && value > target { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 363 | | target [INFO] [stdout] 364 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking cpal v0.15.3 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stdout] warning: the loop variable `i` is only used to index `left` [INFO] [stdout] --> crates/mb-engine/src/machines/amiga_filter.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | for i in 0..frames { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 67 - for i in 0..frames { [INFO] [stdout] 67 + for in left.iter_mut().take(frames) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `right` [INFO] [stdout] --> crates/mb-engine/src/machines/amiga_filter.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | for i in 0..frames { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 77 - for i in 0..frames { [INFO] [stdout] 77 + for in right.iter_mut().take(frames) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> crates/mb-engine/src/mixer.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | self.event_buf.sort_unstable_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 - self.event_buf.sort_unstable_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] 204 + self.event_buf.sort_unstable_by_key(|a| a.time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Compiling glutin-winit v0.5.0 [INFO] [stderr] Compiling rfd v0.15.4 [INFO] [stderr] Checking mb-audio v0.1.0 (/opt/rustwide/workdir/crates/mb-audio) [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking assert_no_alloc v1.1.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stdout] warning: struct `ModEnvelope` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> crates/mb-ir/src/mod_envelope.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/mb-ir/src/song.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / return track.machine_node [INFO] [stdout] 107 | | .and_then(|id| self.graph.node(id)) [INFO] [stdout] 108 | | .map(|n| match n.node_type { [INFO] [stdout] 109 | | NodeType::Machine { is_tracker, .. } => { [INFO] [stdout] ... | [INFO] [stdout] 115 | | }) [INFO] [stdout] 116 | | .unwrap_or(false); [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 ~ track.machine_node [INFO] [stdout] 107 + .and_then(|id| self.graph.node(id)) [INFO] [stdout] 108 + .map(|n| match n.node_type { [INFO] [stdout] 109 + NodeType::Machine { is_tracker, .. } => { [INFO] [stdout] 110 + is_tracker [INFO] [stdout] 111 + } [INFO] [stdout] 112 + _ => { [INFO] [stdout] 113 + false [INFO] [stdout] 114 + } [INFO] [stdout] 115 + }) [INFO] [stdout] 116 ~ .unwrap_or(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> crates/mb-ir/src/song.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | return (self.get_pattern_at(self.sequence[seq_idx].clip_idx as usize), self.sequence[seq_idx].start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - return (self.get_pattern_at(self.sequence[seq_idx].clip_idx as usize), self.sequence[seq_idx].start); [INFO] [stdout] 205 + (self.get_pattern_at(self.sequence[seq_idx].clip_idx as usize), self.sequence[seq_idx].start) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking mb-formats v0.1.0 (/opt/rustwide/workdir/crates/mb-formats) [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking imgui v0.12.0 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking mb-master v0.1.0 (/opt/rustwide/workdir/crates/mb-master) [INFO] [stderr] Compiling zvariant_utils v3.3.0 [INFO] [stderr] Compiling enumflags2 v0.7.12 [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> crates/mb-formats/tests/mod_fixtures.rs:26:21 [INFO] [stdout] | [INFO] [stdout] 26 | (0..pat.channels as u8).map(move |col| pat.cell(row, col)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `pat.channels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling zvariant_derive v5.9.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Compiling zvariant v5.9.2 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking imgui-glow-renderer v0.13.0 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking zbus_names v4.3.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Compiling zbus_macros v5.13.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> crates/mb-engine/benches/engine_bench.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 28 | if hash % 4 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `hash.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> crates/mb-engine/src/channel.rs:360:40 [INFO] [stdout] | [INFO] [stdout] 360 | if prev > target && value < target { [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 361 | | target [INFO] [stdout] 362 | | } else if prev < target && value > target { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> crates/mb-engine/src/channel.rs:362:47 [INFO] [stdout] | [INFO] [stdout] 362 | } else if prev < target && value > target { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 363 | | target [INFO] [stdout] 364 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/mb-engine/src/clip_source.rs:264:9 [INFO] [stdout] | [INFO] [stdout] 264 | expected_events.sort_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 264 - expected_events.sort_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] 264 + expected_events.sort_by_key(|a| a.time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> crates/mb-engine/src/clip_source.rs:272:9 [INFO] [stdout] | [INFO] [stdout] 272 | actual_events.sort_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 272 - actual_events.sort_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] 272 + actual_events.sort_by_key(|a| a.time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `left` [INFO] [stdout] --> crates/mb-engine/src/machines/amiga_filter.rs:67:18 [INFO] [stdout] | [INFO] [stdout] 67 | for i in 0..frames { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 67 - for i in 0..frames { [INFO] [stdout] 67 + for in left.iter_mut().take(frames) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `right` [INFO] [stdout] --> crates/mb-engine/src/machines/amiga_filter.rs:77:22 [INFO] [stdout] | [INFO] [stdout] 77 | for i in 0..frames { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 77 - for i in 0..frames { [INFO] [stdout] 77 + for in right.iter_mut().take(frames) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> crates/mb-engine/src/mixer.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | self.event_buf.sort_unstable_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 - self.event_buf.sort_unstable_by(|a, b| a.time.cmp(&b.time)); [INFO] [stdout] 204 + self.event_buf.sort_unstable_by_key(|a| a.time); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking zbus v5.13.2 [INFO] [stderr] Checking imgui-winit-support v0.13.0 [INFO] [stderr] Checking ashpd v0.11.1 [INFO] [stderr] Checking masterblaster v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the loop variable `i` is used to index `muted` [INFO] [stdout] --> src/ui/sequencer.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | for i in 0..num_tracks { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 80 - for i in 0..num_tracks { [INFO] [stdout] 80 + for (i, ) in muted.iter().enumerate().take(num_tracks) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `track_labels` [INFO] [stdout] --> src/ui/sequencer.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 99 | for i in 0..num_tracks { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 99 - for i in 0..num_tracks { [INFO] [stdout] 99 + for (i, ) in track_labels.iter().enumerate().take(num_tracks) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ui/sequencer.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 270 | if beat % 16 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `beat.is_multiple_of(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ui/sequencer.rs:272:15 [INFO] [stdout] | [INFO] [stdout] 272 | } else if beat % 4 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `beat.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `muted` [INFO] [stdout] --> src/ui/sequencer.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | for i in 0..num_tracks { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 80 - for i in 0..num_tracks { [INFO] [stdout] 80 + for (i, ) in muted.iter().enumerate().take(num_tracks) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `track_labels` [INFO] [stdout] --> src/ui/sequencer.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 99 | for i in 0..num_tracks { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 99 - for i in 0..num_tracks { [INFO] [stdout] 99 + for (i, ) in track_labels.iter().enumerate().take(num_tracks) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ui/sequencer.rs:270:8 [INFO] [stdout] | [INFO] [stdout] 270 | if beat % 16 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace with: `beat.is_multiple_of(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/ui/sequencer.rs:272:15 [INFO] [stdout] | [INFO] [stdout] 272 | } else if beat % 4 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace with: `beat.is_multiple_of(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> tests/bmx_fixtures.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | / clip.pattern().map_or(false, |pat| { [INFO] [stdout] 90 | | pat.data.iter().any(|cell| !cell.is_empty()) [INFO] [stdout] 91 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 89 - clip.pattern().map_or(false, |pat| { [INFO] [stdout] 89 + clip.pattern().is_some_and(|pat| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> tests/bmx_fixtures.rs:134:21 [INFO] [stdout] | [INFO] [stdout] 134 | let expected = (100u32 * 1 * 4) / 24; [INFO] [stdout] | ^^^^^^^^^^ help: consider reducing it to: `100u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 17s [INFO] running `Command { std: "docker" "inspect" "9cc7abab423a2d55e8225b8900f8c10d0ac5837812dcca9277f2cc9886f5807c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cc7abab423a2d55e8225b8900f8c10d0ac5837812dcca9277f2cc9886f5807c", kill_on_drop: false }` [INFO] [stdout] 9cc7abab423a2d55e8225b8900f8c10d0ac5837812dcca9277f2cc9886f5807c