[INFO] cloning repository https://github.com/eugenever/locator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eugenever/locator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feugenever%2Flocator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feugenever%2Flocator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f07ec3774ed62b95e73657166cd6fdd81df78731 [INFO] linting eugenever/locator/f07ec3774ed62b95e73657166cd6fdd81df78731 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feugenever%2Flocator" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eugenever/locator [INFO] finished tweaking git repo https://github.com/eugenever/locator [INFO] tweaked toml for git repo https://github.com/eugenever/locator written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eugenever/locator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eugenever/locator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/savish/clusters` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tokio-pg-mapper-derive v0.2.0 [INFO] [stderr] Downloaded wasite v1.0.2 [INFO] [stderr] Downloaded tokio_schedule v0.3.2 [INFO] [stderr] Downloaded tokio-postgres v0.7.16 [INFO] [stderr] Downloaded i_shape v1.3.1 [INFO] [stderr] Downloaded h3o-bit v0.1.1 [INFO] [stderr] Downloaded const_fn v0.4.11 [INFO] [stderr] Downloaded actix-multipart-derive v0.7.0 [INFO] [stderr] Downloaded serde_plain v1.0.2 [INFO] [stderr] Downloaded parse-size v1.1.0 [INFO] [stderr] Downloaded actix-multipart v0.7.2 [INFO] [stderr] Downloaded rstar v0.12.0 [INFO] [stderr] Downloaded flume v0.12.0 [INFO] [stderr] Downloaded regex-lite v0.1.5 [INFO] [stderr] Downloaded i_overlay v1.7.4 [INFO] [stderr] Downloaded aes-soft v0.6.4 [INFO] [stderr] Downloaded gpx v0.10.0 [INFO] [stderr] Downloaded geojson v0.24.1 [INFO] [stderr] Downloaded isahc v0.9.14 [INFO] [stderr] Downloaded webpki-root-certs v1.0.5 [INFO] [stderr] Downloaded async-std v1.13.2 [INFO] [stderr] Downloaded hyper v0.13.10 [INFO] [stderr] Downloaded aes-gcm v0.8.0 [INFO] [stderr] Downloaded aesni v0.10.0 [INFO] [stderr] Downloaded geo v0.29.2 [INFO] [stderr] Downloaded aes v0.6.0 [INFO] [stderr] Downloaded geographiclib-rs v0.2.4 [INFO] [stderr] Downloaded redis v1.0.2 [INFO] [stderr] Downloaded geo-types v0.7.14 [INFO] [stderr] Downloaded schemars v1.1.0 [INFO] [stderr] Downloaded curl v0.4.49 [INFO] [stderr] Downloaded spade v2.12.1 [INFO] [stderr] Downloaded tokio v0.2.25 [INFO] [stderr] Downloaded flume v0.9.2 [INFO] [stderr] Downloaded robust v1.1.0 [INFO] [stderr] Downloaded cookie v0.14.4 [INFO] [stderr] Downloaded surf v2.3.2 [INFO] [stderr] Downloaded spinning_top v0.2.5 [INFO] [stderr] Downloaded serde_qs v0.8.5 [INFO] [stderr] Downloaded actix-web-httpauth v0.8.2 [INFO] [stderr] Downloaded float_eq v1.0.1 [INFO] [stderr] Downloaded polyline v0.11.0 [INFO] [stderr] Downloaded arcstr v1.2.0 [INFO] [stderr] Downloaded sluice v0.5.5 [INFO] [stderr] Downloaded http-client v6.5.3 [INFO] [stderr] Downloaded net2 v0.2.39 [INFO] [stderr] Downloaded earcutr v0.4.3 [INFO] [stderr] Downloaded tokio-tls v0.3.1 [INFO] [stderr] Downloaded deadpool-postgres v0.14.1 [INFO] [stderr] Downloaded i_key_sort v0.2.0 [INFO] [stderr] Downloaded i_float v1.3.1 [INFO] [stderr] Downloaded rusty_pool v0.7.0 [INFO] [stderr] Downloaded native-tls v0.2.18 [INFO] [stderr] Downloaded ctr v0.6.0 [INFO] [stderr] Downloaded hmac v0.10.1 [INFO] [stderr] Downloaded infer v0.2.3 [INFO] [stderr] Downloaded cc v1.2.54 [INFO] [stderr] Downloaded hyper-tls v0.4.3 [INFO] [stderr] Downloaded hkdf v0.10.0 [INFO] [stderr] Downloaded tokio-pg-mapper v0.2.0 [INFO] [stderr] Downloaded postgres-protocol v0.6.9 [INFO] [stderr] Downloaded postgres-types v0.2.11 [INFO] [stderr] Downloaded whoami v2.0.2 [INFO] [stderr] Downloaded value-bag v1.12.0 [INFO] [stderr] Downloaded i_tree v0.8.3 [INFO] [stderr] Downloaded mac_address v1.1.7 [INFO] [stderr] Downloaded crypto-mac v0.10.0 [INFO] [stderr] Downloaded http-types v2.12.0 [INFO] [stderr] Downloaded curl-sys v0.4.85+curl-8.18.0 [INFO] [stderr] Downloaded libnghttp2-sys v0.1.12+1.68.0 [INFO] [stderr] Downloaded h3o v0.7.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7856832af123fc9082728f57b82eaaf2c70bab9c5436b3c6d0752ce319f6594c [INFO] running `Command { std: "docker" "start" "-a" "7856832af123fc9082728f57b82eaaf2c70bab9c5436b3c6d0752ce319f6594c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7856832af123fc9082728f57b82eaaf2c70bab9c5436b3c6d0752ce319f6594c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7856832af123fc9082728f57b82eaaf2c70bab9c5436b3c6d0752ce319f6594c", kill_on_drop: false }` [INFO] [stdout] 7856832af123fc9082728f57b82eaaf2c70bab9c5436b3c6d0752ce319f6594c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bbecba929090c25e68e09f80f7a2e56913f1f7831e610109d88314bb84c6f21 [INFO] running `Command { std: "docker" "start" "-a" "3bbecba929090c25e68e09f80f7a2e56913f1f7831e610109d88314bb84c6f21", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.101 [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Checking value-bag v1.12.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling icu_properties_data v2.1.1 [INFO] [stderr] Checking parking v2.2.1 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Compiling zmij v1.0.16 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.108 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking universal-hash v0.4.0 [INFO] [stderr] Compiling jobserver v0.1.31 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Compiling const_fn v0.4.11 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking cpuid-bool v0.2.0 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking rstar v0.12.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking polyval v0.4.5 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling rand_core v0.9.3 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking aes-soft v0.6.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking piper v0.2.4 [INFO] [stderr] Checking crypto-mac v0.10.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Compiling tracing v0.1.40 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking aes v0.6.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hmac v0.10.1 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Compiling wasm-bindgen v0.2.108 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking ghash v0.3.1 [INFO] [stderr] Checking brotli-decompressor v5.0.0 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling aws-lc-sys v0.37.0 [INFO] [stderr] Compiling libnghttp2-sys v0.1.12+1.68.0 [INFO] [stderr] Compiling libz-sys v1.1.23 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling curl-sys v0.4.85+curl-8.18.0 [INFO] [stderr] Checking ctr v0.6.0 [INFO] [stderr] Compiling bytestring v1.3.1 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking aead v0.3.2 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling cookie v0.14.4 [INFO] [stderr] Compiling cookie v0.16.2 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling futures-core v0.3.31 [INFO] [stderr] Compiling curl v0.4.49 [INFO] [stderr] Checking zerocopy v0.7.34 [INFO] [stderr] Compiling futures-sink v0.3.31 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling regex-lite v0.1.5 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking postgres-protocol v0.6.9 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking aes-gcm v0.8.0 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking brotli v8.0.2 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking hkdf v0.10.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking local-channel v0.1.5 [INFO] [stderr] Checking phf_shared v0.13.1 [INFO] [stderr] Checking http-body v0.3.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking spinning_top v0.2.5 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.108 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Compiling actix-router v0.5.3 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling http-types v2.12.0 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling isahc v0.9.14 [INFO] [stderr] Checking httpdate v0.3.2 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Checking async-std v1.13.2 [INFO] [stderr] Checking phf v0.13.1 [INFO] [stderr] Checking flume v0.9.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking sluice v0.5.5 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking i_key_sort v0.2.0 [INFO] [stderr] Checking infer v0.2.3 [INFO] [stderr] Checking i_tree v0.8.3 [INFO] [stderr] Checking whoami v2.0.2 [INFO] [stderr] Checking impl-more v0.1.9 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Compiling postgres-types v0.2.11 [INFO] [stderr] Compiling futures-util v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling pin-project-internal v1.1.10 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.108 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling actix-macros v0.2.4 [INFO] [stderr] Checking pin-project v1.1.10 [INFO] [stderr] Compiling actix-web-codegen v4.3.0 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Checking tracing-futures v0.2.5 [INFO] [stderr] Compiling tokio-util v0.7.11 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking js-sys v0.3.85 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking spade v2.12.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking phf_shared v0.12.1 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Compiling parse-size v1.1.0 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Compiling actix-multipart-derive v0.7.0 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Compiling tokio-postgres v0.7.16 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking h2 v0.2.7 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking phf v0.12.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking geo-types v0.7.14 [INFO] [stderr] Checking i_float v1.3.1 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking actix-rt v2.11.0 [INFO] [stderr] Checking serde_qs v0.8.5 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking actix-server v2.6.0 [INFO] [stderr] Checking i_shape v1.3.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking deadpool-runtime v0.1.4 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking tokio-tls v0.3.1 [INFO] [stderr] Checking i_overlay v1.7.4 [INFO] [stderr] Checking deadpool v0.12.3 [INFO] [stderr] Checking toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking serde_plain v1.0.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking web-sys v0.3.85 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking geo v0.29.2 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Checking serde_spanned v1.0.4 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking float_eq v1.0.1 [INFO] [stderr] Checking toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Checking xml-rs v0.8.28 [INFO] [stderr] Checking arcstr v1.2.0 [INFO] [stderr] Checking h3o-bit v0.1.1 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking toml v0.9.11+spec-1.1.0 [INFO] [stderr] Checking rusty_pool v0.7.0 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking flume v0.12.0 [INFO] [stderr] Compiling tokio-pg-mapper-derive v0.2.0 [INFO] [stderr] Checking chrono-tz v0.10.4 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking tokio_schedule v0.3.2 [INFO] [stderr] Checking serde_with v3.16.1 [INFO] [stderr] Checking mac_address v1.1.7 [INFO] [stderr] Checking gpx v0.10.0 [INFO] [stderr] Checking deadpool-postgres v0.14.1 [INFO] [stderr] Checking tokio-pg-mapper v0.2.0 [INFO] [stderr] Checking polyline v0.11.0 [INFO] [stderr] Checking geojson v0.24.1 [INFO] [stderr] Checking ipnetwork v0.20.0 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking clusters v1.0.0 (https://github.com/savish/clusters?tag=v1.0.0#bad0c559) [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking h3o v0.7.0 [INFO] [stderr] Checking hyper v0.13.10 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking redis v1.0.2 [INFO] [stderr] Checking actix-http v3.11.2 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking actix-web v4.12.1 [INFO] [stderr] Checking hyper-tls v0.4.3 [INFO] [stderr] Checking http-client v6.5.3 [INFO] [stderr] Checking surf v2.3.2 [INFO] [stderr] Checking actix-multipart v0.7.2 [INFO] [stderr] Checking actix-web-httpauth v0.8.2 [INFO] [stderr] Compiling aws-lc-rs v1.15.4 [INFO] [stderr] Checking rustls-webpki v0.103.7 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking rustls-platform-verifier v0.6.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking reqwest v0.13.1 [INFO] [stderr] Checking locator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/config/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod config; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/blobasaur/cmd.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | ... e.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/blobasaur/cmd.rs:103:38 [INFO] [stdout] | [INFO] [stdout] 103 | ... e.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/db/pg/bulk_insert.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Some(pg_err) = e.as_db_error() { [INFO] [stdout] 91 | | if pg_err.code().code() == "40P01" && _retries < MAX_RETRIES { [INFO] [stdout] 92 | | info!("deadlock detected, retrying... Attempt {}", _retries + 1,); [INFO] [stdout] 93 | | _retries = _retries + 1; [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Some(pg_err) = e.as_db_error() [INFO] [stdout] 91 ~ && pg_err.code().code() == "40P01" && _retries < MAX_RETRIES { [INFO] [stdout] 92 | info!("deadlock detected, retrying... Attempt {}", _retries + 1,); [INFO] [stdout] ... [INFO] [stdout] 95 | continue; [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/db/pg/bulk_insert.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | _retries = _retries + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `_retries += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/pg/mod.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 173 | let statement = transaction.prepare(&query).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/pg/mod.rs:201:41 [INFO] [stdout] | [INFO] [stdout] 201 | let statement = transaction.prepare(&query).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/db/pg/mod.rs:359:25 [INFO] [stdout] | [INFO] [stdout] 359 | / if !psp.contains(&ap.child) && geo_fence.is_none() { [INFO] [stdout] 360 | | if let Ok(date) = ap.date() { [INFO] [stdout] 361 | | // future partitions cannot be detached [INFO] [stdout] 362 | | if date < now { [INFO] [stdout] ... | [INFO] [stdout] 370 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 359 ~ if !psp.contains(&ap.child) && geo_fence.is_none() [INFO] [stdout] 360 ~ && let Ok(date) = ap.date() { [INFO] [stdout] 361 | // future partitions cannot be detached [INFO] [stdout] ... [INFO] [stdout] 368 | } [INFO] [stdout] 369 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/db/pg/mod.rs:598:14 [INFO] [stdout] | [INFO] [stdout] 598 | .map(|row| RangeId::from(row)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `RangeId::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/db/pg/mod.rs:648:1 [INFO] [stdout] | [INFO] [stdout] 648 | / pub async fn insert_cell( [INFO] [stdout] 649 | | transaction: &Transaction<'_>, [INFO] [stdout] 650 | | radio: i16, [INFO] [stdout] 651 | | country: i16, [INFO] [stdout] ... | [INFO] [stdout] 656 | | tl: TransmitterLocation, [INFO] [stdout] 657 | | ) -> Result { [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/cmd.rs:126:78 [INFO] [stdout] | [INFO] [stdout] 126 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/config/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod config; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/cmd.rs:182:78 [INFO] [stdout] | [INFO] [stdout] 182 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:67:78 [INFO] [stdout] | [INFO] [stdout] 67 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | / match v { [INFO] [stdout] 90 | | redis::Value::Array(array) => { [INFO] [stdout] 91 | | for v2 in array { [INFO] [stdout] 92 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 175 | | _ => {} [INFO] [stdout] 176 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 90 + for v2 in array { [INFO] [stdout] 91 + match v2 { [INFO] [stdout] 92 + redis::Value::Array(array2) => { [INFO] [stdout] 93 + for v3 in array2 { [INFO] [stdout] 94 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 95 + if v4.len() < 4 { [INFO] [stdout] 96 + continue; [INFO] [stdout] 97 + } [INFO] [stdout] 98 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 99 + let mac = [INFO] [stdout] 100 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 101 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 102 + let ylr_str = [INFO] [stdout] 103 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 104 + let ylr: YandexLbsResponse = [INFO] [stdout] 105 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 106 + [INFO] [stdout] 107 + if let Err(e) = set_ba_lbs_yandex_wifi_one( [INFO] [stdout] 108 + tx_ba_conn.clone(), [INFO] [stdout] 109 + Collection::BaLbsYandexWifi.as_ref(), [INFO] [stdout] 110 + ylr, [INFO] [stdout] 111 + &mac, [INFO] [stdout] 112 + ) [INFO] [stdout] 113 + .await [INFO] [stdout] 114 + { [INFO] [stdout] 115 + println!( [INFO] [stdout] 116 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 117 + ); [INFO] [stdout] 118 + } [INFO] [stdout] 119 + i2 += 1; [INFO] [stdout] 120 + [INFO] [stdout] 121 + // if ylr.location.accuracy == 150.0 { [INFO] [stdout] 122 + // println!("mac: {}", mac); [INFO] [stdout] 123 + // println!("ylr: {:?}", ylr); [INFO] [stdout] 124 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 125 + // tx_t38_conn.clone(), [INFO] [stdout] 126 + // "lbs:yandex:wifi", [INFO] [stdout] 127 + // &mac, [INFO] [stdout] 128 + // ) [INFO] [stdout] 129 + // .await; [INFO] [stdout] 130 + // } [INFO] [stdout] 131 + [INFO] [stdout] 132 + // if true { [INFO] [stdout] 133 + // all_count += 1; [INFO] [stdout] 134 + // let ps = format!( [INFO] [stdout] 135 + // "{}", [INFO] [stdout] 136 + // ylr.location.point.lat [INFO] [stdout] 137 + // ); [INFO] [stdout] 138 + // let ps2 = format!( [INFO] [stdout] 139 + // "{}", [INFO] [stdout] 140 + // ylr.location.point.lon [INFO] [stdout] 141 + // ); [INFO] [stdout] 142 + // if ps.len() <= 9 || ps2.len() <= 9 { [INFO] [stdout] 143 + // // DEBUG [INFO] [stdout] 144 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 145 + // println!("mac: {}", mac); [INFO] [stdout] 146 + // println!( [INFO] [stdout] 147 + // "ylr: {:?}", [INFO] [stdout] 148 + // ylr.location.point [INFO] [stdout] 149 + // ); [INFO] [stdout] 150 + // del_wifi_one( [INFO] [stdout] 151 + // tx_t38_conn.clone(), [INFO] [stdout] 152 + // "wifi", [INFO] [stdout] 153 + // &mac, [INFO] [stdout] 154 + // ) [INFO] [stdout] 155 + // .await; [INFO] [stdout] 156 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 157 + // tx_t38_conn.clone(), [INFO] [stdout] 158 + // "lbs:yandex:wifi", [INFO] [stdout] 159 + // &mac, [INFO] [stdout] 160 + // ) [INFO] [stdout] 161 + // .await; [INFO] [stdout] 162 + // i2 += 1; [INFO] [stdout] 163 + // } [INFO] [stdout] 164 + // } [INFO] [stdout] 165 + } [INFO] [stdout] 166 + } [INFO] [stdout] 167 + } [INFO] [stdout] 168 + } [INFO] [stdout] 169 + } [INFO] [stdout] 170 + _ => {} [INFO] [stdout] 171 + } [INFO] [stdout] 172 + } [INFO] [stdout] 173 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:92:33 [INFO] [stdout] | [INFO] [stdout] 92 | / ... match v2 { [INFO] [stdout] 93 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 94 | | ... for v3 in array2 { [INFO] [stdout] 95 | | ... if let redis::Value::Array(v4) = v3 { [INFO] [stdout] ... | [INFO] [stdout] 171 | | ... _ => {} [INFO] [stdout] 172 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 93 + for v3 in array2 { [INFO] [stdout] 94 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 95 + if v4.len() < 4 { [INFO] [stdout] 96 + continue; [INFO] [stdout] 97 + } [INFO] [stdout] 98 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 99 + let mac = [INFO] [stdout] 100 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 101 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 102 + let ylr_str = [INFO] [stdout] 103 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 104 + let ylr: YandexLbsResponse = [INFO] [stdout] 105 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 106 + [INFO] [stdout] 107 + if let Err(e) = set_ba_lbs_yandex_wifi_one( [INFO] [stdout] 108 + tx_ba_conn.clone(), [INFO] [stdout] 109 + Collection::BaLbsYandexWifi.as_ref(), [INFO] [stdout] 110 + ylr, [INFO] [stdout] 111 + &mac, [INFO] [stdout] 112 + ) [INFO] [stdout] 113 + .await [INFO] [stdout] 114 + { [INFO] [stdout] 115 + println!( [INFO] [stdout] 116 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 117 + ); [INFO] [stdout] 118 + } [INFO] [stdout] 119 + i2 += 1; [INFO] [stdout] 120 + [INFO] [stdout] 121 + // if ylr.location.accuracy == 150.0 { [INFO] [stdout] 122 + // println!("mac: {}", mac); [INFO] [stdout] 123 + // println!("ylr: {:?}", ylr); [INFO] [stdout] 124 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 125 + // tx_t38_conn.clone(), [INFO] [stdout] 126 + // "lbs:yandex:wifi", [INFO] [stdout] 127 + // &mac, [INFO] [stdout] 128 + // ) [INFO] [stdout] 129 + // .await; [INFO] [stdout] 130 + // } [INFO] [stdout] 131 + [INFO] [stdout] 132 + // if true { [INFO] [stdout] 133 + // all_count += 1; [INFO] [stdout] 134 + // let ps = format!( [INFO] [stdout] 135 + // "{}", [INFO] [stdout] 136 + // ylr.location.point.lat [INFO] [stdout] 137 + // ); [INFO] [stdout] 138 + // let ps2 = format!( [INFO] [stdout] 139 + // "{}", [INFO] [stdout] 140 + // ylr.location.point.lon [INFO] [stdout] 141 + // ); [INFO] [stdout] 142 + // if ps.len() <= 9 || ps2.len() <= 9 { [INFO] [stdout] 143 + // // DEBUG [INFO] [stdout] 144 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 145 + // println!("mac: {}", mac); [INFO] [stdout] 146 + // println!( [INFO] [stdout] 147 + // "ylr: {:?}", [INFO] [stdout] 148 + // ylr.location.point [INFO] [stdout] 149 + // ); [INFO] [stdout] 150 + // del_wifi_one( [INFO] [stdout] 151 + // tx_t38_conn.clone(), [INFO] [stdout] 152 + // "wifi", [INFO] [stdout] 153 + // &mac, [INFO] [stdout] 154 + // ) [INFO] [stdout] 155 + // .await; [INFO] [stdout] 156 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 157 + // tx_t38_conn.clone(), [INFO] [stdout] 158 + // "lbs:yandex:wifi", [INFO] [stdout] 159 + // &mac, [INFO] [stdout] 160 + // ) [INFO] [stdout] 161 + // .await; [INFO] [stdout] 162 + // i2 += 1; [INFO] [stdout] 163 + // } [INFO] [stdout] 164 + // } [INFO] [stdout] 165 + } [INFO] [stdout] 166 + } [INFO] [stdout] 167 + } [INFO] [stdout] 168 + } [INFO] [stdout] 169 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:230:78 [INFO] [stdout] | [INFO] [stdout] 230 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:251:21 [INFO] [stdout] | [INFO] [stdout] 251 | / match v { [INFO] [stdout] 252 | | redis::Value::Array(array) => { [INFO] [stdout] 253 | | for v2 in array { [INFO] [stdout] 254 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 315 | | _ => {} [INFO] [stdout] 316 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 251 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 252 + for v2 in array { [INFO] [stdout] 253 + match v2 { [INFO] [stdout] 254 + redis::Value::Array(array2) => { [INFO] [stdout] 255 + for v3 in array2 { [INFO] [stdout] 256 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 257 + if v4.len() < 4 { [INFO] [stdout] 258 + continue; [INFO] [stdout] 259 + } [INFO] [stdout] 260 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 261 + let mac = [INFO] [stdout] 262 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 263 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 264 + let tl_str = [INFO] [stdout] 265 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 266 + let tl: TransmitterLocation = [INFO] [stdout] 267 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 268 + [INFO] [stdout] 269 + if let Err(e) = set_ba_wifi_one( [INFO] [stdout] 270 + tx_ba_conn.clone(), [INFO] [stdout] 271 + Collection::BaWifi.as_ref(), [INFO] [stdout] 272 + &tl, [INFO] [stdout] 273 + ) [INFO] [stdout] 274 + .await [INFO] [stdout] 275 + { [INFO] [stdout] 276 + println!( [INFO] [stdout] 277 + "ERROR save TransmitterLocation to blobasaur" [INFO] [stdout] 278 + ); [INFO] [stdout] 279 + } [INFO] [stdout] 280 + i += 1; [INFO] [stdout] 281 + [INFO] [stdout] 282 + // if tl.lat >= 43.7 [INFO] [stdout] 283 + // && tl.lat <= 44.999 [INFO] [stdout] 284 + // && tl.lon >= 36.999 [INFO] [stdout] 285 + // && tl.lon <= 38.111 [INFO] [stdout] 286 + // { [INFO] [stdout] 287 + // // DEBUG [INFO] [stdout] 288 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 289 + // println!("mac: {}", mac); [INFO] [stdout] 290 + // println!("tl: {:?}", tl); [INFO] [stdout] 291 + // del_wifi_one( [INFO] [stdout] 292 + // tx_t38_conn.clone(), [INFO] [stdout] 293 + // "wifi", [INFO] [stdout] 294 + // &mac, [INFO] [stdout] 295 + // ) [INFO] [stdout] 296 + // .await; [INFO] [stdout] 297 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 298 + // tx_t38_conn.clone(), [INFO] [stdout] 299 + // "lbs:yandex:wifi", [INFO] [stdout] 300 + // &mac, [INFO] [stdout] 301 + // ) [INFO] [stdout] 302 + // .await; [INFO] [stdout] 303 + // i += 1; [INFO] [stdout] 304 + // } [INFO] [stdout] 305 + } [INFO] [stdout] 306 + } [INFO] [stdout] 307 + } [INFO] [stdout] 308 + } [INFO] [stdout] 309 + } [INFO] [stdout] 310 + _ => {} [INFO] [stdout] 311 + } [INFO] [stdout] 312 + } [INFO] [stdout] 313 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:254:33 [INFO] [stdout] | [INFO] [stdout] 254 | / ... match v2 { [INFO] [stdout] 255 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 256 | | ... for v3 in array2 { [INFO] [stdout] 257 | | ... if let redis::Value::Array(v4) = v3 { [INFO] [stdout] ... | [INFO] [stdout] 311 | | ... _ => {} [INFO] [stdout] 312 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 254 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 255 + for v3 in array2 { [INFO] [stdout] 256 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 257 + if v4.len() < 4 { [INFO] [stdout] 258 + continue; [INFO] [stdout] 259 + } [INFO] [stdout] 260 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 261 + let mac = [INFO] [stdout] 262 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 263 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 264 + let tl_str = [INFO] [stdout] 265 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 266 + let tl: TransmitterLocation = [INFO] [stdout] 267 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 268 + [INFO] [stdout] 269 + if let Err(e) = set_ba_wifi_one( [INFO] [stdout] 270 + tx_ba_conn.clone(), [INFO] [stdout] 271 + Collection::BaWifi.as_ref(), [INFO] [stdout] 272 + &tl, [INFO] [stdout] 273 + ) [INFO] [stdout] 274 + .await [INFO] [stdout] 275 + { [INFO] [stdout] 276 + println!( [INFO] [stdout] 277 + "ERROR save TransmitterLocation to blobasaur" [INFO] [stdout] 278 + ); [INFO] [stdout] 279 + } [INFO] [stdout] 280 + i += 1; [INFO] [stdout] 281 + [INFO] [stdout] 282 + // if tl.lat >= 43.7 [INFO] [stdout] 283 + // && tl.lat <= 44.999 [INFO] [stdout] 284 + // && tl.lon >= 36.999 [INFO] [stdout] 285 + // && tl.lon <= 38.111 [INFO] [stdout] 286 + // { [INFO] [stdout] 287 + // // DEBUG [INFO] [stdout] 288 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 289 + // println!("mac: {}", mac); [INFO] [stdout] 290 + // println!("tl: {:?}", tl); [INFO] [stdout] 291 + // del_wifi_one( [INFO] [stdout] 292 + // tx_t38_conn.clone(), [INFO] [stdout] 293 + // "wifi", [INFO] [stdout] 294 + // &mac, [INFO] [stdout] 295 + // ) [INFO] [stdout] 296 + // .await; [INFO] [stdout] 297 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 298 + // tx_t38_conn.clone(), [INFO] [stdout] 299 + // "lbs:yandex:wifi", [INFO] [stdout] 300 + // &mac, [INFO] [stdout] 301 + // ) [INFO] [stdout] 302 + // .await; [INFO] [stdout] 303 + // i += 1; [INFO] [stdout] 304 + // } [INFO] [stdout] 305 + } [INFO] [stdout] 306 + } [INFO] [stdout] 307 + } [INFO] [stdout] 308 + } [INFO] [stdout] 309 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:372:78 [INFO] [stdout] | [INFO] [stdout] 372 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:394:21 [INFO] [stdout] | [INFO] [stdout] 394 | / match v { [INFO] [stdout] 395 | | redis::Value::Array(array) => { [INFO] [stdout] 396 | | for v2 in array { [INFO] [stdout] 397 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 430 | | _ => {} [INFO] [stdout] 431 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 394 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 395 + for v2 in array { [INFO] [stdout] 396 + match v2 { [INFO] [stdout] 397 + redis::Value::Array(array2) => { [INFO] [stdout] 398 + if let redis::Value::BulkString(s) = &array2[0] { [INFO] [stdout] 399 + let cell_code = String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 400 + if let redis::Value::BulkString(s1) = &array2[1] { [INFO] [stdout] 401 + let ylr_str = [INFO] [stdout] 402 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 403 + [INFO] [stdout] 404 + let dc: DataCell = [INFO] [stdout] 405 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 406 + let ylr: YandexLbsResponse = [INFO] [stdout] 407 + serde_json::from_str(&dc.data).unwrap(); [INFO] [stdout] 408 + [INFO] [stdout] 409 + if let Err(e) = set_ba_lbs_yandex_cell_one( [INFO] [stdout] 410 + tx_ba_conn.clone(), [INFO] [stdout] 411 + Collection::BaLbsYandexCell.as_ref(), [INFO] [stdout] 412 + ylr, [INFO] [stdout] 413 + &cell_code, [INFO] [stdout] 414 + ) [INFO] [stdout] 415 + .await [INFO] [stdout] 416 + { [INFO] [stdout] 417 + println!( [INFO] [stdout] 418 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 419 + ); [INFO] [stdout] 420 + } [INFO] [stdout] 421 + i2 += 1; [INFO] [stdout] 422 + } [INFO] [stdout] 423 + } [INFO] [stdout] 424 + } [INFO] [stdout] 425 + _ => {} [INFO] [stdout] 426 + } [INFO] [stdout] 427 + } [INFO] [stdout] 428 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:397:33 [INFO] [stdout] | [INFO] [stdout] 397 | / ... match v2 { [INFO] [stdout] 398 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 399 | | ... if let redis::Value::BulkString(s) = &array2[0] { [INFO] [stdout] 400 | | ... let cell_code = String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 426 | | ... _ => {} [INFO] [stdout] 427 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 397 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 398 + if let redis::Value::BulkString(s) = &array2[0] { [INFO] [stdout] 399 + let cell_code = String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 400 + if let redis::Value::BulkString(s1) = &array2[1] { [INFO] [stdout] 401 + let ylr_str = [INFO] [stdout] 402 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 403 + [INFO] [stdout] 404 + let dc: DataCell = [INFO] [stdout] 405 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 406 + let ylr: YandexLbsResponse = [INFO] [stdout] 407 + serde_json::from_str(&dc.data).unwrap(); [INFO] [stdout] 408 + [INFO] [stdout] 409 + if let Err(e) = set_ba_lbs_yandex_cell_one( [INFO] [stdout] 410 + tx_ba_conn.clone(), [INFO] [stdout] 411 + Collection::BaLbsYandexCell.as_ref(), [INFO] [stdout] 412 + ylr, [INFO] [stdout] 413 + &cell_code, [INFO] [stdout] 414 + ) [INFO] [stdout] 415 + .await [INFO] [stdout] 416 + { [INFO] [stdout] 417 + println!( [INFO] [stdout] 418 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 419 + ); [INFO] [stdout] 420 + } [INFO] [stdout] 421 + i2 += 1; [INFO] [stdout] 422 + } [INFO] [stdout] 423 + } [INFO] [stdout] 424 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:480:78 [INFO] [stdout] | [INFO] [stdout] 480 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:501:21 [INFO] [stdout] | [INFO] [stdout] 501 | / match v { [INFO] [stdout] 502 | | redis::Value::Array(array) => { [INFO] [stdout] 503 | | for v2 in array { [INFO] [stdout] 504 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 579 | | _ => {} [INFO] [stdout] 580 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 501 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 502 + for v2 in array { [INFO] [stdout] 503 + match v2 { [INFO] [stdout] 504 + redis::Value::Array(array2) => { [INFO] [stdout] 505 + for v3 in array2 { [INFO] [stdout] 506 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 507 + if v4.len() < 4 { [INFO] [stdout] 508 + continue; [INFO] [stdout] 509 + } [INFO] [stdout] 510 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 511 + let mac = [INFO] [stdout] 512 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 513 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 514 + let tl_str = [INFO] [stdout] 515 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 516 + let tl: TransmitterLocation = [INFO] [stdout] 517 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 518 + [INFO] [stdout] 519 + match get_yandex_lbs_wifi_one( [INFO] [stdout] 520 + tx_t38_conn.clone(), [INFO] [stdout] 521 + "lbs:yandex:wifi", [INFO] [stdout] 522 + &mac, [INFO] [stdout] 523 + ) [INFO] [stdout] 524 + .await [INFO] [stdout] 525 + { [INFO] [stdout] 526 + Err(_e) => {} [INFO] [stdout] 527 + Ok(w) => { [INFO] [stdout] 528 + if let Some(ylr) = w { [INFO] [stdout] 529 + let p_yandex = Point { [INFO] [stdout] 530 + id: 0, [INFO] [stdout] 531 + lat: ylr.location.point.lat, [INFO] [stdout] 532 + lon: ylr.location.point.lon, [INFO] [stdout] 533 + }; [INFO] [stdout] 534 + let p_tl = Point { [INFO] [stdout] 535 + id: 1, [INFO] [stdout] 536 + lat: tl.lat, [INFO] [stdout] 537 + lon: tl.lon, [INFO] [stdout] 538 + }; [INFO] [stdout] 539 + let d = [INFO] [stdout] 540 + p_yandex.distance(&p_tl); [INFO] [stdout] 541 + if d > MAX_DISTANCE_REPORT_LBS { [INFO] [stdout] 542 + // DEBUG [INFO] [stdout] 543 + // TODO: remove after tests by Whoosh [INFO] [stdout] 544 + println!("d mac: {}", mac); [INFO] [stdout] 545 + println!("d tl: {:?}", tl); [INFO] [stdout] 546 + del_wifi_one( [INFO] [stdout] 547 + tx_t38_conn.clone(), [INFO] [stdout] 548 + "wifi", [INFO] [stdout] 549 + &mac, [INFO] [stdout] 550 + ) [INFO] [stdout] 551 + .await; [INFO] [stdout] 552 + i += 1; [INFO] [stdout] 553 + } [INFO] [stdout] 554 + } else { [INFO] [stdout] 555 + // DEBUG [INFO] [stdout] 556 + // TODO: remove after tests by Whoosh [INFO] [stdout] 557 + println!("none mac: {}", mac); [INFO] [stdout] 558 + println!("none tl: {:?}", tl); [INFO] [stdout] 559 + del_wifi_one( [INFO] [stdout] 560 + tx_t38_conn.clone(), [INFO] [stdout] 561 + "wifi", [INFO] [stdout] 562 + &mac, [INFO] [stdout] 563 + ) [INFO] [stdout] 564 + .await; [INFO] [stdout] 565 + i += 1; [INFO] [stdout] 566 + } [INFO] [stdout] 567 + } [INFO] [stdout] 568 + } [INFO] [stdout] 569 + } [INFO] [stdout] 570 + } [INFO] [stdout] 571 + } [INFO] [stdout] 572 + } [INFO] [stdout] 573 + } [INFO] [stdout] 574 + _ => {} [INFO] [stdout] 575 + } [INFO] [stdout] 576 + } [INFO] [stdout] 577 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:504:33 [INFO] [stdout] | [INFO] [stdout] 504 | / ... match v2 { [INFO] [stdout] 505 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 506 | | ... for v3 in array2 { [INFO] [stdout] 507 | | ... if let redis::Value::Array(v4) = v3 { [INFO] [stdout] ... | [INFO] [stdout] 575 | | ... _ => {} [INFO] [stdout] 576 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 504 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 505 + for v3 in array2 { [INFO] [stdout] 506 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 507 + if v4.len() < 4 { [INFO] [stdout] 508 + continue; [INFO] [stdout] 509 + } [INFO] [stdout] 510 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 511 + let mac = [INFO] [stdout] 512 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 513 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 514 + let tl_str = [INFO] [stdout] 515 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 516 + let tl: TransmitterLocation = [INFO] [stdout] 517 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 518 + [INFO] [stdout] 519 + match get_yandex_lbs_wifi_one( [INFO] [stdout] 520 + tx_t38_conn.clone(), [INFO] [stdout] 521 + "lbs:yandex:wifi", [INFO] [stdout] 522 + &mac, [INFO] [stdout] 523 + ) [INFO] [stdout] 524 + .await [INFO] [stdout] 525 + { [INFO] [stdout] 526 + Err(_e) => {} [INFO] [stdout] 527 + Ok(w) => { [INFO] [stdout] 528 + if let Some(ylr) = w { [INFO] [stdout] 529 + let p_yandex = Point { [INFO] [stdout] 530 + id: 0, [INFO] [stdout] 531 + lat: ylr.location.point.lat, [INFO] [stdout] 532 + lon: ylr.location.point.lon, [INFO] [stdout] 533 + }; [INFO] [stdout] 534 + let p_tl = Point { [INFO] [stdout] 535 + id: 1, [INFO] [stdout] 536 + lat: tl.lat, [INFO] [stdout] 537 + lon: tl.lon, [INFO] [stdout] 538 + }; [INFO] [stdout] 539 + let d = [INFO] [stdout] 540 + p_yandex.distance(&p_tl); [INFO] [stdout] 541 + if d > MAX_DISTANCE_REPORT_LBS { [INFO] [stdout] 542 + // DEBUG [INFO] [stdout] 543 + // TODO: remove after tests by Whoosh [INFO] [stdout] 544 + println!("d mac: {}", mac); [INFO] [stdout] 545 + println!("d tl: {:?}", tl); [INFO] [stdout] 546 + del_wifi_one( [INFO] [stdout] 547 + tx_t38_conn.clone(), [INFO] [stdout] 548 + "wifi", [INFO] [stdout] 549 + &mac, [INFO] [stdout] 550 + ) [INFO] [stdout] 551 + .await; [INFO] [stdout] 552 + i += 1; [INFO] [stdout] 553 + } [INFO] [stdout] 554 + } else { [INFO] [stdout] 555 + // DEBUG [INFO] [stdout] 556 + // TODO: remove after tests by Whoosh [INFO] [stdout] 557 + println!("none mac: {}", mac); [INFO] [stdout] 558 + println!("none tl: {:?}", tl); [INFO] [stdout] 559 + del_wifi_one( [INFO] [stdout] 560 + tx_t38_conn.clone(), [INFO] [stdout] 561 + "wifi", [INFO] [stdout] 562 + &mac, [INFO] [stdout] 563 + ) [INFO] [stdout] 564 + .await; [INFO] [stdout] 565 + i += 1; [INFO] [stdout] 566 + } [INFO] [stdout] 567 + } [INFO] [stdout] 568 + } [INFO] [stdout] 569 + } [INFO] [stdout] 570 + } [INFO] [stdout] 571 + } [INFO] [stdout] 572 + } [INFO] [stdout] 573 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:631:78 [INFO] [stdout] | [INFO] [stdout] 631 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:651:21 [INFO] [stdout] | [INFO] [stdout] 651 | / match v { [INFO] [stdout] 652 | | redis::Value::Array(array) => { [INFO] [stdout] 653 | | let mut ids = Vec::with_capacity(array.len()); [INFO] [stdout] 654 | | for id_value in array { [INFO] [stdout] ... | [INFO] [stdout] 665 | | _ => {} [INFO] [stdout] 666 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 651 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 652 + let mut ids = Vec::with_capacity(array.len()); [INFO] [stdout] 653 + for id_value in array { [INFO] [stdout] 654 + match id_value { [INFO] [stdout] 655 + redis::Value::BulkString(bulk_string) => { [INFO] [stdout] 656 + let id = String::from_utf8(bulk_string).unwrap(); [INFO] [stdout] 657 + ids.push(id); [INFO] [stdout] 658 + } [INFO] [stdout] 659 + _ => {} [INFO] [stdout] 660 + } [INFO] [stdout] 661 + } [INFO] [stdout] 662 + return Ok(ids); [INFO] [stdout] 663 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:655:33 [INFO] [stdout] | [INFO] [stdout] 655 | / ... match id_value { [INFO] [stdout] 656 | | ... redis::Value::BulkString(bulk_string) => { [INFO] [stdout] 657 | | ... let id = String::from_utf8(bulk_string).unwrap(); [INFO] [stdout] 658 | | ... ids.push(id); [INFO] [stdout] 659 | | ... } [INFO] [stdout] 660 | | ... _ => {} [INFO] [stdout] 661 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 655 ~ if let redis::Value::BulkString(bulk_string) = id_value { [INFO] [stdout] 656 + let id = String::from_utf8(bulk_string).unwrap(); [INFO] [stdout] 657 + ids.push(id); [INFO] [stdout] 658 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/mod.rs:474:5 [INFO] [stdout] | [INFO] [stdout] 474 | / match scan_result { [INFO] [stdout] 475 | | redis::Value::Array(arr) => { [INFO] [stdout] 476 | | for v in arr { [INFO] [stdout] 477 | | match v { [INFO] [stdout] ... | [INFO] [stdout] 531 | | _ => {} [INFO] [stdout] 532 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 474 ~ if let redis::Value::Array(arr) = scan_result { [INFO] [stdout] 475 + for v in arr { [INFO] [stdout] 476 + match v { [INFO] [stdout] 477 + redis::Value::Array(arr1) => { [INFO] [stdout] 478 + for v1 in arr1 { [INFO] [stdout] 479 + match v1 { [INFO] [stdout] 480 + redis::Value::Array(arr2) => { [INFO] [stdout] 481 + for v2 in arr2 { [INFO] [stdout] 482 + match v2 { [INFO] [stdout] 483 + redis::Value::Array(arr3) => { [INFO] [stdout] 484 + for (i3, v3) in arr3.iter().enumerate() { [INFO] [stdout] 485 + match v3 { [INFO] [stdout] 486 + redis::Value::BulkString(data) => { [INFO] [stdout] 487 + // i3 == 0 => field name = "data" [INFO] [stdout] 488 + if i3 == 1 { [INFO] [stdout] 489 + match serde_json::from_slice::< [INFO] [stdout] 490 + TransmitterLocation, [INFO] [stdout] 491 + >( [INFO] [stdout] 492 + &data [INFO] [stdout] 493 + ) { [INFO] [stdout] 494 + Err(err) => { [INFO] [stdout] 495 + error!( [INFO] [stdout] 496 + "deserialize tl from Tile38: {}", [INFO] [stdout] 497 + err [INFO] [stdout] 498 + ); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + Ok(tl) => { [INFO] [stdout] 501 + tls.push(tl); [INFO] [stdout] 502 + } [INFO] [stdout] 503 + } [INFO] [stdout] 504 + } [INFO] [stdout] 505 + } [INFO] [stdout] 506 + _ => {} [INFO] [stdout] 507 + } [INFO] [stdout] 508 + } [INFO] [stdout] 509 + } [INFO] [stdout] 510 + redis::Value::BulkString(_field) => { [INFO] [stdout] 511 + // fields: [INFO] [stdout] 512 + // mac String [INFO] [stdout] 513 + // geometry Object [INFO] [stdout] 514 + } [INFO] [stdout] 515 + _ => {} [INFO] [stdout] 516 + } [INFO] [stdout] 517 + } [INFO] [stdout] 518 + } [INFO] [stdout] 519 + _ => {} [INFO] [stdout] 520 + } [INFO] [stdout] 521 + } [INFO] [stdout] 522 + } [INFO] [stdout] 523 + redis::Value::Int(_i) => { [INFO] [stdout] 524 + // at first level _i == 0 [INFO] [stdout] 525 + } [INFO] [stdout] 526 + _ => {} [INFO] [stdout] 527 + } [INFO] [stdout] 528 + } [INFO] [stdout] 529 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/mod.rs:480:29 [INFO] [stdout] | [INFO] [stdout] 480 | / ... match v1 { [INFO] [stdout] 481 | | ... redis::Value::Array(arr2) => { [INFO] [stdout] 482 | | ... for v2 in arr2 { [INFO] [stdout] 483 | | ... match v2 { [INFO] [stdout] ... | [INFO] [stdout] 520 | | ... _ => {} [INFO] [stdout] 521 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 480 ~ if let redis::Value::Array(arr2) = v1 { [INFO] [stdout] 481 + for v2 in arr2 { [INFO] [stdout] 482 + match v2 { [INFO] [stdout] 483 + redis::Value::Array(arr3) => { [INFO] [stdout] 484 + for (i3, v3) in arr3.iter().enumerate() { [INFO] [stdout] 485 + match v3 { [INFO] [stdout] 486 + redis::Value::BulkString(data) => { [INFO] [stdout] 487 + // i3 == 0 => field name = "data" [INFO] [stdout] 488 + if i3 == 1 { [INFO] [stdout] 489 + match serde_json::from_slice::< [INFO] [stdout] 490 + TransmitterLocation, [INFO] [stdout] 491 + >( [INFO] [stdout] 492 + &data [INFO] [stdout] 493 + ) { [INFO] [stdout] 494 + Err(err) => { [INFO] [stdout] 495 + error!( [INFO] [stdout] 496 + "deserialize tl from Tile38: {}", [INFO] [stdout] 497 + err [INFO] [stdout] 498 + ); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + Ok(tl) => { [INFO] [stdout] 501 + tls.push(tl); [INFO] [stdout] 502 + } [INFO] [stdout] 503 + } [INFO] [stdout] 504 + } [INFO] [stdout] 505 + } [INFO] [stdout] 506 + _ => {} [INFO] [stdout] 507 + } [INFO] [stdout] 508 + } [INFO] [stdout] 509 + } [INFO] [stdout] 510 + redis::Value::BulkString(_field) => { [INFO] [stdout] 511 + // fields: [INFO] [stdout] 512 + // mac String [INFO] [stdout] 513 + // geometry Object [INFO] [stdout] 514 + } [INFO] [stdout] 515 + _ => {} [INFO] [stdout] 516 + } [INFO] [stdout] 517 + } [INFO] [stdout] 518 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/db/t38/mod.rs:489:61 [INFO] [stdout] | [INFO] [stdout] 489 | / ... if i3 == 1 { [INFO] [stdout] 490 | | ... match serde_json::from_slice::< [INFO] [stdout] 491 | | ... TransmitterLocation, [INFO] [stdout] 492 | | ... >( [INFO] [stdout] ... | [INFO] [stdout] 505 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 487 ~ redis::Value::BulkString(data) [INFO] [stdout] 488 | // i3 == 0 => field name = "data" [INFO] [stdout] 489 ~ if i3 == 1 => { [INFO] [stdout] 490 | match serde_json::from_slice::< [INFO] [stdout] ... [INFO] [stdout] 504 | } [INFO] [stdout] 505 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/mod.rs:486:53 [INFO] [stdout] | [INFO] [stdout] 486 | / ... match v3 { [INFO] [stdout] 487 | | ... redis::Value::BulkString(data) => { [INFO] [stdout] 488 | | ... // i3 == 0 => field name = "data" [INFO] [stdout] 489 | | ... if i3 == 1 { [INFO] [stdout] ... | [INFO] [stdout] 507 | | ... _ => {} [INFO] [stdout] 508 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 486 ~ if let redis::Value::BulkString(data) = v3 { [INFO] [stdout] 487 + // i3 == 0 => field name = "data" [INFO] [stdout] 488 + if i3 == 1 { [INFO] [stdout] 489 + match serde_json::from_slice::< [INFO] [stdout] 490 + TransmitterLocation, [INFO] [stdout] 491 + >( [INFO] [stdout] 492 + &data [INFO] [stdout] 493 + ) { [INFO] [stdout] 494 + Err(err) => { [INFO] [stdout] 495 + error!( [INFO] [stdout] 496 + "deserialize tl from Tile38: {}", [INFO] [stdout] 497 + err [INFO] [stdout] 498 + ); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + Ok(tl) => { [INFO] [stdout] 501 + tls.push(tl); [INFO] [stdout] 502 + } [INFO] [stdout] 503 + } [INFO] [stdout] 504 + } [INFO] [stdout] 505 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/t38/mod.rs:493:69 [INFO] [stdout] | [INFO] [stdout] 493 | ... &data [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/error/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod error; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/error/error.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 111 | let error_resp = error_response(code); [INFO] [stdout] | -------------------------------------- unnecessary `let` binding [INFO] [stdout] 112 | error_resp [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 111 ~ [INFO] [stdout] 112 ~ error_response(code) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/error/error.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 115 | / let error_resp = HttpResponse::InternalServerError().json(json!( [INFO] [stdout] 116 | | { [INFO] [stdout] 117 | | "error": { [INFO] [stdout] 118 | | "domain": domain, [INFO] [stdout] ... | [INFO] [stdout] 124 | | )); [INFO] [stdout] | |_______________- unnecessary `let` binding [INFO] [stdout] 125 | error_resp [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 115 ~ [INFO] [stdout] 116 ~ HttpResponse::InternalServerError().json(json!( [INFO] [stdout] 117 + { [INFO] [stdout] 118 + "error": { [INFO] [stdout] 119 + "domain": domain, [INFO] [stdout] 120 + "reason": "internal server error", [INFO] [stdout] 121 + "message": "", [INFO] [stdout] 122 + "code": 500, [INFO] [stdout] 123 + } [INFO] [stdout] 124 + } [INFO] [stdout] 125 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/lbs/http_client.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / pub async fn post_for_data( [INFO] [stdout] 71 | | &self, [INFO] [stdout] 72 | | key: &str, [INFO] [stdout] 73 | | url: &str, [INFO] [stdout] ... | [INFO] [stdout] 80 | | collection: &str, [INFO] [stdout] 81 | | ) -> Result<(), ApiError> { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/blobasaur/cmd.rs:59:38 [INFO] [stdout] | [INFO] [stdout] 59 | ... e.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/blobasaur/cmd.rs:103:38 [INFO] [stdout] | [INFO] [stdout] 103 | ... e.to_string() [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/db/pg/bulk_insert.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | / if let Some(pg_err) = e.as_db_error() { [INFO] [stdout] 91 | | if pg_err.code().code() == "40P01" && _retries < MAX_RETRIES { [INFO] [stdout] 92 | | info!("deadlock detected, retrying... Attempt {}", _retries + 1,); [INFO] [stdout] 93 | | _retries = _retries + 1; [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 90 ~ if let Some(pg_err) = e.as_db_error() [INFO] [stdout] 91 ~ && pg_err.code().code() == "40P01" && _retries < MAX_RETRIES { [INFO] [stdout] 92 | info!("deadlock detected, retrying... Attempt {}", _retries + 1,); [INFO] [stdout] ... [INFO] [stdout] 95 | continue; [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/db/pg/bulk_insert.rs:93:21 [INFO] [stdout] | [INFO] [stdout] 93 | _retries = _retries + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `_retries += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lbs/model.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return true; [INFO] [stdout] 169 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lbs/yandex/cell.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Err(e) = yandex_client [INFO] [stdout] 235 | | .post_for_data( [INFO] [stdout] 236 | | &cell_code, [INFO] [stdout] 237 | | &yandex_lbs_url, [INFO] [stdout] ... | [INFO] [stdout] 248 | | return Err(e); [INFO] [stdout] 249 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 234 ~ yandex_client [INFO] [stdout] 235 + .post_for_data( [INFO] [stdout] 236 + &cell_code, [INFO] [stdout] 237 + &yandex_lbs_url, [INFO] [stdout] 238 + &yandex_lbs_request, [INFO] [stdout] 239 + tx_yandex_api.clone(), [INFO] [stdout] 240 + api_key, [INFO] [stdout] 241 + &mut lbs_responses, [INFO] [stdout] 242 + tx_t38_conn.clone(), [INFO] [stdout] 243 + tx_ba_conn.clone(), [INFO] [stdout] 244 + collection, [INFO] [stdout] 245 + ) [INFO] [stdout] 246 + .await? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/pg/mod.rs:173:41 [INFO] [stdout] | [INFO] [stdout] 173 | let statement = transaction.prepare(&query).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/pg/mod.rs:201:41 [INFO] [stdout] | [INFO] [stdout] 201 | let statement = transaction.prepare(&query).await?; [INFO] [stdout] | ^^^^^^ help: change this to: `query` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/db/pg/mod.rs:359:25 [INFO] [stdout] | [INFO] [stdout] 359 | / if !psp.contains(&ap.child) && geo_fence.is_none() { [INFO] [stdout] 360 | | if let Ok(date) = ap.date() { [INFO] [stdout] 361 | | // future partitions cannot be detached [INFO] [stdout] 362 | | if date < now { [INFO] [stdout] ... | [INFO] [stdout] 370 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 359 ~ if !psp.contains(&ap.child) && geo_fence.is_none() [INFO] [stdout] 360 ~ && let Ok(date) = ap.date() { [INFO] [stdout] 361 | // future partitions cannot be detached [INFO] [stdout] ... [INFO] [stdout] 368 | } [INFO] [stdout] 369 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/db/pg/mod.rs:598:14 [INFO] [stdout] | [INFO] [stdout] 598 | .map(|row| RangeId::from(row)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `RangeId::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/db/pg/mod.rs:648:1 [INFO] [stdout] | [INFO] [stdout] 648 | / pub async fn insert_cell( [INFO] [stdout] 649 | | transaction: &Transaction<'_>, [INFO] [stdout] 650 | | radio: i16, [INFO] [stdout] 651 | | country: i16, [INFO] [stdout] ... | [INFO] [stdout] 656 | | tl: TransmitterLocation, [INFO] [stdout] 657 | | ) -> Result { [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lbs/yandex/wifi.rs:364:13 [INFO] [stdout] | [INFO] [stdout] 364 | / if let Err(e) = yandex_client [INFO] [stdout] 365 | | .post_for_data( [INFO] [stdout] 366 | | &mac, [INFO] [stdout] 367 | | &yandex_lbs_url, [INFO] [stdout] ... | [INFO] [stdout] 378 | | return Err(e); [INFO] [stdout] 379 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 364 ~ yandex_client [INFO] [stdout] 365 + .post_for_data( [INFO] [stdout] 366 + &mac, [INFO] [stdout] 367 + &yandex_lbs_url, [INFO] [stdout] 368 + &yandex_lbs_request, [INFO] [stdout] 369 + tx_yandex_api.clone(), [INFO] [stdout] 370 + api_key, [INFO] [stdout] 371 + &mut lbs_responses, [INFO] [stdout] 372 + tx_t38_conn.clone(), [INFO] [stdout] 373 + tx_ba_conn.clone(), [INFO] [stdout] 374 + collection, [INFO] [stdout] 375 + ) [INFO] [stdout] 376 + .await? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/cmd.rs:126:78 [INFO] [stdout] | [INFO] [stdout] 126 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/cmd.rs:182:78 [INFO] [stdout] | [INFO] [stdout] 182 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:67:78 [INFO] [stdout] | [INFO] [stdout] 67 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | / match v { [INFO] [stdout] 90 | | redis::Value::Array(array) => { [INFO] [stdout] 91 | | for v2 in array { [INFO] [stdout] 92 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 175 | | _ => {} [INFO] [stdout] 176 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 90 + for v2 in array { [INFO] [stdout] 91 + match v2 { [INFO] [stdout] 92 + redis::Value::Array(array2) => { [INFO] [stdout] 93 + for v3 in array2 { [INFO] [stdout] 94 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 95 + if v4.len() < 4 { [INFO] [stdout] 96 + continue; [INFO] [stdout] 97 + } [INFO] [stdout] 98 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 99 + let mac = [INFO] [stdout] 100 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 101 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 102 + let ylr_str = [INFO] [stdout] 103 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 104 + let ylr: YandexLbsResponse = [INFO] [stdout] 105 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 106 + [INFO] [stdout] 107 + if let Err(e) = set_ba_lbs_yandex_wifi_one( [INFO] [stdout] 108 + tx_ba_conn.clone(), [INFO] [stdout] 109 + Collection::BaLbsYandexWifi.as_ref(), [INFO] [stdout] 110 + ylr, [INFO] [stdout] 111 + &mac, [INFO] [stdout] 112 + ) [INFO] [stdout] 113 + .await [INFO] [stdout] 114 + { [INFO] [stdout] 115 + println!( [INFO] [stdout] 116 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 117 + ); [INFO] [stdout] 118 + } [INFO] [stdout] 119 + i2 += 1; [INFO] [stdout] 120 + [INFO] [stdout] 121 + // if ylr.location.accuracy == 150.0 { [INFO] [stdout] 122 + // println!("mac: {}", mac); [INFO] [stdout] 123 + // println!("ylr: {:?}", ylr); [INFO] [stdout] 124 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 125 + // tx_t38_conn.clone(), [INFO] [stdout] 126 + // "lbs:yandex:wifi", [INFO] [stdout] 127 + // &mac, [INFO] [stdout] 128 + // ) [INFO] [stdout] 129 + // .await; [INFO] [stdout] 130 + // } [INFO] [stdout] 131 + [INFO] [stdout] 132 + // if true { [INFO] [stdout] 133 + // all_count += 1; [INFO] [stdout] 134 + // let ps = format!( [INFO] [stdout] 135 + // "{}", [INFO] [stdout] 136 + // ylr.location.point.lat [INFO] [stdout] 137 + // ); [INFO] [stdout] 138 + // let ps2 = format!( [INFO] [stdout] 139 + // "{}", [INFO] [stdout] 140 + // ylr.location.point.lon [INFO] [stdout] 141 + // ); [INFO] [stdout] 142 + // if ps.len() <= 9 || ps2.len() <= 9 { [INFO] [stdout] 143 + // // DEBUG [INFO] [stdout] 144 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 145 + // println!("mac: {}", mac); [INFO] [stdout] 146 + // println!( [INFO] [stdout] 147 + // "ylr: {:?}", [INFO] [stdout] 148 + // ylr.location.point [INFO] [stdout] 149 + // ); [INFO] [stdout] 150 + // del_wifi_one( [INFO] [stdout] 151 + // tx_t38_conn.clone(), [INFO] [stdout] 152 + // "wifi", [INFO] [stdout] 153 + // &mac, [INFO] [stdout] 154 + // ) [INFO] [stdout] 155 + // .await; [INFO] [stdout] 156 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 157 + // tx_t38_conn.clone(), [INFO] [stdout] 158 + // "lbs:yandex:wifi", [INFO] [stdout] 159 + // &mac, [INFO] [stdout] 160 + // ) [INFO] [stdout] 161 + // .await; [INFO] [stdout] 162 + // i2 += 1; [INFO] [stdout] 163 + // } [INFO] [stdout] 164 + // } [INFO] [stdout] 165 + } [INFO] [stdout] 166 + } [INFO] [stdout] 167 + } [INFO] [stdout] 168 + } [INFO] [stdout] 169 + } [INFO] [stdout] 170 + _ => {} [INFO] [stdout] 171 + } [INFO] [stdout] 172 + } [INFO] [stdout] 173 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:92:33 [INFO] [stdout] | [INFO] [stdout] 92 | / ... match v2 { [INFO] [stdout] 93 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 94 | | ... for v3 in array2 { [INFO] [stdout] 95 | | ... if let redis::Value::Array(v4) = v3 { [INFO] [stdout] ... | [INFO] [stdout] 171 | | ... _ => {} [INFO] [stdout] 172 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 92 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 93 + for v3 in array2 { [INFO] [stdout] 94 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 95 + if v4.len() < 4 { [INFO] [stdout] 96 + continue; [INFO] [stdout] 97 + } [INFO] [stdout] 98 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 99 + let mac = [INFO] [stdout] 100 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 101 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 102 + let ylr_str = [INFO] [stdout] 103 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 104 + let ylr: YandexLbsResponse = [INFO] [stdout] 105 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 106 + [INFO] [stdout] 107 + if let Err(e) = set_ba_lbs_yandex_wifi_one( [INFO] [stdout] 108 + tx_ba_conn.clone(), [INFO] [stdout] 109 + Collection::BaLbsYandexWifi.as_ref(), [INFO] [stdout] 110 + ylr, [INFO] [stdout] 111 + &mac, [INFO] [stdout] 112 + ) [INFO] [stdout] 113 + .await [INFO] [stdout] 114 + { [INFO] [stdout] 115 + println!( [INFO] [stdout] 116 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 117 + ); [INFO] [stdout] 118 + } [INFO] [stdout] 119 + i2 += 1; [INFO] [stdout] 120 + [INFO] [stdout] 121 + // if ylr.location.accuracy == 150.0 { [INFO] [stdout] 122 + // println!("mac: {}", mac); [INFO] [stdout] 123 + // println!("ylr: {:?}", ylr); [INFO] [stdout] 124 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 125 + // tx_t38_conn.clone(), [INFO] [stdout] 126 + // "lbs:yandex:wifi", [INFO] [stdout] 127 + // &mac, [INFO] [stdout] 128 + // ) [INFO] [stdout] 129 + // .await; [INFO] [stdout] 130 + // } [INFO] [stdout] 131 + [INFO] [stdout] 132 + // if true { [INFO] [stdout] 133 + // all_count += 1; [INFO] [stdout] 134 + // let ps = format!( [INFO] [stdout] 135 + // "{}", [INFO] [stdout] 136 + // ylr.location.point.lat [INFO] [stdout] 137 + // ); [INFO] [stdout] 138 + // let ps2 = format!( [INFO] [stdout] 139 + // "{}", [INFO] [stdout] 140 + // ylr.location.point.lon [INFO] [stdout] 141 + // ); [INFO] [stdout] 142 + // if ps.len() <= 9 || ps2.len() <= 9 { [INFO] [stdout] 143 + // // DEBUG [INFO] [stdout] 144 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 145 + // println!("mac: {}", mac); [INFO] [stdout] 146 + // println!( [INFO] [stdout] 147 + // "ylr: {:?}", [INFO] [stdout] 148 + // ylr.location.point [INFO] [stdout] 149 + // ); [INFO] [stdout] 150 + // del_wifi_one( [INFO] [stdout] 151 + // tx_t38_conn.clone(), [INFO] [stdout] 152 + // "wifi", [INFO] [stdout] 153 + // &mac, [INFO] [stdout] 154 + // ) [INFO] [stdout] 155 + // .await; [INFO] [stdout] 156 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 157 + // tx_t38_conn.clone(), [INFO] [stdout] 158 + // "lbs:yandex:wifi", [INFO] [stdout] 159 + // &mac, [INFO] [stdout] 160 + // ) [INFO] [stdout] 161 + // .await; [INFO] [stdout] 162 + // i2 += 1; [INFO] [stdout] 163 + // } [INFO] [stdout] 164 + // } [INFO] [stdout] 165 + } [INFO] [stdout] 166 + } [INFO] [stdout] 167 + } [INFO] [stdout] 168 + } [INFO] [stdout] 169 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:230:78 [INFO] [stdout] | [INFO] [stdout] 230 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1045:13 [INFO] [stdout] | [INFO] [stdout] 1045 | lat_weighted = lat_weighted + ylr.location.point.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted += ylr.location.point.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1046:13 [INFO] [stdout] | [INFO] [stdout] 1046 | lon_weighted = lon_weighted + ylr.location.point.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted += ylr.location.point.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1047:13 [INFO] [stdout] | [INFO] [stdout] 1047 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:251:21 [INFO] [stdout] | [INFO] [stdout] 251 | / match v { [INFO] [stdout] 252 | | redis::Value::Array(array) => { [INFO] [stdout] 253 | | for v2 in array { [INFO] [stdout] 254 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 315 | | _ => {} [INFO] [stdout] 316 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 251 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 252 + for v2 in array { [INFO] [stdout] 253 + match v2 { [INFO] [stdout] 254 + redis::Value::Array(array2) => { [INFO] [stdout] 255 + for v3 in array2 { [INFO] [stdout] 256 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 257 + if v4.len() < 4 { [INFO] [stdout] 258 + continue; [INFO] [stdout] 259 + } [INFO] [stdout] 260 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 261 + let mac = [INFO] [stdout] 262 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 263 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 264 + let tl_str = [INFO] [stdout] 265 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 266 + let tl: TransmitterLocation = [INFO] [stdout] 267 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 268 + [INFO] [stdout] 269 + if let Err(e) = set_ba_wifi_one( [INFO] [stdout] 270 + tx_ba_conn.clone(), [INFO] [stdout] 271 + Collection::BaWifi.as_ref(), [INFO] [stdout] 272 + &tl, [INFO] [stdout] 273 + ) [INFO] [stdout] 274 + .await [INFO] [stdout] 275 + { [INFO] [stdout] 276 + println!( [INFO] [stdout] 277 + "ERROR save TransmitterLocation to blobasaur" [INFO] [stdout] 278 + ); [INFO] [stdout] 279 + } [INFO] [stdout] 280 + i += 1; [INFO] [stdout] 281 + [INFO] [stdout] 282 + // if tl.lat >= 43.7 [INFO] [stdout] 283 + // && tl.lat <= 44.999 [INFO] [stdout] 284 + // && tl.lon >= 36.999 [INFO] [stdout] 285 + // && tl.lon <= 38.111 [INFO] [stdout] 286 + // { [INFO] [stdout] 287 + // // DEBUG [INFO] [stdout] 288 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 289 + // println!("mac: {}", mac); [INFO] [stdout] 290 + // println!("tl: {:?}", tl); [INFO] [stdout] 291 + // del_wifi_one( [INFO] [stdout] 292 + // tx_t38_conn.clone(), [INFO] [stdout] 293 + // "wifi", [INFO] [stdout] 294 + // &mac, [INFO] [stdout] 295 + // ) [INFO] [stdout] 296 + // .await; [INFO] [stdout] 297 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 298 + // tx_t38_conn.clone(), [INFO] [stdout] 299 + // "lbs:yandex:wifi", [INFO] [stdout] 300 + // &mac, [INFO] [stdout] 301 + // ) [INFO] [stdout] 302 + // .await; [INFO] [stdout] 303 + // i += 1; [INFO] [stdout] 304 + // } [INFO] [stdout] 305 + } [INFO] [stdout] 306 + } [INFO] [stdout] 307 + } [INFO] [stdout] 308 + } [INFO] [stdout] 309 + } [INFO] [stdout] 310 + _ => {} [INFO] [stdout] 311 + } [INFO] [stdout] 312 + } [INFO] [stdout] 313 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:254:33 [INFO] [stdout] | [INFO] [stdout] 254 | / ... match v2 { [INFO] [stdout] 255 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 256 | | ... for v3 in array2 { [INFO] [stdout] 257 | | ... if let redis::Value::Array(v4) = v3 { [INFO] [stdout] ... | [INFO] [stdout] 311 | | ... _ => {} [INFO] [stdout] 312 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 254 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 255 + for v3 in array2 { [INFO] [stdout] 256 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 257 + if v4.len() < 4 { [INFO] [stdout] 258 + continue; [INFO] [stdout] 259 + } [INFO] [stdout] 260 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 261 + let mac = [INFO] [stdout] 262 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 263 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 264 + let tl_str = [INFO] [stdout] 265 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 266 + let tl: TransmitterLocation = [INFO] [stdout] 267 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 268 + [INFO] [stdout] 269 + if let Err(e) = set_ba_wifi_one( [INFO] [stdout] 270 + tx_ba_conn.clone(), [INFO] [stdout] 271 + Collection::BaWifi.as_ref(), [INFO] [stdout] 272 + &tl, [INFO] [stdout] 273 + ) [INFO] [stdout] 274 + .await [INFO] [stdout] 275 + { [INFO] [stdout] 276 + println!( [INFO] [stdout] 277 + "ERROR save TransmitterLocation to blobasaur" [INFO] [stdout] 278 + ); [INFO] [stdout] 279 + } [INFO] [stdout] 280 + i += 1; [INFO] [stdout] 281 + [INFO] [stdout] 282 + // if tl.lat >= 43.7 [INFO] [stdout] 283 + // && tl.lat <= 44.999 [INFO] [stdout] 284 + // && tl.lon >= 36.999 [INFO] [stdout] 285 + // && tl.lon <= 38.111 [INFO] [stdout] 286 + // { [INFO] [stdout] 287 + // // DEBUG [INFO] [stdout] 288 + // // TODO: remove after tests by Whoosh [INFO] [stdout] 289 + // println!("mac: {}", mac); [INFO] [stdout] 290 + // println!("tl: {:?}", tl); [INFO] [stdout] 291 + // del_wifi_one( [INFO] [stdout] 292 + // tx_t38_conn.clone(), [INFO] [stdout] 293 + // "wifi", [INFO] [stdout] 294 + // &mac, [INFO] [stdout] 295 + // ) [INFO] [stdout] 296 + // .await; [INFO] [stdout] 297 + // del_yandex_lbs_wifi_one( [INFO] [stdout] 298 + // tx_t38_conn.clone(), [INFO] [stdout] 299 + // "lbs:yandex:wifi", [INFO] [stdout] 300 + // &mac, [INFO] [stdout] 301 + // ) [INFO] [stdout] 302 + // .await; [INFO] [stdout] 303 + // i += 1; [INFO] [stdout] 304 + // } [INFO] [stdout] 305 + } [INFO] [stdout] 306 + } [INFO] [stdout] 307 + } [INFO] [stdout] 308 + } [INFO] [stdout] 309 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:372:78 [INFO] [stdout] | [INFO] [stdout] 372 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:394:21 [INFO] [stdout] | [INFO] [stdout] 394 | / match v { [INFO] [stdout] 395 | | redis::Value::Array(array) => { [INFO] [stdout] 396 | | for v2 in array { [INFO] [stdout] 397 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 430 | | _ => {} [INFO] [stdout] 431 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 394 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 395 + for v2 in array { [INFO] [stdout] 396 + match v2 { [INFO] [stdout] 397 + redis::Value::Array(array2) => { [INFO] [stdout] 398 + if let redis::Value::BulkString(s) = &array2[0] { [INFO] [stdout] 399 + let cell_code = String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 400 + if let redis::Value::BulkString(s1) = &array2[1] { [INFO] [stdout] 401 + let ylr_str = [INFO] [stdout] 402 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 403 + [INFO] [stdout] 404 + let dc: DataCell = [INFO] [stdout] 405 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 406 + let ylr: YandexLbsResponse = [INFO] [stdout] 407 + serde_json::from_str(&dc.data).unwrap(); [INFO] [stdout] 408 + [INFO] [stdout] 409 + if let Err(e) = set_ba_lbs_yandex_cell_one( [INFO] [stdout] 410 + tx_ba_conn.clone(), [INFO] [stdout] 411 + Collection::BaLbsYandexCell.as_ref(), [INFO] [stdout] 412 + ylr, [INFO] [stdout] 413 + &cell_code, [INFO] [stdout] 414 + ) [INFO] [stdout] 415 + .await [INFO] [stdout] 416 + { [INFO] [stdout] 417 + println!( [INFO] [stdout] 418 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 419 + ); [INFO] [stdout] 420 + } [INFO] [stdout] 421 + i2 += 1; [INFO] [stdout] 422 + } [INFO] [stdout] 423 + } [INFO] [stdout] 424 + } [INFO] [stdout] 425 + _ => {} [INFO] [stdout] 426 + } [INFO] [stdout] 427 + } [INFO] [stdout] 428 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:397:33 [INFO] [stdout] | [INFO] [stdout] 397 | / ... match v2 { [INFO] [stdout] 398 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 399 | | ... if let redis::Value::BulkString(s) = &array2[0] { [INFO] [stdout] 400 | | ... let cell_code = String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 426 | | ... _ => {} [INFO] [stdout] 427 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 397 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 398 + if let redis::Value::BulkString(s) = &array2[0] { [INFO] [stdout] 399 + let cell_code = String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 400 + if let redis::Value::BulkString(s1) = &array2[1] { [INFO] [stdout] 401 + let ylr_str = [INFO] [stdout] 402 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 403 + [INFO] [stdout] 404 + let dc: DataCell = [INFO] [stdout] 405 + serde_json::from_str(&ylr_str).unwrap(); [INFO] [stdout] 406 + let ylr: YandexLbsResponse = [INFO] [stdout] 407 + serde_json::from_str(&dc.data).unwrap(); [INFO] [stdout] 408 + [INFO] [stdout] 409 + if let Err(e) = set_ba_lbs_yandex_cell_one( [INFO] [stdout] 410 + tx_ba_conn.clone(), [INFO] [stdout] 411 + Collection::BaLbsYandexCell.as_ref(), [INFO] [stdout] 412 + ylr, [INFO] [stdout] 413 + &cell_code, [INFO] [stdout] 414 + ) [INFO] [stdout] 415 + .await [INFO] [stdout] 416 + { [INFO] [stdout] 417 + println!( [INFO] [stdout] 418 + "ERROR save YandexLbsResponse to blobasaur" [INFO] [stdout] 419 + ); [INFO] [stdout] 420 + } [INFO] [stdout] 421 + i2 += 1; [INFO] [stdout] 422 + } [INFO] [stdout] 423 + } [INFO] [stdout] 424 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:480:78 [INFO] [stdout] | [INFO] [stdout] 480 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:501:21 [INFO] [stdout] | [INFO] [stdout] 501 | / match v { [INFO] [stdout] 502 | | redis::Value::Array(array) => { [INFO] [stdout] 503 | | for v2 in array { [INFO] [stdout] 504 | | match v2 { [INFO] [stdout] ... | [INFO] [stdout] 579 | | _ => {} [INFO] [stdout] 580 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 501 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 502 + for v2 in array { [INFO] [stdout] 503 + match v2 { [INFO] [stdout] 504 + redis::Value::Array(array2) => { [INFO] [stdout] 505 + for v3 in array2 { [INFO] [stdout] 506 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 507 + if v4.len() < 4 { [INFO] [stdout] 508 + continue; [INFO] [stdout] 509 + } [INFO] [stdout] 510 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 511 + let mac = [INFO] [stdout] 512 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 513 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 514 + let tl_str = [INFO] [stdout] 515 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 516 + let tl: TransmitterLocation = [INFO] [stdout] 517 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 518 + [INFO] [stdout] 519 + match get_yandex_lbs_wifi_one( [INFO] [stdout] 520 + tx_t38_conn.clone(), [INFO] [stdout] 521 + "lbs:yandex:wifi", [INFO] [stdout] 522 + &mac, [INFO] [stdout] 523 + ) [INFO] [stdout] 524 + .await [INFO] [stdout] 525 + { [INFO] [stdout] 526 + Err(_e) => {} [INFO] [stdout] 527 + Ok(w) => { [INFO] [stdout] 528 + if let Some(ylr) = w { [INFO] [stdout] 529 + let p_yandex = Point { [INFO] [stdout] 530 + id: 0, [INFO] [stdout] 531 + lat: ylr.location.point.lat, [INFO] [stdout] 532 + lon: ylr.location.point.lon, [INFO] [stdout] 533 + }; [INFO] [stdout] 534 + let p_tl = Point { [INFO] [stdout] 535 + id: 1, [INFO] [stdout] 536 + lat: tl.lat, [INFO] [stdout] 537 + lon: tl.lon, [INFO] [stdout] 538 + }; [INFO] [stdout] 539 + let d = [INFO] [stdout] 540 + p_yandex.distance(&p_tl); [INFO] [stdout] 541 + if d > MAX_DISTANCE_REPORT_LBS { [INFO] [stdout] 542 + // DEBUG [INFO] [stdout] 543 + // TODO: remove after tests by Whoosh [INFO] [stdout] 544 + println!("d mac: {}", mac); [INFO] [stdout] 545 + println!("d tl: {:?}", tl); [INFO] [stdout] 546 + del_wifi_one( [INFO] [stdout] 547 + tx_t38_conn.clone(), [INFO] [stdout] 548 + "wifi", [INFO] [stdout] 549 + &mac, [INFO] [stdout] 550 + ) [INFO] [stdout] 551 + .await; [INFO] [stdout] 552 + i += 1; [INFO] [stdout] 553 + } [INFO] [stdout] 554 + } else { [INFO] [stdout] 555 + // DEBUG [INFO] [stdout] 556 + // TODO: remove after tests by Whoosh [INFO] [stdout] 557 + println!("none mac: {}", mac); [INFO] [stdout] 558 + println!("none tl: {:?}", tl); [INFO] [stdout] 559 + del_wifi_one( [INFO] [stdout] 560 + tx_t38_conn.clone(), [INFO] [stdout] 561 + "wifi", [INFO] [stdout] 562 + &mac, [INFO] [stdout] 563 + ) [INFO] [stdout] 564 + .await; [INFO] [stdout] 565 + i += 1; [INFO] [stdout] 566 + } [INFO] [stdout] 567 + } [INFO] [stdout] 568 + } [INFO] [stdout] 569 + } [INFO] [stdout] 570 + } [INFO] [stdout] 571 + } [INFO] [stdout] 572 + } [INFO] [stdout] 573 + } [INFO] [stdout] 574 + _ => {} [INFO] [stdout] 575 + } [INFO] [stdout] 576 + } [INFO] [stdout] 577 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:504:33 [INFO] [stdout] | [INFO] [stdout] 504 | / ... match v2 { [INFO] [stdout] 505 | | ... redis::Value::Array(array2) => { [INFO] [stdout] 506 | | ... for v3 in array2 { [INFO] [stdout] 507 | | ... if let redis::Value::Array(v4) = v3 { [INFO] [stdout] ... | [INFO] [stdout] 575 | | ... _ => {} [INFO] [stdout] 576 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 504 ~ if let redis::Value::Array(array2) = v2 { [INFO] [stdout] 505 + for v3 in array2 { [INFO] [stdout] 506 + if let redis::Value::Array(v4) = v3 { [INFO] [stdout] 507 + if v4.len() < 4 { [INFO] [stdout] 508 + continue; [INFO] [stdout] 509 + } [INFO] [stdout] 510 + if let redis::Value::BulkString(s) = &v4[3] { [INFO] [stdout] 511 + let mac = [INFO] [stdout] 512 + String::from_utf8(s.to_vec()).unwrap(); [INFO] [stdout] 513 + if let redis::Value::BulkString(s1) = &v4[1] { [INFO] [stdout] 514 + let tl_str = [INFO] [stdout] 515 + String::from_utf8(s1.to_vec()).unwrap(); [INFO] [stdout] 516 + let tl: TransmitterLocation = [INFO] [stdout] 517 + serde_json::from_str(&tl_str).unwrap(); [INFO] [stdout] 518 + [INFO] [stdout] 519 + match get_yandex_lbs_wifi_one( [INFO] [stdout] 520 + tx_t38_conn.clone(), [INFO] [stdout] 521 + "lbs:yandex:wifi", [INFO] [stdout] 522 + &mac, [INFO] [stdout] 523 + ) [INFO] [stdout] 524 + .await [INFO] [stdout] 525 + { [INFO] [stdout] 526 + Err(_e) => {} [INFO] [stdout] 527 + Ok(w) => { [INFO] [stdout] 528 + if let Some(ylr) = w { [INFO] [stdout] 529 + let p_yandex = Point { [INFO] [stdout] 530 + id: 0, [INFO] [stdout] 531 + lat: ylr.location.point.lat, [INFO] [stdout] 532 + lon: ylr.location.point.lon, [INFO] [stdout] 533 + }; [INFO] [stdout] 534 + let p_tl = Point { [INFO] [stdout] 535 + id: 1, [INFO] [stdout] 536 + lat: tl.lat, [INFO] [stdout] 537 + lon: tl.lon, [INFO] [stdout] 538 + }; [INFO] [stdout] 539 + let d = [INFO] [stdout] 540 + p_yandex.distance(&p_tl); [INFO] [stdout] 541 + if d > MAX_DISTANCE_REPORT_LBS { [INFO] [stdout] 542 + // DEBUG [INFO] [stdout] 543 + // TODO: remove after tests by Whoosh [INFO] [stdout] 544 + println!("d mac: {}", mac); [INFO] [stdout] 545 + println!("d tl: {:?}", tl); [INFO] [stdout] 546 + del_wifi_one( [INFO] [stdout] 547 + tx_t38_conn.clone(), [INFO] [stdout] 548 + "wifi", [INFO] [stdout] 549 + &mac, [INFO] [stdout] 550 + ) [INFO] [stdout] 551 + .await; [INFO] [stdout] 552 + i += 1; [INFO] [stdout] 553 + } [INFO] [stdout] 554 + } else { [INFO] [stdout] 555 + // DEBUG [INFO] [stdout] 556 + // TODO: remove after tests by Whoosh [INFO] [stdout] 557 + println!("none mac: {}", mac); [INFO] [stdout] 558 + println!("none tl: {:?}", tl); [INFO] [stdout] 559 + del_wifi_one( [INFO] [stdout] 560 + tx_t38_conn.clone(), [INFO] [stdout] 561 + "wifi", [INFO] [stdout] 562 + &mac, [INFO] [stdout] 563 + ) [INFO] [stdout] 564 + .await; [INFO] [stdout] 565 + i += 1; [INFO] [stdout] 566 + } [INFO] [stdout] 567 + } [INFO] [stdout] 568 + } [INFO] [stdout] 569 + } [INFO] [stdout] 570 + } [INFO] [stdout] 571 + } [INFO] [stdout] 572 + } [INFO] [stdout] 573 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/db/t38/scan.rs:631:78 [INFO] [stdout] | [INFO] [stdout] 631 | format!("Unable to connect to the Redis store: {}", e.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:651:21 [INFO] [stdout] | [INFO] [stdout] 651 | / match v { [INFO] [stdout] 652 | | redis::Value::Array(array) => { [INFO] [stdout] 653 | | let mut ids = Vec::with_capacity(array.len()); [INFO] [stdout] 654 | | for id_value in array { [INFO] [stdout] ... | [INFO] [stdout] 665 | | _ => {} [INFO] [stdout] 666 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 651 ~ if let redis::Value::Array(array) = v { [INFO] [stdout] 652 + let mut ids = Vec::with_capacity(array.len()); [INFO] [stdout] 653 + for id_value in array { [INFO] [stdout] 654 + match id_value { [INFO] [stdout] 655 + redis::Value::BulkString(bulk_string) => { [INFO] [stdout] 656 + let id = String::from_utf8(bulk_string).unwrap(); [INFO] [stdout] 657 + ids.push(id); [INFO] [stdout] 658 + } [INFO] [stdout] 659 + _ => {} [INFO] [stdout] 660 + } [INFO] [stdout] 661 + } [INFO] [stdout] 662 + return Ok(ids); [INFO] [stdout] 663 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/scan.rs:655:33 [INFO] [stdout] | [INFO] [stdout] 655 | / ... match id_value { [INFO] [stdout] 656 | | ... redis::Value::BulkString(bulk_string) => { [INFO] [stdout] 657 | | ... let id = String::from_utf8(bulk_string).unwrap(); [INFO] [stdout] 658 | | ... ids.push(id); [INFO] [stdout] 659 | | ... } [INFO] [stdout] 660 | | ... _ => {} [INFO] [stdout] 661 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 655 ~ if let redis::Value::BulkString(bulk_string) = id_value { [INFO] [stdout] 656 + let id = String::from_utf8(bulk_string).unwrap(); [INFO] [stdout] 657 + ids.push(id); [INFO] [stdout] 658 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DBSCAN` contains a capitalized acronym [INFO] [stdout] --> src/services/locate/dbscan/mod.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 172 | pub struct DBSCAN [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Dbscan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/mod.rs:474:5 [INFO] [stdout] | [INFO] [stdout] 474 | / match scan_result { [INFO] [stdout] 475 | | redis::Value::Array(arr) => { [INFO] [stdout] 476 | | for v in arr { [INFO] [stdout] 477 | | match v { [INFO] [stdout] ... | [INFO] [stdout] 531 | | _ => {} [INFO] [stdout] 532 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 474 ~ if let redis::Value::Array(arr) = scan_result { [INFO] [stdout] 475 + for v in arr { [INFO] [stdout] 476 + match v { [INFO] [stdout] 477 + redis::Value::Array(arr1) => { [INFO] [stdout] 478 + for v1 in arr1 { [INFO] [stdout] 479 + match v1 { [INFO] [stdout] 480 + redis::Value::Array(arr2) => { [INFO] [stdout] 481 + for v2 in arr2 { [INFO] [stdout] 482 + match v2 { [INFO] [stdout] 483 + redis::Value::Array(arr3) => { [INFO] [stdout] 484 + for (i3, v3) in arr3.iter().enumerate() { [INFO] [stdout] 485 + match v3 { [INFO] [stdout] 486 + redis::Value::BulkString(data) => { [INFO] [stdout] 487 + // i3 == 0 => field name = "data" [INFO] [stdout] 488 + if i3 == 1 { [INFO] [stdout] 489 + match serde_json::from_slice::< [INFO] [stdout] 490 + TransmitterLocation, [INFO] [stdout] 491 + >( [INFO] [stdout] 492 + &data [INFO] [stdout] 493 + ) { [INFO] [stdout] 494 + Err(err) => { [INFO] [stdout] 495 + error!( [INFO] [stdout] 496 + "deserialize tl from Tile38: {}", [INFO] [stdout] 497 + err [INFO] [stdout] 498 + ); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + Ok(tl) => { [INFO] [stdout] 501 + tls.push(tl); [INFO] [stdout] 502 + } [INFO] [stdout] 503 + } [INFO] [stdout] 504 + } [INFO] [stdout] 505 + } [INFO] [stdout] 506 + _ => {} [INFO] [stdout] 507 + } [INFO] [stdout] 508 + } [INFO] [stdout] 509 + } [INFO] [stdout] 510 + redis::Value::BulkString(_field) => { [INFO] [stdout] 511 + // fields: [INFO] [stdout] 512 + // mac String [INFO] [stdout] 513 + // geometry Object [INFO] [stdout] 514 + } [INFO] [stdout] 515 + _ => {} [INFO] [stdout] 516 + } [INFO] [stdout] 517 + } [INFO] [stdout] 518 + } [INFO] [stdout] 519 + _ => {} [INFO] [stdout] 520 + } [INFO] [stdout] 521 + } [INFO] [stdout] 522 + } [INFO] [stdout] 523 + redis::Value::Int(_i) => { [INFO] [stdout] 524 + // at first level _i == 0 [INFO] [stdout] 525 + } [INFO] [stdout] 526 + _ => {} [INFO] [stdout] 527 + } [INFO] [stdout] 528 + } [INFO] [stdout] 529 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/mod.rs:480:29 [INFO] [stdout] | [INFO] [stdout] 480 | / ... match v1 { [INFO] [stdout] 481 | | ... redis::Value::Array(arr2) => { [INFO] [stdout] 482 | | ... for v2 in arr2 { [INFO] [stdout] 483 | | ... match v2 { [INFO] [stdout] ... | [INFO] [stdout] 520 | | ... _ => {} [INFO] [stdout] 521 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 480 ~ if let redis::Value::Array(arr2) = v1 { [INFO] [stdout] 481 + for v2 in arr2 { [INFO] [stdout] 482 + match v2 { [INFO] [stdout] 483 + redis::Value::Array(arr3) => { [INFO] [stdout] 484 + for (i3, v3) in arr3.iter().enumerate() { [INFO] [stdout] 485 + match v3 { [INFO] [stdout] 486 + redis::Value::BulkString(data) => { [INFO] [stdout] 487 + // i3 == 0 => field name = "data" [INFO] [stdout] 488 + if i3 == 1 { [INFO] [stdout] 489 + match serde_json::from_slice::< [INFO] [stdout] 490 + TransmitterLocation, [INFO] [stdout] 491 + >( [INFO] [stdout] 492 + &data [INFO] [stdout] 493 + ) { [INFO] [stdout] 494 + Err(err) => { [INFO] [stdout] 495 + error!( [INFO] [stdout] 496 + "deserialize tl from Tile38: {}", [INFO] [stdout] 497 + err [INFO] [stdout] 498 + ); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + Ok(tl) => { [INFO] [stdout] 501 + tls.push(tl); [INFO] [stdout] 502 + } [INFO] [stdout] 503 + } [INFO] [stdout] 504 + } [INFO] [stdout] 505 + } [INFO] [stdout] 506 + _ => {} [INFO] [stdout] 507 + } [INFO] [stdout] 508 + } [INFO] [stdout] 509 + } [INFO] [stdout] 510 + redis::Value::BulkString(_field) => { [INFO] [stdout] 511 + // fields: [INFO] [stdout] 512 + // mac String [INFO] [stdout] 513 + // geometry Object [INFO] [stdout] 514 + } [INFO] [stdout] 515 + _ => {} [INFO] [stdout] 516 + } [INFO] [stdout] 517 + } [INFO] [stdout] 518 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/db/t38/mod.rs:489:61 [INFO] [stdout] | [INFO] [stdout] 489 | / ... if i3 == 1 { [INFO] [stdout] 490 | | ... match serde_json::from_slice::< [INFO] [stdout] 491 | | ... TransmitterLocation, [INFO] [stdout] 492 | | ... >( [INFO] [stdout] ... | [INFO] [stdout] 505 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 487 ~ redis::Value::BulkString(data) [INFO] [stdout] 488 | // i3 == 0 => field name = "data" [INFO] [stdout] 489 ~ if i3 == 1 => { [INFO] [stdout] 490 | match serde_json::from_slice::< [INFO] [stdout] ... [INFO] [stdout] 504 | } [INFO] [stdout] 505 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/db/t38/mod.rs:486:53 [INFO] [stdout] | [INFO] [stdout] 486 | / ... match v3 { [INFO] [stdout] 487 | | ... redis::Value::BulkString(data) => { [INFO] [stdout] 488 | | ... // i3 == 0 => field name = "data" [INFO] [stdout] 489 | | ... if i3 == 1 { [INFO] [stdout] ... | [INFO] [stdout] 507 | | ... _ => {} [INFO] [stdout] 508 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 486 ~ if let redis::Value::BulkString(data) = v3 { [INFO] [stdout] 487 + // i3 == 0 => field name = "data" [INFO] [stdout] 488 + if i3 == 1 { [INFO] [stdout] 489 + match serde_json::from_slice::< [INFO] [stdout] 490 + TransmitterLocation, [INFO] [stdout] 491 + >( [INFO] [stdout] 492 + &data [INFO] [stdout] 493 + ) { [INFO] [stdout] 494 + Err(err) => { [INFO] [stdout] 495 + error!( [INFO] [stdout] 496 + "deserialize tl from Tile38: {}", [INFO] [stdout] 497 + err [INFO] [stdout] 498 + ); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + Ok(tl) => { [INFO] [stdout] 501 + tls.push(tl); [INFO] [stdout] 502 + } [INFO] [stdout] 503 + } [INFO] [stdout] 504 + } [INFO] [stdout] 505 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/db/t38/mod.rs:493:69 [INFO] [stdout] | [INFO] [stdout] 493 | ... &data [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/error/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod error; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/error/error.rs:112:13 [INFO] [stdout] | [INFO] [stdout] 111 | let error_resp = error_response(code); [INFO] [stdout] | -------------------------------------- unnecessary `let` binding [INFO] [stdout] 112 | error_resp [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 111 ~ [INFO] [stdout] 112 ~ error_response(code) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/error/error.rs:125:13 [INFO] [stdout] | [INFO] [stdout] 115 | / let error_resp = HttpResponse::InternalServerError().json(json!( [INFO] [stdout] 116 | | { [INFO] [stdout] 117 | | "error": { [INFO] [stdout] 118 | | "domain": domain, [INFO] [stdout] ... | [INFO] [stdout] 124 | | )); [INFO] [stdout] | |_______________- unnecessary `let` binding [INFO] [stdout] 125 | error_resp [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 115 ~ [INFO] [stdout] 116 ~ HttpResponse::InternalServerError().json(json!( [INFO] [stdout] 117 + { [INFO] [stdout] 118 + "error": { [INFO] [stdout] 119 + "domain": domain, [INFO] [stdout] 120 + "reason": "internal server error", [INFO] [stdout] 121 + "message": "", [INFO] [stdout] 122 + "code": 500, [INFO] [stdout] 123 + } [INFO] [stdout] 124 + } [INFO] [stdout] 125 + )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/locate/geolocate.rs:179:49 [INFO] [stdout] | [INFO] [stdout] 179 | if check_outlier(outliers_opt.as_ref(), &tl) { [INFO] [stdout] | ^^^ help: change this to: `tl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:194:13 [INFO] [stdout] | [INFO] [stdout] 194 | lat_weight = lat_weight + tl.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight += tl.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | lon_weight = lon_weight + tl.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight += tl.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | r_weight = r_weight + tl.accuracy * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight += tl.accuracy * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | c = c + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `c += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | lat_weight = lat_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | lon_weight = lon_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | r_weight = r_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/services/locate/geolocate.rs:243:48 [INFO] [stdout] | [INFO] [stdout] 243 | for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 243 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 243 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/lbs/http_client.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / pub async fn post_for_data( [INFO] [stdout] 71 | | &self, [INFO] [stdout] 72 | | key: &str, [INFO] [stdout] 73 | | url: &str, [INFO] [stdout] ... | [INFO] [stdout] 80 | | collection: &str, [INFO] [stdout] 81 | | ) -> Result<(), ApiError> { [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/locate/geolocate_public.rs:260:49 [INFO] [stdout] | [INFO] [stdout] 260 | if check_outlier(outliers_opt.as_ref(), &tl) { [INFO] [stdout] | ^^^ help: change this to: `tl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | lat_weight = lat_weight + tl.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight += tl.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | lon_weight = lon_weight + tl.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight += tl.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | r_weight = r_weight + tl.accuracy * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight += tl.accuracy * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | c = c + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `c += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/services/locate/geolocate_public.rs:297:40 [INFO] [stdout] | [INFO] [stdout] 297 | for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 297 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 297 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | lat_weight = lat_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | lon_weight = lon_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | r_weight = r_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/services/locate/geolocate_public.rs:386:48 [INFO] [stdout] | [INFO] [stdout] 386 | for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 386 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 386 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lbs/model.rs:169:5 [INFO] [stdout] | [INFO] [stdout] 169 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 169 - return true; [INFO] [stdout] 169 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lbs/yandex/cell.rs:234:13 [INFO] [stdout] | [INFO] [stdout] 234 | / if let Err(e) = yandex_client [INFO] [stdout] 235 | | .post_for_data( [INFO] [stdout] 236 | | &cell_code, [INFO] [stdout] 237 | | &yandex_lbs_url, [INFO] [stdout] ... | [INFO] [stdout] 248 | | return Err(e); [INFO] [stdout] 249 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 234 ~ yandex_client [INFO] [stdout] 235 + .post_for_data( [INFO] [stdout] 236 + &cell_code, [INFO] [stdout] 237 + &yandex_lbs_url, [INFO] [stdout] 238 + &yandex_lbs_request, [INFO] [stdout] 239 + tx_yandex_api.clone(), [INFO] [stdout] 240 + api_key, [INFO] [stdout] 241 + &mut lbs_responses, [INFO] [stdout] 242 + tx_t38_conn.clone(), [INFO] [stdout] 243 + tx_ba_conn.clone(), [INFO] [stdout] 244 + collection, [INFO] [stdout] 245 + ) [INFO] [stdout] 246 + .await? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | impl Into for SubmissionPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 33 ~ impl From for Submission { [INFO] [stdout] 34 ~ fn from(val: SubmissionPublic) -> Self { [INFO] [stdout] 35 | Submission { [INFO] [stdout] 36 ~ items: val.items.into_iter().map(|rp| rp.into()).collect(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | impl Into for ReportPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 56 ~ impl From for Report { [INFO] [stdout] 57 ~ fn from(val: ReportPublic) -> Self { [INFO] [stdout] 58 ~ let wap = val.wifi.map(|vec_wp| { [INFO] [stdout] 59 | vec_wp [INFO] [stdout] ... [INFO] [stdout] 64 | Report { [INFO] [stdout] 65 ~ timestamp: val.timestamp, [INFO] [stdout] 66 ~ device_id: val.device_id, [INFO] [stdout] 67 ~ position: val.gnss.into(), [INFO] [stdout] 68 | wifi_access_points: wap, [INFO] [stdout] 69 ~ cell: val.cell, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | impl Into for ReportPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 77 ~ impl From for ReportProcess { [INFO] [stdout] 78 ~ fn from(val: ReportPublic) -> Self { [INFO] [stdout] 79 ~ let wap = val.wifi.map(|vec_wp| { [INFO] [stdout] 80 | vec_wp [INFO] [stdout] ... [INFO] [stdout] 85 | ReportProcess { [INFO] [stdout] 86 ~ timestamp: val.timestamp.timestamp(), [INFO] [stdout] 87 ~ device_id: val.device_id, [INFO] [stdout] 88 ~ position: val.gnss.into(), [INFO] [stdout] 89 | wifi_access_points: wap, [INFO] [stdout] 90 ~ cell: val.cell, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:117:1 [INFO] [stdout] | [INFO] [stdout] 117 | impl Into for WifiPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 117 ~ impl From for Wifi { [INFO] [stdout] 118 ~ fn from(val: WifiPublic) -> Self { [INFO] [stdout] 119 | Wifi { [INFO] [stdout] 120 ~ mac_address: val.mac, [INFO] [stdout] 121 ~ radio_type: val.radio_type, [INFO] [stdout] 122 ~ age: val.age, [INFO] [stdout] 123 ~ channel: val.channel, [INFO] [stdout] 124 ~ frequency: val.frequency, [INFO] [stdout] 125 ~ signal_strength: val.rssi, [INFO] [stdout] 126 ~ signal_to_noise_ratio: val.snr, [INFO] [stdout] 127 ~ ssid: val.ssid, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | impl Into for WifiPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 133 ~ impl From for WifiProcess { [INFO] [stdout] 134 ~ fn from(val: WifiPublic) -> Self { [INFO] [stdout] 135 | WifiProcess { [INFO] [stdout] 136 ~ mac_address: val.mac, [INFO] [stdout] 137 ~ age: val.age, [INFO] [stdout] 138 ~ signal_strength: val.rssi, [INFO] [stdout] 139 ~ ssid: val.ssid, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/lbs/yandex/wifi.rs:364:13 [INFO] [stdout] | [INFO] [stdout] 364 | / if let Err(e) = yandex_client [INFO] [stdout] 365 | | .post_for_data( [INFO] [stdout] 366 | | &mac, [INFO] [stdout] 367 | | &yandex_lbs_url, [INFO] [stdout] ... | [INFO] [stdout] 378 | | return Err(e); [INFO] [stdout] 379 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] help: replace it with [INFO] [stdout] | [INFO] [stdout] 364 ~ yandex_client [INFO] [stdout] 365 + .post_for_data( [INFO] [stdout] 366 + &mac, [INFO] [stdout] 367 + &yandex_lbs_url, [INFO] [stdout] 368 + &yandex_lbs_request, [INFO] [stdout] 369 + tx_yandex_api.clone(), [INFO] [stdout] 370 + api_key, [INFO] [stdout] 371 + &mut lbs_responses, [INFO] [stdout] 372 + tx_t38_conn.clone(), [INFO] [stdout] 373 + tx_ba_conn.clone(), [INFO] [stdout] 374 + collection, [INFO] [stdout] 375 + ) [INFO] [stdout] 376 + .await? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:161:1 [INFO] [stdout] | [INFO] [stdout] 161 | impl Into for PositionPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 161 ~ impl From for Position { [INFO] [stdout] 162 ~ fn from(val: PositionPublic) -> Self { [INFO] [stdout] 163 | Position { [INFO] [stdout] 164 ~ latitude: val.latitude, [INFO] [stdout] 165 ~ longitude: val.longitude, [INFO] [stdout] 166 ~ accuracy: val.accuracy, [INFO] [stdout] 167 ~ altitude: val.altitude, [INFO] [stdout] 168 ~ altitude_accuracy: val.altitude_accuracy, [INFO] [stdout] 169 ~ age: val.age, [INFO] [stdout] 170 ~ speed: val.speed, [INFO] [stdout] 171 ~ heading: val.bearing, [INFO] [stdout] 172 ~ pressure: val.pressure, [INFO] [stdout] 173 ~ source: val.source, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:179:1 [INFO] [stdout] | [INFO] [stdout] 179 | impl Into for PositionPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 179 ~ impl From for PositionProcess { [INFO] [stdout] 180 ~ fn from(val: PositionPublic) -> Self { [INFO] [stdout] 181 | PositionProcess { [INFO] [stdout] 182 ~ latitude: val.latitude, [INFO] [stdout] 183 ~ longitude: val.longitude, [INFO] [stdout] 184 ~ accuracy: val.accuracy, [INFO] [stdout] 185 ~ age: val.age, [INFO] [stdout] 186 ~ speed: val.speed, [INFO] [stdout] 187 ~ heading: val.bearing, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / if let Some(rp) = sp.items.first() { [INFO] [stdout] 202 | | if !valid_cell(rp.cell.as_ref()) { [INFO] [stdout] 203 | | return Ok(HttpResponse::UnprocessableEntity().json(json!( [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 201 ~ if let Some(rp) = sp.items.first() [INFO] [stdout] 202 ~ && !valid_cell(rp.cell.as_ref()) { [INFO] [stdout] 203 | return Ok(HttpResponse::UnprocessableEntity().json(json!( [INFO] [stdout] ... [INFO] [stdout] 212 | ))); [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1045:13 [INFO] [stdout] | [INFO] [stdout] 1045 | lat_weighted = lat_weighted + ylr.location.point.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted += ylr.location.point.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1046:13 [INFO] [stdout] | [INFO] [stdout] 1046 | lon_weighted = lon_weighted + ylr.location.point.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted += ylr.location.point.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1047:13 [INFO] [stdout] | [INFO] [stdout] 1047 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/lbs/yandex/wifi.rs:1104:52 [INFO] [stdout] | [INFO] [stdout] 1104 | ... for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 1104 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 1104 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/services/submission/report.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / pub async fn process_report( [INFO] [stdout] 97 | | data: web::Json, [INFO] [stdout] 98 | | pool_tp: web::Data, [INFO] [stdout] 99 | | tx_t38_conn: web::Data>, [INFO] [stdout] ... | [INFO] [stdout] 104 | | _req: HttpRequest, [INFO] [stdout] 105 | | ) -> actix_web::Result { [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.signal_strength` after checking its variant with `is_some` [INFO] [stdout] --> src/services/submission/report.rs:282:25 [INFO] [stdout] | [INFO] [stdout] 281 | if self.signal_strength.is_some() { [INFO] [stdout] | --------------------------------- help: try: `if let Some() = self.signal_strength` [INFO] [stdout] 282 | return Some(self.signal_strength.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/blobasaur.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Some(_e) = error { [INFO] [stdout] 37 | | if let Ok(client) = ba_client(&CONFIG.blobasaur.host, CONFIG.blobasaur.port) [INFO] [stdout] 38 | | { [INFO] [stdout] 39 | | if client [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if let Some(_e) = error [INFO] [stdout] 37 ~ && let Ok(client) = ba_client(&CONFIG.blobasaur.host, CONFIG.blobasaur.port) [INFO] [stdout] 38 | { [INFO] [stdout] ... [INFO] [stdout] 63 | } [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:45:40 [INFO] [stdout] | [INFO] [stdout] 45 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] | -------^^^^^^--------------------------- help: try: `if tx.send(Some(c.clone())).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 75 | if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/blobasaur.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | / if let Ok(c) = client.get_multiplexed_async_connection().await { [INFO] [stdout] 167 | | if let Ok(mut recover_pool) = connection_pool().await { [INFO] [stdout] 168 | | recover_pool.push(c); [INFO] [stdout] 169 | | if let Err(e) = tx_ba_conn [INFO] [stdout] ... | [INFO] [stdout] 178 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ if let Ok(c) = client.get_multiplexed_async_connection().await [INFO] [stdout] 167 ~ && let Ok(mut recover_pool) = connection_pool().await { [INFO] [stdout] 168 | recover_pool.push(c); [INFO] [stdout] ... [INFO] [stdout] 176 | } [INFO] [stdout] 177 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Id` [INFO] [stdout] --> src/tasks/report.rs:311:1 [INFO] [stdout] | [INFO] [stdout] 311 | / pub enum MessageServicePartition { [INFO] [stdout] 312 | | RangeId { [INFO] [stdout] 313 | | partition: String, [INFO] [stdout] 314 | | tx: oneshot::Sender>, [INFO] [stdout] ... | [INFO] [stdout] 323 | | }, [INFO] [stdout] 324 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:338:32 [INFO] [stdout] | [INFO] [stdout] 338 | if let Err(_) = tx.send(Some(*range)) { [INFO] [stdout] | -------^^^^^^------------------------ help: try: `if tx.send(Some(*range)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:345:40 [INFO] [stdout] | [INFO] [stdout] 345 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:352:44 [INFO] [stdout] | [INFO] [stdout] 352 | ... if let Err(_) = tx.send(Some(*r)) { [INFO] [stdout] | -------^^^^^^-------------------- help: try: `if tx.send(Some(*r)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:359:44 [INFO] [stdout] | [INFO] [stdout] 359 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:369:32 [INFO] [stdout] | [INFO] [stdout] 369 | if let Err(_) = tx.send(Some(*lid)) { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(Some(*lid)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DBSCAN` contains a capitalized acronym [INFO] [stdout] --> src/services/locate/dbscan/mod.rs:172:12 [INFO] [stdout] | [INFO] [stdout] 172 | pub struct DBSCAN [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Dbscan` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:225:29 [INFO] [stdout] | [INFO] [stdout] 225 | / ... if let Some(c) = connections.get(index_conn) { [INFO] [stdout] 226 | | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 227 | | ... error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 228 | | ... } [INFO] [stdout] 229 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 225 ~ if let Some(c) = connections.get(index_conn) [INFO] [stdout] 226 ~ && let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 227 | error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/t38/master_replica.rs:226:40 [INFO] [stdout] | [INFO] [stdout] 226 | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] | -------^^^^^^--------------------------- help: try: `if tx.send(Some(c.clone())).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/locate/geolocate.rs:179:49 [INFO] [stdout] | [INFO] [stdout] 179 | if check_outlier(outliers_opt.as_ref(), &tl) { [INFO] [stdout] | ^^^ help: change this to: `tl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:194:13 [INFO] [stdout] | [INFO] [stdout] 194 | lat_weight = lat_weight + tl.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight += tl.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:195:13 [INFO] [stdout] | [INFO] [stdout] 195 | lon_weight = lon_weight + tl.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight += tl.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:196:13 [INFO] [stdout] | [INFO] [stdout] 196 | r_weight = r_weight + tl.accuracy * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight += tl.accuracy * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:198:13 [INFO] [stdout] | [INFO] [stdout] 198 | c = c + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `c += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | lat_weight = lat_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | lon_weight = lon_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | r_weight = r_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 367 | / ... if let Some(c) = connections.get(index_conn_srv) { [INFO] [stdout] 368 | | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 369 | | ... error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 370 | | ... } [INFO] [stdout] 371 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 367 ~ if let Some(c) = connections.get(index_conn_srv) [INFO] [stdout] 368 ~ && let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 369 | error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 370 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/t38/master_replica.rs:368:40 [INFO] [stdout] | [INFO] [stdout] 368 | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] | -------^^^^^^--------------------------- help: try: `if tx.send(Some(c.clone())).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/services/locate/geolocate.rs:243:48 [INFO] [stdout] | [INFO] [stdout] 243 | for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 243 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 243 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:410:63 [INFO] [stdout] | [INFO] [stdout] 410 | .get_multiplexed_async_connection_with_config(&t38_conn_config) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:430:45 [INFO] [stdout] | [INFO] [stdout] 430 | ... &t38_conn_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:458:74 [INFO] [stdout] | [INFO] [stdout] 458 | ... connection_pool(connection, &client, &t38_conn_config).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:480:74 [INFO] [stdout] | [INFO] [stdout] 480 | ... connection_pool(connection, &client, &t38_conn_config).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:497:70 [INFO] [stdout] | [INFO] [stdout] 497 | ... connection_pool(connection, &client, &t38_conn_config).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | / if let Ok(connection) = node.client.get_multiplexed_async_connection().await { [INFO] [stdout] 544 | | if let Ok(role) = get_role(connection).await { [INFO] [stdout] 545 | | if let Some(r) = role { [INFO] [stdout] 546 | | node.role = Some(r.clone()); [INFO] [stdout] ... | [INFO] [stdout] 553 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 543 ~ if let Ok(connection) = node.client.get_multiplexed_async_connection().await [INFO] [stdout] 544 ~ && let Ok(role) = get_role(connection).await { [INFO] [stdout] 545 | if let Some(r) = role { [INFO] [stdout] ... [INFO] [stdout] 551 | } [INFO] [stdout] 552 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/tasks/t38/master_replica.rs:545:21 [INFO] [stdout] | [INFO] [stdout] 545 | / if let Some(r) = role { [INFO] [stdout] 546 | | node.role = Some(r.clone()); [INFO] [stdout] 547 | | nodes.insert(key, node.clone()); [INFO] [stdout] 548 | | if r.contains(role_name) { [INFO] [stdout] ... | [INFO] [stdout] 551 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/tasks/t38/master_replica.rs:544:27 [INFO] [stdout] | [INFO] [stdout] 544 | if let Ok(role) = get_role(connection).await { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 545 | if let Some(r) = role { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:544:17 [INFO] [stdout] | [INFO] [stdout] 544 | / if let Ok(role) = get_role(connection).await { [INFO] [stdout] 545 | | if let Some(r) = role { [INFO] [stdout] 546 | | node.role = Some(r.clone()); [INFO] [stdout] 547 | | nodes.insert(key, node.clone()); [INFO] [stdout] ... | [INFO] [stdout] 552 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 544 ~ if let Ok(role) = get_role(connection).await [INFO] [stdout] 545 ~ && let Some(r) = role { [INFO] [stdout] 546 | node.role = Some(r.clone()); [INFO] [stdout] ... [INFO] [stdout] 550 | } [INFO] [stdout] 551 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:688:63 [INFO] [stdout] | [INFO] [stdout] 688 | .get_multiplexed_async_connection_with_config(&t38_conn_config) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tasks/t38/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod t38; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `ApiKey` [INFO] [stdout] --> src/tasks/yandex.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / pub enum YandexApiMessage { [INFO] [stdout] 39 | | GetApiKey { tx: oneshot::Sender> }, [INFO] [stdout] 40 | | InvalidApiKey { invalid_api_key: InvalidApiKey }, [INFO] [stdout] 41 | | ValidApiKey { valid_api_key: ValidApiKey }, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/services/locate/geolocate_public.rs:260:49 [INFO] [stdout] | [INFO] [stdout] 260 | if check_outlier(outliers_opt.as_ref(), &tl) { [INFO] [stdout] | ^^^ help: change this to: `tl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:274:13 [INFO] [stdout] | [INFO] [stdout] 274 | lat_weight = lat_weight + tl.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight += tl.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:275:13 [INFO] [stdout] | [INFO] [stdout] 275 | lon_weight = lon_weight + tl.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight += tl.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:276:13 [INFO] [stdout] | [INFO] [stdout] 276 | r_weight = r_weight + tl.accuracy * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight += tl.accuracy * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:277:13 [INFO] [stdout] | [INFO] [stdout] 277 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | c = c + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `c += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/services/locate/geolocate_public.rs:297:40 [INFO] [stdout] | [INFO] [stdout] 297 | for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 297 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 297 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/yandex.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 98 | / ... if let Ok(status) = yandex_client.post_for_status(&yandex_lbs_url, &yandex_lbs_request).await { [INFO] [stdout] 99 | | ... if status == 200 && let Some(valid_key) = invalid_api_keys.remove(&i) { [INFO] [stdout] 100 | | ... let m = YandexApiMessage::ValidApiKey { valid_api_key: ValidApiKey {key: valid_key.key, i} }; [INFO] [stdout] 101 | | ... if let Err(e) = tx.send_async(m).await { [INFO] [stdout] ... | [INFO] [stdout] 105 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 98 ~ if let Ok(status) = yandex_client.post_for_status(&yandex_lbs_url, &yandex_lbs_request).await [INFO] [stdout] 99 ~ && status == 200 && let Some(valid_key) = invalid_api_keys.remove(&i) { [INFO] [stdout] 100 | let m = YandexApiMessage::ValidApiKey { valid_api_key: ValidApiKey {key: valid_key.key, i} }; [INFO] [stdout] ... [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | lat_weight = lat_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | lon_weight = lon_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/locate/geolocate_public.rs:336:9 [INFO] [stdout] | [INFO] [stdout] 336 | r_weight = r_weight / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `r_weight /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/yandex.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | / if let Some((i, k)) = active_api_keys.iter().next() { [INFO] [stdout] 151 | | if tx [INFO] [stdout] 152 | | .send(Some(ApiKey { [INFO] [stdout] 153 | | key: k.clone(), [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 150 ~ if let Some((i, k)) = active_api_keys.iter().next() [INFO] [stdout] 151 ~ && tx [INFO] [stdout] 152 | .send(Some(ApiKey { [INFO] [stdout] ... [INFO] [stdout] 158 | error!("send Yandex api key"); [INFO] [stdout] 159 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's keys [INFO] [stdout] --> src/services/locate/geolocate_public.rs:386:48 [INFO] [stdout] | [INFO] [stdout] 386 | for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 386 - for (mac, _ylr_opt) in outliers.outliers() { [INFO] [stdout] 386 + for mac in outliers.outliers().keys() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/config/config.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | let hc = vec![HC::Reqwest.to_string(), HC::Surf.to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[HC::Reqwest.to_string(), HC::Surf.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:33:1 [INFO] [stdout] | [INFO] [stdout] 33 | impl Into for SubmissionPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 33 ~ impl From for Submission { [INFO] [stdout] 34 ~ fn from(val: SubmissionPublic) -> Self { [INFO] [stdout] 35 | Submission { [INFO] [stdout] 36 ~ items: val.items.into_iter().map(|rp| rp.into()).collect(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:56:1 [INFO] [stdout] | [INFO] [stdout] 56 | impl Into for ReportPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 56 ~ impl From for Report { [INFO] [stdout] 57 ~ fn from(val: ReportPublic) -> Self { [INFO] [stdout] 58 ~ let wap = val.wifi.map(|vec_wp| { [INFO] [stdout] 59 | vec_wp [INFO] [stdout] ... [INFO] [stdout] 64 | Report { [INFO] [stdout] 65 ~ timestamp: val.timestamp, [INFO] [stdout] 66 ~ device_id: val.device_id, [INFO] [stdout] 67 ~ position: val.gnss.into(), [INFO] [stdout] 68 | wifi_access_points: wap, [INFO] [stdout] 69 ~ cell: val.cell, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:77:1 [INFO] [stdout] | [INFO] [stdout] 77 | impl Into for ReportPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 77 ~ impl From for ReportProcess { [INFO] [stdout] 78 ~ fn from(val: ReportPublic) -> Self { [INFO] [stdout] 79 ~ let wap = val.wifi.map(|vec_wp| { [INFO] [stdout] 80 | vec_wp [INFO] [stdout] ... [INFO] [stdout] 85 | ReportProcess { [INFO] [stdout] 86 ~ timestamp: val.timestamp.timestamp(), [INFO] [stdout] 87 ~ device_id: val.device_id, [INFO] [stdout] 88 ~ position: val.gnss.into(), [INFO] [stdout] 89 | wifi_access_points: wap, [INFO] [stdout] 90 ~ cell: val.cell, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:117:1 [INFO] [stdout] | [INFO] [stdout] 117 | impl Into for WifiPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 117 ~ impl From for Wifi { [INFO] [stdout] 118 ~ fn from(val: WifiPublic) -> Self { [INFO] [stdout] 119 | Wifi { [INFO] [stdout] 120 ~ mac_address: val.mac, [INFO] [stdout] 121 ~ radio_type: val.radio_type, [INFO] [stdout] 122 ~ age: val.age, [INFO] [stdout] 123 ~ channel: val.channel, [INFO] [stdout] 124 ~ frequency: val.frequency, [INFO] [stdout] 125 ~ signal_strength: val.rssi, [INFO] [stdout] 126 ~ signal_to_noise_ratio: val.snr, [INFO] [stdout] 127 ~ ssid: val.ssid, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | impl Into for WifiPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 133 ~ impl From for WifiProcess { [INFO] [stdout] 134 ~ fn from(val: WifiPublic) -> Self { [INFO] [stdout] 135 | WifiProcess { [INFO] [stdout] 136 ~ mac_address: val.mac, [INFO] [stdout] 137 ~ age: val.age, [INFO] [stdout] 138 ~ signal_strength: val.rssi, [INFO] [stdout] 139 ~ ssid: val.ssid, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:161:1 [INFO] [stdout] | [INFO] [stdout] 161 | impl Into for PositionPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 161 ~ impl From for Position { [INFO] [stdout] 162 ~ fn from(val: PositionPublic) -> Self { [INFO] [stdout] 163 | Position { [INFO] [stdout] 164 ~ latitude: val.latitude, [INFO] [stdout] 165 ~ longitude: val.longitude, [INFO] [stdout] 166 ~ accuracy: val.accuracy, [INFO] [stdout] 167 ~ altitude: val.altitude, [INFO] [stdout] 168 ~ altitude_accuracy: val.altitude_accuracy, [INFO] [stdout] 169 ~ age: val.age, [INFO] [stdout] 170 ~ speed: val.speed, [INFO] [stdout] 171 ~ heading: val.bearing, [INFO] [stdout] 172 ~ pressure: val.pressure, [INFO] [stdout] 173 ~ source: val.source, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:179:1 [INFO] [stdout] | [INFO] [stdout] 179 | impl Into for PositionPublic { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 179 ~ impl From for PositionProcess { [INFO] [stdout] 180 ~ fn from(val: PositionPublic) -> Self { [INFO] [stdout] 181 | PositionProcess { [INFO] [stdout] 182 ~ latitude: val.latitude, [INFO] [stdout] 183 ~ longitude: val.longitude, [INFO] [stdout] 184 ~ accuracy: val.accuracy, [INFO] [stdout] 185 ~ age: val.age, [INFO] [stdout] 186 ~ speed: val.speed, [INFO] [stdout] 187 ~ heading: val.bearing, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/services/submission/geosubmit_public.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 201 | / if let Some(rp) = sp.items.first() { [INFO] [stdout] 202 | | if !valid_cell(rp.cell.as_ref()) { [INFO] [stdout] 203 | | return Ok(HttpResponse::UnprocessableEntity().json(json!( [INFO] [stdout] ... | [INFO] [stdout] 214 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 201 ~ if let Some(rp) = sp.items.first() [INFO] [stdout] 202 ~ && !valid_cell(rp.cell.as_ref()) { [INFO] [stdout] 203 | return Ok(HttpResponse::UnprocessableEntity().json(json!( [INFO] [stdout] ... [INFO] [stdout] 212 | ))); [INFO] [stdout] 213 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:347:13 [INFO] [stdout] | [INFO] [stdout] 347 | lat_weighted = lat_weighted + yp.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted += yp.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:348:13 [INFO] [stdout] | [INFO] [stdout] 348 | lon_weighted = lon_weighted + yp.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted += yp.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:349:13 [INFO] [stdout] | [INFO] [stdout] 349 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:353:13 [INFO] [stdout] | [INFO] [stdout] 353 | lat_weighted = lat_weighted / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:354:13 [INFO] [stdout] | [INFO] [stdout] 354 | lon_weighted = lon_weighted / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:405:13 [INFO] [stdout] | [INFO] [stdout] 405 | lat_weighted = lat_weighted + yp.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted += yp.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:406:13 [INFO] [stdout] | [INFO] [stdout] 406 | lon_weighted = lon_weighted + yp.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted += yp.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:407:13 [INFO] [stdout] | [INFO] [stdout] 407 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:411:13 [INFO] [stdout] | [INFO] [stdout] 411 | lat_weighted = lat_weighted / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:412:13 [INFO] [stdout] | [INFO] [stdout] 412 | lon_weighted = lon_weighted / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:447:13 [INFO] [stdout] | [INFO] [stdout] 447 | lat_weighted = lat_weighted + yp.lat * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted += yp.lat * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:448:13 [INFO] [stdout] | [INFO] [stdout] 448 | lon_weighted = lon_weighted + yp.lon * weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted += yp.lon * weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:449:13 [INFO] [stdout] | [INFO] [stdout] 449 | w_weight = w_weight + weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w_weight += weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:453:13 [INFO] [stdout] | [INFO] [stdout] 453 | lat_weighted = lat_weighted / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lat_weighted /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/services/submission/process.rs:454:13 [INFO] [stdout] | [INFO] [stdout] 454 | lon_weighted = lon_weighted / w_weight; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lon_weighted /= w_weight` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/services/submission/report.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / pub async fn process_report( [INFO] [stdout] 97 | | data: web::Json, [INFO] [stdout] 98 | | pool_tp: web::Data, [INFO] [stdout] 99 | | tx_t38_conn: web::Data>, [INFO] [stdout] ... | [INFO] [stdout] 104 | | _req: HttpRequest, [INFO] [stdout] 105 | | ) -> actix_web::Result { [INFO] [stdout] | |______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.signal_strength` after checking its variant with `is_some` [INFO] [stdout] --> src/services/submission/report.rs:282:25 [INFO] [stdout] | [INFO] [stdout] 281 | if self.signal_strength.is_some() { [INFO] [stdout] | --------------------------------- help: try: `if let Some() = self.signal_strength` [INFO] [stdout] 282 | return Some(self.signal_strength.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/blobasaur.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | / if let Some(_e) = error { [INFO] [stdout] 37 | | if let Ok(client) = ba_client(&CONFIG.blobasaur.host, CONFIG.blobasaur.port) [INFO] [stdout] 38 | | { [INFO] [stdout] 39 | | if client [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 36 ~ if let Some(_e) = error [INFO] [stdout] 37 ~ && let Ok(client) = ba_client(&CONFIG.blobasaur.host, CONFIG.blobasaur.port) [INFO] [stdout] 38 | { [INFO] [stdout] ... [INFO] [stdout] 63 | } [INFO] [stdout] 64 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:45:40 [INFO] [stdout] | [INFO] [stdout] 45 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:58:44 [INFO] [stdout] | [INFO] [stdout] 58 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] | -------^^^^^^--------------------------- help: try: `if tx.send(Some(c.clone())).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/blobasaur.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 75 | if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/blobasaur.rs:166:17 [INFO] [stdout] | [INFO] [stdout] 166 | / if let Ok(c) = client.get_multiplexed_async_connection().await { [INFO] [stdout] 167 | | if let Ok(mut recover_pool) = connection_pool().await { [INFO] [stdout] 168 | | recover_pool.push(c); [INFO] [stdout] 169 | | if let Err(e) = tx_ba_conn [INFO] [stdout] ... | [INFO] [stdout] 178 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 166 ~ if let Ok(c) = client.get_multiplexed_async_connection().await [INFO] [stdout] 167 ~ && let Ok(mut recover_pool) = connection_pool().await { [INFO] [stdout] 168 | recover_pool.push(c); [INFO] [stdout] ... [INFO] [stdout] 176 | } [INFO] [stdout] 177 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Id` [INFO] [stdout] --> src/tasks/report.rs:311:1 [INFO] [stdout] | [INFO] [stdout] 311 | / pub enum MessageServicePartition { [INFO] [stdout] 312 | | RangeId { [INFO] [stdout] 313 | | partition: String, [INFO] [stdout] 314 | | tx: oneshot::Sender>, [INFO] [stdout] ... | [INFO] [stdout] 323 | | }, [INFO] [stdout] 324 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:338:32 [INFO] [stdout] | [INFO] [stdout] 338 | if let Err(_) = tx.send(Some(*range)) { [INFO] [stdout] | -------^^^^^^------------------------ help: try: `if tx.send(Some(*range)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:345:40 [INFO] [stdout] | [INFO] [stdout] 345 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:352:44 [INFO] [stdout] | [INFO] [stdout] 352 | ... if let Err(_) = tx.send(Some(*r)) { [INFO] [stdout] | -------^^^^^^-------------------- help: try: `if tx.send(Some(*r)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:359:44 [INFO] [stdout] | [INFO] [stdout] 359 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:369:32 [INFO] [stdout] | [INFO] [stdout] 369 | if let Err(_) = tx.send(Some(*lid)) { [INFO] [stdout] | -------^^^^^^---------------------- help: try: `if tx.send(Some(*lid)).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/report.rs:376:40 [INFO] [stdout] | [INFO] [stdout] 376 | ... if let Err(_) = tx.send(None) { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if tx.send(None).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:225:29 [INFO] [stdout] | [INFO] [stdout] 225 | / ... if let Some(c) = connections.get(index_conn) { [INFO] [stdout] 226 | | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 227 | | ... error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 228 | | ... } [INFO] [stdout] 229 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 225 ~ if let Some(c) = connections.get(index_conn) [INFO] [stdout] 226 ~ && let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 227 | error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 228 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/t38/master_replica.rs:226:40 [INFO] [stdout] | [INFO] [stdout] 226 | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] | -------^^^^^^--------------------------- help: try: `if tx.send(Some(c.clone())).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:367:29 [INFO] [stdout] | [INFO] [stdout] 367 | / ... if let Some(c) = connections.get(index_conn_srv) { [INFO] [stdout] 368 | | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 369 | | ... error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 370 | | ... } [INFO] [stdout] 371 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 367 ~ if let Some(c) = connections.get(index_conn_srv) [INFO] [stdout] 368 ~ && let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] 369 | error!("{}", ERROR_SEND_CONNECTION); [INFO] [stdout] 370 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/tasks/t38/master_replica.rs:368:40 [INFO] [stdout] | [INFO] [stdout] 368 | ... if let Err(_) = tx.send(Some(c.clone())) { [INFO] [stdout] | -------^^^^^^--------------------------- help: try: `if tx.send(Some(c.clone())).is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:410:63 [INFO] [stdout] | [INFO] [stdout] 410 | .get_multiplexed_async_connection_with_config(&t38_conn_config) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:430:45 [INFO] [stdout] | [INFO] [stdout] 430 | ... &t38_conn_config, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:458:74 [INFO] [stdout] | [INFO] [stdout] 458 | ... connection_pool(connection, &client, &t38_conn_config).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:480:74 [INFO] [stdout] | [INFO] [stdout] 480 | ... connection_pool(connection, &client, &t38_conn_config).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:497:70 [INFO] [stdout] | [INFO] [stdout] 497 | ... connection_pool(connection, &client, &t38_conn_config).await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:543:13 [INFO] [stdout] | [INFO] [stdout] 543 | / if let Ok(connection) = node.client.get_multiplexed_async_connection().await { [INFO] [stdout] 544 | | if let Ok(role) = get_role(connection).await { [INFO] [stdout] 545 | | if let Some(r) = role { [INFO] [stdout] 546 | | node.role = Some(r.clone()); [INFO] [stdout] ... | [INFO] [stdout] 553 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 543 ~ if let Ok(connection) = node.client.get_multiplexed_async_connection().await [INFO] [stdout] 544 ~ && let Ok(role) = get_role(connection).await { [INFO] [stdout] 545 | if let Some(r) = role { [INFO] [stdout] ... [INFO] [stdout] 551 | } [INFO] [stdout] 552 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/tasks/t38/master_replica.rs:545:21 [INFO] [stdout] | [INFO] [stdout] 545 | / if let Some(r) = role { [INFO] [stdout] 546 | | node.role = Some(r.clone()); [INFO] [stdout] 547 | | nodes.insert(key, node.clone()); [INFO] [stdout] 548 | | if r.contains(role_name) { [INFO] [stdout] ... | [INFO] [stdout] 551 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/tasks/t38/master_replica.rs:544:27 [INFO] [stdout] | [INFO] [stdout] 544 | if let Ok(role) = get_role(connection).await { [INFO] [stdout] | ^^^^ replace this binding [INFO] [stdout] 545 | if let Some(r) = role { [INFO] [stdout] | ^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/t38/master_replica.rs:544:17 [INFO] [stdout] | [INFO] [stdout] 544 | / if let Ok(role) = get_role(connection).await { [INFO] [stdout] 545 | | if let Some(r) = role { [INFO] [stdout] 546 | | node.role = Some(r.clone()); [INFO] [stdout] 547 | | nodes.insert(key, node.clone()); [INFO] [stdout] ... | [INFO] [stdout] 552 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 544 ~ if let Ok(role) = get_role(connection).await [INFO] [stdout] 545 ~ && let Some(r) = role { [INFO] [stdout] 546 | node.role = Some(r.clone()); [INFO] [stdout] ... [INFO] [stdout] 550 | } [INFO] [stdout] 551 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tasks/t38/master_replica.rs:688:63 [INFO] [stdout] | [INFO] [stdout] 688 | .get_multiplexed_async_connection_with_config(&t38_conn_config) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `t38_conn_config` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tasks/t38/mod.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | mod t38; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `ApiKey` [INFO] [stdout] --> src/tasks/yandex.rs:38:1 [INFO] [stdout] | [INFO] [stdout] 38 | / pub enum YandexApiMessage { [INFO] [stdout] 39 | | GetApiKey { tx: oneshot::Sender> }, [INFO] [stdout] 40 | | InvalidApiKey { invalid_api_key: InvalidApiKey }, [INFO] [stdout] 41 | | ValidApiKey { valid_api_key: ValidApiKey }, [INFO] [stdout] 42 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/yandex.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 98 | / ... if let Ok(status) = yandex_client.post_for_status(&yandex_lbs_url, &yandex_lbs_request).await { [INFO] [stdout] 99 | | ... if status == 200 && let Some(valid_key) = invalid_api_keys.remove(&i) { [INFO] [stdout] 100 | | ... let m = YandexApiMessage::ValidApiKey { valid_api_key: ValidApiKey {key: valid_key.key, i} }; [INFO] [stdout] 101 | | ... if let Err(e) = tx.send_async(m).await { [INFO] [stdout] ... | [INFO] [stdout] 105 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 98 ~ if let Ok(status) = yandex_client.post_for_status(&yandex_lbs_url, &yandex_lbs_request).await [INFO] [stdout] 99 ~ && status == 200 && let Some(valid_key) = invalid_api_keys.remove(&i) { [INFO] [stdout] 100 | let m = YandexApiMessage::ValidApiKey { valid_api_key: ValidApiKey {key: valid_key.key, i} }; [INFO] [stdout] ... [INFO] [stdout] 103 | } [INFO] [stdout] 104 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tasks/yandex.rs:150:25 [INFO] [stdout] | [INFO] [stdout] 150 | / if let Some((i, k)) = active_api_keys.iter().next() { [INFO] [stdout] 151 | | if tx [INFO] [stdout] 152 | | .send(Some(ApiKey { [INFO] [stdout] 153 | | key: k.clone(), [INFO] [stdout] ... | [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 150 ~ if let Some((i, k)) = active_api_keys.iter().next() [INFO] [stdout] 151 ~ && tx [INFO] [stdout] 152 | .send(Some(ApiKey { [INFO] [stdout] ... [INFO] [stdout] 158 | error!("send Yandex api key"); [INFO] [stdout] 159 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/config/config.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | let hc = vec![HC::Reqwest.to_string(), HC::Surf.to_string()]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[HC::Reqwest.to_string(), HC::Surf.to_string()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/services/submission/process.rs:366:24 [INFO] [stdout] | [INFO] [stdout] 366 | let rssi_arr = vec![-67.0, -72.0, -67.0, -70.0, -75.0, -76.0, -80.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[-67.0, -72.0, -67.0, -70.0, -75.0, -76.0, -80.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/services/submission/process.rs:424:24 [INFO] [stdout] | [INFO] [stdout] 424 | let rssi_arr = vec![-88.0, -73.0, -64.0]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[-88.0, -73.0, -64.0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 45s [INFO] running `Command { std: "docker" "inspect" "3bbecba929090c25e68e09f80f7a2e56913f1f7831e610109d88314bb84c6f21", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bbecba929090c25e68e09f80f7a2e56913f1f7831e610109d88314bb84c6f21", kill_on_drop: false }` [INFO] [stdout] 3bbecba929090c25e68e09f80f7a2e56913f1f7831e610109d88314bb84c6f21