[INFO] cloning repository https://github.com/ethan-hawksley/nintendrust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ethan-hawksley/nintendrust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fethan-hawksley%2Fnintendrust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fethan-hawksley%2Fnintendrust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 076e6aaa8ca147082db2d8095ef6e0c4c5293e84 [INFO] linting ethan-hawksley/nintendrust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fethan-hawksley%2Fnintendrust" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ethan-hawksley/nintendrust [INFO] finished tweaking git repo https://github.com/ethan-hawksley/nintendrust [INFO] tweaked toml for git repo https://github.com/ethan-hawksley/nintendrust written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ethan-hawksley/nintendrust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ethan-hawksley/nintendrust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.109 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.109 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.109 [INFO] [stderr] Downloaded wasm-bindgen v0.2.109 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ae83d8cb01ad44290cb7f8da6088d57007dfbf5b7b0b2fdffe56c6a39bf4eb0 [INFO] running `Command { std: "docker" "start" "-a" "7ae83d8cb01ad44290cb7f8da6088d57007dfbf5b7b0b2fdffe56c6a39bf4eb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ae83d8cb01ad44290cb7f8da6088d57007dfbf5b7b0b2fdffe56c6a39bf4eb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ae83d8cb01ad44290cb7f8da6088d57007dfbf5b7b0b2fdffe56c6a39bf4eb0", kill_on_drop: false }` [INFO] [stdout] 7ae83d8cb01ad44290cb7f8da6088d57007dfbf5b7b0b2fdffe56c6a39bf4eb0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63e94d9b632484e3c0b67650d3a19e8326704ba3dc02c878d7a3fc84a99c1d41 [INFO] running `Command { std: "docker" "start" "-a" "63e94d9b632484e3c0b67650d3a19e8326704ba3dc02c878d7a3fc84a99c1d41", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.109 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Compiling wasm-bindgen v0.2.109 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.109 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.109 [INFO] [stderr] Checking nintendrust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/ppu.rs:635:44 [INFO] [stdout] | [INFO] [stdout] 635 | self.address_bus = ((self.vram_address & 0b0111000000000000) >> 12) [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 636 | | | self.cycle_next_character as u16 * 16 [INFO] [stdout] | |___________________________________________________________________^ help: consider parenthesizing your expression: `((self.vram_address & 0b0111000000000000) >> 12) | (self.cycle_next_character as u16 * 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/ppu.rs:635:44 [INFO] [stdout] | [INFO] [stdout] 635 | self.address_bus = ((self.vram_address & 0b0111000000000000) >> 12) [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 636 | | | self.cycle_next_character as u16 * 16 [INFO] [stdout] | |___________________________________________________________________^ help: consider parenthesizing your expression: `((self.vram_address & 0b0111000000000000) >> 12) | (self.cycle_next_character as u16 * 16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Cpu` [INFO] [stdout] --> src/cpu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | Cpu { [INFO] [stdout] 23 | | program_counter: 0, [INFO] [stdout] 24 | | a: 0, [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for Cpu { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 122 | let value = bus.read(0x100 + self.stack_pointer as u16); [INFO] [stdout] | -------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 123 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 122 ~ [INFO] [stdout] 123 ~ bus.read(0x100 + self.stack_pointer as u16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cpu.rs:358:22 [INFO] [stdout] | [INFO] [stdout] 358 | let do_nmi = if !previous_nmi_level_detector && self.nmi_level_detector { [INFO] [stdout] | ______________________^ [INFO] [stdout] 359 | | true [INFO] [stdout] 360 | | } else { [INFO] [stdout] 361 | | false [INFO] [stdout] 362 | | }; [INFO] [stdout] | |_________^ help: you can reduce it to: `!previous_nmi_level_detector && self.nmi_level_detector` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | 0 | (self.v_blank as u8) << 7 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((self.v_blank as u8) << 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:179:30 [INFO] [stdout] | [INFO] [stdout] 179 | let status = 0 [INFO] [stdout] | ______________________________^ [INFO] [stdout] 180 | | | (self.v_blank as u8) << 7 [INFO] [stdout] | |_______________________________________________^ help: consider reducing it to: `((self.v_blank as u8) << 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | / if !self.sprite_evaluation_oam_overflowed { [INFO] [stdout] 421 | | if !self.secondary_oam_full && self.secondary_oam_address < 32 { [INFO] [stdout] 422 | | // If secondary OAM isn't full, the write always occurs. [INFO] [stdout] 423 | | self.secondary_oam[self.secondary_oam_address as usize] = [INFO] [stdout] ... | [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 420 ~ if !self.sprite_evaluation_oam_overflowed [INFO] [stdout] 421 ~ && !self.secondary_oam_full && self.secondary_oam_address < 32 { [INFO] [stdout] 422 | // If secondary OAM isn't full, the write always occurs. [INFO] [stdout] 423 | self.secondary_oam[self.secondary_oam_address as usize] = [INFO] [stdout] 424 | self.sprite_evaluation_temp; [INFO] [stdout] 425 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:740:16 [INFO] [stdout] | [INFO] [stdout] 740 | if (sprite_priority && palette_low != 0) || palette_low == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 740 - if (sprite_priority && palette_low != 0) || palette_low == 0 { [INFO] [stdout] 740 + if !(!sprite_priority && palette_low != 0) { [INFO] [stdout] | [INFO] [stdout] 740 - if (sprite_priority && palette_low != 0) || palette_low == 0 { [INFO] [stdout] 740 + if sprite_priority || palette_low == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:712:43 [INFO] [stdout] | [INFO] [stdout] 712 | let pixel_value = 0 [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 713 | | | if sprite_pixel_l { 1 } else { 0 } [INFO] [stdout] | |________________________________________________________________^ help: consider reducing it to: `if sprite_pixel_l { 1 } else { 0 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rom.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(raw_bytes: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - pub fn new(raw_bytes: &Vec) -> Self { [INFO] [stdout] 11 + pub fn new(raw_bytes: &[u8]) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Cpu` [INFO] [stdout] --> src/cpu.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new() -> Self { [INFO] [stdout] 22 | | Cpu { [INFO] [stdout] 23 | | program_counter: 0, [INFO] [stdout] 24 | | a: 0, [INFO] [stdout] ... | [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for Cpu { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/cpu.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 122 | let value = bus.read(0x100 + self.stack_pointer as u16); [INFO] [stdout] | -------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 123 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 122 ~ [INFO] [stdout] 123 ~ bus.read(0x100 + self.stack_pointer as u16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/cpu.rs:358:22 [INFO] [stdout] | [INFO] [stdout] 358 | let do_nmi = if !previous_nmi_level_detector && self.nmi_level_detector { [INFO] [stdout] | ______________________^ [INFO] [stdout] 359 | | true [INFO] [stdout] 360 | | } else { [INFO] [stdout] 361 | | false [INFO] [stdout] 362 | | }; [INFO] [stdout] | |_________^ help: you can reduce it to: `!previous_nmi_level_detector && self.nmi_level_detector` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | 0 | (self.v_blank as u8) << 7 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `((self.v_blank as u8) << 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:179:30 [INFO] [stdout] | [INFO] [stdout] 179 | let status = 0 [INFO] [stdout] | ______________________________^ [INFO] [stdout] 180 | | | (self.v_blank as u8) << 7 [INFO] [stdout] | |_______________________________________________^ help: consider reducing it to: `((self.v_blank as u8) << 7)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/ppu.rs:420:17 [INFO] [stdout] | [INFO] [stdout] 420 | / if !self.sprite_evaluation_oam_overflowed { [INFO] [stdout] 421 | | if !self.secondary_oam_full && self.secondary_oam_address < 32 { [INFO] [stdout] 422 | | // If secondary OAM isn't full, the write always occurs. [INFO] [stdout] 423 | | self.secondary_oam[self.secondary_oam_address as usize] = [INFO] [stdout] ... | [INFO] [stdout] 426 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 420 ~ if !self.sprite_evaluation_oam_overflowed [INFO] [stdout] 421 ~ && !self.secondary_oam_full && self.secondary_oam_address < 32 { [INFO] [stdout] 422 | // If secondary OAM isn't full, the write always occurs. [INFO] [stdout] 423 | self.secondary_oam[self.secondary_oam_address as usize] = [INFO] [stdout] 424 | self.sprite_evaluation_temp; [INFO] [stdout] 425 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ppu.rs:740:16 [INFO] [stdout] | [INFO] [stdout] 740 | if (sprite_priority && palette_low != 0) || palette_low == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 740 - if (sprite_priority && palette_low != 0) || palette_low == 0 { [INFO] [stdout] 740 + if !(!sprite_priority && palette_low != 0) { [INFO] [stdout] | [INFO] [stdout] 740 - if (sprite_priority && palette_low != 0) || palette_low == 0 { [INFO] [stdout] 740 + if sprite_priority || palette_low == 0 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/ppu.rs:712:43 [INFO] [stdout] | [INFO] [stdout] 712 | let pixel_value = 0 [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 713 | | | if sprite_pixel_l { 1 } else { 0 } [INFO] [stdout] | |________________________________________________________________^ help: consider reducing it to: `if sprite_pixel_l { 1 } else { 0 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/rom.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(raw_bytes: &Vec) -> Self { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 11 - pub fn new(raw_bytes: &Vec) -> Self { [INFO] [stdout] 11 + pub fn new(raw_bytes: &[u8]) -> Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.31s [INFO] running `Command { std: "docker" "inspect" "63e94d9b632484e3c0b67650d3a19e8326704ba3dc02c878d7a3fc84a99c1d41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63e94d9b632484e3c0b67650d3a19e8326704ba3dc02c878d7a3fc84a99c1d41", kill_on_drop: false }` [INFO] [stdout] 63e94d9b632484e3c0b67650d3a19e8326704ba3dc02c878d7a3fc84a99c1d41