[INFO] cloning repository https://github.com/estrandv/jdw-sc
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/estrandv/jdw-sc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Festrandv%2Fjdw-sc", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Festrandv%2Fjdw-sc'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 36172354a29328278921a73bf05eba32a81ef41e
[INFO] linting estrandv/jdw-sc against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Festrandv%2Fjdw-sc" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/estrandv/jdw-sc
[INFO] finished tweaking git repo https://github.com/estrandv/jdw-sc
[INFO] tweaked toml for git repo https://github.com/estrandv/jdw-sc written to /workspace/builds/worker-0-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/estrandv/jdw-sc on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/estrandv/jdw-sc already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating git repository `https://github.com/estrandv/jdw-osc-lib.git`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded bigdecimal v0.4.6
[INFO] [stderr]   Downloaded itoa v1.0.13
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3549889927df85b371c06e4a6e0c5acbd75202192433f9cb3fad138b41cec8ae
[INFO] running `Command { std: "docker" "start" "-a" "3549889927df85b371c06e4a6e0c5acbd75202192433f9cb3fad138b41cec8ae", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3549889927df85b371c06e4a6e0c5acbd75202192433f9cb3fad138b41cec8ae", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3549889927df85b371c06e4a6e0c5acbd75202192433f9cb3fad138b41cec8ae", kill_on_drop: false }`
[INFO] [stdout] 3549889927df85b371c06e4a6e0c5acbd75202192433f9cb3fad138b41cec8ae
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c3234c8384c407c048e15cf740dddba8215c0c52e3cd584cc73a08116ffed801
[INFO] running `Command { std: "docker" "start" "-a" "c3234c8384c407c048e15cf740dddba8215c0c52e3cd584cc73a08116ffed801", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.92
[INFO] [stderr]    Compiling libc v0.2.164
[INFO] [stderr]    Compiling libm v0.2.11
[INFO] [stderr]    Compiling bigdecimal v0.4.6
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling nix v0.29.0
[INFO] [stderr]     Checking itoa v1.0.13
[INFO] [stderr]     Checking minimal-lexical v0.2.1
[INFO] [stderr]    Compiling time-macros v0.2.18
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]     Checking colored v2.1.0
[INFO] [stderr]     Checking regex-automata v0.4.9
[INFO] [stderr]     Checking json v0.12.4
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]    Compiling quote v1.0.37
[INFO] [stderr]     Checking num-bigint v0.4.6
[INFO] [stderr]    Compiling syn v2.0.89
[INFO] [stderr]     Checking time v0.3.36
[INFO] [stderr]     Checking subprocess v0.2.9
[INFO] [stderr]     Checking rosc v0.10.1
[INFO] [stderr]     Checking regex v1.11.1
[INFO] [stderr]     Checking jdw-osc-lib v0.1.1 (https://github.com/estrandv/jdw-osc-lib.git?branch=master#54e5d466)
[INFO] [stderr]     Checking simple_logger v5.0.0
[INFO] [stderr]     Checking ctrlc v3.4.5
[INFO] [stderr]    Compiling serde_derive v1.0.215
[INFO] [stderr]     Checking serde v1.0.215
[INFO] [stderr]     Checking serde_json v1.0.133
[INFO] [stderr]     Checking jdw-sc v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `info`
[INFO] [stdout]  --> src/internal_osc_conversion.rs:6:11
[INFO] [stdout]   |
[INFO] [stdout] 6 | use log::{info, warn};
[INFO] [stdout]   |           ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::time::Duration`
[INFO] [stdout]   --> src/internal_osc_conversion.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use std::time::Duration;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `TryInto`
[INFO] [stdout]  --> src/osc_daemon.rs:2:24
[INFO] [stdout]   |
[INFO] [stdout] 2 |     convert::{TryFrom, TryInto},
[INFO] [stdout]   |                        ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the feature `result_flattening` has been stable since 1.89.0 and no longer requires an attribute to enable
[INFO] [stdout]  --> src/main.rs:1:12
[INFO] [stdout]   |
[INFO] [stdout] 1 | #![feature(result_flattening)]
[INFO] [stdout]   |            ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(stable_features)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `info`
[INFO] [stdout]  --> src/internal_osc_conversion.rs:6:11
[INFO] [stdout]   |
[INFO] [stdout] 6 | use log::{info, warn};
[INFO] [stdout]   |           ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::time::Duration`
[INFO] [stdout]   --> src/internal_osc_conversion.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use std::time::Duration;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `TryInto`
[INFO] [stdout]  --> src/osc_daemon.rs:2:24
[INFO] [stdout]   |
[INFO] [stdout] 2 |     convert::{TryFrom, TryInto},
[INFO] [stdout]   |                        ^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the feature `result_flattening` has been stable since 1.89.0 and no longer requires an attribute to enable
[INFO] [stdout]  --> src/main.rs:1:12
[INFO] [stdout]   |
[INFO] [stdout] 1 | #![feature(result_flattening)]
[INFO] [stdout]   |            ^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(stable_features)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait `SuperColliderNewMessage` is never used
[INFO] [stdout]   --> src/internal_osc_conversion.rs:12:11
[INFO] [stdout]    |
[INFO] [stdout] 12 | pub trait SuperColliderNewMessage {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/internal_osc_conversion.rs:35:59
[INFO] [stdout]    |
[INFO] [stdout] 35 | fn create_s_new(node_id: i32, synth_name: &str, msg_args: &Vec<OscType>) -> TimedOSCPacket {
[INFO] [stdout]    |                                                           ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 35 ~ fn create_s_new(node_id: i32, synth_name: &str, msg_args: &[OscType]) -> TimedOSCPacket {
[INFO] [stdout] 36 |     let mut final_args = vec![
[INFO] [stdout] ...
[INFO] [stdout] 42 |
[INFO] [stdout] 43 ~     final_args.extend(msg_args.to_owned());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: trait `SuperColliderNewMessage` is never used
[INFO] [stdout]   --> src/internal_osc_conversion.rs:12:11
[INFO] [stdout]    |
[INFO] [stdout] 12 | pub trait SuperColliderNewMessage {
[INFO] [stdout]    |           ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/internal_osc_conversion.rs:35:59
[INFO] [stdout]    |
[INFO] [stdout] 35 | fn create_s_new(node_id: i32, synth_name: &str, msg_args: &Vec<OscType>) -> TimedOSCPacket {
[INFO] [stdout]    |                                                           ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 35 ~ fn create_s_new(node_id: i32, synth_name: &str, msg_args: &[OscType]) -> TimedOSCPacket {
[INFO] [stdout] 36 |     let mut final_args = vec![
[INFO] [stdout] ...
[INFO] [stdout] 42 |
[INFO] [stdout] 43 ~     final_args.extend(msg_args.to_owned());
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/internal_osc_conversion.rs:89:5
[INFO] [stdout]    |
[INFO] [stdout] 89 |     return beats / beats_per_second;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 89 -     return beats / beats_per_second;
[INFO] [stdout] 89 +     beats / beats_per_second
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/internal_osc_conversion.rs:89:5
[INFO] [stdout]    |
[INFO] [stdout] 89 |     return beats / beats_per_second;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 89 -     return beats / beats_per_second;
[INFO] [stdout] 89 +     beats / beats_per_second
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait
[INFO] [stdout]    --> src/internal_osc_conversion.rs:145:55
[INFO] [stdout]     |
[INFO] [stdout] 145 |                 let mut final_ars = vec![OscType::Int(id.clone())];
[INFO] [stdout]     |                                                       ^^^^^^^^^^ help: try dereferencing it: `*id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait
[INFO] [stdout]    --> src/internal_osc_conversion.rs:145:55
[INFO] [stdout]     |
[INFO] [stdout] 145 |                 let mut final_ars = vec![OscType::Int(id.clone())];
[INFO] [stdout]     |                                                       ^^^^^^^^^^ help: try dereferencing it: `*id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait
[INFO] [stdout]    --> src/internal_osc_conversion.rs:175:55
[INFO] [stdout]     |
[INFO] [stdout] 175 |                 let mut final_ars = vec![OscType::Int(id.clone())];
[INFO] [stdout]     |                                                       ^^^^^^^^^^ help: try dereferencing it: `*id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/internal_osc_conversion.rs:206:12
[INFO] [stdout]     |
[INFO] [stdout] 206 |           if base_args
[INFO] [stdout]     |  ____________^
[INFO] [stdout] 207 | |             .iter()
[INFO] [stdout] 208 | |             .map(|arg| arg.clone())
[INFO] [stdout]     | |___________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] help: consider calling the dedicated `cloned` method
[INFO] [stdout]     |
[INFO] [stdout] 206 ~         if base_args
[INFO] [stdout] 207 +             .iter().cloned()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/internal_osc_conversion.rs:295:5
[INFO] [stdout]     |
[INFO] [stdout] 295 |     return sc_msg;
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 295 -     return sc_msg;
[INFO] [stdout] 295 +     sc_msg
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/internal_osc_conversion.rs:281:29
[INFO] [stdout]     |
[INFO] [stdout] 281 | ...                   return res;
[INFO] [stdout]     |                       ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 281 -                             return res;
[INFO] [stdout] 281 +                             res
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait
[INFO] [stdout]    --> src/internal_osc_conversion.rs:175:55
[INFO] [stdout]     |
[INFO] [stdout] 175 |                 let mut final_ars = vec![OscType::Int(id.clone())];
[INFO] [stdout]     |                                                       ^^^^^^^^^^ help: try dereferencing it: `*id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/internal_osc_conversion.rs:206:12
[INFO] [stdout]     |
[INFO] [stdout] 206 |           if base_args
[INFO] [stdout]     |  ____________^
[INFO] [stdout] 207 | |             .iter()
[INFO] [stdout] 208 | |             .map(|arg| arg.clone())
[INFO] [stdout]     | |___________________________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] help: consider calling the dedicated `cloned` method
[INFO] [stdout]     |
[INFO] [stdout] 206 ~         if base_args
[INFO] [stdout] 207 +             .iter().cloned()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/internal_osc_conversion.rs:295:5
[INFO] [stdout]     |
[INFO] [stdout] 295 |     return sc_msg;
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 295 -     return sc_msg;
[INFO] [stdout] 295 +     sc_msg
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/node_lookup.rs:52:59
[INFO] [stdout]    |
[INFO] [stdout] 52 |                 new_reg.retain(|entry, _| !regex.is_match(&entry));
[INFO] [stdout]    |                                                           ^^^^^^ help: change this to: `entry`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/node_lookup.rs:81:17
[INFO] [stdout]    |
[INFO] [stdout] 81 |                 return matching;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 81 -                 return matching;
[INFO] [stdout] 81 +                 matching
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/internal_osc_conversion.rs:281:29
[INFO] [stdout]     |
[INFO] [stdout] 281 | ...                   return res;
[INFO] [stdout]     |                       ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 281 -                             return res;
[INFO] [stdout] 281 +                             res
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait
[INFO] [stdout]   --> src/node_lookup.rs:72:34
[INFO] [stdout]    |
[INFO] [stdout] 72 |                     .map(|entry| entry.1.clone())
[INFO] [stdout]    |                                  ^^^^^^^^^^^^^^^ help: try dereferencing it: `*entry.1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/nrt_record.rs:40:56
[INFO] [stdout]    |
[INFO] [stdout] 40 |         row_template = row_template.replace("{:adr}", &format!("{}", msg.unwrap().addr));
[INFO] [stdout]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `msg.unwrap().addr.to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/node_lookup.rs:52:59
[INFO] [stdout]    |
[INFO] [stdout] 52 |                 new_reg.retain(|entry, _| !regex.is_match(&entry));
[INFO] [stdout]    |                                                           ^^^^^^ help: change this to: `entry`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/node_lookup.rs:81:17
[INFO] [stdout]    |
[INFO] [stdout] 81 |                 return matching;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 81 -                 return matching;
[INFO] [stdout] 81 +                 matching
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait
[INFO] [stdout]   --> src/node_lookup.rs:72:34
[INFO] [stdout]    |
[INFO] [stdout] 72 |                     .map(|entry| entry.1.clone())
[INFO] [stdout]    |                                  ^^^^^^^^^^^^^^^ help: try dereferencing it: `*entry.1`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/nrt_record.rs:40:56
[INFO] [stdout]    |
[INFO] [stdout] 40 |         row_template = row_template.replace("{:adr}", &format!("{}", msg.unwrap().addr));
[INFO] [stdout]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `msg.unwrap().addr.to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Some` followed by `unwrap`
[INFO] [stdout]    --> src/osc_daemon.rs:264:42
[INFO] [stdout]     |
[INFO] [stdout] 264 |   ...                   .filter(|opt| opt.is_some())
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 265 | | ...                   .map(Option::unwrap)
[INFO] [stdout]     | |__________________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_filter_map
[INFO] [stdout]     = note: `#[warn(clippy::option_filter_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Some` followed by `unwrap`
[INFO] [stdout]    --> src/osc_daemon.rs:257:42
[INFO] [stdout]     |
[INFO] [stdout] 257 |   ...                   .filter(|opt| opt.is_some())
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 258 | | ...                   .map(Option::unwrap)
[INFO] [stdout]     | |__________________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_filter_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/osc_daemon.rs:278:53
[INFO] [stdout]     |
[INFO] [stdout] 278 | ...                   return scd_templating::nrt_wrap_synthdef(&def);
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 278 -                                                     return scd_templating::nrt_wrap_synthdef(&def);
[INFO] [stdout] 278 +                                                     scd_templating::nrt_wrap_synthdef(&def)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Some` followed by `unwrap`
[INFO] [stdout]    --> src/osc_daemon.rs:264:42
[INFO] [stdout]     |
[INFO] [stdout] 264 |   ...                   .filter(|opt| opt.is_some())
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 265 | | ...                   .map(Option::unwrap)
[INFO] [stdout]     | |__________________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_filter_map
[INFO] [stdout]     = note: `#[warn(clippy::option_filter_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `filter` for `Some` followed by `unwrap`
[INFO] [stdout]    --> src/osc_daemon.rs:257:42
[INFO] [stdout]     |
[INFO] [stdout] 257 |   ...                   .filter(|opt| opt.is_some())
[INFO] [stdout]     |  ________________________^
[INFO] [stdout] 258 | | ...                   .map(Option::unwrap)
[INFO] [stdout]     | |__________________________________________^ help: consider using `flatten` instead: `flatten()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_filter_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/osc_daemon.rs:278:53
[INFO] [stdout]     |
[INFO] [stdout] 278 | ...                   return scd_templating::nrt_wrap_synthdef(&def);
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 278 -                                                     return scd_templating::nrt_wrap_synthdef(&def);
[INFO] [stdout] 278 +                                                     scd_templating::nrt_wrap_synthdef(&def)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tagged_bundle.contents.get(0)`
[INFO] [stdout]   --> src/osc_model.rs:19:27
[INFO] [stdout]    |
[INFO] [stdout] 19 |         let info_packet = tagged_bundle.contents.get(0).ok_or("No packets")?;
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tagged_bundle.contents.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `info_msg
[INFO] [stdout]                          .clone()
[INFO] [stdout]                          .args
[INFO] [stdout]                          .clone().get(0)`
[INFO] [stdout]   --> src/osc_model.rs:26:29
[INFO] [stdout]    |
[INFO] [stdout] 26 |               let timestamp = info_msg
[INFO] [stdout]    |  _____________________________^
[INFO] [stdout] 27 | |                 .clone()
[INFO] [stdout] 28 | |                 .args
[INFO] [stdout] 29 | |                 .clone()
[INFO] [stdout] 30 | |                 .get(0)
[INFO] [stdout]    | |_______________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 26 ~             let timestamp = info_msg
[INFO] [stdout] 27 +                 .clone()
[INFO] [stdout] 28 +                 .args
[INFO] [stdout] 29 +                 .clone().first()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used
[INFO] [stdout]   --> src/osc_model.rs:37:17
[INFO] [stdout]    |
[INFO] [stdout] 37 |                 SystemTime::try_from(timestamp).map_err(|_| "Malformed timestamp".to_string())?;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: converting `OscTime` to `SystemTime` cannot fail
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 37 -                 SystemTime::try_from(timestamp).map_err(|_| "Malformed timestamp".to_string())?;
[INFO] [stdout] 37 +                 From::from(timestamp).map_err(|_| "Malformed timestamp".to_string())?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `tagged_bundle.contents.get(0)`
[INFO] [stdout]   --> src/osc_model.rs:19:27
[INFO] [stdout]    |
[INFO] [stdout] 19 |         let info_packet = tagged_bundle.contents.get(0).ok_or("No packets")?;
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tagged_bundle.contents.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `info_msg
[INFO] [stdout]                          .clone()
[INFO] [stdout]                          .args
[INFO] [stdout]                          .clone().get(0)`
[INFO] [stdout]   --> src/osc_model.rs:26:29
[INFO] [stdout]    |
[INFO] [stdout] 26 |               let timestamp = info_msg
[INFO] [stdout]    |  _____________________________^
[INFO] [stdout] 27 | |                 .clone()
[INFO] [stdout] 28 | |                 .args
[INFO] [stdout] 29 | |                 .clone()
[INFO] [stdout] 30 | |                 .get(0)
[INFO] [stdout]    | |_______________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 26 ~             let timestamp = info_msg
[INFO] [stdout] 27 +                 .clone()
[INFO] [stdout] 28 +                 .args
[INFO] [stdout] 29 +                 .clone().first()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/osc_model.rs:185:38
[INFO] [stdout]     |
[INFO] [stdout] 185 |         let category = if cat_arg == "".to_string() {
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]     = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used
[INFO] [stdout]   --> src/osc_model.rs:37:17
[INFO] [stdout]    |
[INFO] [stdout] 37 |                 SystemTime::try_from(timestamp).map_err(|_| "Malformed timestamp".to_string())?;
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: converting `OscTime` to `SystemTime` cannot fail
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default
[INFO] [stdout] help: use
[INFO] [stdout]    |
[INFO] [stdout] 37 -                 SystemTime::try_from(timestamp).map_err(|_| "Malformed timestamp".to_string())?;
[INFO] [stdout] 37 +                 From::from(timestamp).map_err(|_| "Malformed timestamp".to_string())?;
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/osc_model.rs:236:17
[INFO] [stdout]     |
[INFO] [stdout] 236 | /                 return match packet {
[INFO] [stdout] 237 | |                     OscPacket::Bundle(bun) => {
[INFO] [stdout] 238 | |                         let tagged = TaggedBundle::new(&bun)?;
[INFO] [stdout] 239 | |                         info!("Parsing tagged bundle for NRT! {}", tagged.bundle_tag);
[INFO] [stdout] ...   |
[INFO] [stdout] 247 | |                 };
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 236 ~                 match packet {
[INFO] [stdout] 237 +                     OscPacket::Bundle(bun) => {
[INFO] [stdout] 238 +                         let tagged = TaggedBundle::new(&bun)?;
[INFO] [stdout] 239 +                         info!("Parsing tagged bundle for NRT! {}", tagged.bundle_tag);
[INFO] [stdout] 240 +                         Ok(TimedOSCPacket::from_bundle(tagged)?)
[INFO] [stdout] 241 +                     }
[INFO] [stdout] 242 +                     _ => {
[INFO] [stdout] 243 +                         warn!("Unexpected non-bundle when unpacking timed messages bundle content");
[INFO] [stdout] 244 +                         Err("Unexpected non-bundle when unpacking timed messages bundle"
[INFO] [stdout] 245 +                             .to_string())
[INFO] [stdout] 246 +                     }
[INFO] [stdout] 247 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/osc_model.rs:238:56
[INFO] [stdout]     |
[INFO] [stdout] 238 |                         let tagged = TaggedBundle::new(&bun)?;
[INFO] [stdout]     |                                                        ^^^^ help: change this to: `bun`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]   --> src/sampling.rs:29:27
[INFO] [stdout]    |
[INFO] [stdout] 29 |             self.file_path.to_string(),
[INFO] [stdout]    |                           ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]    = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]   --> src/sampling.rs:38:27
[INFO] [stdout]    |
[INFO] [stdout] 38 |             self.file_path.to_string(),
[INFO] [stdout]    |                           ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/sampling.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 | /         return samples_in_category.iter()
[INFO] [stdout] 61 | |             .find(|sample| sample.tone_index as usize == sample_number)
[INFO] [stdout] 62 | |             .map(|sample| sample.clone());
[INFO] [stdout]    | |_________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 ~         samples_in_category.iter()
[INFO] [stdout] 61 +             .find(|sample| sample.tone_index as usize == sample_number)
[INFO] [stdout] 62 ~             .map(|sample| sample.clone())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]   --> src/sampling.rs:54:48
[INFO] [stdout]    |
[INFO] [stdout] 54 |           let samples_in_category: Vec<Sample> = self.samples.iter()
[INFO] [stdout]    |  ________________________________________________^
[INFO] [stdout] 55 | |             // Return ALL samples if category is blank
[INFO] [stdout] 56 | |             .filter(|sample| sample.category_tag == category || category == "")
[INFO] [stdout] 57 | |             .map(|f| f.clone())
[INFO] [stdout]    | |_______________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] help: consider calling the dedicated `cloned` method
[INFO] [stdout]    |
[INFO] [stdout] 54 ~         let samples_in_category: Vec<Sample> = self.samples.iter()
[INFO] [stdout] 55 +             // Return ALL samples if category is blank
[INFO] [stdout] 56 +             .filter(|sample| sample.category_tag == category || category == "").cloned()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]    --> src/osc_model.rs:185:38
[INFO] [stdout]     |
[INFO] [stdout] 185 |         let category = if cat_arg == "".to_string() {
[INFO] [stdout]     |                                      ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]     = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/sampling.rs:56:65
[INFO] [stdout]    |
[INFO] [stdout] 56 |             .filter(|sample| sample.category_tag == category || category == "")
[INFO] [stdout]    |                                                                 ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `category.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]   --> src/sampling.rs:60:16
[INFO] [stdout]    |
[INFO] [stdout] 60 |           return samples_in_category.iter()
[INFO] [stdout]    |  ________________^
[INFO] [stdout] 61 | |             .find(|sample| sample.tone_index as usize == sample_number)
[INFO] [stdout] 62 | |             .map(|sample| sample.clone());
[INFO] [stdout]    | |_________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] help: consider calling the dedicated `cloned` method
[INFO] [stdout]    |
[INFO] [stdout] 60 ~         return samples_in_category.iter()
[INFO] [stdout] 61 ~             .find(|sample| sample.tone_index as usize == sample_number).cloned();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/osc_model.rs:236:17
[INFO] [stdout]     |
[INFO] [stdout] 236 | /                 return match packet {
[INFO] [stdout] 237 | |                     OscPacket::Bundle(bun) => {
[INFO] [stdout] 238 | |                         let tagged = TaggedBundle::new(&bun)?;
[INFO] [stdout] 239 | |                         info!("Parsing tagged bundle for NRT! {}", tagged.bundle_tag);
[INFO] [stdout] ...   |
[INFO] [stdout] 247 | |                 };
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 236 ~                 match packet {
[INFO] [stdout] 237 +                     OscPacket::Bundle(bun) => {
[INFO] [stdout] 238 +                         let tagged = TaggedBundle::new(&bun)?;
[INFO] [stdout] 239 +                         info!("Parsing tagged bundle for NRT! {}", tagged.bundle_tag);
[INFO] [stdout] 240 +                         Ok(TimedOSCPacket::from_bundle(tagged)?)
[INFO] [stdout] 241 +                     }
[INFO] [stdout] 242 +                     _ => {
[INFO] [stdout] 243 +                         warn!("Unexpected non-bundle when unpacking timed messages bundle content");
[INFO] [stdout] 244 +                         Err("Unexpected non-bundle when unpacking timed messages bundle"
[INFO] [stdout] 245 +                             .to_string())
[INFO] [stdout] 246 +                     }
[INFO] [stdout] 247 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.70s
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/sampling.rs:101:12
[INFO] [stdout]     |
[INFO] [stdout] 101 |         if !existing.is_some() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^ help: try: `existing.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `existing` after checking its variant with `is_some`
[INFO] [stdout]    --> src/sampling.rs:105:47
[INFO] [stdout]     |
[INFO] [stdout] 105 |         let selected = if existing.is_some() {existing.unwrap()} else {sample};
[INFO] [stdout]     |                        ---------------------  ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |                        |
[INFO] [stdout]     |                        help: try: `if let Some(<item>) = existing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/osc_model.rs:238:56
[INFO] [stdout]     |
[INFO] [stdout] 238 |                         let tagged = TaggedBundle::new(&bun)?;
[INFO] [stdout]     |                                                        ^^^^ help: change this to: `bun`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]   --> src/sampling.rs:90:24
[INFO] [stdout]    |
[INFO] [stdout] 90 |         let existing = pack.samples.iter().find(|s| s.file_path == msg.file_path).map(|s| s.clone());
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `pack.samples.iter().find(|s| s.file_path == msg.file_path).cloned()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/sampling.rs:123:9
[INFO] [stdout]     |
[INFO] [stdout] 123 |         return self.sample_packs.values().flat_map(|pack| pack.samples.clone()).collect()
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -         return self.sample_packs.values().flat_map(|pack| pack.samples.clone()).collect()
[INFO] [stdout] 123 +         self.sample_packs.values().flat_map(|pack| pack.samples.clone()).collect()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]   --> src/sampling.rs:29:27
[INFO] [stdout]    |
[INFO] [stdout] 29 |             self.file_path.to_string(),
[INFO] [stdout]    |                           ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]    = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args
[INFO] [stdout]   --> src/sampling.rs:38:27
[INFO] [stdout]    |
[INFO] [stdout] 38 |             self.file_path.to_string(),
[INFO] [stdout]    |                           ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/sampling.rs:60:9
[INFO] [stdout]    |
[INFO] [stdout] 60 | /         return samples_in_category.iter()
[INFO] [stdout] 61 | |             .find(|sample| sample.tone_index as usize == sample_number)
[INFO] [stdout] 62 | |             .map(|sample| sample.clone());
[INFO] [stdout]    | |_________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 ~         samples_in_category.iter()
[INFO] [stdout] 61 +             .find(|sample| sample.tone_index as usize == sample_number)
[INFO] [stdout] 62 ~             .map(|sample| sample.clone())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]   --> src/sampling.rs:54:48
[INFO] [stdout]    |
[INFO] [stdout] 54 |           let samples_in_category: Vec<Sample> = self.samples.iter()
[INFO] [stdout]    |  ________________________________________________^
[INFO] [stdout] 55 | |             // Return ALL samples if category is blank
[INFO] [stdout] 56 | |             .filter(|sample| sample.category_tag == category || category == "")
[INFO] [stdout] 57 | |             .map(|f| f.clone())
[INFO] [stdout]    | |_______________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] help: consider calling the dedicated `cloned` method
[INFO] [stdout]    |
[INFO] [stdout] 54 ~         let samples_in_category: Vec<Sample> = self.samples.iter()
[INFO] [stdout] 55 +             // Return ALL samples if category is blank
[INFO] [stdout] 56 +             .filter(|sample| sample.category_tag == category || category == "").cloned()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/sampling.rs:56:65
[INFO] [stdout]    |
[INFO] [stdout] 56 |             .filter(|sample| sample.category_tag == category || category == "")
[INFO] [stdout]    |                                                                 ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `category.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]   --> src/sampling.rs:60:16
[INFO] [stdout]    |
[INFO] [stdout] 60 |           return samples_in_category.iter()
[INFO] [stdout]    |  ________________^
[INFO] [stdout] 61 | |             .find(|sample| sample.tone_index as usize == sample_number)
[INFO] [stdout] 62 | |             .map(|sample| sample.clone());
[INFO] [stdout]    | |_________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] help: consider calling the dedicated `cloned` method
[INFO] [stdout]    |
[INFO] [stdout] 60 ~         return samples_in_category.iter()
[INFO] [stdout] 61 ~             .find(|sample| sample.tone_index as usize == sample_number).cloned();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/sampling.rs:101:12
[INFO] [stdout]     |
[INFO] [stdout] 101 |         if !existing.is_some() {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^ help: try: `existing.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `existing` after checking its variant with `is_some`
[INFO] [stdout]    --> src/sampling.rs:105:47
[INFO] [stdout]     |
[INFO] [stdout] 105 |         let selected = if existing.is_some() {existing.unwrap()} else {sample};
[INFO] [stdout]     |                        ---------------------  ^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |                        |
[INFO] [stdout]     |                        help: try: `if let Some(<item>) = existing`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]   --> src/sampling.rs:90:24
[INFO] [stdout]    |
[INFO] [stdout] 90 |         let existing = pack.samples.iter().find(|s| s.file_path == msg.file_path).map(|s| s.clone());
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `pack.samples.iter().find(|s| s.file_path == msg.file_path).cloned()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/sc_process_management.rs:200:21
[INFO] [stdout]     |
[INFO] [stdout] 200 | /                     match packet {
[INFO] [stdout] 201 | |                         OscPacket::Message(msg) => {
[INFO] [stdout] 202 | |                             if msg.addr == message_name && args == msg.args {
[INFO] [stdout] 203 | |                                 info!(">> Awaited message received! Continuing ...");
[INFO] [stdout] ...   |
[INFO] [stdout] 211 | |                         _ => {}
[INFO] [stdout] 212 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 200 ~                     if let OscPacket::Message(msg) = packet {
[INFO] [stdout] 201 +                         if msg.addr == message_name && args == msg.args {
[INFO] [stdout] 202 +                             info!(">> Awaited message received! Continuing ...");
[INFO] [stdout] 203 +                             return Ok(());
[INFO] [stdout] 204 +                         } else {
[INFO] [stdout] 205 +                             debug!(
[INFO] [stdout] 206 +                                 "Received message not the waited for one, continuing wait..."
[INFO] [stdout] 207 +                             );
[INFO] [stdout] 208 +                         }
[INFO] [stdout] 209 +                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/sampling.rs:123:9
[INFO] [stdout]     |
[INFO] [stdout] 123 |         return self.sample_packs.values().flat_map(|pack| pack.samples.clone()).collect()
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -         return self.sample_packs.values().flat_map(|pack| pack.samples.clone()).collect()
[INFO] [stdout] 123 +         self.sample_packs.values().flat_map(|pack| pack.samples.clone()).collect()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/scd_templating.rs:45:5
[INFO] [stdout]    |
[INFO] [stdout] 45 |     return Ok(text);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 45 -     return Ok(text);
[INFO] [stdout] 45 +     Ok(text)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/main.rs:63:5
[INFO] [stdout]    |
[INFO] [stdout] 63 | /     match client.await_internal_response(
[INFO] [stdout] 64 | |         "/init",
[INFO] [stdout] 65 | |         vec![OscType::String("ok".to_string())],
[INFO] [stdout] 66 | |         Duration::from_secs(10),
[INFO] [stdout] ...  |
[INFO] [stdout] 72 | |         Ok(()) => (),
[INFO] [stdout] 73 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 63 ~     if let Err(e) = client.await_internal_response(
[INFO] [stdout] 64 +         "/init",
[INFO] [stdout] 65 +         vec![OscType::String("ok".to_string())],
[INFO] [stdout] 66 +         Duration::from_secs(10),
[INFO] [stdout] 67 +     ) {
[INFO] [stdout] 68 +         error!("{}", e);
[INFO] [stdout] 69 +         process_arc_failure.lock().unwrap().terminate().unwrap();
[INFO] [stdout] 70 ~     };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/sc_process_management.rs:200:21
[INFO] [stdout]     |
[INFO] [stdout] 200 | /                     match packet {
[INFO] [stdout] 201 | |                         OscPacket::Message(msg) => {
[INFO] [stdout] 202 | |                             if msg.addr == message_name && args == msg.args {
[INFO] [stdout] 203 | |                                 info!(">> Awaited message received! Continuing ...");
[INFO] [stdout] ...   |
[INFO] [stdout] 211 | |                         _ => {}
[INFO] [stdout] 212 | |                     }
[INFO] [stdout]     | |_____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 200 ~                     if let OscPacket::Message(msg) = packet {
[INFO] [stdout] 201 +                         if msg.addr == message_name && args == msg.args {
[INFO] [stdout] 202 +                             info!(">> Awaited message received! Continuing ...");
[INFO] [stdout] 203 +                             return Ok(());
[INFO] [stdout] 204 +                         } else {
[INFO] [stdout] 205 +                             debug!(
[INFO] [stdout] 206 +                                 "Received message not the waited for one, continuing wait..."
[INFO] [stdout] 207 +                             );
[INFO] [stdout] 208 +                         }
[INFO] [stdout] 209 +                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `sendTime` should have a snake case name
[INFO] [stdout]   --> src/osc_daemon.rs:60:48
[INFO] [stdout]    |
[INFO] [stdout] 60 |     fn interpret(&mut self, packet: OscPacket, sendTime: SystemTime) {
[INFO] [stdout]    |                                                ^^^^^^^^ help: convert the identifier to snake case: `send_time`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/scd_templating.rs:45:5
[INFO] [stdout]    |
[INFO] [stdout] 45 |     return Ok(text);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 45 -     return Ok(text);
[INFO] [stdout] 45 +     Ok(text)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/main.rs:63:5
[INFO] [stdout]    |
[INFO] [stdout] 63 | /     match client.await_internal_response(
[INFO] [stdout] 64 | |         "/init",
[INFO] [stdout] 65 | |         vec![OscType::String("ok".to_string())],
[INFO] [stdout] 66 | |         Duration::from_secs(10),
[INFO] [stdout] ...  |
[INFO] [stdout] 72 | |         Ok(()) => (),
[INFO] [stdout] 73 | |     };
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 63 ~     if let Err(e) = client.await_internal_response(
[INFO] [stdout] 64 +         "/init",
[INFO] [stdout] 65 +         vec![OscType::String("ok".to_string())],
[INFO] [stdout] 66 +         Duration::from_secs(10),
[INFO] [stdout] 67 +     ) {
[INFO] [stdout] 68 +         error!("{}", e);
[INFO] [stdout] 69 +         process_arc_failure.lock().unwrap().terminate().unwrap();
[INFO] [stdout] 70 ~     };
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: variable `sendTime` should have a snake case name
[INFO] [stdout]   --> src/osc_daemon.rs:60:48
[INFO] [stdout]    |
[INFO] [stdout] 60 |     fn interpret(&mut self, packet: OscPacket, sendTime: SystemTime) {
[INFO] [stdout]    |                                                ^^^^^^^^ help: convert the identifier to snake case: `send_time`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] running `Command { std: "docker" "inspect" "c3234c8384c407c048e15cf740dddba8215c0c52e3cd584cc73a08116ffed801", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c3234c8384c407c048e15cf740dddba8215c0c52e3cd584cc73a08116ffed801", kill_on_drop: false }`
[INFO] [stdout] c3234c8384c407c048e15cf740dddba8215c0c52e3cd584cc73a08116ffed801