[INFO] cloning repository https://github.com/escher-bach/GrammarInduction [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/escher-bach/GrammarInduction" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fescher-bach%2FGrammarInduction", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fescher-bach%2FGrammarInduction'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f787930a5fbacc0dd5f28b52a5252d57d42cc20b [INFO] linting escher-bach/GrammarInduction against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fescher-bach%2FGrammarInduction" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/escher-bach/GrammarInduction [INFO] finished tweaking git repo https://github.com/escher-bach/GrammarInduction [INFO] tweaked toml for git repo https://github.com/escher-bach/GrammarInduction written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/escher-bach/GrammarInduction on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/escher-bach/GrammarInduction already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cc v1.2.41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c7468fee60854068d58b8588aaa58c52c5f525ecba7cd88814746b3dd4faf55 [INFO] running `Command { std: "docker" "start" "-a" "3c7468fee60854068d58b8588aaa58c52c5f525ecba7cd88814746b3dd4faf55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c7468fee60854068d58b8588aaa58c52c5f525ecba7cd88814746b3dd4faf55", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c7468fee60854068d58b8588aaa58c52c5f525ecba7cd88814746b3dd4faf55", kill_on_drop: false }` [INFO] [stdout] 3c7468fee60854068d58b8588aaa58c52c5f525ecba7cd88814746b3dd4faf55 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9aefbe8a06ffc51ea8cd8cc1a1e1e8b946d75fe293e5b7ec7c40bbc7f6805fd5 [INFO] running `Command { std: "docker" "start" "-a" "9aefbe8a06ffc51ea8cd8cc1a1e1e8b946d75fe293e5b7ec7c40bbc7f6805fd5", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling libc v0.2.177 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Compiling syn v2.0.107 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking stratagram v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:354:22 [INFO] [stdout] | [INFO] [stdout] 354 | .or_insert_with(AHashSet::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:411:14 [INFO] [stdout] | [INFO] [stdout] 411 | .or_insert_with(AHashMap::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:419:18 [INFO] [stdout] | [INFO] [stdout] 419 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:429:22 [INFO] [stdout] | [INFO] [stdout] 429 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:427:22 [INFO] [stdout] | [INFO] [stdout] 427 | .or_insert_with(AHashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:489:13 [INFO] [stdout] | [INFO] [stdout] 489 | / if let Some(paths) = fillers_map.get(ngram) { [INFO] [stdout] 490 | | if !paths.is_empty() { [INFO] [stdout] 491 | | valid.push(ngram.clone()); [INFO] [stdout] 492 | | } [INFO] [stdout] 493 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 489 ~ if let Some(paths) = fillers_map.get(ngram) [INFO] [stdout] 490 ~ && !paths.is_empty() { [INFO] [stdout] 491 | valid.push(ngram.clone()); [INFO] [stdout] 492 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:523:13 [INFO] [stdout] | [INFO] [stdout] 523 | / if let Some(level_index) = self.pattern_indices.get(&ngram_level) { [INFO] [stdout] 524 | | if let Some(fillers_map) = level_index.get(context) { [INFO] [stdout] 525 | | for ngram in ngrams_to_merge { [INFO] [stdout] 526 | | if let Some(indices) = fillers_map.get(ngram) { [INFO] [stdout] ... | [INFO] [stdout] 531 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 523 ~ if let Some(level_index) = self.pattern_indices.get(&ngram_level) [INFO] [stdout] 524 ~ && let Some(fillers_map) = level_index.get(context) { [INFO] [stdout] 525 | for ngram in ngrams_to_merge { [INFO] [stdout] ... [INFO] [stdout] 529 | } [INFO] [stdout] 530 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:575:18 [INFO] [stdout] | [INFO] [stdout] 575 | .or_insert_with(AHashSet::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:580:17 [INFO] [stdout] | [INFO] [stdout] 580 | / if !self.paths[path_idx].contains(old_token_id) { [INFO] [stdout] 581 | | if let Some(set) = self.token_locations.get_mut(old_token_id) { [INFO] [stdout] 582 | | set.remove(&path_idx); [INFO] [stdout] 583 | | if set.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 587 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 580 ~ if !self.paths[path_idx].contains(old_token_id) [INFO] [stdout] 581 ~ && let Some(set) = self.token_locations.get_mut(old_token_id) { [INFO] [stdout] 582 | set.remove(&path_idx); [INFO] [stdout] ... [INFO] [stdout] 585 | } [INFO] [stdout] 586 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:611:14 [INFO] [stdout] | [INFO] [stdout] 611 | .or_insert_with(AHashMap::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:614:14 [INFO] [stdout] | [INFO] [stdout] 614 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:627:18 [INFO] [stdout] | [INFO] [stdout] 627 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:625:18 [INFO] [stdout] | [INFO] [stdout] 625 | .or_insert_with(AHashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:748:9 [INFO] [stdout] | [INFO] [stdout] 748 | / if let Some(parent) = output_path.parent() { [INFO] [stdout] 749 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 750 | | fs::create_dir_all(parent).with_context(|| { [INFO] [stdout] 751 | | format!("creating grammar directory at {}", parent.display()) [INFO] [stdout] ... | [INFO] [stdout] 754 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 748 ~ if let Some(parent) = output_path.parent() [INFO] [stdout] 749 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 750 | fs::create_dir_all(parent).with_context(|| { [INFO] [stdout] 751 | format!("creating grammar directory at {}", parent.display()) [INFO] [stdout] 752 | })?; [INFO] [stdout] 753 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:993:8 [INFO] [stdout] | [INFO] [stdout] 993 | if !prefix.is_empty() && !(prefix.len() == 1 && prefix[0] == BEG_ID) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(prefix.is_empty() || prefix.len() == 1 && prefix[0] == BEG_ID)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:996:8 [INFO] [stdout] | [INFO] [stdout] 996 | if !suffix.is_empty() && !(suffix.len() == 1 && suffix[0] == END_ID) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(suffix.is_empty() || suffix.len() == 1 && suffix[0] == END_ID)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1143:9 [INFO] [stdout] | [INFO] [stdout] 1143 | / if let (Some(first), Some(last)) = (levels.first().copied(), levels.last().copied()) { [INFO] [stdout] 1144 | | if first != last { [INFO] [stdout] 1145 | | matcher.compare_snapshots(first, last); [INFO] [stdout] 1146 | | } [INFO] [stdout] 1147 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1143 ~ if let (Some(first), Some(last)) = (levels.first().copied(), levels.last().copied()) [INFO] [stdout] 1144 ~ && first != last { [INFO] [stdout] 1145 | matcher.compare_snapshots(first, last); [INFO] [stdout] 1146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:354:22 [INFO] [stdout] | [INFO] [stdout] 354 | .or_insert_with(AHashSet::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:411:14 [INFO] [stdout] | [INFO] [stdout] 411 | .or_insert_with(AHashMap::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:419:18 [INFO] [stdout] | [INFO] [stdout] 419 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:429:22 [INFO] [stdout] | [INFO] [stdout] 429 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:427:22 [INFO] [stdout] | [INFO] [stdout] 427 | .or_insert_with(AHashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:489:13 [INFO] [stdout] | [INFO] [stdout] 489 | / if let Some(paths) = fillers_map.get(ngram) { [INFO] [stdout] 490 | | if !paths.is_empty() { [INFO] [stdout] 491 | | valid.push(ngram.clone()); [INFO] [stdout] 492 | | } [INFO] [stdout] 493 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 489 ~ if let Some(paths) = fillers_map.get(ngram) [INFO] [stdout] 490 ~ && !paths.is_empty() { [INFO] [stdout] 491 | valid.push(ngram.clone()); [INFO] [stdout] 492 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:523:13 [INFO] [stdout] | [INFO] [stdout] 523 | / if let Some(level_index) = self.pattern_indices.get(&ngram_level) { [INFO] [stdout] 524 | | if let Some(fillers_map) = level_index.get(context) { [INFO] [stdout] 525 | | for ngram in ngrams_to_merge { [INFO] [stdout] 526 | | if let Some(indices) = fillers_map.get(ngram) { [INFO] [stdout] ... | [INFO] [stdout] 531 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 523 ~ if let Some(level_index) = self.pattern_indices.get(&ngram_level) [INFO] [stdout] 524 ~ && let Some(fillers_map) = level_index.get(context) { [INFO] [stdout] 525 | for ngram in ngrams_to_merge { [INFO] [stdout] ... [INFO] [stdout] 529 | } [INFO] [stdout] 530 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:575:18 [INFO] [stdout] | [INFO] [stdout] 575 | .or_insert_with(AHashSet::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:580:17 [INFO] [stdout] | [INFO] [stdout] 580 | / if !self.paths[path_idx].contains(old_token_id) { [INFO] [stdout] 581 | | if let Some(set) = self.token_locations.get_mut(old_token_id) { [INFO] [stdout] 582 | | set.remove(&path_idx); [INFO] [stdout] 583 | | if set.is_empty() { [INFO] [stdout] ... | [INFO] [stdout] 587 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 580 ~ if !self.paths[path_idx].contains(old_token_id) [INFO] [stdout] 581 ~ && let Some(set) = self.token_locations.get_mut(old_token_id) { [INFO] [stdout] 582 | set.remove(&path_idx); [INFO] [stdout] ... [INFO] [stdout] 585 | } [INFO] [stdout] 586 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:611:14 [INFO] [stdout] | [INFO] [stdout] 611 | .or_insert_with(AHashMap::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:614:14 [INFO] [stdout] | [INFO] [stdout] 614 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:627:18 [INFO] [stdout] | [INFO] [stdout] 627 | .or_insert_with(AHashSet::new); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert_with` to construct default value [INFO] [stdout] --> src/main.rs:625:18 [INFO] [stdout] | [INFO] [stdout] 625 | .or_insert_with(AHashMap::new) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:748:9 [INFO] [stdout] | [INFO] [stdout] 748 | / if let Some(parent) = output_path.parent() { [INFO] [stdout] 749 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 750 | | fs::create_dir_all(parent).with_context(|| { [INFO] [stdout] 751 | | format!("creating grammar directory at {}", parent.display()) [INFO] [stdout] ... | [INFO] [stdout] 754 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 748 ~ if let Some(parent) = output_path.parent() [INFO] [stdout] 749 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 750 | fs::create_dir_all(parent).with_context(|| { [INFO] [stdout] 751 | format!("creating grammar directory at {}", parent.display()) [INFO] [stdout] 752 | })?; [INFO] [stdout] 753 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:993:8 [INFO] [stdout] | [INFO] [stdout] 993 | if !prefix.is_empty() && !(prefix.len() == 1 && prefix[0] == BEG_ID) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(prefix.is_empty() || prefix.len() == 1 && prefix[0] == BEG_ID)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:996:8 [INFO] [stdout] | [INFO] [stdout] 996 | if !suffix.is_empty() && !(suffix.len() == 1 && suffix[0] == END_ID) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(suffix.is_empty() || suffix.len() == 1 && suffix[0] == END_ID)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:1143:9 [INFO] [stdout] | [INFO] [stdout] 1143 | / if let (Some(first), Some(last)) = (levels.first().copied(), levels.last().copied()) { [INFO] [stdout] 1144 | | if first != last { [INFO] [stdout] 1145 | | matcher.compare_snapshots(first, last); [INFO] [stdout] 1146 | | } [INFO] [stdout] 1147 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1143 ~ if let (Some(first), Some(last)) = (levels.first().copied(), levels.last().copied()) [INFO] [stdout] 1144 ~ && first != last { [INFO] [stdout] 1145 | matcher.compare_snapshots(first, last); [INFO] [stdout] 1146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.91s [INFO] running `Command { std: "docker" "inspect" "9aefbe8a06ffc51ea8cd8cc1a1e1e8b946d75fe293e5b7ec7c40bbc7f6805fd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9aefbe8a06ffc51ea8cd8cc1a1e1e8b946d75fe293e5b7ec7c40bbc7f6805fd5", kill_on_drop: false }` [INFO] [stdout] 9aefbe8a06ffc51ea8cd8cc1a1e1e8b946d75fe293e5b7ec7c40bbc7f6805fd5