[INFO] cloning repository https://github.com/eridgd/tentoku-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eridgd/tentoku-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feridgd%2Ftentoku-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feridgd%2Ftentoku-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b9c111d2d7805ebe751265c1b7eff6eae28e56c [INFO] linting eridgd/tentoku-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feridgd%2Ftentoku-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eridgd/tentoku-rs [INFO] finished tweaking git repo https://github.com/eridgd/tentoku-rs [INFO] tweaked toml for git repo https://github.com/eridgd/tentoku-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eridgd/tentoku-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eridgd/tentoku-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ureq-proto v0.5.3 [INFO] [stderr] Downloaded ureq v3.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 857bc1ab244896f9c697b22858351b72766c59891b405fca9d8832ccdad633b0 [INFO] running `Command { std: "docker" "start" "-a" "857bc1ab244896f9c697b22858351b72766c59891b405fca9d8832ccdad633b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "857bc1ab244896f9c697b22858351b72766c59891b405fca9d8832ccdad633b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "857bc1ab244896f9c697b22858351b72766c59891b405fca9d8832ccdad633b0", kill_on_drop: false }` [INFO] [stdout] 857bc1ab244896f9c697b22858351b72766c59891b405fca9d8832ccdad633b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91dfe5ae05624753375662533e942a333795637b54f3ec6af0193a999e4f6a61 [INFO] running `Command { std: "docker" "start" "-a" "91dfe5ae05624753375662533e942a333795637b54f3ec6af0193a999e4f6a61", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling zerocopy v0.8.40 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking rustls-pki-types v1.14.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking simd-adler32 v0.3.8 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling rustls v0.23.37 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking webpki-roots v1.0.6 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling getrandom v0.4.1 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking quick-xml v0.37.5 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Compiling zerocopy-derive v0.8.40 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking rustls-webpki v0.103.9 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ureq v3.2.0 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking tentoku v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/deinflect.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | reason_chains.iter().map(|c| c.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `reason_chains.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `KeyIndex` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/key_index.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/key_index.rs:166:24 [INFO] [stdout] | [INFO] [stdout] 166 | Ok(Self::build(keys.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/key_index.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn build(keys: impl IntoIterator) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 166 - Ok(Self::build(keys.into_iter())) [INFO] [stdout] 166 + Ok(Self::build(keys)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/sorting.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | if let Ok(wordfreq) = normalized[2..].parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/sorting.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | if normalized.starts_with("nf") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Some() = normalized.strip_prefix("nf") { [INFO] [stdout] 47 ~ if let Ok(wordfreq) = .parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/sorting.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | / k.info.as_deref().map_or(false, |info| { [INFO] [stdout] 130 | | info.split(',') [INFO] [stdout] 131 | | .any(|p| matches!(p.trim(), "rK" | "sK" | "iK")) [INFO] [stdout] 132 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 129 - k.info.as_deref().map_or(false, |info| { [INFO] [stdout] 129 + k.info.as_deref().is_some_and(|info| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/sorting.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | / s.misc [INFO] [stdout] 154 | | .as_deref() [INFO] [stdout] 155 | | .map_or(false, |misc| misc.iter().any(|m| m.contains("uk"))) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 155 - .map_or(false, |misc| misc.iter().any(|m| m.contains("uk"))) [INFO] [stdout] 155 + .is_some_and(|misc| misc.iter().any(|m| m.contains("uk"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/sorting.rs:172:35 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn sort_word_results(results: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 172 - pub fn sort_word_results(results: &mut Vec) { [INFO] [stdout] 172 + pub fn sort_word_results(results: &mut [WordResult]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sqlite_dict.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kanji_by_entry: HashMap, Option)>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sqlite_dict.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 92 | let mut kana_by_entry: HashMap, Option)>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sqlite_dict.rs:229:34 [INFO] [stdout] | [INFO] [stdout] 229 | matched: (kanji_match_found && matches) || !kanji_match_found, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - matched: (kanji_match_found && matches) || !kanji_match_found, [INFO] [stdout] 229 + matched: !(kanji_match_found && !matches), [INFO] [stdout] | [INFO] [stdout] 229 - matched: (kanji_match_found && matches) || !kanji_match_found, [INFO] [stdout] 229 + matched: !kanji_match_found || matches, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sqlite_dict.rs:254:38 [INFO] [stdout] | [INFO] [stdout] 254 | ... matched: (kana_match_found && matches) || !kana_match_found, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 254 - matched: (kana_match_found && matches) || !kana_match_found, [INFO] [stdout] 254 + matched: !(kana_match_found && !matches), [INFO] [stdout] | [INFO] [stdout] 254 - matched: (kana_match_found && matches) || !kana_match_found, [INFO] [stdout] 254 + matched: !kana_match_found || matches, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/deinflect.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | reason_chains.iter().map(|c| c.clone()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `reason_chains.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `KeyIndex` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/key_index.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/key_index.rs:166:24 [INFO] [stdout] | [INFO] [stdout] 166 | Ok(Self::build(keys.into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/key_index.rs:34:29 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn build(keys: impl IntoIterator) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 166 - Ok(Self::build(keys.into_iter())) [INFO] [stdout] 166 + Ok(Self::build(keys)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/sorting.rs:47:31 [INFO] [stdout] | [INFO] [stdout] 47 | if let Ok(wordfreq) = normalized[2..].parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/sorting.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | if normalized.starts_with("nf") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 46 ~ if let Some() = normalized.strip_prefix("nf") { [INFO] [stdout] 47 ~ if let Ok(wordfreq) = .parse::() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/sorting.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | / k.info.as_deref().map_or(false, |info| { [INFO] [stdout] 130 | | info.split(',') [INFO] [stdout] 131 | | .any(|p| matches!(p.trim(), "rK" | "sK" | "iK")) [INFO] [stdout] 132 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 129 - k.info.as_deref().map_or(false, |info| { [INFO] [stdout] 129 + k.info.as_deref().is_some_and(|info| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/sorting.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | / s.misc [INFO] [stdout] 154 | | .as_deref() [INFO] [stdout] 155 | | .map_or(false, |misc| misc.iter().any(|m| m.contains("uk"))) [INFO] [stdout] | |________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 155 - .map_or(false, |misc| misc.iter().any(|m| m.contains("uk"))) [INFO] [stdout] 155 + .is_some_and(|misc| misc.iter().any(|m| m.contains("uk"))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/sorting.rs:172:35 [INFO] [stdout] | [INFO] [stdout] 172 | pub fn sort_word_results(results: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 172 - pub fn sort_word_results(results: &mut Vec) { [INFO] [stdout] 172 + pub fn sort_word_results(results: &mut [WordResult]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sqlite_dict.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 67 | let mut kanji_by_entry: HashMap, Option)>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/sqlite_dict.rs:92:32 [INFO] [stdout] | [INFO] [stdout] 92 | let mut kana_by_entry: HashMap, Option)>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sqlite_dict.rs:229:34 [INFO] [stdout] | [INFO] [stdout] 229 | matched: (kanji_match_found && matches) || !kanji_match_found, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 229 - matched: (kanji_match_found && matches) || !kanji_match_found, [INFO] [stdout] 229 + matched: !(kanji_match_found && !matches), [INFO] [stdout] | [INFO] [stdout] 229 - matched: (kanji_match_found && matches) || !kanji_match_found, [INFO] [stdout] 229 + matched: !kanji_match_found || matches, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sqlite_dict.rs:254:38 [INFO] [stdout] | [INFO] [stdout] 254 | ... matched: (kana_match_found && matches) || !kana_match_found, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 254 - matched: (kana_match_found && matches) || !kana_match_found, [INFO] [stdout] 254 + matched: !(kana_match_found && !matches), [INFO] [stdout] | [INFO] [stdout] 254 - matched: (kana_match_found && matches) || !kana_match_found, [INFO] [stdout] 254 + matched: !kana_match_found || matches, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.16s [INFO] running `Command { std: "docker" "inspect" "91dfe5ae05624753375662533e942a333795637b54f3ec6af0193a999e4f6a61", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91dfe5ae05624753375662533e942a333795637b54f3ec6af0193a999e4f6a61", kill_on_drop: false }` [INFO] [stdout] 91dfe5ae05624753375662533e942a333795637b54f3ec6af0193a999e4f6a61