[INFO] cloning repository https://github.com/ericye16/rusty-tic-tac-toe [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ericye16/rusty-tic-tac-toe" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fericye16%2Frusty-tic-tac-toe", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fericye16%2Frusty-tic-tac-toe'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] dda5667cea5006f90d7782d60ec13d08a39353bb [INFO] linting ericye16/rusty-tic-tac-toe against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fericye16%2Frusty-tic-tac-toe" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ericye16/rusty-tic-tac-toe [INFO] finished tweaking git repo https://github.com/ericye16/rusty-tic-tac-toe [INFO] tweaked toml for git repo https://github.com/ericye16/rusty-tic-tac-toe written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ericye16/rusty-tic-tac-toe on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ericye16/rusty-tic-tac-toe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b5155bf4539c1bd0b091ad0c21ec26746254c25aa5baf73521c5ee526533b3e8 [INFO] running `Command { std: "docker" "start" "-a" "b5155bf4539c1bd0b091ad0c21ec26746254c25aa5baf73521c5ee526533b3e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b5155bf4539c1bd0b091ad0c21ec26746254c25aa5baf73521c5ee526533b3e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5155bf4539c1bd0b091ad0c21ec26746254c25aa5baf73521c5ee526533b3e8", kill_on_drop: false }` [INFO] [stdout] b5155bf4539c1bd0b091ad0c21ec26746254c25aa5baf73521c5ee526533b3e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c2467df2098226adaceea70bf4569dfdde8c4c698ba0c5432e43f13c7baaf9b4 [INFO] running `Command { std: "docker" "start" "-a" "c2467df2098226adaceea70bf4569dfdde8c4c698ba0c5432e43f13c7baaf9b4", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking rusty-tic-tac-toe v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | GameState { state: state } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/game.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | GameState { state: state } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `O` is never constructed [INFO] [stdout] --> src/game.rs:7:3 [INFO] [stdout] | [INFO] [stdout] 4 | enum CellState { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 7 | O, [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `CellState` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `PlayerStatus` is never used [INFO] [stdout] --> src/game.rs:22:10 [INFO] [stdout] | [INFO] [stdout] 22 | pub enum PlayerStatus { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `check_winner` is never used [INFO] [stdout] --> src/game.rs:74:10 [INFO] [stdout] | [INFO] [stdout] 40 | impl GameState { [INFO] [stdout] | -------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn check_winner(&self) -> PlayerStatus { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `E` [INFO] [stdout] --> src/game.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | let E = Empty; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: you might have meant to pattern match on the similarly named variant `X` [INFO] [stdout] | [INFO] [stdout] 229 - let E = Empty; [INFO] [stdout] 229 + let game::CellState::X = Empty; [INFO] [stdout] | [INFO] [stdout] help: if this is intentional, prefix it with an underscore [INFO] [stdout] | [INFO] [stdout] 229 | let _E = Empty; [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/game.rs:54:7 [INFO] [stdout] | [INFO] [stdout] 54 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 84 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 88 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:110:24 [INFO] [stdout] | [INFO] [stdout] 110 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/game.rs:54:7 [INFO] [stdout] | [INFO] [stdout] 54 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:84:24 [INFO] [stdout] | [INFO] [stdout] 84 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:88:23 [INFO] [stdout] | [INFO] [stdout] 88 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:110:24 [INFO] [stdout] | [INFO] [stdout] 110 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:135:22 [INFO] [stdout] | [INFO] [stdout] 135 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:139:21 [INFO] [stdout] | [INFO] [stdout] 139 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:159:22 [INFO] [stdout] | [INFO] [stdout] 159 | winner = winner && true; [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `winner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | loser = loser && true; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `loser` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/main.rs:9:3 [INFO] [stdout] | [INFO] [stdout] 9 | / io::stdin().read_line(&mut n) [INFO] [stdout] 10 | | .ok() [INFO] [stdout] 11 | | .expect("failed to read line"); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 9 - io::stdin().read_line(&mut n) [INFO] [stdout] 10 - .ok() [INFO] [stdout] 11 - .expect("failed to read line"); [INFO] [stdout] 9 + io::stdin().read_line(&mut n).expect("failed to read line"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 21 | Ok(num) if num >= 1 && num <= 3 => num - 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(num) if num >= 1 && num <= 3 => num - 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 80 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 80 + while let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 80 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 80 + if let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 106 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 106 + while let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 106 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 106 + if let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 131 | for cell in self.state.get(get_index(r, r)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 131 - for cell in self.state.get(get_index(r, r)) { [INFO] [stdout] 131 + while let Some(cell) = self.state.get(get_index(r, r)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 131 - for cell in self.state.get(get_index(r, r)) { [INFO] [stdout] 131 + if let Some(cell) = self.state.get(get_index(r, r)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 155 - for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] 155 + while let Some(cell) = self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 155 - for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] 155 + if let Some(cell) = self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `ok().expect()` on a `Result` value [INFO] [stdout] --> src/main.rs:9:3 [INFO] [stdout] | [INFO] [stdout] 9 | / io::stdin().read_line(&mut n) [INFO] [stdout] 10 | | .ok() [INFO] [stdout] 11 | | .expect("failed to read line"); [INFO] [stdout] | |__________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stdout] = note: `#[warn(clippy::ok_expect)]` on by default [INFO] [stdout] help: call `expect()` directly on the `Result` [INFO] [stdout] | [INFO] [stdout] 9 - io::stdin().read_line(&mut n) [INFO] [stdout] 10 - .ok() [INFO] [stdout] 11 - .expect("failed to read line"); [INFO] [stdout] 9 + io::stdin().read_line(&mut n).expect("failed to read line"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:21:18 [INFO] [stdout] | [INFO] [stdout] 21 | Ok(num) if num >= 1 && num <= 3 => num - 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | Ok(num) if num >= 1 && num <= 3 => num - 1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=3).contains(&num)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 80 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 80 + while let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 80 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 80 + if let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 106 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 106 + while let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 106 - for cell in self.state.get(get_index(r, c)) { [INFO] [stdout] 106 + if let Some(cell) = self.state.get(get_index(r, c)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 131 | for cell in self.state.get(get_index(r, r)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 131 - for cell in self.state.get(get_index(r, r)) { [INFO] [stdout] 131 + while let Some(cell) = self.state.get(get_index(r, r)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 131 - for cell in self.state.get(get_index(r, r)) { [INFO] [stdout] 131 + if let Some(cell) = self.state.get(get_index(r, r)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/game.rs:155:19 [INFO] [stdout] | [INFO] [stdout] 155 | for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 155 - for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] 155 + while let Some(cell) = self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 155 - for cell in self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] 155 + if let Some(cell) = self.state.get(get_index(r, 3 - r)) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `E` should have a snake case name [INFO] [stdout] --> src/game.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | let E = Empty; [INFO] [stdout] | ^ help: convert the identifier to snake case: `e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `E` should have a snake case name [INFO] [stdout] --> src/game.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | let E = Empty; [INFO] [stdout] | ^ help: convert the identifier to snake case: `e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `E` should have a snake case name [INFO] [stdout] --> src/game.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | let E = Empty; [INFO] [stdout] | ^ help: convert the identifier to snake case: `e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `E` should have a snake case name [INFO] [stdout] --> src/game.rs:229:9 [INFO] [stdout] | [INFO] [stdout] 229 | let E = Empty; [INFO] [stdout] | ^ help: convert the identifier to snake case: `e` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "c2467df2098226adaceea70bf4569dfdde8c4c698ba0c5432e43f13c7baaf9b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c2467df2098226adaceea70bf4569dfdde8c4c698ba0c5432e43f13c7baaf9b4", kill_on_drop: false }` [INFO] [stdout] c2467df2098226adaceea70bf4569dfdde8c4c698ba0c5432e43f13c7baaf9b4