[INFO] cloning repository https://github.com/erickpires/sokoban [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/erickpires/sokoban" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ferickpires%2Fsokoban", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ferickpires%2Fsokoban'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8b1d4ae1318b1d34d3725314892165f730a5503b [INFO] linting erickpires/sokoban against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ferickpires%2Fsokoban" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/erickpires/sokoban [INFO] finished tweaking git repo https://github.com/erickpires/sokoban [INFO] tweaked toml for git repo https://github.com/erickpires/sokoban written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/erickpires/sokoban on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/erickpires/sokoban already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating git repository `https://github.com/bjz/gl-rs` [INFO] [stderr] Updating git submodule `https://github.com/capnm/Khronos_XML_API` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-integer v0.1.33 [INFO] [stderr] Downloaded c_vec v1.0.12 [INFO] [stderr] Downloaded thread_local v0.3.3 [INFO] [stderr] Downloaded lazy_static v0.2.4 [INFO] [stderr] Downloaded sdl2-sys v0.27.2 [INFO] [stderr] Downloaded log v0.3.7 [INFO] [stderr] Downloaded aho-corasick v0.6.3 [INFO] [stderr] Downloaded xml-rs v0.3.6 [INFO] [stderr] Downloaded rand v0.3.15 [INFO] [stderr] Downloaded thread-id v3.0.0 [INFO] [stderr] Downloaded sdl2 v0.29.0 [INFO] [stderr] Downloaded regex v0.2.1 [INFO] [stderr] Downloaded libc v0.2.21 [INFO] [stderr] Downloaded regex-syntax v0.4.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 47203513de485b8608a21416440aad2e6d631c8c6c2668c2d52b1a4254b8a384 [INFO] running `Command { std: "docker" "start" "-a" "47203513de485b8608a21416440aad2e6d631c8c6c2668c2d52b1a4254b8a384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "47203513de485b8608a21416440aad2e6d631c8c6c2668c2d52b1a4254b8a384", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "47203513de485b8608a21416440aad2e6d631c8c6c2668c2d52b1a4254b8a384", kill_on_drop: false }` [INFO] [stdout] 47203513de485b8608a21416440aad2e6d631c8c6c2668c2d52b1a4254b8a384 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0766b97aeeface6ef7acb9d42f46ab1e17150902225a90d78ac374e2735ea7d3 [INFO] running `Command { std: "docker" "start" "-a" "0766b97aeeface6ef7acb9d42f46ab1e17150902225a90d78ac374e2735ea7d3", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.21 [INFO] [stderr] Compiling khronos_api v1.0.0 (https://github.com/bjz/gl-rs#e4a3bb70) [INFO] [stderr] Compiling xml-rs v0.3.6 [INFO] [stderr] Compiling log v0.3.7 [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Compiling sdl2-sys v0.27.2 [INFO] [stderr] Checking regex-syntax v0.4.0 [INFO] [stderr] Checking c_vec v1.0.12 [INFO] [stderr] Checking lazy_static v0.2.4 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking unreachable v0.1.1 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking num-integer v0.1.33 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Checking sdl2 v0.29.0 [INFO] [stderr] Compiling gl_generator v0.5.2 (https://github.com/bjz/gl-rs#e4a3bb70) [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Compiling gl v0.6.1 (https://github.com/bjz/gl-rs#e4a3bb70) [INFO] [stderr] Checking sokoban v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/math.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 72 | / let result = Vector2 { [INFO] [stdout] 73 | | x : self.x - rhs.x, [INFO] [stdout] 74 | | y : self.y - rhs.y, [INFO] [stdout] 75 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 76 | [INFO] [stdout] 77 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 72 ~ [INFO] [stdout] 73 | [INFO] [stdout] 74 ~ Vector2 { [INFO] [stdout] 75 + x : self.x - rhs.x, [INFO] [stdout] 76 + y : self.y - rhs.y, [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/math.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 86 | / let result = Vector2 { [INFO] [stdout] 87 | | x : self.x + rhs.x, [INFO] [stdout] 88 | | y : self.y + rhs.y, [INFO] [stdout] 89 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 90 | [INFO] [stdout] 91 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 | [INFO] [stdout] 88 ~ Vector2 { [INFO] [stdout] 89 + x : self.x + rhs.x, [INFO] [stdout] 90 + y : self.y + rhs.y, [INFO] [stdout] 91 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/math.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 100 | / let result = Vector2 { [INFO] [stdout] 101 | | x : self.x / rhs, [INFO] [stdout] 102 | | y : self.y / rhs, [INFO] [stdout] 103 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 104 | [INFO] [stdout] 105 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 100 ~ [INFO] [stdout] 101 | [INFO] [stdout] 102 ~ Vector2 { [INFO] [stdout] 103 + x : self.x / rhs, [INFO] [stdout] 104 + y : self.y / rhs, [INFO] [stdout] 105 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/math.rs:116:6 [INFO] [stdout] | [INFO] [stdout] 116 | impl<'a> AddAssign<&'a Vector2> for Vector2 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 116 - impl<'a> AddAssign<&'a Vector2> for Vector2 { [INFO] [stdout] 116 + impl AddAssign<&Vector2> for Vector2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/math.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return None; [INFO] [stdout] 290 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/math.rs:294:6 [INFO] [stdout] | [INFO] [stdout] 294 | impl<'a> Add for &'a Rect2 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 294 - impl<'a> Add for &'a Rect2 { [INFO] [stdout] 294 + impl Add for &Rect2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sdl_misc.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !music.play(-1).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `music.play(-1).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/sdl_misc.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | / match game_controller_subsystem.num_joysticks() { [INFO] [stdout] 79 | | Ok(n) => n, [INFO] [stdout] 80 | | Err(_) => 0, [INFO] [stdout] 81 | | }; [INFO] [stdout] | |_________^ help: replace it with: `game_controller_subsystem.num_joysticks().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/math.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 72 | / let result = Vector2 { [INFO] [stdout] 73 | | x : self.x - rhs.x, [INFO] [stdout] 74 | | y : self.y - rhs.y, [INFO] [stdout] 75 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 76 | [INFO] [stdout] 77 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 72 ~ [INFO] [stdout] 73 | [INFO] [stdout] 74 ~ Vector2 { [INFO] [stdout] 75 + x : self.x - rhs.x, [INFO] [stdout] 76 + y : self.y - rhs.y, [INFO] [stdout] 77 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/math.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 86 | / let result = Vector2 { [INFO] [stdout] 87 | | x : self.x + rhs.x, [INFO] [stdout] 88 | | y : self.y + rhs.y, [INFO] [stdout] 89 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 90 | [INFO] [stdout] 91 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 86 ~ [INFO] [stdout] 87 | [INFO] [stdout] 88 ~ Vector2 { [INFO] [stdout] 89 + x : self.x + rhs.x, [INFO] [stdout] 90 + y : self.y + rhs.y, [INFO] [stdout] 91 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/math.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 100 | / let result = Vector2 { [INFO] [stdout] 101 | | x : self.x / rhs, [INFO] [stdout] 102 | | y : self.y / rhs, [INFO] [stdout] 103 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 104 | [INFO] [stdout] 105 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 100 ~ [INFO] [stdout] 101 | [INFO] [stdout] 102 ~ Vector2 { [INFO] [stdout] 103 + x : self.x / rhs, [INFO] [stdout] 104 + y : self.y / rhs, [INFO] [stdout] 105 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/math.rs:116:6 [INFO] [stdout] | [INFO] [stdout] 116 | impl<'a> AddAssign<&'a Vector2> for Vector2 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 116 - impl<'a> AddAssign<&'a Vector2> for Vector2 { [INFO] [stdout] 116 + impl AddAssign<&Vector2> for Vector2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/math.rs:290:9 [INFO] [stdout] | [INFO] [stdout] 290 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 290 - return None; [INFO] [stdout] 290 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/math.rs:294:6 [INFO] [stdout] | [INFO] [stdout] 294 | impl<'a> Add for &'a Rect2 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 294 - impl<'a> Add for &'a Rect2 { [INFO] [stdout] 294 + impl Add for &Rect2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/sdl_misc.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | if !music.play(-1).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `music.play(-1).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match can be simplified with `.unwrap_or_default()` [INFO] [stdout] --> src/sdl_misc.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | / match game_controller_subsystem.num_joysticks() { [INFO] [stdout] 79 | | Ok(n) => n, [INFO] [stdout] 80 | | Err(_) => 0, [INFO] [stdout] 81 | | }; [INFO] [stdout] | |_________^ help: replace it with: `game_controller_subsystem.num_joysticks().unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::manual_unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | const GAME_NAME : &'static str = "Sokoban"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/main.rs:667:22 [INFO] [stdout] | [INFO] [stdout] 667 | }if axis == RightX { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] = note: `#[warn(clippy::possible_missing_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/main.rs:669:22 [INFO] [stdout] | [INFO] [stdout] 669 | }if axis == RightY { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/main.rs:928:40 [INFO] [stdout] | [INFO] [stdout] 928 | .expect("Failed to write");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:945:58 [INFO] [stdout] | [INFO] [stdout] 945 | fn parse_level(level_name: &str, renderer: &Renderer) -> (Option<(Map, Entity)>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 945 - fn parse_level(level_name: &str, renderer: &Renderer) -> (Option<(Map, Entity)>) { [INFO] [stdout] 945 + fn parse_level(level_name: &str, renderer: &Renderer) -> Option<(Map, Entity)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 44 | const GAME_NAME : &'static str = "Sokoban"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/main.rs:667:22 [INFO] [stdout] | [INFO] [stdout] 667 | }if axis == RightX { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] = note: `#[warn(clippy::possible_missing_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like an `else if` but the `else` is missing [INFO] [stdout] --> src/main.rs:669:22 [INFO] [stdout] | [INFO] [stdout] 669 | }if axis == RightY { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#possible_missing_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/main.rs:928:40 [INFO] [stdout] | [INFO] [stdout] 928 | .expect("Failed to write");; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/main.rs:945:58 [INFO] [stdout] | [INFO] [stdout] 945 | fn parse_level(level_name: &str, renderer: &Renderer) -> (Option<(Map, Entity)>) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 945 - fn parse_level(level_name: &str, renderer: &Renderer) -> (Option<(Map, Entity)>) { [INFO] [stdout] 945 + fn parse_level(level_name: &str, renderer: &Renderer) -> Option<(Map, Entity)> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> src/main.rs:35:52 [INFO] [stdout] | [INFO] [stdout] 35 | fn allowed_motion_before_collision(moving: &Rect2, direction: Vector2, obstacle: &Rect2) -> f32 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `level_music` is never read [INFO] [stdout] --> src/main.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | level_music = play_music(Path::new(map.level_music.as_ref().unwrap().as_str())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> src/main.rs:35:52 [INFO] [stdout] | [INFO] [stdout] 35 | fn allowed_motion_before_collision(moving: &Rect2, direction: Vector2, obstacle: &Rect2) -> f32 { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `right_x_axis`, `action_a`, and `action_b` are never read [INFO] [stdout] --> src/main.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 64 | struct GameInputState { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 68 | right_x_axis: f32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | action_a: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 72 | action_b: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameInputState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fps` is never read [INFO] [stdout] --> src/main.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 102 | struct AnimationInfo { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 106 | fps : u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AnimationInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `collision_against_entities` is never used [INFO] [stdout] --> src/main.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 226 | impl Entity { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 255 | fn collision_against_entities(&self, entities: &Vec, movement: Vector2) -> isize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !moving.collides_with(obstacle).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `moving.collides_with(obstacle).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | let ref current_lane = self.animation_info.animation_lanes[self.animation_info.current_animation_lane_index as usize]; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^-------------------------------------------------------------------------------------------------- help: try: `let current_lane = &self.animation_info.animation_lanes[self.animation_info.current_animation_lane_index as usize];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `level_music` is never read [INFO] [stdout] --> src/main.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | level_music = play_music(Path::new(map.level_music.as_ref().unwrap().as_str())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:263:16 [INFO] [stdout] | [INFO] [stdout] 263 | if !target_rect.collides_with(&entity_rect).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target_rect.collides_with(&entity_rect).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:255:52 [INFO] [stdout] | [INFO] [stdout] 255 | fn collision_against_entities(&self, entities: &Vec, movement: Vector2) -> isize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 255 - fn collision_against_entities(&self, entities: &Vec, movement: Vector2) -> isize { [INFO] [stdout] 255 + fn collision_against_entities(&self, entities: &[Entity], movement: Vector2) -> isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `entities` [INFO] [stdout] --> src/main.rs:259:22 [INFO] [stdout] | [INFO] [stdout] 259 | for index in 0..entities.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 259 - for index in 0..entities.len() { [INFO] [stdout] 259 + for (index, ) in entities.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | let ref entity = entities[index]; [INFO] [stdout] | ----^^^^^^^^^^------------------- help: try: `let entity = &entities[index];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:299:24 [INFO] [stdout] | [INFO] [stdout] 299 | if !target_rect.collides_with(&tile_rect).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target_rect.collides_with(&tile_rect).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:453:47 [INFO] [stdout] | [INFO] [stdout] 453 | let input_file = File::open(map_file).expect(format!("Could not open file: {:?}", map_file).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not open file: {:?}", map_file))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:517:12 [INFO] [stdout] | [INFO] [stdout] 517 | if !tile_texture.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tile_texture.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tile_texture` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:518:32 [INFO] [stdout] | [INFO] [stdout] 517 | if !tile_texture.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 518 | let tile_texture = tile_texture.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:612:8 [INFO] [stdout] | [INFO] [stdout] 612 | if !map.level_music.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.level_music.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `map.level_music` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:613:44 [INFO] [stdout] | [INFO] [stdout] 612 | if !map.level_music.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 613 | level_music = play_music(Path::new(map.level_music.as_ref().unwrap().as_str())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `right_x_axis`, `action_a`, and `action_b` are never read [INFO] [stdout] --> src/main.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 64 | struct GameInputState { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 68 | right_x_axis: f32, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | action_a: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 72 | action_b: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `GameInputState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `fps` is never read [INFO] [stdout] --> src/main.rs:106:5 [INFO] [stdout] | [INFO] [stdout] 102 | struct AnimationInfo { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 106 | fps : u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AnimationInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `collision_against_entities` is never used [INFO] [stdout] --> src/main.rs:255:8 [INFO] [stdout] | [INFO] [stdout] 226 | impl Entity { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 255 | fn collision_against_entities(&self, entities: &Vec, movement: Vector2) -> isize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | if !moving.collides_with(obstacle).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `moving.collides_with(obstacle).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:646:28 [INFO] [stdout] | [INFO] [stdout] 646 | if val <= DEAD_ZONE && val >= -DEAD_ZONE { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-DEAD_ZONE..=DEAD_ZONE).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | let ref current_lane = self.animation_info.animation_lanes[self.animation_info.current_animation_lane_index as usize]; [INFO] [stdout] | ----^^^^^^^^^^^^^^^^-------------------------------------------------------------------------------------------------- help: try: `let current_lane = &self.animation_info.animation_lanes[self.animation_info.current_animation_lane_index as usize];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] = note: `#[warn(clippy::toplevel_ref_arg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:263:16 [INFO] [stdout] | [INFO] [stdout] 263 | if !target_rect.collides_with(&entity_rect).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target_rect.collides_with(&entity_rect).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:255:52 [INFO] [stdout] | [INFO] [stdout] 255 | fn collision_against_entities(&self, entities: &Vec, movement: Vector2) -> isize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 255 - fn collision_against_entities(&self, entities: &Vec, movement: Vector2) -> isize { [INFO] [stdout] 255 + fn collision_against_entities(&self, entities: &[Entity], movement: Vector2) -> isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:787:100 [INFO] [stdout] | [INFO] [stdout] 787 | let (player_texture, texture_w, texture_h) = texture_from_path(Path::new("assets/player.bmp"), &renderer); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `renderer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `entities` [INFO] [stdout] --> src/main.rs:259:22 [INFO] [stdout] | [INFO] [stdout] 259 | for index in 0..entities.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 259 - for index in 0..entities.len() { [INFO] [stdout] 259 + for (index, ) in entities.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stdout] --> src/main.rs:260:17 [INFO] [stdout] | [INFO] [stdout] 260 | let ref entity = entities[index]; [INFO] [stdout] | ----^^^^^^^^^^------------------- help: try: `let entity = &entities[index];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:299:24 [INFO] [stdout] | [INFO] [stdout] 299 | if !target_rect.collides_with(&tile_rect).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `target_rect.collides_with(&tile_rect).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:823:5 [INFO] [stdout] | [INFO] [stdout] 823 | let offset : usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `offset` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 823 ~ [INFO] [stdout] 824 | [INFO] [stdout] 825 ~ let offset : usize = match asset_type { [INFO] [stdout] 826 ~ AssetType::Sound => { "assets/".len() }, [INFO] [stdout] 827 ~ AssetType::Sprite => { "assets/".len() }, [INFO] [stdout] 828 ~ AssetType::Map => { "assets/maps/".len() }, [INFO] [stdout] 829 ~ AssetType::Level => { "assets/maps/".len() }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:868:8 [INFO] [stdout] | [INFO] [stdout] 868 | if !map.level_music.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.level_music.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:874:8 [INFO] [stdout] | [INFO] [stdout] 874 | if !map.next_level.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.next_level.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `map.level_music` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:870:49 [INFO] [stdout] | [INFO] [stdout] 868 | if !map.level_music.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 869 | output_file.write_all(format!("level_music = {}\n", [INFO] [stdout] 870 | remove_asset_path(AssetType::Sound, map.level_music.as_ref().unwrap())).as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `map.next_level` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:876:49 [INFO] [stdout] | [INFO] [stdout] 874 | if !map.next_level.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 875 | output_file.write_all(format!("next_level = {}\n\n", [INFO] [stdout] 876 | remove_asset_path(AssetType::Level, map.next_level.as_ref().unwrap().as_str())).as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:856:8 [INFO] [stdout] | [INFO] [stdout] 856 | if map.boxes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `map.boxes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:453:47 [INFO] [stdout] | [INFO] [stdout] 453 | let input_file = File::open(map_file).expect(format!("Could not open file: {:?}", map_file).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not open file: {:?}", map_file))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:517:12 [INFO] [stdout] | [INFO] [stdout] 517 | if !tile_texture.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `tile_texture.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tile_texture` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:518:32 [INFO] [stdout] | [INFO] [stdout] 517 | if !tile_texture.is_none() { [INFO] [stdout] | ---------------------- the check is happening here [INFO] [stdout] 518 | let tile_texture = tile_texture.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:921:47 [INFO] [stdout] | [INFO] [stdout] 921 | let mut map_file = File::create(map_path).expect(format!("Could not open file {:?}", map_path).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not open file {:?}", map_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:612:8 [INFO] [stdout] | [INFO] [stdout] 612 | if !map.level_music.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.level_music.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `map.level_music` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:613:44 [INFO] [stdout] | [INFO] [stdout] 612 | if !map.level_music.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 613 | level_music = play_music(Path::new(map.level_music.as_ref().unwrap().as_str())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/main.rs:931:25 [INFO] [stdout] | [INFO] [stdout] 931 | let tile_code = match tile_type { [INFO] [stdout] | _________________________^ [INFO] [stdout] 932 | | &TileType::Wall => 1, [INFO] [stdout] 933 | | &TileType::Floor => 0, [INFO] [stdout] 934 | | &TileType::Target => 4, [INFO] [stdout] 935 | | &TileType::Blank => 5, [INFO] [stdout] 936 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 931 ~ let tile_code = match *tile_type { [INFO] [stdout] 932 ~ TileType::Wall => 1, [INFO] [stdout] 933 ~ TileType::Floor => 0, [INFO] [stdout] 934 ~ TileType::Target => 4, [INFO] [stdout] 935 ~ TileType::Blank => 5, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:978:12 [INFO] [stdout] | [INFO] [stdout] 978 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:1057:28 [INFO] [stdout] | [INFO] [stdout] 1057 | let level_music_path = match _level_music { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1058 | | Some(path) => Some(asset_path_string(AssetType::Sound, path.as_str())), [INFO] [stdout] 1059 | | None => None, [INFO] [stdout] 1060 | | }; [INFO] [stdout] | |_____^ help: try: `_level_music.map(|path| asset_path_string(AssetType::Sound, path.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:1061:27 [INFO] [stdout] | [INFO] [stdout] 1061 | let next_level_path = match _next_level { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 1062 | | Some(path) => Some(asset_path_string(AssetType::Level, path.as_str())), [INFO] [stdout] 1063 | | None => None, [INFO] [stdout] 1064 | | }; [INFO] [stdout] | |_____^ help: try: `_next_level.map(|path| asset_path_string(AssetType::Level, path.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:1138:5 [INFO] [stdout] | [INFO] [stdout] 1136 | let result = tuple_from_strings::(v_0_str, v_1_str); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 1137 | [INFO] [stdout] 1138 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 1136 ~ [INFO] [stdout] 1137 | [INFO] [stdout] 1138 ~ tuple_from_strings::(v_0_str, v_1_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:646:28 [INFO] [stdout] | [INFO] [stdout] 646 | if val <= DEAD_ZONE && val >= -DEAD_ZONE { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(-DEAD_ZONE..=DEAD_ZONE).contains(&val)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tuple` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:1176:25 [INFO] [stdout] | [INFO] [stdout] 1171 | if tuple.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = tuple` [INFO] [stdout] ... [INFO] [stdout] 1176 | result.push(tuple.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rest` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:1182:23 [INFO] [stdout] | [INFO] [stdout] 1179 | if rest.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = rest` [INFO] [stdout] ... [INFO] [stdout] 1182 | vec_str = rest.unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:1191:74 [INFO] [stdout] | [INFO] [stdout] 1191 | fn draw_text(renderer: &mut Renderer, font: &Font, color: Color, string: &String, position: Vector2, centered: bool) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1191 - fn draw_text(renderer: &mut Renderer, font: &Font, color: Color, string: &String, position: Vector2, centered: bool) { [INFO] [stdout] 1191 + fn draw_text(renderer: &mut Renderer, font: &Font, color: Color, string: &str, position: Vector2, centered: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:1201:5 [INFO] [stdout] | [INFO] [stdout] 1201 | let text_rect; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `text_rect` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1201 ~ [INFO] [stdout] 1202 | [INFO] [stdout] 1203 ~ let text_rect = if centered { [INFO] [stdout] 1204 ~ Rect::new(text_x - (text_width / 2) as i32, text_y - (text_height / 2) as i32, text_width, text_height) [INFO] [stdout] 1205 | } else { [INFO] [stdout] 1206 ~ Rect::new(text_x, text_y, text_width, text_height) [INFO] [stdout] 1207 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `copy` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:1209:19 [INFO] [stdout] | [INFO] [stdout] 1209 | renderer.copy(&mut text_texture, None, Some(text_rect)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1209 - renderer.copy(&mut text_texture, None, Some(text_rect)).unwrap(); [INFO] [stdout] 1209 + renderer.copy(&text_texture, None, Some(text_rect)).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:787:100 [INFO] [stdout] | [INFO] [stdout] 787 | let (player_texture, texture_w, texture_h) = texture_from_path(Path::new("assets/player.bmp"), &renderer); [INFO] [stdout] | ^^^^^^^^^ help: change this to: `renderer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `entity_mass` should have an upper case name [INFO] [stdout] --> src/main.rs:722:19 [INFO] [stdout] | [INFO] [stdout] 722 | const entity_mass : f32 = 0.0058; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 722 - const entity_mass : f32 = 0.0058; [INFO] [stdout] 722 + const ENTITY_MASS : f32 = 0.0058; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `drag` should have an upper case name [INFO] [stdout] --> src/main.rs:723:19 [INFO] [stdout] | [INFO] [stdout] 723 | const drag : f32 = 20.0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 723 - const drag : f32 = 20.0; [INFO] [stdout] 723 + const DRAG : f32 = 20.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:823:5 [INFO] [stdout] | [INFO] [stdout] 823 | let offset : usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `offset` here and remove the assignments from the `match` arms [INFO] [stdout] | [INFO] [stdout] 823 ~ [INFO] [stdout] 824 | [INFO] [stdout] 825 ~ let offset : usize = match asset_type { [INFO] [stdout] 826 ~ AssetType::Sound => { "assets/".len() }, [INFO] [stdout] 827 ~ AssetType::Sprite => { "assets/".len() }, [INFO] [stdout] 828 ~ AssetType::Map => { "assets/maps/".len() }, [INFO] [stdout] 829 ~ AssetType::Level => { "assets/maps/".len() }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:868:8 [INFO] [stdout] | [INFO] [stdout] 868 | if !map.level_music.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.level_music.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:874:8 [INFO] [stdout] | [INFO] [stdout] 874 | if !map.next_level.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `map.next_level.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `map.level_music` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:870:49 [INFO] [stdout] | [INFO] [stdout] 868 | if !map.level_music.is_none() { [INFO] [stdout] | ------------------------- the check is happening here [INFO] [stdout] 869 | output_file.write_all(format!("level_music = {}\n", [INFO] [stdout] 870 | remove_asset_path(AssetType::Sound, map.level_music.as_ref().unwrap())).as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `map.next_level` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:876:49 [INFO] [stdout] | [INFO] [stdout] 874 | if !map.next_level.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 875 | output_file.write_all(format!("next_level = {}\n\n", [INFO] [stdout] 876 | remove_asset_path(AssetType::Level, map.next_level.as_ref().unwrap().as_str())).as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:856:8 [INFO] [stdout] | [INFO] [stdout] 856 | if map.boxes.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `map.boxes.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:921:47 [INFO] [stdout] | [INFO] [stdout] 921 | let mut map_file = File::create(map_path).expect(format!("Could not open file {:?}", map_path).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Could not open file {:?}", map_path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you don't need to add `&` to all patterns [INFO] [stdout] --> src/main.rs:931:25 [INFO] [stdout] | [INFO] [stdout] 931 | let tile_code = match tile_type { [INFO] [stdout] | _________________________^ [INFO] [stdout] 932 | | &TileType::Wall => 1, [INFO] [stdout] 933 | | &TileType::Floor => 0, [INFO] [stdout] 934 | | &TileType::Target => 4, [INFO] [stdout] 935 | | &TileType::Blank => 5, [INFO] [stdout] 936 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stdout] = note: `#[warn(clippy::match_ref_pats)]` on by default [INFO] [stdout] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stdout] | [INFO] [stdout] 931 ~ let tile_code = match *tile_type { [INFO] [stdout] 932 ~ TileType::Wall => 1, [INFO] [stdout] 933 ~ TileType::Floor => 0, [INFO] [stdout] 934 ~ TileType::Target => 4, [INFO] [stdout] 935 ~ TileType::Blank => 5, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:978:12 [INFO] [stdout] | [INFO] [stdout] 978 | if line == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `line.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:1057:28 [INFO] [stdout] | [INFO] [stdout] 1057 | let level_music_path = match _level_music { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 1058 | | Some(path) => Some(asset_path_string(AssetType::Sound, path.as_str())), [INFO] [stdout] 1059 | | None => None, [INFO] [stdout] 1060 | | }; [INFO] [stdout] | |_____^ help: try: `_level_music.map(|path| asset_path_string(AssetType::Sound, path.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:1061:27 [INFO] [stdout] | [INFO] [stdout] 1061 | let next_level_path = match _next_level { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 1062 | | Some(path) => Some(asset_path_string(AssetType::Level, path.as_str())), [INFO] [stdout] 1063 | | None => None, [INFO] [stdout] 1064 | | }; [INFO] [stdout] | |_____^ help: try: `_next_level.map(|path| asset_path_string(AssetType::Level, path.as_str()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:1138:5 [INFO] [stdout] | [INFO] [stdout] 1136 | let result = tuple_from_strings::(v_0_str, v_1_str); [INFO] [stdout] | --------------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 1137 | [INFO] [stdout] 1138 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 1136 ~ [INFO] [stdout] 1137 | [INFO] [stdout] 1138 ~ tuple_from_strings::(v_0_str, v_1_str) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tuple` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:1176:25 [INFO] [stdout] | [INFO] [stdout] 1171 | if tuple.is_none() { [INFO] [stdout] | ------------------ help: try: `if let Some() = tuple` [INFO] [stdout] ... [INFO] [stdout] 1176 | result.push(tuple.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `rest` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:1182:23 [INFO] [stdout] | [INFO] [stdout] 1179 | if rest.is_none() { [INFO] [stdout] | ----------------- help: try: `if let Some() = rest` [INFO] [stdout] ... [INFO] [stdout] 1182 | vec_str = rest.unwrap().as_str(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:1191:74 [INFO] [stdout] | [INFO] [stdout] 1191 | fn draw_text(renderer: &mut Renderer, font: &Font, color: Color, string: &String, position: Vector2, centered: bool) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1191 - fn draw_text(renderer: &mut Renderer, font: &Font, color: Color, string: &String, position: Vector2, centered: bool) { [INFO] [stdout] 1191 + fn draw_text(renderer: &mut Renderer, font: &Font, color: Color, string: &str, position: Vector2, centered: bool) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/main.rs:1201:5 [INFO] [stdout] | [INFO] [stdout] 1201 | let text_rect; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `text_rect` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1201 ~ [INFO] [stdout] 1202 | [INFO] [stdout] 1203 ~ let text_rect = if centered { [INFO] [stdout] 1204 ~ Rect::new(text_x - (text_width / 2) as i32, text_y - (text_height / 2) as i32, text_width, text_height) [INFO] [stdout] 1205 | } else { [INFO] [stdout] 1206 ~ Rect::new(text_x, text_y, text_width, text_height) [INFO] [stdout] 1207 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `copy` doesn't need a mutable reference [INFO] [stdout] --> src/main.rs:1209:19 [INFO] [stdout] | [INFO] [stdout] 1209 | renderer.copy(&mut text_texture, None, Some(text_rect)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1209 - renderer.copy(&mut text_texture, None, Some(text_rect)).unwrap(); [INFO] [stdout] 1209 + renderer.copy(&text_texture, None, Some(text_rect)).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `entity_mass` should have an upper case name [INFO] [stdout] --> src/main.rs:722:19 [INFO] [stdout] | [INFO] [stdout] 722 | const entity_mass : f32 = 0.0058; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 722 - const entity_mass : f32 = 0.0058; [INFO] [stdout] 722 + const ENTITY_MASS : f32 = 0.0058; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `drag` should have an upper case name [INFO] [stdout] --> src/main.rs:723:19 [INFO] [stdout] | [INFO] [stdout] 723 | const drag : f32 = 20.0; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 723 - const drag : f32 = 20.0; [INFO] [stdout] 723 + const DRAG : f32 = 20.0; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.78s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "0766b97aeeface6ef7acb9d42f46ab1e17150902225a90d78ac374e2735ea7d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0766b97aeeface6ef7acb9d42f46ab1e17150902225a90d78ac374e2735ea7d3", kill_on_drop: false }` [INFO] [stdout] 0766b97aeeface6ef7acb9d42f46ab1e17150902225a90d78ac374e2735ea7d3