[INFO] cloning repository https://github.com/eqrion/wasm-generate-testsuite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eqrion/wasm-generate-testsuite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feqrion%2Fwasm-generate-testsuite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feqrion%2Fwasm-generate-testsuite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6cfb5cf93dff9bc3f461af35f7810e056a8e76be [INFO] linting eqrion/wasm-generate-testsuite against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feqrion%2Fwasm-generate-testsuite" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eqrion/wasm-generate-testsuite [INFO] finished tweaking git repo https://github.com/eqrion/wasm-generate-testsuite [INFO] tweaked toml for git repo https://github.com/eqrion/wasm-generate-testsuite written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eqrion/wasm-generate-testsuite on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eqrion/wasm-generate-testsuite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wast v35.0.1 [INFO] [stderr] Downloaded winapi-util v0.1.4 [INFO] [stderr] Downloaded is-macro v0.1.9 [INFO] [stderr] Downloaded swc_visit_macros v0.2.3 [INFO] [stderr] Downloaded swc_ecma_visit v0.26.0 [INFO] [stderr] Downloaded pmutil v0.5.3 [INFO] [stderr] Downloaded serde_derive v1.0.125 [INFO] [stderr] Downloaded swc_visit v0.2.4 [INFO] [stderr] Downloaded swc_ecmascript v0.27.0 [INFO] [stderr] Downloaded from_variant v0.1.3 [INFO] [stderr] Downloaded enum_kind v0.2.1 [INFO] [stderr] Downloaded dprint-core v0.35.3 [INFO] [stderr] Downloaded swc_ecma_ast v0.40.0 [INFO] [stderr] Downloaded dprint-swc-ecma-ast-view v0.12.0 [INFO] [stderr] Downloaded swc_macros_common v0.3.3 [INFO] [stderr] Downloaded syn v1.0.65 [INFO] [stderr] Downloaded swc_ecma_parser v0.50.0 [INFO] [stderr] Downloaded swc_atoms v0.2.5 [INFO] [stderr] Downloaded ast_node v0.7.2 [INFO] [stderr] Downloaded swc_eq_ignore_macros v0.1.0 [INFO] [stderr] Downloaded string_enum v0.3.1 [INFO] [stderr] Downloaded swc_common v0.10.13 [INFO] [stderr] Downloaded aho-corasick v0.7.9 [INFO] [stderr] Downloaded leb128 v0.2.4 [INFO] [stderr] Downloaded dprint-plugin-typescript v0.42.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c6253bb854752b69dbae1350c6ea4e10df6399485b520905270c478f3408ad2 [INFO] running `Command { std: "docker" "start" "-a" "4c6253bb854752b69dbae1350c6ea4e10df6399485b520905270c478f3408ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c6253bb854752b69dbae1350c6ea4e10df6399485b520905270c478f3408ad2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c6253bb854752b69dbae1350c6ea4e10df6399485b520905270c478f3408ad2", kill_on_drop: false }` [INFO] [stdout] 4c6253bb854752b69dbae1350c6ea4e10df6399485b520905270c478f3408ad2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8fec7a0c9859fcd19d78274b5edca32401aeb22fefa34db1488b54d26844dd1e [INFO] running `Command { std: "docker" "start" "-a" "8fec7a0c9859fcd19d78274b5edca32401aeb22fefa34db1488b54d26844dd1e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling syn v1.0.65 [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling ppv-lite86 v0.2.10 [INFO] [stderr] Compiling siphasher v0.3.5 [INFO] [stderr] Compiling regex-syntax v0.6.14 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling aho-corasick v0.7.9 [INFO] [stderr] Checking new_debug_unreachable v1.0.4 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking unicode-xid v0.2.0 [INFO] [stderr] Checking bumpalo v3.6.1 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking leb128 v0.2.4 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking wast v35.0.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Checking regex v1.3.4 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.1 [INFO] [stderr] Compiling swc_atoms v0.2.5 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling pmutil v0.5.3 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling swc_macros_common v0.3.3 [INFO] [stderr] Compiling swc_visit_macros v0.2.3 [INFO] [stderr] Compiling swc_eq_ignore_macros v0.1.0 [INFO] [stderr] Compiling from_variant v0.1.3 [INFO] [stderr] Compiling is-macro v0.1.9 [INFO] [stderr] Compiling string_enum v0.3.1 [INFO] [stderr] Compiling enum_kind v0.2.1 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling ast_node v0.7.2 [INFO] [stderr] Checking swc_visit v0.2.4 [INFO] [stderr] Checking string_cache v0.8.1 [INFO] [stderr] Checking dprint-core v0.35.3 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking swc_common v0.10.13 [INFO] [stderr] Checking swc_ecma_ast v0.40.0 [INFO] [stderr] Checking swc_ecma_visit v0.26.0 [INFO] [stderr] Checking swc_ecma_parser v0.50.0 [INFO] [stderr] Checking swc_ecmascript v0.27.0 [INFO] [stderr] Checking dprint-swc-ecma-ast-view v0.12.0 [INFO] [stderr] Checking dprint-plugin-typescript v0.42.0 [INFO] [stderr] Checking wast2js v0.1.0 (/opt/rustwide/workdir/wast2js) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | const HARNESS: &'static str = include_str!("./harness.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | const LICENSE: &'static str = include_str!("./license.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | const HARNESS: &'static str = include_str!("./harness.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | const LICENSE: &'static str = include_str!("./license.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `writeln!` args [INFO] [stdout] --> wast2js/src/convert.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | / writeln!( [INFO] [stdout] 109 | | out, [INFO] [stdout] 110 | | "register(${}, {});", [INFO] [stdout] 111 | | next_instance, [INFO] [stdout] 112 | | format!("`{}`", escape_template_string(id.name())) [INFO] [stdout] 113 | | )?; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `writeln!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> wast2js/src/convert.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | writeln!(out, "")?; [INFO] [stdout] | ^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(&module[0..i]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(&module[0..i]); [INFO] [stdout] 281 + Ok(&module[0..i]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> wast2js/src/convert.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | State::EscapeQStr => match next { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 276 | | _ => state = State::QStr, [INFO] [stdout] 277 | | }, [INFO] [stdout] | |_____________^ help: consider using the match body instead: `state = State::QStr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> wast2js/src/convert.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | text.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `text.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | / return a.is_nan() [INFO] [stdout] 361 | | || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 | | || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits(); [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 ~ a.is_nan() [INFO] [stdout] 361 + || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 ~ || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 366 | return a.is_nan(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return a.is_nan(); [INFO] [stdout] 366 + a.is_nan() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 389 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:434:25 [INFO] [stdout] | [INFO] [stdout] 434 | CanonicalNan => format!("`f32_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:435:26 [INFO] [stdout] | [INFO] [stdout] 435 | ArithmeticNan => format!("`f32_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:443:25 [INFO] [stdout] | [INFO] [stdout] 443 | CanonicalNan => format!("`f64_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:444:26 [INFO] [stdout] | [INFO] [stdout] 444 | ArithmeticNan => format!("`f64_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `writeln!` args [INFO] [stdout] --> wast2js/src/convert.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | / writeln!( [INFO] [stdout] 109 | | out, [INFO] [stdout] 110 | | "register(${}, {});", [INFO] [stdout] 111 | | next_instance, [INFO] [stdout] 112 | | format!("`{}`", escape_template_string(id.name())) [INFO] [stdout] 113 | | )?; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `writeln!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:458:43 [INFO] [stdout] | [INFO] [stdout] 458 | Some(wast::HeapType::Func) => format!("value('funcref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('funcref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:459:45 [INFO] [stdout] | [INFO] [stdout] 459 | Some(wast::HeapType::Extern) => format!("value('externref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('externref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|x| f32_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f32_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:498:30 [INFO] [stdout] | [INFO] [stdout] 498 | .map(|x| f64_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f64_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> wast2js/src/convert.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | writeln!(out, "")?; [INFO] [stdout] | ^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(&module[0..i]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(&module[0..i]); [INFO] [stdout] 281 + Ok(&module[0..i]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> wast2js/src/convert.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | State::EscapeQStr => match next { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 276 | | _ => state = State::QStr, [INFO] [stdout] 277 | | }, [INFO] [stdout] | |_____________^ help: consider using the match body instead: `state = State::QStr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> wast2js/src/convert.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | text.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `text.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:570:23 [INFO] [stdout] | [INFO] [stdout] 570 | RefNull(_) => format!("null"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"null".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | / return a.is_nan() [INFO] [stdout] 361 | | || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 | | || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits(); [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 ~ a.is_nan() [INFO] [stdout] 361 + || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 ~ || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 366 | return a.is_nan(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return a.is_nan(); [INFO] [stdout] 366 + a.is_nan() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 389 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:434:25 [INFO] [stdout] | [INFO] [stdout] 434 | CanonicalNan => format!("`f32_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:435:26 [INFO] [stdout] | [INFO] [stdout] 435 | ArithmeticNan => format!("`f32_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:443:25 [INFO] [stdout] | [INFO] [stdout] 443 | CanonicalNan => format!("`f64_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:444:26 [INFO] [stdout] | [INFO] [stdout] 444 | ArithmeticNan => format!("`f64_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:458:43 [INFO] [stdout] | [INFO] [stdout] 458 | Some(wast::HeapType::Func) => format!("value('funcref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('funcref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:459:45 [INFO] [stdout] | [INFO] [stdout] 459 | Some(wast::HeapType::Extern) => format!("value('externref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('externref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|x| f32_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f32_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:498:30 [INFO] [stdout] | [INFO] [stdout] 498 | .map(|x| f64_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f64_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:570:23 [INFO] [stdout] | [INFO] [stdout] 570 | RefNull(_) => format!("null"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"null".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wasm-generate-testsuite v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | const HARNESS: &'static str = include_str!("./harness.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | const LICENSE: &'static str = include_str!("./license.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | const HARNESS: &'static str = include_str!("./harness.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> wast2js/src/convert.rs:22:17 [INFO] [stdout] | [INFO] [stdout] 22 | const LICENSE: &'static str = include_str!("./license.js"); [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `writeln!` args [INFO] [stdout] --> wast2js/src/convert.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | / writeln!( [INFO] [stdout] 109 | | out, [INFO] [stdout] 110 | | "register(${}, {});", [INFO] [stdout] 111 | | next_instance, [INFO] [stdout] 112 | | format!("`{}`", escape_template_string(id.name())) [INFO] [stdout] 113 | | )?; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `writeln!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use toml; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use wast2js; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> wast2js/src/convert.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | writeln!(out, "")?; [INFO] [stdout] | ^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(&module[0..i]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(&module[0..i]); [INFO] [stdout] 281 + Ok(&module[0..i]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> wast2js/src/convert.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | State::EscapeQStr => match next { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 276 | | _ => state = State::QStr, [INFO] [stdout] 277 | | }, [INFO] [stdout] | |_____________^ help: consider using the match body instead: `state = State::QStr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> wast2js/src/convert.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | text.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `text.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | / return a.is_nan() [INFO] [stdout] 361 | | || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 | | || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits(); [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 ~ a.is_nan() [INFO] [stdout] 361 + || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 ~ || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 366 | return a.is_nan(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return a.is_nan(); [INFO] [stdout] 366 + a.is_nan() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 389 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:434:25 [INFO] [stdout] | [INFO] [stdout] 434 | CanonicalNan => format!("`f32_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:435:26 [INFO] [stdout] | [INFO] [stdout] 435 | ArithmeticNan => format!("`f32_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:443:25 [INFO] [stdout] | [INFO] [stdout] 443 | CanonicalNan => format!("`f64_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:444:26 [INFO] [stdout] | [INFO] [stdout] 444 | ArithmeticNan => format!("`f64_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:458:43 [INFO] [stdout] | [INFO] [stdout] 458 | Some(wast::HeapType::Func) => format!("value('funcref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('funcref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:459:45 [INFO] [stdout] | [INFO] [stdout] 459 | Some(wast::HeapType::Extern) => format!("value('externref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('externref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|x| f32_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f32_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:498:30 [INFO] [stdout] | [INFO] [stdout] 498 | .map(|x| f64_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f64_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:570:23 [INFO] [stdout] | [INFO] [stdout] 570 | RefNull(_) => format!("null"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"null".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use toml; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use wast2js; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `writeln!` args [INFO] [stdout] --> wast2js/src/convert.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | / writeln!( [INFO] [stdout] 109 | | out, [INFO] [stdout] 110 | | "register(${}, {});", [INFO] [stdout] 111 | | next_instance, [INFO] [stdout] 112 | | format!("`{}`", escape_template_string(id.name())) [INFO] [stdout] 113 | | )?; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `writeln!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/main.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | self.repos.iter_mut().find(|x| &x.name == name) [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `x.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> wast2js/src/convert.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | writeln!(out, "")?; [INFO] [stdout] | ^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:281:5 [INFO] [stdout] | [INFO] [stdout] 281 | return Ok(&module[0..i]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 281 - return Ok(&module[0..i]); [INFO] [stdout] 281 + Ok(&module[0..i]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> wast2js/src/convert.rs:275:34 [INFO] [stdout] | [INFO] [stdout] 275 | State::EscapeQStr => match next { [INFO] [stdout] | __________________________________^ [INFO] [stdout] 276 | | _ => state = State::QStr, [INFO] [stdout] 277 | | }, [INFO] [stdout] | |_____________^ help: consider using the match body instead: `state = State::QStr` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> wast2js/src/convert.rs:300:9 [INFO] [stdout] | [INFO] [stdout] 300 | text.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `text.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | / return a.is_nan() [INFO] [stdout] 361 | | || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 | | || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits(); [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 360 ~ a.is_nan() [INFO] [stdout] 361 + || ((a as f64) as f32).to_bits() != a.to_bits() [INFO] [stdout] 362 ~ || (format!("{:.}", a).parse::().unwrap() as f32).to_bits() != a.to_bits() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> wast2js/src/convert.rs:366:5 [INFO] [stdout] | [INFO] [stdout] 366 | return a.is_nan(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 366 - return a.is_nan(); [INFO] [stdout] 366 + a.is_nan() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:387:9 [INFO] [stdout] | [INFO] [stdout] 387 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:389:9 [INFO] [stdout] | [INFO] [stdout] 389 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:397:9 [INFO] [stdout] | [INFO] [stdout] 397 | format!("Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | format!("-Infinity") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-Infinity".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:401:9 [INFO] [stdout] | [INFO] [stdout] 401 | format!("-0") [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-0".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:434:25 [INFO] [stdout] | [INFO] [stdout] 434 | CanonicalNan => format!("`f32_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/main.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 65 | .find(|x| &x.name == name) [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `x.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:435:26 [INFO] [stdout] | [INFO] [stdout] 435 | ArithmeticNan => format!("`f32_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f32_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/main.rs:70:60 [INFO] [stdout] | [INFO] [stdout] 70 | if let Some(lock) = self.repos.iter_mut().find(|x| &x.name == name) { [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `x.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:443:25 [INFO] [stdout] | [INFO] [stdout] 443 | CanonicalNan => format!("`f64_canonical_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_canonical_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:444:26 [INFO] [stdout] | [INFO] [stdout] 444 | ArithmeticNan => format!("`f64_arithmetic_nan`"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"`f64_arithmetic_nan`".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:458:43 [INFO] [stdout] | [INFO] [stdout] 458 | Some(wast::HeapType::Func) => format!("value('funcref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('funcref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:459:45 [INFO] [stdout] | [INFO] [stdout] 459 | Some(wast::HeapType::Extern) => format!("value('externref', null)"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"value('externref', null)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|x| f32_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f32_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> wast2js/src/convert.rs:498:30 [INFO] [stdout] | [INFO] [stdout] 498 | .map(|x| f64_pattern_to_js_value(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `f64_pattern_to_js_value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> wast2js/src/convert.rs:570:23 [INFO] [stdout] | [INFO] [stdout] 570 | RefNull(_) => format!("null"), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"null".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:223:41 [INFO] [stdout] | [INFO] [stdout] 223 | let repo = config.find_repo_mut(&name).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:224:25 [INFO] [stdout] | [INFO] [stdout] 224 | lock.set_commit(&name, &status.commit_base_hash); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/main.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 255 | let remote_branch = repo.branch.as_ref().map(|x| x.as_str()).unwrap_or("master"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `repo.branch.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:262:52 [INFO] [stdout] | [INFO] [stdout] 262 | run("git", &["remote", "add", remote_name, &remote_url])?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `remote_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 48.51s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:359:8 [INFO] [stdout] | [INFO] [stdout] 359 | if !repo.parent.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `repo.parent.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | if !run("git", &["merge", "-q", parent, "-m", &message]).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["merge", "-q", parent, "-m", &message]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:369:16 [INFO] [stdout] | [INFO] [stdout] 369 | if !run("git", &["checkout", "--ours", "document"]).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["checkout", "--ours", "document"]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:370:20 [INFO] [stdout] | [INFO] [stdout] 370 | || !run("git", &["add", "document"]).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["add", "document"]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:371:20 [INFO] [stdout] | [INFO] [stdout] 371 | || !run("git", &["-c", "core.editor=true", "merge", "--continue"]).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["-c", "core.editor=true", "merge", "--continue"]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:379:39 [INFO] [stdout] | [INFO] [stdout] 379 | run("git", &["reset", &commit_base_hash, "--hard"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `commit_base_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:404:36 [INFO] [stdout] | [INFO] [stdout] 404 | Path::new("./js").join(&path.with_extension("wast.js").file_name().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path.with_extension("wast.js").file_name().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:434:19 [INFO] [stdout] | [INFO] [stdout] 434 | .join(&stripped_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `stripped_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/main.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | config.directive.as_ref().map(|x| x.as_str()).unwrap_or(""), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `config.directive.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/main.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 452 | repo.directive.as_ref().map(|x| x.as_str()).unwrap_or("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `repo.directive.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:470:14 [INFO] [stdout] | [INFO] [stdout] 470 | .map(|x| PathBuf::from(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:467:50 [INFO] [stdout] | [INFO] [stdout] 467 | &["diff", "--name-only", &repo.name, &parent, "test/core"], [INFO] [stdout] | ^^^^^^^ help: change this to: `parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/main.rs:32:40 [INFO] [stdout] | [INFO] [stdout] 32 | self.repos.iter_mut().find(|x| &x.name == name) [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `x.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/main.rs:65:23 [INFO] [stdout] | [INFO] [stdout] 65 | .find(|x| &x.name == name) [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `x.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/main.rs:70:60 [INFO] [stdout] | [INFO] [stdout] 70 | if let Some(lock) = self.repos.iter_mut().find(|x| &x.name == name) { [INFO] [stdout] | -------^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `x.name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:223:41 [INFO] [stdout] | [INFO] [stdout] 223 | let repo = config.find_repo_mut(&name).unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:224:25 [INFO] [stdout] | [INFO] [stdout] 224 | lock.set_commit(&name, &status.commit_base_hash); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/main.rs:255:25 [INFO] [stdout] | [INFO] [stdout] 255 | let remote_branch = repo.branch.as_ref().map(|x| x.as_str()).unwrap_or("master"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `repo.branch.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:262:52 [INFO] [stdout] | [INFO] [stdout] 262 | run("git", &["remote", "add", remote_name, &remote_url])?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `remote_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:359:8 [INFO] [stdout] | [INFO] [stdout] 359 | if !repo.parent.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `repo.parent.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 367 | if !run("git", &["merge", "-q", parent, "-m", &message]).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["merge", "-q", parent, "-m", &message]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:369:16 [INFO] [stdout] | [INFO] [stdout] 369 | if !run("git", &["checkout", "--ours", "document"]).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["checkout", "--ours", "document"]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:370:20 [INFO] [stdout] | [INFO] [stdout] 370 | || !run("git", &["add", "document"]).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["add", "document"]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:371:20 [INFO] [stdout] | [INFO] [stdout] 371 | || !run("git", &["-c", "core.editor=true", "merge", "--continue"]).is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `run("git", &["-c", "core.editor=true", "merge", "--continue"]).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:379:39 [INFO] [stdout] | [INFO] [stdout] 379 | run("git", &["reset", &commit_base_hash, "--hard"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `commit_base_hash` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:404:36 [INFO] [stdout] | [INFO] [stdout] 404 | Path::new("./js").join(&path.with_extension("wast.js").file_name().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path.with_extension("wast.js").file_name().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:434:19 [INFO] [stdout] | [INFO] [stdout] 434 | .join(&stripped_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `stripped_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/main.rs:451:9 [INFO] [stdout] | [INFO] [stdout] 451 | config.directive.as_ref().map(|x| x.as_str()).unwrap_or(""), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `config.directive.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/main.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 452 | repo.directive.as_ref().map(|x| x.as_str()).unwrap_or("") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `repo.directive.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:470:14 [INFO] [stdout] | [INFO] [stdout] 470 | .map(|x| PathBuf::from(x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `PathBuf::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:467:50 [INFO] [stdout] | [INFO] [stdout] 467 | &["diff", "--name-only", &repo.name, &parent, "test/core"], [INFO] [stdout] | ^^^^^^^ help: change this to: `parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8fec7a0c9859fcd19d78274b5edca32401aeb22fefa34db1488b54d26844dd1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fec7a0c9859fcd19d78274b5edca32401aeb22fefa34db1488b54d26844dd1e", kill_on_drop: false }` [INFO] [stdout] 8fec7a0c9859fcd19d78274b5edca32401aeb22fefa34db1488b54d26844dd1e