[INFO] cloning repository https://github.com/endojs/endo-but-for-bots [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/endojs/endo-but-for-bots" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendojs%2Fendo-but-for-bots", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendojs%2Fendo-but-for-bots'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 08e9129afeda02667a9b72136443b8ef95b3f186 [INFO] linting endojs/endo-but-for-bots against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fendojs%2Fendo-but-for-bots" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] [stderr] Updating files: 31% (12644/40437) Updating files: 32% (12940/40437) Updating files: 33% (13345/40437) Updating files: 34% (13749/40437) Updating files: 35% (14153/40437) Updating files: 36% (14558/40437) Updating files: 37% (14962/40437) Updating files: 38% (15367/40437) Updating files: 39% (15771/40437) Updating files: 40% (16175/40437) Updating files: 41% (16580/40437) Updating files: 42% (16984/40437) Updating files: 43% (17388/40437) Updating files: 44% (17793/40437) Updating files: 45% (18197/40437) Updating files: 46% (18602/40437) Updating files: 47% (19006/40437) Updating files: 48% (19410/40437) Updating files: 49% (19815/40437) Updating files: 50% (20219/40437) Updating files: 51% (20623/40437) Updating files: 52% (21028/40437) Updating files: 53% (21432/40437) Updating files: 54% (21836/40437) Updating files: 55% (22241/40437) Updating files: 56% (22645/40437) Updating files: 57% (23050/40437) Updating files: 58% (23454/40437) Updating files: 59% (23858/40437) Updating files: 60% (24263/40437) Updating files: 61% (24667/40437) Updating files: 62% (25071/40437) Updating files: 63% (25476/40437) Updating files: 64% (25880/40437) Updating files: 64% (26213/40437) Updating files: 65% (26285/40437) Updating files: 66% (26689/40437) Updating files: 67% (27093/40437) Updating files: 68% (27498/40437) Updating files: 69% (27902/40437) Updating files: 70% (28306/40437) Updating files: 71% (28711/40437) Updating files: 72% (29115/40437) Updating files: 73% (29520/40437) Updating files: 74% (29924/40437) Updating files: 75% (30328/40437) Updating files: 76% (30733/40437) Updating files: 77% (31137/40437) Updating files: 78% (31541/40437) Updating files: 79% (31946/40437) Updating files: 80% (32350/40437) Updating files: 81% (32754/40437) Updating files: 82% (33159/40437) Updating files: 83% (33563/40437) Updating files: 84% (33968/40437) Updating files: 85% (34372/40437) Updating files: 86% (34776/40437) Updating files: 87% (35181/40437) Updating files: 88% (35585/40437) Updating files: 89% (35989/40437) Updating files: 90% (36394/40437) Updating files: 91% (36798/40437) Updating files: 92% (37203/40437) Updating files: 93% (37607/40437) Updating files: 94% (38011/40437) Updating files: 95% (38416/40437) Updating files: 96% (38820/40437) Updating files: 97% (39224/40437) Updating files: 98% (39629/40437) Updating files: 99% (40033/40437) Updating files: 99% (40403/40437) Updating files: 100% (40437/40437) Updating files: 100% (40437/40437), done. [INFO] started tweaking git repo https://github.com/endojs/endo-but-for-bots [INFO] finished tweaking git repo https://github.com/endojs/endo-but-for-bots [INFO] tweaked toml for git repo https://github.com/endojs/endo-but-for-bots written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/endojs/endo-but-for-bots on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/endojs/endo-but-for-bots already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_derive v1.0.225 [INFO] [stderr] Downloaded noise-protocol v0.2.0 [INFO] [stderr] Downloaded noise-rust-crypto v0.6.2 [INFO] [stderr] Downloaded serde_core v1.0.225 [INFO] [stderr] Downloaded serde v1.0.225 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 817084377f9a17f11a076ab5d047a0a30a0c665d1c7754a50190f694de7dd697 [INFO] running `Command { std: "docker" "start" "-a" "817084377f9a17f11a076ab5d047a0a30a0c665d1c7754a50190f694de7dd697", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "817084377f9a17f11a076ab5d047a0a30a0c665d1c7754a50190f694de7dd697", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "817084377f9a17f11a076ab5d047a0a30a0c665d1c7754a50190f694de7dd697", kill_on_drop: false }` [INFO] [stdout] 817084377f9a17f11a076ab5d047a0a30a0c665d1c7754a50190f694de7dd697 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 91670d68c0dfbbe1fa200f71256b3048f162aa23ecf56db857bd740703cc370e [INFO] running `Command { std: "docker" "start" "-a" "91670d68c0dfbbe1fa200f71256b3048f162aa23ecf56db857bd740703cc370e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.175 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking noise-protocol v0.2.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking x25519-dalek v2.0.1 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking noise-rust-crypto v0.6.2 [INFO] [stderr] Checking ocapn_noise_protocol_facilities v0.1.0 (/opt/rustwide/workdir/rust/ocapn_noise) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:107:30 [INFO] [stdout] | [INFO] [stdout] 107 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:109:30 [INFO] [stdout] | [INFO] [stdout] 109 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:124:30 [INFO] [stdout] | [INFO] [stdout] 124 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:126:30 [INFO] [stdout] | [INFO] [stdout] 126 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return 0; [INFO] [stdout] 174 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / match hs.write_message( [INFO] [stdout] 164 | | &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 165 | | &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 166 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 170 | | Ok(()) => (), [INFO] [stdout] 171 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 164 + &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 165 + &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 166 + ) { [INFO] [stdout] 167 + return 1; [INFO] [stdout] 168 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return 0; [INFO] [stdout] 233 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / match hs.read_message( [INFO] [stdout] 223 | | &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 224 | | &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 225 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 229 | | Ok(_) => (), [INFO] [stdout] 230 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 223 + &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 224 + &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 225 + ) { [INFO] [stdout] 226 + return 2; [INFO] [stdout] 227 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - return 0; [INFO] [stdout] 257 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | / match hs.write_message( [INFO] [stdout] 247 | | &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 248 | | &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 249 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 253 | | Ok(_) => (), [INFO] [stdout] 254 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 247 + &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 248 + &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 249 + ) { [INFO] [stdout] 250 + return 2; [INFO] [stdout] 251 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | if !responder_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] 305 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 303 ~ if responder_verifying_key [INFO] [stdout] 304 + .verify(&responder_public_crypt_key.as_slice(), &responder_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return 0; [INFO] [stdout] 311 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | / match hs.read_message( [INFO] [stdout] 271 | | &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 272 | | &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 273 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 277 | | Ok(_) => (), [INFO] [stdout] 278 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 270 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 271 + &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 272 + &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 273 + ) { [INFO] [stdout] 274 + return 2; [INFO] [stdout] 275 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `responder_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return 0; [INFO] [stdout] 337 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | / match hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 326 | | Err(_) => { [INFO] [stdout] 327 | | return 1; [INFO] [stdout] ... | [INFO] [stdout] 330 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 325 ~ if let Err(_) = hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 326 + return 1; [INFO] [stdout] 327 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | if !initiator_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 381 | | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] 382 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 380 ~ if initiator_verifying_key [INFO] [stdout] 381 + .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 392 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 392 - return 0; [INFO] [stdout] 392 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | / match hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 350 | | Err(_) => { [INFO] [stdout] 351 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 354 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 349 ~ if let Err(_) = hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 350 + return 2; [INFO] [stdout] 351 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:381:21 [INFO] [stdout] | [INFO] [stdout] 381 | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `initiator_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return 0; [INFO] [stdout] 411 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - return 0; [INFO] [stdout] 435 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | / match decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 429 | | Err(_) => { [INFO] [stdout] 430 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 433 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 428 ~ if let Err(_) = decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 429 + return 2; [INFO] [stdout] 430 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:107:30 [INFO] [stdout] | [INFO] [stdout] 107 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:109:30 [INFO] [stdout] | [INFO] [stdout] 109 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:124:30 [INFO] [stdout] | [INFO] [stdout] 124 | .copy_from_slice(&signing_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `signing_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:126:30 [INFO] [stdout] | [INFO] [stdout] 126 | .copy_from_slice(&verifying_key.to_bytes().as_slice()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `verifying_key.to_bytes().as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 174 - return 0; [INFO] [stdout] 174 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / match hs.write_message( [INFO] [stdout] 164 | | &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 165 | | &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 166 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 170 | | Ok(()) => (), [INFO] [stdout] 171 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 163 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 164 + &BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 165 + &mut BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 166 + ) { [INFO] [stdout] 167 + return 1; [INFO] [stdout] 168 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:233:9 [INFO] [stdout] | [INFO] [stdout] 233 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 233 - return 0; [INFO] [stdout] 233 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | / match hs.read_message( [INFO] [stdout] 223 | | &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 224 | | &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 225 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 229 | | Ok(_) => (), [INFO] [stdout] 230 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 222 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 223 + &BUFFER[SYN_OFFSET..][..SYN_LENGTH], [INFO] [stdout] 224 + &mut BUFFER[SYN_PAYLOAD_OFFSET..][..SYN_PAYLOAD_LENGTH], [INFO] [stdout] 225 + ) { [INFO] [stdout] 226 + return 2; [INFO] [stdout] 227 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 257 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 257 - return 0; [INFO] [stdout] 257 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | / match hs.write_message( [INFO] [stdout] 247 | | &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 248 | | &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 249 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 253 | | Ok(_) => (), [INFO] [stdout] 254 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 246 ~ if let Err(_) = hs.write_message( [INFO] [stdout] 247 + &BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 248 + &mut BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 249 + ) { [INFO] [stdout] 250 + return 2; [INFO] [stdout] 251 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | if !responder_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 304 | | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] 305 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 303 ~ if responder_verifying_key [INFO] [stdout] 304 + .verify(&responder_public_crypt_key.as_slice(), &responder_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:311:9 [INFO] [stdout] | [INFO] [stdout] 311 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return 0; [INFO] [stdout] 311 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | / match hs.read_message( [INFO] [stdout] 271 | | &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 272 | | &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 273 | | ) { [INFO] [stdout] ... | [INFO] [stdout] 277 | | Ok(_) => (), [INFO] [stdout] 278 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 270 ~ if let Err(_) = hs.read_message( [INFO] [stdout] 271 + &BUFFER[SYNACK_OFFSET..][..SYNACK_LENGTH], [INFO] [stdout] 272 + &mut BUFFER[SYNACK_PAYLOAD_OFFSET..][..SYNACK_PAYLOAD_LENGTH], [INFO] [stdout] 273 + ) { [INFO] [stdout] 274 + return 2; [INFO] [stdout] 275 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:304:21 [INFO] [stdout] | [INFO] [stdout] 304 | .verify(&responder_public_crypt_key.as_slice(), &responder_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `responder_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return 0; [INFO] [stdout] 337 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:325:9 [INFO] [stdout] | [INFO] [stdout] 325 | / match hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 326 | | Err(_) => { [INFO] [stdout] 327 | | return 1; [INFO] [stdout] ... | [INFO] [stdout] 330 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 325 ~ if let Err(_) = hs.write_message(&[], &mut BUFFER[ACK_OFFSET..][..ACK_LENGTH]) { [INFO] [stdout] 326 + return 1; [INFO] [stdout] 327 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:380:12 [INFO] [stdout] | [INFO] [stdout] 380 | if !initiator_verifying_key [INFO] [stdout] | ____________^ [INFO] [stdout] 381 | | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] 382 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 380 ~ if initiator_verifying_key [INFO] [stdout] 381 + .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:392:9 [INFO] [stdout] | [INFO] [stdout] 392 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 392 - return 0; [INFO] [stdout] 392 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | / match hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 350 | | Err(_) => { [INFO] [stdout] 351 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 354 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 349 ~ if let Err(_) = hs.read_message(&BUFFER[ACK_OFFSET..][..ACK_LENGTH], &mut []) { [INFO] [stdout] 350 + return 2; [INFO] [stdout] 351 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:381:21 [INFO] [stdout] | [INFO] [stdout] 381 | .verify(&initiator_public_crypt_key.as_slice(), &initiator_signature) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `initiator_public_crypt_key.as_slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:411:9 [INFO] [stdout] | [INFO] [stdout] 411 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return 0; [INFO] [stdout] 411 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:435:9 [INFO] [stdout] | [INFO] [stdout] 435 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 435 - return 0; [INFO] [stdout] 435 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> rust/ocapn_noise/src/lib.rs:428:9 [INFO] [stdout] | [INFO] [stdout] 428 | / match decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 429 | | Err(_) => { [INFO] [stdout] 430 | | return 2; [INFO] [stdout] ... | [INFO] [stdout] 433 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 428 ~ if let Err(_) = decrypter.decrypt_in_place(&mut BUFFER, length) { [INFO] [stdout] 429 + return 2; [INFO] [stdout] 430 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.42s [INFO] running `Command { std: "docker" "inspect" "91670d68c0dfbbe1fa200f71256b3048f162aa23ecf56db857bd740703cc370e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "91670d68c0dfbbe1fa200f71256b3048f162aa23ecf56db857bd740703cc370e", kill_on_drop: false }` [INFO] [stdout] 91670d68c0dfbbe1fa200f71256b3048f162aa23ecf56db857bd740703cc370e