[INFO] cloning repository https://github.com/enderavour/di-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/enderavour/di-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fenderavour%2Fdi-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fenderavour%2Fdi-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4cf6adaf52e9c3bf81093def844c775bb53823f [INFO] linting enderavour/di-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fenderavour%2Fdi-rs" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/enderavour/di-rs [INFO] finished tweaking git repo https://github.com/enderavour/di-rs [INFO] tweaked toml for git repo https://github.com/enderavour/di-rs written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/enderavour/di-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/enderavour/di-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded failure v0.1.8 [INFO] [stderr] Downloaded failure_derive v0.1.8 [INFO] [stderr] Downloaded num-format v0.1.2 [INFO] [stderr] Downloaded clap v4.5.53 [INFO] [stderr] Downloaded cc v1.2.49 [INFO] [stderr] Downloaded clap_builder v4.5.53 [INFO] [stderr] Downloaded syn v2.0.111 [INFO] [stderr] Downloaded libc v0.2.178 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e85ecab20f1a276cda83aa248263b20482635ddc91cf322c28a6d366d5461809 [INFO] running `Command { std: "docker" "start" "-a" "e85ecab20f1a276cda83aa248263b20482635ddc91cf322c28a6d366d5461809", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e85ecab20f1a276cda83aa248263b20482635ddc91cf322c28a6d366d5461809", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e85ecab20f1a276cda83aa248263b20482635ddc91cf322c28a6d366d5461809", kill_on_drop: false }` [INFO] [stdout] e85ecab20f1a276cda83aa248263b20482635ddc91cf322c28a6d366d5461809 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c0d14a90939370efa1973d4e8142b1e718397c86432ea5ca7b459664b04ea35e [INFO] running `Command { std: "docker" "start" "-a" "c0d14a90939370efa1973d4e8142b1e718397c86432ea5ca7b459664b04ea35e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking adler2 v2.0.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking rustc-demangle v0.1.26 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking num-format v0.1.2 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking dir v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/utils.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::{self, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/utils.rs:5:15 [INFO] [stdout] | [INFO] [stdout] 5 | use std::fs::{self, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | let mut entry_p = path_entry.0; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `path` is never read [INFO] [stdout] --> src/main.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | let mut path = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `entry_type` is never read [INFO] [stdout] --> src/main.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | let mut entry_type = EntryType::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | let mut entry_p = path_entry.0; [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `path` is never read [INFO] [stdout] --> src/main.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | let mut path = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `entry_type` is never read [INFO] [stdout] --> src/main.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | let mut entry_type = EntryType::Unknown; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/walkdir.rs:78:2 [INFO] [stdout] | [INFO] [stdout] 78 | / if let EntryType::Dir = entry_type [INFO] [stdout] 79 | | { [INFO] [stdout] 80 | | if let Ok((ref part_unstr, ref mnt_unstr)) = utils::dname_and_mp(path) [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 78 ~ if let EntryType::Dir = entry_type [INFO] [stdout] 79 ~ && let Ok((ref part_unstr, ref mnt_unstr)) = utils::dname_and_mp(path) [INFO] [stdout] 80 | { [INFO] [stdout] ... [INFO] [stdout] 99 | dir_count, "Dir(s)", &(utils::d_free_space(&CString::new(mnt).unwrap()).to_formatted_string(&Locale::fr))); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/walkdir.rs:78:2 [INFO] [stdout] | [INFO] [stdout] 78 | / if let EntryType::Dir = entry_type [INFO] [stdout] 79 | | { [INFO] [stdout] 80 | | if let Ok((ref part_unstr, ref mnt_unstr)) = utils::dname_and_mp(path) [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 78 ~ if let EntryType::Dir = entry_type [INFO] [stdout] 79 ~ && let Ok((ref part_unstr, ref mnt_unstr)) = utils::dname_and_mp(path) [INFO] [stdout] 80 | { [INFO] [stdout] ... [INFO] [stdout] 99 | dir_count, "Dir(s)", &(utils::d_free_space(&CString::new(mnt).unwrap()).to_formatted_string(&Locale::fr))); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn strip_buf_zeros(line: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - pub fn strip_buf_zeros(line: &String) -> String [INFO] [stdout] 54 + pub fn strip_buf_zeros(line: &str) -> String [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/args.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn parse_args() -> Option<(Option>, Option>)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/args.rs:16:60 [INFO] [stdout] | [INFO] [stdout] 16 | let parsed_paths = path_args.iter().map(|path| parse_path(*path)).collect::>(); [INFO] [stdout] | ^^^^^ help: try: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | if !path_info.is_ok() { return (arg.clone(), EntryType::Unknown) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `path_info.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/args.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | let parsed = &arg[1..]; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/args.rs:82:3 [INFO] [stdout] | [INFO] [stdout] 82 | / if arg.starts_with("-") [INFO] [stdout] 83 | | { [INFO] [stdout] | |________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 82 ~ if let Some(parsed) = arg.strip_prefix("-") { [INFO] [stdout] 83 | // Skip / [INFO] [stdout] 84 ~ let action = match parsed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `named` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 34 | if named.is_some() [INFO] [stdout] | ------------------ help: try: `if let Some() = named` [INFO] [stdout] 35 | { [INFO] [stdout] 36 | for arg in named.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `paths` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 28 | if paths.is_none() [INFO] [stdout] | ------------------ help: try: `if let Some() = paths` [INFO] [stdout] ... [INFO] [stdout] 65 | for path_entry in paths.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `named` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 68 | if named.is_some() [INFO] [stdout] | ------------------ help: try: `if let Some() = &named` [INFO] [stdout] 69 | { [INFO] [stdout] 70 | for arg in named.as_ref().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn strip_buf_zeros(line: &String) -> String [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 54 - pub fn strip_buf_zeros(line: &String) -> String [INFO] [stdout] 54 + pub fn strip_buf_zeros(line: &str) -> String [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/args.rs:5:24 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn parse_args() -> Option<(Option>, Option>)> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/args.rs:16:60 [INFO] [stdout] | [INFO] [stdout] 16 | let parsed_paths = path_args.iter().map(|path| parse_path(*path)).collect::>(); [INFO] [stdout] | ^^^^^ help: try: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:63:5 [INFO] [stdout] | [INFO] [stdout] 63 | if !path_info.is_ok() { return (arg.clone(), EntryType::Unknown) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `path_info.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/args.rs:85:17 [INFO] [stdout] | [INFO] [stdout] 85 | let parsed = &arg[1..]; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/args.rs:82:3 [INFO] [stdout] | [INFO] [stdout] 82 | / if arg.starts_with("-") [INFO] [stdout] 83 | | { [INFO] [stdout] | |________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 82 ~ if let Some(parsed) = arg.strip_prefix("-") { [INFO] [stdout] 83 | // Skip / [INFO] [stdout] 84 ~ let action = match parsed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `named` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 34 | if named.is_some() [INFO] [stdout] | ------------------ help: try: `if let Some() = named` [INFO] [stdout] 35 | { [INFO] [stdout] 36 | for arg in named.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `paths` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 28 | if paths.is_none() [INFO] [stdout] | ------------------ help: try: `if let Some() = paths` [INFO] [stdout] ... [INFO] [stdout] 65 | for path_entry in paths.unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `named` after checking its variant with `is_some` [INFO] [stdout] --> src/main.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 68 | if named.is_some() [INFO] [stdout] | ------------------ help: try: `if let Some() = &named` [INFO] [stdout] 69 | { [INFO] [stdout] 70 | for arg in named.as_ref().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.04s [INFO] running `Command { std: "docker" "inspect" "c0d14a90939370efa1973d4e8142b1e718397c86432ea5ca7b459664b04ea35e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0d14a90939370efa1973d4e8142b1e718397c86432ea5ca7b459664b04ea35e", kill_on_drop: false }` [INFO] [stdout] c0d14a90939370efa1973d4e8142b1e718397c86432ea5ca7b459664b04ea35e