[INFO] cloning repository https://github.com/emmgame221/HackAssembler [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/emmgame221/HackAssembler" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Femmgame221%2FHackAssembler", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Femmgame221%2FHackAssembler'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54125d9bae6f0c1b47574457c540385295883292 [INFO] linting emmgame221/HackAssembler against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Femmgame221%2FHackAssembler" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/emmgame221/HackAssembler [INFO] finished tweaking git repo https://github.com/emmgame221/HackAssembler [INFO] tweaked toml for git repo https://github.com/emmgame221/HackAssembler written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/emmgame221/HackAssembler on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/emmgame221/HackAssembler already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 08365968eab2adea00f1200ec83eb3cd030da10c5ed1bd34347bb00a603cb0e1 [INFO] running `Command { std: "docker" "start" "-a" "08365968eab2adea00f1200ec83eb3cd030da10c5ed1bd34347bb00a603cb0e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "08365968eab2adea00f1200ec83eb3cd030da10c5ed1bd34347bb00a603cb0e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "08365968eab2adea00f1200ec83eb3cd030da10c5ed1bd34347bb00a603cb0e1", kill_on_drop: false }` [INFO] [stdout] 08365968eab2adea00f1200ec83eb3cd030da10c5ed1bd34347bb00a603cb0e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c051264ea734c7aeb22ceadd00a4cad96b9a8d91bd9de050f3ee7b860bce953 [INFO] running `Command { std: "docker" "start" "-a" "4c051264ea734c7aeb22ceadd00a4cad96b9a8d91bd9de050f3ee7b860bce953", kill_on_drop: false }` [INFO] [stderr] Checking hack_assembler v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:23:49 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|x| !x.starts_with("//") && !(x == "") && !(x == "\n")) [INFO] [stdout] | ^^^^^^^^^^ help: try: `(x != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|x| !x.starts_with("//") && !(x == "") && !(x == "\n")) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(x != "\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/parser.rs:23:51 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|x| !x.starts_with("//") && !(x == "") && !(x == "\n")) [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/main.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | let arg1 = match args().skip(1).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | .expect(&format!("{} is not a valid file.", arg1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{} is not a valid file.", arg1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:23:49 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|x| !x.starts_with("//") && !(x == "") && !(x == "\n")) [INFO] [stdout] | ^^^^^^^^^^ help: try: `(x != "")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|x| !x.starts_with("//") && !(x == "") && !(x == "\n")) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(x != "\n")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/parser.rs:23:51 [INFO] [stdout] | [INFO] [stdout] 23 | .filter(|x| !x.starts_with("//") && !(x == "") && !(x == "\n")) [INFO] [stdout] | ^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> src/main.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | let arg1 = match args().skip(1).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | .expect(&format!("{} is not a valid file.", arg1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("{} is not a valid file.", arg1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "4c051264ea734c7aeb22ceadd00a4cad96b9a8d91bd9de050f3ee7b860bce953", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c051264ea734c7aeb22ceadd00a4cad96b9a8d91bd9de050f3ee7b860bce953", kill_on_drop: false }` [INFO] [stdout] 4c051264ea734c7aeb22ceadd00a4cad96b9a8d91bd9de050f3ee7b860bce953