[INFO] cloning repository https://github.com/elunico/rust-ini-parser
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/elunico/rust-ini-parser" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felunico%2Frust-ini-parser", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felunico%2Frust-ini-parser'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 417f6b3727f65c102833bcaebbe7294ef29d8e87
[INFO] linting elunico/rust-ini-parser against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felunico%2Frust-ini-parser" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/elunico/rust-ini-parser
[INFO] finished tweaking git repo https://github.com/elunico/rust-ini-parser
[INFO] tweaked toml for git repo https://github.com/elunico/rust-ini-parser written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/elunico/rust-ini-parser on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/elunico/rust-ini-parser already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 37abe17d6fbd83984dcb5692223cf1b98fcd5653e7aaa9d56ad1957c420ae3a9
[INFO] running `Command { std: "docker" "start" "-a" "37abe17d6fbd83984dcb5692223cf1b98fcd5653e7aaa9d56ad1957c420ae3a9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "37abe17d6fbd83984dcb5692223cf1b98fcd5653e7aaa9d56ad1957c420ae3a9", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "37abe17d6fbd83984dcb5692223cf1b98fcd5653e7aaa9d56ad1957c420ae3a9", kill_on_drop: false }`
[INFO] [stdout] 37abe17d6fbd83984dcb5692223cf1b98fcd5653e7aaa9d56ad1957c420ae3a9
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 27593316f1687a0cbeb7c7caff776697b30265da86d3d98b0710a39489f2ecf5
[INFO] running `Command { std: "docker" "start" "-a" "27593316f1687a0cbeb7c7caff776697b30265da86d3d98b0710a39489f2ecf5", kill_on_drop: false }`
[INFO] [stderr]     Checking rust-ini-parser v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `std::collections::HashMap`
[INFO] [stdout]  --> src/configfile.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::collections::HashMap;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/parsing.rs:233:5
[INFO] [stdout]     |
[INFO] [stdout] 233 |     sections: sections,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::collections::HashMap`
[INFO] [stdout]  --> src/configfile.rs:3:5
[INFO] [stdout]   |
[INFO] [stdout] 3 | use std::collections::HashMap;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/parsing.rs:233:5
[INFO] [stdout]     |
[INFO] [stdout] 233 |     sections: sections,
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/configfile.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 | /     return Ok(ConfigFile {
[INFO] [stdout] 20 | |       inifile: parse_ini_file(filename)?,
[INFO] [stdout] 21 | |     });
[INFO] [stdout]    | |______^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 ~     Ok(ConfigFile {
[INFO] [stdout] 20 +       inifile: parse_ini_file(filename)?,
[INFO] [stdout] 21 ~     })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/configfile.rs:29:5
[INFO] [stdout]    |
[INFO] [stdout] 29 |     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 -     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout] 29 +     Some(self.inifile.peek_section(section)?.peek_value(key)?)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded
[INFO] [stdout]   --> src/configfile.rs:29:12
[INFO] [stdout]    |
[INFO] [stdout] 29 |     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]    = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Some` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 29 -     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout] 29 +     return self.inifile.peek_section(section)?.peek_value(key);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/configfile.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 |     return self.inifile.write_to_file(filename, false);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -     return self.inifile.write_to_file(filename, false);
[INFO] [stdout] 51 +     self.inifile.write_to_file(filename, false)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:27:5
[INFO] [stdout]    |
[INFO] [stdout] 27 |     return self.sections.get_mut(section);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 -     return self.sections.get_mut(section);
[INFO] [stdout] 27 +     self.sections.get_mut(section)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:31:5
[INFO] [stdout]    |
[INFO] [stdout] 31 |     return self.sections.get(section);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 31 -     return self.sections.get(section);
[INFO] [stdout] 31 +     self.sections.get(section)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     return None;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 40 -     return None;
[INFO] [stdout] 40 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 |     return None;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 49 -     return None;
[INFO] [stdout] 49 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:44:19
[INFO] [stdout]    |
[INFO] [stdout] 44 |     for (_, v) in &self.sections {
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout]    = note: `#[warn(clippy::for_kv_map)]` on by default
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 44 -     for (_, v) in &self.sections {
[INFO] [stdout] 44 +     for v in self.sections.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/inifile.rs:46:22
[INFO] [stdout]    |
[INFO] [stdout] 46 |         return Some((&v, val.value.as_str()));
[INFO] [stdout]    |                      ^^ help: change this to: `v`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 |     return None;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 58 -     return None;
[INFO] [stdout] 58 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:53:21
[INFO] [stdout]    |
[INFO] [stdout] 53 |     for (_, sec) in &self.sections {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 53 -     for (_, sec) in &self.sections {
[INFO] [stdout] 53 +     for sec in self.sections.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:73:25
[INFO] [stdout]    |
[INFO] [stdout] 73 |       for (_, entry) in &section.entries {
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 73 -       for (_, entry) in &section.entries {
[INFO] [stdout] 73 +       for entry in section.entries.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:85:25
[INFO] [stdout]    |
[INFO] [stdout] 85 |     for (_, section) in &self.sections {
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 85 -     for (_, section) in &self.sections {
[INFO] [stdout] 85 +     for section in self.sections.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/inifile.rs:86:60
[INFO] [stdout]    |
[INFO] [stdout] 86 |       if section.is_default || (!include_empty_sections && section.entries.len() == 0) {
[INFO] [stdout]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `section.entries.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/inifile.rs:90:32
[INFO] [stdout]    |
[INFO] [stdout] 90 |       write_entries(&mut file, &section);
[INFO] [stdout]    |                                ^^^^^^^^ help: change this to: `section`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     return self.is_default;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -     return self.is_default;
[INFO] [stdout] 123 +     self.is_default
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:146:5
[INFO] [stdout]     |
[INFO] [stdout] 146 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 146 -     return None;
[INFO] [stdout] 146 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:155:5
[INFO] [stdout]     |
[INFO] [stdout] 155 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 155 -     return None;
[INFO] [stdout] 155 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:164:5
[INFO] [stdout]     |
[INFO] [stdout] 164 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 164 -     return None;
[INFO] [stdout] 164 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:173:5
[INFO] [stdout]     |
[INFO] [stdout] 173 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 173 -     return None;
[INFO] [stdout] 173 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 | /     return self.chars[self.mark_index..self.current_index]
[INFO] [stdout] 50 | |       .iter()
[INFO] [stdout] 51 | |       .collect();
[INFO] [stdout]    | |________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 49 ~     self.chars[self.mark_index..self.current_index]
[INFO] [stdout] 50 +       .iter()
[INFO] [stdout] 51 ~       .collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:56:7
[INFO] [stdout]    |
[INFO] [stdout] 56 |       return CharResult::Eof;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 56 -       return CharResult::Eof;
[INFO] [stdout] 56 +       CharResult::Eof
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/configfile.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 19 | /     return Ok(ConfigFile {
[INFO] [stdout] 20 | |       inifile: parse_ini_file(filename)?,
[INFO] [stdout] 21 | |     });
[INFO] [stdout]    | |______^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 19 ~     Ok(ConfigFile {
[INFO] [stdout] 20 +       inifile: parse_ini_file(filename)?,
[INFO] [stdout] 21 ~     })
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:58:7
[INFO] [stdout]    |
[INFO] [stdout] 58 |       return CharResult::Char(self.chars[self.current_index]);
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 58 -       return CharResult::Char(self.chars[self.current_index]);
[INFO] [stdout] 58 +       CharResult::Char(self.chars[self.current_index])
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:72:7
[INFO] [stdout]    |
[INFO] [stdout] 72 |       return CharResult::Char(c);
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -       return CharResult::Char(c);
[INFO] [stdout] 72 +       CharResult::Char(c)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:74:7
[INFO] [stdout]    |
[INFO] [stdout] 74 |       return CharResult::Eof;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 74 -       return CharResult::Eof;
[INFO] [stdout] 74 +       CharResult::Eof
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/configfile.rs:29:5
[INFO] [stdout]    |
[INFO] [stdout] 29 |     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 -     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout] 29 +     Some(self.inifile.peek_section(section)?.peek_value(key)?)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Some` and `?` operator are unneeded
[INFO] [stdout]   --> src/configfile.rs:29:12
[INFO] [stdout]    |
[INFO] [stdout] 29 |     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]    = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Some` and `?` operator
[INFO] [stdout]    |
[INFO] [stdout] 29 -     return Some(self.inifile.peek_section(section)?.peek_value(key)?);
[INFO] [stdout] 29 +     return self.inifile.peek_section(section)?.peek_value(key);
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:79:5
[INFO] [stdout]    |
[INFO] [stdout] 79 | /     return format!(
[INFO] [stdout] 80 | |       "Parse error: {} at line {}, column {} (char {})",
[INFO] [stdout] 81 | |       msg, self.line, self.col, self.pos
[INFO] [stdout] 82 | |     );
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 ~     format!(
[INFO] [stdout] 80 +       "Parse error: {} at line {}, column {} (char {})",
[INFO] [stdout] 81 +       msg, self.line, self.col, self.pos
[INFO] [stdout] 82 ~     )
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/configfile.rs:51:5
[INFO] [stdout]    |
[INFO] [stdout] 51 |     return self.inifile.write_to_file(filename, false);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 51 -     return self.inifile.write_to_file(filename, false);
[INFO] [stdout] 51 +     self.inifile.write_to_file(filename, false)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:119:5
[INFO] [stdout]     |
[INFO] [stdout] 119 |     return Ok(None);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -     return Ok(None);
[INFO] [stdout] 119 +     Ok(None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:132:5
[INFO] [stdout]     |
[INFO] [stdout] 132 |     return Ok(None);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 132 -     return Ok(None);
[INFO] [stdout] 132 +     Ok(None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:27:5
[INFO] [stdout]    |
[INFO] [stdout] 27 |     return self.sections.get_mut(section);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 27 -     return self.sections.get_mut(section);
[INFO] [stdout] 27 +     self.sections.get_mut(section)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:31:5
[INFO] [stdout]    |
[INFO] [stdout] 31 |     return self.sections.get(section);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 31 -     return self.sections.get(section);
[INFO] [stdout] 31 +     self.sections.get(section)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:40:5
[INFO] [stdout]    |
[INFO] [stdout] 40 |     return None;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 40 -     return None;
[INFO] [stdout] 40 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 |     return None;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 49 -     return None;
[INFO] [stdout] 49 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:44:19
[INFO] [stdout]    |
[INFO] [stdout] 44 |     for (_, v) in &self.sections {
[INFO] [stdout]    |                   ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout]    = note: `#[warn(clippy::for_kv_map)]` on by default
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 44 -     for (_, v) in &self.sections {
[INFO] [stdout] 44 +     for v in self.sections.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/inifile.rs:46:22
[INFO] [stdout]    |
[INFO] [stdout] 46 |         return Some((&v, val.value.as_str()));
[INFO] [stdout]    |                      ^^ help: change this to: `v`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/inifile.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 |     return None;
[INFO] [stdout]    |     ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 58 -     return None;
[INFO] [stdout] 58 +     None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:53:21
[INFO] [stdout]    |
[INFO] [stdout] 53 |     for (_, sec) in &self.sections {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 53 -     for (_, sec) in &self.sections {
[INFO] [stdout] 53 +     for sec in self.sections.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:166:5
[INFO] [stdout]     |
[INFO] [stdout] 166 | /     return Err(self.error(
[INFO] [stdout] 167 | |       "Empty section! Set environment var INI_PARSER_ALLOW_EMPTY_SECTIONS to true to allow",
[INFO] [stdout] 168 | |     ));
[INFO] [stdout]     | |______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 166 ~     Err(self.error(
[INFO] [stdout] 167 +       "Empty section! Set environment var INI_PARSER_ALLOW_EMPTY_SECTIONS to true to allow",
[INFO] [stdout] 168 ~     ))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:172:5
[INFO] [stdout]     |
[INFO] [stdout] 172 | /     return match (self.parse_key()?, self.parse_value()?) {
[INFO] [stdout] 173 | |       (Some(k), Some(v)) => Ok(Some(IniEntry { key: k, value: v })),
[INFO] [stdout] 174 | |       (_, _) => Ok(None),
[INFO] [stdout] 175 | |     };
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 172 ~     match (self.parse_key()?, self.parse_value()?) {
[INFO] [stdout] 173 +       (Some(k), Some(v)) => Ok(Some(IniEntry { key: k, value: v })),
[INFO] [stdout] 174 +       (_, _) => Ok(None),
[INFO] [stdout] 175 ~     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parsing.rs:208:12
[INFO] [stdout]     |
[INFO] [stdout] 208 |         && !std::env::var("INI_PARSER_ALLOW_EMPTY_SECTIONS").is_ok()
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("INI_PARSER_ALLOW_EMPTY_SECTIONS").is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:231:3
[INFO] [stdout]     |
[INFO] [stdout] 231 | /   return Ok(IniFile {
[INFO] [stdout] 232 | |     filename: String::from("<missing>"),
[INFO] [stdout] 233 | |     sections: sections,
[INFO] [stdout] 234 | |   });
[INFO] [stdout]     | |____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 231 ~   Ok(IniFile {
[INFO] [stdout] 232 +     filename: String::from("<missing>"),
[INFO] [stdout] 233 +     sections: sections,
[INFO] [stdout] 234 ~   })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
[INFO] [stdout]    --> src/parsing.rs:188:27
[INFO] [stdout]     |
[INFO] [stdout] 188 | pub fn parse_ini(content: &mut String) -> Result<IniFile, String> {
[INFO] [stdout]     |                           ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 188 - pub fn parse_ini(content: &mut String) -> Result<IniFile, String> {
[INFO] [stdout] 188 + pub fn parse_ini(content: &mut str) -> Result<IniFile, String> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/parsing.rs:207:12
[INFO] [stdout]     |
[INFO] [stdout] 207 |         && active_section.entries.len() == 0
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `active_section.entries.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:244:3
[INFO] [stdout]     |
[INFO] [stdout] 244 |   return Ok(file);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 244 -   return Ok(file);
[INFO] [stdout] 244 +   Ok(file)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:73:25
[INFO] [stdout]    |
[INFO] [stdout] 73 |       for (_, entry) in &section.entries {
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 73 -       for (_, entry) in &section.entries {
[INFO] [stdout] 73 +       for entry in section.entries.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/parsing.rs:238:36
[INFO] [stdout]     |
[INFO] [stdout] 238 |   let content = fs::read_to_string(&filename);
[INFO] [stdout]     |                                    ^^^^^^^^^ help: change this to: `filename`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to want to iterate on a map's values
[INFO] [stdout]   --> src/inifile.rs:85:25
[INFO] [stdout]    |
[INFO] [stdout] 85 |     for (_, section) in &self.sections {
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map
[INFO] [stdout] help: use the corresponding method
[INFO] [stdout]    |
[INFO] [stdout] 85 -     for (_, section) in &self.sections {
[INFO] [stdout] 85 +     for section in self.sections.values() {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/inifile.rs:86:60
[INFO] [stdout]    |
[INFO] [stdout] 86 |       if section.is_default || (!include_empty_sections && section.entries.len() == 0) {
[INFO] [stdout]    |                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `section.entries.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/inifile.rs:90:32
[INFO] [stdout]    |
[INFO] [stdout] 90 |       write_entries(&mut file, &section);
[INFO] [stdout]    |                                ^^^^^^^^ help: change this to: `section`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:123:5
[INFO] [stdout]     |
[INFO] [stdout] 123 |     return self.is_default;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 123 -     return self.is_default;
[INFO] [stdout] 123 +     self.is_default
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:146:5
[INFO] [stdout]     |
[INFO] [stdout] 146 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 146 -     return None;
[INFO] [stdout] 146 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:155:5
[INFO] [stdout]     |
[INFO] [stdout] 155 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 155 -     return None;
[INFO] [stdout] 155 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:164:5
[INFO] [stdout]     |
[INFO] [stdout] 164 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 164 -     return None;
[INFO] [stdout] 164 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/inifile.rs:173:5
[INFO] [stdout]     |
[INFO] [stdout] 173 |     return None;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 173 -     return None;
[INFO] [stdout] 173 +     None
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:49:5
[INFO] [stdout]    |
[INFO] [stdout] 49 | /     return self.chars[self.mark_index..self.current_index]
[INFO] [stdout] 50 | |       .iter()
[INFO] [stdout] 51 | |       .collect();
[INFO] [stdout]    | |________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 49 ~     self.chars[self.mark_index..self.current_index]
[INFO] [stdout] 50 +       .iter()
[INFO] [stdout] 51 ~       .collect()
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:56:7
[INFO] [stdout]    |
[INFO] [stdout] 56 |       return CharResult::Eof;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 56 -       return CharResult::Eof;
[INFO] [stdout] 56 +       CharResult::Eof
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:58:7
[INFO] [stdout]    |
[INFO] [stdout] 58 |       return CharResult::Char(self.chars[self.current_index]);
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 58 -       return CharResult::Char(self.chars[self.current_index]);
[INFO] [stdout] 58 +       CharResult::Char(self.chars[self.current_index])
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:72:7
[INFO] [stdout]    |
[INFO] [stdout] 72 |       return CharResult::Char(c);
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -       return CharResult::Char(c);
[INFO] [stdout] 72 +       CharResult::Char(c)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:74:7
[INFO] [stdout]    |
[INFO] [stdout] 74 |       return CharResult::Eof;
[INFO] [stdout]    |       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 74 -       return CharResult::Eof;
[INFO] [stdout] 74 +       CharResult::Eof
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/parsing.rs:79:5
[INFO] [stdout]    |
[INFO] [stdout] 79 | /     return format!(
[INFO] [stdout] 80 | |       "Parse error: {} at line {}, column {} (char {})",
[INFO] [stdout] 81 | |       msg, self.line, self.col, self.pos
[INFO] [stdout] 82 | |     );
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 79 ~     format!(
[INFO] [stdout] 80 +       "Parse error: {} at line {}, column {} (char {})",
[INFO] [stdout] 81 +       msg, self.line, self.col, self.pos
[INFO] [stdout] 82 ~     )
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:119:5
[INFO] [stdout]     |
[INFO] [stdout] 119 |     return Ok(None);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 119 -     return Ok(None);
[INFO] [stdout] 119 +     Ok(None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:132:5
[INFO] [stdout]     |
[INFO] [stdout] 132 |     return Ok(None);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 132 -     return Ok(None);
[INFO] [stdout] 132 +     Ok(None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:166:5
[INFO] [stdout]     |
[INFO] [stdout] 166 | /     return Err(self.error(
[INFO] [stdout] 167 | |       "Empty section! Set environment var INI_PARSER_ALLOW_EMPTY_SECTIONS to true to allow",
[INFO] [stdout] 168 | |     ));
[INFO] [stdout]     | |______^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 166 ~     Err(self.error(
[INFO] [stdout] 167 +       "Empty section! Set environment var INI_PARSER_ALLOW_EMPTY_SECTIONS to true to allow",
[INFO] [stdout] 168 ~     ))
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:172:5
[INFO] [stdout]     |
[INFO] [stdout] 172 | /     return match (self.parse_key()?, self.parse_value()?) {
[INFO] [stdout] 173 | |       (Some(k), Some(v)) => Ok(Some(IniEntry { key: k, value: v })),
[INFO] [stdout] 174 | |       (_, _) => Ok(None),
[INFO] [stdout] 175 | |     };
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 172 ~     match (self.parse_key()?, self.parse_value()?) {
[INFO] [stdout] 173 +       (Some(k), Some(v)) => Ok(Some(IniEntry { key: k, value: v })),
[INFO] [stdout] 174 +       (_, _) => Ok(None),
[INFO] [stdout] 175 ~     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parsing.rs:208:12
[INFO] [stdout]     |
[INFO] [stdout] 208 |         && !std::env::var("INI_PARSER_ALLOW_EMPTY_SECTIONS").is_ok()
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("INI_PARSER_ALLOW_EMPTY_SECTIONS").is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:231:3
[INFO] [stdout]     |
[INFO] [stdout] 231 | /   return Ok(IniFile {
[INFO] [stdout] 232 | |     filename: String::from("<missing>"),
[INFO] [stdout] 233 | |     sections: sections,
[INFO] [stdout] 234 | |   });
[INFO] [stdout]     | |____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 231 ~   Ok(IniFile {
[INFO] [stdout] 232 +     filename: String::from("<missing>"),
[INFO] [stdout] 233 +     sections: sections,
[INFO] [stdout] 234 ~   })
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut String` instead of `&mut str` involves a new object where a slice will do
[INFO] [stdout]    --> src/parsing.rs:188:27
[INFO] [stdout]     |
[INFO] [stdout] 188 | pub fn parse_ini(content: &mut String) -> Result<IniFile, String> {
[INFO] [stdout]     |                           ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 188 - pub fn parse_ini(content: &mut String) -> Result<IniFile, String> {
[INFO] [stdout] 188 + pub fn parse_ini(content: &mut str) -> Result<IniFile, String> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/parsing.rs:207:12
[INFO] [stdout]     |
[INFO] [stdout] 207 |         && active_section.entries.len() == 0
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `active_section.entries.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parsing.rs:244:3
[INFO] [stdout]     |
[INFO] [stdout] 244 |   return Ok(file);
[INFO] [stdout]     |   ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 244 -   return Ok(file);
[INFO] [stdout] 244 +   Ok(file)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/parsing.rs:238:36
[INFO] [stdout]     |
[INFO] [stdout] 238 |   let content = fs::read_to_string(&filename);
[INFO] [stdout]     |                                    ^^^^^^^^^ help: change this to: `filename`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.26s
[INFO] running `Command { std: "docker" "inspect" "27593316f1687a0cbeb7c7caff776697b30265da86d3d98b0710a39489f2ecf5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "27593316f1687a0cbeb7c7caff776697b30265da86d3d98b0710a39489f2ecf5", kill_on_drop: false }`
[INFO] [stdout] 27593316f1687a0cbeb7c7caff776697b30265da86d3d98b0710a39489f2ecf5