[INFO] cloning repository https://github.com/elmarco/osinfo-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/elmarco/osinfo-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felmarco%2Fosinfo-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felmarco%2Fosinfo-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4f39f9524cf75b152109905c4cb443f23153750f [INFO] linting elmarco/osinfo-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felmarco%2Fosinfo-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/elmarco/osinfo-rs [INFO] finished tweaking git repo https://github.com/elmarco/osinfo-rs [INFO] tweaked toml for git repo https://github.com/elmarco/osinfo-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/elmarco/osinfo-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/elmarco/osinfo-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zmij v1.0.12 [INFO] [stderr] Downloaded vte_generate_state_changes v0.1.2 [INFO] [stderr] Downloaded ansitok v0.2.0 [INFO] [stderr] Downloaded ansi-str v0.8.0 [INFO] [stderr] Downloaded vte v0.10.1 [INFO] [stderr] Downloaded bounded-integer v0.6.1 [INFO] [stderr] Downloaded roxmltree v0.21.1 [INFO] [stderr] Downloaded zerocopy v0.8.32 [INFO] [stderr] Downloaded zerocopy-derive v0.8.32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c9fd92e0864b66f97734b6c7a24602569a69cf48ad26d2e7d596e9f6d3519166 [INFO] running `Command { std: "docker" "start" "-a" "c9fd92e0864b66f97734b6c7a24602569a69cf48ad26d2e7d596e9f6d3519166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c9fd92e0864b66f97734b6c7a24602569a69cf48ad26d2e7d596e9f6d3519166", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9fd92e0864b66f97734b6c7a24602569a69cf48ad26d2e7d596e9f6d3519166", kill_on_drop: false }` [INFO] [stdout] c9fd92e0864b66f97734b6c7a24602569a69cf48ad26d2e7d596e9f6d3519166 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce555fff1d25da9d394fe85dc51bc52951c49acbf6ac2a8f27c8865f092b0693 [INFO] running `Command { std: "docker" "start" "-a" "ce555fff1d25da9d394fe85dc51bc52951c49acbf6ac2a8f27c8865f092b0693", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling zerocopy v0.8.32 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking roxmltree v0.21.1 [INFO] [stderr] Checking quick-xml v0.38.4 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking bounded-integer v0.6.1 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking rayon-core v1.13.0 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking webpki-roots v1.0.5 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking vte v0.10.1 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking ureq-proto v0.5.3 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking ansitok v0.2.0 [INFO] [stderr] Checking ansi-str v0.8.0 [INFO] [stderr] Checking papergrid v0.13.0 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling zerocopy-derive v0.8.32 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling tabled_derive v0.9.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking tabled v0.17.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking osinfo_xml v0.1.0 (/opt/rustwide/workdir/osinfo-xml) [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/archnames.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / loop { [INFO] [stdout] 211 | | let Some(child) = from_child else { [INFO] [stdout] 212 | | break; [INFO] [stdout] 213 | | }; [INFO] [stdout] ... | [INFO] [stdout] 336 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/archnames.rs:215:49 [INFO] [stdout] | [INFO] [stdout] 215 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 216 | | _ => {} [INFO] [stdout] 217 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 215 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 216 + child.tag_name().name(); [INFO] [stdout] 217 + [INFO] [stdout] 218 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / loop { [INFO] [stdout] 51 | | let Some(child) = from_child else { [INFO] [stdout] 52 | | break; [INFO] [stdout] 53 | | }; [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:55:49 [INFO] [stdout] | [INFO] [stdout] 55 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 56 | | _ => {} [INFO] [stdout] 57 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 56 + child.tag_name().name(); [INFO] [stdout] 57 + [INFO] [stdout] 58 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | "all" => { [INFO] [stdout] 62 | | builder.all()?; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 59 | if let Some(val) = child.text() { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 60 | match val { [INFO] [stdout] 61 | "all" => { [INFO] [stdout] | ^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | "all" => { [INFO] [stdout] 62 | | builder.all()?; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if val == "all" { [INFO] [stdout] 61 + builder.all()?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.archnames` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 143 | if self.archnames.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.archnames` [INFO] [stdout] 144 | return Ok(Archnamesorall::Archnames(Clone::clone( [INFO] [stdout] 145 | &self.archnames.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | &self.archnames.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.archnames.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/alpha.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/alpha.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/avatar_format/alpha.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/height.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/avatar_format/height.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/height.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/mime_type.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/mime_type.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/avatar_format/mime_type.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/width.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/avatar_format/width.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/width.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 44 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.width; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 + }) && ({ [INFO] [stdout] 40 + let elem = &self.height; [INFO] [stdout] 41 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 + }) && ({ [INFO] [stdout] 43 + let elem = &self.alpha; [INFO] [stdout] 44 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 41 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.width; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 + }) && ({ [INFO] [stdout] 40 + let elem = &self.height; [INFO] [stdout] 41 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] 37 | | let elem = &self.width; [INFO] [stdout] 38 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.width; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | / match val { [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/bool.rs:22:67 [INFO] [stdout] | [INFO] [stdout] 22 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/bool.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / loop { [INFO] [stdout] 47 | | let Some(child) = from_child else { [INFO] [stdout] 48 | | break; [INFO] [stdout] 49 | | }; [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/bool.rs:51:49 [INFO] [stdout] | [INFO] [stdout] 51 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 51 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 52 + child.tag_name().name(); [INFO] [stdout] 53 + [INFO] [stdout] 54 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.value` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/bool.rs:162:49 [INFO] [stdout] | [INFO] [stdout] 161 | if self.value.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.value` [INFO] [stdout] 162 | return Ok(Bool::Value(Clone::clone(&self.value.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/bool.rs:162:48 [INFO] [stdout] | [INFO] [stdout] 162 | return Ok(Bool::Value(Clone::clone(&self.value.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.value.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/clones.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/clones.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/clones.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/codename.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/codename.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/codename.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/cpu.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/cpu.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/cpu.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:31:43 [INFO] [stdout] | [INFO] [stdout] 31 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match child.tag_name().name() { [INFO] [stdout] 55 | | _ => continue, [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 54 ~ child.tag_name().name(); [INFO] [stdout] 55 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | / match val { [INFO] [stdout] 60 | | _ => {} [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/datamap.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.entries; [INFO] [stdout] 32 | | elem.iter().all(|elem| false) [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.entries; [INFO] [stdout] 32 + elem.iter().all(|elem| false) [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/datamap.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/datamap.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / match val { [INFO] [stdout] 73 | | _ => {} [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/deployment/os.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/deployment/os.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/deployment/os.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/deployment/platform.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/deployment/platform.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/deployment/platform.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/deployment.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / true && ({ [INFO] [stdout] 38 | | let elem = &self.os; [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 45 | | false [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ ({ [INFO] [stdout] 38 + let elem = &self.os; [INFO] [stdout] 39 + false [INFO] [stdout] 40 + }) && ({ [INFO] [stdout] 41 + let elem = &self.platform; [INFO] [stdout] 42 + false [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.devices; [INFO] [stdout] 45 + false [INFO] [stdout] 46 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/deployment.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / true && ({ [INFO] [stdout] 38 | | let elem = &self.os; [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | }) && ({ [INFO] [stdout] 41 | | let elem = &self.platform; [INFO] [stdout] 42 | | false [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ ({ [INFO] [stdout] 38 + let elem = &self.os; [INFO] [stdout] 39 + false [INFO] [stdout] 40 + }) && ({ [INFO] [stdout] 41 + let elem = &self.platform; [INFO] [stdout] 42 + false [INFO] [stdout] 43 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/deployment.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / true && ({ [INFO] [stdout] 38 | | let elem = &self.os; [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ ({ [INFO] [stdout] 38 + let elem = &self.os; [INFO] [stdout] 39 + false [INFO] [stdout] 40 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/deployment.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/deployment.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match val { [INFO] [stdout] 98 | | _ => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/derives_from.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/derives_from.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/derives_from.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/device/bus_type/bus_type_choice.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / loop { [INFO] [stdout] 61 | | let Some(child) = from_child else { [INFO] [stdout] 62 | | break; [INFO] [stdout] 63 | | }; [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/bus_type/bus_type_choice.rs:65:49 [INFO] [stdout] | [INFO] [stdout] 65 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 66 | | _ => {} [INFO] [stdout] 67 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 65 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 66 + child.tag_name().name(); [INFO] [stdout] 67 + [INFO] [stdout] 68 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/bus_type.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.bus_type_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.bus_type_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/bus_type.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/bus_type.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/device/class/class_choice.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / loop { [INFO] [stdout] 96 | | let Some(child) = from_child else { [INFO] [stdout] 97 | | break; [INFO] [stdout] 98 | | }; [INFO] [stdout] ... | [INFO] [stdout] 152 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/class/class_choice.rs:100:49 [INFO] [stdout] | [INFO] [stdout] 100 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 101 | | _ => {} [INFO] [stdout] 102 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 100 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 101 + child.tag_name().name(); [INFO] [stdout] 102 + [INFO] [stdout] 103 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/class.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.class_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.class_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/class.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/class.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/name.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/device/name.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/name.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/name.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/product.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/product.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/product.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / loop { [INFO] [stdout] 45 | | let Some(child) = from_child else { [INFO] [stdout] 46 | | break; [INFO] [stdout] 47 | | }; [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:49:49 [INFO] [stdout] | [INFO] [stdout] 49 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 50 | | _ => {} [INFO] [stdout] 51 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 50 + child.tag_name().name(); [INFO] [stdout] 51 + [INFO] [stdout] 52 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:54:25 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => { [INFO] [stdout] 56 | | builder.value(val)?; [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 54 ~ { [INFO] [stdout] 55 + builder.value(val)?; [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / match s { [INFO] [stdout] 87 | | val => { [INFO] [stdout] 88 | | builder.value(val)?; [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 86 ~ let val = s; [INFO] [stdout] 87 + { [INFO] [stdout] 88 + builder.value(val)?; [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.value` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 110 | if self.value.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.value` [INFO] [stdout] 111 | return Ok(ProductIdChoice::Value(Clone::clone( [INFO] [stdout] 112 | &self.value.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | &self.value.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.value.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/product_id.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.product_id_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.product_id_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/product_id.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/product_id.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/subsystem.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/subsystem.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/subsystem.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/vendor_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/device/vendor_id.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/vendor_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 75 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 76 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) && ({ [INFO] [stdout] 68 + let elem = &self.vendors; [INFO] [stdout] 69 + elem.iter().all(|elem| false) [INFO] [stdout] 70 + }) && ({ [INFO] [stdout] 71 + let elem = &self.vendor_id; [INFO] [stdout] 72 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 73 + }) && ({ [INFO] [stdout] 74 + let elem = &self.product; [INFO] [stdout] 75 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 76 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 72 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 73 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) && ({ [INFO] [stdout] 68 + let elem = &self.vendors; [INFO] [stdout] 69 + elem.iter().all(|elem| false) [INFO] [stdout] 70 + }) && ({ [INFO] [stdout] 71 + let elem = &self.vendor_id; [INFO] [stdout] 72 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 73 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 69 | | elem.iter().all(|elem| false) [INFO] [stdout] 70 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) && ({ [INFO] [stdout] 68 + let elem = &self.vendors; [INFO] [stdout] 69 + elem.iter().all(|elem| false) [INFO] [stdout] 70 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 66 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] 62 | | let elem = &self.bus_type; [INFO] [stdout] 63 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/device.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | / match val { [INFO] [stdout] 185 | | _ => {} [INFO] [stdout] 186 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/devices/device/driver.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/devices/device/driver.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/devices/device/driver.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / true && ({ [INFO] [stdout] 43 | | let elem = &self.driver; [INFO] [stdout] 44 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ ({ [INFO] [stdout] 43 + let elem = &self.driver; [INFO] [stdout] 44 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:29:43 [INFO] [stdout] | [INFO] [stdout] 29 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | / match val { [INFO] [stdout] 88 | | _ => {} [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/devices.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / true && ({ [INFO] [stdout] 22 | | let elem = &self.devices; [INFO] [stdout] 23 | | elem.iter().all(|elem| false) [INFO] [stdout] 24 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ ({ [INFO] [stdout] 22 + let elem = &self.devices; [INFO] [stdout] 23 + elem.iter().all(|elem| false) [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/devices.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match val { [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/distro.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/distro.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/distro.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver/device.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/driver/device.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/driver/device.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/driver/file.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/driver/file.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/driver/file.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/driver.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | / true && ({ [INFO] [stdout] 80 | | let elem = &self.files; [INFO] [stdout] 81 | | elem.iter().all(|elem| false) [INFO] [stdout] 82 | | }) && ({ [INFO] [stdout] 83 | | let elem = &self.devices; [INFO] [stdout] 84 | | elem.iter().all(|elem| false) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ ({ [INFO] [stdout] 80 + let elem = &self.files; [INFO] [stdout] 81 + elem.iter().all(|elem| false) [INFO] [stdout] 82 + }) && ({ [INFO] [stdout] 83 + let elem = &self.devices; [INFO] [stdout] 84 + elem.iter().all(|elem| false) [INFO] [stdout] 85 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/driver.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | / true && ({ [INFO] [stdout] 80 | | let elem = &self.files; [INFO] [stdout] 81 | | elem.iter().all(|elem| false) [INFO] [stdout] 82 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ ({ [INFO] [stdout] 80 + let elem = &self.files; [INFO] [stdout] 81 + elem.iter().all(|elem| false) [INFO] [stdout] 82 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:41:43 [INFO] [stdout] | [INFO] [stdout] 41 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:48:43 [INFO] [stdout] | [INFO] [stdout] 48 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:56:47 [INFO] [stdout] | [INFO] [stdout] 56 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:65:47 [INFO] [stdout] | [INFO] [stdout] 65 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:74:47 [INFO] [stdout] | [INFO] [stdout] 74 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/driver.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | / match val { [INFO] [stdout] 146 | | _ => {} [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/eol_date.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/eol_date.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/eol_date.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/family.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/family.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/family.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/firmware.rs:29:43 [INFO] [stdout] | [INFO] [stdout] 29 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/firmware.rs:36:43 [INFO] [stdout] | [INFO] [stdout] 36 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/firmware.rs:44:47 [INFO] [stdout] | [INFO] [stdout] 44 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/firmware.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | / match child.tag_name().name() { [INFO] [stdout] 72 | | _ => continue, [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 71 ~ child.tag_name().name(); [INFO] [stdout] 72 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/firmware.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / match val { [INFO] [stdout] 77 | | _ => {} [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/firmware_types.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / loop { [INFO] [stdout] 46 | | let Some(child) = from_child else { [INFO] [stdout] 47 | | break; [INFO] [stdout] 48 | | }; [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/firmware_types.rs:50:49 [INFO] [stdout] | [INFO] [stdout] 50 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 51 | | _ => {} [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 50 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 51 + child.tag_name().name(); [INFO] [stdout] 52 + [INFO] [stdout] 53 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/image/url.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/image/url.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/image/url.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image/variant.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/image/variant.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / match child.tag_name().name() { [INFO] [stdout] 43 | | _ => continue, [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 42 ~ child.tag_name().name(); [INFO] [stdout] 43 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/image/variant.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match val { [INFO] [stdout] 48 | | _ => {} [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/image.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / true && ({ [INFO] [stdout] 58 | | let elem = &self.variant; [INFO] [stdout] 59 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 | | }) && ({ [INFO] [stdout] 61 | | let elem = &self.url; [INFO] [stdout] 62 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 63 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ ({ [INFO] [stdout] 58 + let elem = &self.variant; [INFO] [stdout] 59 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 + }) && ({ [INFO] [stdout] 61 + let elem = &self.url; [INFO] [stdout] 62 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 63 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/image.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / true && ({ [INFO] [stdout] 58 | | let elem = &self.variant; [INFO] [stdout] 59 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ ({ [INFO] [stdout] 58 + let elem = &self.variant; [INFO] [stdout] 59 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image.rs:44:43 [INFO] [stdout] | [INFO] [stdout] 44 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image.rs:52:47 [INFO] [stdout] | [INFO] [stdout] 52 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/image.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | / match val { [INFO] [stdout] 111 | | _ => {} [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/imageformats.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / loop { [INFO] [stdout] 61 | | let Some(child) = from_child else { [INFO] [stdout] 62 | | break; [INFO] [stdout] 63 | | }; [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/imageformats.rs:65:49 [INFO] [stdout] | [INFO] [stdout] 65 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 66 | | _ => {} [INFO] [stdout] 67 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 65 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 66 + child.tag_name().name(); [INFO] [stdout] 67 + [INFO] [stdout] 68 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/injection_method.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/injection_method.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/injection_method.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/can_post_install_drivers.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/can_post_install_drivers.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/can_post_install_drivers.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/can_pre_install_drivers.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/can_pre_install_drivers.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/can_pre_install_drivers.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:41:47 [INFO] [stdout] | [INFO] [stdout] 41 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | / match child.tag_name().name() { [INFO] [stdout] 76 | | _ => continue, [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 75 ~ child.tag_name().name(); [INFO] [stdout] 76 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | / match val { [INFO] [stdout] 81 | | _ => {} [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/config.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / true && ({ [INFO] [stdout] 22 | | let elem = &self.params; [INFO] [stdout] 23 | | elem.iter().all(|elem| false) [INFO] [stdout] 24 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ ({ [INFO] [stdout] 22 + let elem = &self.params; [INFO] [stdout] 23 + elem.iter().all(|elem| false) [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/config.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match val { [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/expected_filename.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/expected_filename.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/expected_filename.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/needs_internet.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/needs_internet.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/needs_internet.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/path_format.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/install_script/path_format.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/path_format.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/post_install_drivers_signing_req.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/install_script/post_install_drivers_signing_req.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/post_install_drivers_signing_req.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | / match child.tag_name().name() { [INFO] [stdout] 44 | | _ => continue, [INFO] [stdout] 45 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 43 ~ child.tag_name().name(); [INFO] [stdout] 44 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/pre_install_drivers_signing_req.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/install_script/pre_install_drivers_signing_req.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/pre_install_drivers_signing_req.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/product_key_format.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/product_key_format.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/product_key_format.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/profile.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/profile.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/profile.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / loop { [INFO] [stdout] 53 | | let Some(child) = from_child else { [INFO] [stdout] 54 | | break; [INFO] [stdout] 55 | | }; [INFO] [stdout] ... | [INFO] [stdout] 72 | | *from_child = child.next_sibling(); [INFO] [stdout] 73 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:59:73 [INFO] [stdout] | [INFO] [stdout] 59 | builder.any_element(crate::AnyElement::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | / match val { [INFO] [stdout] 66 | | _ => {} [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________________________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:87:51 [INFO] [stdout] | [INFO] [stdout] 87 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.uri` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:130:35 [INFO] [stdout] | [INFO] [stdout] 128 | if self.uri.is_some() && self.empty.is_some() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 129 | return Ok(TemplateChoice::Variant0 { [INFO] [stdout] 130 | uri: Clone::clone(self.uri.as_ref().unwrap()).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.any_element` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:135:18 [INFO] [stdout] | [INFO] [stdout] 133 | if self.any_element.is_some() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = &self.any_element` [INFO] [stdout] 134 | return Ok(TemplateChoice::AnyElement(Clone::clone( [INFO] [stdout] 135 | &self.any_element.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:130:22 [INFO] [stdout] | [INFO] [stdout] 130 | uri: Clone::clone(self.uri.as_ref().unwrap()).into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Clone::clone(self.uri.as_ref().unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/install_script/template/template_choice.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 135 | &self.any_element.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.any_element.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/template.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.template_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.template_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/template.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/template.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / true && ({ [INFO] [stdout] 86 | | let elem = &self.profile; [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 102 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ ({ [INFO] [stdout] 86 + let elem = &self.profile; [INFO] [stdout] 87 + false [INFO] [stdout] 88 + }) && ({ [INFO] [stdout] 89 + let elem = &self.path_format; [INFO] [stdout] 90 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 91 + }) && ({ [INFO] [stdout] 92 + let elem = &self.expected_filename; [INFO] [stdout] 93 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 94 + }) && ({ [INFO] [stdout] 95 + let elem = &self.avatar_format; [INFO] [stdout] 96 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 97 + }) && ({ [INFO] [stdout] 98 + let elem = &self.config; [INFO] [stdout] 99 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 100 + }) && ({ [INFO] [stdout] 101 + let elem = &self.product_key_format; [INFO] [stdout] 102 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 103 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / true && ({ [INFO] [stdout] 86 | | let elem = &self.profile; [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 99 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 100 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ ({ [INFO] [stdout] 86 + let elem = &self.profile; [INFO] [stdout] 87 + false [INFO] [stdout] 88 + }) && ({ [INFO] [stdout] 89 + let elem = &self.path_format; [INFO] [stdout] 90 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 91 + }) && ({ [INFO] [stdout] 92 + let elem = &self.expected_filename; [INFO] [stdout] 93 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 94 + }) && ({ [INFO] [stdout] 95 + let elem = &self.avatar_format; [INFO] [stdout] 96 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 97 + }) && ({ [INFO] [stdout] 98 + let elem = &self.config; [INFO] [stdout] 99 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 100 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / true && ({ [INFO] [stdout] 86 | | let elem = &self.profile; [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 96 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 97 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ ({ [INFO] [stdout] 86 + let elem = &self.profile; [INFO] [stdout] 87 + false [INFO] [stdout] 88 + }) && ({ [INFO] [stdout] 89 + let elem = &self.path_format; [INFO] [stdout] 90 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 91 + }) && ({ [INFO] [stdout] 92 + let elem = &self.expected_filename; [INFO] [stdout] 93 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 94 + }) && ({ [INFO] [stdout] 95 + let elem = &self.avatar_format; [INFO] [stdout] 96 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 97 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / true && ({ [INFO] [stdout] 86 | | let elem = &self.profile; [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 93 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 94 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ ({ [INFO] [stdout] 86 + let elem = &self.profile; [INFO] [stdout] 87 + false [INFO] [stdout] 88 + }) && ({ [INFO] [stdout] 89 + let elem = &self.path_format; [INFO] [stdout] 90 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 91 + }) && ({ [INFO] [stdout] 92 + let elem = &self.expected_filename; [INFO] [stdout] 93 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 94 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / true && ({ [INFO] [stdout] 86 | | let elem = &self.profile; [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | }) && ({ [INFO] [stdout] 89 | | let elem = &self.path_format; [INFO] [stdout] 90 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 91 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ ({ [INFO] [stdout] 86 + let elem = &self.profile; [INFO] [stdout] 87 + false [INFO] [stdout] 88 + }) && ({ [INFO] [stdout] 89 + let elem = &self.path_format; [INFO] [stdout] 90 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 91 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / true && ({ [INFO] [stdout] 86 | | let elem = &self.profile; [INFO] [stdout] 87 | | false [INFO] [stdout] 88 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 85 ~ ({ [INFO] [stdout] 86 + let elem = &self.profile; [INFO] [stdout] 87 + false [INFO] [stdout] 88 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script.rs:81:43 [INFO] [stdout] | [INFO] [stdout] 81 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 313 | / match val { [INFO] [stdout] 314 | | _ => {} [INFO] [stdout] 315 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/installer/script.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/installer/script.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/installer/script.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/installer.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / true && ({ [INFO] [stdout] 22 | | let elem = &self.scripts; [INFO] [stdout] 23 | | elem.iter().all(|elem| false) [INFO] [stdout] 24 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ ({ [INFO] [stdout] 22 + let elem = &self.scripts; [INFO] [stdout] 23 + elem.iter().all(|elem| false) [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/installer.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match val { [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso/application_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/iso/application_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/iso/application_id.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso/publisher_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/iso/publisher_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/iso/publisher_id.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso/system_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/iso/system_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/iso/system_id.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso/volume_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/iso/volume_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/iso/volume_id.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso/volume_size.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/iso/volume_size.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/iso/volume_size.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / true && ({ [INFO] [stdout] 41 | | let elem = &self.volume_id; [INFO] [stdout] 42 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 57 | | elem.iter().all(|elem| false) [INFO] [stdout] 58 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ ({ [INFO] [stdout] 41 + let elem = &self.volume_id; [INFO] [stdout] 42 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.publisher_id; [INFO] [stdout] 45 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 46 + }) && ({ [INFO] [stdout] 47 + let elem = &self.application_id; [INFO] [stdout] 48 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 49 + }) && ({ [INFO] [stdout] 50 + let elem = &self.system_id; [INFO] [stdout] 51 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 52 + }) && ({ [INFO] [stdout] 53 + let elem = &self.volume_size; [INFO] [stdout] 54 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 55 + }) && ({ [INFO] [stdout] 56 + let elem = &self.l10n_languages; [INFO] [stdout] 57 + elem.iter().all(|elem| false) [INFO] [stdout] 58 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / true && ({ [INFO] [stdout] 41 | | let elem = &self.volume_id; [INFO] [stdout] 42 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 54 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 55 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ ({ [INFO] [stdout] 41 + let elem = &self.volume_id; [INFO] [stdout] 42 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.publisher_id; [INFO] [stdout] 45 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 46 + }) && ({ [INFO] [stdout] 47 + let elem = &self.application_id; [INFO] [stdout] 48 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 49 + }) && ({ [INFO] [stdout] 50 + let elem = &self.system_id; [INFO] [stdout] 51 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 52 + }) && ({ [INFO] [stdout] 53 + let elem = &self.volume_size; [INFO] [stdout] 54 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 55 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / true && ({ [INFO] [stdout] 41 | | let elem = &self.volume_id; [INFO] [stdout] 42 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 51 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 52 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ ({ [INFO] [stdout] 41 + let elem = &self.volume_id; [INFO] [stdout] 42 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.publisher_id; [INFO] [stdout] 45 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 46 + }) && ({ [INFO] [stdout] 47 + let elem = &self.application_id; [INFO] [stdout] 48 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 49 + }) && ({ [INFO] [stdout] 50 + let elem = &self.system_id; [INFO] [stdout] 51 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 52 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / true && ({ [INFO] [stdout] 41 | | let elem = &self.volume_id; [INFO] [stdout] 42 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 48 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 49 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ ({ [INFO] [stdout] 41 + let elem = &self.volume_id; [INFO] [stdout] 42 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.publisher_id; [INFO] [stdout] 45 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 46 + }) && ({ [INFO] [stdout] 47 + let elem = &self.application_id; [INFO] [stdout] 48 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 49 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / true && ({ [INFO] [stdout] 41 | | let elem = &self.volume_id; [INFO] [stdout] 42 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] 44 | | let elem = &self.publisher_id; [INFO] [stdout] 45 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 46 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ ({ [INFO] [stdout] 41 + let elem = &self.volume_id; [INFO] [stdout] 42 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.publisher_id; [INFO] [stdout] 45 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 46 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/iso.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | / true && ({ [INFO] [stdout] 41 | | let elem = &self.volume_id; [INFO] [stdout] 42 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 40 ~ ({ [INFO] [stdout] 41 + let elem = &self.volume_id; [INFO] [stdout] 42 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 43 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/iso.rs:132:13 [INFO] [stdout] | [INFO] [stdout] 132 | / match val { [INFO] [stdout] 133 | | _ => {} [INFO] [stdout] 134 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/l10n_language.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | / true && ({ [INFO] [stdout] 44 | | let elem = &self.value; [INFO] [stdout] 45 | | false [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 43 ~ ({ [INFO] [stdout] 44 + let elem = &self.value; [INFO] [stdout] 45 + false [INFO] [stdout] 46 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/l10n_language.rs:29:47 [INFO] [stdout] | [INFO] [stdout] 29 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/l10n_language.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/l10n_language.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | / match child.tag_name().name() { [INFO] [stdout] 79 | | _ => continue, [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 78 ~ child.tag_name().name(); [INFO] [stdout] 79 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/l10n_language.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | / match val { [INFO] [stdout] 84 | | _ => { [INFO] [stdout] 85 | | builder.value(val)?; [INFO] [stdout] 86 | | } [INFO] [stdout] 87 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 83 ~ { [INFO] [stdout] 84 + builder.value(val)?; [INFO] [stdout] 85 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / loop { [INFO] [stdout] 96 | | let Some(child) = from_child else { [INFO] [stdout] 97 | | break; [INFO] [stdout] 98 | | }; [INFO] [stdout] ... | [INFO] [stdout] 134 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:101:52 [INFO] [stdout] | [INFO] [stdout] 101 | "datamap" if Datamap::from_xml(&child).is_ok() => { [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:102:59 [INFO] [stdout] | [INFO] [stdout] 102 | builder.datamap(Datamap::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:104:58 [INFO] [stdout] | [INFO] [stdout] 104 | "deployment" if Deployment::from_xml(&child).is_ok() => { [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:105:65 [INFO] [stdout] | [INFO] [stdout] 105 | builder.deployment(Deployment::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:107:50 [INFO] [stdout] | [INFO] [stdout] 107 | "device" if Device::from_xml(&child).is_ok() => { [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:108:57 [INFO] [stdout] | [INFO] [stdout] 108 | builder.device(Device::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:110:65 [INFO] [stdout] | [INFO] [stdout] 110 | "install-script" if InstallScript::from_xml(&child).is_ok() => { [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:111:72 [INFO] [stdout] | [INFO] [stdout] 111 | builder.install_script(InstallScript::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:113:42 [INFO] [stdout] | [INFO] [stdout] 113 | "os" if Os::from_xml(&child).is_ok() => { [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:114:49 [INFO] [stdout] | [INFO] [stdout] 114 | builder.os(Os::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:116:54 [INFO] [stdout] | [INFO] [stdout] 116 | "platform" if Platform::from_xml(&child).is_ok() => { [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:117:61 [INFO] [stdout] | [INFO] [stdout] 117 | builder.platform(Platform::from_xml(&child)?)?; [INFO] [stdout] | ^^^^^^ help: change this to: `child` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:123:25 [INFO] [stdout] | [INFO] [stdout] 123 | / match val { [INFO] [stdout] 124 | | _ => {} [INFO] [stdout] 125 | | } [INFO] [stdout] | |_________________________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.datamap` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:237:18 [INFO] [stdout] | [INFO] [stdout] 235 | if self.datamap.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = &self.datamap` [INFO] [stdout] 236 | return Ok(Entry::Datamap(Clone::clone( [INFO] [stdout] 237 | &self.datamap.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.device` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:241:51 [INFO] [stdout] | [INFO] [stdout] 240 | if self.device.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &self.device` [INFO] [stdout] 241 | return Ok(Entry::Device(Clone::clone(&self.device.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.os` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:244:47 [INFO] [stdout] | [INFO] [stdout] 243 | if self.os.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = &self.os` [INFO] [stdout] 244 | return Ok(Entry::Os(Clone::clone(&self.os.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.platform` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:248:18 [INFO] [stdout] | [INFO] [stdout] 246 | if self.platform.is_some() { [INFO] [stdout] | -------------------------- help: try: `if let Some() = &self.platform` [INFO] [stdout] 247 | return Ok(Entry::Platform(Clone::clone( [INFO] [stdout] 248 | &self.platform.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.deployment` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:253:18 [INFO] [stdout] | [INFO] [stdout] 251 | if self.deployment.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = &self.deployment` [INFO] [stdout] 252 | return Ok(Entry::Deployment(Clone::clone( [INFO] [stdout] 253 | &self.deployment.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.install_script` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:258:18 [INFO] [stdout] | [INFO] [stdout] 256 | if self.install_script.is_some() { [INFO] [stdout] | -------------------------------- help: try: `if let Some() = &self.install_script` [INFO] [stdout] 257 | return Ok(Entry::InstallScript(Clone::clone( [INFO] [stdout] 258 | &self.install_script.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:237:17 [INFO] [stdout] | [INFO] [stdout] 237 | &self.datamap.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.datamap.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:241:50 [INFO] [stdout] | [INFO] [stdout] 241 | return Ok(Entry::Device(Clone::clone(&self.device.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.device.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:244:46 [INFO] [stdout] | [INFO] [stdout] 244 | return Ok(Entry::Os(Clone::clone(&self.os.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.os.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:248:17 [INFO] [stdout] | [INFO] [stdout] 248 | &self.platform.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.platform.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | &self.deployment.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.deployment.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/libosinfo/entry.rs:258:17 [INFO] [stdout] | [INFO] [stdout] 258 | &self.install_script.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.install_script.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/libosinfo.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | / true && ({ [INFO] [stdout] 32 | | let elem = &self.entries; [INFO] [stdout] 33 | | elem.iter().all(|elem| elem.is_empty()) [INFO] [stdout] 34 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ ({ [INFO] [stdout] 32 + let elem = &self.entries; [INFO] [stdout] 33 + elem.iter().all(|elem| elem.is_empty()) [INFO] [stdout] 34 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/libosinfo.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / match child.tag_name().name() { [INFO] [stdout] 59 | | _ => continue, [INFO] [stdout] 60 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 58 ~ child.tag_name().name(); [INFO] [stdout] 59 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/libosinfo.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | / match val { [INFO] [stdout] 64 | | _ => {} [INFO] [stdout] 65 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/libosinfo.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | / loop { [INFO] [stdout] 69 | | if let Ok(elem) = Entry::from_xml(node, child) { [INFO] [stdout] 70 | | builder.entry(elem)?; [INFO] [stdout] 71 | | } else { [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ help: try: `while let Ok(elem) = Entry::from_xml(node, child) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> osinfo-xml/src/libosinfo.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / let version = Clone::clone( [INFO] [stdout] 118 | | self.version [INFO] [stdout] 119 | | .as_ref() [INFO] [stdout] 120 | | .ok_or(Error::BuilderMissingField("libosinfo", "version"))?, [INFO] [stdout] 121 | | ); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 117 - let version = Clone::clone( [INFO] [stdout] 117 + Clone::clone( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media/initrd.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/media/initrd.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/media/initrd.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media/kernel.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/media/kernel.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/media/kernel.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media/url.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/media/url.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/media/url.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media/variant.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/media/variant.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / match child.tag_name().name() { [INFO] [stdout] 43 | | _ => continue, [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 42 ~ child.tag_name().name(); [INFO] [stdout] 43 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/media/variant.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match val { [INFO] [stdout] 48 | | _ => {} [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | / true && ({ [INFO] [stdout] 107 | | let elem = &self.variant; [INFO] [stdout] 108 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 123 | | elem.iter().all(|elem| false) [INFO] [stdout] 124 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ ({ [INFO] [stdout] 107 + let elem = &self.variant; [INFO] [stdout] 108 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.url; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 + }) && ({ [INFO] [stdout] 113 + let elem = &self.iso; [INFO] [stdout] 114 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 + }) && ({ [INFO] [stdout] 116 + let elem = &self.initrd; [INFO] [stdout] 117 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 118 + }) && ({ [INFO] [stdout] 119 + let elem = &self.kernel; [INFO] [stdout] 120 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 121 + }) && ({ [INFO] [stdout] 122 + let elem = &self.installers; [INFO] [stdout] 123 + elem.iter().all(|elem| false) [INFO] [stdout] 124 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | / true && ({ [INFO] [stdout] 107 | | let elem = &self.variant; [INFO] [stdout] 108 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 120 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 121 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ ({ [INFO] [stdout] 107 + let elem = &self.variant; [INFO] [stdout] 108 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.url; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 + }) && ({ [INFO] [stdout] 113 + let elem = &self.iso; [INFO] [stdout] 114 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 + }) && ({ [INFO] [stdout] 116 + let elem = &self.initrd; [INFO] [stdout] 117 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 118 + }) && ({ [INFO] [stdout] 119 + let elem = &self.kernel; [INFO] [stdout] 120 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 121 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | / true && ({ [INFO] [stdout] 107 | | let elem = &self.variant; [INFO] [stdout] 108 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 117 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 118 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ ({ [INFO] [stdout] 107 + let elem = &self.variant; [INFO] [stdout] 108 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.url; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 + }) && ({ [INFO] [stdout] 113 + let elem = &self.iso; [INFO] [stdout] 114 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 + }) && ({ [INFO] [stdout] 116 + let elem = &self.initrd; [INFO] [stdout] 117 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 118 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | / true && ({ [INFO] [stdout] 107 | | let elem = &self.variant; [INFO] [stdout] 108 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 114 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ ({ [INFO] [stdout] 107 + let elem = &self.variant; [INFO] [stdout] 108 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.url; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 + }) && ({ [INFO] [stdout] 113 + let elem = &self.iso; [INFO] [stdout] 114 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | / true && ({ [INFO] [stdout] 107 | | let elem = &self.variant; [INFO] [stdout] 108 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] 110 | | let elem = &self.url; [INFO] [stdout] 111 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ ({ [INFO] [stdout] 107 + let elem = &self.variant; [INFO] [stdout] 108 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.url; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/media.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | / true && ({ [INFO] [stdout] 107 | | let elem = &self.variant; [INFO] [stdout] 108 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 ~ ({ [INFO] [stdout] 107 + let elem = &self.variant; [INFO] [stdout] 108 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 109 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media.rs:57:43 [INFO] [stdout] | [INFO] [stdout] 57 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media.rs:65:47 [INFO] [stdout] | [INFO] [stdout] 65 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media.rs:74:47 [INFO] [stdout] | [INFO] [stdout] 74 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media.rs:83:47 [INFO] [stdout] | [INFO] [stdout] 83 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media.rs:92:47 [INFO] [stdout] | [INFO] [stdout] 92 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/media.rs:101:47 [INFO] [stdout] | [INFO] [stdout] 101 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/media.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | / match val { [INFO] [stdout] 224 | | _ => {} [INFO] [stdout] 225 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/n_cpus.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/n_cpus.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/n_cpus.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/name.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/name.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/name.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/name.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os/cloud_image_username.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/os/cloud_image_username.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/os/cloud_image_username.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os/kernel_url_argument.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/os/kernel_url_argument.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/os/kernel_url_argument.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / true && ({ [INFO] [stdout] 101 | | let elem = &self.vendors; [INFO] [stdout] 102 | | elem.iter().all(|elem| false) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 117 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 118 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ ({ [INFO] [stdout] 101 + let elem = &self.vendors; [INFO] [stdout] 102 + elem.iter().all(|elem| false) [INFO] [stdout] 103 + }) && ({ [INFO] [stdout] 104 + let elem = &self.names; [INFO] [stdout] 105 + elem.iter().all(|elem| false) [INFO] [stdout] 106 + }) && ({ [INFO] [stdout] 107 + let elem = &self.short_ids; [INFO] [stdout] 108 + elem.iter().all(|elem| false) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.version; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 + }) && ({ [INFO] [stdout] 113 + let elem = &self.codename; [INFO] [stdout] 114 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 + }) && ({ [INFO] [stdout] 116 + let elem = &self.family; [INFO] [stdout] 117 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 118 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / true && ({ [INFO] [stdout] 101 | | let elem = &self.vendors; [INFO] [stdout] 102 | | elem.iter().all(|elem| false) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 114 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ ({ [INFO] [stdout] 101 + let elem = &self.vendors; [INFO] [stdout] 102 + elem.iter().all(|elem| false) [INFO] [stdout] 103 + }) && ({ [INFO] [stdout] 104 + let elem = &self.names; [INFO] [stdout] 105 + elem.iter().all(|elem| false) [INFO] [stdout] 106 + }) && ({ [INFO] [stdout] 107 + let elem = &self.short_ids; [INFO] [stdout] 108 + elem.iter().all(|elem| false) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.version; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 + }) && ({ [INFO] [stdout] 113 + let elem = &self.codename; [INFO] [stdout] 114 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 115 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / true && ({ [INFO] [stdout] 101 | | let elem = &self.vendors; [INFO] [stdout] 102 | | elem.iter().all(|elem| false) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 111 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ ({ [INFO] [stdout] 101 + let elem = &self.vendors; [INFO] [stdout] 102 + elem.iter().all(|elem| false) [INFO] [stdout] 103 + }) && ({ [INFO] [stdout] 104 + let elem = &self.names; [INFO] [stdout] 105 + elem.iter().all(|elem| false) [INFO] [stdout] 106 + }) && ({ [INFO] [stdout] 107 + let elem = &self.short_ids; [INFO] [stdout] 108 + elem.iter().all(|elem| false) [INFO] [stdout] 109 + }) && ({ [INFO] [stdout] 110 + let elem = &self.version; [INFO] [stdout] 111 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 112 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / true && ({ [INFO] [stdout] 101 | | let elem = &self.vendors; [INFO] [stdout] 102 | | elem.iter().all(|elem| false) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 108 | | elem.iter().all(|elem| false) [INFO] [stdout] 109 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ ({ [INFO] [stdout] 101 + let elem = &self.vendors; [INFO] [stdout] 102 + elem.iter().all(|elem| false) [INFO] [stdout] 103 + }) && ({ [INFO] [stdout] 104 + let elem = &self.names; [INFO] [stdout] 105 + elem.iter().all(|elem| false) [INFO] [stdout] 106 + }) && ({ [INFO] [stdout] 107 + let elem = &self.short_ids; [INFO] [stdout] 108 + elem.iter().all(|elem| false) [INFO] [stdout] 109 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / true && ({ [INFO] [stdout] 101 | | let elem = &self.vendors; [INFO] [stdout] 102 | | elem.iter().all(|elem| false) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] 104 | | let elem = &self.names; [INFO] [stdout] 105 | | elem.iter().all(|elem| false) [INFO] [stdout] 106 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ ({ [INFO] [stdout] 101 + let elem = &self.vendors; [INFO] [stdout] 102 + elem.iter().all(|elem| false) [INFO] [stdout] 103 + }) && ({ [INFO] [stdout] 104 + let elem = &self.names; [INFO] [stdout] 105 + elem.iter().all(|elem| false) [INFO] [stdout] 106 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/os.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 100 | / true && ({ [INFO] [stdout] 101 | | let elem = &self.vendors; [INFO] [stdout] 102 | | elem.iter().all(|elem| false) [INFO] [stdout] 103 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 100 ~ ({ [INFO] [stdout] 101 + let elem = &self.vendors; [INFO] [stdout] 102 + elem.iter().all(|elem| false) [INFO] [stdout] 103 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/os.rs:96:43 [INFO] [stdout] | [INFO] [stdout] 96 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/os.rs:418:13 [INFO] [stdout] | [INFO] [stdout] 418 | / match val { [INFO] [stdout] 419 | | _ => {} [INFO] [stdout] 420 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/platform.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / true && ({ [INFO] [stdout] 66 | | let elem = &self.vendors; [INFO] [stdout] 67 | | elem.iter().all(|elem| false) [INFO] [stdout] 68 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 82 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 83 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ ({ [INFO] [stdout] 66 + let elem = &self.vendors; [INFO] [stdout] 67 + elem.iter().all(|elem| false) [INFO] [stdout] 68 + }) && ({ [INFO] [stdout] 69 + let elem = &self.names; [INFO] [stdout] 70 + elem.iter().all(|elem| false) [INFO] [stdout] 71 + }) && ({ [INFO] [stdout] 72 + let elem = &self.short_ids; [INFO] [stdout] 73 + elem.iter().all(|elem| false) [INFO] [stdout] 74 + }) && ({ [INFO] [stdout] 75 + let elem = &self.version; [INFO] [stdout] 76 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 77 + }) && ({ [INFO] [stdout] 78 + let elem = &self.codename; [INFO] [stdout] 79 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 80 + }) && ({ [INFO] [stdout] 81 + let elem = &self.family; [INFO] [stdout] 82 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 83 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/platform.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / true && ({ [INFO] [stdout] 66 | | let elem = &self.vendors; [INFO] [stdout] 67 | | elem.iter().all(|elem| false) [INFO] [stdout] 68 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 79 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 80 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ ({ [INFO] [stdout] 66 + let elem = &self.vendors; [INFO] [stdout] 67 + elem.iter().all(|elem| false) [INFO] [stdout] 68 + }) && ({ [INFO] [stdout] 69 + let elem = &self.names; [INFO] [stdout] 70 + elem.iter().all(|elem| false) [INFO] [stdout] 71 + }) && ({ [INFO] [stdout] 72 + let elem = &self.short_ids; [INFO] [stdout] 73 + elem.iter().all(|elem| false) [INFO] [stdout] 74 + }) && ({ [INFO] [stdout] 75 + let elem = &self.version; [INFO] [stdout] 76 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 77 + }) && ({ [INFO] [stdout] 78 + let elem = &self.codename; [INFO] [stdout] 79 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 80 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/platform.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / true && ({ [INFO] [stdout] 66 | | let elem = &self.vendors; [INFO] [stdout] 67 | | elem.iter().all(|elem| false) [INFO] [stdout] 68 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 76 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 77 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ ({ [INFO] [stdout] 66 + let elem = &self.vendors; [INFO] [stdout] 67 + elem.iter().all(|elem| false) [INFO] [stdout] 68 + }) && ({ [INFO] [stdout] 69 + let elem = &self.names; [INFO] [stdout] 70 + elem.iter().all(|elem| false) [INFO] [stdout] 71 + }) && ({ [INFO] [stdout] 72 + let elem = &self.short_ids; [INFO] [stdout] 73 + elem.iter().all(|elem| false) [INFO] [stdout] 74 + }) && ({ [INFO] [stdout] 75 + let elem = &self.version; [INFO] [stdout] 76 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 77 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/platform.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / true && ({ [INFO] [stdout] 66 | | let elem = &self.vendors; [INFO] [stdout] 67 | | elem.iter().all(|elem| false) [INFO] [stdout] 68 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 73 | | elem.iter().all(|elem| false) [INFO] [stdout] 74 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ ({ [INFO] [stdout] 66 + let elem = &self.vendors; [INFO] [stdout] 67 + elem.iter().all(|elem| false) [INFO] [stdout] 68 + }) && ({ [INFO] [stdout] 69 + let elem = &self.names; [INFO] [stdout] 70 + elem.iter().all(|elem| false) [INFO] [stdout] 71 + }) && ({ [INFO] [stdout] 72 + let elem = &self.short_ids; [INFO] [stdout] 73 + elem.iter().all(|elem| false) [INFO] [stdout] 74 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/platform.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / true && ({ [INFO] [stdout] 66 | | let elem = &self.vendors; [INFO] [stdout] 67 | | elem.iter().all(|elem| false) [INFO] [stdout] 68 | | }) && ({ [INFO] [stdout] 69 | | let elem = &self.names; [INFO] [stdout] 70 | | elem.iter().all(|elem| false) [INFO] [stdout] 71 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ ({ [INFO] [stdout] 66 + let elem = &self.vendors; [INFO] [stdout] 67 + elem.iter().all(|elem| false) [INFO] [stdout] 68 + }) && ({ [INFO] [stdout] 69 + let elem = &self.names; [INFO] [stdout] 70 + elem.iter().all(|elem| false) [INFO] [stdout] 71 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/platform.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / true && ({ [INFO] [stdout] 66 | | let elem = &self.vendors; [INFO] [stdout] 67 | | elem.iter().all(|elem| false) [INFO] [stdout] 68 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 65 ~ ({ [INFO] [stdout] 66 + let elem = &self.vendors; [INFO] [stdout] 67 + elem.iter().all(|elem| false) [INFO] [stdout] 68 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/platform.rs:61:43 [INFO] [stdout] | [INFO] [stdout] 61 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/platform.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | / match val { [INFO] [stdout] 252 | | _ => {} [INFO] [stdout] 253 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/ram.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/ram.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/ram.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/release_date.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/release_date.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/release_date.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/release_status.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/release_status.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/release_status.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/maximum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 40 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 + }) && ({ [INFO] [stdout] 39 + let elem = &self.storage; [INFO] [stdout] 40 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/maximum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 37 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/maximum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] 33 | | let elem = &self.n_cpus; [INFO] [stdout] 34 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/maximum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/resources/maximum.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match val { [INFO] [stdout] 98 | | _ => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/minimum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 40 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 + }) && ({ [INFO] [stdout] 39 + let elem = &self.storage; [INFO] [stdout] 40 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/minimum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 37 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/minimum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] 33 | | let elem = &self.n_cpus; [INFO] [stdout] 34 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/minimum.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/resources/minimum.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match val { [INFO] [stdout] 98 | | _ => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/network_install.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 40 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 + }) && ({ [INFO] [stdout] 39 + let elem = &self.storage; [INFO] [stdout] 40 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/network_install.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 37 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/network_install.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] 33 | | let elem = &self.n_cpus; [INFO] [stdout] 34 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/network_install.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/resources/network_install.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match val { [INFO] [stdout] 98 | | _ => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/recommended.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 40 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 + }) && ({ [INFO] [stdout] 39 + let elem = &self.storage; [INFO] [stdout] 40 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 41 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/recommended.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 37 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 + }) && ({ [INFO] [stdout] 36 + let elem = &self.ram; [INFO] [stdout] 37 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 38 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/recommended.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] 33 | | let elem = &self.n_cpus; [INFO] [stdout] 34 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 + }) && ({ [INFO] [stdout] 33 + let elem = &self.n_cpus; [INFO] [stdout] 34 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 35 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources/recommended.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | / true && ({ [INFO] [stdout] 30 | | let elem = &self.cpu; [INFO] [stdout] 31 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 29 ~ ({ [INFO] [stdout] 30 + let elem = &self.cpu; [INFO] [stdout] 31 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 32 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/resources/recommended.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match val { [INFO] [stdout] 98 | | _ => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / true && ({ [INFO] [stdout] 56 | | let elem = &self.network_install; [INFO] [stdout] 57 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 66 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ ({ [INFO] [stdout] 56 + let elem = &self.network_install; [INFO] [stdout] 57 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 + }) && ({ [INFO] [stdout] 59 + let elem = &self.minimum; [INFO] [stdout] 60 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.recommended; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.maximum; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / true && ({ [INFO] [stdout] 56 | | let elem = &self.network_install; [INFO] [stdout] 57 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 63 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ ({ [INFO] [stdout] 56 + let elem = &self.network_install; [INFO] [stdout] 57 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 + }) && ({ [INFO] [stdout] 59 + let elem = &self.minimum; [INFO] [stdout] 60 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.recommended; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / true && ({ [INFO] [stdout] 56 | | let elem = &self.network_install; [INFO] [stdout] 57 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 | | }) && ({ [INFO] [stdout] 59 | | let elem = &self.minimum; [INFO] [stdout] 60 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ ({ [INFO] [stdout] 56 + let elem = &self.network_install; [INFO] [stdout] 57 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 + }) && ({ [INFO] [stdout] 59 + let elem = &self.minimum; [INFO] [stdout] 60 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 61 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/resources.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / true && ({ [INFO] [stdout] 56 | | let elem = &self.network_install; [INFO] [stdout] 57 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 55 ~ ({ [INFO] [stdout] 56 + let elem = &self.network_install; [INFO] [stdout] 57 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 58 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/resources.rs:42:43 [INFO] [stdout] | [INFO] [stdout] 42 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/resources.rs:50:47 [INFO] [stdout] | [INFO] [stdout] 50 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/resources.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | / match val { [INFO] [stdout] 130 | | _ => {} [INFO] [stdout] 131 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/short_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/short_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/short_id.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/storage.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/storage.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/storage.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree/boot_iso.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/tree/boot_iso.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/tree/boot_iso.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree/initrd.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/tree/initrd.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/tree/initrd.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree/kernel.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/tree/kernel.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/tree/kernel.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree/url.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/tree/url.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/tree/url.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/tree/variant.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/tree/variant.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / match child.tag_name().name() { [INFO] [stdout] 43 | | _ => continue, [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 42 ~ child.tag_name().name(); [INFO] [stdout] 43 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/tree/variant.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match val { [INFO] [stdout] 48 | | _ => {} [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / true && ({ [INFO] [stdout] 51 | | let elem = &self.variant; [INFO] [stdout] 52 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 67 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 68 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ ({ [INFO] [stdout] 51 + let elem = &self.variant; [INFO] [stdout] 52 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 + }) && ({ [INFO] [stdout] 54 + let elem = &self.url; [INFO] [stdout] 55 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 56 + }) && ({ [INFO] [stdout] 57 + let elem = &self.treeinfo; [INFO] [stdout] 58 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 59 + }) && ({ [INFO] [stdout] 60 + let elem = &self.initrd; [INFO] [stdout] 61 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 62 + }) && ({ [INFO] [stdout] 63 + let elem = &self.kernel; [INFO] [stdout] 64 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 65 + }) && ({ [INFO] [stdout] 66 + let elem = &self.boot_iso; [INFO] [stdout] 67 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 68 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / true && ({ [INFO] [stdout] 51 | | let elem = &self.variant; [INFO] [stdout] 52 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 64 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 65 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ ({ [INFO] [stdout] 51 + let elem = &self.variant; [INFO] [stdout] 52 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 + }) && ({ [INFO] [stdout] 54 + let elem = &self.url; [INFO] [stdout] 55 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 56 + }) && ({ [INFO] [stdout] 57 + let elem = &self.treeinfo; [INFO] [stdout] 58 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 59 + }) && ({ [INFO] [stdout] 60 + let elem = &self.initrd; [INFO] [stdout] 61 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 62 + }) && ({ [INFO] [stdout] 63 + let elem = &self.kernel; [INFO] [stdout] 64 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 65 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / true && ({ [INFO] [stdout] 51 | | let elem = &self.variant; [INFO] [stdout] 52 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 61 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 62 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ ({ [INFO] [stdout] 51 + let elem = &self.variant; [INFO] [stdout] 52 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 + }) && ({ [INFO] [stdout] 54 + let elem = &self.url; [INFO] [stdout] 55 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 56 + }) && ({ [INFO] [stdout] 57 + let elem = &self.treeinfo; [INFO] [stdout] 58 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 59 + }) && ({ [INFO] [stdout] 60 + let elem = &self.initrd; [INFO] [stdout] 61 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 62 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking half v2.7.1 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / true && ({ [INFO] [stdout] 51 | | let elem = &self.variant; [INFO] [stdout] 52 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 58 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 59 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ ({ [INFO] [stdout] 51 + let elem = &self.variant; [INFO] [stdout] 52 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 + }) && ({ [INFO] [stdout] 54 + let elem = &self.url; [INFO] [stdout] 55 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 56 + }) && ({ [INFO] [stdout] 57 + let elem = &self.treeinfo; [INFO] [stdout] 58 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 59 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / true && ({ [INFO] [stdout] 51 | | let elem = &self.variant; [INFO] [stdout] 52 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 | | }) && ({ [INFO] [stdout] 54 | | let elem = &self.url; [INFO] [stdout] 55 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 56 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ ({ [INFO] [stdout] 51 + let elem = &self.variant; [INFO] [stdout] 52 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 + }) && ({ [INFO] [stdout] 54 + let elem = &self.url; [INFO] [stdout] 55 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 56 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/tree.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | / true && ({ [INFO] [stdout] 51 | | let elem = &self.variant; [INFO] [stdout] 52 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 50 ~ ({ [INFO] [stdout] 51 + let elem = &self.variant; [INFO] [stdout] 52 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 53 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/tree.rs:46:43 [INFO] [stdout] | [INFO] [stdout] 46 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/tree.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | / match val { [INFO] [stdout] 146 | | _ => {} [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo/arch.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/treeinfo/arch.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/treeinfo/arch.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo/family.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/treeinfo/family.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/treeinfo/family.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo/variant.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/treeinfo/variant.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/treeinfo/variant.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo/version.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/treeinfo/version.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/treeinfo/version.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.family; [INFO] [stdout] 35 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 44 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.family; [INFO] [stdout] 35 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.variant; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 + }) && ({ [INFO] [stdout] 40 + let elem = &self.version; [INFO] [stdout] 41 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 + }) && ({ [INFO] [stdout] 43 + let elem = &self.arch; [INFO] [stdout] 44 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.family; [INFO] [stdout] 35 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 41 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.family; [INFO] [stdout] 35 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.variant; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 + }) && ({ [INFO] [stdout] 40 + let elem = &self.version; [INFO] [stdout] 41 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.family; [INFO] [stdout] 35 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] 37 | | let elem = &self.variant; [INFO] [stdout] 38 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.family; [INFO] [stdout] 35 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.variant; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/treeinfo.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.family; [INFO] [stdout] 35 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.family; [INFO] [stdout] 35 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 36 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/treeinfo.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | / match val { [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/upgrades.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/upgrades.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/upgrades.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/variant/name.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/variant/name.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/variant/name.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/variant/name.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/variant.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.names; [INFO] [stdout] 32 | | elem.iter().all(|elem| false) [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.names; [INFO] [stdout] 32 + elem.iter().all(|elem| false) [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/variant.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/variant.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | / match val { [INFO] [stdout] 66 | | _ => {} [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/vendor.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/vendor.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/vendor.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/vendor.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/version.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/version.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/version.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> osinfo-xml/src/lib.rs:315:20 [INFO] [stdout] | [INFO] [stdout] 315 | } else if child.is_text() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 316 | | if let Some(text) = child.text() { [INFO] [stdout] 317 | | if !text.trim().is_empty() { [INFO] [stdout] 318 | | children.push(AnyContent::Text(text.to_string())); [INFO] [stdout] ... | [INFO] [stdout] 321 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 315 ~ } else if child.is_text() [INFO] [stdout] 316 ~ && let Some(text) = child.text() { [INFO] [stdout] 317 | if !text.trim().is_empty() { [INFO] [stdout] 318 | children.push(AnyContent::Text(text.to_string())); [INFO] [stdout] 319 | } [INFO] [stdout] 320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> osinfo-xml/src/lib.rs:316:17 [INFO] [stdout] | [INFO] [stdout] 316 | / if let Some(text) = child.text() { [INFO] [stdout] 317 | | if !text.trim().is_empty() { [INFO] [stdout] 318 | | children.push(AnyContent::Text(text.to_string())); [INFO] [stdout] 319 | | } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 316 ~ if let Some(text) = child.text() [INFO] [stdout] 317 ~ && !text.trim().is_empty() { [INFO] [stdout] 318 | children.push(AnyContent::Text(text.to_string())); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/archnames.rs:210:9 [INFO] [stdout] | [INFO] [stdout] 210 | / loop { [INFO] [stdout] 211 | | let Some(child) = from_child else { [INFO] [stdout] 212 | | break; [INFO] [stdout] 213 | | }; [INFO] [stdout] ... | [INFO] [stdout] 336 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/archnames.rs:215:49 [INFO] [stdout] | [INFO] [stdout] 215 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 216 | | _ => {} [INFO] [stdout] 217 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 215 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 216 + child.tag_name().name(); [INFO] [stdout] 217 + [INFO] [stdout] 218 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / loop { [INFO] [stdout] 51 | | let Some(child) = from_child else { [INFO] [stdout] 52 | | break; [INFO] [stdout] 53 | | }; [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:55:49 [INFO] [stdout] | [INFO] [stdout] 55 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 56 | | _ => {} [INFO] [stdout] 57 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 56 + child.tag_name().name(); [INFO] [stdout] 57 + [INFO] [stdout] 58 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | "all" => { [INFO] [stdout] 62 | | builder.all()?; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:59:33 [INFO] [stdout] | [INFO] [stdout] 59 | if let Some(val) = child.text() { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 60 | match val { [INFO] [stdout] 61 | "all" => { [INFO] [stdout] | ^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:60:25 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | "all" => { [INFO] [stdout] 62 | | builder.all()?; [INFO] [stdout] ... | [INFO] [stdout] 65 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 60 ~ if val == "all" { [INFO] [stdout] 61 + builder.all()?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.archnames` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:145:18 [INFO] [stdout] | [INFO] [stdout] 143 | if self.archnames.is_some() { [INFO] [stdout] | --------------------------- help: try: `if let Some() = &self.archnames` [INFO] [stdout] 144 | return Ok(Archnamesorall::Archnames(Clone::clone( [INFO] [stdout] 145 | &self.archnames.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/archnamesorall.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | &self.archnames.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.archnames.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/alpha.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/alpha.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/avatar_format/alpha.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/height.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/avatar_format/height.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/height.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/mime_type.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/mime_type.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/avatar_format/mime_type.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format/width.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/avatar_format/width.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/avatar_format/width.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 44 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.width; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 + }) && ({ [INFO] [stdout] 40 + let elem = &self.height; [INFO] [stdout] 41 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 + }) && ({ [INFO] [stdout] 43 + let elem = &self.alpha; [INFO] [stdout] 44 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 41 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.width; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 + }) && ({ [INFO] [stdout] 40 + let elem = &self.height; [INFO] [stdout] 41 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 42 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] 37 | | let elem = &self.width; [INFO] [stdout] 38 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 + }) && ({ [INFO] [stdout] 37 + let elem = &self.width; [INFO] [stdout] 38 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 39 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | / true && ({ [INFO] [stdout] 34 | | let elem = &self.mime_types; [INFO] [stdout] 35 | | elem.iter().all(|elem| false) [INFO] [stdout] 36 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 33 ~ ({ [INFO] [stdout] 34 + let elem = &self.mime_types; [INFO] [stdout] 35 + elem.iter().all(|elem| false) [INFO] [stdout] 36 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/avatar_format.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | / match val { [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/bool.rs:22:67 [INFO] [stdout] | [INFO] [stdout] 22 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/bool.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | / loop { [INFO] [stdout] 47 | | let Some(child) = from_child else { [INFO] [stdout] 48 | | break; [INFO] [stdout] 49 | | }; [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/bool.rs:51:49 [INFO] [stdout] | [INFO] [stdout] 51 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 51 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 52 + child.tag_name().name(); [INFO] [stdout] 53 + [INFO] [stdout] 54 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.value` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/bool.rs:162:49 [INFO] [stdout] | [INFO] [stdout] 161 | if self.value.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.value` [INFO] [stdout] 162 | return Ok(Bool::Value(Clone::clone(&self.value.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/bool.rs:162:48 [INFO] [stdout] | [INFO] [stdout] 162 | return Ok(Bool::Value(Clone::clone(&self.value.as_ref().unwrap()))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.value.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/clones.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/clones.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/clones.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/codename.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/codename.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/codename.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/cpu.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/cpu.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/cpu.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:24:43 [INFO] [stdout] | [INFO] [stdout] 24 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:31:43 [INFO] [stdout] | [INFO] [stdout] 31 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match child.tag_name().name() { [INFO] [stdout] 55 | | _ => continue, [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 54 ~ child.tag_name().name(); [INFO] [stdout] 55 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/datamap/entry.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | / match val { [INFO] [stdout] 60 | | _ => {} [INFO] [stdout] 61 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/datamap.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.entries; [INFO] [stdout] 32 | | elem.iter().all(|elem| false) [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.entries; [INFO] [stdout] 32 + elem.iter().all(|elem| false) [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/datamap.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/datamap.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | / match val { [INFO] [stdout] 73 | | _ => {} [INFO] [stdout] 74 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/deployment/os.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/deployment/os.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/deployment/os.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/deployment/platform.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/deployment/platform.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/deployment/platform.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/deployment.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / true && ({ [INFO] [stdout] 38 | | let elem = &self.os; [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 45 | | false [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ ({ [INFO] [stdout] 38 + let elem = &self.os; [INFO] [stdout] 39 + false [INFO] [stdout] 40 + }) && ({ [INFO] [stdout] 41 + let elem = &self.platform; [INFO] [stdout] 42 + false [INFO] [stdout] 43 + }) && ({ [INFO] [stdout] 44 + let elem = &self.devices; [INFO] [stdout] 45 + false [INFO] [stdout] 46 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/deployment.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / true && ({ [INFO] [stdout] 38 | | let elem = &self.os; [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | }) && ({ [INFO] [stdout] 41 | | let elem = &self.platform; [INFO] [stdout] 42 | | false [INFO] [stdout] 43 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ ({ [INFO] [stdout] 38 + let elem = &self.os; [INFO] [stdout] 39 + false [INFO] [stdout] 40 + }) && ({ [INFO] [stdout] 41 + let elem = &self.platform; [INFO] [stdout] 42 + false [INFO] [stdout] 43 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/deployment.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | / true && ({ [INFO] [stdout] 38 | | let elem = &self.os; [INFO] [stdout] 39 | | false [INFO] [stdout] 40 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 ~ ({ [INFO] [stdout] 38 + let elem = &self.os; [INFO] [stdout] 39 + false [INFO] [stdout] 40 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/deployment.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/deployment.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 97 | / match val { [INFO] [stdout] 98 | | _ => {} [INFO] [stdout] 99 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/derives_from.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/derives_from.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/derives_from.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/device/bus_type/bus_type_choice.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / loop { [INFO] [stdout] 61 | | let Some(child) = from_child else { [INFO] [stdout] 62 | | break; [INFO] [stdout] 63 | | }; [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/bus_type/bus_type_choice.rs:65:49 [INFO] [stdout] | [INFO] [stdout] 65 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 66 | | _ => {} [INFO] [stdout] 67 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 65 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 66 + child.tag_name().name(); [INFO] [stdout] 67 + [INFO] [stdout] 68 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/bus_type.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.bus_type_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.bus_type_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/bus_type.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/bus_type.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/device/class/class_choice.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | / loop { [INFO] [stdout] 96 | | let Some(child) = from_child else { [INFO] [stdout] 97 | | break; [INFO] [stdout] 98 | | }; [INFO] [stdout] ... | [INFO] [stdout] 152 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/class/class_choice.rs:100:49 [INFO] [stdout] | [INFO] [stdout] 100 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 101 | | _ => {} [INFO] [stdout] 102 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 100 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 101 + child.tag_name().name(); [INFO] [stdout] 102 + [INFO] [stdout] 103 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/class.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.class_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.class_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/class.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/class.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/name.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/device/name.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/name.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/name.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/product.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/product.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/product.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / loop { [INFO] [stdout] 45 | | let Some(child) = from_child else { [INFO] [stdout] 46 | | break; [INFO] [stdout] 47 | | }; [INFO] [stdout] ... | [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:49:49 [INFO] [stdout] | [INFO] [stdout] 49 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 50 | | _ => {} [INFO] [stdout] 51 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 50 + child.tag_name().name(); [INFO] [stdout] 51 + [INFO] [stdout] 52 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:54:25 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => { [INFO] [stdout] 56 | | builder.value(val)?; [INFO] [stdout] 57 | | } [INFO] [stdout] 58 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 54 ~ { [INFO] [stdout] 55 + builder.value(val)?; [INFO] [stdout] 56 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be written as a `let` statement [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | / match s { [INFO] [stdout] 87 | | val => { [INFO] [stdout] 88 | | builder.value(val)?; [INFO] [stdout] 89 | | } [INFO] [stdout] 90 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using a `let` statement [INFO] [stdout] | [INFO] [stdout] 86 ~ let val = s; [INFO] [stdout] 87 + { [INFO] [stdout] 88 + builder.value(val)?; [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.value` after checking its variant with `is_some` [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 110 | if self.value.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &self.value` [INFO] [stdout] 111 | return Ok(ProductIdChoice::Value(Clone::clone( [INFO] [stdout] 112 | &self.value.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> osinfo-xml/src/device/product_id/product_id_choice.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | &self.value.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.value.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/product_id.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 25 | / true && ({ [INFO] [stdout] 26 | | let elem = &self.product_id_choice; [INFO] [stdout] 27 | | elem.is_empty() [INFO] [stdout] 28 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ ({ [INFO] [stdout] 26 + let elem = &self.product_id_choice; [INFO] [stdout] 27 + elem.is_empty() [INFO] [stdout] 28 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/product_id.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match child.tag_name().name() { [INFO] [stdout] 48 | | _ => continue, [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 47 ~ child.tag_name().name(); [INFO] [stdout] 48 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/product_id.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | / match val { [INFO] [stdout] 53 | | _ => {} [INFO] [stdout] 54 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/subsystem.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/subsystem.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/subsystem.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / true && ({ [INFO] [stdout] 31 | | let elem = &self.value; [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ ({ [INFO] [stdout] 31 + let elem = &self.value; [INFO] [stdout] 32 + false [INFO] [stdout] 33 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:25:47 [INFO] [stdout] | [INFO] [stdout] 25 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / match child.tag_name().name() { [INFO] [stdout] 56 | | _ => continue, [INFO] [stdout] 57 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 55 ~ child.tag_name().name(); [INFO] [stdout] 56 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device/vendor.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | / match val { [INFO] [stdout] 61 | | _ => { [INFO] [stdout] 62 | | builder.value(val)?; [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 60 ~ { [INFO] [stdout] 61 + builder.value(val)?; [INFO] [stdout] 62 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device/vendor_id.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/device/vendor_id.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/device/vendor_id.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 75 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 76 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) && ({ [INFO] [stdout] 68 + let elem = &self.vendors; [INFO] [stdout] 69 + elem.iter().all(|elem| false) [INFO] [stdout] 70 + }) && ({ [INFO] [stdout] 71 + let elem = &self.vendor_id; [INFO] [stdout] 72 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 73 + }) && ({ [INFO] [stdout] 74 + let elem = &self.product; [INFO] [stdout] 75 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 76 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 72 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 73 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) && ({ [INFO] [stdout] 68 + let elem = &self.vendors; [INFO] [stdout] 69 + elem.iter().all(|elem| false) [INFO] [stdout] 70 + }) && ({ [INFO] [stdout] 71 + let elem = &self.vendor_id; [INFO] [stdout] 72 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 73 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 69 | | elem.iter().all(|elem| false) [INFO] [stdout] 70 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 + }) && ({ [INFO] [stdout] 68 + let elem = &self.vendors; [INFO] [stdout] 69 + elem.iter().all(|elem| false) [INFO] [stdout] 70 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] ... | [INFO] [stdout] 66 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 + }) && ({ [INFO] [stdout] 65 + let elem = &self.class; [INFO] [stdout] 66 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 67 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] 62 | | let elem = &self.bus_type; [INFO] [stdout] 63 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 + }) && ({ [INFO] [stdout] 62 + let elem = &self.bus_type; [INFO] [stdout] 63 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 64 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/device.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | / true && ({ [INFO] [stdout] 59 | | let elem = &self.names; [INFO] [stdout] 60 | | elem.iter().all(|elem| false) [INFO] [stdout] 61 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 ~ ({ [INFO] [stdout] 59 + let elem = &self.names; [INFO] [stdout] 60 + elem.iter().all(|elem| false) [INFO] [stdout] 61 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/device.rs:54:43 [INFO] [stdout] | [INFO] [stdout] 54 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/device.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | / match val { [INFO] [stdout] 185 | | _ => {} [INFO] [stdout] 186 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/devices/device/driver.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/devices/device/driver.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/devices/device/driver.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / true && ({ [INFO] [stdout] 43 | | let elem = &self.driver; [INFO] [stdout] 44 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 42 ~ ({ [INFO] [stdout] 43 + let elem = &self.driver; [INFO] [stdout] 44 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 45 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:29:43 [INFO] [stdout] | [INFO] [stdout] 29 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:37:47 [INFO] [stdout] | [INFO] [stdout] 37 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/devices/device.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | / match val { [INFO] [stdout] 88 | | _ => {} [INFO] [stdout] 89 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/devices.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / true && ({ [INFO] [stdout] 22 | | let elem = &self.devices; [INFO] [stdout] 23 | | elem.iter().all(|elem| false) [INFO] [stdout] 24 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ ({ [INFO] [stdout] 22 + let elem = &self.devices; [INFO] [stdout] 23 + elem.iter().all(|elem| false) [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/devices.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match val { [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/distro.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/distro.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/distro.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver/device.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/driver/device.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | / match child.tag_name().name() { [INFO] [stdout] 50 | | _ => continue, [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 49 ~ child.tag_name().name(); [INFO] [stdout] 50 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/driver/device.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / match val { [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/driver/file.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/driver/file.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/driver/file.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/driver.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | / true && ({ [INFO] [stdout] 80 | | let elem = &self.files; [INFO] [stdout] 81 | | elem.iter().all(|elem| false) [INFO] [stdout] 82 | | }) && ({ [INFO] [stdout] 83 | | let elem = &self.devices; [INFO] [stdout] 84 | | elem.iter().all(|elem| false) [INFO] [stdout] 85 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ ({ [INFO] [stdout] 80 + let elem = &self.files; [INFO] [stdout] 81 + elem.iter().all(|elem| false) [INFO] [stdout] 82 + }) && ({ [INFO] [stdout] 83 + let elem = &self.devices; [INFO] [stdout] 84 + elem.iter().all(|elem| false) [INFO] [stdout] 85 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/driver.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | / true && ({ [INFO] [stdout] 80 | | let elem = &self.files; [INFO] [stdout] 81 | | elem.iter().all(|elem| false) [INFO] [stdout] 82 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 79 ~ ({ [INFO] [stdout] 80 + let elem = &self.files; [INFO] [stdout] 81 + elem.iter().all(|elem| false) [INFO] [stdout] 82 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:41:43 [INFO] [stdout] | [INFO] [stdout] 41 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:48:43 [INFO] [stdout] | [INFO] [stdout] 48 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:56:47 [INFO] [stdout] | [INFO] [stdout] 56 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:65:47 [INFO] [stdout] | [INFO] [stdout] 65 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/driver.rs:74:47 [INFO] [stdout] | [INFO] [stdout] 74 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/driver.rs:145:13 [INFO] [stdout] | [INFO] [stdout] 145 | / match val { [INFO] [stdout] 146 | | _ => {} [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/eol_date.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/eol_date.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/eol_date.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/family.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/family.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/family.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match val { [INFO] [stdout] 47 | | _ => { [INFO] [stdout] 48 | | builder.value(val)?; [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ { [INFO] [stdout] 47 + builder.value(val)?; [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/firmware.rs:29:43 [INFO] [stdout] | [INFO] [stdout] 29 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/firmware.rs:36:43 [INFO] [stdout] | [INFO] [stdout] 36 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/firmware.rs:44:47 [INFO] [stdout] | [INFO] [stdout] 44 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/firmware.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | / match child.tag_name().name() { [INFO] [stdout] 72 | | _ => continue, [INFO] [stdout] 73 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 71 ~ child.tag_name().name(); [INFO] [stdout] 72 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/firmware.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / match val { [INFO] [stdout] 77 | | _ => {} [INFO] [stdout] 78 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/firmware_types.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | / loop { [INFO] [stdout] 46 | | let Some(child) = from_child else { [INFO] [stdout] 47 | | break; [INFO] [stdout] 48 | | }; [INFO] [stdout] ... | [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/firmware_types.rs:50:49 [INFO] [stdout] | [INFO] [stdout] 50 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 51 | | _ => {} [INFO] [stdout] 52 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 50 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 51 + child.tag_name().name(); [INFO] [stdout] 52 + [INFO] [stdout] 53 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/image/url.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/image/url.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/image/url.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image/variant.rs:22:43 [INFO] [stdout] | [INFO] [stdout] 22 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/image/variant.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | / match child.tag_name().name() { [INFO] [stdout] 43 | | _ => continue, [INFO] [stdout] 44 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 42 ~ child.tag_name().name(); [INFO] [stdout] 43 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/image/variant.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | / match val { [INFO] [stdout] 48 | | _ => {} [INFO] [stdout] 49 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/image.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / true && ({ [INFO] [stdout] 58 | | let elem = &self.variant; [INFO] [stdout] 59 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 | | }) && ({ [INFO] [stdout] 61 | | let elem = &self.url; [INFO] [stdout] 62 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 63 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ ({ [INFO] [stdout] 58 + let elem = &self.variant; [INFO] [stdout] 59 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 + }) && ({ [INFO] [stdout] 61 + let elem = &self.url; [INFO] [stdout] 62 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 63 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/image.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | / true && ({ [INFO] [stdout] 58 | | let elem = &self.variant; [INFO] [stdout] 59 | | elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 | | }) && ({ [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 57 ~ ({ [INFO] [stdout] 58 + let elem = &self.variant; [INFO] [stdout] 59 + elem.as_ref().map(|elem| false).unwrap_or(true) [INFO] [stdout] 60 ~ }) && ({ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image.rs:37:43 [INFO] [stdout] | [INFO] [stdout] 37 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image.rs:44:43 [INFO] [stdout] | [INFO] [stdout] 44 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/image.rs:52:47 [INFO] [stdout] | [INFO] [stdout] 52 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/image.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | / match val { [INFO] [stdout] 111 | | _ => {} [INFO] [stdout] 112 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> osinfo-xml/src/imageformats.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / loop { [INFO] [stdout] 61 | | let Some(child) = from_child else { [INFO] [stdout] 62 | | break; [INFO] [stdout] 63 | | }; [INFO] [stdout] ... | [INFO] [stdout] 96 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(child) = from_child { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/imageformats.rs:65:49 [INFO] [stdout] | [INFO] [stdout] 65 | roxmltree::NodeType::Element => match child.tag_name().name() { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 66 | | _ => {} [INFO] [stdout] 67 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 65 ~ roxmltree::NodeType::Element => { [INFO] [stdout] 66 + child.tag_name().name(); [INFO] [stdout] 67 + [INFO] [stdout] 68 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/injection_method.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> osinfo-xml/src/injection_method.rs:30:63 [INFO] [stdout] | [INFO] [stdout] 30 | writer.write_event(Event::Text(BytesText::new(&elem.to_string())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `elem.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/injection_method.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 41 ~ child.tag_name().name(); [INFO] [stdout] 42 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/can_post_install_drivers.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/can_post_install_drivers.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/can_post_install_drivers.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/can_pre_install_drivers.rs:24:13 [INFO] [stdout] | [INFO] [stdout] 24 | / true && ({ [INFO] [stdout] 25 | | let elem = &self.bool; [INFO] [stdout] 26 | | elem.is_empty() [INFO] [stdout] 27 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 24 ~ ({ [INFO] [stdout] 25 + let elem = &self.bool; [INFO] [stdout] 26 + elem.is_empty() [INFO] [stdout] 27 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/can_pre_install_drivers.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | / match child.tag_name().name() { [INFO] [stdout] 47 | | _ => continue, [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 46 ~ child.tag_name().name(); [INFO] [stdout] 47 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/can_pre_install_drivers.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | / match val { [INFO] [stdout] 52 | | _ => {} [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:26:43 [INFO] [stdout] | [INFO] [stdout] 26 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:33:43 [INFO] [stdout] | [INFO] [stdout] 33 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:41:47 [INFO] [stdout] | [INFO] [stdout] 41 | quick_xml::escape::escape(&elem.to_string()).as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `elem.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | / match child.tag_name().name() { [INFO] [stdout] 76 | | _ => continue, [INFO] [stdout] 77 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] help: consider using the scrutinee and body instead [INFO] [stdout] | [INFO] [stdout] 75 ~ child.tag_name().name(); [INFO] [stdout] 76 + continue [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/config/param.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | / match val { [INFO] [stdout] 81 | | _ => {} [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/config.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | / true && ({ [INFO] [stdout] 22 | | let elem = &self.params; [INFO] [stdout] 23 | | elem.iter().all(|elem| false) [INFO] [stdout] 24 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 21 ~ ({ [INFO] [stdout] 22 + let elem = &self.params; [INFO] [stdout] 23 + elem.iter().all(|elem| false) [INFO] [stdout] 24 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> osinfo-xml/src/install_script/config.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | / match val { [INFO] [stdout] 54 | | _ => {} [INFO] [stdout] 55 | | } [INFO] [stdout] | |_____________^ help: consider using the match body instead: `{}` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> osinfo-xml/src/install_script/expected_filename.rs:19:13 [INFO] [stdout] | [INFO] [stdout] 19 | / true && ({ [INFO] [stdout] 20 | | let elem = &self.value; [INFO] [stdout] 21 | | false [INFO] [stdout] 22 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 19 ~ ({ [INFO] [stdout] 20 + let elem = &self.value; [INFO] [stdout] 21 + false [INFO] [stdout] 22 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its scrutinee and body [INFO] [stdout] --> osinfo-xml/src/install_script/expected_filename.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | / match child.tag_name().name() { [INFO] [stdout] 42 | | _ => continue, [INFO] [stdout] 43 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [WARN] too many lines in the log, truncating it