[INFO] cloning repository https://github.com/ellisra/fme-md [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ellisra/fme-md" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fellisra%2Ffme-md", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fellisra%2Ffme-md'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eae97ed3ca86ffd0983c2cfc8f326931059def5c [INFO] linting ellisra/fme-md against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fellisra%2Ffme-md" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ellisra/fme-md [INFO] finished tweaking git repo https://github.com/ellisra/fme-md [INFO] tweaked toml for git repo https://github.com/ellisra/fme-md written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ellisra/fme-md on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ellisra/fme-md already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_yaml v0.8.26 [INFO] [stderr] Downloaded yaml-front-matter v0.1.0 [INFO] [stderr] Downloaded winapi-util v0.1.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e843305e10e05688214edd1aef5e01975188b45df21455363ba768a452a3090c [INFO] running `Command { std: "docker" "start" "-a" "e843305e10e05688214edd1aef5e01975188b45df21455363ba768a452a3090c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e843305e10e05688214edd1aef5e01975188b45df21455363ba768a452a3090c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e843305e10e05688214edd1aef5e01975188b45df21455363ba768a452a3090c", kill_on_drop: false }` [INFO] [stdout] e843305e10e05688214edd1aef5e01975188b45df21455363ba768a452a3090c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f9d6f0c7ed0ddc88c8f390b65e4673ca44646e6e08eeae2c857355cad6d01e3 [INFO] running `Command { std: "docker" "start" "-a" "1f9d6f0c7ed0ddc88c8f390b65e4673ca44646e6e08eeae2c857355cad6d01e3", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking indexmap v2.8.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking clap_builder v4.5.32 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking clap v4.5.32 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking yaml-front-matter v0.1.0 [INFO] [stderr] Checking fme v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | initial_tag: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - initial_tag: &String, [INFO] [stdout] 80 + initial_tag: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 151 | if !frontmatter.id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `frontmatter.id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/fs_utils.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 28 | print!("Updated: {}\n", md_rfpath.display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 28 - print!("Updated: {}\n", md_rfpath.display()); [INFO] [stdout] 28 + println!("Updated: {}", md_rfpath.display()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/fs_utils.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 46 - path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] 46 + path.is_file() && path.extension().is_some_and(|ext| ext == "md") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/fs_utils.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 58 - path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] 58 + path.is_file() && path.extension().is_some_and(|ext| ext == "md") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/commands.rs:80:18 [INFO] [stdout] | [INFO] [stdout] 80 | initial_tag: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 80 - initial_tag: &String, [INFO] [stdout] 80 + initial_tag: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/commands.rs:151:8 [INFO] [stdout] | [INFO] [stdout] 151 | if !frontmatter.id.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `frontmatter.id.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/fs_utils.rs:28:21 [INFO] [stdout] | [INFO] [stdout] 28 | print!("Updated: {}\n", md_rfpath.display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 28 - print!("Updated: {}\n", md_rfpath.display()); [INFO] [stdout] 28 + println!("Updated: {}", md_rfpath.display()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/fs_utils.rs:46:31 [INFO] [stdout] | [INFO] [stdout] 46 | path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 46 - path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] 46 + path.is_file() && path.extension().is_some_and(|ext| ext == "md") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/fs_utils.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 58 - path.is_file() && path.extension().map_or(false, |ext| ext == "md") [INFO] [stdout] 58 + path.is_file() && path.extension().is_some_and(|ext| ext == "md") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.31s [INFO] running `Command { std: "docker" "inspect" "1f9d6f0c7ed0ddc88c8f390b65e4673ca44646e6e08eeae2c857355cad6d01e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f9d6f0c7ed0ddc88c8f390b65e4673ca44646e6e08eeae2c857355cad6d01e3", kill_on_drop: false }` [INFO] [stdout] 1f9d6f0c7ed0ddc88c8f390b65e4673ca44646e6e08eeae2c857355cad6d01e3