[INFO] cloning repository https://github.com/elizabeth-dev/FCM_Relay [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/elizabeth-dev/FCM_Relay" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felizabeth-dev%2FFCM_Relay", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felizabeth-dev%2FFCM_Relay'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e2f6687bf64cacdc4f045f4c6bf1afb8788d5261 [INFO] linting elizabeth-dev/FCM_Relay against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felizabeth-dev%2FFCM_Relay" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/elizabeth-dev/FCM_Relay [INFO] finished tweaking git repo https://github.com/elizabeth-dev/FCM_Relay [INFO] tweaked toml for git repo https://github.com/elizabeth-dev/FCM_Relay written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/elizabeth-dev/FCM_Relay on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/elizabeth-dev/FCM_Relay already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lambda_http v0.11.1 [INFO] [stderr] Downloaded query_map v0.7.0 [INFO] [stderr] Downloaded base64 v0.22.0 [INFO] [stderr] Downloaded security-framework-sys v2.10.0 [INFO] [stderr] Downloaded lambda_runtime_api_client v0.11.0 [INFO] [stderr] Downloaded hyper v1.3.0 [INFO] [stderr] Downloaded cc v1.0.94 [INFO] [stderr] Downloaded proc-macro2 v1.0.80 [INFO] [stderr] Downloaded rustls-pki-types v1.4.1 [INFO] [stderr] Downloaded reqwest v0.12.3 [INFO] [stderr] Downloaded lambda_runtime v0.11.1 [INFO] [stderr] Downloaded aws_lambda_events v0.15.0 [INFO] [stderr] Downloaded http-serde v2.1.0 [INFO] [stderr] Downloaded syn v2.0.59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec7e1a3af4f9814ac009795703d9a3433ca6c5b2a94d3e067458f04d4c93e687 [INFO] running `Command { std: "docker" "start" "-a" "ec7e1a3af4f9814ac009795703d9a3433ca6c5b2a94d3e067458f04d4c93e687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec7e1a3af4f9814ac009795703d9a3433ca6c5b2a94d3e067458f04d4c93e687", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec7e1a3af4f9814ac009795703d9a3433ca6c5b2a94d3e067458f04d4c93e687", kill_on_drop: false }` [INFO] [stdout] ec7e1a3af4f9814ac009795703d9a3433ca6c5b2a94d3e067458f04d4c93e687 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e7efa92fe82682a8c10e5ed0edf1512219c2cf0636aee4f5383dbde09a01326 [INFO] running `Command { std: "docker" "start" "-a" "0e7efa92fe82682a8c10e5ed0edf1512219c2cf0636aee4f5383dbde09a01326", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Compiling cc v1.0.94 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking query_map v0.7.0 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking http-serde v2.1.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking aws_lambda_events v0.15.0 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking hyper v1.3.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking lambda_runtime_api_client v0.11.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.3 [INFO] [stderr] Checking lambda_runtime v0.11.1 [INFO] [stderr] Checking lambda_http v0.11.1 [INFO] [stderr] Checking fcm_relay v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validation.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !headers [INFO] [stdout] | ________^ [INFO] [stdout] 36 | | .get(header::CONTENT_ENCODING) [INFO] [stdout] 37 | | .is_some_and(|x| x == "aesgcm") [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 35 ~ if headers [INFO] [stdout] 36 + .get(header::CONTENT_ENCODING).is_none_or(|x| x != "aesgcm") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | / return headers [INFO] [stdout] 68 | | .get(key) [INFO] [stdout] 69 | | .unwrap() [INFO] [stdout] 70 | | .to_str() [INFO] [stdout] ... | [INFO] [stdout] 73 | | .find(|x| x.starts_with(param)) [INFO] [stdout] 74 | | .and_then(|x| x.split('=').last().map(|x| x.to_string())); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ headers [INFO] [stdout] 68 + .get(key) [INFO] [stdout] 69 + .unwrap() [INFO] [stdout] 70 + .to_str() [INFO] [stdout] 71 + .unwrap_or_default() [INFO] [stdout] 72 + .split(';') [INFO] [stdout] 73 + .find(|x| x.starts_with(param)) [INFO] [stdout] 74 ~ .and_then(|x| x.split('=').last().map(|x| x.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/validation.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | .and_then(|x| x.split('=').last().map(|x| x.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - .and_then(|x| x.split('=').last().map(|x| x.to_string())); [INFO] [stdout] 74 + .and_then(|x| x.split('=').next_back().map(|x| x.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `params` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:12:38 [INFO] [stdout] | [INFO] [stdout] 11 | if params.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = params` [INFO] [stdout] 12 | let (status_code, message) = params.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return Ok(Response::builder().status(204).body(Body::Empty)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ Ok(Response::builder().status(204).body(Body::Empty)?) [INFO] [stdout] 54 | } [INFO] [stdout] ... [INFO] [stdout] 61 | } [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | / return Ok(Response::builder() [INFO] [stdout] 57 | | .status(500) [INFO] [stdout] 58 | | .header("content-type", "text/plain") [INFO] [stdout] 59 | | .body("Unknown error when sending FCM message".into()) [INFO] [stdout] 60 | | .map_err(Box::new)?) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ Ok(Response::builder() [INFO] [stdout] 57 + .status(500) [INFO] [stdout] 58 + .header("content-type", "text/plain") [INFO] [stdout] 59 + .body("Unknown error when sending FCM message".into()) [INFO] [stdout] 60 + .map_err(Box::new)?) [INFO] [stdout] 61 | } [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/validation.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if !headers [INFO] [stdout] | ________^ [INFO] [stdout] 36 | | .get(header::CONTENT_ENCODING) [INFO] [stdout] 37 | | .is_some_and(|x| x == "aesgcm") [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 35 ~ if headers [INFO] [stdout] 36 + .get(header::CONTENT_ENCODING).is_none_or(|x| x != "aesgcm") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/validation.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | / return headers [INFO] [stdout] 68 | | .get(key) [INFO] [stdout] 69 | | .unwrap() [INFO] [stdout] 70 | | .to_str() [INFO] [stdout] ... | [INFO] [stdout] 73 | | .find(|x| x.starts_with(param)) [INFO] [stdout] 74 | | .and_then(|x| x.split('=').last().map(|x| x.to_string())); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ headers [INFO] [stdout] 68 + .get(key) [INFO] [stdout] 69 + .unwrap() [INFO] [stdout] 70 + .to_str() [INFO] [stdout] 71 + .unwrap_or_default() [INFO] [stdout] 72 + .split(';') [INFO] [stdout] 73 + .find(|x| x.starts_with(param)) [INFO] [stdout] 74 ~ .and_then(|x| x.split('=').last().map(|x| x.to_string())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/validation.rs:74:23 [INFO] [stdout] | [INFO] [stdout] 74 | .and_then(|x| x.split('=').last().map(|x| x.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 74 - .and_then(|x| x.split('=').last().map(|x| x.to_string())); [INFO] [stdout] 74 + .and_then(|x| x.split('=').next_back().map(|x| x.to_string())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.58s [INFO] [stdout] warning: called `unwrap_err` on `params` after checking its variant with `is_err` [INFO] [stdout] --> src/main.rs:12:38 [INFO] [stdout] | [INFO] [stdout] 11 | if params.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Err() = params` [INFO] [stdout] 12 | let (status_code, message) = params.unwrap_err(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | return Ok(Response::builder().status(204).body(Body::Empty)?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 ~ Ok(Response::builder().status(204).body(Body::Empty)?) [INFO] [stdout] 54 | } [INFO] [stdout] ... [INFO] [stdout] 61 | } [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:56:13 [INFO] [stdout] | [INFO] [stdout] 56 | / return Ok(Response::builder() [INFO] [stdout] 57 | | .status(500) [INFO] [stdout] 58 | | .header("content-type", "text/plain") [INFO] [stdout] 59 | | .body("Unknown error when sending FCM message".into()) [INFO] [stdout] 60 | | .map_err(Box::new)?) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ Ok(Response::builder() [INFO] [stdout] 57 + .status(500) [INFO] [stdout] 58 + .header("content-type", "text/plain") [INFO] [stdout] 59 + .body("Unknown error when sending FCM message".into()) [INFO] [stdout] 60 + .map_err(Box::new)?) [INFO] [stdout] 61 | } [INFO] [stdout] 62 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "0e7efa92fe82682a8c10e5ed0edf1512219c2cf0636aee4f5383dbde09a01326", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e7efa92fe82682a8c10e5ed0edf1512219c2cf0636aee4f5383dbde09a01326", kill_on_drop: false }` [INFO] [stdout] 0e7efa92fe82682a8c10e5ed0edf1512219c2cf0636aee4f5383dbde09a01326