[INFO] cloning repository https://github.com/elijah-potter/tatum [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/elijah-potter/tatum" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felijah-potter%2Ftatum", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felijah-potter%2Ftatum'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1bf1735f3336565375254ea6260e4b1a5793929a [INFO] linting elijah-potter/tatum against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Felijah-potter%2Ftatum" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/elijah-potter/tatum [INFO] finished tweaking git repo https://github.com/elijah-potter/tatum [INFO] tweaked toml for git repo https://github.com/elijah-potter/tatum written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/elijah-potter/tatum on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/elijah-potter/tatum already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/pulldown-cmark/pulldown-cmark` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded newline-converter v0.3.0 [INFO] [stderr] Downloaded askama_derive v0.12.5 [INFO] [stderr] Downloaded getrandom v0.2.13 [INFO] [stderr] Downloaded sync_wrapper v1.0.0 [INFO] [stderr] Downloaded open v5.1.2 [INFO] [stderr] Downloaded askama_parser v0.2.1 [INFO] [stderr] Downloaded basic-toml v0.1.9 [INFO] [stderr] Downloaded resolve-path v0.1.0 [INFO] [stderr] Downloaded inquire v0.7.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f9579fc37e9e79247832e1d802ba47257915a3caaad986d36aba74cec3170b9c [INFO] running `Command { std: "docker" "start" "-a" "f9579fc37e9e79247832e1d802ba47257915a3caaad986d36aba74cec3170b9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f9579fc37e9e79247832e1d802ba47257915a3caaad986d36aba74cec3170b9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9579fc37e9e79247832e1d802ba47257915a3caaad986d36aba74cec3170b9c", kill_on_drop: false }` [INFO] [stdout] f9579fc37e9e79247832e1d802ba47257915a3caaad986d36aba74cec3170b9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 78f09117383d9498226f0677998652c6c050b107f739812f3f2178c8042a975d [INFO] running `Command { std: "docker" "start" "-a" "78f09117383d9498226f0677998652c6c050b107f739812f3f2178c8042a975d", kill_on_drop: false }` [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking getrandom v0.2.13 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling mime v0.3.17 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossbeam-utils v0.8.19 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Compiling pulldown-cmark v0.10.0 (https://github.com/pulldown-cmark/pulldown-cmark?rev=2540d4095d5f94fd972c93b927e9bec83b0c5079#2540d409) [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking humansize v2.1.3 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking newline-converter v0.3.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking pulldown-cmark-escape v0.10.0 (https://github.com/pulldown-cmark/pulldown-cmark?rev=2540d4095d5f94fd972c93b927e9bec83b0c5079#2540d409) [INFO] [stderr] Checking askama_escape v0.10.3 [INFO] [stderr] Checking sync_wrapper v1.0.0 [INFO] [stderr] Checking open v5.1.2 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking inquire v0.7.5 [INFO] [stderr] Compiling askama_parser v0.2.1 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking resolve-path v0.1.0 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.79 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking hyper v1.2.0 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking serde_json v1.0.115 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Compiling basic-toml v0.1.9 [INFO] [stderr] Compiling askama_derive v0.12.5 [INFO] [stderr] Checking askama v0.12.1 [INFO] [stderr] Checking tatum v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `command` [INFO] [stdout] --> src/main.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{command, Parser}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `command` [INFO] [stdout] --> src/main.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | use clap::{command, Parser}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/render.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 70 | } else if let Ok(image_path) = dest_url.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/render.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | if let Ok(file_path) = dest_url.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/render.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 70 | } else if let Ok(image_path) = dest_url.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/render.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | if let Ok(file_path) = dest_url.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 89 | if !dest_url.parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest_url.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:96:51 [INFO] [stdout] | [INFO] [stdout] 96 | ... join_and_canonicalize(&file_path, path.clone()) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Path` [INFO] [stdout] --> src/render.rs:228:14 [INFO] [stdout] | [INFO] [stdout] 228 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/render.rs:324:9 [INFO] [stdout] | [INFO] [stdout] 324 | assert_eq!(is_child_path(current_file, file), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 324 - assert_eq!(is_child_path(current_file, file), true); [INFO] [stdout] 324 + assert!(is_child_path(current_file, file)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_ne!` with a literal bool [INFO] [stdout] --> src/render.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | assert_ne!(is_child_path(current_file, file), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 331 - assert_ne!(is_child_path(current_file, file), true); [INFO] [stdout] 331 + assert!(!is_child_path(current_file, file)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/render.rs:89:16 [INFO] [stdout] | [INFO] [stdout] 89 | if !dest_url.parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `dest_url.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/render.rs:96:51 [INFO] [stdout] | [INFO] [stdout] 96 | ... join_and_canonicalize(&file_path, path.clone()) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Path` [INFO] [stdout] --> src/render.rs:228:14 [INFO] [stdout] | [INFO] [stdout] 228 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 02s [INFO] running `Command { std: "docker" "inspect" "78f09117383d9498226f0677998652c6c050b107f739812f3f2178c8042a975d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "78f09117383d9498226f0677998652c6c050b107f739812f3f2178c8042a975d", kill_on_drop: false }` [INFO] [stdout] 78f09117383d9498226f0677998652c6c050b107f739812f3f2178c8042a975d