[INFO] cloning repository https://github.com/ejkul/pong-ggez [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ejkul/pong-ggez" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fejkul%2Fpong-ggez", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fejkul%2Fpong-ggez'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8e460b25c4b98dd187b5f32a2f6c7ba45ff38058 [INFO] linting ejkul/pong-ggez against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fejkul%2Fpong-ggez" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ejkul/pong-ggez [INFO] finished tweaking git repo https://github.com/ejkul/pong-ggez [INFO] tweaked toml for git repo https://github.com/ejkul/pong-ggez written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ejkul/pong-ggez on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ejkul/pong-ggez already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zip v0.5.8 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.68 [INFO] [stderr] Downloaded pkg-config v0.3.18 [INFO] [stderr] Downloaded thiserror-impl v1.0.20 [INFO] [stderr] Downloaded ordered-float v1.1.0 [INFO] [stderr] Downloaded rand v0.5.6 [INFO] [stderr] Downloaded dirs-sys v0.3.5 [INFO] [stderr] Downloaded coreaudio-sys v0.2.5 [INFO] [stderr] Downloaded syn v1.0.41 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.68 [INFO] [stderr] Downloaded cc v1.0.60 [INFO] [stderr] Downloaded gimli v0.22.0 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.68 [INFO] [stderr] Downloaded ppv-lite86 v0.2.9 [INFO] [stderr] Downloaded hermit-abi v0.1.16 [INFO] [stderr] Downloaded num-iter v0.1.41 [INFO] [stderr] Downloaded version_check v0.9.2 [INFO] [stderr] Downloaded bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Downloaded rust-argon2 v0.8.2 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.68 [INFO] [stderr] Downloaded addr2line v0.13.0 [INFO] [stderr] Downloaded xi-unicode v0.2.1 [INFO] [stderr] Downloaded xml-rs v0.8.3 [INFO] [stderr] Downloaded serde_json v1.0.57 [INFO] [stderr] Downloaded object v0.20.0 [INFO] [stderr] Downloaded nom v5.1.2 [INFO] [stderr] Downloaded wasm-bindgen v0.2.68 [INFO] [stderr] Downloaded bindgen v0.53.3 [INFO] [stderr] Downloaded serde_derive v1.0.116 [INFO] [stderr] Downloaded backtrace v0.3.50 [INFO] [stderr] Downloaded serde v1.0.116 [INFO] [stderr] Downloaded jpeg-decoder v0.1.20 [INFO] [stderr] Downloaded libc v0.2.77 [INFO] [stderr] Downloaded adler v0.2.3 [INFO] [stderr] Downloaded miniz_oxide v0.4.2 [INFO] [stderr] Downloaded libloading v0.6.3 [INFO] [stderr] Downloaded redox_users v0.3.5 [INFO] [stderr] Downloaded gilrs-core v0.2.6 [INFO] [stderr] Downloaded thiserror v1.0.20 [INFO] [stderr] Downloaded linked-hash-map v0.5.3 [INFO] [stderr] Downloaded proc-macro2 v1.0.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9b602de25c7cafb1c10aabcf0f544eb666210cf8608d3f5e2add4f2361e68b34 [INFO] running `Command { std: "docker" "start" "-a" "9b602de25c7cafb1c10aabcf0f544eb666210cf8608d3f5e2add4f2361e68b34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9b602de25c7cafb1c10aabcf0f544eb666210cf8608d3f5e2add4f2361e68b34", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b602de25c7cafb1c10aabcf0f544eb666210cf8608d3f5e2add4f2361e68b34", kill_on_drop: false }` [INFO] [stdout] 9b602de25c7cafb1c10aabcf0f544eb666210cf8608d3f5e2add4f2361e68b34 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7e80d6ace7defb1850b20e00ca0155d14292aaf84dd032c10e83233367944b00 [INFO] running `Command { std: "docker" "start" "-a" "7e80d6ace7defb1850b20e00ca0155d14292aaf84dd032c10e83233367944b00", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling libm v0.2.1 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling serde v1.0.116 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling cc v1.0.60 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling proc-macro2 v1.0.21 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling libloading v0.6.3 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling syn v1.0.41 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking dlib v0.4.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling miniz_oxide v0.4.2 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Checking wayland-sys v0.21.13 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Compiling gimli v0.22.0 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling adler v0.2.3 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling wayland-scanner v0.21.13 [INFO] [stderr] Compiling object v0.20.0 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Compiling serde_derive v1.0.116 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking line_drawing v0.7.0 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling itoa v0.4.6 [INFO] [stderr] Compiling pulldown-cmark v0.2.0 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Checking rusttype v0.7.9 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking xdg v2.2.0 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Compiling gfx_gl v0.6.1 [INFO] [stderr] Compiling glutin_egl_sys v0.1.5 [INFO] [stderr] Compiling glutin_glx_sys v0.1.7 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling wayland-client v0.21.13 [INFO] [stderr] Compiling addr2line v0.13.0 [INFO] [stderr] Compiling wayland-protocols v0.21.13 [INFO] [stderr] Checking andrew v0.2.1 [INFO] [stderr] Compiling bzip2-sys v0.1.9+1.0.8 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling backtrace v0.3.50 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking gfx_core v0.9.2 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking sid v0.5.2 [INFO] [stderr] Checking wayland-commons v0.21.13 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking raw-window-handle v0.3.3 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Checking xi-unicode v0.2.1 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling bytecount v0.4.0 [INFO] [stderr] Checking alga v0.9.3 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking glyph_brush_layout v0.1.9 [INFO] [stderr] Checking twox-hash v1.5.0 [INFO] [stderr] Checking nix v0.15.0 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Checking mint v0.5.5 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking glyph_brush v0.6.3 [INFO] [stderr] Checking cpal v0.8.2 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Checking minimp3 v0.3.5 [INFO] [stderr] Checking lewton v0.9.4 [INFO] [stderr] Checking png v0.15.3 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking glyph_brush v0.5.4 [INFO] [stderr] Checking gfx v0.18.2 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking gfx_device_gl v0.16.2 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Compiling euclid_macros v0.1.0 [INFO] [stderr] Compiling smart-default v0.5.2 [INFO] [stderr] Checking nalgebra v0.18.1 [INFO] [stderr] Checking euclid v0.19.9 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking zip v0.5.8 [INFO] [stderr] Checking gilrs-core v0.2.6 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking gilrs v0.7.4 [INFO] [stderr] Checking image v0.22.5 [INFO] [stderr] Checking lyon_geom v0.12.7 [INFO] [stderr] Checking lyon_path v0.13.2 [INFO] [stderr] Checking lyon_tessellation v0.13.5 [INFO] [stderr] Checking lyon_algorithms v0.13.4 [INFO] [stderr] Checking toml v0.5.6 [INFO] [stderr] Checking lyon v0.13.5 [INFO] [stderr] Compiling cargo_metadata v0.6.4 [INFO] [stderr] Compiling skeptic v0.13.4 [INFO] [stderr] Compiling ggez v0.5.1 [INFO] [stderr] Checking rodio v0.9.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.6 [INFO] [stderr] Checking winit v0.19.5 [INFO] [stderr] Checking glutin v0.20.1 [INFO] [stderr] Checking gfx_window_glutin v0.30.0 [INFO] [stderr] Checking pong v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `GameError` [INFO] [stdout] --> src/ball.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | use ggez::{graphics, Context, GameError, GameResult}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BALL_SIZE` and `PADDLE_MAX_VEL` [INFO] [stdout] --> src/paddle.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{BALL_SIZE, PADDLE_MAX_VEL, PADDLE_SIZE, WINDOW_HEIGHT, WINDOW_WIDTH}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ggez::graphics::Mesh` [INFO] [stdout] --> src/paddle.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use ggez::graphics::Mesh; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ggez::nalgebra as na` [INFO] [stdout] --> src/paddle.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use ggez::nalgebra as na; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GameError` [INFO] [stdout] --> src/paddle.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | use ggez::{graphics, Context, GameError, GameResult}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GameError` [INFO] [stdout] --> src/ball.rs:4:31 [INFO] [stdout] | [INFO] [stdout] 4 | use ggez::{graphics, Context, GameError, GameResult}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BALL_SIZE` and `PADDLE_MAX_VEL` [INFO] [stdout] --> src/paddle.rs:1:13 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::{BALL_SIZE, PADDLE_MAX_VEL, PADDLE_SIZE, WINDOW_HEIGHT, WINDOW_WIDTH}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ggez::graphics::Mesh` [INFO] [stdout] --> src/paddle.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use ggez::graphics::Mesh; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ggez::nalgebra as na` [INFO] [stdout] --> src/paddle.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use ggez::nalgebra as na; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `GameError` [INFO] [stdout] --> src/paddle.rs:5:31 [INFO] [stdout] | [INFO] [stdout] 5 | use ggez::{graphics, Context, GameError, GameResult}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `assets_path` [INFO] [stdout] --> src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | let assets_path = path::PathBuf::from("../assets"); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_assets_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ball.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | self.loc = self.loc + self.vel; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.loc += self.vel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ball.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.vel.y *= -1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/ball.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 55 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `-self.vel.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ball.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.vel.y *= -1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/ball.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `-self.vel.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ball.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | if !(self.loc.x > paddle.loc.x + PADDLE_SIZE[0] || paddle.loc.x > self.loc.x + BALL_SIZE) [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | && !(self.loc.y > paddle.loc.y + PADDLE_SIZE[1] [INFO] [stdout] 66 | | || paddle.loc.y > self.loc.y + BALL_SIZE) [INFO] [stdout] | |_________________________________________________________^ help: try: `!(self.loc.x > paddle.loc.x + PADDLE_SIZE[0] || paddle.loc.x > self.loc.x + BALL_SIZE || self.loc.y > paddle.loc.y + PADDLE_SIZE[1] || paddle.loc.y > self.loc.y + BALL_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ggez::GameError` [INFO] [stdout] --> src/main.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | Err(GameError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `GameError::from()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | graphics::TextFragment::new(String::from(num.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `num.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / match self.state { [INFO] [stdout] 105 | | State::Play => self.play_state(ctx)?, [INFO] [stdout] 106 | | _ => (), [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________^ help: try: `if let State::Play = self.state { self.play_state(ctx)? }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `assets_path` [INFO] [stdout] --> src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | let assets_path = path::PathBuf::from("../assets"); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_assets_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | / match self.reset() { [INFO] [stdout] 168 | | Ok(_) => (), [INFO] [stdout] 169 | | Err(_) => (), [INFO] [stdout] 170 | | }; [INFO] [stdout] | |_________________^ help: try: `if let Ok(_) = self.reset() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ball.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | self.loc = self.loc + self.vel; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.loc += self.vel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ball.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.vel.y *= -1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/ball.rs:55:26 [INFO] [stdout] | [INFO] [stdout] 55 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `-self.vel.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] = note: `#[warn(clippy::neg_multiply)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ball.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.vel.y *= -1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this multiplication by -1 can be written more succinctly [INFO] [stdout] --> src/ball.rs:58:26 [INFO] [stdout] | [INFO] [stdout] 58 | self.vel.y = self.vel.y * -1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using: `-self.vel.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ball.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 64 | if !(self.loc.x > paddle.loc.x + PADDLE_SIZE[0] || paddle.loc.x > self.loc.x + BALL_SIZE) [INFO] [stdout] | ____________^ [INFO] [stdout] 65 | | && !(self.loc.y > paddle.loc.y + PADDLE_SIZE[1] [INFO] [stdout] 66 | | || paddle.loc.y > self.loc.y + BALL_SIZE) [INFO] [stdout] | |_________________________________________________________^ help: try: `!(self.loc.x > paddle.loc.x + PADDLE_SIZE[0] || paddle.loc.x > self.loc.x + BALL_SIZE || self.loc.y > paddle.loc.y + PADDLE_SIZE[1] || paddle.loc.y > self.loc.y + BALL_SIZE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `ggez::GameError` [INFO] [stdout] --> src/main.rs:45:17 [INFO] [stdout] | [INFO] [stdout] 45 | Err(GameError::from(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `GameError::from()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/main.rs:69:37 [INFO] [stdout] | [INFO] [stdout] 69 | graphics::TextFragment::new(String::from(num.to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `num.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | / match self.state { [INFO] [stdout] 105 | | State::Play => self.play_state(ctx)?, [INFO] [stdout] 106 | | _ => (), [INFO] [stdout] 107 | | } [INFO] [stdout] | |_____________^ help: try: `if let State::Play = self.state { self.play_state(ctx)? }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:167:17 [INFO] [stdout] | [INFO] [stdout] 167 | / match self.reset() { [INFO] [stdout] 168 | | Ok(_) => (), [INFO] [stdout] 169 | | Err(_) => (), [INFO] [stdout] 170 | | }; [INFO] [stdout] | |_________________^ help: try: `if let Ok(_) = self.reset() { () }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 09s [INFO] running `Command { std: "docker" "inspect" "7e80d6ace7defb1850b20e00ca0155d14292aaf84dd032c10e83233367944b00", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e80d6ace7defb1850b20e00ca0155d14292aaf84dd032c10e83233367944b00", kill_on_drop: false }` [INFO] [stdout] 7e80d6ace7defb1850b20e00ca0155d14292aaf84dd032c10e83233367944b00