[INFO] cloning repository https://github.com/eggnogdev/huffman-coding [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eggnogdev/huffman-coding" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feggnogdev%2Fhuffman-coding", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feggnogdev%2Fhuffman-coding'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 14c4249f9c0cf9cae8269788de8230c58b1ecb22 [INFO] linting eggnogdev/huffman-coding against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feggnogdev%2Fhuffman-coding" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eggnogdev/huffman-coding [INFO] finished tweaking git repo https://github.com/eggnogdev/huffman-coding [INFO] tweaked toml for git repo https://github.com/eggnogdev/huffman-coding written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eggnogdev/huffman-coding on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eggnogdev/huffman-coding already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clap v4.5.28 [INFO] [stderr] Downloaded clap_derive v4.5.28 [INFO] [stderr] Downloaded clap_builder v4.5.27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e56c2b7fa92a5ad7c0bc8825fe693102a6b6322790ae6bf76e578c76b16c2588 [INFO] running `Command { std: "docker" "start" "-a" "e56c2b7fa92a5ad7c0bc8825fe693102a6b6322790ae6bf76e578c76b16c2588", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e56c2b7fa92a5ad7c0bc8825fe693102a6b6322790ae6bf76e578c76b16c2588", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e56c2b7fa92a5ad7c0bc8825fe693102a6b6322790ae6bf76e578c76b16c2588", kill_on_drop: false }` [INFO] [stdout] e56c2b7fa92a5ad7c0bc8825fe693102a6b6322790ae6bf76e578c76b16c2588 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a8da90b45bb77c87d224fa905810286d57e7172fb3683cf2d1751a592e10e71 [INFO] running `Command { std: "docker" "start" "-a" "8a8da90b45bb77c87d224fa905810286d57e7172fb3683cf2d1751a592e10e71", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking clap_builder v4.5.27 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling clap_derive v4.5.28 [INFO] [stderr] Checking clap v4.5.28 [INFO] [stderr] Checking huffman-coding v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/char_code.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / return CharCodePair { [INFO] [stdout] 11 | | value, [INFO] [stdout] 12 | | bits, [INFO] [stdout] 13 | | code, [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 ~ CharCodePair { [INFO] [stdout] 11 + value, [INFO] [stdout] 12 + bits, [INFO] [stdout] 13 + code, [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/char_code.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / return CharCodePair { [INFO] [stdout] 11 | | value, [INFO] [stdout] 12 | | bits, [INFO] [stdout] 13 | | code, [INFO] [stdout] 14 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 ~ CharCodePair { [INFO] [stdout] 11 + value, [INFO] [stdout] 12 + bits, [INFO] [stdout] 13 + code, [INFO] [stdout] 14 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return result; [INFO] [stdout] 85 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return compressed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return compressed; [INFO] [stdout] 101 + compressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/huffman_coding.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | let og_bytes = s.as_bytes().len() as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return result; [INFO] [stdout] 165 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:85:5 [INFO] [stdout] | [INFO] [stdout] 85 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - return result; [INFO] [stdout] 85 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | return decompressed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return decompressed; [INFO] [stdout] 172 + decompressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left_char` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:201:23 [INFO] [stdout] | [INFO] [stdout] 197 | if left_char.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = left_char` [INFO] [stdout] ... [INFO] [stdout] 201 | let left_char = left_char.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right_char` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 211 | if right_char.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = right_char` [INFO] [stdout] ... [INFO] [stdout] 215 | let right_char = right_char.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tree.left` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:231:10 [INFO] [stdout] | [INFO] [stdout] 225 | if tree.left.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &tree.left` [INFO] [stdout] ... [INFO] [stdout] 231 | &tree.left.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:101:5 [INFO] [stdout] | [INFO] [stdout] 101 | return compressed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return compressed; [INFO] [stdout] 101 + compressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tree.right` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:244:10 [INFO] [stdout] | [INFO] [stdout] 238 | if tree.right.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &tree.right` [INFO] [stdout] ... [INFO] [stdout] 244 | &tree.right.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/huffman_coding.rs:93:22 [INFO] [stdout] | [INFO] [stdout] 93 | let og_bytes = s.as_bytes().len() as f64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `s.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | &tree.left.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tree.left.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | &tree.right.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tree.right.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 165 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return result; [INFO] [stdout] 165 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:256:16 [INFO] [stdout] | [INFO] [stdout] 256 | return &pair; [INFO] [stdout] | ^^^^^ help: change this to: `pair` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 280 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return result; [INFO] [stdout] 280 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return result; [INFO] [stdout] 291 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return result; [INFO] [stdout] 312 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/huffman_coding.rs:295:33 [INFO] [stdout] | [INFO] [stdout] 295 | fn get_metadata_from_bytes(b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 295 - fn get_metadata_from_bytes(b: &Vec) -> Vec { [INFO] [stdout] 295 + fn get_metadata_from_bytes(b: &[u8]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:327:5 [INFO] [stdout] | [INFO] [stdout] 327 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return result; [INFO] [stdout] 327 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | result.push(&entry); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return result; [INFO] [stdout] 340 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.93s [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 356 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return None; [INFO] [stdout] 356 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return HuffmanTree { trunk }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return HuffmanTree { trunk }; [INFO] [stdout] 19 + HuffmanTree { trunk } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return tree; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return tree; [INFO] [stdout] 26 + tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return frequencies; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return frequencies; [INFO] [stdout] 38 + frequencies [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | return decompressed; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 172 - return decompressed; [INFO] [stdout] 172 + decompressed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `left_char` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:201:23 [INFO] [stdout] | [INFO] [stdout] 197 | if left_char.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = left_char` [INFO] [stdout] ... [INFO] [stdout] 201 | let left_char = left_char.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `right_char` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 211 | if right_char.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = right_char` [INFO] [stdout] ... [INFO] [stdout] 215 | let right_char = right_char.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return None; [INFO] [stdout] 75 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tree.left` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:231:10 [INFO] [stdout] | [INFO] [stdout] 225 | if tree.left.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &tree.left` [INFO] [stdout] ... [INFO] [stdout] 231 | &tree.left.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tree.right` after checking its variant with `is_some` [INFO] [stdout] --> src/huffman_coding.rs:244:10 [INFO] [stdout] | [INFO] [stdout] 238 | if tree.right.is_some() { [INFO] [stdout] | ----------------------- help: try: `if let Some() = &tree.right` [INFO] [stdout] ... [INFO] [stdout] 244 | &tree.right.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | &tree.left.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tree.left.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:244:9 [INFO] [stdout] | [INFO] [stdout] 244 | &tree.right.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `tree.right.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:256:16 [INFO] [stdout] | [INFO] [stdout] 256 | return &pair; [INFO] [stdout] | ^^^^^ help: change this to: `pair` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:280:5 [INFO] [stdout] | [INFO] [stdout] 280 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return result; [INFO] [stdout] 280 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 291 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 291 - return result; [INFO] [stdout] 291 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 312 - return result; [INFO] [stdout] 312 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/huffman_coding.rs:295:33 [INFO] [stdout] | [INFO] [stdout] 295 | fn get_metadata_from_bytes(b: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 295 - fn get_metadata_from_bytes(b: &Vec) -> Vec { [INFO] [stdout] 295 + fn get_metadata_from_bytes(b: &[u8]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:327:5 [INFO] [stdout] | [INFO] [stdout] 327 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return result; [INFO] [stdout] 327 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/huffman_tree.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / for pair in pairs { [INFO] [stdout] 70 | | if pair.value == c { [INFO] [stdout] 71 | | return Some(pair); [INFO] [stdout] ... | [INFO] [stdout] 75 | | return None; [INFO] [stdout] | |________________^ help: replace with an iterator: `pairs.iter_mut().find(|pair| pair.value == c).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_coding.rs:323:21 [INFO] [stdout] | [INFO] [stdout] 323 | result.push(&entry); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | return left_frequency + right_frequency + char_frequency; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return left_frequency + right_frequency + char_frequency; [INFO] [stdout] 94 + left_frequency + right_frequency + char_frequency [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return result; [INFO] [stdout] 340 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_tree.rs:80:59 [INFO] [stdout] | [INFO] [stdout] 80 | Some(lnode) => Self::get_total_frequency_below_node(&lnode), [INFO] [stdout] | ^^^^^^ help: change this to: `lnode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_coding.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 356 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return None; [INFO] [stdout] 356 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return HuffmanTree { trunk }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return HuffmanTree { trunk }; [INFO] [stdout] 19 + HuffmanTree { trunk } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return tree; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return tree; [INFO] [stdout] 26 + tree [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return frequencies; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return frequencies; [INFO] [stdout] 38 + frequencies [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_tree.rs:85:59 [INFO] [stdout] | [INFO] [stdout] 85 | Some(rnode) => Self::get_total_frequency_below_node(&rnode), [INFO] [stdout] | ^^^^^^ help: change this to: `rnode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return None; [INFO] [stdout] 75 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/huffman_tree.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / for pair in pairs { [INFO] [stdout] 70 | | if pair.value == c { [INFO] [stdout] 71 | | return Some(pair); [INFO] [stdout] ... | [INFO] [stdout] 75 | | return None; [INFO] [stdout] | |________________^ help: replace with an iterator: `pairs.iter_mut().find(|pair| pair.value == c).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/huffman_tree.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | ) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | return left_frequency + right_frequency + char_frequency; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 94 - return left_frequency + right_frequency + char_frequency; [INFO] [stdout] 94 + left_frequency + right_frequency + char_frequency [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_tree.rs:80:59 [INFO] [stdout] | [INFO] [stdout] 80 | Some(lnode) => Self::get_total_frequency_below_node(&lnode), [INFO] [stdout] | ^^^^^^ help: change this to: `lnode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman_tree.rs:85:59 [INFO] [stdout] | [INFO] [stdout] 85 | Some(rnode) => Self::get_total_frequency_below_node(&rnode), [INFO] [stdout] | ^^^^^^ help: change this to: `rnode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | return queue[0].to_tree_node(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return queue[0].to_tree_node(); [INFO] [stdout] 162 + queue[0].to_tree_node() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/huffman_tree.rs:102:4 [INFO] [stdout] | [INFO] [stdout] 102 | ) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | return queue[0].to_tree_node(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return queue[0].to_tree_node(); [INFO] [stdout] 162 + queue[0].to_tree_node() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | / return HuffmanTreeNode { [INFO] [stdout] 203 | | left: match left { [INFO] [stdout] 204 | | Some(lnode) => Some(Box::new(lnode)), [INFO] [stdout] 205 | | None => None, [INFO] [stdout] ... | [INFO] [stdout] 211 | | value [INFO] [stdout] 212 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 ~ HuffmanTreeNode { [INFO] [stdout] 203 + left: match left { [INFO] [stdout] 204 + Some(lnode) => Some(Box::new(lnode)), [INFO] [stdout] 205 + None => None, [INFO] [stdout] 206 + }, [INFO] [stdout] 207 + right: match right { [INFO] [stdout] 208 + Some(rnode) => Some(Box::new(rnode)), [INFO] [stdout] 209 + None => None, [INFO] [stdout] 210 + }, [INFO] [stdout] 211 + value [INFO] [stdout] 212 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:185:41 [INFO] [stdout] | [INFO] [stdout] 185 | let left: Option = match &self.left { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 186 | | Some(lnode) => Some(lnode.to_tree_node()), [INFO] [stdout] 187 | | None => None, [INFO] [stdout] 188 | | }; [INFO] [stdout] | |_____^ help: try: `self.left.as_ref().map(|lnode| lnode.to_tree_node())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:191:42 [INFO] [stdout] | [INFO] [stdout] 191 | let right: Option = match &self.right { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 192 | | Some(rnode) => Some(rnode.to_tree_node()), [INFO] [stdout] 193 | | None => None, [INFO] [stdout] 194 | | }; [INFO] [stdout] | |_____^ help: try: `self.right.as_ref().map(|rnode| rnode.to_tree_node())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:197:31 [INFO] [stdout] | [INFO] [stdout] 197 | let value: Option = match &self.value { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 198 | | Some(cf) => Some(cf.value), [INFO] [stdout] 199 | | None => None, [INFO] [stdout] 200 | | }; [INFO] [stdout] | |_____^ help: try: `self.value.as_ref().map(|cf| cf.value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman_tree.rs:202:5 [INFO] [stdout] | [INFO] [stdout] 202 | / return HuffmanTreeNode { [INFO] [stdout] 203 | | left: match left { [INFO] [stdout] 204 | | Some(lnode) => Some(Box::new(lnode)), [INFO] [stdout] 205 | | None => None, [INFO] [stdout] ... | [INFO] [stdout] 211 | | value [INFO] [stdout] 212 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 ~ HuffmanTreeNode { [INFO] [stdout] 203 + left: match left { [INFO] [stdout] 204 + Some(lnode) => Some(Box::new(lnode)), [INFO] [stdout] 205 + None => None, [INFO] [stdout] 206 + }, [INFO] [stdout] 207 + right: match right { [INFO] [stdout] 208 + Some(rnode) => Some(Box::new(rnode)), [INFO] [stdout] 209 + None => None, [INFO] [stdout] 210 + }, [INFO] [stdout] 211 + value [INFO] [stdout] 212 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:203:13 [INFO] [stdout] | [INFO] [stdout] 203 | left: match left { [INFO] [stdout] | _____________^ [INFO] [stdout] 204 | | Some(lnode) => Some(Box::new(lnode)), [INFO] [stdout] 205 | | None => None, [INFO] [stdout] 206 | | }, [INFO] [stdout] | |_______^ help: try: `left.map(Box::new)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:185:41 [INFO] [stdout] | [INFO] [stdout] 185 | let left: Option = match &self.left { [INFO] [stdout] | _________________________________________^ [INFO] [stdout] 186 | | Some(lnode) => Some(lnode.to_tree_node()), [INFO] [stdout] 187 | | None => None, [INFO] [stdout] 188 | | }; [INFO] [stdout] | |_____^ help: try: `self.left.as_ref().map(|lnode| lnode.to_tree_node())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:207:14 [INFO] [stdout] | [INFO] [stdout] 207 | right: match right { [INFO] [stdout] | ______________^ [INFO] [stdout] 208 | | Some(rnode) => Some(Box::new(rnode)), [INFO] [stdout] 209 | | None => None, [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_______^ help: try: `right.map(Box::new)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:191:42 [INFO] [stdout] | [INFO] [stdout] 191 | let right: Option = match &self.right { [INFO] [stdout] | __________________________________________^ [INFO] [stdout] 192 | | Some(rnode) => Some(rnode.to_tree_node()), [INFO] [stdout] 193 | | None => None, [INFO] [stdout] 194 | | }; [INFO] [stdout] | |_____^ help: try: `self.right.as_ref().map(|rnode| rnode.to_tree_node())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:197:31 [INFO] [stdout] | [INFO] [stdout] 197 | let value: Option = match &self.value { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 198 | | Some(cf) => Some(cf.value), [INFO] [stdout] 199 | | None => None, [INFO] [stdout] 200 | | }; [INFO] [stdout] | |_____^ help: try: `self.value.as_ref().map(|cf| cf.value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_sort.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | return values; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return values; [INFO] [stdout] 12 + values [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_sort.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::merge(a, b, condition); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Self::merge(a, b, condition); [INFO] [stdout] 17 + Self::merge(a, b, condition) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:203:13 [INFO] [stdout] | [INFO] [stdout] 203 | left: match left { [INFO] [stdout] | _____________^ [INFO] [stdout] 204 | | Some(lnode) => Some(Box::new(lnode)), [INFO] [stdout] 205 | | None => None, [INFO] [stdout] 206 | | }, [INFO] [stdout] | |_______^ help: try: `left.map(Box::new)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/huffman_tree.rs:207:14 [INFO] [stdout] | [INFO] [stdout] 207 | right: match right { [INFO] [stdout] | ______________^ [INFO] [stdout] 208 | | Some(rnode) => Some(Box::new(rnode)), [INFO] [stdout] 209 | | None => None, [INFO] [stdout] 210 | | }, [INFO] [stdout] | |_______^ help: try: `right.map(Box::new)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_sort.rs:12:7 [INFO] [stdout] | [INFO] [stdout] 12 | return values; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return values; [INFO] [stdout] 12 + values [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/merge_sort.rs:29:10 [INFO] [stdout] | [INFO] [stdout] 29 | if !(a_index < a.len()) && b_index < b.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(a_index >= a.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_sort.rs:17:7 [INFO] [stdout] | [INFO] [stdout] 17 | return Self::merge(a, b, condition); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return Self::merge(a, b, condition); [INFO] [stdout] 17 + Self::merge(a, b, condition) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/merge_sort.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | } else if !(b_index < b.len()) && a_index < a.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(b_index >= b.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_sort.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return merged; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return merged; [INFO] [stdout] 52 + merged [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/merge_sort.rs:29:10 [INFO] [stdout] | [INFO] [stdout] 29 | if !(a_index < a.len()) && b_index < b.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(a_index >= a.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/merge_sort.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | } else if !(b_index < b.len()) && a_index < a.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `(b_index >= b.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/merge_sort.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | return merged; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - return merged; [INFO] [stdout] 52 + merged [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return MetadataKeyValuePair { key, value }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return MetadataKeyValuePair { key, value }; [INFO] [stdout] 76 + MetadataKeyValuePair { key, value } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return MetadataKeyValuePair { key, value }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return MetadataKeyValuePair { key, value }; [INFO] [stdout] 76 + MetadataKeyValuePair { key, value } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return result; [INFO] [stdout] 117 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return result; [INFO] [stdout] 117 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | / return MetadataKeyValuePair { [INFO] [stdout] 122 | | key: START_METADATA, [INFO] [stdout] 123 | | value: 0, [INFO] [stdout] 124 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 ~ MetadataKeyValuePair { [INFO] [stdout] 122 + key: START_METADATA, [INFO] [stdout] 123 + value: 0, [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | / return MetadataKeyValuePair { [INFO] [stdout] 129 | | key: END_METADATA, [INFO] [stdout] 130 | | value: bits, [INFO] [stdout] 131 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 ~ MetadataKeyValuePair { [INFO] [stdout] 129 + key: END_METADATA, [INFO] [stdout] 130 + value: bits, [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | / return MetadataKeyValuePair { [INFO] [stdout] 199 | | key, [INFO] [stdout] 200 | | value, [INFO] [stdout] 201 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 ~ MetadataKeyValuePair { [INFO] [stdout] 199 + key, [INFO] [stdout] 200 + value, [INFO] [stdout] 201 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 121 | / return MetadataKeyValuePair { [INFO] [stdout] 122 | | key: START_METADATA, [INFO] [stdout] 123 | | value: 0, [INFO] [stdout] 124 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 ~ MetadataKeyValuePair { [INFO] [stdout] 122 + key: START_METADATA, [INFO] [stdout] 123 + value: 0, [INFO] [stdout] 124 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 128 | / return MetadataKeyValuePair { [INFO] [stdout] 129 | | key: END_METADATA, [INFO] [stdout] 130 | | value: bits, [INFO] [stdout] 131 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 ~ MetadataKeyValuePair { [INFO] [stdout] 129 + key: END_METADATA, [INFO] [stdout] 130 + value: bits, [INFO] [stdout] 131 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:198:5 [INFO] [stdout] | [INFO] [stdout] 198 | / return MetadataKeyValuePair { [INFO] [stdout] 199 | | key, [INFO] [stdout] 200 | | value, [INFO] [stdout] 201 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 198 ~ MetadataKeyValuePair { [INFO] [stdout] 199 + key, [INFO] [stdout] 200 + value, [INFO] [stdout] 201 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | return self.key & END_METADATA == END_METADATA; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return self.key & END_METADATA == END_METADATA; [INFO] [stdout] 206 + self.key & END_METADATA == END_METADATA [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | return self.key >= DICTIONARY_ENTRY && self.key <= MAX_DICTIONARY_ENTRY; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return self.key >= DICTIONARY_ENTRY && self.key <= MAX_DICTIONARY_ENTRY; [INFO] [stdout] 211 + self.key >= DICTIONARY_ENTRY && self.key <= MAX_DICTIONARY_ENTRY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | return self.key & END_METADATA == END_METADATA; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 206 - return self.key & END_METADATA == END_METADATA; [INFO] [stdout] 206 + self.key & END_METADATA == END_METADATA [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:271:7 [INFO] [stdout] | [INFO] [stdout] 271 | / return CharCodePair::new( [INFO] [stdout] 272 | | char::from_u32(char_value).unwrap(), [INFO] [stdout] 273 | | char_bits, [INFO] [stdout] 274 | | char_code, [INFO] [stdout] 275 | | ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 ~ CharCodePair::new( [INFO] [stdout] 272 + char::from_u32(char_value).unwrap(), [INFO] [stdout] 273 + char_bits, [INFO] [stdout] 274 + char_code, [INFO] [stdout] 275 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:211:5 [INFO] [stdout] | [INFO] [stdout] 211 | return self.key >= DICTIONARY_ENTRY && self.key <= MAX_DICTIONARY_ENTRY; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 211 - return self.key >= DICTIONARY_ENTRY && self.key <= MAX_DICTIONARY_ENTRY; [INFO] [stdout] 211 + self.key >= DICTIONARY_ENTRY && self.key <= MAX_DICTIONARY_ENTRY [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/metadata.rs:271:7 [INFO] [stdout] | [INFO] [stdout] 271 | / return CharCodePair::new( [INFO] [stdout] 272 | | char::from_u32(char_value).unwrap(), [INFO] [stdout] 273 | | char_bits, [INFO] [stdout] 274 | | char_code, [INFO] [stdout] 275 | | ); [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 ~ CharCodePair::new( [INFO] [stdout] 272 + char::from_u32(char_value).unwrap(), [INFO] [stdout] 273 + char_bits, [INFO] [stdout] 274 + char_code, [INFO] [stdout] 275 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:54:3 [INFO] [stdout] | [INFO] [stdout] 54 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return 0; [INFO] [stdout] 54 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:54:3 [INFO] [stdout] | [INFO] [stdout] 54 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - return 0; [INFO] [stdout] 54 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/main.rs:70:6 [INFO] [stdout] | [INFO] [stdout] 70 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/main.rs:70:6 [INFO] [stdout] | [INFO] [stdout] 70 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/main.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 92 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 96 | match file.write_all(&string.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `string.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/main.rs:92:6 [INFO] [stdout] | [INFO] [stdout] 92 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:96:24 [INFO] [stdout] | [INFO] [stdout] 96 | match file.write_all(&string.as_bytes()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `string.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "8a8da90b45bb77c87d224fa905810286d57e7172fb3683cf2d1751a592e10e71", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a8da90b45bb77c87d224fa905810286d57e7172fb3683cf2d1751a592e10e71", kill_on_drop: false }` [INFO] [stdout] 8a8da90b45bb77c87d224fa905810286d57e7172fb3683cf2d1751a592e10e71