[INFO] cloning repository https://github.com/edsion11/rust_leetcode [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/edsion11/rust_leetcode" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedsion11%2Frust_leetcode", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedsion11%2Frust_leetcode'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 31022e3e568fe406a9ed8f45dc2904909ed2bb90 [INFO] linting edsion11/rust_leetcode against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fedsion11%2Frust_leetcode" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/edsion11/rust_leetcode [INFO] finished tweaking git repo https://github.com/edsion11/rust_leetcode [INFO] tweaked toml for git repo https://github.com/edsion11/rust_leetcode written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/edsion11/rust_leetcode on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/edsion11/rust_leetcode already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf1debd47d13f0762bb717fe93539e8892443f6fdfb9f8cc9498c2a6befb9668 [INFO] running `Command { std: "docker" "start" "-a" "cf1debd47d13f0762bb717fe93539e8892443f6fdfb9f8cc9498c2a6befb9668", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf1debd47d13f0762bb717fe93539e8892443f6fdfb9f8cc9498c2a6befb9668", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf1debd47d13f0762bb717fe93539e8892443f6fdfb9f8cc9498c2a6befb9668", kill_on_drop: false }` [INFO] [stdout] cf1debd47d13f0762bb717fe93539e8892443f6fdfb9f8cc9498c2a6befb9668 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 130d333f9cff2a74fdf990ed3dc2d58ab57fcdc82be5fbfd3dadf239cff66564 [INFO] running `Command { std: "docker" "start" "-a" "130d333f9cff2a74fdf990ed3dc2d58ab57fcdc82be5fbfd3dadf239cff66564", kill_on_drop: false }` [INFO] [stderr] Checking rust_algorithm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self::leetcode_42::trap` [INFO] [stdout] --> src/native_solution/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub use self::leetcode_42::trap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_42::trap_dp` [INFO] [stdout] --> src/native_solution/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub use self::leetcode_42::trap_dp; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_42::trap_two_pointer` [INFO] [stdout] --> src/native_solution/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use self::leetcode_42::trap_two_pointer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_135::candy` [INFO] [stdout] --> src/native_solution/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub use self::leetcode_135::candy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_167::two_sum` [INFO] [stdout] --> src/native_solution/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub use self::leetcode_167::two_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_29::spiral_order` [INFO] [stdout] --> src/native_solution/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub use self::leetcode_29::spiral_order; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_316::remove_duplicate_letters` [INFO] [stdout] --> src/native_solution/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub use self::leetcode_316::remove_duplicate_letters; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_401::add_strings` [INFO] [stdout] --> src/native_solution/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub use self::leetcode_401::add_strings; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_406::reconstruct_queue` [INFO] [stdout] --> src/native_solution/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub use self::leetcode_406::reconstruct_queue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_413::number_of_arithmetic_slices` [INFO] [stdout] --> src/native_solution/mod.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub use self::leetcode_413::number_of_arithmetic_slices; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_435::erase_overlap_intervals` [INFO] [stdout] --> src/native_solution/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub use self::leetcode_435::erase_overlap_intervals; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_452::find_min_arrow_shots` [INFO] [stdout] --> src/native_solution/mod.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub use self::leetcode_452::find_min_arrow_shots; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_455::find_content_children` [INFO] [stdout] --> src/native_solution/mod.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub use self::leetcode_455::find_content_children; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_55::can_jump` [INFO] [stdout] --> src/native_solution/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub use self::leetcode_55::can_jump; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_605::can_place_flowers` [INFO] [stdout] --> src/native_solution/mod.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub use self::leetcode_605::can_place_flowers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_64::min_path_sum` [INFO] [stdout] --> src/native_solution/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub use self::leetcode_64::min_path_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_665::check_possibility` [INFO] [stdout] --> src/native_solution/mod.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | pub use self::leetcode_665::check_possibility; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_70::climb_stairs` [INFO] [stdout] --> src/native_solution/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | pub use self::leetcode_70::climb_stairs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_76::min_window` [INFO] [stdout] --> src/native_solution/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub use self::leetcode_76::min_window; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_763::partition_labels` [INFO] [stdout] --> src/native_solution/mod.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub use self::leetcode_763::partition_labels; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_88::merge` [INFO] [stdout] --> src/native_solution/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub use self::leetcode_88::merge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_887::super_egg_drop` [INFO] [stdout] --> src/native_solution/mod.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub use self::leetcode_887::super_egg_drop; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_894::all_possible_fbt` [INFO] [stdout] --> src/native_solution/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | pub use self::leetcode_894::all_possible_fbt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_99::recover_tree` [INFO] [stdout] --> src/native_solution/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub use self::leetcode_99::recover_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_33::search` [INFO] [stdout] --> src/native_solution/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub use self::leetcode_33::search; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_20::is_valid` [INFO] [stdout] --> src/native_solution/mod.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub use self::leetcode_20::is_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sorts/bucket_sort.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / /// Bucket sort from https://chercher.tech/rust/bucket-sort-rust [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | pub fn bucket_sort(arr: &mut [T], hasher: F) [INFO] [stdout] | ------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 2 - /// Bucket sort from https://chercher.tech/rust/bucket-sort-rust [INFO] [stdout] 2 + //! Bucket sort from https://chercher.tech/rust/bucket-sort-rust [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sorts/bucket_sort.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | / /// Bucket to store elements. [INFO] [stdout] 42 | | [INFO] [stdout] | |_^ [INFO] [stdout] 43 | struct Bucket { [INFO] [stdout] | ------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::three_way_string_quicksort::quick_sort` [INFO] [stdout] --> src/sorts/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use self::three_way_string_quicksort::quick_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::bucket_sort::bucket_sort` [INFO] [stdout] --> src/sorts/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use self::bucket_sort::bucket_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::quick_sort::quick_sort as other_quick_sort` [INFO] [stdout] --> src/sorts/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use self::quick_sort::quick_sort as other_quick_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::insert_sort::insert_sort` [INFO] [stdout] --> src/sorts/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use self::insert_sort::insert_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_42::trap` [INFO] [stdout] --> src/native_solution/mod.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | pub use self::leetcode_42::trap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_42::trap_dp` [INFO] [stdout] --> src/native_solution/mod.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub use self::leetcode_42::trap_dp; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_42::trap_two_pointer` [INFO] [stdout] --> src/native_solution/mod.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub use self::leetcode_42::trap_two_pointer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_135::candy` [INFO] [stdout] --> src/native_solution/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub use self::leetcode_135::candy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_167::two_sum` [INFO] [stdout] --> src/native_solution/mod.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | pub use self::leetcode_167::two_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_29::spiral_order` [INFO] [stdout] --> src/native_solution/mod.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | pub use self::leetcode_29::spiral_order; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_316::remove_duplicate_letters` [INFO] [stdout] --> src/native_solution/mod.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub use self::leetcode_316::remove_duplicate_letters; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_401::add_strings` [INFO] [stdout] --> src/native_solution/mod.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | pub use self::leetcode_401::add_strings; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_406::reconstruct_queue` [INFO] [stdout] --> src/native_solution/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub use self::leetcode_406::reconstruct_queue; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_413::number_of_arithmetic_slices` [INFO] [stdout] --> src/native_solution/mod.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | pub use self::leetcode_413::number_of_arithmetic_slices; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_435::erase_overlap_intervals` [INFO] [stdout] --> src/native_solution/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub use self::leetcode_435::erase_overlap_intervals; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_452::find_min_arrow_shots` [INFO] [stdout] --> src/native_solution/mod.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | pub use self::leetcode_452::find_min_arrow_shots; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_455::find_content_children` [INFO] [stdout] --> src/native_solution/mod.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | pub use self::leetcode_455::find_content_children; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_55::can_jump` [INFO] [stdout] --> src/native_solution/mod.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub use self::leetcode_55::can_jump; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_605::can_place_flowers` [INFO] [stdout] --> src/native_solution/mod.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub use self::leetcode_605::can_place_flowers; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_64::min_path_sum` [INFO] [stdout] --> src/native_solution/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | pub use self::leetcode_64::min_path_sum; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_665::check_possibility` [INFO] [stdout] --> src/native_solution/mod.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | pub use self::leetcode_665::check_possibility; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_70::climb_stairs` [INFO] [stdout] --> src/native_solution/mod.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | pub use self::leetcode_70::climb_stairs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_76::min_window` [INFO] [stdout] --> src/native_solution/mod.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub use self::leetcode_76::min_window; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_763::partition_labels` [INFO] [stdout] --> src/native_solution/mod.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | pub use self::leetcode_763::partition_labels; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_88::merge` [INFO] [stdout] --> src/native_solution/mod.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | pub use self::leetcode_88::merge; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_887::super_egg_drop` [INFO] [stdout] --> src/native_solution/mod.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | pub use self::leetcode_887::super_egg_drop; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_894::all_possible_fbt` [INFO] [stdout] --> src/native_solution/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | pub use self::leetcode_894::all_possible_fbt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_99::recover_tree` [INFO] [stdout] --> src/native_solution/mod.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | pub use self::leetcode_99::recover_tree; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_33::search` [INFO] [stdout] --> src/native_solution/mod.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub use self::leetcode_33::search; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::leetcode_20::is_valid` [INFO] [stdout] --> src/native_solution/mod.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | pub use self::leetcode_20::is_valid; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sorts/bucket_sort.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / /// Bucket sort from https://chercher.tech/rust/bucket-sort-rust [INFO] [stdout] 3 | | [INFO] [stdout] | |_^ [INFO] [stdout] 4 | pub fn bucket_sort(arr: &mut [T], hasher: F) [INFO] [stdout] | ------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 2 - /// Bucket sort from https://chercher.tech/rust/bucket-sort-rust [INFO] [stdout] 2 + //! Bucket sort from https://chercher.tech/rust/bucket-sort-rust [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/sorts/bucket_sort.rs:41:1 [INFO] [stdout] | [INFO] [stdout] 41 | / /// Bucket to store elements. [INFO] [stdout] 42 | | [INFO] [stdout] | |_^ [INFO] [stdout] 43 | struct Bucket { [INFO] [stdout] | ------------- the comment documents this struct [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::three_way_string_quicksort::quick_sort` [INFO] [stdout] --> src/sorts/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use self::three_way_string_quicksort::quick_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::bucket_sort::bucket_sort` [INFO] [stdout] --> src/sorts/mod.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub use self::bucket_sort::bucket_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::quick_sort::quick_sort as other_quick_sort` [INFO] [stdout] --> src/sorts/mod.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use self::quick_sort::quick_sort as other_quick_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::insert_sort::insert_sort` [INFO] [stdout] --> src/sorts/mod.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use self::insert_sort::insert_sort; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_135.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | candies[right - 1] = candies[right - 1] + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `candies[right - 1] += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_135.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | right = right - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `right -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/native_solution/leetcode_167.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /** [INFO] [stdout] 2 | | * [INFO] [stdout] 3 | | */ [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_29.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | if matrix.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matrix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/native_solution/leetcode_29.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | let mut left = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/native_solution/leetcode_29.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | let mut top = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:11:42 [INFO] [stdout] | [INFO] [stdout] 11 | num1.as_bytes()[i - 1] - '0' as u8 [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:18:42 [INFO] [stdout] | [INFO] [stdout] 18 | num2.as_bytes()[j - 1] - '0' as u8 [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | res.push(tmp % 10 + '0' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/native_solution/leetcode_401.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / if i > 0 { [INFO] [stdout] 27 | | i -= 1; [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ help: try: `i = i.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/native_solution/leetcode_401.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if j > 0 { [INFO] [stdout] 30 | | j -= 1; [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ help: try: `j = j.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | res.push('1' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'1'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_406.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return result; [INFO] [stdout] 17 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_406.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | if people.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `people.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_406.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return b[0].cmp(&a[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return b[0].cmp(&a[0]); [INFO] [stdout] 11 + b[0].cmp(&a[0]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_413.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | pre = pre + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pre += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_413.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | sum = sum + pre; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `sum += pre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_435.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return total; [INFO] [stdout] 20 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_435.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | if intervals.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `intervals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `_i` is only used to index `intervals` [INFO] [stdout] --> src/native_solution/leetcode_435.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | for _i in 1..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 13 - for _i in 1..len { [INFO] [stdout] 13 + for in intervals.iter().take(len).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_452.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return result; [INFO] [stdout] 13 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `_i` is only used to index `points` [INFO] [stdout] --> src/native_solution/leetcode_452.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | for _i in 1..points.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for _i in 1..points.len() { [INFO] [stdout] 7 + for in points.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_55.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return last_valid_index == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return last_valid_index == 0; [INFO] [stdout] 11 + last_valid_index == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_55.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | right = right - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `right -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_605.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return false; [INFO] [stdout] 19 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_665.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return true; [INFO] [stdout] 28 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/native_solution/leetcode_665.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | if flag == true { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_70.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return cur; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return cur; [INFO] [stdout] 30 + cur [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_76.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return String::new(); [INFO] [stdout] 44 + String::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_76.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return String::from(&s[begin..begin + minlen]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return String::from(&s[begin..begin + minlen]); [INFO] [stdout] 46 + String::from(&s[begin..begin + minlen]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_763.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return result; [INFO] [stdout] 17 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `min_path_sum` is never used [INFO] [stdout] --> src/native_solution/leetcode_64.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn min_path_sum(grid: Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/native_solution/leetcode_894.rs:3:12 [INFO] [stdout] | [INFO] [stdout] 3 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/native_solution/leetcode_894.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 9 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 10 | #[inline] [INFO] [stdout] 11 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `all_possible_fbt` is never used [INFO] [stdout] --> src/native_solution/leetcode_894.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn all_possible_fbt(mut n: i32) -> Vec>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TreeNode` is never constructed [INFO] [stdout] --> src/native_solution/leetcode_99.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct TreeNode { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/native_solution/leetcode_99.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl TreeNode { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 12 | #[inline] [INFO] [stdout] 13 | pub fn new(val: i32) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `recover_tree` is never used [INFO] [stdout] --> src/native_solution/leetcode_99.rs:23:8 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn recover_tree(_root: Option>>) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/native_solution/leetcode_99.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | #[warn(dead_code)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `trap` is never used [INFO] [stdout] --> src/native_solution/leetcode_42.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn trap(height: Vec) -> i32 { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `trap_dp` is never used [INFO] [stdout] --> src/native_solution/leetcode_42.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn trap_dp(height: Vec) -> i32 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `trap_two_pointer` is never used [INFO] [stdout] --> src/native_solution/leetcode_42.rs:52:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn trap_two_pointer(height: Vec) -> i32{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `search` is never used [INFO] [stdout] --> src/native_solution/leetcode_33.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn search(nums: Vec, target: i32) -> i32 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_valid` is never used [INFO] [stdout] --> src/native_solution/leetcode_20.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn is_valid(s: String) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bucket_sort` is never used [INFO] [stdout] --> src/sorts/bucket_sort.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn bucket_sort(arr: &mut [T], hasher: F) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Bucket` is never constructed [INFO] [stdout] --> src/sorts/bucket_sort.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | struct Bucket { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/sorts/bucket_sort.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 48 | impl Bucket { [INFO] [stdout] | ----------------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn new(hash: H, value: T) -> Bucket { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `quick_sort` is never used [INFO] [stdout] --> src/sorts/three_way_string_quicksort.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn quick_sort(arr: &mut Vec<&str>, lo: i32, hi: i32, d: i32) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `char_at` is never used [INFO] [stdout] --> src/sorts/three_way_string_quicksort.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn char_at(str: &str, i: i32) -> u8 { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `quick_sort` is never used [INFO] [stdout] --> src/sorts/quick_sort.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn quick_sort(arr: &mut [T]){ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `insert_sort` is never used [INFO] [stdout] --> src/sorts/insert_sort.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn insert_sort(arr: &mut [T]){ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shell_sort` is never used [INFO] [stdout] --> src/sorts/shell_sort.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn shell_sort(arr: &mut [T]) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/native_solution/leetcode_88.rs:2:52 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn merge(nums1: &mut Vec, _m: i32, nums2: &mut Vec, _n: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2 - pub fn merge(nums1: &mut Vec, _m: i32, nums2: &mut Vec, _n: i32) { [INFO] [stdout] 2 + pub fn merge(nums1: &mut Vec, _m: i32, nums2: &mut [i32], _n: i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/native_solution/leetcode_88.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | / for _i in 0..array.len() - 1 { [INFO] [stdout] 18 | | nums1[_i + 1] = array[_i] [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________________^ help: try replacing the loop by: `nums1[1..((array.len() - 1) + 1)].copy_from_slice(&array[..(array.len() - 1)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/native_solution/leetcode_88.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | let merge_nums = merge(&mut nums1, m, &mut nums2, n); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 32 ~ merge(&mut nums1, m, &mut nums2, n); [INFO] [stdout] 33 ~ println!("{:?}", ()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_135.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 20 | candies[right - 1] = candies[right - 1] + 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `candies[right - 1] += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_135.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | right = right - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `right -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/native_solution/leetcode_167.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / /** [INFO] [stdout] 2 | | * [INFO] [stdout] 3 | | */ [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/native_solution/leetcode_887.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | t as i32 [INFO] [stdout] | ^^^^^^^^ help: try: `t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_29.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | if matrix.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matrix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/native_solution/leetcode_29.rs:6:20 [INFO] [stdout] | [INFO] [stdout] 6 | let mut left = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/native_solution/leetcode_29.rs:8:19 [INFO] [stdout] | [INFO] [stdout] 8 | let mut top = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:11:42 [INFO] [stdout] | [INFO] [stdout] 11 | num1.as_bytes()[i - 1] - '0' as u8 [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:18:42 [INFO] [stdout] | [INFO] [stdout] 18 | num2.as_bytes()[j - 1] - '0' as u8 [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:25:29 [INFO] [stdout] | [INFO] [stdout] 25 | res.push(tmp % 10 + '0' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'0'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/native_solution/leetcode_99.rs:67:8 [INFO] [stdout] | [INFO] [stdout] 67 | while !r.is_none()||!queue.is_empty(){ [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `r.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/native_solution/leetcode_401.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 26 | / if i > 0 { [INFO] [stdout] 27 | | i -= 1; [INFO] [stdout] 28 | | } [INFO] [stdout] | |_________^ help: try: `i = i.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/native_solution/leetcode_401.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / if j > 0 { [INFO] [stdout] 30 | | j -= 1; [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ help: try: `j = j.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/native_solution/leetcode_401.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | res.push('1' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'1'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_406.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return result; [INFO] [stdout] 17 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_406.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | if people.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `people.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_406.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return b[0].cmp(&a[0]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return b[0].cmp(&a[0]); [INFO] [stdout] 11 + b[0].cmp(&a[0]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/native_solution/leetcode_99.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | let curval = item.as_ref().borrow().val.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `item.as_ref().borrow().val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/native_solution/leetcode_99.rs:83:18 [INFO] [stdout] | [INFO] [stdout] 83 | let preval = prev.as_ref().borrow().val.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `prev.as_ref().borrow().val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_42.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return result; [INFO] [stdout] 28 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_413.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | pre = pre + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pre += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_413.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | sum = sum + pre; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace it with: `sum += pre` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_435.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | return total; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 20 - return total; [INFO] [stdout] 20 + total [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_435.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | if intervals.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `intervals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `_i` is only used to index `intervals` [INFO] [stdout] --> src/native_solution/leetcode_435.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | for _i in 1..len { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 13 - for _i in 1..len { [INFO] [stdout] 13 + for in intervals.iter().take(len).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_452.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return result; [INFO] [stdout] 13 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `_i` is only used to index `points` [INFO] [stdout] --> src/native_solution/leetcode_452.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 7 | for _i in 1..points.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 7 - for _i in 1..points.len() { [INFO] [stdout] 7 + for in points.iter().skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_55.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return last_valid_index == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return last_valid_index == 0; [INFO] [stdout] 11 + last_valid_index == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/native_solution/leetcode_55.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | right = right - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `right -= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_605.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return false; [INFO] [stdout] 19 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_665.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return true; [INFO] [stdout] 28 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/native_solution/leetcode_20.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | if s.len()%2!=0{ [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `!s.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/native_solution/leetcode_665.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | if flag == true { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `flag` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/native_solution/leetcode_20.rs:12:40 [INFO] [stdout] | [INFO] [stdout] 12 | for (_,&str) in s.as_bytes().iter().enumerate(){ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 12 - for (_,&str) in s.as_bytes().iter().enumerate(){ [INFO] [stdout] 12 + for &str in s.as_bytes().iter(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_70.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return cur; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return cur; [INFO] [stdout] 30 + cur [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_20.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | stack.len()==0 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_76.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | return String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - return String::new(); [INFO] [stdout] 44 + String::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_76.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | return String::from(&s[begin..begin + minlen]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return String::from(&s[begin..begin + minlen]); [INFO] [stdout] 46 + String::from(&s[begin..begin + minlen]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used to substitute value for `Option::None` [INFO] [stdout] --> src/native_solution/leetcode_20.rs:38:15 [INFO] [stdout] | [INFO] [stdout] 38 | let pop = array.clone().pop().unwrap_or_else(|| 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `unwrap_or` instead [INFO] [stdout] | [INFO] [stdout] 38 - let pop = array.clone().pop().unwrap_or_else(|| 2); [INFO] [stdout] 38 + let pop = array.clone().pop().unwrap_or(2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/native_solution/leetcode_20.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(false, res); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(false, res); [INFO] [stdout] 40 + assert!(!res); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_763.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return result; [INFO] [stdout] 17 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sorts/bucket_sort.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | let hash = hasher(&value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/native_solution/leetcode_88.rs:2:52 [INFO] [stdout] | [INFO] [stdout] 2 | pub fn merge(nums1: &mut Vec, _m: i32, nums2: &mut Vec, _n: i32) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 2 - pub fn merge(nums1: &mut Vec, _m: i32, nums2: &mut Vec, _n: i32) { [INFO] [stdout] 2 + pub fn merge(nums1: &mut Vec, _m: i32, nums2: &mut [i32], _n: i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like you're manually copying between slices [INFO] [stdout] --> src/native_solution/leetcode_88.rs:17:17 [INFO] [stdout] | [INFO] [stdout] 17 | / for _i in 0..array.len() - 1 { [INFO] [stdout] 18 | | nums1[_i + 1] = array[_i] [INFO] [stdout] 19 | | } [INFO] [stdout] | |_________________^ help: try replacing the loop by: `nums1[1..((array.len() - 1) + 1)].copy_from_slice(&array[..(array.len() - 1)]);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stdout] = note: `#[warn(clippy::manual_memcpy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sorts/three_way_string_quicksort.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return str.as_bytes()[i as usize] as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return str.as_bytes()[i as usize] as u8; [INFO] [stdout] 32 + str.as_bytes()[i as usize] as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/sorts/three_way_string_quicksort.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | return str.as_bytes()[i as usize] as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str.as_bytes()[i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/native_solution/leetcode_887.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | t as i32 [INFO] [stdout] | ^^^^^^^^ help: try: `t` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/sorts/quick_sort.rs:32:36 [INFO] [stdout] | [INFO] [stdout] 32 | arr.swap(store_index as usize, privot as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `privot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/native_solution/leetcode_42.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return result; [INFO] [stdout] 28 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/native_solution/leetcode_20.rs:5:8 [INFO] [stdout] | [INFO] [stdout] 5 | if s.len()%2!=0{ [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `!s.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/native_solution/leetcode_20.rs:12:40 [INFO] [stdout] | [INFO] [stdout] 12 | for (_,&str) in s.as_bytes().iter().enumerate(){ [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 12 - for (_,&str) in s.as_bytes().iter().enumerate(){ [INFO] [stdout] 12 + for &str in s.as_bytes().iter(){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/native_solution/leetcode_20.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | stack.len()==0 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/sorts/bucket_sort.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | let hash = hasher(&value); [INFO] [stdout] | ^^^^^^ help: change this to: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sorts/three_way_string_quicksort.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | return str.as_bytes()[i as usize] as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return str.as_bytes()[i as usize] as u8; [INFO] [stdout] 32 + str.as_bytes()[i as usize] as u8 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u8` -> `u8`) [INFO] [stdout] --> src/sorts/three_way_string_quicksort.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | return str.as_bytes()[i as usize] as u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `str.as_bytes()[i as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/sorts/quick_sort.rs:32:36 [INFO] [stdout] | [INFO] [stdout] 32 | arr.swap(store_index as usize, privot as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `privot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s [INFO] running `Command { std: "docker" "inspect" "130d333f9cff2a74fdf990ed3dc2d58ab57fcdc82be5fbfd3dadf239cff66564", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "130d333f9cff2a74fdf990ed3dc2d58ab57fcdc82be5fbfd3dadf239cff66564", kill_on_drop: false }` [INFO] [stdout] 130d333f9cff2a74fdf990ed3dc2d58ab57fcdc82be5fbfd3dadf239cff66564