[INFO] cloning repository https://github.com/eddybruel/ungit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eddybruel/ungit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feddybruel%2Fungit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feddybruel%2Fungit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0b4dbc4e62f2f705166347b25f1b60c55235c3e9 [INFO] linting eddybruel/ungit against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feddybruel%2Fungit" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eddybruel/ungit [INFO] finished tweaking git repo https://github.com/eddybruel/ungit [INFO] tweaked toml for git repo https://github.com/eddybruel/ungit written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eddybruel/ungit on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eddybruel/ungit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jiff-tzdb-platform v0.1.2 [INFO] [stderr] Downloaded jiff-tzdb v0.1.3 [INFO] [stderr] Downloaded rustix v1.0.3 [INFO] [stderr] Downloaded jiff-static v0.2.4 [INFO] [stderr] Downloaded jiff v0.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba74f99ae1917a9e92ff1e5db5681fae6ecce9fb0b11c88302070d58652ad38a [INFO] running `Command { std: "docker" "start" "-a" "ba74f99ae1917a9e92ff1e5db5681fae6ecce9fb0b11c88302070d58652ad38a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba74f99ae1917a9e92ff1e5db5681fae6ecce9fb0b11c88302070d58652ad38a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba74f99ae1917a9e92ff1e5db5681fae6ecce9fb0b11c88302070d58652ad38a", kill_on_drop: false }` [INFO] [stdout] ba74f99ae1917a9e92ff1e5db5681fae6ecce9fb0b11c88302070d58652ad38a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45e6aed68aa61b3a32ff70462f6f503f118e1fe218dd2d7c3d02c3a5e3ca57e4 [INFO] running `Command { std: "docker" "start" "-a" "45e6aed68aa61b3a32ff70462f6f503f118e1fe218dd2d7c3d02c3a5e3ca57e4", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v1.0.3 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking once_cell v1.21.1 [INFO] [stderr] Compiling libc v0.2.171 [INFO] [stderr] Checking miniz_oxide v0.8.5 [INFO] [stderr] Checking jiff v0.2.4 [INFO] [stderr] Checking flate2 v1.1.0 [INFO] [stderr] Checking getrandom v0.3.2 [INFO] [stderr] Checking memmap2 v0.9.5 [INFO] [stderr] Checking bstr v1.11.3 [INFO] [stderr] Checking tempfile v3.19.0 [INFO] [stderr] Checking ungit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/ref_store.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | struct RefStoreInner { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 38 | path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RefStoreInner` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `old` and `new` are never read [INFO] [stdout] --> src/ref_store.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | struct Op { [INFO] [stdout] | -- fields in this struct [INFO] [stdout] 102 | old: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] 103 | new: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Op` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/ref_store.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 37 | struct RefStoreInner { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 38 | path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RefStoreInner` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `old` and `new` are never read [INFO] [stdout] --> src/ref_store.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | struct Op { [INFO] [stdout] | -- fields in this struct [INFO] [stdout] 102 | old: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] 103 | new: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Op` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/hash.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / Ok(Self::from_hex_bytes( [INFO] [stdout] 44 | | reader.read_bytes(kind.hex_len())?, [INFO] [stdout] 45 | | kind, [INFO] [stdout] 46 | | )?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 43 ~ Self::from_hex_bytes( [INFO] [stdout] 44 | reader.read_bytes(kind.hex_len())?, [INFO] [stdout] 45 | kind, [INFO] [stdout] 46 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Kind` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/hash.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub const fn len(self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/hash.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | / Ok(Self::from_hex_bytes( [INFO] [stdout] 44 | | reader.read_bytes(kind.hex_len())?, [INFO] [stdout] 45 | | kind, [INFO] [stdout] 46 | | )?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 43 ~ Self::from_hex_bytes( [INFO] [stdout] 44 | reader.read_bytes(kind.hex_len())?, [INFO] [stdout] 45 | kind, [INFO] [stdout] 46 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Kind` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/hash.rs:130:5 [INFO] [stdout] | [INFO] [stdout] 130 | pub const fn len(self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/hash.rs:161:67 [INFO] [stdout] | [INFO] [stdout] 161 | Builder::Sha1(hasher) => Hash::Sha1(hasher.finalize().try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `GenericArray, B0>, B1>, B0>, B0>>` to `[u8; 20]` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 161 - Builder::Sha1(hasher) => Hash::Sha1(hasher.finalize().try_into().unwrap()), [INFO] [stdout] 161 + Builder::Sha1(hasher) => Hash::Sha1(hasher.finalize().into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/hash.rs:161:67 [INFO] [stdout] | [INFO] [stdout] 161 | Builder::Sha1(hasher) => Hash::Sha1(hasher.finalize().try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `GenericArray, B0>, B1>, B0>, B0>>` to `[u8; 20]` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 161 - Builder::Sha1(hasher) => Hash::Sha1(hasher.finalize().try_into().unwrap()), [INFO] [stdout] 161 + Builder::Sha1(hasher) => Hash::Sha1(hasher.finalize().into()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/index.rs:108:52 [INFO] [stdout] | [INFO] [stdout] 108 | let path_len: usize = flags.path_len().try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u16` to `usize` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 108 - let path_len: usize = flags.path_len().try_into().unwrap(); [INFO] [stdout] 108 + let path_len: usize = flags.path_len().into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/index.rs:126:26 [INFO] [stdout] | [INFO] [stdout] 126 | writer.write_all(&self.oid.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.oid.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> src/index.rs:108:52 [INFO] [stdout] | [INFO] [stdout] 108 | let path_len: usize = flags.path_len().try_into().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `u16` to `usize` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 108 - let path_len: usize = flags.path_len().try_into().unwrap(); [INFO] [stdout] 108 + let path_len: usize = flags.path_len().into(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/index.rs:126:26 [INFO] [stdout] | [INFO] [stdout] 126 | writer.write_all(&self.oid.as_bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.oid.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/object_store.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 26 | writer.write_all(&object.content)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `object.content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/reader.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / let Some(count) = self.remaining_bytes().find_byte(byte) else { [INFO] [stdout] 54 | | return None; [INFO] [stdout] 55 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let count = self.remaining_bytes().find_byte(byte)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reader.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | if !reader.skip_bytes_until_found(byte).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reader.skip_bytes_until_found(byte).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/object_store.rs:26:26 [INFO] [stdout] | [INFO] [stdout] 26 | writer.write_all(&object.content)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `object.content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/reader.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 53 | / let Some(count) = self.remaining_bytes().find_byte(byte) else { [INFO] [stdout] 54 | | return None; [INFO] [stdout] 55 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let count = self.remaining_bytes().find_byte(byte)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ref_store.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if new.object_id().map_or(false, Hash::is_null) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 60 - if new.object_id().map_or(false, Hash::is_null) { [INFO] [stdout] 60 + if new.object_id().is_some_and(Hash::is_null) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/reader.rs:76:12 [INFO] [stdout] | [INFO] [stdout] 76 | if !reader.skip_bytes_until_found(byte).is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `reader.skip_bytes_until_found(byte).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ref_store.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if old [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | .as_ref() [INFO] [stdout] 73 | | .and_then(|old| old.object_id()) [INFO] [stdout] 74 | | .map_or(false, Hash::is_null) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 74 - .map_or(false, Hash::is_null) [INFO] [stdout] 74 + .is_some_and(Hash::is_null) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Writer` [INFO] [stdout] --> src/tree.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | content: Vec::new(), [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for Writer { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ref_store.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if new.object_id().map_or(false, Hash::is_null) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 60 - if new.object_id().map_or(false, Hash::is_null) { [INFO] [stdout] 60 + if new.object_id().is_some_and(Hash::is_null) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/ref_store.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if old [INFO] [stdout] | ____________^ [INFO] [stdout] 72 | | .as_ref() [INFO] [stdout] 73 | | .and_then(|old| old.object_id()) [INFO] [stdout] 74 | | .map_or(false, Hash::is_null) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 74 - .map_or(false, Hash::is_null) [INFO] [stdout] 74 + .is_some_and(Hash::is_null) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Writer` [INFO] [stdout] --> src/tree.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | Self { [INFO] [stdout] 16 | | content: Vec::new(), [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for Writer { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.18s [INFO] running `Command { std: "docker" "inspect" "45e6aed68aa61b3a32ff70462f6f503f118e1fe218dd2d7c3d02c3a5e3ca57e4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45e6aed68aa61b3a32ff70462f6f503f118e1fe218dd2d7c3d02c3a5e3ca57e4", kill_on_drop: false }` [INFO] [stdout] 45e6aed68aa61b3a32ff70462f6f503f118e1fe218dd2d7c3d02c3a5e3ca57e4