[INFO] cloning repository https://github.com/econia-labs/optivanity [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/econia-labs/optivanity" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feconia-labs%2Foptivanity", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feconia-labs%2Foptivanity'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 03ccd82a4b8c941cc91ea0d0a07035e15313a7c0 [INFO] linting econia-labs/optivanity against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feconia-labs%2Foptivanity" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/econia-labs/optivanity [INFO] finished tweaking git repo https://github.com/econia-labs/optivanity [INFO] tweaked toml for git repo https://github.com/econia-labs/optivanity written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/econia-labs/optivanity on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/econia-labs/optivanity already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zeroize v1.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e80acb740b41de5bcb1aac85e4de14bc5df9102392543d59f2b138df369d0f70 [INFO] running `Command { std: "docker" "start" "-a" "e80acb740b41de5bcb1aac85e4de14bc5df9102392543d59f2b138df369d0f70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e80acb740b41de5bcb1aac85e4de14bc5df9102392543d59f2b138df369d0f70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e80acb740b41de5bcb1aac85e4de14bc5df9102392543d59f2b138df369d0f70", kill_on_drop: false }` [INFO] [stdout] e80acb740b41de5bcb1aac85e4de14bc5df9102392543d59f2b138df369d0f70 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3081be2bc14cfeea639a0e147ee00722d7b2558dfb5d2d8ff46597e1c6d976e1 [INFO] running `Command { std: "docker" "start" "-a" "3081be2bc14cfeea639a0e147ee00722d7b2558dfb5d2d8ff46597e1c6d976e1", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling semver v1.0.22 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling platforms v3.4.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking zeroize v1.8.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling curve25519-dalek v4.1.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking ed25519-dalek v2.1.1 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking num v0.4.2 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking optivanity v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | if !args [INFO] [stdout] | _________^ [INFO] [stdout] 77 | | .prefix [INFO] [stdout] 78 | | .clone() [INFO] [stdout] 79 | | .map_or(true, |prefix| r.is_match(&prefix)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 79 - .map_or(true, |prefix| r.is_match(&prefix)) [INFO] [stdout] 79 + .is_none_or(|prefix| r.is_match(&prefix)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | if !args [INFO] [stdout] | _________^ [INFO] [stdout] 89 | | .suffix [INFO] [stdout] 90 | | .clone() [INFO] [stdout] 91 | | .map_or(true, |suffix| r.is_match(&suffix)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 91 - .map_or(true, |suffix| r.is_match(&suffix)) [INFO] [stdout] 91 + .is_none_or(|suffix| r.is_match(&suffix)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | if !(search_bytes[pb.len()] >> 4 == *pc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(search_bytes[pb.len()] >> 4 != *pc)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 208 | if !(search_bytes[search_bytes.len() - sb.len() - 1] & 0x0f == *sc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(search_bytes[search_bytes.len() - sb.len() - 1] & 0x0f != *sc)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 156 | (hex::decode(s[..s.len() - 1].to_string())?, Some(to_byte(c))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&s[..s.len() - 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:158:26 [INFO] [stdout] | [INFO] [stdout] 158 | (hex::decode(s.to_string())?, None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `&s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:168:26 [INFO] [stdout] | [INFO] [stdout] 168 | (hex::decode(s[1..].to_string())?, Some(to_byte(c))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `&s[1..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | (hex::decode(s.to_string())?, None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `&s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:259:32 [INFO] [stdout] | [INFO] [stdout] 259 | let n_guesses_needed = args.count.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `args.count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | if !args [INFO] [stdout] | _________^ [INFO] [stdout] 77 | | .prefix [INFO] [stdout] 78 | | .clone() [INFO] [stdout] 79 | | .map_or(true, |prefix| r.is_match(&prefix)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 79 - .map_or(true, |prefix| r.is_match(&prefix)) [INFO] [stdout] 79 + .is_none_or(|prefix| r.is_match(&prefix)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/main.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | if !args [INFO] [stdout] | _________^ [INFO] [stdout] 89 | | .suffix [INFO] [stdout] 90 | | .clone() [INFO] [stdout] 91 | | .map_or(true, |suffix| r.is_match(&suffix)) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 91 - .map_or(true, |suffix| r.is_match(&suffix)) [INFO] [stdout] 91 + .is_none_or(|suffix| r.is_match(&suffix)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:197:20 [INFO] [stdout] | [INFO] [stdout] 197 | if !(search_bytes[pb.len()] >> 4 == *pc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(search_bytes[pb.len()] >> 4 != *pc)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 208 | if !(search_bytes[search_bytes.len() - sb.len() - 1] & 0x0f == *sc) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(search_bytes[search_bytes.len() - sb.len() - 1] & 0x0f != *sc)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 156 | (hex::decode(s[..s.len() - 1].to_string())?, Some(to_byte(c))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `&s[..s.len() - 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:158:26 [INFO] [stdout] | [INFO] [stdout] 158 | (hex::decode(s.to_string())?, None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `&s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:168:26 [INFO] [stdout] | [INFO] [stdout] 168 | (hex::decode(s[1..].to_string())?, Some(to_byte(c))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: use: `&s[1..]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/main.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | (hex::decode(s.to_string())?, None) [INFO] [stdout] | ^^^^^^^^^^^^^ help: use: `&s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:259:32 [INFO] [stdout] | [INFO] [stdout] 259 | let n_guesses_needed = args.count.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `args.count` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.16s [INFO] running `Command { std: "docker" "inspect" "3081be2bc14cfeea639a0e147ee00722d7b2558dfb5d2d8ff46597e1c6d976e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3081be2bc14cfeea639a0e147ee00722d7b2558dfb5d2d8ff46597e1c6d976e1", kill_on_drop: false }` [INFO] [stdout] 3081be2bc14cfeea639a0e147ee00722d7b2558dfb5d2d8ff46597e1c6d976e1