[INFO] cloning repository https://github.com/ebalo55/crabby [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ebalo55/crabby" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Febalo55%2Fcrabby", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Febalo55%2Fcrabby'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 22f1592effe66c7b6ca4c71230c492864816f47a [INFO] linting ebalo55/crabby against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Febalo55%2Fcrabby" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ebalo55/crabby [INFO] finished tweaking git repo https://github.com/ebalo55/crabby [INFO] tweaked toml for git repo https://github.com/ebalo55/crabby written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ebalo55/crabby on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ebalo55/crabby already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zstd-safe v7.1.0 [INFO] [stderr] Downloaded zstd v0.13.1 [INFO] [stderr] Downloaded lzma-rs v0.3.0 [INFO] [stderr] Downloaded deflate64 v0.1.8 [INFO] [stderr] Downloaded jobserver v0.1.30 [INFO] [stderr] Downloaded zopfli v0.8.0 [INFO] [stderr] Downloaded rustls-pki-types v1.4.1 [INFO] [stderr] Downloaded cc v1.0.94 [INFO] [stderr] Downloaded zip v1.1.3 [INFO] [stderr] Downloaded fancy-regex v0.13.0 [INFO] [stderr] Downloaded zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Downloaded libz-ng-sys v1.1.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9dce897a71a2f9d4d29891daa358a01cd06ad60165ef330b34728d725d4df5b [INFO] running `Command { std: "docker" "start" "-a" "e9dce897a71a2f9d4d29891daa358a01cd06ad60165ef330b34728d725d4df5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9dce897a71a2f9d4d29891daa358a01cd06ad60165ef330b34728d725d4df5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9dce897a71a2f9d4d29891daa358a01cd06ad60165ef330b34728d725d4df5b", kill_on_drop: false }` [INFO] [stdout] e9dce897a71a2f9d4d29891daa358a01cd06ad60165ef330b34728d725d4df5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8427d28f5ec5a09972ff3ae6c04589c3820f484753bfc33cb8a7c52098d240e8 [INFO] running `Command { std: "docker" "start" "-a" "8427d28f5ec5a09972ff3ae6c04589c3820f484753bfc33cb8a7c52098d240e8", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling zstd-safe v7.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling jobserver v0.1.30 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling cc v1.0.94 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling zip v1.1.3 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling zstd-sys v2.0.10+zstd.1.5.6 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling libz-ng-sys v1.1.15 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Checking typed-arena v2.0.2 [INFO] [stderr] Checking lzma-rs v0.3.0 [INFO] [stderr] Checking zopfli v0.8.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking deflate64 v0.1.8 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking fancy-regex v0.13.0 [INFO] [stderr] Checking fern v0.6.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking zstd v0.13.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking crabby-webshell-generator v1.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/strategies/webshell/php_feature.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PhpFeature { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 8 | /// The path of the feature [INFO] [stdout] 9 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PhpFeature` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/generate_random_string.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 157 | let count = repeat_str.parse::().unwrap_or(1); [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 158 | [INFO] [stdout] 159 | count [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 | [INFO] [stdout] 159 ~ repeat_str.parse::().unwrap_or(1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/generate_random_string.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | repeat_str.push(next.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 235 | assert_eq!(result.chars().nth(0).unwrap().is_ascii_digit(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 235 - assert_eq!(result.chars().nth(0).unwrap().is_ascii_digit(), true); [INFO] [stdout] 235 + assert!(result.chars().nth(0).unwrap().is_ascii_digit()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/generate_random_string.rs:235:20 [INFO] [stdout] | [INFO] [stdout] 235 | assert_eq!(result.chars().nth(0).unwrap().is_ascii_digit(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `result.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 236 | assert_eq!(result.chars().nth(1).unwrap().is_ascii_digit(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 236 - assert_eq!(result.chars().nth(1).unwrap().is_ascii_digit(), true); [INFO] [stdout] 236 + assert!(result.chars().nth(1).unwrap().is_ascii_digit()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 237 | assert_eq!(result.chars().nth(2).unwrap().is_ascii_digit(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 237 - assert_eq!(result.chars().nth(2).unwrap().is_ascii_digit(), true); [INFO] [stdout] 237 + assert!(result.chars().nth(2).unwrap().is_ascii_digit()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:238:9 [INFO] [stdout] | [INFO] [stdout] 238 | assert_eq!(result.chars().nth(3).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 238 - assert_eq!(result.chars().nth(3).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] 238 + assert!(result.chars().nth(3).unwrap().is_ascii_alphabetic()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:239:9 [INFO] [stdout] | [INFO] [stdout] 239 | assert_eq!(result.chars().nth(4).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 239 - assert_eq!(result.chars().nth(4).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] 239 + assert!(result.chars().nth(4).unwrap().is_ascii_alphabetic()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:240:9 [INFO] [stdout] | [INFO] [stdout] 240 | assert_eq!(result.chars().nth(5).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 240 - assert_eq!(result.chars().nth(5).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] 240 + assert!(result.chars().nth(5).unwrap().is_ascii_alphabetic()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | assert_eq!(result.ends_with("{sample}"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 241 - assert_eq!(result.ends_with("{sample}"), true); [INFO] [stdout] 241 + assert!(result.ends_with("{sample}")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:247:9 [INFO] [stdout] | [INFO] [stdout] 247 | assert_eq!(result.chars().nth(0).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 247 - assert_eq!(result.chars().nth(0).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] 247 + assert!(result.chars().nth(0).unwrap().is_ascii_alphabetic()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/generate_random_string.rs:247:20 [INFO] [stdout] | [INFO] [stdout] 247 | assert_eq!(result.chars().nth(0).unwrap().is_ascii_alphabetic(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `result.chars().next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:248:9 [INFO] [stdout] | [INFO] [stdout] 248 | assert_eq!(result.chars().nth(1).unwrap().is_ascii_digit(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 248 - assert_eq!(result.chars().nth(1).unwrap().is_ascii_digit(), true); [INFO] [stdout] 248 + assert!(result.chars().nth(1).unwrap().is_ascii_digit()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/generate_random_string.rs:249:9 [INFO] [stdout] | [INFO] [stdout] 249 | assert_eq!(result.chars().nth(2).unwrap().is_ascii_digit(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 249 - assert_eq!(result.chars().nth(2).unwrap().is_ascii_digit(), true); [INFO] [stdout] 249 + assert!(result.chars().nth(2).unwrap().is_ascii_digit()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/cli_arguments.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub enum CliCommand { [INFO] [stdout] 24 | | /// Clone templates and exit. [INFO] [stdout] 25 | | /// [INFO] [stdout] 26 | | /// This will clone the templates from the repository and exit, useful for updating the templates or customizing them. [INFO] [stdout] 27 | | #[default] [INFO] [stdout] 28 | | Clone, [INFO] [stdout] | | ----- the second-largest variant carries no data at all [INFO] [stdout] ... | [INFO] [stdout] 36 | | Generate(CliGenerateArguments), [INFO] [stdout] | | ------------------------------ the largest variant contains at least 272 bytes [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 36 - Generate(CliGenerateArguments), [INFO] [stdout] 36 + Generate(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.php_args.template_version.to_string() [INFO] [stdout] .split("&") [INFO] [stdout] .collect::>().get(0)` [INFO] [stdout] --> src/strategies/webshell/php.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | / ... self.php_args.template_version.to_string() [INFO] [stdout] 205 | | ... .split("&") [INFO] [stdout] 206 | | ... .collect::>() [INFO] [stdout] 207 | | ... .get(0) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 ~ self.php_args.template_version.to_string() [INFO] [stdout] 205 ~ .split("&") [INFO] [stdout] 206 ~ .collect::>().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/strategies/webshell/php.rs:715:3 [INFO] [stdout] | [INFO] [stdout] 715 | / for capture in captures { [INFO] [stdout] 716 | | if let Ok(capture) = capture { [INFO] [stdout] 717 | | result.push(capture.get(1).unwrap().as_str().to_string()); [INFO] [stdout] 718 | | } [INFO] [stdout] 719 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/strategies/webshell/php.rs:716:4 [INFO] [stdout] | [INFO] [stdout] 716 | / if let Ok(capture) = capture { [INFO] [stdout] 717 | | result.push(capture.get(1).unwrap().as_str().to_string()); [INFO] [stdout] 718 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 715 ~ for capture in captures.flatten() { [INFO] [stdout] 716 ~ result.push(capture.get(1).unwrap().as_str().to_string()); [INFO] [stdout] 717 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/strategies/webshell/php.rs:757:13 [INFO] [stdout] | [INFO] [stdout] 757 | if let Some(_) = entry.file_name() { [INFO] [stdout] | -------^^^^^^^-------------------- help: try: `if entry.file_name().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/strategies/webshell/php_feature.rs:71:40 [INFO] [stdout] | [INFO] [stdout] 71 | fn compute_feature_name(feature_path: &PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 71 - fn compute_feature_name(feature_path: &PathBuf) -> String { [INFO] [stdout] 71 + fn compute_feature_name(feature_path: &Path) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:81:7 [INFO] [stdout] | [INFO] [stdout] 81 | if !args.security.username.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.security.username.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 84 | if !args.security.password.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.security.password.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:87:7 [INFO] [stdout] | [INFO] [stdout] 87 | if !args.security.salt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.security.salt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/strategies/webshell/php_feature.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct PhpFeature { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 8 | /// The path of the feature [INFO] [stdout] 9 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PhpFeature` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/generate_random_string.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 157 | let count = repeat_str.parse::().unwrap_or(1); [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 158 | [INFO] [stdout] 159 | count [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 157 ~ [INFO] [stdout] 158 | [INFO] [stdout] 159 ~ repeat_str.parse::().unwrap_or(1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `char` which implements the `Copy` trait [INFO] [stdout] --> src/generate_random_string.rs:152:25 [INFO] [stdout] | [INFO] [stdout] 152 | repeat_str.push(next.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/cli_arguments.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub enum CliCommand { [INFO] [stdout] 24 | | /// Clone templates and exit. [INFO] [stdout] 25 | | /// [INFO] [stdout] 26 | | /// This will clone the templates from the repository and exit, useful for updating the templates or customizing them. [INFO] [stdout] 27 | | #[default] [INFO] [stdout] 28 | | Clone, [INFO] [stdout] | | ----- the second-largest variant carries no data at all [INFO] [stdout] ... | [INFO] [stdout] 36 | | Generate(CliGenerateArguments), [INFO] [stdout] | | ------------------------------ the largest variant contains at least 272 bytes [INFO] [stdout] 37 | | } [INFO] [stdout] | |_^ the entire enum is at least 272 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 36 - Generate(CliGenerateArguments), [INFO] [stdout] 36 + Generate(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `self.php_args.template_version.to_string() [INFO] [stdout] .split("&") [INFO] [stdout] .collect::>().get(0)` [INFO] [stdout] --> src/strategies/webshell/php.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 204 | / ... self.php_args.template_version.to_string() [INFO] [stdout] 205 | | ... .split("&") [INFO] [stdout] 206 | | ... .collect::>() [INFO] [stdout] 207 | | ... .get(0) [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 204 ~ self.php_args.template_version.to_string() [INFO] [stdout] 205 ~ .split("&") [INFO] [stdout] 206 ~ .collect::>().first() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/strategies/webshell/php.rs:715:3 [INFO] [stdout] | [INFO] [stdout] 715 | / for capture in captures { [INFO] [stdout] 716 | | if let Ok(capture) = capture { [INFO] [stdout] 717 | | result.push(capture.get(1).unwrap().as_str().to_string()); [INFO] [stdout] 718 | | } [INFO] [stdout] 719 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/strategies/webshell/php.rs:716:4 [INFO] [stdout] | [INFO] [stdout] 716 | / if let Ok(capture) = capture { [INFO] [stdout] 717 | | result.push(capture.get(1).unwrap().as_str().to_string()); [INFO] [stdout] 718 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 715 ~ for capture in captures.flatten() { [INFO] [stdout] 716 ~ result.push(capture.get(1).unwrap().as_str().to_string()); [INFO] [stdout] 717 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/strategies/webshell/php.rs:757:13 [INFO] [stdout] | [INFO] [stdout] 757 | if let Some(_) = entry.file_name() { [INFO] [stdout] | -------^^^^^^^-------------------- help: try: `if entry.file_name().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/strategies/webshell/php_feature.rs:71:40 [INFO] [stdout] | [INFO] [stdout] 71 | fn compute_feature_name(feature_path: &PathBuf) -> String { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 71 - fn compute_feature_name(feature_path: &PathBuf) -> String { [INFO] [stdout] 71 + fn compute_feature_name(feature_path: &Path) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:81:7 [INFO] [stdout] | [INFO] [stdout] 81 | if !args.security.username.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.security.username.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:84:7 [INFO] [stdout] | [INFO] [stdout] 84 | if !args.security.password.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.security.password.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:87:7 [INFO] [stdout] | [INFO] [stdout] 87 | if !args.security.salt.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.security.salt.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 23s [INFO] running `Command { std: "docker" "inspect" "8427d28f5ec5a09972ff3ae6c04589c3820f484753bfc33cb8a7c52098d240e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8427d28f5ec5a09972ff3ae6c04589c3820f484753bfc33cb8a7c52098d240e8", kill_on_drop: false }` [INFO] [stdout] 8427d28f5ec5a09972ff3ae6c04589c3820f484753bfc33cb8a7c52098d240e8