[INFO] cloning repository https://github.com/eansearch/rust-eansearch [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eansearch/rust-eansearch" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feansearch%2Frust-eansearch", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feansearch%2Frust-eansearch'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 518c544fc5dd99100ea56f88610d994e509c4cd3 [INFO] linting eansearch/rust-eansearch against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Feansearch%2Frust-eansearch" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eansearch/rust-eansearch [INFO] finished tweaking git repo https://github.com/eansearch/rust-eansearch [INFO] tweaked toml for git repo https://github.com/eansearch/rust-eansearch written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eansearch/rust-eansearch on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 183 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.21.7 (available: v0.22.1) [INFO] [stderr] Adding reqwest v0.11.27 (available: v0.13.2) [INFO] [stderr] Adding serde_with v1.14.0 (available: v3.18.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded schannel v0.1.29 [INFO] [stderr] Downloaded engine v0.0.0 [INFO] [stderr] Downloaded openssl v0.10.76 [INFO] [stderr] Downloaded openssl-sys v0.9.112 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ba9b8e493e7f5cb209ea9b8ea014d3cdf60f9a91aa19e8f90df979a6814fa54a [INFO] running `Command { std: "docker" "start" "-a" "ba9b8e493e7f5cb209ea9b8ea014d3cdf60f9a91aa19e8f90df979a6814fa54a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ba9b8e493e7f5cb209ea9b8ea014d3cdf60f9a91aa19e8f90df979a6814fa54a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba9b8e493e7f5cb209ea9b8ea014d3cdf60f9a91aa19e8f90df979a6814fa54a", kill_on_drop: false }` [INFO] [stdout] ba9b8e493e7f5cb209ea9b8ea014d3cdf60f9a91aa19e8f90df979a6814fa54a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ea623da2484f0877086b2dc2a64fc15596fe957c9ad8b41ec357b64bd4dde8e [INFO] running `Command { std: "docker" "start" "-a" "1ea623da2484f0877086b2dc2a64fc15596fe957c9ad8b41ec357b64bd4dde8e", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Checking gimli v0.32.3 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking rustc-demangle v0.1.27 [INFO] [stderr] Checking ipnet v2.12.0 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking socket2 v0.6.3 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking tokio v1.50.0 [INFO] [stderr] Checking addr2line v0.25.1 [INFO] [stderr] Checking backtrace v0.3.76 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking engine v0.0.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking eansearch v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:116:92 [INFO] [stdout] | [INFO] [stdout] 116 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return Ok(resp.text()?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return Ok(resp.text()?); [INFO] [stdout] 177 + Ok(resp.text()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `api_error` after checking its variant with `is_ok` [INFO] [stdout] --> src/lib.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 193 | if api_error.is_ok() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = api_error` [INFO] [stdout] 194 | return Err(api_error.unwrap()[0].error.clone().into()); // API error [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:189:30 [INFO] [stdout] | [INFO] [stdout] 189 | return self.api_call_list(&url, tries + 1) [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `name` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:235:36 [INFO] [stdout] | [INFO] [stdout] 234 | if name.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = name` [INFO] [stdout] 235 | url = url + "&name=" + name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> src/lib.rs:116:24 [INFO] [stdout] | [INFO] [stdout] 116 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:116:92 [INFO] [stdout] | [INFO] [stdout] 116 | let base_url = String::from("https://api.ean-search.org/api?format=json&token=") + &token; [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | return Ok(resp.text()?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 - return Ok(resp.text()?); [INFO] [stdout] 177 + Ok(resp.text()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `api_error` after checking its variant with `is_ok` [INFO] [stdout] --> src/lib.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 193 | if api_error.is_ok() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = api_error` [INFO] [stdout] 194 | return Err(api_error.unwrap()[0].error.clone().into()); // API error [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:189:30 [INFO] [stdout] | [INFO] [stdout] 189 | return self.api_call_list(&url, tries + 1) [INFO] [stdout] | ^^^^ help: change this to: `url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `name` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:235:36 [INFO] [stdout] | [INFO] [stdout] 234 | if name.is_some() { [INFO] [stdout] | ----------------- help: try: `if let Some() = name` [INFO] [stdout] 235 | url = url + "&name=" + name.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | assert!(!product.unwrap().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product.unwrap().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/lib.rs:481:17 [INFO] [stdout] | [INFO] [stdout] 481 | assert!(checksum_ok.unwrap() == true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `checksum_ok.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/lib.rs:490:17 [INFO] [stdout] | [INFO] [stdout] 490 | assert!(checksum_ok.unwrap() == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!checksum_ok.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 27.53s [INFO] running `Command { std: "docker" "inspect" "1ea623da2484f0877086b2dc2a64fc15596fe957c9ad8b41ec357b64bd4dde8e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ea623da2484f0877086b2dc2a64fc15596fe957c9ad8b41ec357b64bd4dde8e", kill_on_drop: false }` [INFO] [stdout] 1ea623da2484f0877086b2dc2a64fc15596fe957c9ad8b41ec357b64bd4dde8e