[INFO] cloning repository https://github.com/eHammarstrom/GRB [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eHammarstrom/GRB" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FeHammarstrom%2FGRB", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FeHammarstrom%2FGRB'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 031ad52ede080a887e7f631e80cd1b350051047b [INFO] linting eHammarstrom/GRB against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FeHammarstrom%2FGRB" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eHammarstrom/GRB [INFO] finished tweaking git repo https://github.com/eHammarstrom/GRB [INFO] tweaked toml for git repo https://github.com/eHammarstrom/GRB written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eHammarstrom/GRB on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eHammarstrom/GRB already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d429e34fa2904cbf05768c93f5c36c4e4091ba8464a8489a60408f38fe816ac4 [INFO] running `Command { std: "docker" "start" "-a" "d429e34fa2904cbf05768c93f5c36c4e4091ba8464a8489a60408f38fe816ac4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d429e34fa2904cbf05768c93f5c36c4e4091ba8464a8489a60408f38fe816ac4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d429e34fa2904cbf05768c93f5c36c4e4091ba8464a8489a60408f38fe816ac4", kill_on_drop: false }` [INFO] [stdout] d429e34fa2904cbf05768c93f5c36c4e4091ba8464a8489a60408f38fe816ac4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e1939b7e4a74c033a99e9bf95f3416d5eb9f649f2379e275ae8582e27f672b1 [INFO] running `Command { std: "docker" "start" "-a" "1e1939b7e4a74c033a99e9bf95f3416d5eb9f649f2379e275ae8582e27f672b1", kill_on_drop: false }` [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking gamerboy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/gameboy_cpu.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | bus: bus, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `bus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu` [INFO] [stdout] --> src/gameboy_cpu_inst.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::cpu; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/gameboy_cpu.rs:292:13 [INFO] [stdout] | [INFO] [stdout] 292 | bus: bus, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `bus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::cpu` [INFO] [stdout] --> src/gameboy_cpu_inst.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::cpu; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/gameboy_gpu.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | fn read_byte(&self, addr: Self::Addr) -> Result> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/gameboy_gpu.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | addr: Self::Addr, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/gameboy_gpu.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | data: Self::Data, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time` [INFO] [stdout] --> src/gameboy_gpu.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn catchup(&mut self, time: CycleTime) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `mask` is never used [INFO] [stdout] --> src/gameboy_cpu.rs:97:14 [INFO] [stdout] | [INFO] [stdout] 87 | impl Flag { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 97 | const fn mask(self) -> u8 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gameboy_cpu.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | / dst <= overflow_mask && src >= overflow_mask [INFO] [stdout] 128 | | || dst <= overflow_mask && dst > overflow_mask - src [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 - dst <= overflow_mask && src >= overflow_mask [INFO] [stdout] 128 - || dst <= overflow_mask && dst > overflow_mask - src [INFO] [stdout] 127 + !(dst > overflow_mask || src < overflow_mask && dst <= overflow_mask - src) [INFO] [stdout] | [INFO] [stdout] 127 - dst <= overflow_mask && src >= overflow_mask [INFO] [stdout] 128 - || dst <= overflow_mask && dst > overflow_mask - src [INFO] [stdout] 127 + (dst > overflow_mask - src || src >= overflow_mask) && dst <= overflow_mask [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:177:23 [INFO] [stdout] | [INFO] [stdout] 177 | Reg::A => Ok(self.AF.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 177 ~ Reg::A => { [INFO] [stdout] 178 + self.AF.set_high(val); [INFO] [stdout] 179 + Ok(()) [INFO] [stdout] 180 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:178:23 [INFO] [stdout] | [INFO] [stdout] 178 | Reg::B => Ok(self.BC.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 178 ~ Reg::B => { [INFO] [stdout] 179 + self.BC.set_high(val); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] 181 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:179:23 [INFO] [stdout] | [INFO] [stdout] 179 | Reg::C => Ok(self.BC.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 179 ~ Reg::C => { [INFO] [stdout] 180 + self.BC.set_low(val); [INFO] [stdout] 181 + Ok(()) [INFO] [stdout] 182 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:180:23 [INFO] [stdout] | [INFO] [stdout] 180 | Reg::D => Ok(self.DE.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 180 ~ Reg::D => { [INFO] [stdout] 181 + self.DE.set_high(val); [INFO] [stdout] 182 + Ok(()) [INFO] [stdout] 183 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:181:23 [INFO] [stdout] | [INFO] [stdout] 181 | Reg::E => Ok(self.DE.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 181 ~ Reg::E => { [INFO] [stdout] 182 + self.DE.set_low(val); [INFO] [stdout] 183 + Ok(()) [INFO] [stdout] 184 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:182:23 [INFO] [stdout] | [INFO] [stdout] 182 | Reg::F => Ok(self.AF.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 182 ~ Reg::F => { [INFO] [stdout] 183 + self.AF.set_low(val); [INFO] [stdout] 184 + Ok(()) [INFO] [stdout] 185 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:183:23 [INFO] [stdout] | [INFO] [stdout] 183 | Reg::H => Ok(self.HL.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 183 ~ Reg::H => { [INFO] [stdout] 184 + self.HL.set_high(val); [INFO] [stdout] 185 + Ok(()) [INFO] [stdout] 186 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:184:23 [INFO] [stdout] | [INFO] [stdout] 184 | Reg::L => Ok(self.HL.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 184 ~ Reg::L => { [INFO] [stdout] 185 + self.HL.set_low(val); [INFO] [stdout] 186 + Ok(()) [INFO] [stdout] 187 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | Reg::AF => Ok(self.AF = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 193 ~ Reg::AF => { [INFO] [stdout] 194 + let _: () = self.AF = val.into(); [INFO] [stdout] 195 + Ok(()) [INFO] [stdout] 196 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 194 | Reg::BC => Ok(self.BC = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 194 ~ Reg::BC => { [INFO] [stdout] 195 + let _: () = self.BC = val.into(); [INFO] [stdout] 196 + Ok(()) [INFO] [stdout] 197 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:195:24 [INFO] [stdout] | [INFO] [stdout] 195 | Reg::DE => Ok(self.BC = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 195 ~ Reg::DE => { [INFO] [stdout] 196 + let _: () = self.BC = val.into(); [INFO] [stdout] 197 + Ok(()) [INFO] [stdout] 198 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 196 | Reg::HL => Ok(self.HL = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 196 ~ Reg::HL => { [INFO] [stdout] 197 + let _: () = self.HL = val.into(); [INFO] [stdout] 198 + Ok(()) [INFO] [stdout] 199 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:197:24 [INFO] [stdout] | [INFO] [stdout] 197 | Reg::SP => Ok(self.SP = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 197 ~ Reg::SP => { [INFO] [stdout] 198 + let _: () = self.SP = val.into(); [INFO] [stdout] 199 + Ok(()) [INFO] [stdout] 200 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:198:24 [INFO] [stdout] | [INFO] [stdout] 198 | Reg::PC => Ok(self.PC = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 198 ~ Reg::PC => { [INFO] [stdout] 199 + let _: () = self.PC = val.into(); [INFO] [stdout] 200 + Ok(()) [INFO] [stdout] 201 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLCA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | RLCA, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rlca` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | RRA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRCA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | RRCA, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rrca` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STOP` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | STOP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Stop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | RLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDI` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | LDI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DAA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | DAA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Daa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPL` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | CPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDD` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | LDD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SCF` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | SCF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Scf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CCF` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | CCF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ccf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HALT` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | HALT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Halt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUB` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | SUB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RET` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | RET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POP` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | POP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CALL` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | CALL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUSH` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | PUSH, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Push` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RST` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | RST, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PREFIX` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | PREFIX, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RETI` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | RETI, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Reti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDH` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | LDH, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldh` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDHL` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | LDHL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ldhl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/gameboy_gpu.rs:25:25 [INFO] [stdout] | [INFO] [stdout] 25 | fn read_byte(&self, addr: Self::Addr) -> Result> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `addr` [INFO] [stdout] --> src/gameboy_gpu.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | addr: Self::Addr, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_addr` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `data` [INFO] [stdout] --> src/gameboy_gpu.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | data: Self::Data, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_data` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `time` [INFO] [stdout] --> src/gameboy_gpu.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 39 | fn catchup(&mut self, time: CycleTime) {} [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/gameboy_cpu.rs:127:5 [INFO] [stdout] | [INFO] [stdout] 127 | / dst <= overflow_mask && src >= overflow_mask [INFO] [stdout] 128 | | || dst <= overflow_mask && dst > overflow_mask - src [INFO] [stdout] | |____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 127 - dst <= overflow_mask && src >= overflow_mask [INFO] [stdout] 128 - || dst <= overflow_mask && dst > overflow_mask - src [INFO] [stdout] 127 + !(dst > overflow_mask || src < overflow_mask && dst <= overflow_mask - src) [INFO] [stdout] | [INFO] [stdout] 127 - dst <= overflow_mask && src >= overflow_mask [INFO] [stdout] 128 - || dst <= overflow_mask && dst > overflow_mask - src [INFO] [stdout] 127 + (dst > overflow_mask - src || src >= overflow_mask) && dst <= overflow_mask [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:177:23 [INFO] [stdout] | [INFO] [stdout] 177 | Reg::A => Ok(self.AF.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] = note: `#[warn(clippy::unit_arg)]` on by default [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 177 ~ Reg::A => { [INFO] [stdout] 178 + self.AF.set_high(val); [INFO] [stdout] 179 + Ok(()) [INFO] [stdout] 180 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:178:23 [INFO] [stdout] | [INFO] [stdout] 178 | Reg::B => Ok(self.BC.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 178 ~ Reg::B => { [INFO] [stdout] 179 + self.BC.set_high(val); [INFO] [stdout] 180 + Ok(()) [INFO] [stdout] 181 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:179:23 [INFO] [stdout] | [INFO] [stdout] 179 | Reg::C => Ok(self.BC.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 179 ~ Reg::C => { [INFO] [stdout] 180 + self.BC.set_low(val); [INFO] [stdout] 181 + Ok(()) [INFO] [stdout] 182 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:180:23 [INFO] [stdout] | [INFO] [stdout] 180 | Reg::D => Ok(self.DE.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 180 ~ Reg::D => { [INFO] [stdout] 181 + self.DE.set_high(val); [INFO] [stdout] 182 + Ok(()) [INFO] [stdout] 183 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:181:23 [INFO] [stdout] | [INFO] [stdout] 181 | Reg::E => Ok(self.DE.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 181 ~ Reg::E => { [INFO] [stdout] 182 + self.DE.set_low(val); [INFO] [stdout] 183 + Ok(()) [INFO] [stdout] 184 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:182:23 [INFO] [stdout] | [INFO] [stdout] 182 | Reg::F => Ok(self.AF.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 182 ~ Reg::F => { [INFO] [stdout] 183 + self.AF.set_low(val); [INFO] [stdout] 184 + Ok(()) [INFO] [stdout] 185 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:183:23 [INFO] [stdout] | [INFO] [stdout] 183 | Reg::H => Ok(self.HL.set_high(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 183 ~ Reg::H => { [INFO] [stdout] 184 + self.HL.set_high(val); [INFO] [stdout] 185 + Ok(()) [INFO] [stdout] 186 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:184:23 [INFO] [stdout] | [INFO] [stdout] 184 | Reg::L => Ok(self.HL.set_low(val)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 184 ~ Reg::L => { [INFO] [stdout] 185 + self.HL.set_low(val); [INFO] [stdout] 186 + Ok(()) [INFO] [stdout] 187 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | Reg::AF => Ok(self.AF = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 193 ~ Reg::AF => { [INFO] [stdout] 194 + let _: () = self.AF = val.into(); [INFO] [stdout] 195 + Ok(()) [INFO] [stdout] 196 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:194:24 [INFO] [stdout] | [INFO] [stdout] 194 | Reg::BC => Ok(self.BC = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 194 ~ Reg::BC => { [INFO] [stdout] 195 + let _: () = self.BC = val.into(); [INFO] [stdout] 196 + Ok(()) [INFO] [stdout] 197 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:195:24 [INFO] [stdout] | [INFO] [stdout] 195 | Reg::DE => Ok(self.BC = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 195 ~ Reg::DE => { [INFO] [stdout] 196 + let _: () = self.BC = val.into(); [INFO] [stdout] 197 + Ok(()) [INFO] [stdout] 198 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:196:24 [INFO] [stdout] | [INFO] [stdout] 196 | Reg::HL => Ok(self.HL = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 196 ~ Reg::HL => { [INFO] [stdout] 197 + let _: () = self.HL = val.into(); [INFO] [stdout] 198 + Ok(()) [INFO] [stdout] 199 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:197:24 [INFO] [stdout] | [INFO] [stdout] 197 | Reg::SP => Ok(self.SP = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 197 ~ Reg::SP => { [INFO] [stdout] 198 + let _: () = self.SP = val.into(); [INFO] [stdout] 199 + Ok(()) [INFO] [stdout] 200 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: passing a unit value to a function [INFO] [stdout] --> src/gameboy_cpu.rs:198:24 [INFO] [stdout] | [INFO] [stdout] 198 | Reg::PC => Ok(self.PC = val.into()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stdout] help: move the expression in front of the call and replace it with the unit literal `()` [INFO] [stdout] | [INFO] [stdout] 198 ~ Reg::PC => { [INFO] [stdout] 199 + let _: () = self.PC = val.into(); [INFO] [stdout] 200 + Ok(()) [INFO] [stdout] 201 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NOP` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | NOP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Nop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADD` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | ADD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Add` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ADC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | ADC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Adc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | INC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Inc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DEC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | DEC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Dec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLCA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | RLCA, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rlca` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | RRA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rra` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RRCA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | RRCA, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Rrca` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STOP` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | STOP, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Stop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RLA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | RLA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rla` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDI` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | LDI, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DAA` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | DAA, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Daa` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CPL` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | CPL, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Cpl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDD` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 22 | LDD, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SCF` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | SCF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Scf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CCF` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | CCF, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Ccf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HALT` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | HALT, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Halt` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SUB` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | SUB, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sub` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SBC` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | SBC, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sbc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `AND` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | AND, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `And` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `XOR` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | XOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Xor` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RET` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | RET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POP` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | POP, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Pop` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CALL` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | CALL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Call` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUSH` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | PUSH, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Push` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RST` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | RST, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Rst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PREFIX` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | PREFIX, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Prefix` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `RETI` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | RETI, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Reti` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDH` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | LDH, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Ldh` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LDHL` contains a capitalized acronym [INFO] [stdout] --> src/gameboy_cpu_inst.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | LDHL, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Ldhl` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.71s [INFO] running `Command { std: "docker" "inspect" "1e1939b7e4a74c033a99e9bf95f3416d5eb9f649f2379e275ae8582e27f672b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e1939b7e4a74c033a99e9bf95f3416d5eb9f649f2379e275ae8582e27f672b1", kill_on_drop: false }` [INFO] [stdout] 1e1939b7e4a74c033a99e9bf95f3416d5eb9f649f2379e275ae8582e27f672b1