[INFO] cloning repository https://github.com/eFournierRobert/progression_cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/eFournierRobert/progression_cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FeFournierRobert%2Fprogression_cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FeFournierRobert%2Fprogression_cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5779722b5e026f3622c821c174d40461b804c108 [INFO] linting eFournierRobert/progression_cli against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FeFournierRobert%2Fprogression_cli" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/eFournierRobert/progression_cli [INFO] finished tweaking git repo https://github.com/eFournierRobert/progression_cli [INFO] tweaked toml for git repo https://github.com/eFournierRobert/progression_cli written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/eFournierRobert/progression_cli on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/eFournierRobert/progression_cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tempfile v3.18.0 [INFO] [stderr] Downloaded windows-registry v0.2.0 [INFO] [stderr] Downloaded reqwest v0.12.12 [INFO] [stderr] Downloaded rustls v0.23.23 [INFO] [stderr] Downloaded rustix v1.0.1 [INFO] [stderr] Downloaded tokio v1.44.0 [INFO] [stderr] Downloaded ring v0.17.13 [INFO] [stderr] Downloaded linux-raw-sys v0.9.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3a62a3fad1270b081c4d6960ae602d2ff5361ee344f7d85a81c5ecd2a67667a5 [INFO] running `Command { std: "docker" "start" "-a" "3a62a3fad1270b081c4d6960ae602d2ff5361ee344f7d85a81c5ecd2a67667a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3a62a3fad1270b081c4d6960ae602d2ff5361ee344f7d85a81c5ecd2a67667a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a62a3fad1270b081c4d6960ae602d2ff5361ee344f7d85a81c5ecd2a67667a5", kill_on_drop: false }` [INFO] [stdout] 3a62a3fad1270b081c4d6960ae602d2ff5361ee344f7d85a81c5ecd2a67667a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66f135042a4253fcae7a3f9cfe25651772d91b0b29f623c5c2f26402972c1bc4 [INFO] running `Command { std: "docker" "start" "-a" "66f135042a4253fcae7a3f9cfe25651772d91b0b29f623c5c2f26402972c1bc4", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.94 [INFO] [stderr] Compiling libc v0.2.170 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Checking litemap v0.7.5 [INFO] [stderr] Checking smallvec v1.14.0 [INFO] [stderr] Compiling cc v1.2.16 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Compiling openssl v0.10.71 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking bitflags v2.9.0 [INFO] [stderr] Compiling serde v1.0.218 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking http v1.2.0 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking log v0.4.26 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking anstyle v1.0.10 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking rustls-pki-types v1.11.0 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking colored v3.0.0 [INFO] [stderr] Checking anstream v0.6.18 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking indexmap v2.7.1 [INFO] [stderr] Checking rustls-pemfile v2.2.0 [INFO] [stderr] Compiling openssl-sys v0.9.106 [INFO] [stderr] Checking clap_builder v4.5.31 [INFO] [stderr] Compiling quote v1.0.39 [INFO] [stderr] Compiling syn v2.0.99 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking socket2 v0.5.8 [INFO] [stderr] Checking rtoolbox v0.0.2 [INFO] [stderr] Checking rpassword v7.3.1 [INFO] [stderr] Checking tokio v1.44.0 [INFO] [stderr] Checking clap v4.5.31 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.8 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.218 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking reqwest v0.12.12 [INFO] [stderr] Checking progression_cli v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/question/deserialize.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / match question { [INFO] [stdout] 14 | | Ok(question) => Ok(question), [INFO] [stdout] 15 | | Err(e) => Err(e), [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ help: replace it with: `question` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `auth_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/request.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 20 | if auth_result.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = auth_result` [INFO] [stdout] 21 | _auth = auth_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/question/request.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 39 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = result` [INFO] [stdout] ... [INFO] [stdout] 42 | let result = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/request.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(RequestError::QuestionRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(RequestError::QuestionRequestFail); [INFO] [stdout] 40 + Err(RequestError::QuestionRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/question/deserialize.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | / match question { [INFO] [stdout] 14 | | Ok(question) => Ok(question), [INFO] [stdout] 15 | | Err(e) => Err(e), [INFO] [stdout] 16 | | } [INFO] [stdout] | |_____^ help: replace it with: `question` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] = note: `#[warn(clippy::needless_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `auth_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/request.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 20 | if auth_result.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = auth_result` [INFO] [stdout] 21 | _auth = auth_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/question/request.rs:42:22 [INFO] [stdout] | [INFO] [stdout] 39 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = result` [INFO] [stdout] ... [INFO] [stdout] 42 | let result = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/request.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return Err(RequestError::QuestionRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return Err(RequestError::QuestionRequestFail); [INFO] [stdout] 40 + Err(RequestError::QuestionRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `question_uri` after checking its variant with `is_some` [INFO] [stdout] --> src/question/mod.rs:26:57 [INFO] [stdout] | [INFO] [stdout] 25 | if question_uri.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = question_uri` [INFO] [stdout] 26 | let question = match request::http_get_question(question_uri.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/question/mod.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if !folder_path.read_dir().unwrap().next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `folder_path.read_dir().unwrap().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `question_uri` after checking its variant with `is_some` [INFO] [stdout] --> src/question/mod.rs:26:57 [INFO] [stdout] | [INFO] [stdout] 25 | if question_uri.is_some() { [INFO] [stdout] | ------------------------- help: try: `if let Some() = question_uri` [INFO] [stdout] 26 | let question = match request::http_get_question(question_uri.unwrap()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `prog_cli` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/mod.rs:76:24 [INFO] [stdout] | [INFO] [stdout] 75 | if prog_cli.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = prog_cli` [INFO] [stdout] 76 | let mut file = prog_cli.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `enonce_file` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/mod.rs:88:24 [INFO] [stdout] | [INFO] [stdout] 87 | if enonce_file.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = enonce_file` [INFO] [stdout] 88 | let mut file = enonce_file.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/question/mod.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 56 | if !folder_path.read_dir().unwrap().next().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `folder_path.read_dir().unwrap().next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `prog_cli` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/mod.rs:76:24 [INFO] [stdout] | [INFO] [stdout] 75 | if prog_cli.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = prog_cli` [INFO] [stdout] 76 | let mut file = prog_cli.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `enonce_file` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/mod.rs:88:24 [INFO] [stdout] | [INFO] [stdout] 87 | if enonce_file.is_ok() { [INFO] [stdout] | ---------------------- help: try: `if let Ok() = enonce_file` [INFO] [stdout] 88 | let mut file = enonce_file.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/question/mod.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | / if lan == included.included_attributes.langage.as_ref().unwrap() { [INFO] [stdout] 126 | | match create_question_file(&included.included_attributes) { [INFO] [stdout] 127 | | Ok(_) => println!("Question file created"), [INFO] [stdout] 128 | | Err(e) => return Err(e), [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ "ebauche" [INFO] [stdout] 125 ~ if lan == included.included_attributes.langage.as_ref().unwrap() => { [INFO] [stdout] 126 | match create_question_file(&included.included_attributes) { [INFO] [stdout] ... [INFO] [stdout] 129 | } [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/question/mod.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | / if !included.included_attributes.caché.unwrap() { [INFO] [stdout] 134 | | match write_test_info_to_enonce_file( [INFO] [stdout] 135 | | &included.included_attributes, [INFO] [stdout] 136 | | test_num, [INFO] [stdout] ... | [INFO] [stdout] 141 | | test_num += 1; [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ "test" [INFO] [stdout] 133 ~ if !included.included_attributes.caché.unwrap() => { [INFO] [stdout] 134 | match write_test_info_to_enonce_file( [INFO] [stdout] ... [INFO] [stdout] 141 | test_num += 1; [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/question/mod.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | / if !included.included_attributes.caché.unwrap() { [INFO] [stdout] 153 | | match write_test_info_to_enonce_file( [INFO] [stdout] 154 | | &included.included_attributes, [INFO] [stdout] 155 | | test_num, [INFO] [stdout] ... | [INFO] [stdout] 160 | | test_num += 1; [INFO] [stdout] 161 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 151 ~ "test" [INFO] [stdout] 152 ~ if !included.included_attributes.caché.unwrap() => { [INFO] [stdout] 153 | match write_test_info_to_enonce_file( [INFO] [stdout] ... [INFO] [stdout] 160 | test_num += 1; [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/mod.rs:194:19 [INFO] [stdout] | [INFO] [stdout] 194 | Err(_) => return Err(FileCreationError::FailedToWriteTest), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - Err(_) => return Err(FileCreationError::FailedToWriteTest), [INFO] [stdout] 194 + Err(_) => Err(FileCreationError::FailedToWriteTest), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/question/mod.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/question/mod.rs:125:21 [INFO] [stdout] | [INFO] [stdout] 125 | / if lan == included.included_attributes.langage.as_ref().unwrap() { [INFO] [stdout] 126 | | match create_question_file(&included.included_attributes) { [INFO] [stdout] 127 | | Ok(_) => println!("Question file created"), [INFO] [stdout] 128 | | Err(e) => return Err(e), [INFO] [stdout] 129 | | } [INFO] [stdout] 130 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ "ebauche" [INFO] [stdout] 125 ~ if lan == included.included_attributes.langage.as_ref().unwrap() => { [INFO] [stdout] 126 | match create_question_file(&included.included_attributes) { [INFO] [stdout] ... [INFO] [stdout] 129 | } [INFO] [stdout] 130 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/question/mod.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | / if !included.included_attributes.caché.unwrap() { [INFO] [stdout] 134 | | match write_test_info_to_enonce_file( [INFO] [stdout] 135 | | &included.included_attributes, [INFO] [stdout] 136 | | test_num, [INFO] [stdout] ... | [INFO] [stdout] 141 | | test_num += 1; [INFO] [stdout] 142 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 132 ~ "test" [INFO] [stdout] 133 ~ if !included.included_attributes.caché.unwrap() => { [INFO] [stdout] 134 | match write_test_info_to_enonce_file( [INFO] [stdout] ... [INFO] [stdout] 141 | test_num += 1; [INFO] [stdout] 142 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `question_file` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/mod.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 214 | if question_file.is_ok() { [INFO] [stdout] | ------------------------ help: try: `if let Ok() = question_file` [INFO] [stdout] 215 | let mut file = question_file.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/mod.rs:219:23 [INFO] [stdout] | [INFO] [stdout] 219 | Err(_) => return Err(FileCreationError::FailedCreateQuestion), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 - Err(_) => return Err(FileCreationError::FailedCreateQuestion), [INFO] [stdout] 219 + Err(_) => Err(FileCreationError::FailedCreateQuestion), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/mod.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | return Err(FileCreationError::FailedCreateQuestion); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Err(FileCreationError::FailedCreateQuestion); [INFO] [stdout] 222 + Err(FileCreationError::FailedCreateQuestion) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/question/mod.rs:152:21 [INFO] [stdout] | [INFO] [stdout] 152 | / if !included.included_attributes.caché.unwrap() { [INFO] [stdout] 153 | | match write_test_info_to_enonce_file( [INFO] [stdout] 154 | | &included.included_attributes, [INFO] [stdout] 155 | | test_num, [INFO] [stdout] ... | [INFO] [stdout] 160 | | test_num += 1; [INFO] [stdout] 161 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 151 ~ "test" [INFO] [stdout] 152 ~ if !included.included_attributes.caché.unwrap() => { [INFO] [stdout] 153 | match write_test_info_to_enonce_file( [INFO] [stdout] ... [INFO] [stdout] 160 | test_num += 1; [INFO] [stdout] 161 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/question/mod.rs:229:35 [INFO] [stdout] | [INFO] [stdout] 229 | fn get_question_uri_from_url(url: &String) -> Option<&str> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 229 - fn get_question_uri_from_url(url: &String) -> Option<&str> { [INFO] [stdout] 229 + fn get_question_uri_from_url(url: &str) -> Option<&str> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/mod.rs:194:19 [INFO] [stdout] | [INFO] [stdout] 194 | Err(_) => return Err(FileCreationError::FailedToWriteTest), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 194 - Err(_) => return Err(FileCreationError::FailedToWriteTest), [INFO] [stdout] 194 + Err(_) => Err(FileCreationError::FailedToWriteTest), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `.write(true)` because there is `.append(true)` [INFO] [stdout] --> src/question/mod.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | .write(true) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove `.write(true)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ineffective_open_options [INFO] [stdout] = note: `#[warn(clippy::ineffective_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `question_file` after checking its variant with `is_ok` [INFO] [stdout] --> src/question/mod.rs:215:24 [INFO] [stdout] | [INFO] [stdout] 214 | if question_file.is_ok() { [INFO] [stdout] | ------------------------ help: try: `if let Ok() = question_file` [INFO] [stdout] 215 | let mut file = question_file.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/mod.rs:219:23 [INFO] [stdout] | [INFO] [stdout] 219 | Err(_) => return Err(FileCreationError::FailedCreateQuestion), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 - Err(_) => return Err(FileCreationError::FailedCreateQuestion), [INFO] [stdout] 219 + Err(_) => Err(FileCreationError::FailedCreateQuestion), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/question/mod.rs:222:9 [INFO] [stdout] | [INFO] [stdout] 222 | return Err(FileCreationError::FailedCreateQuestion); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 222 - return Err(FileCreationError::FailedCreateQuestion); [INFO] [stdout] 222 + Err(FileCreationError::FailedCreateQuestion) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/question/mod.rs:229:35 [INFO] [stdout] | [INFO] [stdout] 229 | fn get_question_uri_from_url(url: &String) -> Option<&str> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 229 - fn get_question_uri_from_url(url: &String) -> Option<&str> { [INFO] [stdout] 229 + fn get_question_uri_from_url(url: &str) -> Option<&str> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_answer/deserialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match submit_response { [INFO] [stdout] 13 | | Ok(submit_response) => Ok(submit_response), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `submit_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/submit_answer/request.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 60 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = result` [INFO] [stdout] ... [INFO] [stdout] 65 | let result = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/request.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 61 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/request.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 74 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/submit_answer/request.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 46 | get_api_url() + "avancement/" + &username + "/" + &uri + "/tentatives?include=resultats"; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_answer/serialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match ser_body { [INFO] [stdout] 13 | | Ok(body) => Ok(body), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `ser_body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `answer` after checking its variant with `is_ok` [INFO] [stdout] --> src/submit_answer/mod.rs:76:31 [INFO] [stdout] | [INFO] [stdout] 75 | if answer.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = answer` [INFO] [stdout] 76 | let mut answer_file = answer.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/mod.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Ok(()); [INFO] [stdout] 112 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/mod.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | Err(_) => return Err(FileCreationError::FailedCreateAnswer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - Err(_) => return Err(FileCreationError::FailedCreateAnswer), [INFO] [stdout] 114 + Err(_) => Err(FileCreationError::FailedCreateAnswer), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/mod.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return Err(FileCreationError::FailedCreateAnswer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return Err(FileCreationError::FailedCreateAnswer); [INFO] [stdout] 117 + Err(FileCreationError::FailedCreateAnswer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_answer/deserialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match submit_response { [INFO] [stdout] 13 | | Ok(submit_response) => Ok(submit_response), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `submit_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/submit_answer/request.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 60 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = result` [INFO] [stdout] ... [INFO] [stdout] 65 | let result = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/request.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 61 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/request.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 74 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/submit_answer/request.rs:46:41 [INFO] [stdout] | [INFO] [stdout] 46 | get_api_url() + "avancement/" + &username + "/" + &uri + "/tentatives?include=resultats"; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `username` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_test/deserialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match deser_response { [INFO] [stdout] 13 | | Ok(response) => Ok(response), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `deser_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/submit_test/request.rs:68:22 [INFO] [stdout] | [INFO] [stdout] 63 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = result` [INFO] [stdout] ... [INFO] [stdout] 68 | let result = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/request.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 64 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_answer/serialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match ser_body { [INFO] [stdout] 13 | | Ok(body) => Ok(body), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `ser_body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/request.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 77 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/submit_test/request.rs:31:38 [INFO] [stdout] | [INFO] [stdout] 31 | let language = match get_langage(&file_type) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `answer` after checking its variant with `is_ok` [INFO] [stdout] --> src/submit_answer/mod.rs:76:31 [INFO] [stdout] | [INFO] [stdout] 75 | if answer.is_ok() { [INFO] [stdout] | ----------------- help: try: `if let Ok() = answer` [INFO] [stdout] 76 | let mut answer_file = answer.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/mod.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Ok(()); [INFO] [stdout] 112 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/mod.rs:114:23 [INFO] [stdout] | [INFO] [stdout] 114 | Err(_) => return Err(FileCreationError::FailedCreateAnswer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - Err(_) => return Err(FileCreationError::FailedCreateAnswer), [INFO] [stdout] 114 + Err(_) => Err(FileCreationError::FailedCreateAnswer), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_answer/mod.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return Err(FileCreationError::FailedCreateAnswer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return Err(FileCreationError::FailedCreateAnswer); [INFO] [stdout] 117 + Err(FileCreationError::FailedCreateAnswer) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_test/serialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match ser_body { [INFO] [stdout] 13 | | Ok(body) => Ok(body), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `ser_body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_test/deserialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match deser_response { [INFO] [stdout] 13 | | Ok(response) => Ok(response), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `deser_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `test` after checking its variant with `is_ok` [INFO] [stdout] --> src/submit_test/mod.rs:76:29 [INFO] [stdout] | [INFO] [stdout] 75 | if test.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = test` [INFO] [stdout] 76 | let mut test_file = test.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/mod.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return Ok(()); [INFO] [stdout] 101 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/mod.rs:103:23 [INFO] [stdout] | [INFO] [stdout] 103 | Err(_) => return Err(FileCreationError::FailedToCreateTest), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - Err(_) => return Err(FileCreationError::FailedToCreateTest), [INFO] [stdout] 103 + Err(_) => Err(FileCreationError::FailedToCreateTest), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/mod.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Err(FileCreationError::FailedToCreateTest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Err(FileCreationError::FailedToCreateTest); [INFO] [stdout] 106 + Err(FileCreationError::FailedToCreateTest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `result` after checking its variant with `is_err` [INFO] [stdout] --> src/submit_test/request.rs:68:22 [INFO] [stdout] | [INFO] [stdout] 63 | if result.is_err() { [INFO] [stdout] | ------------------ help: try: `if let Ok() = result` [INFO] [stdout] ... [INFO] [stdout] 68 | let result = result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/request.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 64 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/request.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | return Err(RequestError::SubmitRequestFail); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 - return Err(RequestError::SubmitRequestFail); [INFO] [stdout] 77 + Err(RequestError::SubmitRequestFail) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/submit_test/request.rs:31:38 [INFO] [stdout] | [INFO] [stdout] 31 | let language = match get_langage(&file_type) { [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `file_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match expression is unnecessary [INFO] [stdout] --> src/submit_test/serialize.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / match ser_body { [INFO] [stdout] 13 | | Ok(body) => Ok(body), [INFO] [stdout] 14 | | Err(e) => Err(e), [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: replace it with: `ser_body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/utils.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | / if x == "question".to_string() { [INFO] [stdout] 84 | | let mut ret = HashMap::new(); [INFO] [stdout] 85 | | let filename = file_name.to_string_lossy().to_string(); [INFO] [stdout] ... | [INFO] [stdout] 93 | | return Ok(ret); [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ Some(x) [INFO] [stdout] 83 ~ if x == "question".to_string() => { [INFO] [stdout] 84 | let mut ret = HashMap::new(); [INFO] [stdout] ... [INFO] [stdout] 93 | return Ok(ret); [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `test` after checking its variant with `is_ok` [INFO] [stdout] --> src/submit_test/mod.rs:76:29 [INFO] [stdout] | [INFO] [stdout] 75 | if test.is_ok() { [INFO] [stdout] | --------------- help: try: `if let Ok() = test` [INFO] [stdout] 76 | let mut test_file = test.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | / match file_name.to_string_lossy().get(0..8) { [INFO] [stdout] 82 | | Some(x) => { [INFO] [stdout] 83 | | if x == "question".to_string() { [INFO] [stdout] 84 | | let mut ret = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 96 | | None => {} [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 81 ~ if let Some(x) = file_name.to_string_lossy().get(0..8) { [INFO] [stdout] 82 + if x == "question".to_string() { [INFO] [stdout] 83 + let mut ret = HashMap::new(); [INFO] [stdout] 84 + let filename = file_name.to_string_lossy().to_string(); [INFO] [stdout] 85 + [INFO] [stdout] 86 + ret.insert("filename".to_string(), filename.clone()); [INFO] [stdout] 87 + ret.insert( [INFO] [stdout] 88 + "filetype".to_string(), [INFO] [stdout] 89 + filename.get(8..filename.len()).unwrap().to_string(), [INFO] [stdout] 90 + ); [INFO] [stdout] 91 + [INFO] [stdout] 92 + return Ok(ret); [INFO] [stdout] 93 + } [INFO] [stdout] 94 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/mod.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 101 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return Ok(()); [INFO] [stdout] 101 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 83 | if x == "question".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `"question"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/mod.rs:103:23 [INFO] [stdout] | [INFO] [stdout] 103 | Err(_) => return Err(FileCreationError::FailedToCreateTest), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - Err(_) => return Err(FileCreationError::FailedToCreateTest), [INFO] [stdout] 103 + Err(_) => Err(FileCreationError::FailedToCreateTest), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/submit_test/mod.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return Err(FileCreationError::FailedToCreateTest); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return Err(FileCreationError::FailedToCreateTest); [INFO] [stdout] 106 + Err(FileCreationError::FailedToCreateTest) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/utils.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | let password = match rpassword::read_password() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 123 | | Ok(pass) => pass, [INFO] [stdout] 124 | | Err(e) => return Err(e), [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_____^ help: try instead: `rpassword::read_password()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - println!("{}", "Failed to create basic auth.".red().bold()); [INFO] [stdout] 142 - return; [INFO] [stdout] 141 + println!("{}", "Failed to create basic auth.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - println!("{}", "Failed to deserialize API response.".red().bold()); [INFO] [stdout] 146 - return; [INFO] [stdout] 145 + println!("{}", "Failed to deserialize API response.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - ); [INFO] [stdout] 153 - return; [INFO] [stdout] 152 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/utils.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | / if x == "question".to_string() { [INFO] [stdout] 84 | | let mut ret = HashMap::new(); [INFO] [stdout] 85 | | let filename = file_name.to_string_lossy().to_string(); [INFO] [stdout] ... | [INFO] [stdout] 93 | | return Ok(ret); [INFO] [stdout] 94 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 82 ~ Some(x) [INFO] [stdout] 83 ~ if x == "question".to_string() => { [INFO] [stdout] 84 | let mut ret = HashMap::new(); [INFO] [stdout] ... [INFO] [stdout] 93 | return Ok(ret); [INFO] [stdout] 94 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - ); [INFO] [stdout] 162 - return; [INFO] [stdout] 161 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 171 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 170 - ); [INFO] [stdout] 171 - return; [INFO] [stdout] 170 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 180 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - ); [INFO] [stdout] 180 - return; [INFO] [stdout] 179 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - println!("{}", "Couldn't get language from file type".red().bold()); [INFO] [stdout] 184 - return; [INFO] [stdout] 183 + println!("{}", "Couldn't get language from file type".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | / match file_name.to_string_lossy().get(0..8) { [INFO] [stdout] 82 | | Some(x) => { [INFO] [stdout] 83 | | if x == "question".to_string() { [INFO] [stdout] 84 | | let mut ret = HashMap::new(); [INFO] [stdout] ... | [INFO] [stdout] 96 | | None => {} [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 81 ~ if let Some(x) = file_name.to_string_lossy().get(0..8) { [INFO] [stdout] 82 + if x == "question".to_string() { [INFO] [stdout] 83 + let mut ret = HashMap::new(); [INFO] [stdout] 84 + let filename = file_name.to_string_lossy().to_string(); [INFO] [stdout] 85 + [INFO] [stdout] 86 + ret.insert("filename".to_string(), filename.clone()); [INFO] [stdout] 87 + ret.insert( [INFO] [stdout] 88 + "filetype".to_string(), [INFO] [stdout] 89 + filename.get(8..filename.len()).unwrap().to_string(), [INFO] [stdout] 90 + ); [INFO] [stdout] 91 + [INFO] [stdout] 92 + return Ok(ret); [INFO] [stdout] 93 + } [INFO] [stdout] 94 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils.rs:83:33 [INFO] [stdout] | [INFO] [stdout] 83 | if x == "question".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `"question"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/utils.rs:122:20 [INFO] [stdout] | [INFO] [stdout] 122 | let password = match rpassword::read_password() { [INFO] [stdout] | ____________________^ [INFO] [stdout] 123 | | Ok(pass) => pass, [INFO] [stdout] 124 | | Err(e) => return Err(e), [INFO] [stdout] 125 | | }; [INFO] [stdout] | |_____^ help: try instead: `rpassword::read_password()?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - println!("{}", "Failed to create .progcli.".red().bold()); [INFO] [stdout] 197 - return; [INFO] [stdout] 196 + println!("{}", "Failed to create .progcli.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - println!("{}", "Failed to create enonce.md file.".red().bold()); [INFO] [stdout] 201 - return; [INFO] [stdout] 200 + println!("{}", "Failed to create enonce.md file.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - println!("{}", "Failed to create question file.".red().bold()); [INFO] [stdout] 205 - return; [INFO] [stdout] 204 + println!("{}", "Failed to create question file.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - println!("{}", "Failed to create folder for files.".red().bold()); [INFO] [stdout] 209 - return; [INFO] [stdout] 208 + println!("{}", "Failed to create folder for files.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - println!("{}", "Failed to create answer.md file.".red().bold()); [INFO] [stdout] 213 - return; [INFO] [stdout] 212 + println!("{}", "Failed to create answer.md file.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - println!("{}", "Failed to write test in enonce.md".red().bold()); [INFO] [stdout] 217 - return; [INFO] [stdout] 216 + println!("{}", "Failed to write test in enonce.md".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 225 - ); [INFO] [stdout] 226 - return; [INFO] [stdout] 225 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - println!("{}", "Failed to create test.md".red().bold()); [INFO] [stdout] 230 - return; [INFO] [stdout] 229 + println!("{}", "Failed to create test.md".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - println!("{}", "Failed to create basic auth.".red().bold()); [INFO] [stdout] 142 - return; [INFO] [stdout] 141 + println!("{}", "Failed to create basic auth.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 145 - println!("{}", "Failed to deserialize API response.".red().bold()); [INFO] [stdout] 146 - return; [INFO] [stdout] 145 + println!("{}", "Failed to deserialize API response.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - ); [INFO] [stdout] 153 - return; [INFO] [stdout] 152 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:162:13 [INFO] [stdout] | [INFO] [stdout] 162 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - ); [INFO] [stdout] 162 - return; [INFO] [stdout] 161 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:171:13 [INFO] [stdout] | [INFO] [stdout] 171 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 170 - ); [INFO] [stdout] 171 - return; [INFO] [stdout] 170 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:180:13 [INFO] [stdout] | [INFO] [stdout] 180 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 179 - ); [INFO] [stdout] 180 - return; [INFO] [stdout] 179 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 183 - println!("{}", "Couldn't get language from file type".red().bold()); [INFO] [stdout] 184 - return; [INFO] [stdout] 183 + println!("{}", "Couldn't get language from file type".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - println!("{}", "Could not find Question file".red().bold()); [INFO] [stdout] 243 - return; [INFO] [stdout] 242 + println!("{}", "Could not find Question file".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - println!("{}", "Could not read current directory".red().bold()); [INFO] [stdout] 247 - return; [INFO] [stdout] 246 + println!("{}", "Could not read current directory".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - ); [INFO] [stdout] 255 - return; [INFO] [stdout] 254 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:197:13 [INFO] [stdout] | [INFO] [stdout] 197 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - println!("{}", "Failed to create .progcli.".red().bold()); [INFO] [stdout] 197 - return; [INFO] [stdout] 196 + println!("{}", "Failed to create .progcli.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - println!("{}", "Failed to create enonce.md file.".red().bold()); [INFO] [stdout] 201 - return; [INFO] [stdout] 200 + println!("{}", "Failed to create enonce.md file.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:205:13 [INFO] [stdout] | [INFO] [stdout] 205 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - println!("{}", "Failed to create question file.".red().bold()); [INFO] [stdout] 205 - return; [INFO] [stdout] 204 + println!("{}", "Failed to create question file.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - println!("{}", "Failed to create folder for files.".red().bold()); [INFO] [stdout] 209 - return; [INFO] [stdout] 208 + println!("{}", "Failed to create folder for files.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - println!("{}", "Failed to create answer.md file.".red().bold()); [INFO] [stdout] 213 - return; [INFO] [stdout] 212 + println!("{}", "Failed to create answer.md file.".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:217:13 [INFO] [stdout] | [INFO] [stdout] 217 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 216 - println!("{}", "Failed to write test in enonce.md".red().bold()); [INFO] [stdout] 217 - return; [INFO] [stdout] 216 + println!("{}", "Failed to write test in enonce.md".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 225 - ); [INFO] [stdout] 226 - return; [INFO] [stdout] 225 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:230:13 [INFO] [stdout] | [INFO] [stdout] 230 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 229 - println!("{}", "Failed to create test.md".red().bold()); [INFO] [stdout] 230 - return; [INFO] [stdout] 229 + println!("{}", "Failed to create test.md".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:265:5 [INFO] [stdout] | [INFO] [stdout] 265 | / return match file_type.as_str() { [INFO] [stdout] 266 | | ".py" => Some(String::from("python")), [INFO] [stdout] 267 | | ".java" => Some(String::from("java")), [INFO] [stdout] 268 | | ".cs" => Some(String::from("c#")), [INFO] [stdout] ... | [INFO] [stdout] 272 | | _ => None, [INFO] [stdout] 273 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 ~ match file_type.as_str() { [INFO] [stdout] 266 + ".py" => Some(String::from("python")), [INFO] [stdout] 267 + ".java" => Some(String::from("java")), [INFO] [stdout] 268 + ".cs" => Some(String::from("c#")), [INFO] [stdout] 269 + ".rs" => Some(String::from("rust")), [INFO] [stdout] 270 + ".js" => Some(String::from("javascript")), [INFO] [stdout] 271 + ".kt" => Some(String::from("kotlin")), [INFO] [stdout] 272 + _ => None, [INFO] [stdout] 273 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:264:31 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn get_langage(file_type: &String) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 264 ~ pub fn get_langage(file_type: &str) -> Option { [INFO] [stdout] 265 ~ return match file_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:243:13 [INFO] [stdout] | [INFO] [stdout] 243 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - println!("{}", "Could not find Question file".red().bold()); [INFO] [stdout] 243 - return; [INFO] [stdout] 242 + println!("{}", "Could not find Question file".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 247 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - println!("{}", "Could not read current directory".red().bold()); [INFO] [stdout] 247 - return; [INFO] [stdout] 246 + println!("{}", "Could not read current directory".red().bold()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / match matches.get_one::("clone") { [INFO] [stdout] 49 | | Some(url) => question::clone(url, only_lang), [INFO] [stdout] 50 | | _ => {} [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(url) = matches.get_one::("clone") { question::clone(url, only_lang) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:255:13 [INFO] [stdout] | [INFO] [stdout] 255 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - ); [INFO] [stdout] 255 - return; [INFO] [stdout] 254 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / match matches.get_one::("submit_test") { [INFO] [stdout] 54 | | Some(test_num) => submit_test::submit_test(test_num), [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(test_num) = matches.get_one::("submit_test") { submit_test::submit_test(test_num) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils.rs:265:5 [INFO] [stdout] | [INFO] [stdout] 265 | / return match file_type.as_str() { [INFO] [stdout] 266 | | ".py" => Some(String::from("python")), [INFO] [stdout] 267 | | ".java" => Some(String::from("java")), [INFO] [stdout] 268 | | ".cs" => Some(String::from("c#")), [INFO] [stdout] ... | [INFO] [stdout] 272 | | _ => None, [INFO] [stdout] 273 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 265 ~ match file_type.as_str() { [INFO] [stdout] 266 + ".py" => Some(String::from("python")), [INFO] [stdout] 267 + ".java" => Some(String::from("java")), [INFO] [stdout] 268 + ".cs" => Some(String::from("c#")), [INFO] [stdout] 269 + ".rs" => Some(String::from("rust")), [INFO] [stdout] 270 + ".js" => Some(String::from("javascript")), [INFO] [stdout] 271 + ".kt" => Some(String::from("kotlin")), [INFO] [stdout] 272 + _ => None, [INFO] [stdout] 273 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:264:31 [INFO] [stdout] | [INFO] [stdout] 264 | pub fn get_langage(file_type: &String) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 264 ~ pub fn get_langage(file_type: &str) -> Option { [INFO] [stdout] 265 ~ return match file_type { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | / match matches.get_one::("clone") { [INFO] [stdout] 49 | | Some(url) => question::clone(url, only_lang), [INFO] [stdout] 50 | | _ => {} [INFO] [stdout] 51 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(url) = matches.get_one::("clone") { question::clone(url, only_lang) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | / match matches.get_one::("submit_test") { [INFO] [stdout] 54 | | Some(test_num) => submit_test::submit_test(test_num), [INFO] [stdout] 55 | | _ => {} [INFO] [stdout] 56 | | } [INFO] [stdout] | |_____^ help: try: `if let Some(test_num) = matches.get_one::("submit_test") { submit_test::submit_test(test_num) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.35s [INFO] running `Command { std: "docker" "inspect" "66f135042a4253fcae7a3f9cfe25651772d91b0b29f623c5c2f26402972c1bc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66f135042a4253fcae7a3f9cfe25651772d91b0b29f623c5c2f26402972c1bc4", kill_on_drop: false }` [INFO] [stdout] 66f135042a4253fcae7a3f9cfe25651772d91b0b29f623c5c2f26402972c1bc4