[INFO] cloning repository https://github.com/duckinator/sgs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/duckinator/sgs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fduckinator%2Fsgs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fduckinator%2Fsgs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ac7f64e0e3b310a9598596675072a461040f1b7a [INFO] linting duckinator/sgs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fduckinator%2Fsgs" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-2-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/duckinator/sgs [INFO] finished tweaking git repo https://github.com/duckinator/sgs [INFO] tweaked toml for git repo https://github.com/duckinator/sgs written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/duckinator/sgs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/duckinator/sgs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded speech-dispatcher-sys v0.7.0 [INFO] [stderr] Downloaded indexmap v2.0.1 [INFO] [stderr] Downloaded concurrent-queue v2.3.0 [INFO] [stderr] Downloaded ecolor v0.23.0 [INFO] [stderr] Downloaded nanoserde v0.1.35 [INFO] [stderr] Downloaded ab_glyph v0.2.22 [INFO] [stderr] Downloaded bindgen v0.68.1 [INFO] [stderr] Downloaded web-time v0.2.2 [INFO] [stderr] Downloaded async-signal v0.2.4 [INFO] [stderr] Downloaded event-listener v3.0.0 [INFO] [stderr] Downloaded async-executor v1.5.4 [INFO] [stderr] Downloaded egui-winit v0.23.0 [INFO] [stderr] Downloaded emath v0.23.0 [INFO] [stderr] Downloaded blocking v1.4.1 [INFO] [stderr] Downloaded nanoserde-derive v0.1.21 [INFO] [stderr] Downloaded oxilangtag v0.1.3 [INFO] [stderr] Downloaded tts v0.25.6 [INFO] [stderr] Downloaded tracing v0.1.39 [INFO] [stderr] Downloaded async-task v4.4.1 [INFO] [stderr] Downloaded epaint v0.23.0 [INFO] [stderr] Downloaded parking v2.1.1 [INFO] [stderr] Downloaded egui v0.23.0 [INFO] [stderr] Downloaded speech-dispatcher v0.16.0 [INFO] [stderr] Downloaded eframe v0.23.0 [INFO] [stderr] Downloaded egui_glow v0.23.0 [INFO] [stderr] Downloaded rustix v0.38.19 [INFO] [stderr] Downloaded dyn-clone v1.0.14 [INFO] [stderr] Downloaded rustix v0.37.25 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e002835dc1968d82288ef1ad3a768b11ce44d0b1b673a8f71a9be5daa704bd30 [INFO] running `Command { std: "docker" "start" "-a" "e002835dc1968d82288ef1ad3a768b11ce44d0b1b673a8f71a9be5daa704bd30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e002835dc1968d82288ef1ad3a768b11ce44d0b1b673a8f71a9be5daa704bd30", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e002835dc1968d82288ef1ad3a768b11ce44d0b1b673a8f71a9be5daa704bd30", kill_on_drop: false }` [INFO] [stdout] e002835dc1968d82288ef1ad3a768b11ce44d0b1b673a8f71a9be5daa704bd30 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b8c790ece669ee9382bc22b0900bc7c0ddca32b4e9db0f8a2bcb12649841397c [INFO] running `Command { std: "docker" "start" "-a" "b8c790ece669ee9382bc22b0900bc7c0ddca32b4e9db0f8a2bcb12649841397c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling serde v1.0.189 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling regex-syntax v0.7.5 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling indexmap v2.0.1 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Compiling winnow v0.5.15 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking parking v2.1.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling prettyplease v0.2.15 [INFO] [stderr] Compiling rustix v0.37.25 [INFO] [stderr] Compiling rustix v0.38.19 [INFO] [stderr] Compiling aho-corasick v1.1.1 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Checking async-task v4.4.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling bitflags v2.4.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling linux-raw-sys v0.4.10 [INFO] [stderr] Compiling async-trait v0.1.73 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Compiling home v0.5.5 [INFO] [stderr] Compiling bindgen v0.68.1 [INFO] [stderr] Checking ttf-parser v0.19.2 [INFO] [stderr] Checking async-executor v1.5.4 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking xcursor v0.3.4 [INFO] [stderr] Compiling regex-automata v0.3.8 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking xdg-home v1.0.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking owned_ttf_parser v0.19.0 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking ab_glyph v0.2.22 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Compiling regex v1.9.5 [INFO] [stderr] Compiling glutin_egl_sys v0.5.1 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking gethostname v0.2.3 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking x11rb-protocol v0.10.0 [INFO] [stderr] Compiling glutin v0.30.10 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking url v2.4.1 [INFO] [stderr] Checking fdeflate v0.3.0 [INFO] [stderr] Compiling glutin-winit v0.3.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking web-time v0.2.2 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking dyn-clone v1.0.14 [INFO] [stderr] Checking glow v0.12.3 [INFO] [stderr] Compiling tts v0.25.6 [INFO] [stderr] Checking webbrowser v0.8.12 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Checking oxilangtag v0.1.3 [INFO] [stderr] Compiling nanoserde-derive v0.1.21 [INFO] [stderr] Compiling serde_derive v1.0.189 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling enumflags2_derive v0.7.8 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling enumn v0.1.12 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Compiling serde_repr v0.1.16 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Checking tracing v0.1.39 [INFO] [stderr] Checking nanoserde v0.1.35 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Compiling zvariant_derive v3.15.0 [INFO] [stderr] Compiling zbus_macros v3.14.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling atspi-macros v0.2.0 [INFO] [stderr] Compiling dyn-clonable-impl v0.9.0 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking blocking v1.4.1 [INFO] [stderr] Checking dyn-clonable v0.9.0 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.3 [INFO] [stderr] Checking x11rb v0.10.1 [INFO] [stderr] Checking arboard v3.2.1 [INFO] [stderr] Compiling speech-dispatcher-sys v0.7.0 [INFO] [stderr] Checking enumflags2 v0.7.8 [INFO] [stderr] Checking accesskit v0.11.2 [INFO] [stderr] Checking ecolor v0.23.0 [INFO] [stderr] Checking emath v0.23.0 [INFO] [stderr] Checking zvariant v3.15.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking epaint v0.23.0 [INFO] [stderr] Checking speech-dispatcher v0.16.0 [INFO] [stderr] Checking accesskit_consumer v0.15.2 [INFO] [stderr] Checking zbus_names v2.6.0 [INFO] [stderr] Checking zbus v3.14.1 [INFO] [stderr] Checking egui v0.23.0 [INFO] [stderr] Checking egui_glow v0.23.0 [INFO] [stderr] Checking atspi v0.10.1 [INFO] [stderr] Checking smithay-clipboard v0.6.6 [INFO] [stderr] Checking accesskit_unix v0.5.2 [INFO] [stderr] Checking accesskit_winit v0.14.4 [INFO] [stderr] Checking egui-winit v0.23.0 [INFO] [stderr] Checking eframe v0.23.0 [INFO] [stderr] Checking sgs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the loop variable `row` is used to index `related` [INFO] [stdout] --> src/app.rs:246:40 [INFO] [stdout] | [INFO] [stdout] 246 | ... for row in 0..cmp::min(folder.rows, related.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 246 - for row in 0..cmp::min(folder.rows, related.len()) { [INFO] [stdout] 246 + for (row, ) in related.iter().enumerate().take(cmp::min(folder.rows, related.len())) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `row` is used to index `related` [INFO] [stdout] --> src/app.rs:246:40 [INFO] [stdout] | [INFO] [stdout] 246 | ... for row in 0..cmp::min(folder.rows, related.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 246 - for row in 0..cmp::min(folder.rows, related.len()) { [INFO] [stdout] 246 + for (row, ) in related.iter().enumerate().take(cmp::min(folder.rows, related.len())) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return btn.as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return btn.as_ref(); [INFO] [stdout] 41 + btn.as_ref() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return None; [INFO] [stdout] 43 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return btn.as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return btn.as_ref(); [INFO] [stdout] 63 + btn.as_ref() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return None; [INFO] [stdout] 65 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/system.rs:112:68 [INFO] [stdout] | [INFO] [stdout] 112 | let toplevel_name = folder_id.split("::").next().unwrap_or(&folder_id); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `folder_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/button.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Clone, Debug, DeJson, SerJson, PartialEq)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `DeJson` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/speech.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn default() -> Result> { [INFO] [stdout] 12 | | let tts = Tts::default()?; [INFO] [stdout] 13 | | [INFO] [stdout] 14 | | Ok(SpeechEngine { tts }) [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return btn.as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return btn.as_ref(); [INFO] [stdout] 41 + btn.as_ref() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return None; [INFO] [stdout] 43 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | return btn.as_ref(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return btn.as_ref(); [INFO] [stdout] 63 + btn.as_ref() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return None; [INFO] [stdout] 65 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/system.rs:112:68 [INFO] [stdout] | [INFO] [stdout] 112 | let toplevel_name = folder_id.split("::").next().unwrap_or(&folder_id); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `folder_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/system.rs:193:5 [INFO] [stdout] | [INFO] [stdout] 193 | assert_eq!(true, system.folders[0].toplevel); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 193 - assert_eq!(true, system.folders[0].toplevel); [INFO] [stdout] 193 + assert!(system.folders[0].toplevel); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/system.rs:194:5 [INFO] [stdout] | [INFO] [stdout] 194 | assert_eq!(true, system.folders[1].toplevel); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 194 - assert_eq!(true, system.folders[1].toplevel); [INFO] [stdout] 194 + assert!(system.folders[1].toplevel); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/system.rs:199:5 [INFO] [stdout] | [INFO] [stdout] 199 | assert_eq!(false, folder.immediate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 199 - assert_eq!(false, folder.immediate); [INFO] [stdout] 199 + assert!(!folder.immediate); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/system.rs:206:5 [INFO] [stdout] | [INFO] [stdout] 206 | assert_eq!(true, quick_folder.immediate); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 206 - assert_eq!(true, quick_folder.immediate); [INFO] [stdout] 206 + assert!(quick_folder.immediate); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> src/button.rs:4:24 [INFO] [stdout] | [INFO] [stdout] 4 | #[derive(Clone, Debug, DeJson, SerJson, PartialEq)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `DeJson` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 15 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 24 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 32 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 40 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 50 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/panel.rs:61:12 [INFO] [stdout] | [INFO] [stdout] 61 | if self.entries.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> src/speech.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / pub fn default() -> Result> { [INFO] [stdout] 12 | | let tts = Tts::default()?; [INFO] [stdout] 13 | | [INFO] [stdout] 14 | | Ok(SpeechEngine { tts }) [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 00s [INFO] running `Command { std: "docker" "inspect" "b8c790ece669ee9382bc22b0900bc7c0ddca32b4e9db0f8a2bcb12649841397c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b8c790ece669ee9382bc22b0900bc7c0ddca32b4e9db0f8a2bcb12649841397c", kill_on_drop: false }` [INFO] [stdout] b8c790ece669ee9382bc22b0900bc7c0ddca32b4e9db0f8a2bcb12649841397c