[INFO] cloning repository https://github.com/drumfreakk/align [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/drumfreakk/align" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrumfreakk%2Falign", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrumfreakk%2Falign'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 47fc8bf97c23f1f719d4dd2dc7f35dacb37a46cd [INFO] linting drumfreakk/align against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrumfreakk%2Falign" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/drumfreakk/align [INFO] finished tweaking git repo https://github.com/drumfreakk/align [INFO] tweaked toml for git repo https://github.com/drumfreakk/align written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/drumfreakk/align on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/drumfreakk/align already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 85a7ead41083dd1d1b91a9963c31bd90706a5ce9ff95febc3f2b82f7a4c44abe [INFO] running `Command { std: "docker" "start" "-a" "85a7ead41083dd1d1b91a9963c31bd90706a5ce9ff95febc3f2b82f7a4c44abe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "85a7ead41083dd1d1b91a9963c31bd90706a5ce9ff95febc3f2b82f7a4c44abe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "85a7ead41083dd1d1b91a9963c31bd90706a5ce9ff95febc3f2b82f7a4c44abe", kill_on_drop: false }` [INFO] [stdout] 85a7ead41083dd1d1b91a9963c31bd90706a5ce9ff95febc3f2b82f7a4c44abe [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 066e7c1ddbfaae65b0a7c17be6f44108cb9ef86455f0458c6ea394632be8b543 [INFO] running `Command { std: "docker" "start" "-a" "066e7c1ddbfaae65b0a7c17be6f44108cb9ef86455f0458c6ea394632be8b543", kill_on_drop: false }` [INFO] [stderr] Checking align v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the loop variable `j` is only used to index `classes` [INFO] [stdout] --> src/score.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | for j in 0..scores_array[0].len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 31 - for j in 0..scores_array[0].len(){ [INFO] [stdout] 31 + for in classes.iter().take(scores_array[0].len()){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/score.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | return Err(String::from(format!("Aligned gaps at position {}", i))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Aligned gaps at position {}", i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `out` [INFO] [stdout] --> src/align.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | for i in 0..out.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 61 - for i in 0..out.len() { [INFO] [stdout] 61 + for in &mut out { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/align.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if out.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Ok(()); [INFO] [stdout] 158 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:160:24 [INFO] [stdout] | [INFO] [stdout] 160 | Err(e) => return Err(e), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - Err(e) => return Err(e), [INFO] [stdout] 160 + Err(e) => Err(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | return Some(Ordering::Greater); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - return Some(Ordering::Greater); [INFO] [stdout] 200 + Some(Ordering::Greater) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | return Some(Ordering::Less); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Some(Ordering::Less); [INFO] [stdout] 202 + Some(Ordering::Less) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | return Some(Ordering::Greater); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Some(Ordering::Greater); [INFO] [stdout] 208 + Some(Ordering::Greater) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | return Some(Ordering::Less); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return Some(Ordering::Less); [INFO] [stdout] 210 + Some(Ordering::Less) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | return Some(Ordering::Equal); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Some(Ordering::Equal); [INFO] [stdout] 213 + Some(Ordering::Equal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:215:21 [INFO] [stdout] | [INFO] [stdout] 215 | return Some(Ordering::Greater); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return Some(Ordering::Greater); [INFO] [stdout] 215 + Some(Ordering::Greater) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 217 | return Some(Ordering::Less); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return Some(Ordering::Less); [INFO] [stdout] 217 + Some(Ordering::Less) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/align.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | / match classes { [INFO] [stdout] 232 | | Some(c) => { [INFO] [stdout] 233 | | for class in c { [INFO] [stdout] 234 | | if class.contains(a) && class.contains(b) { [INFO] [stdout] ... | [INFO] [stdout] 242 | | None => () [INFO] [stdout] 243 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 231 ~ if let Some(c) = classes { [INFO] [stdout] 232 + for class in c { [INFO] [stdout] 233 + if class.contains(a) && class.contains(b) { [INFO] [stdout] 234 + return AACompare{ [INFO] [stdout] 235 + equal: true, [INFO] [stdout] 236 + strictness: AAMatchType::Class, [INFO] [stdout] 237 + }; [INFO] [stdout] 238 + } [INFO] [stdout] 239 + } [INFO] [stdout] 240 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/align.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | if !(align_min.end < fix_min.start && align_max.start >= fix_max.end) && !substr.aligned { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(substr.aligned || align_min.end < fix_min.start && align_max.start >= fix_max.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 256 - print!("\n"); [INFO] [stdout] 256 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/align.rs:353:26 [INFO] [stdout] | [INFO] [stdout] 353 | fn display_pos_list(pos: &Vec, amount: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 353 - fn display_pos_list(pos: &Vec, amount: Option) { [INFO] [stdout] 353 + fn display_pos_list(pos: &[Position], amount: Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `pos` [INFO] [stdout] --> src/align.rs:359:14 [INFO] [stdout] | [INFO] [stdout] 359 | for i in 0..amount { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 359 - for i in 0..amount { [INFO] [stdout] 359 + for (i, ) in pos.iter().enumerate().take(amount) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - return Ok(()) [INFO] [stdout] 415 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:377:33 [INFO] [stdout] | [INFO] [stdout] 377 | Some(i) => res.push(write!(f, " (Score: {}):\n", i)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 377 - Some(i) => res.push(write!(f, " (Score: {}):\n", i)), [INFO] [stdout] 377 + Some(i) => res.push(writeln!(f, " (Score: {}):", i)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:378:33 [INFO] [stdout] | [INFO] [stdout] 378 | None => res.push(write!(f, ":\n")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 378 - None => res.push(write!(f, ":\n")), [INFO] [stdout] 378 + None => res.push(writeln!(f, ":")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:390:18 [INFO] [stdout] | [INFO] [stdout] 390 | res.push(write!(f, "\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 390 - res.push(write!(f, "\n")); [INFO] [stdout] 390 + res.push(writeln!(f)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:406:22 [INFO] [stdout] | [INFO] [stdout] 406 | res.push(write!(f, "\u{1b}[22m\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 406 - res.push(write!(f, "\u{1b}[22m\n")); [INFO] [stdout] 406 + res.push(writeln!(f, "\u{1b}[22m")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/align.rs:410:13 [INFO] [stdout] | [INFO] [stdout] 410 | / match r { [INFO] [stdout] 411 | | Err(e) => return Err(e), [INFO] [stdout] 412 | | _ => (), [INFO] [stdout] 413 | | }; [INFO] [stdout] | |_____________^ help: try: `if let Err(e) = r { return Err(e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `classes` [INFO] [stdout] --> src/score.rs:31:14 [INFO] [stdout] | [INFO] [stdout] 31 | for j in 0..scores_array[0].len(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 31 - for j in 0..scores_array[0].len(){ [INFO] [stdout] 31 + for in classes.iter().take(scores_array[0].len()){ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/score.rs:63:24 [INFO] [stdout] | [INFO] [stdout] 63 | return Err(String::from(format!("Aligned gaps at position {}", i))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("Aligned gaps at position {}", i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `out` [INFO] [stdout] --> src/align.rs:61:34 [INFO] [stdout] | [INFO] [stdout] 61 | for i in 0..out.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 61 - for i in 0..out.len() { [INFO] [stdout] 61 + for in &mut out { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/align.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if out.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:158:17 [INFO] [stdout] | [INFO] [stdout] 158 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Ok(()); [INFO] [stdout] 158 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:160:24 [INFO] [stdout] | [INFO] [stdout] 160 | Err(e) => return Err(e), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - Err(e) => return Err(e), [INFO] [stdout] 160 + Err(e) => Err(e), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:200:13 [INFO] [stdout] | [INFO] [stdout] 200 | return Some(Ordering::Greater); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 200 - return Some(Ordering::Greater); [INFO] [stdout] 200 + Some(Ordering::Greater) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | return Some(Ordering::Less); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return Some(Ordering::Less); [INFO] [stdout] 202 + Some(Ordering::Less) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | return Some(Ordering::Greater); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Some(Ordering::Greater); [INFO] [stdout] 208 + Some(Ordering::Greater) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | return Some(Ordering::Less); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 210 - return Some(Ordering::Less); [INFO] [stdout] 210 + Some(Ordering::Less) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 213 | return Some(Ordering::Equal); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 213 - return Some(Ordering::Equal); [INFO] [stdout] 213 + Some(Ordering::Equal) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:215:21 [INFO] [stdout] | [INFO] [stdout] 215 | return Some(Ordering::Greater); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return Some(Ordering::Greater); [INFO] [stdout] 215 + Some(Ordering::Greater) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:217:21 [INFO] [stdout] | [INFO] [stdout] 217 | return Some(Ordering::Less); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return Some(Ordering::Less); [INFO] [stdout] 217 + Some(Ordering::Less) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/align.rs:231:9 [INFO] [stdout] | [INFO] [stdout] 231 | / match classes { [INFO] [stdout] 232 | | Some(c) => { [INFO] [stdout] 233 | | for class in c { [INFO] [stdout] 234 | | if class.contains(a) && class.contains(b) { [INFO] [stdout] ... | [INFO] [stdout] 242 | | None => () [INFO] [stdout] 243 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 231 ~ if let Some(c) = classes { [INFO] [stdout] 232 + for class in c { [INFO] [stdout] 233 + if class.contains(a) && class.contains(b) { [INFO] [stdout] 234 + return AACompare{ [INFO] [stdout] 235 + equal: true, [INFO] [stdout] 236 + strictness: AAMatchType::Class, [INFO] [stdout] 237 + }; [INFO] [stdout] 238 + } [INFO] [stdout] 239 + } [INFO] [stdout] 240 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/align.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 303 | if !(align_min.end < fix_min.start && align_max.start >= fix_max.end) && !substr.aligned { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(substr.aligned || align_min.end < fix_min.start && align_max.start >= fix_max.end)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:256:5 [INFO] [stdout] | [INFO] [stdout] 256 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 256 - print!("\n"); [INFO] [stdout] 256 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/align.rs:353:26 [INFO] [stdout] | [INFO] [stdout] 353 | fn display_pos_list(pos: &Vec, amount: Option) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 353 - fn display_pos_list(pos: &Vec, amount: Option) { [INFO] [stdout] 353 + fn display_pos_list(pos: &[Position], amount: Option) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `pos` [INFO] [stdout] --> src/align.rs:359:14 [INFO] [stdout] | [INFO] [stdout] 359 | for i in 0..amount { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 359 - for i in 0..amount { [INFO] [stdout] 359 + for (i, ) in pos.iter().enumerate().take(amount) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/align.rs:415:9 [INFO] [stdout] | [INFO] [stdout] 415 | return Ok(()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - return Ok(()) [INFO] [stdout] 415 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:377:33 [INFO] [stdout] | [INFO] [stdout] 377 | Some(i) => res.push(write!(f, " (Score: {}):\n", i)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] = note: `#[warn(clippy::write_with_newline)]` on by default [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 377 - Some(i) => res.push(write!(f, " (Score: {}):\n", i)), [INFO] [stdout] 377 + Some(i) => res.push(writeln!(f, " (Score: {}):", i)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:378:33 [INFO] [stdout] | [INFO] [stdout] 378 | None => res.push(write!(f, ":\n")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 378 - None => res.push(write!(f, ":\n")), [INFO] [stdout] 378 + None => res.push(writeln!(f, ":")), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:390:18 [INFO] [stdout] | [INFO] [stdout] 390 | res.push(write!(f, "\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 390 - res.push(write!(f, "\n")); [INFO] [stdout] 390 + res.push(writeln!(f)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `write!()` with a format string that ends in a single newline [INFO] [stdout] --> src/align.rs:406:22 [INFO] [stdout] | [INFO] [stdout] 406 | res.push(write!(f, "\u{1b}[22m\n")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stdout] help: use `writeln!` instead [INFO] [stdout] | [INFO] [stdout] 406 - res.push(write!(f, "\u{1b}[22m\n")); [INFO] [stdout] 406 + res.push(writeln!(f, "\u{1b}[22m")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/align.rs:410:13 [INFO] [stdout] | [INFO] [stdout] 410 | / match r { [INFO] [stdout] 411 | | Err(e) => return Err(e), [INFO] [stdout] 412 | | _ => (), [INFO] [stdout] 413 | | }; [INFO] [stdout] | |_____________^ help: try: `if let Err(e) = r { return Err(e) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.28s [INFO] running `Command { std: "docker" "inspect" "066e7c1ddbfaae65b0a7c17be6f44108cb9ef86455f0458c6ea394632be8b543", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "066e7c1ddbfaae65b0a7c17be6f44108cb9ef86455f0458c6ea394632be8b543", kill_on_drop: false }` [INFO] [stdout] 066e7c1ddbfaae65b0a7c17be6f44108cb9ef86455f0458c6ea394632be8b543