[INFO] cloning repository https://github.com/drone-autopilot/tello-autopilot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/drone-autopilot/tello-autopilot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrone-autopilot%2Ftello-autopilot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrone-autopilot%2Ftello-autopilot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 01293d42c964094d6881d9d5c04fb25bc4da0aad [INFO] linting drone-autopilot/tello-autopilot against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdrone-autopilot%2Ftello-autopilot" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/drone-autopilot/tello-autopilot [INFO] finished tweaking git repo https://github.com/drone-autopilot/tello-autopilot [INFO] tweaked toml for git repo https://github.com/drone-autopilot/tello-autopilot written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/drone-autopilot/tello-autopilot on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/drone-autopilot/tello-autopilot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded value-bag v1.4.1 [INFO] [stderr] Downloaded parking v2.1.1 [INFO] [stderr] Downloaded blocking v1.4.1 [INFO] [stderr] Downloaded async-executor v1.5.4 [INFO] [stderr] Downloaded async-task v4.4.1 [INFO] [stderr] Downloaded aho-corasick v1.0.5 [INFO] [stderr] Downloaded rustix v0.37.25 [INFO] [stderr] Downloaded rustix v0.38.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f0703fc2d4bdc6d923a892616c8e509d16a088291a28e93d56fd20cb9a0bb82 [INFO] running `Command { std: "docker" "start" "-a" "9f0703fc2d4bdc6d923a892616c8e509d16a088291a28e93d56fd20cb9a0bb82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f0703fc2d4bdc6d923a892616c8e509d16a088291a28e93d56fd20cb9a0bb82", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f0703fc2d4bdc6d923a892616c8e509d16a088291a28e93d56fd20cb9a0bb82", kill_on_drop: false }` [INFO] [stdout] 9f0703fc2d4bdc6d923a892616c8e509d16a088291a28e93d56fd20cb9a0bb82 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7ecdd4a489f10f449b01e4b0dd7034d811e57a3bb541c4ab4437a3638ac15f28 [INFO] running `Command { std: "docker" "start" "-a" "7ecdd4a489f10f449b01e4b0dd7034d811e57a3bb541c4ab4437a3638ac15f28", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Checking value-bag v1.4.1 [INFO] [stderr] Checking parking v2.1.1 [INFO] [stderr] Compiling rustix v0.37.25 [INFO] [stderr] Compiling rustix v0.38.13 [INFO] [stderr] Checking async-task v4.4.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking linux-raw-sys v0.4.7 [INFO] [stderr] Checking regex-syntax v0.7.5 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking socket2 v0.5.4 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking tracing v0.1.39 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking aho-corasick v1.0.5 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking concurrent-queue v2.3.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking blocking v1.4.1 [INFO] [stderr] Checking async-executor v1.5.4 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Checking regex v1.9.5 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Checking tello-autopilot v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/state.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 58 | | let mut state = Self::default(); [INFO] [stdout] 59 | | [INFO] [stdout] 60 | | let fields: Vec<&str> = s.trim().split(';').collect(); [INFO] [stdout] ... | [INFO] [stdout] 104 | | return Some(state); [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return Some(state); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return Some(state); [INFO] [stdout] 104 + Some(state) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cmd.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 15 | | match s { [INFO] [stdout] 16 | | "l" => Some(Self::Left), [INFO] [stdout] 17 | | "r" => Some(Self::Right), [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cmd.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 110 | | let parts: Vec<&str> = s.trim().split_whitespace().collect(); [INFO] [stdout] 111 | | [INFO] [stdout] 112 | | match parts.get(0) { [INFO] [stdout] ... | [INFO] [stdout] 284 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd.rs:273:20 [INFO] [stdout] | [INFO] [stdout] 273 | if !(a > -100 && a < 100) || !(b > -100 && b < 100) || !(c > -100 && c < 100) || !(d > -100 && d < 100) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(a > -100 && a < 100 && b > -100 && b < 100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/cmd.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 110 | let parts: Vec<&str> = s.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/cmd.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | match parts.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 145 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:153:20 [INFO] [stdout] | [INFO] [stdout] 153 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | if value >= 1 && value <= 360 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=360).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:177:20 [INFO] [stdout] | [INFO] [stdout] 177 | if value >= 1 && value <= 360 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=360).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:234:20 [INFO] [stdout] | [INFO] [stdout] 234 | if value >= 10 && value <= 100 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(10..=100).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd.rs:447:20 [INFO] [stdout] | [INFO] [stdout] 447 | if !(*a > -100 && *a < 100) || !(*b > -100 && *b < 100) || !(*c > -100 && *c < 100) || !(*d > -100 && *d < 100) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(*a > -100 && *a < 100 && *b > -100 && *b < 100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/state.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 58 | | let mut state = Self::default(); [INFO] [stdout] 59 | | [INFO] [stdout] 60 | | let fields: Vec<&str> = s.trim().split(';').collect(); [INFO] [stdout] ... | [INFO] [stdout] 104 | | return Some(state); [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | return Some(state); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 104 - return Some(state); [INFO] [stdout] 104 + Some(state) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cmd.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 15 | | match s { [INFO] [stdout] 16 | | "l" => Some(Self::Left), [INFO] [stdout] 17 | | "r" => Some(Self::Right), [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cmd.rs:479:5 [INFO] [stdout] | [INFO] [stdout] 479 | / pub fn from_str(s: &str) -> Self { [INFO] [stdout] 480 | | match s { [INFO] [stdout] 481 | | "ok" => CommandResult::Ok, [INFO] [stdout] 482 | | "error" => CommandResult::Error, [INFO] [stdout] ... | [INFO] [stdout] 488 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cmd.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | / pub fn from_str(s: &str) -> Option { [INFO] [stdout] 110 | | let parts: Vec<&str> = s.trim().split_whitespace().collect(); [INFO] [stdout] 111 | | [INFO] [stdout] 112 | | match parts.get(0) { [INFO] [stdout] ... | [INFO] [stdout] 284 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd.rs:273:20 [INFO] [stdout] | [INFO] [stdout] 273 | if !(a > -100 && a < 100) || !(b > -100 && b < 100) || !(c > -100 && c < 100) || !(d > -100 && d < 100) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(a > -100 && a < 100 && b > -100 && b < 100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: found call to `str::trim` before `str::split_whitespace` [INFO] [stdout] --> src/cmd.rs:110:34 [INFO] [stdout] | [INFO] [stdout] 110 | let parts: Vec<&str> = s.trim().split_whitespace().collect(); [INFO] [stdout] | ^^^^^^^ help: remove `trim()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace [INFO] [stdout] = note: `#[warn(clippy::trim_split_whitespace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `parts.get(0)` [INFO] [stdout] --> src/cmd.rs:112:15 [INFO] [stdout] | [INFO] [stdout] 112 | match parts.get(0) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `parts.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:137:20 [INFO] [stdout] | [INFO] [stdout] 137 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:145:20 [INFO] [stdout] | [INFO] [stdout] 145 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:153:20 [INFO] [stdout] | [INFO] [stdout] 153 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:161:20 [INFO] [stdout] | [INFO] [stdout] 161 | if value >= 20 && value <= 500 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(20..=500).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:169:20 [INFO] [stdout] | [INFO] [stdout] 169 | if value >= 1 && value <= 360 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=360).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:177:20 [INFO] [stdout] | [INFO] [stdout] 177 | if value >= 1 && value <= 360 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(1..=360).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cmd.rs:234:20 [INFO] [stdout] | [INFO] [stdout] 234 | if value >= 10 && value <= 100 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(10..=100).contains(&value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cmd.rs:447:20 [INFO] [stdout] | [INFO] [stdout] 447 | if !(*a > -100 && *a < 100) || !(*b > -100 && *b < 100) || !(*c > -100 && *c < 100) || !(*d > -100 && *d < 100) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(*a > -100 && *a < 100 && *b > -100 && *b < 100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `from_str` can be confused for the standard trait method `std::str::FromStr::from_str` [INFO] [stdout] --> src/cmd.rs:479:5 [INFO] [stdout] | [INFO] [stdout] 479 | / pub fn from_str(s: &str) -> Self { [INFO] [stdout] 480 | | match s { [INFO] [stdout] 481 | | "ok" => CommandResult::Ok, [INFO] [stdout] 482 | | "error" => CommandResult::Error, [INFO] [stdout] ... | [INFO] [stdout] 488 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::str::FromStr` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/main.rs:172:39 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `a: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/main.rs:172:42 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `b: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/main.rs:172:45 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `c: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/main.rs:172:48 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `d: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shoot_cmd_infinitely` is never used [INFO] [stdout] --> src/main.rs:259:10 [INFO] [stdout] | [INFO] [stdout] 259 | async fn shoot_cmd_infinitely( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 133 | if cmd_str.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmd_str.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a` [INFO] [stdout] --> src/main.rs:172:39 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `a: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `b` [INFO] [stdout] --> src/main.rs:172:42 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `b: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/main.rs:172:45 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `c: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/main.rs:172:48 [INFO] [stdout] | [INFO] [stdout] 172 | Command::Rc { a, b, c, d } => { [INFO] [stdout] | ^ help: try ignoring the field: `d: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | / match cmd { [INFO] [stdout] 172 | | Command::Rc { a, b, c, d } => { [INFO] [stdout] 173 | | // wait 0.5s [INFO] [stdout] 174 | | sleep_ms(500).await; [INFO] [stdout] ... | [INFO] [stdout] 177 | | _ => () [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 171 ~ if let Command::Rc { a, b, c, d } = cmd { [INFO] [stdout] 172 + // wait 0.5s [INFO] [stdout] 173 + sleep_ms(500).await; [INFO] [stdout] 174 + continue; [INFO] [stdout] 175 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | ... return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - ); [INFO] [stdout] 206 - return; [INFO] [stdout] 205 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shoot_cmd_infinitely` is never used [INFO] [stdout] --> src/main.rs:259:10 [INFO] [stdout] | [INFO] [stdout] 259 | async fn shoot_cmd_infinitely( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:325:25 [INFO] [stdout] | [INFO] [stdout] 325 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - ); [INFO] [stdout] 325 - return; [INFO] [stdout] 324 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:133:24 [INFO] [stdout] | [INFO] [stdout] 133 | if cmd_str.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cmd_str.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:171:21 [INFO] [stdout] | [INFO] [stdout] 171 | / match cmd { [INFO] [stdout] 172 | | Command::Rc { a, b, c, d } => { [INFO] [stdout] 173 | | // wait 0.5s [INFO] [stdout] 174 | | sleep_ms(500).await; [INFO] [stdout] ... | [INFO] [stdout] 177 | | _ => () [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 171 ~ if let Command::Rc { a, b, c, d } = cmd { [INFO] [stdout] 172 + // wait 0.5s [INFO] [stdout] 173 + sleep_ms(500).await; [INFO] [stdout] 174 + continue; [INFO] [stdout] 175 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:206:29 [INFO] [stdout] | [INFO] [stdout] 206 | ... return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 205 - ); [INFO] [stdout] 206 - return; [INFO] [stdout] 205 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:325:25 [INFO] [stdout] | [INFO] [stdout] 325 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 324 - ); [INFO] [stdout] 325 - return; [INFO] [stdout] 324 + ); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.74s [INFO] running `Command { std: "docker" "inspect" "7ecdd4a489f10f449b01e4b0dd7034d811e57a3bb541c4ab4437a3638ac15f28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ecdd4a489f10f449b01e4b0dd7034d811e57a3bb541c4ab4437a3638ac15f28", kill_on_drop: false }` [INFO] [stdout] 7ecdd4a489f10f449b01e4b0dd7034d811e57a3bb541c4ab4437a3638ac15f28