[INFO] cloning repository https://github.com/dream-lake-games/zenith [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dream-lake-games/zenith" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdream-lake-games%2Fzenith", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdream-lake-games%2Fzenith'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 793d4aac58980f9fa607ee6538ad71450a1f2eb8 [INFO] linting dream-lake-games/zenith against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdream-lake-games%2Fzenith" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dream-lake-games/zenith [INFO] finished tweaking git repo https://github.com/dream-lake-games/zenith [INFO] tweaked toml for git repo https://github.com/dream-lake-games/zenith written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dream-lake-games/zenith on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dream-lake-games/zenith already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded xcursor v0.3.6 [INFO] [stderr] Downloaded bevy-inspector-egui v0.25.1 [INFO] [stderr] Downloaded bytes v1.7.0 [INFO] [stderr] Downloaded bevy-inspector-egui-derive v0.25.0 [INFO] [stderr] Downloaded bevy_egui v0.28.0 [INFO] [stderr] Downloaded blake3 v1.5.3 [INFO] [stderr] Downloaded ttf-parser v0.24.0 [INFO] [stderr] Downloaded winit v0.30.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a030197533a7fe735342a28ca4360a69428223b255442693e3ca32a20807d309 [INFO] running `Command { std: "docker" "start" "-a" "a030197533a7fe735342a28ca4360a69428223b255442693e3ca32a20807d309", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a030197533a7fe735342a28ca4360a69428223b255442693e3ca32a20807d309", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a030197533a7fe735342a28ca4360a69428223b255442693e3ca32a20807d309", kill_on_drop: false }` [INFO] [stdout] a030197533a7fe735342a28ca4360a69428223b255442693e3ca32a20807d309 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f13fa8dc70adb4593ff43712814e1efd96593064df93bda77cf5b75e3c15e152 [INFO] running `Command { std: "docker" "start" "-a" "f13fa8dc70adb4593ff43712814e1efd96593064df93bda77cf5b75e3c15e152", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling winnow v0.6.18 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling indexmap v2.3.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Compiling uuid v1.10.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cc v1.1.7 [INFO] [stderr] Checking ash v0.37.3+1.3.251 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking arrayref v0.3.8 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking ttf-parser v0.24.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Compiling winit v0.30.4 [INFO] [stderr] Checking euclid v0.22.10 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Compiling gilrs v0.10.9 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking dpi v0.1.1 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking grid v0.14.0 [INFO] [stderr] Checking guillotiere v0.6.2 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking bevy_tasks v0.14.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Compiling bevy_egui v0.28.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking pretty-type-name v1.0.1 [INFO] [stderr] Checking taffy v0.5.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling toml_edit v0.22.20 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking owned_ttf_parser v0.24.0 [INFO] [stderr] Checking webbrowser v1.0.1 [INFO] [stderr] Checking ab_glyph v0.2.28 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking glyph_brush_layout v0.2.4 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling blake3 v1.5.3 [INFO] [stderr] Compiling bevy_macro_utils v0.14.0 [INFO] [stderr] Compiling encase_derive_impl v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling bytemuck_derive v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.14.0 [INFO] [stderr] Compiling bevy_reflect_derive v0.14.0 [INFO] [stderr] Compiling bevy_ecs_macros v0.14.0 [INFO] [stderr] Compiling bevy_derive v0.14.0 [INFO] [stderr] Compiling encase_derive v0.8.0 [INFO] [stderr] Compiling bevy_asset_macros v0.14.0 [INFO] [stderr] Compiling bevy_render_macros v0.14.0 [INFO] [stderr] Compiling bevy_encase_derive v0.14.0 [INFO] [stderr] Compiling gltf-derive v1.4.1 [INFO] [stderr] Compiling bevy_gizmos_macros v0.14.0 [INFO] [stderr] Compiling bevy_state_macros v0.14.0 [INFO] [stderr] Compiling bevy-inspector-egui-derive v0.25.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Checking egui v0.28.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking wgpu-types v0.20.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking rustix v0.38.34 [INFO] [stderr] Checking nix v0.29.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking alsa v0.9.0 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking bevy_utils v0.14.0 [INFO] [stderr] Checking gpu-descriptor v0.3.0 [INFO] [stderr] Checking gilrs-core v0.5.13 [INFO] [stderr] Checking cpal v0.15.3 [INFO] [stderr] Checking gltf-json v1.4.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking rodio v0.18.1 [INFO] [stderr] Checking naga v0.20.0 [INFO] [stderr] Checking bevy_reflect v0.14.0 [INFO] [stderr] Checking encase v0.8.0 [INFO] [stderr] Checking bevy_mikktspace v0.14.0 [INFO] [stderr] Checking hexasphere v12.0.0 [INFO] [stderr] Checking gltf v1.4.1 [INFO] [stderr] Checking polling v3.7.2 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking arboard v3.4.0 [INFO] [stderr] Checking bevy_ecs v0.14.0 [INFO] [stderr] Checking bevy_math v0.14.0 [INFO] [stderr] Checking accesskit_winit v0.20.4 [INFO] [stderr] Checking wgpu-hal v0.21.1 [INFO] [stderr] Checking naga_oil v0.14.0 [INFO] [stderr] Checking bevy_color v0.14.1 [INFO] [stderr] Checking wgpu-core v0.21.1 [INFO] [stderr] Checking bevy_app v0.14.0 [INFO] [stderr] Checking bevy_core v0.14.0 [INFO] [stderr] Checking bevy_time v0.14.0 [INFO] [stderr] Checking bevy_a11y v0.14.0 [INFO] [stderr] Checking bevy_asset v0.14.0 [INFO] [stderr] Checking bevy_input v0.14.0 [INFO] [stderr] Checking bevy_log v0.14.0 [INFO] [stderr] Checking bevy_window v0.14.0 [INFO] [stderr] Checking bevy_hierarchy v0.14.0 [INFO] [stderr] Checking bevy_transform v0.14.0 [INFO] [stderr] Checking bevy_state v0.14.0 [INFO] [stderr] Checking bevy_diagnostic v0.14.0 [INFO] [stderr] Checking wgpu v0.20.1 [INFO] [stderr] Checking bevy_winit v0.14.0 [INFO] [stderr] Checking bevy_gilrs v0.14.0 [INFO] [stderr] Checking bevy_render v0.14.0 [INFO] [stderr] Checking bevy_audio v0.14.0 [INFO] [stderr] Checking bevy_core_pipeline v0.14.0 [INFO] [stderr] Checking bevy_scene v0.14.0 [INFO] [stderr] Checking bevy_animation v0.14.0 [INFO] [stderr] Checking bevy_sprite v0.14.0 [INFO] [stderr] Checking bevy_pbr v0.14.0 [INFO] [stderr] Checking bevy_text v0.14.0 [INFO] [stderr] Checking bevy_ui v0.14.0 [INFO] [stderr] Checking bevy_gizmos v0.14.0 [INFO] [stderr] Checking bevy_gltf v0.14.0 [INFO] [stderr] Checking bevy_internal v0.14.0 [INFO] [stderr] Checking bevy v0.14.0 [INFO] [stderr] Checking bevy-inspector-egui v0.25.1 [INFO] [stderr] Checking zenith v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary `pub(self)` [INFO] [stdout] --> src/animation/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub(self) mod mesh; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self [INFO] [stdout] = note: `#[warn(clippy::needless_pub_self)]` on by default [INFO] [stdout] = help: remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `pub(self)` [INFO] [stdout] --> src/animation/mod.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub(self) mod mesh; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pub_self [INFO] [stdout] = note: `#[warn(clippy::needless_pub_self)]` on by default [INFO] [stdout] = help: remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | MetaState::Cutscene(cutscene_state) => Some(cutscene_state.clone()), [INFO] [stdout] | ^^^^^----------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::CutsceneState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:59:57 [INFO] [stdout] | [INFO] [stdout] 59 | MetaState::Cutscene(cutscene_state) => Some(cutscene_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:66:52 [INFO] [stdout] | [INFO] [stdout] 66 | MetaState::Tutorial(tutorial_state) => Some(tutorial_state.clone()), [INFO] [stdout] | ^^^^^----------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::TutorialState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:66:57 [INFO] [stdout] | [INFO] [stdout] 66 | MetaState::Tutorial(tutorial_state) => Some(tutorial_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] ... [INFO] [stdout] 110 | impl_to_meta_state!(CutsceneState, Cutscene); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::CutsceneState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:104:34 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 110 | impl_to_meta_state!(CutsceneState, Cutscene); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_to_meta_state` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] ... [INFO] [stdout] 111 | impl_to_meta_state!(TutorialState, Tutorial); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::TutorialState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:104:34 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | impl_to_meta_state!(TutorialState, Tutorial); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_to_meta_state` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:59:52 [INFO] [stdout] | [INFO] [stdout] 59 | MetaState::Cutscene(cutscene_state) => Some(cutscene_state.clone()), [INFO] [stdout] | ^^^^^----------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::CutsceneState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:59:57 [INFO] [stdout] | [INFO] [stdout] 59 | MetaState::Cutscene(cutscene_state) => Some(cutscene_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(unreachable_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:66:52 [INFO] [stdout] | [INFO] [stdout] 66 | MetaState::Tutorial(tutorial_state) => Some(tutorial_state.clone()), [INFO] [stdout] | ^^^^^----------------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::TutorialState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:66:57 [INFO] [stdout] | [INFO] [stdout] 66 | MetaState::Tutorial(tutorial_state) => Some(tutorial_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] ... [INFO] [stdout] 110 | impl_to_meta_state!(CutsceneState, Cutscene); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::CutsceneState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:104:34 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 110 | impl_to_meta_state!(CutsceneState, Cutscene); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_to_meta_state` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/state/mod.rs:104:17 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------^ [INFO] [stdout] | | | [INFO] [stdout] | | any code following this expression is unreachable [INFO] [stdout] | unreachable expression [INFO] [stdout] ... [INFO] [stdout] 111 | impl_to_meta_state!(TutorialState, Tutorial); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] note: this expression has type `state::TutorialState`, which is uninhabited [INFO] [stdout] --> src/state/mod.rs:104:34 [INFO] [stdout] | [INFO] [stdout] 104 | MetaState::$disc(self.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 111 | impl_to_meta_state!(TutorialState, Tutorial); [INFO] [stdout] | -------------------------------------------- in this macro invocation [INFO] [stdout] = note: this warning originates in the macro `impl_to_meta_state` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnimationNextBurden` is never constructed [INFO] [stdout] --> src/animation/animation_manager.rs:178:8 [INFO] [stdout] | [INFO] [stdout] 178 | struct AnimationNextBurden { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AnimationNextBurden` is never constructed [INFO] [stdout] --> src/animation/animation_manager.rs:178:8 [INFO] [stdout] | [INFO] [stdout] 178 | struct AnimationNextBurden { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AnimationManager` [INFO] [stdout] --> src/animation/animation_manager.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | / pub fn new() -> Self { [INFO] [stdout] 94 | | Self { [INFO] [stdout] 95 | | state: default(), [INFO] [stdout] 96 | | hidden: false, [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 92 + impl Default for AnimationManager { [INFO] [stdout] 93 + fn default() -> Self { [INFO] [stdout] 94 + Self::new() [INFO] [stdout] 95 + } [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AnimationManager` [INFO] [stdout] --> src/animation/animation_manager.rs:93:5 [INFO] [stdout] | [INFO] [stdout] 93 | / pub fn new() -> Self { [INFO] [stdout] 94 | | Self { [INFO] [stdout] 95 | | state: default(), [INFO] [stdout] 96 | | hidden: false, [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 92 + impl Default for AnimationManager { [INFO] [stdout] 93 + fn default() -> Self { [INFO] [stdout] 94 + Self::new() [INFO] [stdout] 95 + } [INFO] [stdout] 96 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/animation/animation_manager.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | self.ixes.get(&body_type).map(|thing| *thing) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.ixes.get(&body_type).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/animation/animation_manager.rs:159:9 [INFO] [stdout] | [INFO] [stdout] 159 | self.ixes.get(&body_type).map(|thing| *thing) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `self.ixes.get(&body_type).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/animation/animation_manager.rs:232:15 [INFO] [stdout] | [INFO] [stdout] 232 | managers: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 233 | | (Entity, &AnimationManager, Option<&Children>), [INFO] [stdout] 234 | | Changed>, [INFO] [stdout] 235 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/animation/animation_manager.rs:232:15 [INFO] [stdout] | [INFO] [stdout] 232 | managers: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 233 | | (Entity, &AnimationManager, Option<&Children>), [INFO] [stdout] 234 | | Changed>, [INFO] [stdout] 235 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/animation/animation_manager.rs:271:19 [INFO] [stdout] | [INFO] [stdout] 271 | mut managers: Query<( [INFO] [stdout] | ___________________^ [INFO] [stdout] 272 | | Entity, [INFO] [stdout] 273 | | &mut AnimationManager, [INFO] [stdout] 274 | | &mut AnimationBodyProgress, [INFO] [stdout] 275 | | Option<&Dying>, [INFO] [stdout] 276 | | &mut Visibility, [INFO] [stdout] 277 | | )>, [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/animation/animation_manager.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 323 | if !already_dying.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `already_dying.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/animation/animation_manager.rs:271:19 [INFO] [stdout] | [INFO] [stdout] 271 | mut managers: Query<( [INFO] [stdout] | ___________________^ [INFO] [stdout] 272 | | Entity, [INFO] [stdout] 273 | | &mut AnimationManager, [INFO] [stdout] 274 | | &mut AnimationBodyProgress, [INFO] [stdout] 275 | | Option<&Dying>, [INFO] [stdout] 276 | | &mut Visibility, [INFO] [stdout] 277 | | )>, [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/animation/animation_manager.rs:323:24 [INFO] [stdout] | [INFO] [stdout] 323 | if !already_dying.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `already_dying.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TextureManager` [INFO] [stdout] --> src/animation/texture_manager.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / pub fn new() -> Self { [INFO] [stdout] 115 | | Self { [INFO] [stdout] 116 | | state: default(), [INFO] [stdout] 117 | | point_map: default(), [INFO] [stdout] 118 | | } [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 113 + impl Default for TextureManager { [INFO] [stdout] 114 + fn default() -> Self { [INFO] [stdout] 115 + Self::new() [INFO] [stdout] 116 + } [INFO] [stdout] 117 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `TextureManager` [INFO] [stdout] --> src/animation/texture_manager.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / pub fn new() -> Self { [INFO] [stdout] 115 | | Self { [INFO] [stdout] 116 | | state: default(), [INFO] [stdout] 117 | | point_map: default(), [INFO] [stdout] 118 | | } [INFO] [stdout] 119 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 113 + impl Default for TextureManager { [INFO] [stdout] 114 + fn default() -> Self { [INFO] [stdout] 115 + Self::new() [INFO] [stdout] 116 + } [INFO] [stdout] 117 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/texture_manager.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | &self.point_map.get(&part).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.point_map.get(&part).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/texture_manager.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | &self.point_map.get(&part).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.point_map.get(&part).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/texture_manager.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | let bound = uvec2_bound(&points); [INFO] [stdout] | ^^^^^^^ help: change this to: `points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/texture_manager.rs:196:35 [INFO] [stdout] | [INFO] [stdout] 196 | let mesh = points_to_mesh(&points); [INFO] [stdout] | ^^^^^^^ help: change this to: `points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/texture_manager.rs:195:33 [INFO] [stdout] | [INFO] [stdout] 195 | let bound = uvec2_bound(&points); [INFO] [stdout] | ^^^^^^^ help: change this to: `points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/animation/texture_manager.rs:196:35 [INFO] [stdout] | [INFO] [stdout] 196 | let mesh = points_to_mesh(&points); [INFO] [stdout] | ^^^^^^^ help: change this to: `points` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/camera/mod.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | mut layer_camera_q: Query< [INFO] [stdout] | _________________________^ [INFO] [stdout] 94 | | &mut Transform, [INFO] [stdout] 95 | | ( [INFO] [stdout] 96 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 103 | | ), [INFO] [stdout] 104 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/camera/mod.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | mut layer_camera_q: Query< [INFO] [stdout] | _________________________^ [INFO] [stdout] 94 | | &mut Transform, [INFO] [stdout] 95 | | ( [INFO] [stdout] 96 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 103 | | ), [INFO] [stdout] 104 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/camera/mod.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 108 | *layer_tran = dynamic_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*dynamic_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/camera/mod.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 108 | *layer_tran = dynamic_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*dynamic_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DebugState` which implements the `Copy` trait [INFO] [stdout] --> src/debug/mod.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 28 | next_debug_state.set(interactive_state.0.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `interactive_state.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DebugState` which implements the `Copy` trait [INFO] [stdout] --> src/debug/mod.rs:28:30 [INFO] [stdout] | [INFO] [stdout] 28 | next_debug_state.set(interactive_state.0.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `interactive_state.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/debug/mod.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | / fn debug_update( [INFO] [stdout] 74 | | keyboard: Res>, [INFO] [stdout] 75 | | mut commands: Commands, [INFO] [stdout] 76 | | mut bullet_time: ResMut, [INFO] [stdout] ... | [INFO] [stdout] 81 | | room_state: Res>, [INFO] [stdout] 82 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/debug/mod.rs:73:1 [INFO] [stdout] | [INFO] [stdout] 73 | / fn debug_update( [INFO] [stdout] 74 | | keyboard: Res>, [INFO] [stdout] 75 | | mut commands: Commands, [INFO] [stdout] 76 | | mut bullet_time: ResMut, [INFO] [stdout] ... | [INFO] [stdout] 81 | | room_state: Res>, [INFO] [stdout] 82 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/debug/mod.rs:99:66 [INFO] [stdout] | [INFO] [stdout] 99 | commands.spawn(SuicidoBundle::new(Vec2::new(0.0, -10.0), &room_state.get())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `room_state.get()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/debug/mod.rs:99:66 [INFO] [stdout] | [INFO] [stdout] 99 | commands.spawn(SuicidoBundle::new(Vec2::new(0.0, -10.0), &room_state.get())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `room_state.get()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:120:15 [INFO] [stdout] | [INFO] [stdout] 120 | relevant: Query, Without>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:120:15 [INFO] [stdout] | [INFO] [stdout] 120 | relevant: Query, Without>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 152 | mut suicidos: Query< [INFO] [stdout] | ___________________^ [INFO] [stdout] 153 | | ( [INFO] [stdout] 154 | | Entity, [INFO] [stdout] 155 | | &mut Charging, [INFO] [stdout] ... | [INFO] [stdout] 161 | | With, [INFO] [stdout] 162 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | ship_poses: Query<(&GlobalTransform, &DynoTran), (With, Without)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 152 | mut suicidos: Query< [INFO] [stdout] | ___________________^ [INFO] [stdout] 153 | | ( [INFO] [stdout] 154 | | Entity, [INFO] [stdout] 155 | | &mut Charging, [INFO] [stdout] ... | [INFO] [stdout] 161 | | With, [INFO] [stdout] 162 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | ship_poses: Query<(&GlobalTransform, &DynoTran), (With, Without)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:231:19 [INFO] [stdout] | [INFO] [stdout] 231 | mut suicidos: Query< [INFO] [stdout] | ___________________^ [INFO] [stdout] 232 | | ( [INFO] [stdout] 233 | | Entity, [INFO] [stdout] 234 | | &mut Launching, [INFO] [stdout] ... | [INFO] [stdout] 239 | | With, [INFO] [stdout] 240 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:231:19 [INFO] [stdout] | [INFO] [stdout] 231 | mut suicidos: Query< [INFO] [stdout] | ___________________^ [INFO] [stdout] 232 | | ( [INFO] [stdout] 233 | | Entity, [INFO] [stdout] 234 | | &mut Launching, [INFO] [stdout] ... | [INFO] [stdout] 239 | | With, [INFO] [stdout] 240 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:307:19 [INFO] [stdout] | [INFO] [stdout] 307 | mut suicidos: Query< [INFO] [stdout] | ___________________^ [INFO] [stdout] 308 | | ( [INFO] [stdout] 309 | | Entity, [INFO] [stdout] 310 | | &mut Exploding, [INFO] [stdout] ... | [INFO] [stdout] 316 | | With, [INFO] [stdout] 317 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:307:19 [INFO] [stdout] | [INFO] [stdout] 307 | mut suicidos: Query< [INFO] [stdout] | ___________________^ [INFO] [stdout] 308 | | ( [INFO] [stdout] 309 | | Entity, [INFO] [stdout] 310 | | &mut Exploding, [INFO] [stdout] ... | [INFO] [stdout] 316 | | With, [INFO] [stdout] 317 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy/suicido.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | / if !exploding.has_spawned_circle { [INFO] [stdout] 332 | | if animation_state.get_state() == AnimationSuicidoBody::Explode [INFO] [stdout] 333 | | && animation_progress.get_body_ix(AnimationBody_AnimationSuicidoBody::explode) [INFO] [stdout] 334 | | == Some(3) [INFO] [stdout] ... | [INFO] [stdout] 343 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 331 ~ if !exploding.has_spawned_circle [INFO] [stdout] 332 ~ && animation_state.get_state() == AnimationSuicidoBody::Explode [INFO] [stdout] 333 | && animation_progress.get_body_ix(AnimationBody_AnimationSuicidoBody::explode) [INFO] [stdout] ... [INFO] [stdout] 341 | )); [INFO] [stdout] 342 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/enemy/suicido.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | / if !exploding.has_spawned_circle { [INFO] [stdout] 332 | | if animation_state.get_state() == AnimationSuicidoBody::Explode [INFO] [stdout] 333 | | && animation_progress.get_body_ix(AnimationBody_AnimationSuicidoBody::explode) [INFO] [stdout] 334 | | == Some(3) [INFO] [stdout] ... | [INFO] [stdout] 343 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 331 ~ if !exploding.has_spawned_circle [INFO] [stdout] 332 ~ && animation_state.get_state() == AnimationSuicidoBody::Explode [INFO] [stdout] 333 | && animation_progress.get_body_ix(AnimationBody_AnimationSuicidoBody::explode) [INFO] [stdout] ... [INFO] [stdout] 341 | )); [INFO] [stdout] 342 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:348:19 [INFO] [stdout] | [INFO] [stdout] 348 | mut suicidos: Query<( [INFO] [stdout] | ___________________^ [INFO] [stdout] 349 | | &mut AnimationManager, [INFO] [stdout] 350 | | Option<&Charging>, [INFO] [stdout] 351 | | Option<&Launching>, [INFO] [stdout] 352 | | Option<&Exploding>, [INFO] [stdout] 353 | | )>, [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/enemy/suicido.rs:348:19 [INFO] [stdout] | [INFO] [stdout] 348 | mut suicidos: Query<( [INFO] [stdout] | ___________________^ [INFO] [stdout] 349 | | &mut AnimationManager, [INFO] [stdout] 350 | | Option<&Charging>, [INFO] [stdout] 351 | | Option<&Launching>, [INFO] [stdout] 352 | | Option<&Exploding>, [INFO] [stdout] 353 | | )>, [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/environment/planet.rs:36:64 [INFO] [stdout] | [INFO] [stdout] 36 | mirage_texture: MirageTextureManager::room_offsets(&room_state), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `room_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/environment/planet.rs:36:64 [INFO] [stdout] | [INFO] [stdout] 36 | mirage_texture: MirageTextureManager::room_offsets(&room_state), [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `room_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/input/desktop_input.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - non_game_writer.send(NonGameInput::Continue); [INFO] [stdout] 86 - return; [INFO] [stdout] 85 + non_game_writer.send(NonGameInput::Continue); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/input/desktop_input.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 85 - non_game_writer.send(NonGameInput::Continue); [INFO] [stdout] 86 - return; [INFO] [stdout] 85 + non_game_writer.send(NonGameInput::Continue); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LayerGrowth` which implements the `Copy` trait [INFO] [stdout] --> src/layer/mod.rs:413:29 [INFO] [stdout] | [INFO] [stdout] 413 | app.insert_resource(self.layer_growth.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.layer_growth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `LayerGrowth` which implements the `Copy` trait [INFO] [stdout] --> src/layer/mod.rs:413:29 [INFO] [stdout] | [INFO] [stdout] 413 | app.insert_resource(self.layer_growth.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.layer_growth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mirage/mirage_drawing.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | managers: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 48 | | (Entity, &Children, &MirageAnimationManager), [INFO] [stdout] 49 | | (Changed>,), [INFO] [stdout] 50 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mirage/mirage_drawing.rs:47:15 [INFO] [stdout] | [INFO] [stdout] 47 | managers: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 48 | | (Entity, &Children, &MirageAnimationManager), [INFO] [stdout] 49 | | (Changed>,), [INFO] [stdout] 50 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mirage/mirage_drawing.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | managers: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 84 | | (Entity, &MirageTextureManager, &Children), [INFO] [stdout] 85 | | (Changed>,), [INFO] [stdout] 86 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mirage/mirage_drawing.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | managers: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 84 | | (Entity, &MirageTextureManager, &Children), [INFO] [stdout] 85 | | (Changed>,), [INFO] [stdout] 86 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mirage/mirage_drawing.rs:119:16 [INFO] [stdout] | [INFO] [stdout] 119 | reference: Query< [INFO] [stdout] | ________________^ [INFO] [stdout] 120 | | &GlobalTransform, [INFO] [stdout] 121 | | ( [INFO] [stdout] 122 | | With, [INFO] [stdout] ... | [INFO] [stdout] 125 | | ), [INFO] [stdout] 126 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mirage/mirage_drawing.rs:119:16 [INFO] [stdout] | [INFO] [stdout] 119 | reference: Query< [INFO] [stdout] | ________________^ [INFO] [stdout] 120 | | &GlobalTransform, [INFO] [stdout] 121 | | ( [INFO] [stdout] 122 | | With, [INFO] [stdout] ... | [INFO] [stdout] 125 | | ), [INFO] [stdout] 126 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/mirage/mirage_drawing.rs:137:43 [INFO] [stdout] | [INFO] [stdout] 137 | let new_global: GlobalTransform = (tran.clone()).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `(*tran)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/mirage/mirage_drawing.rs:137:43 [INFO] [stdout] | [INFO] [stdout] 137 | let new_global: GlobalTransform = (tran.clone()).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `(*tran)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / return (*my_center + placement.0).distance(*other_center + rhs.1) [INFO] [stdout] 108 | | < my_radius + other_radius [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 ~ (*my_center + placement.0).distance(*other_center + rhs.1) [INFO] [stdout] 108 + < my_radius + other_radius [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / return (*my_center + placement.0).distance(*other_center + rhs.1) [INFO] [stdout] 108 | | < my_radius + other_radius [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 107 ~ (*my_center + placement.0).distance(*other_center + rhs.1) [INFO] [stdout] 108 + < my_radius + other_radius [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return false; [INFO] [stdout] 120 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 120 - return false; [INFO] [stdout] 120 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 135 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return false; [INFO] [stdout] 135 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:135:17 [INFO] [stdout] | [INFO] [stdout] 135 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return false; [INFO] [stdout] 135 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return false; [INFO] [stdout] 161 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/physics/bounds.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 161 - return false; [INFO] [stdout] 161 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BulletTime` [INFO] [stdout] --> src/physics/bullet_time.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | time_factor: 1.0, [INFO] [stdout] 15 | | main_duration: Duration::default(), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for BulletTime { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BulletTime` [INFO] [stdout] --> src/physics/bullet_time.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Self { [INFO] [stdout] 13 | | Self { [INFO] [stdout] 14 | | time_factor: 1.0, [INFO] [stdout] 15 | | main_duration: Duration::default(), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 8 + impl Default for BulletTime { [INFO] [stdout] 9 + fn default() -> Self { [INFO] [stdout] 10 + Self::new() [INFO] [stdout] 11 + } [INFO] [stdout] 12 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | trigger_on_static: Query, With)>, With)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | no_gtran: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 38 | | Entity, [INFO] [stdout] 39 | | ( [INFO] [stdout] 40 | | Or<( [INFO] [stdout] ... | [INFO] [stdout] 47 | | ), [INFO] [stdout] 48 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | relevant_eids: Query< [INFO] [stdout] | ____________________^ [INFO] [stdout] 72 | | Entity, [INFO] [stdout] 73 | | ( [INFO] [stdout] 74 | | Or<( [INFO] [stdout] ... | [INFO] [stdout] 83 | | ), [INFO] [stdout] 84 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | mut rot_only_dynos: Query< [INFO] [stdout] | _________________________^ [INFO] [stdout] 95 | | (&DynoRot, &mut Transform), [INFO] [stdout] 96 | | ( [INFO] [stdout] 97 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 103 | | ), [INFO] [stdout] 104 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | mut both_dynos: Query< [INFO] [stdout] | _____________________^ [INFO] [stdout] 106 | | (&DynoRot, &DynoTran, &mut Transform), [INFO] [stdout] 107 | | ( [INFO] [stdout] 108 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 113 | | ), [INFO] [stdout] 114 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:115:26 [INFO] [stdout] | [INFO] [stdout] 115 | mut tran_only_dynos: Query< [INFO] [stdout] | __________________________^ [INFO] [stdout] 116 | | (&DynoTran, &mut Transform), [INFO] [stdout] 117 | | ( [INFO] [stdout] 118 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 124 | | ), [INFO] [stdout] 125 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | trigger_on_static: Query, With)>, With)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | mut rot_only_dynos: Query< [INFO] [stdout] | _________________________^ [INFO] [stdout] 150 | | (&DynoRot, &mut Transform), [INFO] [stdout] 151 | | (Without, With, With), [INFO] [stdout] 152 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | no_gtran: Query< [INFO] [stdout] | _______________^ [INFO] [stdout] 38 | | Entity, [INFO] [stdout] 39 | | ( [INFO] [stdout] 40 | | Or<( [INFO] [stdout] ... | [INFO] [stdout] 47 | | ), [INFO] [stdout] 48 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 153 | mut both_dynos: Query< [INFO] [stdout] | _____________________^ [INFO] [stdout] 154 | | (&DynoRot, &DynoTran, &mut Transform), [INFO] [stdout] 155 | | (With, With), [INFO] [stdout] 156 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:157:26 [INFO] [stdout] | [INFO] [stdout] 157 | mut tran_only_dynos: Query< [INFO] [stdout] | __________________________^ [INFO] [stdout] 158 | | (&DynoTran, &mut Transform), [INFO] [stdout] 159 | | ( [INFO] [stdout] 160 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 164 | | ), [INFO] [stdout] 165 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:71:20 [INFO] [stdout] | [INFO] [stdout] 71 | relevant_eids: Query< [INFO] [stdout] | ____________________^ [INFO] [stdout] 72 | | Entity, [INFO] [stdout] 73 | | ( [INFO] [stdout] 74 | | Or<( [INFO] [stdout] ... | [INFO] [stdout] 83 | | ), [INFO] [stdout] 84 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/physics/logic.rs:187:1 [INFO] [stdout] | [INFO] [stdout] 187 | / fn resolve_static_collisions( [INFO] [stdout] 188 | | rx_eid: Entity, [INFO] [stdout] 189 | | rx: &mut StaticRx, [INFO] [stdout] 190 | | dyno_tran: &mut DynoTran, [INFO] [stdout] ... | [INFO] [stdout] 195 | | collision_root: &CollisionRoot, [INFO] [stdout] 196 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:94:25 [INFO] [stdout] | [INFO] [stdout] 94 | mut rot_only_dynos: Query< [INFO] [stdout] | _________________________^ [INFO] [stdout] 95 | | (&DynoRot, &mut Transform), [INFO] [stdout] 96 | | ( [INFO] [stdout] 97 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 103 | | ), [INFO] [stdout] 104 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:105:21 [INFO] [stdout] | [INFO] [stdout] 105 | mut both_dynos: Query< [INFO] [stdout] | _____________________^ [INFO] [stdout] 106 | | (&DynoRot, &DynoTran, &mut Transform), [INFO] [stdout] 107 | | ( [INFO] [stdout] 108 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 113 | | ), [INFO] [stdout] 114 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:115:26 [INFO] [stdout] | [INFO] [stdout] 115 | mut tran_only_dynos: Query< [INFO] [stdout] | __________________________^ [INFO] [stdout] 116 | | (&DynoTran, &mut Transform), [INFO] [stdout] 117 | | ( [INFO] [stdout] 118 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 124 | | ), [INFO] [stdout] 125 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | mut rot_only_dynos: Query< [INFO] [stdout] | _________________________^ [INFO] [stdout] 150 | | (&DynoRot, &mut Transform), [INFO] [stdout] 151 | | (Without, With, With), [INFO] [stdout] 152 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:153:21 [INFO] [stdout] | [INFO] [stdout] 153 | mut both_dynos: Query< [INFO] [stdout] | _____________________^ [INFO] [stdout] 154 | | (&DynoRot, &DynoTran, &mut Transform), [INFO] [stdout] 155 | | (With, With), [INFO] [stdout] 156 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:157:26 [INFO] [stdout] | [INFO] [stdout] 157 | mut tran_only_dynos: Query< [INFO] [stdout] | __________________________^ [INFO] [stdout] 158 | | (&DynoTran, &mut Transform), [INFO] [stdout] 159 | | ( [INFO] [stdout] 160 | | Without, [INFO] [stdout] ... | [INFO] [stdout] 164 | | ), [INFO] [stdout] 165 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/physics/logic.rs:276:1 [INFO] [stdout] | [INFO] [stdout] 276 | / fn resolve_trigger_collisions( [INFO] [stdout] 277 | | eid: Entity, [INFO] [stdout] 278 | | rx: &mut TriggerRx, [INFO] [stdout] 279 | | gtran: &Transform, [INFO] [stdout] ... | [INFO] [stdout] 284 | | dup_set: &mut HashSet<(Entity, Entity)>, [INFO] [stdout] 285 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/physics/logic.rs:187:1 [INFO] [stdout] | [INFO] [stdout] 187 | / fn resolve_static_collisions( [INFO] [stdout] 188 | | rx_eid: Entity, [INFO] [stdout] 189 | | rx: &mut StaticRx, [INFO] [stdout] 190 | | dyno_tran: &mut DynoTran, [INFO] [stdout] ... | [INFO] [stdout] 195 | | collision_root: &CollisionRoot, [INFO] [stdout] 196 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:335:20 [INFO] [stdout] | [INFO] [stdout] 335 | relevant_eids: Query< [INFO] [stdout] | ____________________^ [INFO] [stdout] 336 | | Entity, [INFO] [stdout] 337 | | ( [INFO] [stdout] 338 | | Or<(With, With)>, [INFO] [stdout] ... | [INFO] [stdout] 342 | | ), [INFO] [stdout] 343 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:345:20 [INFO] [stdout] | [INFO] [stdout] 345 | mut dyno_data: Query< [INFO] [stdout] | ____________________^ [INFO] [stdout] 346 | | ( [INFO] [stdout] 347 | | Entity, [INFO] [stdout] 348 | | Option<&mut DynoTran>, [INFO] [stdout] ... | [INFO] [stdout] 353 | | Or<(With, With)>, [INFO] [stdout] 354 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/physics/logic.rs:333:1 [INFO] [stdout] | [INFO] [stdout] 333 | / fn move_unstuck_static_or_trigger_receivers( [INFO] [stdout] 334 | | bullet_time: Res, [INFO] [stdout] 335 | | relevant_eids: Query< [INFO] [stdout] 336 | | Entity, [INFO] [stdout] ... | [INFO] [stdout] 361 | | proot: Res, [INFO] [stdout] 362 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GlobalTransform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:366:24 [INFO] [stdout] | [INFO] [stdout] 366 | let my_gtran = my_gtran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*my_gtran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/physics/logic.rs:370:32 [INFO] [stdout] | [INFO] [stdout] 370 | let mut my_dyno_tran = my_dyno_tran.map(|inner| inner.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `my_dyno_tran.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/physics/logic.rs:371:31 [INFO] [stdout] | [INFO] [stdout] 371 | let mut my_dyno_rot = my_dyno_rot.map(|inner| inner.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `my_dyno_rot.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:372:27 [INFO] [stdout] | [INFO] [stdout] 372 | let mut my_tran = my_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*my_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/physics/logic.rs:276:1 [INFO] [stdout] | [INFO] [stdout] 276 | / fn resolve_trigger_collisions( [INFO] [stdout] 277 | | eid: Entity, [INFO] [stdout] 278 | | rx: &mut TriggerRx, [INFO] [stdout] 279 | | gtran: &Transform, [INFO] [stdout] ... | [INFO] [stdout] 284 | | dup_set: &mut HashSet<(Entity, Entity)>, [INFO] [stdout] 285 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/physics/logic.rs:403:25 [INFO] [stdout] | [INFO] [stdout] 403 | &mut my_static_rx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `my_static_rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/physics/logic.rs:404:25 [INFO] [stdout] | [INFO] [stdout] 404 | &mut my_dyno_tran, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `my_dyno_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:413:42 [INFO] [stdout] | [INFO] [stdout] 413 | let mut mid_step_gtran = my_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `my_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:335:20 [INFO] [stdout] | [INFO] [stdout] 335 | relevant_eids: Query< [INFO] [stdout] | ____________________^ [INFO] [stdout] 336 | | Entity, [INFO] [stdout] 337 | | ( [INFO] [stdout] 338 | | Or<(With, With)>, [INFO] [stdout] ... | [INFO] [stdout] 342 | | ), [INFO] [stdout] 343 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:345:20 [INFO] [stdout] | [INFO] [stdout] 345 | mut dyno_data: Query< [INFO] [stdout] | ____________________^ [INFO] [stdout] 346 | | ( [INFO] [stdout] 347 | | Entity, [INFO] [stdout] 348 | | Option<&mut DynoTran>, [INFO] [stdout] ... | [INFO] [stdout] 353 | | Or<(With, With)>, [INFO] [stdout] 354 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:444:42 [INFO] [stdout] | [INFO] [stdout] 444 | let mut mid_step_gtran = my_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `my_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/physics/logic.rs:333:1 [INFO] [stdout] | [INFO] [stdout] 333 | / fn move_unstuck_static_or_trigger_receivers( [INFO] [stdout] 334 | | bullet_time: Res, [INFO] [stdout] 335 | | relevant_eids: Query< [INFO] [stdout] 336 | | Entity, [INFO] [stdout] ... | [INFO] [stdout] 361 | | proot: Res, [INFO] [stdout] 362 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GlobalTransform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:366:24 [INFO] [stdout] | [INFO] [stdout] 366 | let my_gtran = my_gtran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*my_gtran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/physics/logic.rs:370:32 [INFO] [stdout] | [INFO] [stdout] 370 | let mut my_dyno_tran = my_dyno_tran.map(|inner| inner.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `my_dyno_tran.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/physics/logic.rs:371:31 [INFO] [stdout] | [INFO] [stdout] 371 | let mut my_dyno_rot = my_dyno_rot.map(|inner| inner.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `my_dyno_rot.cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:372:27 [INFO] [stdout] | [INFO] [stdout] 372 | let mut my_tran = my_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*my_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:485:22 [INFO] [stdout] | [INFO] [stdout] 485 | mut stuck_dynos: Query< [INFO] [stdout] | ______________________^ [INFO] [stdout] 486 | | ( [INFO] [stdout] 487 | | Entity, [INFO] [stdout] 488 | | &Stuck, [INFO] [stdout] ... | [INFO] [stdout] 499 | | ), [INFO] [stdout] 500 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/physics/logic.rs:403:25 [INFO] [stdout] | [INFO] [stdout] 403 | &mut my_static_rx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `my_static_rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/physics/logic.rs:404:25 [INFO] [stdout] | [INFO] [stdout] 404 | &mut my_dyno_tran, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: change this to: `my_dyno_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:413:42 [INFO] [stdout] | [INFO] [stdout] 413 | let mut mid_step_gtran = my_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `my_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Transform` which implements the `Copy` trait [INFO] [stdout] --> src/physics/logic.rs:444:42 [INFO] [stdout] | [INFO] [stdout] 444 | let mut mid_step_gtran = my_tran.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `my_tran` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/logic.rs:485:22 [INFO] [stdout] | [INFO] [stdout] 485 | mut stuck_dynos: Query< [INFO] [stdout] | ______________________^ [INFO] [stdout] 486 | | ( [INFO] [stdout] 487 | | Entity, [INFO] [stdout] 488 | | &Stuck, [INFO] [stdout] ... | [INFO] [stdout] 499 | | ), [INFO] [stdout] 500 | | >, [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/patrol.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | mut patrol_watch: Query<( [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | Entity, [INFO] [stdout] 106 | | &PatrolWatch, [INFO] [stdout] 107 | | Option<&mut PatrolActive>, [INFO] [stdout] 108 | | &GlobalTransform, [INFO] [stdout] 109 | | )>, [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/physics/patrol.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if seen_targets.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `seen_targets.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/physics/patrol.rs:104:23 [INFO] [stdout] | [INFO] [stdout] 104 | mut patrol_watch: Query<( [INFO] [stdout] | _______________________^ [INFO] [stdout] 105 | | Entity, [INFO] [stdout] 106 | | &PatrolWatch, [INFO] [stdout] 107 | | Option<&mut PatrolActive>, [INFO] [stdout] 108 | | &GlobalTransform, [INFO] [stdout] 109 | | )>, [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/physics/patrol.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if seen_targets.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `seen_targets.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (13/7) [INFO] [stdout] --> src/roots.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / fn setup_roots( [INFO] [stdout] 56 | | mut commands: Commands, [INFO] [stdout] 57 | | $( [INFO] [stdout] 58 | | #[allow(nonstandard_style)] [INFO] [stdout] 59 | | mut [<$name _res>]: ResMut<$name>, [INFO] [stdout] 60 | | )* [INFO] [stdout] 61 | | ) { [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 95 | / impl_root_init!( [INFO] [stdout] 96 | | CollisionRoot, [INFO] [stdout] 97 | | ConvoRoot, [INFO] [stdout] 98 | | CutsceneRoot, [INFO] [stdout] ... | [INFO] [stdout] 117 | | TutorialRoot [INFO] [stdout] 118 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: this warning originates in the macro `impl_root_init` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (13/7) [INFO] [stdout] --> src/roots.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | / fn setup_roots( [INFO] [stdout] 56 | | mut commands: Commands, [INFO] [stdout] 57 | | $( [INFO] [stdout] 58 | | #[allow(nonstandard_style)] [INFO] [stdout] 59 | | mut [<$name _res>]: ResMut<$name>, [INFO] [stdout] 60 | | )* [INFO] [stdout] 61 | | ) { [INFO] [stdout] | |_____________^ [INFO] [stdout] ... [INFO] [stdout] 95 | / impl_root_init!( [INFO] [stdout] 96 | | CollisionRoot, [INFO] [stdout] 97 | | ConvoRoot, [INFO] [stdout] 98 | | CutsceneRoot, [INFO] [stdout] ... | [INFO] [stdout] 117 | | TutorialRoot [INFO] [stdout] 118 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: this warning originates in the macro `impl_root_init` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/state/room.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / match sources.get_room_state() { [INFO] [stdout] 107 | | Some(room_state) => Some(room_state.encounter_state.kind), [INFO] [stdout] 108 | | None => None, [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ help: try: `sources.get_room_state().map(|room_state| room_state.encounter_state.kind)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/state/room.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / match sources.get_room_state() { [INFO] [stdout] 118 | | Some(room_state) => Some(room_state.encounter_state.progress), [INFO] [stdout] 119 | | None => None, [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ help: try: `sources.get_room_state().map(|room_state| room_state.encounter_state.progress)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/state/room.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | / match sources.get_room_state() { [INFO] [stdout] 129 | | Some(room_state) => Some(room_state.encounter_state), [INFO] [stdout] 130 | | None => None, [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________^ help: try: `sources.get_room_state().map(|room_state| room_state.encounter_state)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/state/room.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | / match sources.get_room_state() { [INFO] [stdout] 107 | | Some(room_state) => Some(room_state.encounter_state.kind), [INFO] [stdout] 108 | | None => None, [INFO] [stdout] 109 | | } [INFO] [stdout] | |_________^ help: try: `sources.get_room_state().map(|room_state| room_state.encounter_state.kind)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/state/room.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / match sources.get_room_state() { [INFO] [stdout] 118 | | Some(room_state) => Some(room_state.encounter_state.progress), [INFO] [stdout] 119 | | None => None, [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ help: try: `sources.get_room_state().map(|room_state| room_state.encounter_state.progress)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/state/room.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | / match sources.get_room_state() { [INFO] [stdout] 129 | | Some(room_state) => Some(room_state.encounter_state), [INFO] [stdout] 130 | | None => None, [INFO] [stdout] 131 | | } [INFO] [stdout] | |_________^ help: try: `sources.get_room_state().map(|room_state| room_state.encounter_state)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MenuState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:52:49 [INFO] [stdout] | [INFO] [stdout] 52 | MetaState::Menu(menu_state) => Some(menu_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*menu_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CutsceneState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:59:57 [INFO] [stdout] | [INFO] [stdout] 59 | MetaState::Cutscene(cutscene_state) => Some(cutscene_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*cutscene_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TutorialState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:66:57 [INFO] [stdout] | [INFO] [stdout] 66 | MetaState::Tutorial(tutorial_state) => Some(tutorial_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tutorial_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RoomState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:73:49 [INFO] [stdout] | [INFO] [stdout] 73 | MetaState::Room(room_state) => Some(room_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*room_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `MenuState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:52:49 [INFO] [stdout] | [INFO] [stdout] 52 | MetaState::Menu(menu_state) => Some(menu_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*menu_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CutsceneState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:59:57 [INFO] [stdout] | [INFO] [stdout] 59 | MetaState::Cutscene(cutscene_state) => Some(cutscene_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*cutscene_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TutorialState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:66:57 [INFO] [stdout] | [INFO] [stdout] 66 | MetaState::Tutorial(tutorial_state) => Some(tutorial_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*tutorial_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RoomState` which implements the `Copy` trait [INFO] [stdout] --> src/state/mod.rs:73:49 [INFO] [stdout] | [INFO] [stdout] 73 | MetaState::Room(room_state) => Some(room_state.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*room_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/state/mod.rs:165:42 [INFO] [stdout] | [INFO] [stdout] 165 | MetaTransitionState::Entering { .. } => Some(TransitionState::Entering), [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/state/mod.rs:165:42 [INFO] [stdout] | [INFO] [stdout] 165 | MetaTransitionState::Entering { .. } => Some(TransitionState::Entering), [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [optimized + debuginfo] target(s) in 3m 31s [INFO] running `Command { std: "docker" "inspect" "f13fa8dc70adb4593ff43712814e1efd96593064df93bda77cf5b75e3c15e152", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f13fa8dc70adb4593ff43712814e1efd96593064df93bda77cf5b75e3c15e152", kill_on_drop: false }` [INFO] [stdout] f13fa8dc70adb4593ff43712814e1efd96593064df93bda77cf5b75e3c15e152