[INFO] cloning repository https://github.com/dpleshkov/rust-dns-blocker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dpleshkov/rust-dns-blocker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdpleshkov%2Frust-dns-blocker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdpleshkov%2Frust-dns-blocker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ee1c2ff68f19587248f70ddb910d72d37e75af56 [INFO] linting dpleshkov/rust-dns-blocker against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdpleshkov%2Frust-dns-blocker" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dpleshkov/rust-dns-blocker [INFO] finished tweaking git repo https://github.com/dpleshkov/rust-dns-blocker [INFO] tweaked toml for git repo https://github.com/dpleshkov/rust-dns-blocker written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dpleshkov/rust-dns-blocker on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dpleshkov/rust-dns-blocker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustls-webpki v0.101.3 [INFO] [stderr] Downloaded pin-project-lite v0.2.10 [INFO] [stderr] Downloaded rustls v0.21.6 [INFO] [stderr] Downloaded webpki-roots v0.25.2 [INFO] [stderr] Downloaded hyper-rustls v0.24.1 [INFO] [stderr] Downloaded simple-dns v0.5.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7fe836bd5a5b63cb2871bac63648630b4249c1a73ef45f8c17ece6b79a80545a [INFO] running `Command { std: "docker" "start" "-a" "7fe836bd5a5b63cb2871bac63648630b4249c1a73ef45f8c17ece6b79a80545a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7fe836bd5a5b63cb2871bac63648630b4249c1a73ef45f8c17ece6b79a80545a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7fe836bd5a5b63cb2871bac63648630b4249c1a73ef45f8c17ece6b79a80545a", kill_on_drop: false }` [INFO] [stdout] 7fe836bd5a5b63cb2871bac63648630b4249c1a73ef45f8c17ece6b79a80545a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ce270c8a79f9867d62bc3678262c281b64e24098bef3778eb34b6792bc34f87 [INFO] running `Command { std: "docker" "start" "-a" "2ce270c8a79f9867d62bc3678262c281b64e24098bef3778eb34b6792bc34f87", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling rustls v0.21.6 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling proc-macro2 v1.0.63 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking simple-dns v0.5.3 [INFO] [stderr] Checking webpki-roots v0.25.2 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking ring v0.16.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rustls-pemfile v1.0.3 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Compiling syn v2.0.23 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rustls-webpki v0.101.3 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-rustls v0.24.1 [INFO] [stderr] Checking rust-dns-blocker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/resolver.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use hyper_rustls; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/resolver.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use simple_dns; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/resolver.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use hyper_rustls; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/resolver.rs:8:1 [INFO] [stdout] | [INFO] [stdout] 8 | use simple_dns; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolver.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/resolver.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !res.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `res.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/doh_listener.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Ok(response); [INFO] [stdout] 43 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/doh_listener.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / return Ok( [INFO] [stdout] 77 | | Response::builder() [INFO] [stdout] 78 | | .status(StatusCode::OK) [INFO] [stdout] 79 | | .header("content-type", "application/dns-message") [INFO] [stdout] 80 | | .body(Body::from(dns_response)).expect("Failure building body") [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ Ok( [INFO] [stdout] 77 + Response::builder() [INFO] [stdout] 78 + .status(StatusCode::OK) [INFO] [stdout] 79 + .header("content-type", "application/dns-message") [INFO] [stdout] 80 + .body(Body::from(dns_response)).expect("Failure building body") [INFO] [stdout] 81 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `hyper::Body` [INFO] [stdout] --> src/doh_listener.rs:74:51 [INFO] [stdout] | [INFO] [stdout] 74 | let dns_query = hyper::body::to_bytes(Body::from(req.into_body())).await.expect("Failure processing body"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Body::from()`: `req.into_body()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/filter.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return Filter { [INFO] [stdout] 12 | | names: HashSet::new() [INFO] [stdout] 13 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ Filter { [INFO] [stdout] 12 + names: HashSet::new() [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/doh_listener.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | return Ok(response); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - return Ok(response); [INFO] [stdout] 43 + Ok(response) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/doh_listener.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | / return Ok( [INFO] [stdout] 77 | | Response::builder() [INFO] [stdout] 78 | | .status(StatusCode::OK) [INFO] [stdout] 79 | | .header("content-type", "application/dns-message") [INFO] [stdout] 80 | | .body(Body::from(dns_response)).expect("Failure building body") [INFO] [stdout] 81 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 ~ Ok( [INFO] [stdout] 77 + Response::builder() [INFO] [stdout] 78 + .status(StatusCode::OK) [INFO] [stdout] 79 + .header("content-type", "application/dns-message") [INFO] [stdout] 80 + .body(Body::from(dns_response)).expect("Failure building body") [INFO] [stdout] 81 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `hyper::Body` [INFO] [stdout] --> src/doh_listener.rs:74:51 [INFO] [stdout] | [INFO] [stdout] 74 | let dns_query = hyper::body::to_bytes(Body::from(req.into_body())).await.expect("Failure processing body"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Body::from()`: `req.into_body()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/filter.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return Filter { [INFO] [stdout] 12 | | names: HashSet::new() [INFO] [stdout] 13 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ Filter { [INFO] [stdout] 12 + names: HashSet::new() [INFO] [stdout] 13 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.38s [INFO] running `Command { std: "docker" "inspect" "2ce270c8a79f9867d62bc3678262c281b64e24098bef3778eb34b6792bc34f87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ce270c8a79f9867d62bc3678262c281b64e24098bef3778eb34b6792bc34f87", kill_on_drop: false }` [INFO] [stdout] 2ce270c8a79f9867d62bc3678262c281b64e24098bef3778eb34b6792bc34f87