[INFO] cloning repository https://github.com/dotrocks/dls_simulation_tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dotrocks/dls_simulation_tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdotrocks%2Fdls_simulation_tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdotrocks%2Fdls_simulation_tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] eee08e3933c83bc2c14ae4b4c1ed338b32b6aea0 [INFO] linting dotrocks/dls_simulation_tool against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdotrocks%2Fdls_simulation_tool" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dotrocks/dls_simulation_tool [INFO] finished tweaking git repo https://github.com/dotrocks/dls_simulation_tool [INFO] tweaked toml for git repo https://github.com/dotrocks/dls_simulation_tool written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dotrocks/dls_simulation_tool on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dotrocks/dls_simulation_tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rfd v0.16.0 [INFO] [stderr] Downloaded const_fn v0.4.11 [INFO] [stderr] Downloaded toml_edit v0.23.9 [INFO] [stderr] Downloaded opener v0.8.3 [INFO] [stderr] Downloaded egui_plot v0.34.0 [INFO] [stderr] Downloaded lopdf v0.26.0 [INFO] [stderr] Downloaded zune-jpeg v0.5.6 [INFO] [stderr] Downloaded moxcms v0.7.10 [INFO] [stderr] Downloaded genpdf v0.2.0 [INFO] [stderr] Downloaded pom v3.4.0 [INFO] [stderr] Downloaded orbclient v0.3.49 [INFO] [stderr] Downloaded printpdf v0.3.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d8a5c6f30addcfd61b3600a6cd8f6b0f6076c367230fa669e2a271ed21d9f736 [INFO] running `Command { std: "docker" "start" "-a" "d8a5c6f30addcfd61b3600a6cd8f6b0f6076c367230fa669e2a271ed21d9f736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d8a5c6f30addcfd61b3600a6cd8f6b0f6076c367230fa669e2a271ed21d9f736", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8a5c6f30addcfd61b3600a6cd8f6b0f6076c367230fa669e2a271ed21d9f736", kill_on_drop: false }` [INFO] [stdout] d8a5c6f30addcfd61b3600a6cd8f6b0f6076c367230fa669e2a271ed21d9f736 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 22882add68647d192333956bda0a790eb310c887af66fdb4eadc9480c8816107 [INFO] running `Command { std: "docker" "start" "-a" "22882add68647d192333956bda0a790eb310c887af66fdb4eadc9480c8816107", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Checking wayland-sys v0.31.7 [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking quote v1.0.42 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking accesskit v0.21.1 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling standback v0.2.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking aligned v0.4.2 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Compiling toml_edit v0.23.9 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Checking epaint_default_fonts v0.33.3 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Compiling const_fn v0.4.11 [INFO] [stderr] Compiling glutin_egl_sys v0.7.1 [INFO] [stderr] Compiling glutin_glx_sys v0.6.1 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking accesskit_consumer v0.31.0 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking nix v0.30.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling time-macros-impl v0.1.2 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Compiling time v0.2.27 [INFO] [stderr] Compiling freetype-sys v0.20.1 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v6.0.0 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.20.0 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking time-macros v0.1.1 [INFO] [stderr] Checking zune-jpeg v0.5.6 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Compiling pathfinder_simd v0.5.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking pom v3.4.0 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking stb_truetype v0.3.1 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling font-kit v0.14.3 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking async-fs v2.2.0 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Compiling rfd v0.16.0 [INFO] [stderr] Checking float-ord v0.3.2 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking opener v0.8.3 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Checking moxcms v0.7.10 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking ndarray v0.17.1 [INFO] [stderr] Checking lopdf v0.26.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking av-scenechange v0.14.1 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Checking rav1e v0.8.1 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking plotters-bitmap v0.3.7 [INFO] [stderr] Checking printpdf v0.3.4 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking tokio v1.48.0 [INFO] [stderr] Checking ahash v0.8.12 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking winit v0.30.12 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking zvariant_utils v3.2.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking genpdf v0.2.0 [INFO] [stderr] Compiling zvariant_derive v5.8.0 [INFO] [stderr] Checking rand_distr v0.5.1 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling zvariant v5.8.0 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Compiling zbus_names v4.2.0 [INFO] [stderr] Compiling zbus_xml v5.0.2 [INFO] [stderr] Compiling zbus_macros v5.12.0 [INFO] [stderr] Checking zbus-lockstep v0.5.2 [INFO] [stderr] Checking egui_glow v0.33.3 [INFO] [stderr] Checking egui_plot v0.34.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.2 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking zbus v5.12.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking ashpd v0.11.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.2 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.2 [INFO] [stderr] Checking accesskit_winit v0.29.2 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking eframe v0.33.3 [INFO] [stderr] Checking dls_simulator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/gui.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use rfd; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/gui.rs:10:1 [INFO] [stdout] | [INFO] [stdout] 10 | use rfd; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/report.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use csv; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/report.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use opener; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/report.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use csv; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/report.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | use opener; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:263:25 [INFO] [stdout] | [INFO] [stdout] 263 | / if let Some(path) = rfd::FileDialog::new() [INFO] [stdout] 264 | | .add_filter("PDF Files", &["pdf"]) [INFO] [stdout] 265 | | .set_file_name(&default_name) [INFO] [stdout] 266 | | .save_file() [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 266 ~ .save_file() [INFO] [stdout] 267 ~ && let Err(err) = [INFO] [stdout] 268 | export_pdf(&path.to_string_lossy(), &self.params, results) [INFO] [stdout] 269 | { [INFO] [stdout] 270 | eprintln!("PDF export error: {err}"); [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | / if ui [INFO] [stdout] 277 | | .add_sized( [INFO] [stdout] 278 | | [ui.available_width(), 24.0], [INFO] [stdout] 279 | | egui::Button::new("Export CSVs").small(), [INFO] [stdout] ... | [INFO] [stdout] 290 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 281 ~ .clicked() [INFO] [stdout] 282 ~ && let Some(path) = rfd::FileDialog::new().pick_folder() { [INFO] [stdout] 283 | if let Err(err) = [INFO] [stdout] ... [INFO] [stdout] 287 | } [INFO] [stdout] 288 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | / if let Some(path) = rfd::FileDialog::new().pick_folder() { [INFO] [stdout] 284 | | if let Err(err) = [INFO] [stdout] 285 | | export_csv(&path.to_string_lossy(), &self.params, results) [INFO] [stdout] ... | [INFO] [stdout] 289 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 283 ~ if let Some(path) = rfd::FileDialog::new().pick_folder() [INFO] [stdout] 284 ~ && let Err(err) = [INFO] [stdout] 285 | export_csv(&path.to_string_lossy(), &self.params, results) [INFO] [stdout] 286 | { [INFO] [stdout] 287 | eprintln!("CSV export error: {err}"); [INFO] [stdout] 288 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | *weight = *weight / sum_weights; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*weight /= sum_weights` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `e_total` [INFO] [stdout] --> src/simulation.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | for j in 0..n_steps { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 74 - for j in 0..n_steps { [INFO] [stdout] 74 + for in e_total.iter_mut().take(n_steps) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | phi = phi + sqrt_2_gamma * dw; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `phi += sqrt_2_gamma * dw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | e_total[j] = e_total[j] + intensity_weights[i] * phi.cos(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e_total[j] += intensity_weights[i] * phi.cos()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | intensity = intensity + detector_noise; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity += detector_noise` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | sum_val = sum_val + intensity_weights[i] * (-gamma[i] * tau_val).exp(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_val += intensity_weights[i] * (-gamma[i] * tau_val).exp()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | k = k + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | p = p * random_val; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `p *= random_val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | histogram[bin_idx] = histogram[bin_idx] + w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram[bin_idx] += w` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | *h = *h / sum; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*h /= sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 294 | histogram[bin_idx] = histogram[bin_idx] + 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram[bin_idx] += 1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:299:13 [INFO] [stdout] | [INFO] [stdout] 299 | *h = *h / sum; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*h /= sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:263:25 [INFO] [stdout] | [INFO] [stdout] 263 | / if let Some(path) = rfd::FileDialog::new() [INFO] [stdout] 264 | | .add_filter("PDF Files", &["pdf"]) [INFO] [stdout] 265 | | .set_file_name(&default_name) [INFO] [stdout] 266 | | .save_file() [INFO] [stdout] ... | [INFO] [stdout] 273 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 266 ~ .save_file() [INFO] [stdout] 267 ~ && let Err(err) = [INFO] [stdout] 268 | export_pdf(&path.to_string_lossy(), &self.params, results) [INFO] [stdout] 269 | { [INFO] [stdout] 270 | eprintln!("PDF export error: {err}"); [INFO] [stdout] 271 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:276:21 [INFO] [stdout] | [INFO] [stdout] 276 | / if ui [INFO] [stdout] 277 | | .add_sized( [INFO] [stdout] 278 | | [ui.available_width(), 24.0], [INFO] [stdout] 279 | | egui::Button::new("Export CSVs").small(), [INFO] [stdout] ... | [INFO] [stdout] 290 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 281 ~ .clicked() [INFO] [stdout] 282 ~ && let Some(path) = rfd::FileDialog::new().pick_folder() { [INFO] [stdout] 283 | if let Err(err) = [INFO] [stdout] ... [INFO] [stdout] 287 | } [INFO] [stdout] 288 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:283:25 [INFO] [stdout] | [INFO] [stdout] 283 | / if let Some(path) = rfd::FileDialog::new().pick_folder() { [INFO] [stdout] 284 | | if let Err(err) = [INFO] [stdout] 285 | | export_csv(&path.to_string_lossy(), &self.params, results) [INFO] [stdout] ... | [INFO] [stdout] 289 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 283 ~ if let Some(path) = rfd::FileDialog::new().pick_folder() [INFO] [stdout] 284 ~ && let Err(err) = [INFO] [stdout] 285 | export_csv(&path.to_string_lossy(), &self.params, results) [INFO] [stdout] 286 | { [INFO] [stdout] 287 | eprintln!("CSV export error: {err}"); [INFO] [stdout] 288 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | *weight = *weight / sum_weights; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*weight /= sum_weights` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `e_total` [INFO] [stdout] --> src/simulation.rs:74:22 [INFO] [stdout] | [INFO] [stdout] 74 | for j in 0..n_steps { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 74 - for j in 0..n_steps { [INFO] [stdout] 74 + for in e_total.iter_mut().take(n_steps) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | phi = phi + sqrt_2_gamma * dw; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `phi += sqrt_2_gamma * dw` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | e_total[j] = e_total[j] + intensity_weights[i] * phi.cos(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `e_total[j] += intensity_weights[i] * phi.cos()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | intensity = intensity + detector_noise; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity += detector_noise` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:145:17 [INFO] [stdout] | [INFO] [stdout] 145 | sum_val = sum_val + intensity_weights[i] * (-gamma[i] * tau_val).exp(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sum_val += intensity_weights[i] * (-gamma[i] * tau_val).exp()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:208:17 [INFO] [stdout] | [INFO] [stdout] 208 | k = k + 1; [INFO] [stdout] | ^^^^^^^^^ help: replace it with: `k += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | p = p * random_val; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `p *= random_val` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / if generate_g1_plot(&image_path, result).is_ok() { [INFO] [stdout] 154 | | if let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 155 | | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 156 | | } [INFO] [stdout] 157 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if generate_g1_plot(&image_path, result).is_ok() [INFO] [stdout] 154 ~ && let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 155 | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:269:17 [INFO] [stdout] | [INFO] [stdout] 269 | histogram[bin_idx] = histogram[bin_idx] + w; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram[bin_idx] += w` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / if generate_g2_plot(&image_path, result).is_ok() { [INFO] [stdout] 164 | | if let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 165 | | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 166 | | } [INFO] [stdout] 167 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 163 ~ if generate_g2_plot(&image_path, result).is_ok() [INFO] [stdout] 164 ~ && let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 165 | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 166 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | *h = *h / sum; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*h /= sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | / if generate_size_plot(&image_path, result).is_ok() { [INFO] [stdout] 174 | | if let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 175 | | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 176 | | } [INFO] [stdout] 177 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 173 ~ if generate_size_plot(&image_path, result).is_ok() [INFO] [stdout] 174 ~ && let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 175 | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:294:17 [INFO] [stdout] | [INFO] [stdout] 294 | histogram[bin_idx] = histogram[bin_idx] + 1.0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `histogram[bin_idx] += 1.0` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/simulation.rs:299:13 [INFO] [stdout] | [INFO] [stdout] 299 | *h = *h / sum; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `*h /= sum` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:255:70 [INFO] [stdout] | [INFO] [stdout] 255 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &RED)); [INFO] [stdout] | ^^^^ help: change this to: `RED` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:259:70 [INFO] [stdout] | [INFO] [stdout] 259 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &GREEN)); [INFO] [stdout] | ^^^^^^ help: change this to: `GREEN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:263:27 [INFO] [stdout] | [INFO] [stdout] 263 | .background_style(&WHITE) [INFO] [stdout] | ^^^^^^ help: change this to: `WHITE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:341:70 [INFO] [stdout] | [INFO] [stdout] 341 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &BLUE)); [INFO] [stdout] | ^^^^^ help: change this to: `BLUE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:345:70 [INFO] [stdout] | [INFO] [stdout] 345 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &GREEN)); [INFO] [stdout] | ^^^^^^ help: change this to: `GREEN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:350:27 [INFO] [stdout] | [INFO] [stdout] 350 | .background_style(&WHITE) [INFO] [stdout] | ^^^^^^ help: change this to: `WHITE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:434:70 [INFO] [stdout] | [INFO] [stdout] 434 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &GREEN)); [INFO] [stdout] | ^^^^^^ help: change this to: `GREEN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:446:70 [INFO] [stdout] | [INFO] [stdout] 446 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &BLUE)); [INFO] [stdout] | ^^^^^ help: change this to: `BLUE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:450:27 [INFO] [stdout] | [INFO] [stdout] 450 | .background_style(&WHITE) [INFO] [stdout] | ^^^^^^ help: change this to: `WHITE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:474:26 [INFO] [stdout] | [INFO] [stdout] 474 | wtr.write_record(&["Size (nm)", "Intensity Distribution", "Number Distribution"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Size (nm)", "Intensity Distribution", "Number Distribution"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:501:26 [INFO] [stdout] | [INFO] [stdout] 501 | wtr.write_record(&["Tau (s)", "g2 Numeric Noisy", "g2 Theory"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Tau (s)", "g2 Numeric Noisy", "g2 Theory"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:516:26 [INFO] [stdout] | [INFO] [stdout] 516 | wtr.write_record(&["Tau (s)", "g1 Numeric Ideal", "g1 Theory"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Tau (s)", "g1 Numeric Ideal", "g1 Theory"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:531:26 [INFO] [stdout] | [INFO] [stdout] 531 | wtr.write_record(&[ [INFO] [stdout] | __________________________^ [INFO] [stdout] 532 | | "Time (s)", [INFO] [stdout] 533 | | "Intensity Ideal (a.u.)", [INFO] [stdout] 534 | | "Intensity Noisy (a.u.)", [INFO] [stdout] 535 | | ])?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 531 ~ wtr.write_record([ [INFO] [stdout] 532 + "Time (s)", [INFO] [stdout] 533 + "Intensity Ideal (a.u.)", [INFO] [stdout] 534 + "Intensity Noisy (a.u.)", [INFO] [stdout] 535 ~ ])?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:553:26 [INFO] [stdout] | [INFO] [stdout] 553 | wtr.write_record(&["Particle Size (nm)", "Intensity Weight"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Particle Size (nm)", "Intensity Weight"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:153:9 [INFO] [stdout] | [INFO] [stdout] 153 | / if generate_g1_plot(&image_path, result).is_ok() { [INFO] [stdout] 154 | | if let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 155 | | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 156 | | } [INFO] [stdout] 157 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 153 ~ if generate_g1_plot(&image_path, result).is_ok() [INFO] [stdout] 154 ~ && let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 155 | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 156 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | / if generate_g2_plot(&image_path, result).is_ok() { [INFO] [stdout] 164 | | if let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 165 | | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 166 | | } [INFO] [stdout] 167 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 163 ~ if generate_g2_plot(&image_path, result).is_ok() [INFO] [stdout] 164 ~ && let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 165 | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 166 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/report.rs:173:9 [INFO] [stdout] | [INFO] [stdout] 173 | / if generate_size_plot(&image_path, result).is_ok() { [INFO] [stdout] 174 | | if let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 175 | | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 176 | | } [INFO] [stdout] 177 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 173 ~ if generate_size_plot(&image_path, result).is_ok() [INFO] [stdout] 174 ~ && let Ok(img) = elements::Image::from_path(&image_path) { [INFO] [stdout] 175 | doc.push(img.with_alignment(Alignment::Center)); [INFO] [stdout] 176 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:255:70 [INFO] [stdout] | [INFO] [stdout] 255 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &RED)); [INFO] [stdout] | ^^^^ help: change this to: `RED` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:259:70 [INFO] [stdout] | [INFO] [stdout] 259 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &GREEN)); [INFO] [stdout] | ^^^^^^ help: change this to: `GREEN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:263:27 [INFO] [stdout] | [INFO] [stdout] 263 | .background_style(&WHITE) [INFO] [stdout] | ^^^^^^ help: change this to: `WHITE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:341:70 [INFO] [stdout] | [INFO] [stdout] 341 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &BLUE)); [INFO] [stdout] | ^^^^^ help: change this to: `BLUE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:345:70 [INFO] [stdout] | [INFO] [stdout] 345 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &GREEN)); [INFO] [stdout] | ^^^^^^ help: change this to: `GREEN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:350:27 [INFO] [stdout] | [INFO] [stdout] 350 | .background_style(&WHITE) [INFO] [stdout] | ^^^^^^ help: change this to: `WHITE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:434:70 [INFO] [stdout] | [INFO] [stdout] 434 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &GREEN)); [INFO] [stdout] | ^^^^^^ help: change this to: `GREEN` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:446:70 [INFO] [stdout] | [INFO] [stdout] 446 | .legend(|(x, y)| PathElement::new(vec![(x, y), (x + 20, y)], &BLUE)); [INFO] [stdout] | ^^^^^ help: change this to: `BLUE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:450:27 [INFO] [stdout] | [INFO] [stdout] 450 | .background_style(&WHITE) [INFO] [stdout] | ^^^^^^ help: change this to: `WHITE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:474:26 [INFO] [stdout] | [INFO] [stdout] 474 | wtr.write_record(&["Size (nm)", "Intensity Distribution", "Number Distribution"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Size (nm)", "Intensity Distribution", "Number Distribution"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:501:26 [INFO] [stdout] | [INFO] [stdout] 501 | wtr.write_record(&["Tau (s)", "g2 Numeric Noisy", "g2 Theory"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Tau (s)", "g2 Numeric Noisy", "g2 Theory"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:516:26 [INFO] [stdout] | [INFO] [stdout] 516 | wtr.write_record(&["Tau (s)", "g1 Numeric Ideal", "g1 Theory"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Tau (s)", "g1 Numeric Ideal", "g1 Theory"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:531:26 [INFO] [stdout] | [INFO] [stdout] 531 | wtr.write_record(&[ [INFO] [stdout] | __________________________^ [INFO] [stdout] 532 | | "Time (s)", [INFO] [stdout] 533 | | "Intensity Ideal (a.u.)", [INFO] [stdout] 534 | | "Intensity Noisy (a.u.)", [INFO] [stdout] 535 | | ])?; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 531 ~ wtr.write_record([ [INFO] [stdout] 532 + "Time (s)", [INFO] [stdout] 533 + "Intensity Ideal (a.u.)", [INFO] [stdout] 534 + "Intensity Noisy (a.u.)", [INFO] [stdout] 535 ~ ])?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/report.rs:553:26 [INFO] [stdout] | [INFO] [stdout] 553 | wtr.write_record(&["Particle Size (nm)", "Intensity Weight"])?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Particle Size (nm)", "Intensity Weight"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.22s [INFO] running `Command { std: "docker" "inspect" "22882add68647d192333956bda0a790eb310c887af66fdb4eadc9480c8816107", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "22882add68647d192333956bda0a790eb310c887af66fdb4eadc9480c8816107", kill_on_drop: false }` [INFO] [stdout] 22882add68647d192333956bda0a790eb310c887af66fdb4eadc9480c8816107