[INFO] cloning repository https://github.com/domaschh/adventofcode23 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/domaschh/adventofcode23" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdomaschh%2Fadventofcode23", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdomaschh%2Fadventofcode23'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f7a9b843bba5026279527293f69bf68ab3487ecb [INFO] linting domaschh/adventofcode23 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdomaschh%2Fadventofcode23" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/domaschh/adventofcode23 [INFO] finished tweaking git repo https://github.com/domaschh/adventofcode23 [INFO] tweaked toml for git repo https://github.com/domaschh/adventofcode23 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/domaschh/adventofcode23 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/domaschh/adventofcode23 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded gcd v2.3.0 [INFO] [stderr] Downloaded array_map v0.4.0 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.15 [INFO] [stderr] Downloaded rayon-core v1.12.0 [INFO] [stderr] Downloaded memoffset v0.9.0 [INFO] [stderr] Downloaded strum v0.25.0 [INFO] [stderr] Downloaded crossbeam-deque v0.8.3 [INFO] [stderr] Downloaded rayon v1.8.0 [INFO] [stderr] Downloaded itertools v0.12.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 186f2f2806927688dd410c501b742a0101a52f591014bb31e040e3b68b656650 [INFO] running `Command { std: "docker" "start" "-a" "186f2f2806927688dd410c501b742a0101a52f591014bb31e040e3b68b656650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "186f2f2806927688dd410c501b742a0101a52f591014bb31e040e3b68b656650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "186f2f2806927688dd410c501b742a0101a52f591014bb31e040e3b68b656650", kill_on_drop: false }` [INFO] [stdout] 186f2f2806927688dd410c501b742a0101a52f591014bb31e040e3b68b656650 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad303b70a0d3d25207ced9b07dcc91f85cdc7b59eca90268b80c98d855fc1430 [INFO] running `Command { std: "docker" "start" "-a" "ad303b70a0d3d25207ced9b07dcc91f85cdc7b59eca90268b80c98d855fc1430", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking gcd v2.3.0 [INFO] [stderr] Checking array_map v0.4.0 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking itertools v0.12.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking adventcode23 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `time::Instant` [INFO] [stdout] --> src/days/dayseven.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, time::Instant}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/days/dayseven.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | const CHARS: [&'static str; 14] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::Instant` [INFO] [stdout] --> src/days/dayseven.rs:1:33 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{collections::HashMap, time::Instant}; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/days/dayseven.rs:5:16 [INFO] [stdout] | [INFO] [stdout] 5 | const CHARS: [&'static str; 14] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dayfive2` is never used [INFO] [stdout] --> src/days/dayfive.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 126 | pub(crate) fn dayfive2(filename: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/dayeight.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | let instr_sequence_str = lines.get(0).ok_or("No first line")?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/dayeight.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | split.nth(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `split.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `count` is used as a loop counter [INFO] [stdout] --> src/days/dayeight.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | for instruction in instr_sequence_str.chars().cycle() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (count, instruction) in instr_sequence_str.chars().cycle().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/dayeight.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | let instr_sequence_str = lines.get(0).ok_or("No first line")?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/dayeight.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | split.nth(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `split.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/days/dayeight.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | .reduce(|acc, v| lcm(acc, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `lcm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/dayeight.rs:110:31 [INFO] [stdout] | [INFO] [stdout] 110 | fn get_or_set(f_z_encounters: &mut Vec>, i: usize, count: u64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn get_or_set(f_z_encounters: &mut Vec>, i: usize, count: u64) { [INFO] [stdout] 110 + fn get_or_set(f_z_encounters: &mut [Option], i: usize, count: u64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/days/daynine.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 54 - (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] 54 + (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then_some(diff_seq) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/days/daynine.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 70 - (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] 70 + (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then_some(diff_seq) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/days/dayseven.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 73 | / let strength_type = match scores[0] { [INFO] [stdout] 74 | | 5 => HandType::FiveOfAKind, [INFO] [stdout] 75 | | 4 => HandType::FourOfAKind, [INFO] [stdout] 76 | | 3 => { [INFO] [stdout] ... | [INFO] [stdout] 90 | | _ => HandType::HighCard, [INFO] [stdout] 91 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 92 | [INFO] [stdout] 93 | strength_type [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 73 ~ [INFO] [stdout] 74 | [INFO] [stdout] 75 ~ match scores[0] { [INFO] [stdout] 76 + 5 => HandType::FiveOfAKind, [INFO] [stdout] 77 + 4 => HandType::FourOfAKind, [INFO] [stdout] 78 + 3 => { [INFO] [stdout] 79 + if scores[1] == 2 { [INFO] [stdout] 80 + HandType::FullHouse [INFO] [stdout] 81 + } else { [INFO] [stdout] 82 + HandType::ThreeOfAKind [INFO] [stdout] 83 + } [INFO] [stdout] 84 + } [INFO] [stdout] 85 + 2 => { [INFO] [stdout] 86 + if scores[1] == 2 { [INFO] [stdout] 87 + HandType::TwoPair [INFO] [stdout] 88 + } else { [INFO] [stdout] 89 + HandType::OnePair [INFO] [stdout] 90 + } [INFO] [stdout] 91 + } [INFO] [stdout] 92 + _ => HandType::HighCard, [INFO] [stdout] 93 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `input.get(0)` [INFO] [stdout] --> src/days/daysix.rs:35:25 [INFO] [stdout] | [INFO] [stdout] 35 | let time_str_iter = input [INFO] [stdout] | _________________________^ [INFO] [stdout] 36 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `input.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `input.get(0)` [INFO] [stdout] --> src/days/daysix.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | let time: i64 = input [INFO] [stdout] | _____________________^ [INFO] [stdout] 60 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `input.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `input.get(0)` [INFO] [stdout] --> src/days/daysix.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | let distance: i64 = input [INFO] [stdout] | _________________________^ [INFO] [stdout] 70 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `input.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/dayten.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 194 | fn shoelace_area(points: &Vec) -> isize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 194 - fn shoelace_area(points: &Vec) -> isize { [INFO] [stdout] 194 + fn shoelace_area(points: &[Coord]) -> isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/days/dayten.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 209 | (area as isize).abs() / 2 [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/daythirteen.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return None; [INFO] [stdout] 31 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/daythirteen.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | if valid && (!part2 || *part2 == !flipped) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*part2 != flipped` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/daythirteen.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return num_repr; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return num_repr; [INFO] [stdout] 42 + num_repr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/daythree.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | let width = lines.get(0).map(|t| t.1.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/daythree.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | let width = lines.get(0).map(|t| t.1.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/days/daytwelve.rs:5:45 [INFO] [stdout] | [INFO] [stdout] 5 | let line_bytes: Vec<&str> = bytes.split(|b| b == '\n').collect_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using a `char`: `'\n'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `dayfive2` is never used [INFO] [stdout] --> src/days/dayfive.rs:126:15 [INFO] [stdout] | [INFO] [stdout] 126 | pub(crate) fn dayfive2(filename: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/days/daytwelve.rs:17:45 [INFO] [stdout] | [INFO] [stdout] 17 | let line_bytes: Vec<&str> = bytes.split(|b| b == '\n').collect_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using a `char`: `'\n'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/dayeight.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | let instr_sequence_str = lines.get(0).ok_or("No first line")?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/dayeight.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | split.nth(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `split.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `count` is used as a loop counter [INFO] [stdout] --> src/days/dayeight.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | for instruction in instr_sequence_str.chars().cycle() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (count, instruction) in instr_sequence_str.chars().cycle().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/dayeight.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | let instr_sequence_str = lines.get(0).ok_or("No first line")?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> src/days/dayeight.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 61 | split.nth(0).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `split.next()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/days/dayeight.rs:83:25 [INFO] [stdout] | [INFO] [stdout] 83 | .reduce(|acc, v| lcm(acc, v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `lcm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/dayeight.rs:110:31 [INFO] [stdout] | [INFO] [stdout] 110 | fn get_or_set(f_z_encounters: &mut Vec>, i: usize, count: u64) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn get_or_set(f_z_encounters: &mut Vec>, i: usize, count: u64) { [INFO] [stdout] 110 + fn get_or_set(f_z_encounters: &mut [Option], i: usize, count: u64) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/days/dayten.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | fn iter(&self, dir: Delta) -> PipeWalk { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 70 | fn iter(&self, dir: Delta) -> PipeWalk<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/days/daynine.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] = note: `#[warn(clippy::unnecessary_lazy_evaluations)]` on by default [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 54 - (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] 54 + (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then_some(diff_seq) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary closure used with `bool::then` [INFO] [stdout] --> src/days/daynine.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_lazy_evaluations [INFO] [stdout] help: use `then_some` instead [INFO] [stdout] | [INFO] [stdout] 70 - (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then(|| diff_seq) [INFO] [stdout] 70 + (!diff_seq.is_empty() && diff_seq.iter().any(|&x| x != T::from(0_u8))).then_some(diff_seq) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/days/dayseven.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 73 | / let strength_type = match scores[0] { [INFO] [stdout] 74 | | 5 => HandType::FiveOfAKind, [INFO] [stdout] 75 | | 4 => HandType::FourOfAKind, [INFO] [stdout] 76 | | 3 => { [INFO] [stdout] ... | [INFO] [stdout] 90 | | _ => HandType::HighCard, [INFO] [stdout] 91 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 92 | [INFO] [stdout] 93 | strength_type [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 73 ~ [INFO] [stdout] 74 | [INFO] [stdout] 75 ~ match scores[0] { [INFO] [stdout] 76 + 5 => HandType::FiveOfAKind, [INFO] [stdout] 77 + 4 => HandType::FourOfAKind, [INFO] [stdout] 78 + 3 => { [INFO] [stdout] 79 + if scores[1] == 2 { [INFO] [stdout] 80 + HandType::FullHouse [INFO] [stdout] 81 + } else { [INFO] [stdout] 82 + HandType::ThreeOfAKind [INFO] [stdout] 83 + } [INFO] [stdout] 84 + } [INFO] [stdout] 85 + 2 => { [INFO] [stdout] 86 + if scores[1] == 2 { [INFO] [stdout] 87 + HandType::TwoPair [INFO] [stdout] 88 + } else { [INFO] [stdout] 89 + HandType::OnePair [INFO] [stdout] 90 + } [INFO] [stdout] 91 + } [INFO] [stdout] 92 + _ => HandType::HighCard, [INFO] [stdout] 93 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `input.get(0)` [INFO] [stdout] --> src/days/daysix.rs:35:25 [INFO] [stdout] | [INFO] [stdout] 35 | let time_str_iter = input [INFO] [stdout] | _________________________^ [INFO] [stdout] 36 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `input.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `input.get(0)` [INFO] [stdout] --> src/days/daysix.rs:59:21 [INFO] [stdout] | [INFO] [stdout] 59 | let time: i64 = input [INFO] [stdout] | _____________________^ [INFO] [stdout] 60 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `input.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `input.get(0)` [INFO] [stdout] --> src/days/daysix.rs:69:25 [INFO] [stdout] | [INFO] [stdout] 69 | let distance: i64 = input [INFO] [stdout] | _________________________^ [INFO] [stdout] 70 | | .get(0) [INFO] [stdout] | |_______________^ help: try: `input.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/days/dayten.rs:194:26 [INFO] [stdout] | [INFO] [stdout] 194 | fn shoelace_area(points: &Vec) -> isize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 194 - fn shoelace_area(points: &Vec) -> isize { [INFO] [stdout] 194 + fn shoelace_area(points: &[Coord]) -> isize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`isize` -> `isize`) [INFO] [stdout] --> src/days/dayten.rs:209:5 [INFO] [stdout] | [INFO] [stdout] 209 | (area as isize).abs() / 2 [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/daythirteen.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return None; [INFO] [stdout] 31 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/days/daythirteen.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | if valid && (!part2 || *part2 == !flipped) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `*part2 != flipped` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/days/daythirteen.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return num_repr; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return num_repr; [INFO] [stdout] 42 + num_repr [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/daythree.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | let width = lines.get(0).map(|t| t.1.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `lines.get(0)` [INFO] [stdout] --> src/days/daythree.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | let width = lines.get(0).map(|t| t.1.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `lines.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/days/daytwelve.rs:5:45 [INFO] [stdout] | [INFO] [stdout] 5 | let line_bytes: Vec<&str> = bytes.split(|b| b == '\n').collect_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using a `char`: `'\n'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/days/daytwelve.rs:17:45 [INFO] [stdout] | [INFO] [stdout] 17 | let line_bytes: Vec<&str> = bytes.split(|b| b == '\n').collect_vec(); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using a `char`: `'\n'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/days/dayten.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | fn iter(&self, dir: Delta) -> PipeWalk { [INFO] [stdout] | ^^^^^ ^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 70 | fn iter(&self, dir: Delta) -> PipeWalk<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.24s [INFO] running `Command { std: "docker" "inspect" "ad303b70a0d3d25207ced9b07dcc91f85cdc7b59eca90268b80c98d855fc1430", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad303b70a0d3d25207ced9b07dcc91f85cdc7b59eca90268b80c98d855fc1430", kill_on_drop: false }` [INFO] [stdout] ad303b70a0d3d25207ced9b07dcc91f85cdc7b59eca90268b80c98d855fc1430