[INFO] cloning repository https://github.com/dogHere/rust-bst
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dogHere/rust-bst" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdogHere%2Frust-bst", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdogHere%2Frust-bst'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 39ad6b0b42bd5f4095800d2a1eb99f8492716f88
[INFO] linting dogHere/rust-bst against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdogHere%2Frust-bst" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/dogHere/rust-bst
[INFO] finished tweaking git repo https://github.com/dogHere/rust-bst
[INFO] tweaked toml for git repo https://github.com/dogHere/rust-bst written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/dogHere/rust-bst on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/dogHere/rust-bst already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] c43f42ad36197855c90bac3f2991cd114bfd1887849d93daee1cb750960411d6
[INFO] running `Command { std: "docker" "start" "-a" "c43f42ad36197855c90bac3f2991cd114bfd1887849d93daee1cb750960411d6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "c43f42ad36197855c90bac3f2991cd114bfd1887849d93daee1cb750960411d6", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c43f42ad36197855c90bac3f2991cd114bfd1887849d93daee1cb750960411d6", kill_on_drop: false }`
[INFO] [stdout] c43f42ad36197855c90bac3f2991cd114bfd1887849d93daee1cb750960411d6
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] bf53e4552ddbf6f7225c0e7b1dc2d30b4c2b42193bc31bf9eea4fc5b4e2d73c3
[INFO] running `Command { std: "docker" "start" "-a" "bf53e4552ddbf6f7225c0e7b1dc2d30b4c2b42193bc31bf9eea4fc5b4e2d73c3", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr]     Checking bst_rs v0.2.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]   --> src/tree.rs:31:21
[INFO] [stdout]    |
[INFO] [stdout] 31 |                     swap(&mut self.right, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `self.right = Some(Box::from(Node::new(value)))`
[INFO] [stdout]    |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]   --> src/tree.rs:31:48
[INFO] [stdout]    |
[INFO] [stdout] 31 |                     swap(&mut self.right, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout]    = note: `#[warn(clippy::swap_with_temporary)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]   --> src/tree.rs:40:21
[INFO] [stdout]    |
[INFO] [stdout] 40 |                     swap(&mut self.left, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `self.left = Some(Box::from(Node::new(value)))`
[INFO] [stdout]    |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]   --> src/tree.rs:40:47
[INFO] [stdout]    |
[INFO] [stdout] 40 |                     swap(&mut self.left, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:52:38
[INFO] [stdout]    |
[INFO] [stdout] 52 |             Some(ref n) => Node::min(&*n)
[INFO] [stdout]    |                                      ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout]    = note: `#[warn(clippy::borrow_deref_ref)]` on by default
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 52 -             Some(ref n) => Node::min(&*n)
[INFO] [stdout] 52 +             Some(ref n) => Node::min(n)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 52 |             Some(ref n) => Node::min(&**n)
[INFO] [stdout]    |                                        +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:59:38
[INFO] [stdout]    |
[INFO] [stdout] 59 |             Some(ref n) => Node::max(&*n)
[INFO] [stdout]    |                                      ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 59 -             Some(ref n) => Node::max(&*n)
[INFO] [stdout] 59 +             Some(ref n) => Node::max(n)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 59 |             Some(ref n) => Node::max(&**n)
[INFO] [stdout]    |                                        +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Box<&Node<T>>`
[INFO] [stdout]   --> src/tree.rs:63:41
[INFO] [stdout]    |
[INFO] [stdout] 63 |     fn find(&self, value: &T) -> Option<Box<&Node<T>>> {
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^ help: try: `&Node<T>`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `&Node<T>` is already a pointer, `Box<&Node<T>>` allocates a pointer on the heap
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation
[INFO] [stdout]    = note: `#[warn(clippy::redundant_allocation)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:67:43
[INFO] [stdout]    |
[INFO] [stdout] 67 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                           ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 67 -                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout] 67 +                 Some(ref n) => Node::find(n, &value)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 67 |                 Some(ref n) => Node::find(&**n, &value)
[INFO] [stdout]    |                                             +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/tree.rs:67:48
[INFO] [stdout]    |
[INFO] [stdout] 67 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                                ^^^^^^ help: change this to: `value`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:72:43
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                           ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 72 -                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout] 72 +                 Some(ref n) => Node::find(n, &value)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 Some(ref n) => Node::find(&**n, &value)
[INFO] [stdout]    |                                             +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/tree.rs:72:48
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                                ^^^^^^ help: change this to: `value`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/tree.rs:85:20
[INFO] [stdout]    |
[INFO] [stdout] 85 |                 if !r.left.is_some() && !r.right.is_some() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^ help: try: `r.left.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/tree.rs:85:41
[INFO] [stdout]    |
[INFO] [stdout] 85 |                 if !r.left.is_some() && !r.right.is_some() {
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^ help: try: `r.right.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]   --> src/tree.rs:96:29
[INFO] [stdout]    |
[INFO] [stdout] 96 | ...                   swap(&mut None, &mut r.left);
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `r.left = None`
[INFO] [stdout]    |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]   --> src/tree.rs:96:39
[INFO] [stdout]    |
[INFO] [stdout] 96 | ...                   swap(&mut None, &mut r.left);
[INFO] [stdout]    |                                 ^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]    --> src/tree.rs:100:29
[INFO] [stdout]     |
[INFO] [stdout] 100 | ...                   swap(&mut None, &mut r.right);
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `r.right = None`
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:100:39
[INFO] [stdout]     |
[INFO] [stdout] 100 | ...                   swap(&mut None, &mut r.right);
[INFO] [stdout]     |                                 ^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping temporary values has no effect
[INFO] [stdout]    --> src/tree.rs:103:29
[INFO] [stdout]     |
[INFO] [stdout] 103 | ...                   swap(&mut None, &mut r.find(&m));
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:103:39
[INFO] [stdout]     |
[INFO] [stdout] 103 | ...                   swap(&mut None, &mut r.find(&m));
[INFO] [stdout]     |                                 ^^^^
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:103:50
[INFO] [stdout]     |
[INFO] [stdout] 103 | ...                   swap(&mut None, &mut r.find(&m));
[INFO] [stdout]     |                                            ^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]    --> src/tree.rs:111:13
[INFO] [stdout]     |
[INFO] [stdout] 111 |             swap(node, &mut None);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `*node = None`
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:111:29
[INFO] [stdout]     |
[INFO] [stdout] 111 |             swap(node, &mut None);
[INFO] [stdout]     |                             ^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tree<T>`
[INFO] [stdout]    --> src/tree.rs:136:5
[INFO] [stdout]     |
[INFO] [stdout] 136 | /     pub fn new() -> Tree<T> {
[INFO] [stdout] 137 | |         Tree {
[INFO] [stdout] 138 | |             root: None
[INFO] [stdout] 139 | |         }
[INFO] [stdout] 140 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 121 + impl<T: PartialOrd + Clone> Default for Tree<T> {
[INFO] [stdout] 122 +     fn default() -> Self {
[INFO] [stdout] 123 +         Self::new()
[INFO] [stdout] 124 +     }
[INFO] [stdout] 125 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]    --> src/tree.rs:163:17
[INFO] [stdout]     |
[INFO] [stdout] 163 |                 swap(&mut self.root, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `self.root = Some(Box::from(Node::new(value)))`
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:163:43
[INFO] [stdout]     |
[INFO] [stdout] 163 |                 swap(&mut self.root, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/tree.rs:195:9
[INFO] [stdout]     |
[INFO] [stdout] 195 | /         match self.root {
[INFO] [stdout] 196 | |             None => None,
[INFO] [stdout] 197 | |             Some(ref n) => Some(n.min())
[INFO] [stdout] 198 | |         }
[INFO] [stdout]     | |_________^ help: try: `self.root.as_ref().map(|n| n.min())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/tree.rs:222:9
[INFO] [stdout]     |
[INFO] [stdout] 222 | /         match self.root {
[INFO] [stdout] 223 | |             None => None,
[INFO] [stdout] 224 | |             Some(ref n) => Some(n.max())
[INFO] [stdout] 225 | |         }
[INFO] [stdout]     | |_________^ help: try: `self.root.as_ref().map(|n| n.max())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/tree.rs:281:9
[INFO] [stdout]     |
[INFO] [stdout] 281 | /         match self.find(value) {
[INFO] [stdout] 282 | |             None => false,
[INFO] [stdout] 283 | |             _ => true
[INFO] [stdout] 284 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 281 -         match self.find(value) {
[INFO] [stdout] 282 -             None => false,
[INFO] [stdout] 283 -             _ => true
[INFO] [stdout] 284 -         }
[INFO] [stdout] 281 +         !matches!(self.find(value), None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/tree.rs:281:9
[INFO] [stdout]     |
[INFO] [stdout] 281 | /         match self.find(value) {
[INFO] [stdout] 282 | |             None => false,
[INFO] [stdout] 283 | |             _ => true
[INFO] [stdout] 284 | |         }
[INFO] [stdout]     | |_________^ help: try: `self.find(value).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]   --> src/tree.rs:31:21
[INFO] [stdout]    |
[INFO] [stdout] 31 |                     swap(&mut self.right, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `self.right = Some(Box::from(Node::new(value)))`
[INFO] [stdout]    |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]   --> src/tree.rs:31:48
[INFO] [stdout]    |
[INFO] [stdout] 31 |                     swap(&mut self.right, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout]    = note: `#[warn(clippy::swap_with_temporary)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]   --> src/tree.rs:40:21
[INFO] [stdout]    |
[INFO] [stdout] 40 |                     swap(&mut self.left, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `self.left = Some(Box::from(Node::new(value)))`
[INFO] [stdout]    |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]   --> src/tree.rs:40:47
[INFO] [stdout]    |
[INFO] [stdout] 40 |                     swap(&mut self.left, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:52:38
[INFO] [stdout]    |
[INFO] [stdout] 52 |             Some(ref n) => Node::min(&*n)
[INFO] [stdout]    |                                      ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout]    = note: `#[warn(clippy::borrow_deref_ref)]` on by default
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 52 -             Some(ref n) => Node::min(&*n)
[INFO] [stdout] 52 +             Some(ref n) => Node::min(n)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 52 |             Some(ref n) => Node::min(&**n)
[INFO] [stdout]    |                                        +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:59:38
[INFO] [stdout]    |
[INFO] [stdout] 59 |             Some(ref n) => Node::max(&*n)
[INFO] [stdout]    |                                      ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 59 -             Some(ref n) => Node::max(&*n)
[INFO] [stdout] 59 +             Some(ref n) => Node::max(n)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 59 |             Some(ref n) => Node::max(&**n)
[INFO] [stdout]    |                                        +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: usage of `Box<&Node<T>>`
[INFO] [stdout]   --> src/tree.rs:63:41
[INFO] [stdout]    |
[INFO] [stdout] 63 |     fn find(&self, value: &T) -> Option<Box<&Node<T>>> {
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^ help: try: `&Node<T>`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `&Node<T>` is already a pointer, `Box<&Node<T>>` allocates a pointer on the heap
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_allocation
[INFO] [stdout]    = note: `#[warn(clippy::redundant_allocation)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:67:43
[INFO] [stdout]    |
[INFO] [stdout] 67 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                           ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 67 -                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout] 67 +                 Some(ref n) => Node::find(n, &value)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 67 |                 Some(ref n) => Node::find(&**n, &value)
[INFO] [stdout]    |                                             +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/tree.rs:67:48
[INFO] [stdout]    |
[INFO] [stdout] 67 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                                ^^^^^^ help: change this to: `value`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: deref on an immutable reference
[INFO] [stdout]   --> src/tree.rs:72:43
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                           ^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref
[INFO] [stdout] help: if you would like to reborrow, try removing `&*`
[INFO] [stdout]    |
[INFO] [stdout] 72 -                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout] 72 +                 Some(ref n) => Node::find(n, &value)
[INFO] [stdout]    |
[INFO] [stdout] help: if you would like to deref, try using `&**`
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 Some(ref n) => Node::find(&**n, &value)
[INFO] [stdout]    |                                             +
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/tree.rs:72:48
[INFO] [stdout]    |
[INFO] [stdout] 72 |                 Some(ref n) => Node::find(&*n, &value)
[INFO] [stdout]    |                                                ^^^^^^ help: change this to: `value`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/tree.rs:85:20
[INFO] [stdout]    |
[INFO] [stdout] 85 |                 if !r.left.is_some() && !r.right.is_some() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^ help: try: `r.left.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/tree.rs:85:41
[INFO] [stdout]    |
[INFO] [stdout] 85 |                 if !r.left.is_some() && !r.right.is_some() {
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^ help: try: `r.right.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]   --> src/tree.rs:96:29
[INFO] [stdout]    |
[INFO] [stdout] 96 | ...                   swap(&mut None, &mut r.left);
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `r.left = None`
[INFO] [stdout]    |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]   --> src/tree.rs:96:39
[INFO] [stdout]    |
[INFO] [stdout] 96 | ...                   swap(&mut None, &mut r.left);
[INFO] [stdout]    |                                 ^^^^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]    --> src/tree.rs:100:29
[INFO] [stdout]     |
[INFO] [stdout] 100 | ...                   swap(&mut None, &mut r.right);
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `r.right = None`
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:100:39
[INFO] [stdout]     |
[INFO] [stdout] 100 | ...                   swap(&mut None, &mut r.right);
[INFO] [stdout]     |                                 ^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping temporary values has no effect
[INFO] [stdout]    --> src/tree.rs:103:29
[INFO] [stdout]     |
[INFO] [stdout] 103 | ...                   swap(&mut None, &mut r.find(&m));
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:103:39
[INFO] [stdout]     |
[INFO] [stdout] 103 | ...                   swap(&mut None, &mut r.find(&m));
[INFO] [stdout]     |                                 ^^^^
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:103:50
[INFO] [stdout]     |
[INFO] [stdout] 103 | ...                   swap(&mut None, &mut r.find(&m));
[INFO] [stdout]     |                                            ^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]    --> src/tree.rs:111:13
[INFO] [stdout]     |
[INFO] [stdout] 111 |             swap(node, &mut None);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `*node = None`
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:111:29
[INFO] [stdout]     |
[INFO] [stdout] 111 |             swap(node, &mut None);
[INFO] [stdout]     |                             ^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Tree<T>`
[INFO] [stdout]    --> src/tree.rs:136:5
[INFO] [stdout]     |
[INFO] [stdout] 136 | /     pub fn new() -> Tree<T> {
[INFO] [stdout] 137 | |         Tree {
[INFO] [stdout] 138 | |             root: None
[INFO] [stdout] 139 | |         }
[INFO] [stdout] 140 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]     = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]     |
[INFO] [stdout] 121 + impl<T: PartialOrd + Clone> Default for Tree<T> {
[INFO] [stdout] 122 +     fn default() -> Self {
[INFO] [stdout] 123 +         Self::new()
[INFO] [stdout] 124 +     }
[INFO] [stdout] 125 + }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: swapping with a temporary value is inefficient
[INFO] [stdout]    --> src/tree.rs:163:17
[INFO] [stdout]     |
[INFO] [stdout] 163 |                 swap(&mut self.root, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use assignment instead: `self.root = Some(Box::from(Node::new(value)))`
[INFO] [stdout]     |
[INFO] [stdout] note: this expression returns a temporary value
[INFO] [stdout]    --> src/tree.rs:163:43
[INFO] [stdout]     |
[INFO] [stdout] 163 |                 swap(&mut self.root, &mut Some(Box::from(Node::new(value))));
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#swap_with_temporary
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/tree.rs:195:9
[INFO] [stdout]     |
[INFO] [stdout] 195 | /         match self.root {
[INFO] [stdout] 196 | |             None => None,
[INFO] [stdout] 197 | |             Some(ref n) => Some(n.min())
[INFO] [stdout] 198 | |         }
[INFO] [stdout]     | |_________^ help: try: `self.root.as_ref().map(|n| n.min())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/tree.rs:222:9
[INFO] [stdout]     |
[INFO] [stdout] 222 | /         match self.root {
[INFO] [stdout] 223 | |             None => None,
[INFO] [stdout] 224 | |             Some(ref n) => Some(n.max())
[INFO] [stdout] 225 | |         }
[INFO] [stdout]     | |_________^ help: try: `self.root.as_ref().map(|n| n.max())`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/tree.rs:281:9
[INFO] [stdout]     |
[INFO] [stdout] 281 | /         match self.find(value) {
[INFO] [stdout] 282 | |             None => false,
[INFO] [stdout] 283 | |             _ => true
[INFO] [stdout] 284 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 281 -         match self.find(value) {
[INFO] [stdout] 282 -             None => false,
[INFO] [stdout] 283 -             _ => true
[INFO] [stdout] 284 -         }
[INFO] [stdout] 281 +         !matches!(self.find(value), None)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stdout]    --> src/tree.rs:281:9
[INFO] [stdout]     |
[INFO] [stdout] 281 | /         match self.find(value) {
[INFO] [stdout] 282 | |             None => false,
[INFO] [stdout] 283 | |             _ => true
[INFO] [stdout] 284 | |         }
[INFO] [stdout]     | |_________^ help: try: `self.find(value).is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.38s
[INFO] running `Command { std: "docker" "inspect" "bf53e4552ddbf6f7225c0e7b1dc2d30b4c2b42193bc31bf9eea4fc5b4e2d73c3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bf53e4552ddbf6f7225c0e7b1dc2d30b4c2b42193bc31bf9eea4fc5b4e2d73c3", kill_on_drop: false }`
[INFO] [stdout] bf53e4552ddbf6f7225c0e7b1dc2d30b4c2b42193bc31bf9eea4fc5b4e2d73c3