[INFO] cloning repository https://github.com/dmateos/rustnes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dmateos/rustnes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmateos%2Frustnes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmateos%2Frustnes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c89379caef87f03210ee2d51505f7f020d2eddd3 [INFO] linting dmateos/rustnes against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdmateos%2Frustnes" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dmateos/rustnes [INFO] finished tweaking git repo https://github.com/dmateos/rustnes [INFO] tweaked toml for git repo https://github.com/dmateos/rustnes written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dmateos/rustnes on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dmateos/rustnes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pollster v0.3.0 [INFO] [stderr] Downloaded wayland-sys v0.31.8 [INFO] [stderr] Downloaded wayland-backend v0.3.12 [INFO] [stderr] Downloaded wayland-cursor v0.31.12 [INFO] [stderr] Downloaded proc-macro2 v1.0.104 [INFO] [stderr] Downloaded ultraviolet v0.9.2 [INFO] [stderr] Downloaded pixels v0.15.0 [INFO] [stderr] Downloaded wayland-protocols-plasma v0.3.10 [INFO] [stderr] Downloaded wayland-protocols v0.32.10 [INFO] [stderr] Downloaded font8x8 v0.3.1 [INFO] [stderr] Downloaded quick-xml v0.38.4 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.10 [INFO] [stderr] Downloaded syn v2.0.113 [INFO] [stderr] Downloaded regex-syntax v0.8.9 [INFO] [stderr] Downloaded wayland-scanner v0.31.8 [INFO] [stderr] Downloaded libc v0.2.179 [INFO] [stderr] Downloaded orbclient v0.3.50 [INFO] [stderr] Downloaded widestring v1.2.1 [INFO] [stderr] Downloaded wayland-client v0.31.12 [INFO] [stderr] Downloaded wgpu-hal v0.19.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4590502f6a661d0140f5ad185c3468440111aba569410368f44e42246d958420 [INFO] running `Command { std: "docker" "start" "-a" "4590502f6a661d0140f5ad185c3468440111aba569410368f44e42246d958420", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4590502f6a661d0140f5ad185c3468440111aba569410368f44e42246d958420", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4590502f6a661d0140f5ad185c3468440111aba569410368f44e42246d958420", kill_on_drop: false }` [INFO] [stdout] 4590502f6a661d0140f5ad185c3468440111aba569410368f44e42246d958420 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71677706d0899c736e8b8d0b40356da76126a367bfe51e59c09eb0740ebab444 [INFO] running `Command { std: "docker" "start" "-a" "71677706d0899c736e8b8d0b40356da76126a367bfe51e59c09eb0740ebab444", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling proc-macro2 v1.0.104 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling libc v0.2.179 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.6 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Compiling wayland-sys v0.31.8 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling wayland-client v0.31.12 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Compiling ash v0.37.3+1.3.251 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Compiling wgpu-hal v0.19.5 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking slab v0.4.11 [INFO] [stderr] Compiling syn v2.0.113 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking raw-window-handle v0.6.2 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking wgpu-types v0.19.2 [INFO] [stderr] Compiling wgpu-core v0.19.4 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling quick-xml v0.38.4 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Checking ttf-parser v0.25.1 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking cursor-icon v1.2.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Compiling wgpu v0.19.4 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.10 [INFO] [stderr] Compiling winit v0.30.12 [INFO] [stderr] Checking as-raw-xcb-connection v1.0.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Compiling wayland-scanner v0.31.8 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking x11rb-protocol v0.13.2 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling thiserror v2.0.17 [INFO] [stderr] Compiling wayland-backend v0.3.12 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking pollster v0.3.0 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking font8x8 v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking owned_ttf_parser v0.25.1 [INFO] [stderr] Checking ab_glyph v0.2.32 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Checking ultraviolet v0.9.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking naga v0.19.2 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking wayland-protocols v0.32.10 [INFO] [stderr] Checking wayland-cursor v0.31.12 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.10 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.10 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking pixels v0.15.0 [INFO] [stderr] Checking rustnes v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `last_a12` is never read [INFO] [stdout] --> src/bus.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 50 | struct Mmc3 { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 83 | last_a12: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ctrl_value` and `mask_value` are never used [INFO] [stdout] --> src/ppu.rs:1224:12 [INFO] [stdout] | [INFO] [stdout] 255 | impl Ppu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1224 | pub fn ctrl_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1229 | pub fn mask_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `buffer` [INFO] [stdout] --> src/bus.rs:344:26 [INFO] [stdout] | [INFO] [stdout] 344 | for i in 0..256 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 344 - for i in 0..256 { [INFO] [stdout] 344 + for (i, ) in buffer.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bus.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | 3 | _ => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `last_a12` is never read [INFO] [stdout] --> src/bus.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 50 | struct Mmc3 { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] ... [INFO] [stdout] 83 | last_a12: bool, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ctrl_value` and `mask_value` are never used [INFO] [stdout] --> src/ppu.rs:1224:12 [INFO] [stdout] | [INFO] [stdout] 255 | impl Ppu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1224 | pub fn ctrl_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1229 | pub fn mask_value(&self) -> u8 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:609:27 [INFO] [stdout] | [INFO] [stdout] 609 | } else if count % 1000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `buffer` [INFO] [stdout] --> src/bus.rs:344:26 [INFO] [stdout] | [INFO] [stdout] 344 | for i in 0..256 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 344 - for i in 0..256 { [INFO] [stdout] 344 + for (i, ) in buffer.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/bus.rs:495:13 [INFO] [stdout] | [INFO] [stdout] 495 | 3 | _ => { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:1011:20 [INFO] [stdout] | [INFO] [stdout] 1011 | if count % 1000 == 0 || !will_branch { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:1156:27 [INFO] [stdout] | [INFO] [stdout] 1156 | } else if count % 5000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(5000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ppu.rs:675:17 [INFO] [stdout] | [INFO] [stdout] 675 | / if (addr as usize) < self.chr_rom.len() { [INFO] [stdout] 676 | | self.chr_rom[addr as usize] = value; [INFO] [stdout] 677 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 673 ~ 0x0000..=0x1FFF [INFO] [stdout] 674 | // For now, allow writes to CHR RAM if present [INFO] [stdout] 675 ~ if (addr as usize) < self.chr_rom.len() => { [INFO] [stdout] 676 | self.chr_rom[addr as usize] = value; [INFO] [stdout] 677 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/ppu.rs:829:32 [INFO] [stdout] | [INFO] [stdout] 829 | let screen_x = (tile_x * 8 + pixel_offset) as i32 - self.fine_x as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(tile_x * 8 + pixel_offset)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/ppu.rs:832:20 [INFO] [stdout] | [INFO] [stdout] 832 | if screen_x < 0 || screen_x >= 256 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..256).contains(&screen_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:609:27 [INFO] [stdout] | [INFO] [stdout] 609 | } else if count % 1000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | frame[offset] = frame[offset] / 3; // R [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame[offset] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | frame[offset + 1] = frame[offset + 1] / 3; // G [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame[offset + 1] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | frame[offset + 2] = frame[offset + 2] / 3; // B [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame[offset + 2] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:1011:20 [INFO] [stdout] | [INFO] [stdout] 1011 | if count % 1000 == 0 || !will_branch { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(1000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 344 | / if cpu.bus.ppu.check_a12_rise() { [INFO] [stdout] 345 | | if cpu.bus.mmc3_clock_irq() { [INFO] [stdout] 346 | | cpu.irq(); [INFO] [stdout] 347 | | } [INFO] [stdout] 348 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 344 ~ if cpu.bus.ppu.check_a12_rise() [INFO] [stdout] 345 ~ && cpu.bus.mmc3_clock_irq() { [INFO] [stdout] 346 | cpu.irq(); [INFO] [stdout] 347 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/cpu.rs:1156:27 [INFO] [stdout] | [INFO] [stdout] 1156 | } else if count % 5000 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `count.is_multiple_of(5000)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:559:5 [INFO] [stdout] | [INFO] [stdout] 559 | / if let Some(device) = host.default_output_device() { [INFO] [stdout] 560 | | if let Ok(config) = device.default_output_config() { [INFO] [stdout] 561 | | let sample_rate = config.sample_rate().0 as f64; [INFO] [stdout] 562 | | cpu.bus.apu.set_sample_rate(sample_rate); [INFO] [stdout] 563 | | } [INFO] [stdout] 564 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 559 ~ if let Some(device) = host.default_output_device() [INFO] [stdout] 560 ~ && let Ok(config) = device.default_output_config() { [INFO] [stdout] 561 | let sample_rate = config.sample_rate().0 as f64; [INFO] [stdout] 562 | cpu.bus.apu.set_sample_rate(sample_rate); [INFO] [stdout] 563 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ppu.rs:675:17 [INFO] [stdout] | [INFO] [stdout] 675 | / if (addr as usize) < self.chr_rom.len() { [INFO] [stdout] 676 | | self.chr_rom[addr as usize] = value; [INFO] [stdout] 677 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 673 ~ 0x0000..=0x1FFF [INFO] [stdout] 674 | // For now, allow writes to CHR RAM if present [INFO] [stdout] 675 ~ if (addr as usize) < self.chr_rom.len() => { [INFO] [stdout] 676 | self.chr_rom[addr as usize] = value; [INFO] [stdout] 677 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/ppu.rs:829:32 [INFO] [stdout] | [INFO] [stdout] 829 | let screen_x = (tile_x * 8 + pixel_offset) as i32 - self.fine_x as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(tile_x * 8 + pixel_offset)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!Range::contains` implementation [INFO] [stdout] --> src/ppu.rs:832:20 [INFO] [stdout] | [INFO] [stdout] 832 | if screen_x < 0 || screen_x >= 256 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..256).contains(&screen_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | frame[offset] = frame[offset] / 3; // R [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame[offset] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:207:21 [INFO] [stdout] | [INFO] [stdout] 207 | frame[offset + 1] = frame[offset + 1] / 3; // G [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame[offset + 1] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:208:21 [INFO] [stdout] | [INFO] [stdout] 208 | frame[offset + 2] = frame[offset + 2] / 3; // B [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame[offset + 2] /= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:344:21 [INFO] [stdout] | [INFO] [stdout] 344 | / if cpu.bus.ppu.check_a12_rise() { [INFO] [stdout] 345 | | if cpu.bus.mmc3_clock_irq() { [INFO] [stdout] 346 | | cpu.irq(); [INFO] [stdout] 347 | | } [INFO] [stdout] 348 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 344 ~ if cpu.bus.ppu.check_a12_rise() [INFO] [stdout] 345 ~ && cpu.bus.mmc3_clock_irq() { [INFO] [stdout] 346 | cpu.irq(); [INFO] [stdout] 347 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:559:5 [INFO] [stdout] | [INFO] [stdout] 559 | / if let Some(device) = host.default_output_device() { [INFO] [stdout] 560 | | if let Ok(config) = device.default_output_config() { [INFO] [stdout] 561 | | let sample_rate = config.sample_rate().0 as f64; [INFO] [stdout] 562 | | cpu.bus.apu.set_sample_rate(sample_rate); [INFO] [stdout] 563 | | } [INFO] [stdout] 564 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 559 ~ if let Some(device) = host.default_output_device() [INFO] [stdout] 560 ~ && let Ok(config) = device.default_output_config() { [INFO] [stdout] 561 | let sample_rate = config.sample_rate().0 as f64; [INFO] [stdout] 562 | cpu.bus.apu.set_sample_rate(sample_rate); [INFO] [stdout] 563 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `Command { std: "docker" "inspect" "71677706d0899c736e8b8d0b40356da76126a367bfe51e59c09eb0740ebab444", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71677706d0899c736e8b8d0b40356da76126a367bfe51e59c09eb0740ebab444", kill_on_drop: false }` [INFO] [stdout] 71677706d0899c736e8b8d0b40356da76126a367bfe51e59c09eb0740ebab444