[INFO] cloning repository https://github.com/djrideout/advent-grid
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/djrideout/advent-grid" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjrideout%2Fadvent-grid", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjrideout%2Fadvent-grid'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 2163d1bbbb9b17197c1d59e7e609bd14557e0ca5
[INFO] linting djrideout/advent-grid against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjrideout%2Fadvent-grid" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/djrideout/advent-grid
[INFO] finished tweaking git repo https://github.com/djrideout/advent-grid
[INFO] tweaked toml for git repo https://github.com/djrideout/advent-grid written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/djrideout/advent-grid on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/djrideout/advent-grid already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 6d328951c060220e25f9480e7ec7b9b0e07696ade48e36ab5f8756848071dc5d
[INFO] running `Command { std: "docker" "start" "-a" "6d328951c060220e25f9480e7ec7b9b0e07696ade48e36ab5f8756848071dc5d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "6d328951c060220e25f9480e7ec7b9b0e07696ade48e36ab5f8756848071dc5d", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6d328951c060220e25f9480e7ec7b9b0e07696ade48e36ab5f8756848071dc5d", kill_on_drop: false }`
[INFO] [stdout] 6d328951c060220e25f9480e7ec7b9b0e07696ade48e36ab5f8756848071dc5d
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] edadb1a4009b7d47a8080c2d6975a3d8b574b0cb418f53295698ce3d633423cd
[INFO] running `Command { std: "docker" "start" "-a" "edadb1a4009b7d47a8080c2d6975a3d8b574b0cb418f53295698ce3d633423cd", kill_on_drop: false }`
[INFO] [stderr]     Checking regex-automata v0.4.13
[INFO] [stderr]     Checking regex v1.12.2
[INFO] [stderr]     Checking advent-grid v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:157:16
[INFO] [stdout]     |
[INFO] [stdout] 157 |             if !min_distance.is_some() || new_distance <= *min_distance.unwrap() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `min_distance.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `end_prev_edges` after checking its variant with `is_some`
[INFO] [stdout]    --> src/lib.rs:180:44
[INFO] [stdout]     |
[INFO] [stdout] 179 |     if end_prev_edges.is_some() {
[INFO] [stdout]     |     --------------------------- help: try: `if let Some(<item>) = end_prev_edges`
[INFO] [stdout] 180 |         let mut edges = HashSet::from_iter(end_prev_edges.unwrap());
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/lib.rs:140:22
[INFO] [stdout]     |
[INFO] [stdout] 140 | pub fn dijkstra(map: &String, line_len: i32, start_pos: i32, end_pos: i32, opposite_cost: i32, perpendicular_cost: i32) -> Dijkstra...
[INFO] [stdout]     |                      ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 140 ~ pub fn dijkstra(map: &str, line_len: i32, start_pos: i32, end_pos: i32, opposite_cost: i32, perpendicular_cost: i32) -> DijkstraResult {
[INFO] [stdout] 141 ~     let grid = Grid::new(map.to_owned(), line_len);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:148:11
[INFO] [stdout]     |
[INFO] [stdout] 148 |     while node_queue.len() > 0 {
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!node_queue.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:172:17
[INFO] [stdout]     |
[INFO] [stdout] 172 |                 return a_dist.cmp(b_dist);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 172 -                 return a_dist.cmp(b_dist);
[INFO] [stdout] 172 +                 a_dist.cmp(b_dist)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:170:48
[INFO] [stdout]     |
[INFO] [stdout] 170 |                 let a_dist = min_distances.get(&a).unwrap();
[INFO] [stdout]     |                                                ^^ help: change this to: `a`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:171:48
[INFO] [stdout]     |
[INFO] [stdout] 171 |                 let b_dist = min_distances.get(&b).unwrap();
[INFO] [stdout]     |                                                ^^ help: change this to: `b`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:181:15
[INFO] [stdout]     |
[INFO] [stdout] 181 |         while edges.len() > 0 {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!edges.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:157:16
[INFO] [stdout]     |
[INFO] [stdout] 157 |             if !min_distance.is_some() || new_distance <= *min_distance.unwrap() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `min_distance.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `end_prev_edges` after checking its variant with `is_some`
[INFO] [stdout]    --> src/lib.rs:180:44
[INFO] [stdout]     |
[INFO] [stdout] 179 |     if end_prev_edges.is_some() {
[INFO] [stdout]     |     --------------------------- help: try: `if let Some(<item>) = end_prev_edges`
[INFO] [stdout] 180 |         let mut edges = HashSet::from_iter(end_prev_edges.unwrap());
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]    --> src/lib.rs:140:22
[INFO] [stdout]     |
[INFO] [stdout] 140 | pub fn dijkstra(map: &String, line_len: i32, start_pos: i32, end_pos: i32, opposite_cost: i32, perpendicular_cost: i32) -> Dijkstra...
[INFO] [stdout]     |                      ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 140 ~ pub fn dijkstra(map: &str, line_len: i32, start_pos: i32, end_pos: i32, opposite_cost: i32, perpendicular_cost: i32) -> DijkstraResult {
[INFO] [stdout] 141 ~     let grid = Grid::new(map.to_owned(), line_len);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:148:11
[INFO] [stdout]     |
[INFO] [stdout] 148 |     while node_queue.len() > 0 {
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!node_queue.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lib.rs:172:17
[INFO] [stdout]     |
[INFO] [stdout] 172 |                 return a_dist.cmp(b_dist);
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 172 -                 return a_dist.cmp(b_dist);
[INFO] [stdout] 172 +                 a_dist.cmp(b_dist)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:170:48
[INFO] [stdout]     |
[INFO] [stdout] 170 |                 let a_dist = min_distances.get(&a).unwrap();
[INFO] [stdout]     |                                                ^^ help: change this to: `a`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:171:48
[INFO] [stdout]     |
[INFO] [stdout] 171 |                 let b_dist = min_distances.get(&b).unwrap();
[INFO] [stdout]     |                                                ^^ help: change this to: `b`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lib.rs:181:15
[INFO] [stdout]     |
[INFO] [stdout] 181 |         while edges.len() > 0 {
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!edges.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.60s
[INFO] running `Command { std: "docker" "inspect" "edadb1a4009b7d47a8080c2d6975a3d8b574b0cb418f53295698ce3d633423cd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "edadb1a4009b7d47a8080c2d6975a3d8b574b0cb418f53295698ce3d633423cd", kill_on_drop: false }`
[INFO] [stdout] edadb1a4009b7d47a8080c2d6975a3d8b574b0cb418f53295698ce3d633423cd