[INFO] cloning repository https://github.com/djole-petrovic-js/usage-parse [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/djole-petrovic-js/usage-parse" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjole-petrovic-js%2Fusage-parse", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjole-petrovic-js%2Fusage-parse'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e84dc619fb50c4cc4150dbc8bee39f310045d47e [INFO] linting djole-petrovic-js/usage-parse against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjole-petrovic-js%2Fusage-parse" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/djole-petrovic-js/usage-parse [INFO] finished tweaking git repo https://github.com/djole-petrovic-js/usage-parse [INFO] tweaked toml for git repo https://github.com/djole-petrovic-js/usage-parse written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/djole-petrovic-js/usage-parse on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/djole-petrovic-js/usage-parse already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2c513c15b829a390b2ebee033c750d111b843117387d47f5ae5a85270c02f560 [INFO] running `Command { std: "docker" "start" "-a" "2c513c15b829a390b2ebee033c750d111b843117387d47f5ae5a85270c02f560", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2c513c15b829a390b2ebee033c750d111b843117387d47f5ae5a85270c02f560", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c513c15b829a390b2ebee033c750d111b843117387d47f5ae5a85270c02f560", kill_on_drop: false }` [INFO] [stdout] 2c513c15b829a390b2ebee033c750d111b843117387d47f5ae5a85270c02f560 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23f540d37a10f3916eb305fdd8ed600c19a6a8fa9258b841c121893a26893db1 [INFO] running `Command { std: "docker" "start" "-a" "23f540d37a10f3916eb305fdd8ed600c19a6a8fa9258b841c121893a26893db1", kill_on_drop: false }` [INFO] [stderr] Checking usage-parse v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/arguments_lib/cli_args.rs:175:17 [INFO] [stdout] | [INFO] [stdout] 175 | assert!(!cli_args.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `cli_args.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/formatters/formatter_factory.rs:36:49 [INFO] [stdout] | [INFO] [stdout] 36 | FormatterFactory::resolve_formatter(&"json") [INFO] [stdout] | ^^^^^^^ help: change this to: `"json"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/formatters/formatter_factory.rs:42:49 [INFO] [stdout] | [INFO] [stdout] 42 | FormatterFactory::resolve_formatter(&"stdout") [INFO] [stdout] | ^^^^^^^^^ help: change this to: `"stdout"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/formatters/formatter_factory.rs:47:53 [INFO] [stdout] | [INFO] [stdout] 47 | assert!(FormatterFactory::resolve_formatter(&"unknown").is_err()); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `"unknown"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:229:17 [INFO] [stdout] | [INFO] [stdout] 229 | assert!(!owner_usage_hash_map.is_err()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `owner_usage_hash_map.is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:224:41 [INFO] [stdout] | [INFO] [stdout] 224 | let log_parser = LogParser::new(&test_log_path); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `test_log_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | &query_string, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:266:17 [INFO] [stdout] | [INFO] [stdout] 266 | &query_string, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:282:17 [INFO] [stdout] | [INFO] [stdout] 282 | &query_string_with_v_only, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `query_string_with_v_only` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:298:17 [INFO] [stdout] | [INFO] [stdout] 298 | &query_string_with_i_only, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `query_string_with_i_only` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 313 | &query_string, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:322:13 [INFO] [stdout] | [INFO] [stdout] 322 | &query_string, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/log_parser.rs:339:17 [INFO] [stdout] | [INFO] [stdout] 339 | &query_string, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/utils.rs:128:46 [INFO] [stdout] | [INFO] [stdout] 128 | get_query_string_parameter_value(&query_string, &'o'), [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/utils.rs:132:46 [INFO] [stdout] | [INFO] [stdout] 132 | get_query_string_parameter_value(&query_string, &'v'), [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/utils.rs:136:46 [INFO] [stdout] | [INFO] [stdout] 136 | get_query_string_parameter_value(&query_string, &'i'), [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/utils.rs:139:53 [INFO] [stdout] | [INFO] [stdout] 139 | assert_eq!(get_query_string_parameter_value(&query_string, &'X'), None); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `query_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/log_parser_lib/utils.rs:140:53 [INFO] [stdout] | [INFO] [stdout] 140 | assert_eq!(get_query_string_parameter_value(&"", &'W'), None); [INFO] [stdout] | ^^^ help: change this to: `""` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/fs_utils.rs:63:49 [INFO] [stdout] | [INFO] [stdout] 63 | let mut test_log_files = get_file_names(&test_log_dir); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `test_log_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `test_log_files.get(0)` [INFO] [stdout] --> src/utils/fs_utils.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | assert_eq!(test_log_files.get(0), Some(&test_log_file_one.to_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `test_log_files.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "23f540d37a10f3916eb305fdd8ed600c19a6a8fa9258b841c121893a26893db1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23f540d37a10f3916eb305fdd8ed600c19a6a8fa9258b841c121893a26893db1", kill_on_drop: false }` [INFO] [stdout] 23f540d37a10f3916eb305fdd8ed600c19a6a8fa9258b841c121893a26893db1