[INFO] cloning repository https://github.com/djfarly/tde-rs
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/djfarly/tde-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjfarly%2Ftde-rs", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjfarly%2Ftde-rs'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] f5c4ba813a5b54596367792baeca736a02f1aa0c
[INFO] linting djfarly/tde-rs against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdjfarly%2Ftde-rs" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/djfarly/tde-rs
[INFO] finished tweaking git repo https://github.com/djfarly/tde-rs
[INFO] tweaked toml for git repo https://github.com/djfarly/tde-rs written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/djfarly/tde-rs on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/djfarly/tde-rs already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded ppv-lite86 v0.2.15
[INFO] [stderr]   Downloaded libc v0.2.107
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1d120640b15d1e03f64a9e19ca52e486c6bd8d4e48ffca72f0f86690df76b3b3
[INFO] running `Command { std: "docker" "start" "-a" "1d120640b15d1e03f64a9e19ca52e486c6bd8d4e48ffca72f0f86690df76b3b3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1d120640b15d1e03f64a9e19ca52e486c6bd8d4e48ffca72f0f86690df76b3b3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1d120640b15d1e03f64a9e19ca52e486c6bd8d4e48ffca72f0f86690df76b3b3", kill_on_drop: false }`
[INFO] [stdout] 1d120640b15d1e03f64a9e19ca52e486c6bd8d4e48ffca72f0f86690df76b3b3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] d39922b9bdef26d8f0ebe184ac9a45dc74de62fadaf3a7687cc70f5bdff124ac
[INFO] running `Command { std: "docker" "start" "-a" "d39922b9bdef26d8f0ebe184ac9a45dc74de62fadaf3a7687cc70f5bdff124ac", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.107
[INFO] [stderr]     Checking ppv-lite86 v0.2.15
[INFO] [stderr]     Checking getrandom v0.2.3
[INFO] [stderr]     Checking rand_core v0.6.3
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.4
[INFO] [stderr]     Checking tde-rs v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/rolls.rs:114:17
[INFO] [stdout]     |
[INFO] [stdout] 114 |                 remaining_skill_points: remaining_skill_points,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining_skill_points`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/rolls.rs:118:17
[INFO] [stdout]     |
[INFO] [stdout] 118 |                 remaining_skill_points: remaining_skill_points,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining_skill_points`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/rolls.rs:114:17
[INFO] [stdout]     |
[INFO] [stdout] 114 |                 remaining_skill_points: remaining_skill_points,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining_skill_points`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/rolls.rs:118:17
[INFO] [stdout]     |
[INFO] [stdout] 118 |                 remaining_skill_points: remaining_skill_points,
[INFO] [stdout]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remaining_skill_points`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `success` and `quality` are never read
[INFO] [stdout]    --> src/rolls.rs:143:5
[INFO] [stdout]     |
[INFO] [stdout] 142 | pub struct Chance {
[INFO] [stdout]     |            ------ fields in this struct
[INFO] [stdout] 143 |     success: f64,
[INFO] [stdout]     |     ^^^^^^^
[INFO] [stdout] 144 |     quality: [f64; 6],
[INFO] [stdout]     |     ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `Chance` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]  --> src/rolls.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | /     (rolls[0] == 20 && rolls[1] == 20)
[INFO] [stdout] 7 | |         || (rolls[0] == 20 && rolls[2] == 20)
[INFO] [stdout]   | |_____________________________________________^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]   = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]   |
[INFO] [stdout] 6 -     (rolls[0] == 20 && rolls[1] == 20)
[INFO] [stdout] 7 -         || (rolls[0] == 20 && rolls[2] == 20)
[INFO] [stdout] 6 +     !(rolls[0] != 20 || rolls[1] != 20 && rolls[2] != 20)
[INFO] [stdout]   |
[INFO] [stdout] 6 -     (rolls[0] == 20 && rolls[1] == 20)
[INFO] [stdout] 7 -         || (rolls[0] == 20 && rolls[2] == 20)
[INFO] [stdout] 6 +     (rolls[2] == 20 || rolls[1] == 20) && rolls[0] == 20
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/rolls.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | /     (rolls[0] == 1 && rolls[1] == 1)
[INFO] [stdout] 17 | |         || (rolls[0] == 1 && rolls[2] == 1)
[INFO] [stdout]    | |___________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 16 -     (rolls[0] == 1 && rolls[1] == 1)
[INFO] [stdout] 17 -         || (rolls[0] == 1 && rolls[2] == 1)
[INFO] [stdout] 16 +     !(rolls[0] != 1 || rolls[1] != 1 && rolls[2] != 1)
[INFO] [stdout]    |
[INFO] [stdout] 16 -     (rolls[0] == 1 && rolls[1] == 1)
[INFO] [stdout] 17 -         || (rolls[0] == 1 && rolls[2] == 1)
[INFO] [stdout] 16 +     (rolls[2] == 1 || rolls[1] == 1) && rolls[0] == 1
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`)
[INFO] [stdout]   --> src/rolls.rs:35:16
[INFO] [stdout]    |
[INFO] [stdout] 35 |     if roll > (attribute as i8 + modifier) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^ help: try: `attribute`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`)
[INFO] [stdout]   --> src/rolls.rs:36:9
[INFO] [stdout]    |
[INFO] [stdout] 36 |         (roll - (attribute as i8 + modifier)) as i8
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(roll - (attribute as i8 + modifier))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`)
[INFO] [stdout]   --> src/rolls.rs:36:18
[INFO] [stdout]    |
[INFO] [stdout] 36 |         (roll - (attribute as i8 + modifier)) as i8
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^ help: try: `attribute`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `success` and `quality` are never read
[INFO] [stdout]    --> src/rolls.rs:143:5
[INFO] [stdout]     |
[INFO] [stdout] 142 | pub struct Chance {
[INFO] [stdout]     |            ------ fields in this struct
[INFO] [stdout] 143 |     success: f64,
[INFO] [stdout]     |     ^^^^^^^
[INFO] [stdout] 144 |     quality: [f64; 6],
[INFO] [stdout]     |     ^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `Chance` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]     = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]  --> src/rolls.rs:6:5
[INFO] [stdout]   |
[INFO] [stdout] 6 | /     (rolls[0] == 20 && rolls[1] == 20)
[INFO] [stdout] 7 | |         || (rolls[0] == 20 && rolls[2] == 20)
[INFO] [stdout]   | |_____________________________________________^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]   = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]   |
[INFO] [stdout] 6 -     (rolls[0] == 20 && rolls[1] == 20)
[INFO] [stdout] 7 -         || (rolls[0] == 20 && rolls[2] == 20)
[INFO] [stdout] 6 +     !(rolls[0] != 20 || rolls[1] != 20 && rolls[2] != 20)
[INFO] [stdout]   |
[INFO] [stdout] 6 -     (rolls[0] == 20 && rolls[1] == 20)
[INFO] [stdout] 7 -         || (rolls[0] == 20 && rolls[2] == 20)
[INFO] [stdout] 6 +     (rolls[2] == 20 || rolls[1] == 20) && rolls[0] == 20
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/rolls.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | /     (rolls[0] == 1 && rolls[1] == 1)
[INFO] [stdout] 17 | |         || (rolls[0] == 1 && rolls[2] == 1)
[INFO] [stdout]    | |___________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 16 -     (rolls[0] == 1 && rolls[1] == 1)
[INFO] [stdout] 17 -         || (rolls[0] == 1 && rolls[2] == 1)
[INFO] [stdout] 16 +     !(rolls[0] != 1 || rolls[1] != 1 && rolls[2] != 1)
[INFO] [stdout]    |
[INFO] [stdout] 16 -     (rolls[0] == 1 && rolls[1] == 1)
[INFO] [stdout] 17 -         || (rolls[0] == 1 && rolls[2] == 1)
[INFO] [stdout] 16 +     (rolls[2] == 1 || rolls[1] == 1) && rolls[0] == 1
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`)
[INFO] [stdout]   --> src/rolls.rs:35:16
[INFO] [stdout]    |
[INFO] [stdout] 35 |     if roll > (attribute as i8 + modifier) {
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^ help: try: `attribute`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`)
[INFO] [stdout]   --> src/rolls.rs:36:9
[INFO] [stdout]    |
[INFO] [stdout] 36 |         (roll - (attribute as i8 + modifier)) as i8
[INFO] [stdout]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(roll - (attribute as i8 + modifier))`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`i8` -> `i8`)
[INFO] [stdout]   --> src/rolls.rs:36:18
[INFO] [stdout]    |
[INFO] [stdout] 36 |         (roll - (attribute as i8 + modifier)) as i8
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^ help: try: `attribute`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.65s
[INFO] running `Command { std: "docker" "inspect" "d39922b9bdef26d8f0ebe184ac9a45dc74de62fadaf3a7687cc70f5bdff124ac", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d39922b9bdef26d8f0ebe184ac9a45dc74de62fadaf3a7687cc70f5bdff124ac", kill_on_drop: false }`
[INFO] [stdout] d39922b9bdef26d8f0ebe184ac9a45dc74de62fadaf3a7687cc70f5bdff124ac