[INFO] cloning repository https://github.com/dhruv-ar/youtube_social_network_project [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dhruv-ar/youtube_social_network_project" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdhruv-ar%2Fyoutube_social_network_project", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdhruv-ar%2Fyoutube_social_network_project'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6ee16319544a32d20470c033508b50c752653d44 [INFO] linting dhruv-ar/youtube_social_network_project against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdhruv-ar%2Fyoutube_social_network_project" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dhruv-ar/youtube_social_network_project [INFO] finished tweaking git repo https://github.com/dhruv-ar/youtube_social_network_project [INFO] tweaked toml for git repo https://github.com/dhruv-ar/youtube_social_network_project written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dhruv-ar/youtube_social_network_project on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dhruv-ar/youtube_social_network_project already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.path [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded csv-core v0.1.11 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec1fcc1f35394c674d0af1459bba6e3aa7317eeda8bbcdafac863bde6cbd00a8 [INFO] running `Command { std: "docker" "start" "-a" "ec1fcc1f35394c674d0af1459bba6e3aa7317eeda8bbcdafac863bde6cbd00a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec1fcc1f35394c674d0af1459bba6e3aa7317eeda8bbcdafac863bde6cbd00a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec1fcc1f35394c674d0af1459bba6e3aa7317eeda8bbcdafac863bde6cbd00a8", kill_on_drop: false }` [INFO] [stdout] ec1fcc1f35394c674d0af1459bba6e3aa7317eeda8bbcdafac863bde6cbd00a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c9b99f1f3f7f2bd1e91bc25848cb3c0a13052dd2a4666333e46f91805c00aab [INFO] running `Command { std: "docker" "start" "-a" "5c9b99f1f3f7f2bd1e91bc25848cb3c0a13052dd2a4666333e46f91805c00aab", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.path [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling cc v1.2.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking png v0.17.15 [INFO] [stderr] Compiling yeslogic-fontconfig-sys v6.0.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling pathfinder_simd v0.5.4 [INFO] [stderr] Compiling serde v1.0.215 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling font-kit v0.14.2 [INFO] [stderr] Checking bytemuck v1.20.0 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking pathfinder_geometry v0.5.1 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking float-ord v0.3.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Compiling freetype-sys v0.20.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking plotters-bitmap v0.3.7 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking youtube_social_network v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/graph.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn load_graph(file_path: &str) -> HashMap> { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/analysis.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | for (_, neighbors) in adjacency_list { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 47 - for (_, neighbors) in adjacency_list { [INFO] [stdout] 47 + for neighbors in adjacency_list.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !fs::metadata(output_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | .write_record(&["Node", "Centrality"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Node", "Centrality"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 38 | .write_record(&["Degree", "Count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Degree", "Count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `youtube_social_network::graph::load_graph` [INFO] [stdout] --> tests/tests.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use youtube_social_network::graph::load_graph; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/graph.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn load_graph(file_path: &str) -> HashMap> { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/graph.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn load_graph(file_path: &str) -> HashMap> { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/analysis.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | for (_, neighbors) in adjacency_list { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 47 - for (_, neighbors) in adjacency_list { [INFO] [stdout] 47 + for neighbors in adjacency_list.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !fs::metadata(output_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | .write_record(&["Node", "Centrality"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Node", "Centrality"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 38 | .write_record(&["Degree", "Count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Degree", "Count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `file_path` [INFO] [stdout] --> src/graph.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn load_graph(file_path: &str) -> HashMap> { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/analysis.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | for (_, neighbors) in adjacency_list { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 47 - for (_, neighbors) in adjacency_list { [INFO] [stdout] 47 + for neighbors in adjacency_list.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !fs::metadata(output_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | .write_record(&["Node", "Centrality"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Node", "Centrality"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 38 | .write_record(&["Degree", "Count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Degree", "Count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/analysis.rs:47:27 [INFO] [stdout] | [INFO] [stdout] 47 | for (_, neighbors) in adjacency_list { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 47 - for (_, neighbors) in adjacency_list { [INFO] [stdout] 47 + for neighbors in adjacency_list.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !fs::metadata(output_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(output_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | .write_record(&["Node", "Centrality"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Node", "Centrality"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/utils.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 38 | .write_record(&["Degree", "Count"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `["Degree", "Count"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.44s [INFO] running `Command { std: "docker" "inspect" "5c9b99f1f3f7f2bd1e91bc25848cb3c0a13052dd2a4666333e46f91805c00aab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c9b99f1f3f7f2bd1e91bc25848cb3c0a13052dd2a4666333e46f91805c00aab", kill_on_drop: false }` [INFO] [stdout] 5c9b99f1f3f7f2bd1e91bc25848cb3c0a13052dd2a4666333e46f91805c00aab