[INFO] cloning repository https://github.com/dhald/yahtzee_rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dhald/yahtzee_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdhald%2Fyahtzee_rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdhald%2Fyahtzee_rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 590fd2301f17e29f1e1b44bc507072177c8f6f74
[INFO] linting dhald/yahtzee_rust against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdhald%2Fyahtzee_rust" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] removed /workspace/builds/worker-4-tc1/source/.cargo/config.toml
[INFO] started tweaking git repo https://github.com/dhald/yahtzee_rust
[INFO] finished tweaking git repo https://github.com/dhald/yahtzee_rust
[INFO] tweaked toml for git repo https://github.com/dhald/yahtzee_rust written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/dhald/yahtzee_rust on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/dhald/yahtzee_rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded clap_builder v4.5.23
[INFO] [stderr]   Downloaded clap v4.5.23
[INFO] [stderr]   Downloaded syn v2.0.92
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 7c1b2eaf287ced508439309b526bb1fda39ebae61d3f70d953bc82a7c0008006
[INFO] running `Command { std: "docker" "start" "-a" "7c1b2eaf287ced508439309b526bb1fda39ebae61d3f70d953bc82a7c0008006", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "7c1b2eaf287ced508439309b526bb1fda39ebae61d3f70d953bc82a7c0008006", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7c1b2eaf287ced508439309b526bb1fda39ebae61d3f70d953bc82a7c0008006", kill_on_drop: false }`
[INFO] [stdout] 7c1b2eaf287ced508439309b526bb1fda39ebae61d3f70d953bc82a7c0008006
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5d3ccf23d740314c8b39d64da6dbe6647bf3cafb5e338115b3c26b6f72bd05d2
[INFO] running `Command { std: "docker" "start" "-a" "5d3ccf23d740314c8b39d64da6dbe6647bf3cafb5e338115b3c26b6f72bd05d2", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.92
[INFO] [stderr]     Checking either v1.13.0
[INFO] [stderr]     Checking strum v0.26.3
[INFO] [stderr]     Checking clap_builder v4.5.23
[INFO] [stderr]     Checking rayon v1.10.0
[INFO] [stderr]    Compiling quote v1.0.38
[INFO] [stderr]    Compiling syn v2.0.92
[INFO] [stderr]    Compiling clap_derive v4.5.18
[INFO] [stderr]    Compiling strum_macros v0.26.4
[INFO] [stderr]     Checking clap v4.5.23
[INFO] [stderr]     Checking yahtzee_rust v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/category.rs:28:31
[INFO] [stdout]    |
[INFO] [stdout] 28 |             Category::Ones => 1 * dice.ones,
[INFO] [stdout]    |                               ^^^^^^^^^^^^^ help: consider reducing it to: `dice.ones`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout]    = note: `#[warn(clippy::identity_op)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/dice.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         1 * ones + 2 * twos + 3 * threes + 4 * fours + 5 * fives + 6 * sixes
[INFO] [stdout]    |         ^^^^^^^^ help: consider reducing it to: `*ones`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/dice.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 | /         ones > &0 && twos > &0 && threes > &0 && fours > &0
[INFO] [stdout] 84 | |             || twos > &0 && threes > &0 && fours > &0 && fives > &0
[INFO] [stdout]    | |___________________________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 83 -         ones > &0 && twos > &0 && threes > &0 && fours > &0
[INFO] [stdout] 84 -             || twos > &0 && threes > &0 && fours > &0 && fives > &0
[INFO] [stdout] 83 +         !(twos <= &0 || threes <= &0 || fours <= &0 || ones <= &0 && fives <= &0)
[INFO] [stdout]    |
[INFO] [stdout] 83 -         ones > &0 && twos > &0 && threes > &0 && fours > &0
[INFO] [stdout] 84 -             || twos > &0 && threes > &0 && fours > &0 && fives > &0
[INFO] [stdout] 83 +         (fives > &0 || ones > &0) && fours > &0 && threes > &0 && twos > &0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]    --> src/dice.rs:153:9
[INFO] [stdout]     |
[INFO] [stdout] 153 | /         let mut keeps = Vec::new();
[INFO] [stdout] 154 | |         keeps.push(Self::EMPTY);
[INFO] [stdout]     | |________________________________^ help: consider using the `vec![]` macro: `let mut keeps = vec![..];`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]     = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Dice` which implements the `Copy` trait
[INFO] [stdout]    --> src/dice.rs:162:40
[INFO] [stdout]     |
[INFO] [stdout] 162 |                         let mut keep = keep.clone();
[INFO] [stdout]     |                                        ^^^^^^^^^^^^ help: try dereferencing it: `*keep`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:27:15
[INFO] [stdout]    |
[INFO] [stdout] 27 |     turn_evs: &Vec<f32>,
[INFO] [stdout]    |               ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 27 -     turn_evs: &Vec<f32>,
[INFO] [stdout] 27 +     turn_evs: &[f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:28:16
[INFO] [stdout]    |
[INFO] [stdout] 28 |     all_rolls: &Vec<Dice>,
[INFO] [stdout]    |                ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 28 -     all_rolls: &Vec<Dice>,
[INFO] [stdout] 28 +     all_rolls: &[Dice],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:29:19
[INFO] [stdout]    |
[INFO] [stdout] 29 |     roll_scratch: &mut Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 29 -     roll_scratch: &mut Vec<f32>,
[INFO] [stdout] 29 +     roll_scratch: &mut [f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:60:19
[INFO] [stdout]    |
[INFO] [stdout] 60 |     keep_scratch: &mut Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 60 -     keep_scratch: &mut Vec<f32>,
[INFO] [stdout] 60 +     keep_scratch: &mut [f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:61:19
[INFO] [stdout]    |
[INFO] [stdout] 61 |     roll_scratch: &Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 61 -     roll_scratch: &Vec<f32>,
[INFO] [stdout] 61 +     roll_scratch: &[f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:78:19
[INFO] [stdout]    |
[INFO] [stdout] 78 |     keep_scratch: &Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 78 -     keep_scratch: &Vec<f32>,
[INFO] [stdout] 78 +     keep_scratch: &[f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:79:19
[INFO] [stdout]    |
[INFO] [stdout] 79 |     roll_scratch: &mut Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 79 -     roll_scratch: &mut Vec<f32>,
[INFO] [stdout] 79 +     roll_scratch: &mut [f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:94:40
[INFO] [stdout]    |
[INFO] [stdout] 94 | fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout]    |                                        ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 94 - fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout] 94 + fn compute_begin_turn_ev(roll_scratch: &[f32], all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:94:62
[INFO] [stdout]    |
[INFO] [stdout] 94 | fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout]    |                                                              ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 94 - fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout] 94 + fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &[Dice]) -> f32 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/category.rs:28:31
[INFO] [stdout]    |
[INFO] [stdout] 28 |             Category::Ones => 1 * dice.ones,
[INFO] [stdout]    |                               ^^^^^^^^^^^^^ help: consider reducing it to: `dice.ones`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout]    = note: `#[warn(clippy::identity_op)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this operation has no effect
[INFO] [stdout]   --> src/dice.rs:59:9
[INFO] [stdout]    |
[INFO] [stdout] 59 |         1 * ones + 2 * twos + 3 * threes + 4 * fours + 5 * fives + 6 * sixes
[INFO] [stdout]    |         ^^^^^^^^ help: consider reducing it to: `*ones`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/dice.rs:83:9
[INFO] [stdout]    |
[INFO] [stdout] 83 | /         ones > &0 && twos > &0 && threes > &0 && fours > &0
[INFO] [stdout] 84 | |             || twos > &0 && threes > &0 && fours > &0 && fives > &0
[INFO] [stdout]    | |___________________________________________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 83 -         ones > &0 && twos > &0 && threes > &0 && fours > &0
[INFO] [stdout] 84 -             || twos > &0 && threes > &0 && fours > &0 && fives > &0
[INFO] [stdout] 83 +         !(twos <= &0 || threes <= &0 || fours <= &0 || ones <= &0 && fives <= &0)
[INFO] [stdout]    |
[INFO] [stdout] 83 -         ones > &0 && twos > &0 && threes > &0 && fours > &0
[INFO] [stdout] 84 -             || twos > &0 && threes > &0 && fours > &0 && fives > &0
[INFO] [stdout] 83 +         (fives > &0 || ones > &0) && fours > &0 && threes > &0 && twos > &0
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: calls to `push` immediately after creation
[INFO] [stdout]    --> src/dice.rs:153:9
[INFO] [stdout]     |
[INFO] [stdout] 153 | /         let mut keeps = Vec::new();
[INFO] [stdout] 154 | |         keeps.push(Self::EMPTY);
[INFO] [stdout]     | |________________________________^ help: consider using the `vec![]` macro: `let mut keeps = vec![..];`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
[INFO] [stdout]     = note: `#[warn(clippy::vec_init_then_push)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Dice` which implements the `Copy` trait
[INFO] [stdout]    --> src/dice.rs:162:40
[INFO] [stdout]     |
[INFO] [stdout] 162 |                         let mut keep = keep.clone();
[INFO] [stdout]     |                                        ^^^^^^^^^^^^ help: try dereferencing it: `*keep`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:27:15
[INFO] [stdout]    |
[INFO] [stdout] 27 |     turn_evs: &Vec<f32>,
[INFO] [stdout]    |               ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 27 -     turn_evs: &Vec<f32>,
[INFO] [stdout] 27 +     turn_evs: &[f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:28:16
[INFO] [stdout]    |
[INFO] [stdout] 28 |     all_rolls: &Vec<Dice>,
[INFO] [stdout]    |                ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 28 -     all_rolls: &Vec<Dice>,
[INFO] [stdout] 28 +     all_rolls: &[Dice],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:29:19
[INFO] [stdout]    |
[INFO] [stdout] 29 |     roll_scratch: &mut Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 29 -     roll_scratch: &mut Vec<f32>,
[INFO] [stdout] 29 +     roll_scratch: &mut [f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:60:19
[INFO] [stdout]    |
[INFO] [stdout] 60 |     keep_scratch: &mut Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 60 -     keep_scratch: &mut Vec<f32>,
[INFO] [stdout] 60 +     keep_scratch: &mut [f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:61:19
[INFO] [stdout]    |
[INFO] [stdout] 61 |     roll_scratch: &Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 61 -     roll_scratch: &Vec<f32>,
[INFO] [stdout] 61 +     roll_scratch: &[f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:78:19
[INFO] [stdout]    |
[INFO] [stdout] 78 |     keep_scratch: &Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 78 -     keep_scratch: &Vec<f32>,
[INFO] [stdout] 78 +     keep_scratch: &[f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:79:19
[INFO] [stdout]    |
[INFO] [stdout] 79 |     roll_scratch: &mut Vec<f32>,
[INFO] [stdout]    |                   ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 79 -     roll_scratch: &mut Vec<f32>,
[INFO] [stdout] 79 +     roll_scratch: &mut [f32],
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:94:40
[INFO] [stdout]    |
[INFO] [stdout] 94 | fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout]    |                                        ^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 94 - fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout] 94 + fn compute_begin_turn_ev(roll_scratch: &[f32], all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:94:62
[INFO] [stdout]    |
[INFO] [stdout] 94 | fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout]    |                                                              ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 94 - fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &Vec<Dice>) -> f32 {
[INFO] [stdout] 94 + fn compute_begin_turn_ev(roll_scratch: &Vec<f32>, all_rolls: &[Dice]) -> f32 {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.94s
[INFO] running `Command { std: "docker" "inspect" "5d3ccf23d740314c8b39d64da6dbe6647bf3cafb5e338115b3c26b6f72bd05d2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5d3ccf23d740314c8b39d64da6dbe6647bf3cafb5e338115b3c26b6f72bd05d2", kill_on_drop: false }`
[INFO] [stdout] 5d3ccf23d740314c8b39d64da6dbe6647bf3cafb5e338115b3c26b6f72bd05d2