[INFO] cloning repository https://github.com/dgc08/risp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dgc08/risp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgc08%2Frisp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgc08%2Frisp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8753024a147afe5ec15a05517380440427aaa2b3 [INFO] linting dgc08/risp against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdgc08%2Frisp" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dgc08/risp [INFO] finished tweaking git repo https://github.com/dgc08/risp [INFO] tweaked toml for git repo https://github.com/dgc08/risp written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dgc08/risp on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dgc08/risp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4a94cc434466d75339850edad3214ab8a65806a700de5b4541721423ca8d18b [INFO] running `Command { std: "docker" "start" "-a" "c4a94cc434466d75339850edad3214ab8a65806a700de5b4541721423ca8d18b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4a94cc434466d75339850edad3214ab8a65806a700de5b4541721423ca8d18b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4a94cc434466d75339850edad3214ab8a65806a700de5b4541721423ca8d18b", kill_on_drop: false }` [INFO] [stdout] c4a94cc434466d75339850edad3214ab8a65806a700de5b4541721423ca8d18b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa9ca980f24974773864d3b9425a0df4f0f27ea3c5ad47003a678e648c275475 [INFO] running `Command { std: "docker" "start" "-a" "aa9ca980f24974773864d3b9425a0df4f0f27ea3c5ad47003a678e648c275475", kill_on_drop: false }` [INFO] [stderr] Checking risp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `current_contenxt` is never read [INFO] [stdout] --> src/vm.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub struct VMState { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 142 | pub current_contenxt: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Src` is never constructed [INFO] [stdout] --> src/func.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 9 | enum FunctionSource<'a> { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 10 | FnPointer(&'a dyn Fn(Vec, &VMState) -> VMValue), [INFO] [stdout] 11 | Src(Vec), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FunctionSource` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_dynamic` is never used [INFO] [stdout] --> src/func.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 40 | impl Function { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn new_dynamic(tokens: Vec, num: usize) -> Function { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/vm.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | EOF [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/list.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 41 | current = &next; [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/list.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 68 | current = &next; [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/func/stdlib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lex.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / match ch { [INFO] [stdout] 46 | | 'A' ..='Z' | 'a' ..= 'z' | '0' ..= '9' | '_' => true, [INFO] [stdout] 47 | | _ => false [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 45 - match ch { [INFO] [stdout] 46 - 'A' ..='Z' | 'a' ..= 'z' | '0' ..= '9' | '_' => true, [INFO] [stdout] 47 - _ => false [INFO] [stdout] 48 - } [INFO] [stdout] 45 + matches!(ch, 'A' ..='Z' | 'a' ..= 'z' | '0' ..= '9' | '_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `current_contenxt` is never read [INFO] [stdout] --> src/vm.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub struct VMState { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 142 | pub current_contenxt: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Src` is never constructed [INFO] [stdout] --> src/func.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 9 | enum FunctionSource<'a> { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] 10 | FnPointer(&'a dyn Fn(Vec, &VMState) -> VMValue), [INFO] [stdout] 11 | Src(Vec), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FunctionSource` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new_dynamic` is never used [INFO] [stdout] --> src/func.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 40 | impl Function { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 53 | pub fn new_dynamic(tokens: Vec, num: usize) -> Function { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/vm.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | EOF [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/eval.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !iter.peek().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.peek().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/eval.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | while let Some(next_token) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next_token in iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:41:36 [INFO] [stdout] | [INFO] [stdout] 41 | let target = target_r.index(1, &vm).clone(); [INFO] [stdout] | ^^^ help: change this to: `vm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:42:64 [INFO] [stdout] | [INFO] [stdout] 42 | vm.set("test", target.add(VMValue::new_str(" ahahahahya"), &vm)); [INFO] [stdout] | ^^^ help: change this to: `vm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/list.rs:41:23 [INFO] [stdout] | [INFO] [stdout] 41 | current = &next; [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/list.rs:68:23 [INFO] [stdout] | [INFO] [stdout] 68 | current = &next; [INFO] [stdout] | ^^^^^ help: change this to: `next` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `println!` [INFO] [stdout] --> src/func/stdlib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | println!(""); [INFO] [stdout] | ^^^^^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stdout] = note: `#[warn(clippy::println_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/lex.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / match ch { [INFO] [stdout] 46 | | 'A' ..='Z' | 'a' ..= 'z' | '0' ..= '9' | '_' => true, [INFO] [stdout] 47 | | _ => false [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 45 - match ch { [INFO] [stdout] 46 - 'A' ..='Z' | 'a' ..= 'z' | '0' ..= '9' | '_' => true, [INFO] [stdout] 47 - _ => false [INFO] [stdout] 48 - } [INFO] [stdout] 45 + matches!(ch, 'A' ..='Z' | 'a' ..= 'z' | '0' ..= '9' | '_') [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/eval.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 39 | if !iter.peek().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.peek().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `for` loop [INFO] [stdout] --> src/eval.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | while let Some(next_token) = iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for next_token in iter.by_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stdout] = note: `#[warn(clippy::while_let_on_iterator)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:41:36 [INFO] [stdout] | [INFO] [stdout] 41 | let target = target_r.index(1, &vm).clone(); [INFO] [stdout] | ^^^ help: change this to: `vm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:42:64 [INFO] [stdout] | [INFO] [stdout] 42 | vm.set("test", target.add(VMValue::new_str(" ahahahahya"), &vm)); [INFO] [stdout] | ^^^ help: change this to: `vm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.27s [INFO] running `Command { std: "docker" "inspect" "aa9ca980f24974773864d3b9425a0df4f0f27ea3c5ad47003a678e648c275475", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa9ca980f24974773864d3b9425a0df4f0f27ea3c5ad47003a678e648c275475", kill_on_drop: false }` [INFO] [stdout] aa9ca980f24974773864d3b9425a0df4f0f27ea3c5ad47003a678e648c275475