[INFO] cloning repository https://github.com/dfrg/swash [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dfrg/swash" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdfrg%2Fswash", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdfrg%2Fswash'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fbdc592d874ff529334e0b42c65f8630ac4b59c0 [INFO] linting dfrg/swash/fbdc592d874ff529334e0b42c65f8630ac4b59c0 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdfrg%2Fswash" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dfrg/swash [INFO] finished tweaking git repo https://github.com/dfrg/swash [INFO] tweaked toml for git repo https://github.com/dfrg/swash written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dfrg/swash on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded zeno v0.3.3 [INFO] [stderr] Downloaded core_maths v0.1.1 [INFO] [stderr] Downloaded font-types v0.11.0 [INFO] [stderr] Downloaded skrifa v0.40.0 [INFO] [stderr] Downloaded read-fonts v0.37.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 697ef6620c91b4c576722a4cb9a84268c63017ee9b3d770cd8dbd17568fff5cf [INFO] running `Command { std: "docker" "start" "-a" "697ef6620c91b4c576722a4cb9a84268c63017ee9b3d770cd8dbd17568fff5cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "697ef6620c91b4c576722a4cb9a84268c63017ee9b3d770cd8dbd17568fff5cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "697ef6620c91b4c576722a4cb9a84268c63017ee9b3d770cd8dbd17568fff5cf", kill_on_drop: false }` [INFO] [stdout] 697ef6620c91b4c576722a4cb9a84268c63017ee9b3d770cd8dbd17568fff5cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dcdbb7a00fa4be5ace20bc50fb9c4fade3693499f0d2fb194216afbbc3c33c49 [INFO] running `Command { std: "docker" "start" "-a" "dcdbb7a00fa4be5ace20bc50fb9c4fade3693499f0d2fb194216afbbc3c33c49", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Checking yazi v0.2.1 [INFO] [stderr] Checking zeno v0.3.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking font-types v0.11.0 [INFO] [stderr] Checking read-fonts v0.37.0 [INFO] [stderr] Checking skrifa v0.40.0 [INFO] [stderr] Checking swash v0.2.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/attributes.rs:431:1 [INFO] [stdout] | [INFO] [stdout] 431 | / impl Default for Style { [INFO] [stdout] 432 | | fn default() -> Self { [INFO] [stdout] 433 | | Self::Normal [INFO] [stdout] 434 | | } [INFO] [stdout] 435 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 331 + #[derive(Default)] [INFO] [stdout] 332 | pub enum Style { [INFO] [stdout] 333 ~ #[default] [INFO] [stdout] 334 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/attributes.rs:431:1 [INFO] [stdout] | [INFO] [stdout] 431 | / impl Default for Style { [INFO] [stdout] 432 | | fn default() -> Self { [INFO] [stdout] 433 | | Self::Normal [INFO] [stdout] 434 | | } [INFO] [stdout] 435 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 331 + #[derive(Default)] [INFO] [stdout] 332 | pub enum Style { [INFO] [stdout] 333 ~ #[default] [INFO] [stdout] 334 ~ Normal, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/internal/at.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | self.data.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/internal/at.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | self.data.len() != 0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:439:43 [INFO] [stdout] | [INFO] [stdout] 439 | for row in src.chunks(((w * bits as usize) + 7) / 8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * bits as usize).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:448:43 [INFO] [stdout] | [INFO] [stdout] 448 | for row in src.chunks(((w * bits as usize) + 7) / 8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * bits as usize).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:457:43 [INFO] [stdout] | [INFO] [stdout] 457 | for row in src.chunks(((w * bits as usize) + 7) / 8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * bits as usize).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:686:21 [INFO] [stdout] | [INFO] [stdout] 686 | let w = (bitmap.width as usize * depth + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(bitmap.width as usize * depth).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:695:52 [INFO] [stdout] | [INFO] [stdout] 695 | bitmap.data = d.read_bytes(offset + 5, (w * h + 7) / 8)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * h).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:706:21 [INFO] [stdout] | [INFO] [stdout] 706 | let w = (bitmap.width as usize * depth + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(bitmap.width as usize * depth).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:715:52 [INFO] [stdout] | [INFO] [stdout] 715 | bitmap.data = d.read_bytes(offset + 8, (w * h + 7) / 8)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * h).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/scale/image.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / impl Default for Content { [INFO] [stdout] 21 | | fn default() -> Self { [INFO] [stdout] 22 | | Self::Mask [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub enum Content { [INFO] [stdout] 13 | /// 8-bit alpha mask. [INFO] [stdout] 14 ~ #[default] [INFO] [stdout] 15 ~ Mask, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:439:43 [INFO] [stdout] | [INFO] [stdout] 439 | for row in src.chunks(((w * bits as usize) + 7) / 8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * bits as usize).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:448:43 [INFO] [stdout] | [INFO] [stdout] 448 | for row in src.chunks(((w * bits as usize) + 7) / 8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * bits as usize).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:457:43 [INFO] [stdout] | [INFO] [stdout] 457 | for row in src.chunks(((w * bits as usize) + 7) / 8) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * bits as usize).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:686:21 [INFO] [stdout] | [INFO] [stdout] 686 | let w = (bitmap.width as usize * depth + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(bitmap.width as usize * depth).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:695:52 [INFO] [stdout] | [INFO] [stdout] 695 | bitmap.data = d.read_bytes(offset + 5, (w * h + 7) / 8)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * h).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:706:21 [INFO] [stdout] | [INFO] [stdout] 706 | let w = (bitmap.width as usize * depth + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(bitmap.width as usize * depth).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/strike.rs:715:52 [INFO] [stdout] | [INFO] [stdout] 715 | bitmap.data = d.read_bytes(offset + 8, (w * h + 7) / 8)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * h).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | this.pitch = (w * this.bpp + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * this.bpp).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:207:23 [INFO] [stdout] | [INFO] [stdout] 207 | this.bwidth = (this.bpp + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `this.bpp.div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scale/bitmap/png.rs:242:21 [INFO] [stdout] | [INFO] [stdout] 242 | / if bytes.len() > 4 && this.gamma.is_none() { [INFO] [stdout] 243 | | this.gamma = Some(get_u32be(bytes, 0) as f32 / 100000.); [INFO] [stdout] 244 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 241 ~ GAMA [INFO] [stdout] 242 ~ if bytes.len() > 4 && this.gamma.is_none() => { [INFO] [stdout] 243 | this.gamma = Some(get_u32be(bytes, 0) as f32 / 100000.); [INFO] [stdout] 244 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | 0 => (w + 7) / 8, [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:292:22 [INFO] [stdout] | [INFO] [stdout] 292 | 2 => (w + 3) / 4, [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | 4 => (w + 1) / 2, [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:307:29 [INFO] [stdout] | [INFO] [stdout] 307 | let pitch = (cols * bpp + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(cols * bpp).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `source.get(0)` [INFO] [stdout] --> src/scale/bitmap/png.rs:342:23 [INFO] [stdout] | [INFO] [stdout] 342 | let ty = *source.get(0)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `source.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `source.get(0)` [INFO] [stdout] --> src/scale/bitmap/png.rs:352:23 [INFO] [stdout] | [INFO] [stdout] 352 | let ty = *source.get(0)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `source.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `dy` is used as a loop counter [INFO] [stdout] --> src/scale/bitmap/mod.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | for sy in source_columns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (dy, sy) in (dest_y..).zip(source_columns)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/scale/image.rs:20:1 [INFO] [stdout] | [INFO] [stdout] 20 | / impl Default for Content { [INFO] [stdout] 21 | | fn default() -> Self { [INFO] [stdout] 22 | | Self::Mask [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 11 + #[derive(Default)] [INFO] [stdout] 12 | pub enum Content { [INFO] [stdout] 13 | /// 8-bit alpha mask. [INFO] [stdout] 14 ~ #[default] [INFO] [stdout] 15 ~ Mask, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:206:22 [INFO] [stdout] | [INFO] [stdout] 206 | this.pitch = (w * this.bpp + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(w * this.bpp).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:207:23 [INFO] [stdout] | [INFO] [stdout] 207 | this.bwidth = (this.bpp + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `this.bpp.div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/scale/mod.rs:278:1 [INFO] [stdout] | [INFO] [stdout] 278 | / impl Default for Source { [INFO] [stdout] 279 | | fn default() -> Self { [INFO] [stdout] 280 | | Self::Outline [INFO] [stdout] 281 | | } [INFO] [stdout] 282 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 267 + #[derive(Default)] [INFO] [stdout] 268 | pub enum Source { [INFO] [stdout] 269 | /// Scalable outlines. [INFO] [stdout] 270 ~ #[default] [INFO] [stdout] 271 ~ Outline, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/scale/bitmap/png.rs:242:21 [INFO] [stdout] | [INFO] [stdout] 242 | / if bytes.len() > 4 && this.gamma.is_none() { [INFO] [stdout] 243 | | this.gamma = Some(get_u32be(bytes, 0) as f32 / 100000.); [INFO] [stdout] 244 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 241 ~ GAMA [INFO] [stdout] 242 ~ if bytes.len() > 4 && this.gamma.is_none() => { [INFO] [stdout] 243 | this.gamma = Some(get_u32be(bytes, 0) as f32 / 100000.); [INFO] [stdout] 244 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:290:22 [INFO] [stdout] | [INFO] [stdout] 290 | 0 => (w + 7) / 8, [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:292:22 [INFO] [stdout] | [INFO] [stdout] 292 | 2 => (w + 3) / 4, [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(4)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:294:22 [INFO] [stdout] | [INFO] [stdout] 294 | 4 => (w + 1) / 2, [INFO] [stdout] | ^^^^^^^^^^^ help: consider using `.div_ceil()`: `w.div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/scale/bitmap/png.rs:307:29 [INFO] [stdout] | [INFO] [stdout] 307 | let pitch = (cols * bpp + 7) / 8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `(cols * bpp).div_ceil(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `source.get(0)` [INFO] [stdout] --> src/scale/bitmap/png.rs:342:23 [INFO] [stdout] | [INFO] [stdout] 342 | let ty = *source.get(0)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `source.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `source.get(0)` [INFO] [stdout] --> src/scale/bitmap/png.rs:352:23 [INFO] [stdout] | [INFO] [stdout] 352 | let ty = *source.get(0)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `source.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scale/mod.rs:579:56 [INFO] [stdout] | [INFO] [stdout] 579 | .draw(settings, &mut OutlineWriter(&mut outline)) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `outline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `dy` is used as a loop counter [INFO] [stdout] --> src/scale/bitmap/mod.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 53 | for sy in source_columns { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (dy, sy) in (dest_y..).zip(source_columns)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:23:48 [INFO] [stdout] | [INFO] [stdout] 23 | for (_i, subtable) in chain.subtables().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 23 - for (_i, subtable) in chain.subtables().enumerate() { [INFO] [stdout] 23 + for subtable in chain.subtables() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:91:60 [INFO] [stdout] | [INFO] [stdout] 91 | for (_i, g) in buffer.glyphs.iter_mut().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 91 - for (_i, g) in buffer.glyphs.iter_mut().enumerate() { [INFO] [stdout] 91 + for g in buffer.glyphs.iter_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/scale/mod.rs:278:1 [INFO] [stdout] | [INFO] [stdout] 278 | / impl Default for Source { [INFO] [stdout] 279 | | fn default() -> Self { [INFO] [stdout] 280 | | Self::Outline [INFO] [stdout] 281 | | } [INFO] [stdout] 282 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 267 + #[derive(Default)] [INFO] [stdout] 268 | pub enum Source { [INFO] [stdout] 269 | /// Scalable outlines. [INFO] [stdout] 270 ~ #[default] [INFO] [stdout] 271 ~ Outline, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:186:54 [INFO] [stdout] | [INFO] [stdout] 186 | for (_i, subtable) in subtables(data, kerx, ankr).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 186 - for (_i, subtable) in subtables(data, kerx, ankr).enumerate() { [INFO] [stdout] 186 + for subtable in subtables(data, kerx, ankr) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:306:48 [INFO] [stdout] | [INFO] [stdout] 306 | for (_i, subtable) in subtables(data, kern).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 306 - for (_i, subtable) in subtables(data, kern).enumerate() { [INFO] [stdout] 306 + for subtable in subtables(data, kern) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual absolute difference pattern without using `abs_diff` [INFO] [stdout] --> src/shape/aat.rs:362:44 [INFO] [stdout] | [INFO] [stdout] 362 | ... let diff = if base >= i { base - i } else { i - base }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with `abs_diff`: `base.abs_diff(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_abs_diff [INFO] [stdout] = note: `#[warn(clippy::manual_abs_diff)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/scale/mod.rs:579:56 [INFO] [stdout] | [INFO] [stdout] 579 | .draw(settings, &mut OutlineWriter(&mut outline)) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `outline` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/shape/at.rs:390:13 [INFO] [stdout] | [INFO] [stdout] 390 | cache.sub_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 390 - cache.sub_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 390 + cache.sub_features.sort_unstable_by_key(|a| a.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/shape/at.rs:396:13 [INFO] [stdout] | [INFO] [stdout] 396 | cache.pos_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 396 - cache.pos_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 396 + cache.pos_features.sort_unstable_by_key(|a| a.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/shape/at.rs:468:9 [INFO] [stdout] | [INFO] [stdout] 468 | self.indices.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 468 - self.indices.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 468 + self.indices.sort_unstable_by_key(|a| a.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:23:48 [INFO] [stdout] | [INFO] [stdout] 23 | for (_i, subtable) in chain.subtables().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 23 - for (_i, subtable) in chain.subtables().enumerate() { [INFO] [stdout] 23 + for subtable in chain.subtables() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/shape/at.rs:573:42 [INFO] [stdout] | [INFO] [stdout] 573 | coverage.resize(coverage.len() + (range_len + 15) / 16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `range_len.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:91:60 [INFO] [stdout] | [INFO] [stdout] 91 | for (_i, g) in buffer.glyphs.iter_mut().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 91 - for (_i, g) in buffer.glyphs.iter_mut().enumerate() { [INFO] [stdout] 91 + for g in buffer.glyphs.iter_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:186:54 [INFO] [stdout] | [INFO] [stdout] 186 | for (_i, subtable) in subtables(data, kerx, ankr).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 186 - for (_i, subtable) in subtables(data, kerx, ankr).enumerate() { [INFO] [stdout] 186 + for subtable in subtables(data, kerx, ankr) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/shape/aat.rs:306:48 [INFO] [stdout] | [INFO] [stdout] 306 | for (_i, subtable) in subtables(data, kern).enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 306 - for (_i, subtable) in subtables(data, kern).enumerate() { [INFO] [stdout] 306 + for subtable in subtables(data, kern) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual absolute difference pattern without using `abs_diff` [INFO] [stdout] --> src/shape/aat.rs:362:44 [INFO] [stdout] | [INFO] [stdout] 362 | ... let diff = if base >= i { base - i } else { i - base }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with `abs_diff`: `base.abs_diff(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_abs_diff [INFO] [stdout] = note: `#[warn(clippy::manual_abs_diff)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/shape/at.rs:915:9 [INFO] [stdout] | [INFO] [stdout] 915 | for g in &self.buf.glyphs[self.s.cur + 1..self.s.end] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, g) in (self.s.cur + 1..).zip(self.buf.glyphs[self.s.cur + 1..self.s.end].iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/shape/at.rs:390:13 [INFO] [stdout] | [INFO] [stdout] 390 | cache.sub_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 390 - cache.sub_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 390 + cache.sub_features.sort_unstable_by_key(|a| a.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/shape/at.rs:396:13 [INFO] [stdout] | [INFO] [stdout] 396 | cache.pos_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 396 - cache.pos_features.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 396 + cache.pos_features.sort_unstable_by_key(|a| a.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/shape/at.rs:468:9 [INFO] [stdout] | [INFO] [stdout] 468 | self.indices.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 468 - self.indices.sort_unstable_by(|a, b| a.0.cmp(&b.0)); [INFO] [stdout] 468 + self.indices.sort_unstable_by_key(|a| a.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/shape/at.rs:573:42 [INFO] [stdout] | [INFO] [stdout] 573 | coverage.resize(coverage.len() + (range_len + 15) / 16, 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `range_len.div_ceil(16)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/shape/at.rs:915:9 [INFO] [stdout] | [INFO] [stdout] 915 | for g in &self.buf.glyphs[self.s.cur + 1..self.s.end] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, g) in (self.s.cur + 1..).zip(self.buf.glyphs[self.s.cur + 1..self.s.end].iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/shape/buffer.rs:579:17 [INFO] [stdout] | [INFO] [stdout] 579 | / if reph.is_none() { [INFO] [stdout] 580 | | reph = Some(i); [INFO] [stdout] 581 | | ignored[i] = true; [INFO] [stdout] 582 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 578 ~ Reph [INFO] [stdout] 579 ~ if reph.is_none() => { [INFO] [stdout] 580 | reph = Some(i); [INFO] [stdout] 581 | ignored[i] = true; [INFO] [stdout] 582 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/shape/buffer.rs:585:17 [INFO] [stdout] | [INFO] [stdout] 585 | / if pref.is_none() { [INFO] [stdout] 586 | | pref = Some(i); [INFO] [stdout] 587 | | ignored[i] = true; [INFO] [stdout] 588 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 584 ~ Pref [INFO] [stdout] 585 ~ if pref.is_none() => { [INFO] [stdout] 586 | pref = Some(i); [INFO] [stdout] 587 | ignored[i] = true; [INFO] [stdout] 588 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/shape/buffer.rs:579:17 [INFO] [stdout] | [INFO] [stdout] 579 | / if reph.is_none() { [INFO] [stdout] 580 | | reph = Some(i); [INFO] [stdout] 581 | | ignored[i] = true; [INFO] [stdout] 582 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 578 ~ Reph [INFO] [stdout] 579 ~ if reph.is_none() => { [INFO] [stdout] 580 | reph = Some(i); [INFO] [stdout] 581 | ignored[i] = true; [INFO] [stdout] 582 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/shape/buffer.rs:585:17 [INFO] [stdout] | [INFO] [stdout] 585 | / if pref.is_none() { [INFO] [stdout] 586 | | pref = Some(i); [INFO] [stdout] 587 | | ignored[i] = true; [INFO] [stdout] 588 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 584 ~ Pref [INFO] [stdout] 585 ~ if pref.is_none() => { [INFO] [stdout] 586 | pref = Some(i); [INFO] [stdout] 587 | ignored[i] = true; [INFO] [stdout] 588 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/shape/mod.rs:854:17 [INFO] [stdout] | [INFO] [stdout] 854 | / if !self.state.disable_kern { [INFO] [stdout] 855 | | e.kern(buf); [INFO] [stdout] 856 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 853 ~ PosMode::Kern [INFO] [stdout] 854 ~ if !self.state.disable_kern => { [INFO] [stdout] 855 | e.kern(buf); [INFO] [stdout] 856 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/text/compose.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if (a - SBASE) % TCOUNT == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(a - SBASE).is_multiple_of(TCOUNT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/shape/mod.rs:854:17 [INFO] [stdout] | [INFO] [stdout] 854 | / if !self.state.disable_kern { [INFO] [stdout] 855 | | e.kern(buf); [INFO] [stdout] 856 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 853 ~ PosMode::Kern [INFO] [stdout] 854 ~ if !self.state.disable_kern => { [INFO] [stdout] 855 | e.kern(buf); [INFO] [stdout] 856 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/text/compose.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 117 | if (a - SBASE) % TCOUNT == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(a - SBASE).is_multiple_of(TCOUNT)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/lang_data.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | pub const LANG_ENTRIES: [(&'static str, &'static str); 715] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 134 | | ("Abaza", "abq"), ("Abkhazian", "ab"), ("Acoli", "ach"), ("Achi", "acr"), ("Adyghe", "ady"), ("Afrikaans", "af"), ("Afar", "a... [INFO] [stdout] 135 | | ("Aari", "aiw"), ("Marma", "rmz"), ("Rakhine", "rki"), ("Assamese", "as"), ("Asturian", "ast"), ("Tsetsaut", "txc"), ("Mattol... [INFO] [stdout] 136 | | ("Tanaina", "tfn"), ("Lower Tanana", "taa"), ("Upper Tanana", "tau"), ("Tanacross", "tcb"), ("Upper Kuskokwim", "kuu"), ("Sou... [INFO] [stdout] ... | [INFO] [stdout] 176 | | ("Zaza", "zza"), [INFO] [stdout] 177 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] = note: `#[warn(clippy::large_const_arrays)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/lang_data.rs:133:1 [INFO] [stdout] | [INFO] [stdout] 133 | pub const LANG_ENTRIES: [(&'static str, &'static str); 715] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 134 | | ("Abaza", "abq"), ("Abkhazian", "ab"), ("Acoli", "ach"), ("Achi", "acr"), ("Adyghe", "ady"), ("Afrikaans", "af"), ("Afar", "a... [INFO] [stdout] 135 | | ("Aari", "aiw"), ("Marma", "rmz"), ("Rakhine", "rki"), ("Assamese", "as"), ("Asturian", "ast"), ("Tsetsaut", "txc"), ("Mattol... [INFO] [stdout] 136 | | ("Tanaina", "tfn"), ("Lower Tanana", "taa"), ("Upper Tanana", "tau"), ("Tanacross", "tcb"), ("Upper Kuskokwim", "kuu"), ("Sou... [INFO] [stdout] ... | [INFO] [stdout] 176 | | ("Zaza", "zza"), [INFO] [stdout] 177 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] = note: `#[warn(clippy::large_const_arrays)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:1727:1 [INFO] [stdout] | [INFO] [stdout] 1727 | const RECORD_INDEX2: [u16; 14744] = [ [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | _help: make this a static item: `static` [INFO] [stdout] | | [INFO] [stdout] 1728 | | 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 2, 3, 4, 5, 0, 0, 0, 0, 0, 0, 6, 6, 6, 7, 8, 9, 10, 11, 12, 13, [INFO] [stdout] 1729 | | 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 25, 26, 27, 27, [INFO] [stdout] 1730 | | 27, 9, 14, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 16, 29, 17, [INFO] [stdout] ... | [INFO] [stdout] 2576 | | 2033, 2033, 2033, 2034, 2034, [INFO] [stdout] 2577 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:1727:1 [INFO] [stdout] | [INFO] [stdout] 1727 | const RECORD_INDEX2: [u16; 14744] = [ [INFO] [stdout] | ^---- [INFO] [stdout] | | [INFO] [stdout] | _help: make this a static item: `static` [INFO] [stdout] | | [INFO] [stdout] 1728 | | 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 2, 3, 4, 5, 0, 0, 0, 0, 0, 0, 6, 6, 6, 7, 8, 9, 10, 11, 12, 13, [INFO] [stdout] 1729 | | 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 24, 24, 24, 24, 24, 24, 24, 24, 24, 25, 26, 27, 27, [INFO] [stdout] 1730 | | 27, 9, 14, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 28, 16, 29, 17, [INFO] [stdout] ... | [INFO] [stdout] 2576 | | 2033, 2033, 2033, 2034, 2034, [INFO] [stdout] 2577 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:2682:1 [INFO] [stdout] | [INFO] [stdout] 2682 | pub const RECORDS: [Record; 2035] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 2683 | | r(32,C::Control,B::BasicLatin,S::Common,0,Bc::BN,Jt::U,Cb::CN,Wb::XX,Lb::CM,Uc::O,Mc::O), r(32,C::Control,B::BasicLatin,S::C... [INFO] [stdout] 2684 | | r(32,C::Control,B::BasicLatin,S::Common,0,Bc::B,Jt::U,Cb::LF,Wb::LF,Lb::LF,Uc::O,Mc::O), r(32,C::Control,B::BasicLatin,S::Co... [INFO] [stdout] 2685 | | r(32,C::Control,B::BasicLatin,S::Common,0,Bc::WS,Jt::U,Cb::CN,Wb::NL,Lb::BK,Uc::O,Mc::O), r(32,C::Control,B::BasicLatin,S::C... [INFO] [stdout] ... | [INFO] [stdout] 3725 | | r(64,C::Other,B::SupplementaryPrivateUseAreaB,S::Unknown,0,Bc::L,Jt::U,Cb::XX,Wb::XX,Lb::XX,Uc::O,Mc::O), [INFO] [stdout] 3726 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:2682:1 [INFO] [stdout] | [INFO] [stdout] 2682 | pub const RECORDS: [Record; 2035] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 2683 | | r(32,C::Control,B::BasicLatin,S::Common,0,Bc::BN,Jt::U,Cb::CN,Wb::XX,Lb::CM,Uc::O,Mc::O), r(32,C::Control,B::BasicLatin,S::C... [INFO] [stdout] 2684 | | r(32,C::Control,B::BasicLatin,S::Common,0,Bc::B,Jt::U,Cb::LF,Wb::LF,Lb::LF,Uc::O,Mc::O), r(32,C::Control,B::BasicLatin,S::Co... [INFO] [stdout] 2685 | | r(32,C::Control,B::BasicLatin,S::Common,0,Bc::WS,Jt::U,Cb::CN,Wb::NL,Lb::BK,Uc::O,Mc::O), r(32,C::Control,B::BasicLatin,S::C... [INFO] [stdout] ... | [INFO] [stdout] 3725 | | r(64,C::Other,B::SupplementaryPrivateUseAreaB,S::Unknown,0,Bc::L,Jt::U,Cb::XX,Wb::XX,Lb::XX,Uc::O,Mc::O), [INFO] [stdout] 3726 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:4758:1 [INFO] [stdout] | [INFO] [stdout] 4758 | pub const DECOMPOSE: [u32; 5469] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 4759 | | 0, 255, 2, 65, 768, 2, 65, 769, 2, 65, 770, 2, 65, 771, 2, 65, 776, 2, 65, 778, 2, 67, 807, 2, [INFO] [stdout] 4760 | | 69, 768, 2, 69, 769, 2, 69, 770, 2, 69, 776, 2, 73, 768, 2, 73, 769, 2, 73, 770, 2, 73, 776, 2, [INFO] [stdout] 4761 | | 78, 771, 2, 79, 768, 2, 79, 769, 2, 79, 770, 2, 79, 771, 2, 79, 776, 2, 85, 768, 2, 85, 769, 2, [INFO] [stdout] ... | [INFO] [stdout] 5036 | | 40697, 1, 40702, 1, 40709, 1, 40719, 1, 40726, 1, 40763, 1, 173568, [INFO] [stdout] 5037 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:4758:1 [INFO] [stdout] | [INFO] [stdout] 4758 | pub const DECOMPOSE: [u32; 5469] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 4759 | | 0, 255, 2, 65, 768, 2, 65, 769, 2, 65, 770, 2, 65, 771, 2, 65, 776, 2, 65, 778, 2, 67, 807, 2, [INFO] [stdout] 4760 | | 69, 768, 2, 69, 769, 2, 69, 770, 2, 69, 776, 2, 73, 768, 2, 73, 769, 2, 73, 770, 2, 73, 776, 2, [INFO] [stdout] 4761 | | 78, 771, 2, 79, 768, 2, 79, 769, 2, 79, 770, 2, 79, 771, 2, 79, 776, 2, 85, 768, 2, 85, 769, 2, [INFO] [stdout] ... | [INFO] [stdout] 5036 | | 40697, 1, 40702, 1, 40709, 1, 40719, 1, 40726, 1, 40763, 1, 173568, [INFO] [stdout] 5037 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:5040:1 [INFO] [stdout] | [INFO] [stdout] 5040 | pub const DECOMPOSE_COMPAT: [u32; 9307] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 5041 | | 0, 255, 1, 32, 2, 32, 776, 1, 97, 2, 32, 772, 1, 50, 1, 51, 2, 32, 769, 1, 956, 2, 32, 807, 1, [INFO] [stdout] 5042 | | 49, 1, 111, 3, 49, 8260, 52, 3, 49, 8260, 50, 3, 51, 8260, 52, 2, 73, 74, 2, 105, 106, 2, 76, [INFO] [stdout] 5043 | | 183, 2, 108, 183, 2, 700, 110, 1, 115, 3, 68, 90, 780, 3, 68, 122, 780, 3, 100, 122, 780, 2, [INFO] [stdout] ... | [INFO] [stdout] 5482 | | 1, 51, 1, 52, 1, 53, 1, 54, 1, 55, 1, 56, 1, 57, [INFO] [stdout] 5483 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/text/unicode_data.rs:5040:1 [INFO] [stdout] | [INFO] [stdout] 5040 | pub const DECOMPOSE_COMPAT: [u32; 9307] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 5041 | | 0, 255, 1, 32, 2, 32, 776, 1, 97, 2, 32, 772, 1, 50, 1, 51, 2, 32, 769, 1, 956, 2, 32, 807, 1, [INFO] [stdout] 5042 | | 49, 1, 111, 3, 49, 8260, 52, 3, 49, 8260, 50, 3, 51, 8260, 52, 2, 73, 74, 2, 105, 106, 2, 76, [INFO] [stdout] 5043 | | 183, 2, 108, 183, 2, 700, 110, 1, 115, 3, 68, 90, 780, 3, 68, 122, 780, 3, 100, 122, 780, 2, [INFO] [stdout] ... | [INFO] [stdout] 5482 | | 1, 51, 1, 52, 1, 53, 1, 54, 1, 55, 1, 56, 1, 57, [INFO] [stdout] 5483 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/text/cluster/char.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | / impl Default for ShapeClass { [INFO] [stdout] 80 | | fn default() -> Self { [INFO] [stdout] 81 | | Self::Base [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 44 + #[derive(Default)] [INFO] [stdout] 45 | pub enum ShapeClass { [INFO] [stdout] 46 | /// Reph form. [INFO] [stdout] ... [INFO] [stdout] 52 | /// Base character. [INFO] [stdout] 53 ~ #[default] [INFO] [stdout] 54 ~ Base, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/text/cluster/char.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | / impl Default for ShapeClass { [INFO] [stdout] 80 | | fn default() -> Self { [INFO] [stdout] 81 | | Self::Base [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant [INFO] [stdout] | [INFO] [stdout] 44 + #[derive(Default)] [INFO] [stdout] 45 | pub enum ShapeClass { [INFO] [stdout] 46 | /// Reph form. [INFO] [stdout] ... [INFO] [stdout] 52 | /// Base character. [INFO] [stdout] 53 ~ #[default] [INFO] [stdout] 54 ~ Base, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.01s [INFO] running `Command { std: "docker" "inspect" "dcdbb7a00fa4be5ace20bc50fb9c4fade3693499f0d2fb194216afbbc3c33c49", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dcdbb7a00fa4be5ace20bc50fb9c4fade3693499f0d2fb194216afbbc3c33c49", kill_on_drop: false }` [INFO] [stdout] dcdbb7a00fa4be5ace20bc50fb9c4fade3693499f0d2fb194216afbbc3c33c49