[INFO] cloning repository https://github.com/devkcud/bfree [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/devkcud/bfree" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevkcud%2Fbfree", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevkcud%2Fbfree'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b87423ee9f87811bb8a3f856ff8241ec1735fdcc [INFO] linting devkcud/bfree against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevkcud%2Fbfree" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/devkcud/bfree [INFO] finished tweaking git repo https://github.com/devkcud/bfree [INFO] tweaked toml for git repo https://github.com/devkcud/bfree written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/devkcud/bfree on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/devkcud/bfree already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rustix v0.37.11 [INFO] [stderr] Downloaded serde v1.0.159 [INFO] [stderr] Downloaded prettytable v0.10.0 [INFO] [stderr] Downloaded libc v0.2.141 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e059afde658da5c6da979e7adbf461458ef5da799ea611cc7fa7883553e5a14 [INFO] running `Command { std: "docker" "start" "-a" "7e059afde658da5c6da979e7adbf461458ef5da799ea611cc7fa7883553e5a14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e059afde658da5c6da979e7adbf461458ef5da799ea611cc7fa7883553e5a14", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e059afde658da5c6da979e7adbf461458ef5da799ea611cc7fa7883553e5a14", kill_on_drop: false }` [INFO] [stdout] 7e059afde658da5c6da979e7adbf461458ef5da799ea611cc7fa7883553e5a14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 77c2223b75769c4158a7a39be8eb301085d6390c149ef25a0e5f560dda29d063 [INFO] running `Command { std: "docker" "start" "-a" "77c2223b75769c4158a7a39be8eb301085d6390c149ef25a0e5f560dda29d063", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.141 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Compiling io-lifetimes v1.0.10 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.14 [INFO] [stderr] Compiling serde v1.0.159 [INFO] [stderr] Compiling rustix v0.37.11 [INFO] [stderr] Checking linux-raw-sys v0.3.1 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking crossbeam-channel v0.5.7 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rayon-core v1.11.0 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking csv v1.2.1 [INFO] [stderr] Checking prettytable v0.10.0 [INFO] [stderr] Checking sysinfo v0.28.4 [INFO] [stderr] Checking bfree v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/args.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / return ArgsConstructor { [INFO] [stdout] 26 | | commands, [INFO] [stdout] 27 | | flags, [INFO] [stdout] 28 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ ArgsConstructor { [INFO] [stdout] 26 + commands, [INFO] [stdout] 27 + flags, [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/utils/args.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|e| e.chars()) [INFO] [stdout] | ______________^ [INFO] [stdout] 16 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|e| e.chars())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/args.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return self.flags [INFO] [stdout] 33 | | .iter() [INFO] [stdout] 34 | | .filter(|f| f.starts_with(FLAG_IDENTIFIER)) [INFO] [stdout] 35 | | .flat_map(|f| f.chars().skip(1)) [INFO] [stdout] 36 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ self.flags [INFO] [stdout] 33 + .iter() [INFO] [stdout] 34 + .filter(|f| f.starts_with(FLAG_IDENTIFIER)) [INFO] [stdout] 35 + .flat_map(|f| f.chars().skip(1)) [INFO] [stdout] 36 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/args.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return self.get_flags().iter().find(|e| **e == flag).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return self.get_flags().iter().find(|e| **e == flag).is_some(); [INFO] [stdout] 40 + self.get_flags().iter().find(|e| **e == flag).is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/utils/args.rs:43:62 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn functionize(&self, flag: char, mut callback: F) -> () where F: FnMut() { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/help.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / ... return HelpMenu { [INFO] [stdout] 15 | | ... // May God forgive my sins. [INFO] [stdout] 16 | | ... project_name: String::from(*args().collect::>().first().unwrap_or(&"bfree".to_string()).to_string().split('/... [INFO] [stdout] ... | [INFO] [stdout] 19 | | ... flags: Vec::new(), [INFO] [stdout] 20 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ HelpMenu { [INFO] [stdout] 15 + // May God forgive my sins. [INFO] [stdout] 16 + project_name: String::from(*args().collect::>().first().unwrap_or(&"bfree".to_string()).to_string().split('/').collect::>().last().unwrap_or(&"bfree")), [INFO] [stdout] 17 + [INFO] [stdout] 18 + commands: Vec::new(), [INFO] [stdout] 19 + flags: Vec::new(), [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/help.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | ...tring::from(*args().collect::>().first().unwrap_or(&"bfree".to_string()).to_string().split('/').collect::>(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `args().collect::>().first().unwrap_or(&"bfree".to_string()).as_ref().split('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/help.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self; [INFO] [stdout] 25 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/help.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return self; [INFO] [stdout] 30 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/args.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | / return ArgsConstructor { [INFO] [stdout] 26 | | commands, [INFO] [stdout] 27 | | flags, [INFO] [stdout] 28 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 ~ ArgsConstructor { [INFO] [stdout] 26 + commands, [INFO] [stdout] 27 + flags, [INFO] [stdout] 28 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/utils/args.rs:15:14 [INFO] [stdout] | [INFO] [stdout] 15 | .map(|e| e.chars()) [INFO] [stdout] | ______________^ [INFO] [stdout] 16 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|e| e.chars())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/args.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / return self.flags [INFO] [stdout] 33 | | .iter() [INFO] [stdout] 34 | | .filter(|f| f.starts_with(FLAG_IDENTIFIER)) [INFO] [stdout] 35 | | .flat_map(|f| f.chars().skip(1)) [INFO] [stdout] 36 | | .collect(); [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 ~ self.flags [INFO] [stdout] 33 + .iter() [INFO] [stdout] 34 + .filter(|f| f.starts_with(FLAG_IDENTIFIER)) [INFO] [stdout] 35 + .flat_map(|f| f.chars().skip(1)) [INFO] [stdout] 36 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/args.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | return self.get_flags().iter().find(|e| **e == flag).is_some(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return self.get_flags().iter().find(|e| **e == flag).is_some(); [INFO] [stdout] 40 + self.get_flags().iter().find(|e| **e == flag).is_some() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/utils/args.rs:43:62 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn functionize(&self, flag: char, mut callback: F) -> () where F: FnMut() { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/table.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return MemoryTable { [INFO] [stdout] 30 | | memoman: RefCell::new(memoman), [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | row_titles: RefCell::new(row_titles), [INFO] [stdout] ... | [INFO] [stdout] 39 | | quiet, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ MemoryTable { [INFO] [stdout] 30 + memoman: RefCell::new(memoman), [INFO] [stdout] 31 + [INFO] [stdout] 32 + row_titles: RefCell::new(row_titles), [INFO] [stdout] 33 + row_memory: RefCell::new(if quiet { row![] } else { row!["Memory".yellow().bold()] }), [INFO] [stdout] 34 + row_swap: RefCell::new(if quiet { row![] } else { row!["Swap".yellow().bold()] }), [INFO] [stdout] 35 + [INFO] [stdout] 36 + show_memory, [INFO] [stdout] 37 + show_swap, [INFO] [stdout] 38 + [INFO] [stdout] 39 + quiet, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/memory/table.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | if self.show_memory || (!self.show_memory && !self.show_swap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - if self.show_memory || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 53 + if !(!self.show_memory && self.show_swap) { [INFO] [stdout] | [INFO] [stdout] 53 - if self.show_memory || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 53 + if self.show_memory || !self.show_swap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/memory/table.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | if self.show_swap || (!self.show_memory && !self.show_swap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - if self.show_swap || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 58 + if !(!self.show_swap && self.show_memory) { [INFO] [stdout] | [INFO] [stdout] 58 - if self.show_swap || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 58 + if self.show_swap || !self.show_memory { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/help.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / ... return HelpMenu { [INFO] [stdout] 15 | | ... // May God forgive my sins. [INFO] [stdout] 16 | | ... project_name: String::from(*args().collect::>().first().unwrap_or(&"bfree".to_string()).to_string().split('/... [INFO] [stdout] ... | [INFO] [stdout] 19 | | ... flags: Vec::new(), [INFO] [stdout] 20 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ HelpMenu { [INFO] [stdout] 15 + // May God forgive my sins. [INFO] [stdout] 16 + project_name: String::from(*args().collect::>().first().unwrap_or(&"bfree".to_string()).to_string().split('/').collect::>().last().unwrap_or(&"bfree")), [INFO] [stdout] 17 + [INFO] [stdout] 18 + commands: Vec::new(), [INFO] [stdout] 19 + flags: Vec::new(), [INFO] [stdout] 20 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/help.rs:16:41 [INFO] [stdout] | [INFO] [stdout] 16 | ...tring::from(*args().collect::>().first().unwrap_or(&"bfree".to_string()).to_string().split('/').collect::>(... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `args().collect::>().first().unwrap_or(&"bfree".to_string()).as_ref().split('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/help.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self; [INFO] [stdout] 25 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/help.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return self; [INFO] [stdout] 30 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/table.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return table; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return table; [INFO] [stdout] 124 + table [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return MemoryManager { [INFO] [stdout] 12 | | system: System::new(), [INFO] [stdout] 13 | | as_bytes, [INFO] [stdout] 14 | | factor: if as_bytes { 1 } else { 1024 << 10 }, [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ MemoryManager { [INFO] [stdout] 12 + system: System::new(), [INFO] [stdout] 13 + as_bytes, [INFO] [stdout] 14 + factor: if as_bytes { 1 } else { 1024 << 10 }, [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/memory/manager.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn refresh(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - self.system.refresh_memory(); [INFO] [stdout] 20 - return; [INFO] [stdout] 19 + self.system.refresh_memory(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return (memory / self.factor, swap / self.factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return (memory / self.factor, swap / self.factor); [INFO] [stdout] 27 + (memory / self.factor, swap / self.factor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return (memory / self.factor, swap / self.factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return (memory / self.factor, swap / self.factor); [INFO] [stdout] 34 + (memory / self.factor, swap / self.factor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return (memory / self.factor, swap / self.factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return (memory / self.factor, swap / self.factor); [INFO] [stdout] 41 + (memory / self.factor, swap / self.factor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return memory / self.factor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return memory / self.factor; [INFO] [stdout] 47 + memory / self.factor [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/table.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | / return MemoryTable { [INFO] [stdout] 30 | | memoman: RefCell::new(memoman), [INFO] [stdout] 31 | | [INFO] [stdout] 32 | | row_titles: RefCell::new(row_titles), [INFO] [stdout] ... | [INFO] [stdout] 39 | | quiet, [INFO] [stdout] 40 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 ~ MemoryTable { [INFO] [stdout] 30 + memoman: RefCell::new(memoman), [INFO] [stdout] 31 + [INFO] [stdout] 32 + row_titles: RefCell::new(row_titles), [INFO] [stdout] 33 + row_memory: RefCell::new(if quiet { row![] } else { row!["Memory".yellow().bold()] }), [INFO] [stdout] 34 + row_swap: RefCell::new(if quiet { row![] } else { row!["Swap".yellow().bold()] }), [INFO] [stdout] 35 + [INFO] [stdout] 36 + show_memory, [INFO] [stdout] 37 + show_swap, [INFO] [stdout] 38 + [INFO] [stdout] 39 + quiet, [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/memory/table.rs:53:20 [INFO] [stdout] | [INFO] [stdout] 53 | if self.show_memory || (!self.show_memory && !self.show_swap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 53 - if self.show_memory || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 53 + if !(!self.show_memory && self.show_swap) { [INFO] [stdout] | [INFO] [stdout] 53 - if self.show_memory || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 53 + if self.show_memory || !self.show_swap { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/memory/table.rs:58:20 [INFO] [stdout] | [INFO] [stdout] 58 | if self.show_swap || (!self.show_memory && !self.show_swap) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 58 - if self.show_swap || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 58 + if !(!self.show_swap && self.show_memory) { [INFO] [stdout] | [INFO] [stdout] 58 - if self.show_swap || (!self.show_memory && !self.show_swap) { [INFO] [stdout] 58 + if self.show_swap || !self.show_memory { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/table.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | return table; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 - return table; [INFO] [stdout] 124 + table [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | / return MemoryManager { [INFO] [stdout] 12 | | system: System::new(), [INFO] [stdout] 13 | | as_bytes, [INFO] [stdout] 14 | | factor: if as_bytes { 1 } else { 1024 << 10 }, [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 ~ MemoryManager { [INFO] [stdout] 12 + system: System::new(), [INFO] [stdout] 13 + as_bytes, [INFO] [stdout] 14 + factor: if as_bytes { 1 } else { 1024 << 10 }, [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/memory/manager.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn refresh(&mut self) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - self.system.refresh_memory(); [INFO] [stdout] 20 - return; [INFO] [stdout] 19 + self.system.refresh_memory(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return (memory / self.factor, swap / self.factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return (memory / self.factor, swap / self.factor); [INFO] [stdout] 27 + (memory / self.factor, swap / self.factor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | return (memory / self.factor, swap / self.factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return (memory / self.factor, swap / self.factor); [INFO] [stdout] 34 + (memory / self.factor, swap / self.factor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return (memory / self.factor, swap / self.factor); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return (memory / self.factor, swap / self.factor); [INFO] [stdout] 41 + (memory / self.factor, swap / self.factor) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memory/manager.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | return memory / self.factor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return memory / self.factor; [INFO] [stdout] 47 + memory / self.factor [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.95s [INFO] running `Command { std: "docker" "inspect" "77c2223b75769c4158a7a39be8eb301085d6390c149ef25a0e5f560dda29d063", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "77c2223b75769c4158a7a39be8eb301085d6390c149ef25a0e5f560dda29d063", kill_on_drop: false }` [INFO] [stdout] 77c2223b75769c4158a7a39be8eb301085d6390c149ef25a0e5f560dda29d063