[INFO] cloning repository https://github.com/devalexwhite/md-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/devalexwhite/md-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevalexwhite%2Fmd-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevalexwhite%2Fmd-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0b38432331f971a9e88ee879df8245b9ecac282e [INFO] linting devalexwhite/md-server against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdevalexwhite%2Fmd-server" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/devalexwhite/md-server [INFO] finished tweaking git repo https://github.com/devalexwhite/md-server [INFO] tweaked toml for git repo https://github.com/devalexwhite/md-server written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/devalexwhite/md-server on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/devalexwhite/md-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lru v0.12.5 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.112 [INFO] [stderr] Downloaded cassowary v0.3.0 [INFO] [stderr] Downloaded libyml v0.0.5 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.112 [INFO] [stderr] Downloaded maud_macros v0.26.0 [INFO] [stderr] Downloaded unicode-id v0.3.6 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.112 [INFO] [stderr] Downloaded wasm-bindgen v0.2.112 [INFO] [stderr] Downloaded js-sys v0.3.89 [INFO] [stderr] Downloaded serde_yml v0.0.12 [INFO] [stderr] Downloaded redox_syscall v0.7.2 [INFO] [stderr] Downloaded maud v0.26.0 [INFO] [stderr] Downloaded unicode-truncate v1.1.0 [INFO] [stderr] Downloaded instability v0.3.11 [INFO] [stderr] Downloaded crossterm v0.28.1 [INFO] [stderr] Downloaded libc v0.2.182 [INFO] [stderr] Downloaded ratatui v0.28.1 [INFO] [stderr] Downloaded markdown v1.0.0 [INFO] [stderr] Downloaded compact_str v0.8.1 [INFO] [stderr] Downloaded woothee v0.13.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9f2344ce2a5f5595e91f46eaad7852ed1753fa5183737f72653b0fab85d96b1 [INFO] running `Command { std: "docker" "start" "-a" "d9f2344ce2a5f5595e91f46eaad7852ed1753fa5183737f72653b0fab85d96b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9f2344ce2a5f5595e91f46eaad7852ed1753fa5183737f72653b0fab85d96b1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9f2344ce2a5f5595e91f46eaad7852ed1753fa5183737f72653b0fab85d96b1", kill_on_drop: false }` [INFO] [stdout] d9f2344ce2a5f5595e91f46eaad7852ed1753fa5183737f72653b0fab85d96b1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b234cdc6e6b7cb3fcc77fff7772d8296c4eaeac6af659b059546e059d23f9cf [INFO] running `Command { std: "docker" "start" "-a" "3b234cdc6e6b7cb3fcc77fff7772d8296c4eaeac6af659b059546e059d23f9cf", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling pin-project-lite v0.2.16 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking allocator-api2 v0.2.21 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling once_cell v1.21.3 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling hashbrown v0.15.5 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling parking v2.2.1 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Compiling crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Compiling hashbrown v0.16.1 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling tokio v1.49.0 [INFO] [stderr] Compiling indexmap v2.13.0 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Compiling hashlink v0.10.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling anyhow v1.0.102 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling multer v3.1.0 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking rand_core v0.9.5 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Compiling serde_yml v0.0.12 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Compiling woothee v0.13.0 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking libyml v0.0.5 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-id v0.3.6 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking matchit v0.8.4 [INFO] [stderr] Checking markdown v1.0.0 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling maud_macros v0.26.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking maud v0.26.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Checking axum-core v0.5.6 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling serde_urlencoded v0.7.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking sqlx-core v0.8.6 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking hyper-util v0.1.20 [INFO] [stderr] Checking ratatui v0.28.1 [INFO] [stderr] Checking axum v0.8.8 [INFO] [stderr] Checking sqlx-sqlite v0.8.6 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking md-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/db.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 367 | pub struct TokenRecord { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 368 | pub id: i64, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenRecord` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/analytics.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if referer.as_deref().map_or(false, |r| { [INFO] [stdout] | ________^ [INFO] [stdout] 42 | | r.starts_with(state.base_url.as_deref().unwrap_or("")) [INFO] [stdout] 43 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 41 - if referer.as_deref().map_or(false, |r| { [INFO] [stdout] 41 + if referer.as_deref().is_some_and(|r| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/analytics.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | let ip = if conn_ip.map_or(false, is_trusted_proxy) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 62 - let ip = if conn_ip.map_or(false, is_trusted_proxy) { [INFO] [stdout] 62 + let ip = if conn_ip.is_some_and(is_trusted_proxy) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `id` is never read [INFO] [stdout] --> src/db.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 367 | pub struct TokenRecord { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 368 | pub id: i64, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenRecord` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/analytics.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | if referer.as_deref().map_or(false, |r| { [INFO] [stdout] | ________^ [INFO] [stdout] 42 | | r.starts_with(state.base_url.as_deref().unwrap_or("")) [INFO] [stdout] 43 | | }) { [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 41 - if referer.as_deref().map_or(false, |r| { [INFO] [stdout] 41 + if referer.as_deref().is_some_and(|r| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/analytics.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | let ip = if conn_ip.map_or(false, is_trusted_proxy) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 62 - let ip = if conn_ip.map_or(false, is_trusted_proxy) { [INFO] [stdout] 62 + let ip = if conn_ip.is_some_and(is_trusted_proxy) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/editor/handlers.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(parent) = fs_path.parent() { [INFO] [stdout] 119 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 120 | | return AppError::Io(e).into_response(); [INFO] [stdout] 121 | | } [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(parent) = fs_path.parent() [INFO] [stdout] 119 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 120 | return AppError::Io(e).into_response(); [INFO] [stdout] 121 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/editor/handlers.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | / if let Some(parent) = fs_path.parent() { [INFO] [stdout] 217 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 218 | | return AppError::Io(e).into_response(); [INFO] [stdout] 219 | | } [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 216 ~ if let Some(parent) = fs_path.parent() [INFO] [stdout] 217 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 218 | return AppError::Io(e).into_response(); [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/editor/handlers.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / if let Some(parent) = fs_path.parent() { [INFO] [stdout] 119 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 120 | | return AppError::Io(e).into_response(); [INFO] [stdout] 121 | | } [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 118 ~ if let Some(parent) = fs_path.parent() [INFO] [stdout] 119 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 120 | return AppError::Io(e).into_response(); [INFO] [stdout] 121 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/editor/handlers.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / if let Some(parent) = dst.parent() { [INFO] [stdout] 317 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 318 | | return AppError::Io(e).into_response(); [INFO] [stdout] 319 | | } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 316 ~ if let Some(parent) = dst.parent() [INFO] [stdout] 317 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 318 | return AppError::Io(e).into_response(); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/editor/handlers.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | .map_err(|e| io_err_to_response(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `io_err_to_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/editor/handlers.rs:382:18 [INFO] [stdout] | [INFO] [stdout] 382 | .map_err(|e| io_err_to_response(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `io_err_to_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/editor/handlers.rs:216:5 [INFO] [stdout] | [INFO] [stdout] 216 | / if let Some(parent) = fs_path.parent() { [INFO] [stdout] 217 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 218 | | return AppError::Io(e).into_response(); [INFO] [stdout] 219 | | } [INFO] [stdout] 220 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 216 ~ if let Some(parent) = fs_path.parent() [INFO] [stdout] 217 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 218 | return AppError::Io(e).into_response(); [INFO] [stdout] 219 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/editor/handlers.rs:394:31 [INFO] [stdout] | [INFO] [stdout] 394 | fn sanitize_rel(rel: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/editor/handlers.rs:316:5 [INFO] [stdout] | [INFO] [stdout] 316 | / if let Some(parent) = dst.parent() { [INFO] [stdout] 317 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 318 | | return AppError::Io(e).into_response(); [INFO] [stdout] 319 | | } [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 316 ~ if let Some(parent) = dst.parent() [INFO] [stdout] 317 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 318 | return AppError::Io(e).into_response(); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/editor/handlers.rs:345:18 [INFO] [stdout] | [INFO] [stdout] 345 | .map_err(|e| io_err_to_response(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `io_err_to_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/editor/handlers.rs:382:18 [INFO] [stdout] | [INFO] [stdout] 382 | .map_err(|e| io_err_to_response(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `io_err_to_response` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/editor/handlers.rs:394:31 [INFO] [stdout] | [INFO] [stdout] 394 | fn sanitize_rel(rel: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] = note: `#[warn(clippy::result_large_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handler.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / if let Some(ref mp) = micropub_url { [INFO] [stdout] 144 | | if let Ok(val) = header::HeaderValue::from_str(&format!("<{}>; rel=\"micropub\"", mp)) { [INFO] [stdout] 145 | | response.headers_mut().insert("Link", val); [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 143 ~ if let Some(ref mp) = micropub_url [INFO] [stdout] 144 ~ && let Ok(val) = header::HeaderValue::from_str(&format!("<{}>; rel=\"micropub\"", mp)) { [INFO] [stdout] 145 | response.headers_mut().insert("Link", val); [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/handler.rs:143:5 [INFO] [stdout] | [INFO] [stdout] 143 | / if let Some(ref mp) = micropub_url { [INFO] [stdout] 144 | | if let Ok(val) = header::HeaderValue::from_str(&format!("<{}>; rel=\"micropub\"", mp)) { [INFO] [stdout] 145 | | response.headers_mut().insert("Link", val); [INFO] [stdout] 146 | | } [INFO] [stdout] 147 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 143 ~ if let Some(ref mp) = micropub_url [INFO] [stdout] 144 ~ && let Ok(val) = header::HeaderValue::from_str(&format!("<{}>; rel=\"micropub\"", mp)) { [INFO] [stdout] 145 | response.headers_mut().insert("Link", val); [INFO] [stdout] 146 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/log_capture.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | let formatted = format!("{message}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | &format!("Token lacks {} scope", required), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Token lacks {} scope", required)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | &format!("Unsupported query type: {}", q), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Unsupported query type: {}", q)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/log_capture.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | let formatted = format!("{message}"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | &format!("Token lacks {} scope", required), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Token lacks {} scope", required)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/micropub/handlers.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | / if let Some(parent) = fs_path.parent() { [INFO] [stdout] 264 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 265 | | return ( [INFO] [stdout] 266 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] ... | [INFO] [stdout] 271 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 263 ~ if let Some(parent) = fs_path.parent() [INFO] [stdout] 264 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 265 | return ( [INFO] [stdout] ... [INFO] [stdout] 269 | .into_response(); [INFO] [stdout] 270 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:267:57 [INFO] [stdout] | [INFO] [stdout] 267 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:296:53 [INFO] [stdout] | [INFO] [stdout] 296 | Json(MicropubError::new("server_error", &format!("Failed to serialize front matter: {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to serialize front matter: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | &format!("Unsupported query type: {}", q), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Unsupported query type: {}", q)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:313:21 [INFO] [stdout] | [INFO] [stdout] 313 | &format!("A post already exists at: {}", rel_path), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("A post already exists at: {}", rel_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:321:57 [INFO] [stdout] | [INFO] [stdout] 321 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:330:61 [INFO] [stdout] | [INFO] [stdout] 330 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:386:53 [INFO] [stdout] | [INFO] [stdout] 386 | Json(MicropubError::new("server_error", &format!("Failed to serialize front matter: {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to serialize front matter: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:392:53 [INFO] [stdout] | [INFO] [stdout] 392 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/micropub/handlers.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | / if let Some(parent) = fs_path.parent() { [INFO] [stdout] 264 | | if let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 265 | | return ( [INFO] [stdout] 266 | | StatusCode::INTERNAL_SERVER_ERROR, [INFO] [stdout] ... | [INFO] [stdout] 271 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 263 ~ if let Some(parent) = fs_path.parent() [INFO] [stdout] 264 ~ && let Err(e) = tokio::fs::create_dir_all(parent).await { [INFO] [stdout] 265 | return ( [INFO] [stdout] ... [INFO] [stdout] 269 | .into_response(); [INFO] [stdout] 270 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:267:57 [INFO] [stdout] | [INFO] [stdout] 267 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:296:53 [INFO] [stdout] | [INFO] [stdout] 296 | Json(MicropubError::new("server_error", &format!("Failed to serialize front matter: {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to serialize front matter: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:313:21 [INFO] [stdout] | [INFO] [stdout] 313 | &format!("A post already exists at: {}", rel_path), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("A post already exists at: {}", rel_path)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:321:57 [INFO] [stdout] | [INFO] [stdout] 321 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:330:61 [INFO] [stdout] | [INFO] [stdout] 330 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:497:53 [INFO] [stdout] | [INFO] [stdout] 497 | Json(MicropubError::new("server_error", &format!("Failed to serialize front matter: {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to serialize front matter: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:503:53 [INFO] [stdout] | [INFO] [stdout] 503 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:386:53 [INFO] [stdout] | [INFO] [stdout] 386 | Json(MicropubError::new("server_error", &format!("Failed to serialize front matter: {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to serialize front matter: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:515:36 [INFO] [stdout] | [INFO] [stdout] 515 | fn parse_form_body(body: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:392:53 [INFO] [stdout] | [INFO] [stdout] 392 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:592:17 [INFO] [stdout] | [INFO] [stdout] 592 | &format!("Unknown action: {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Unknown action: {}", a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:599:36 [INFO] [stdout] | [INFO] [stdout] 599 | fn parse_json_body(body: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:643:17 [INFO] [stdout] | [INFO] [stdout] 643 | &format!("Unknown action: {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Unknown action: {}", a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:650:47 [INFO] [stdout] | [INFO] [stdout] 650 | fn parse_json_create(v: serde_json::Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:713:47 [INFO] [stdout] | [INFO] [stdout] 713 | fn parse_json_update(v: serde_json::Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:497:53 [INFO] [stdout] | [INFO] [stdout] 497 | Json(MicropubError::new("server_error", &format!("Failed to serialize front matter: {}", e))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Failed to serialize front matter: {}", e)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:503:53 [INFO] [stdout] | [INFO] [stdout] 503 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:515:36 [INFO] [stdout] | [INFO] [stdout] 515 | fn parse_form_body(body: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:592:17 [INFO] [stdout] | [INFO] [stdout] 592 | &format!("Unknown action: {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Unknown action: {}", a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/media.rs:74:57 [INFO] [stdout] | [INFO] [stdout] 74 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:599:36 [INFO] [stdout] | [INFO] [stdout] 599 | fn parse_json_body(body: &[u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/media.rs:98:57 [INFO] [stdout] | [INFO] [stdout] 98 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/handlers.rs:643:17 [INFO] [stdout] | [INFO] [stdout] 643 | &format!("Unknown action: {}", a), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("Unknown action: {}", a)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:650:47 [INFO] [stdout] | [INFO] [stdout] 650 | fn parse_json_create(v: serde_json::Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the `Err`-variant returned from this function is very large [INFO] [stdout] --> src/micropub/handlers.rs:713:47 [INFO] [stdout] | [INFO] [stdout] 713 | fn parse_json_update(v: serde_json::Value) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes [INFO] [stdout] | [INFO] [stdout] = help: try reducing the size of `axum::http::Response`, for example by boxing large elements or replacing it with `Box>` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/micropub/media.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | .rsplit(|c| c == '/' || c == '\\') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['/', '\\']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/media.rs:74:57 [INFO] [stdout] | [INFO] [stdout] 74 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/micropub/media.rs:98:57 [INFO] [stdout] | [INFO] [stdout] 98 | Json(MicropubError::new("server_error", &e.to_string())), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `e.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this manual char comparison can be written more succinctly [INFO] [stdout] --> src/micropub/media.rs:128:17 [INFO] [stdout] | [INFO] [stdout] 128 | .rsplit(|c| c == '/' || c == '\\') [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['/', '\\']` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison [INFO] [stdout] = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some((_, _, t)) = self.message { [INFO] [stdout] 105 | | if t.elapsed() > Duration::from_secs(MSG_SECS) { [INFO] [stdout] 106 | | self.message = None; [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Some((_, _, t)) = self.message [INFO] [stdout] 105 ~ && t.elapsed() > Duration::from_secs(MSG_SECS) { [INFO] [stdout] 106 | self.message = None; [INFO] [stdout] 107 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:104:9 [INFO] [stdout] | [INFO] [stdout] 104 | / if let Some((_, _, t)) = self.message { [INFO] [stdout] 105 | | if t.elapsed() > Duration::from_secs(MSG_SECS) { [INFO] [stdout] 106 | | self.message = None; [INFO] [stdout] 107 | | } [INFO] [stdout] 108 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 104 ~ if let Some((_, _, t)) = self.message [INFO] [stdout] 105 ~ && t.elapsed() > Duration::from_secs(MSG_SECS) { [INFO] [stdout] 106 | self.message = None; [INFO] [stdout] 107 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 26s [INFO] running `Command { std: "docker" "inspect" "3b234cdc6e6b7cb3fcc77fff7772d8296c4eaeac6af659b059546e059d23f9cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b234cdc6e6b7cb3fcc77fff7772d8296c4eaeac6af659b059546e059d23f9cf", kill_on_drop: false }` [INFO] [stdout] 3b234cdc6e6b7cb3fcc77fff7772d8296c4eaeac6af659b059546e059d23f9cf