[INFO] cloning repository https://github.com/derwiath/adventofcode-2019 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/derwiath/adventofcode-2019" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fderwiath%2Fadventofcode-2019", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fderwiath%2Fadventofcode-2019'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 588bc94cf9ad7faceded9d7be67a8fe505a266f5 [INFO] linting derwiath/adventofcode-2019 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fderwiath%2Fadventofcode-2019" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/derwiath/adventofcode-2019 [INFO] finished tweaking git repo https://github.com/derwiath/adventofcode-2019 [INFO] tweaked toml for git repo https://github.com/derwiath/adventofcode-2019 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/derwiath/adventofcode-2019 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/derwiath/adventofcode-2019 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a5ee67f8cf9062ea6955704ccf66ebb83080610c64e053358497b6131e9f896 [INFO] running `Command { std: "docker" "start" "-a" "7a5ee67f8cf9062ea6955704ccf66ebb83080610c64e053358497b6131e9f896", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a5ee67f8cf9062ea6955704ccf66ebb83080610c64e053358497b6131e9f896", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a5ee67f8cf9062ea6955704ccf66ebb83080610c64e053358497b6131e9f896", kill_on_drop: false }` [INFO] [stdout] 7a5ee67f8cf9062ea6955704ccf66ebb83080610c64e053358497b6131e9f896 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70e7fd941a104242115f8e3e43f5e5c3f2a0f9f6522108d019b0df47e57e2303 [INFO] running `Command { std: "docker" "start" "-a" "70e7fd941a104242115f8e3e43f5e5c3f2a0f9f6522108d019b0df47e57e2303", kill_on_drop: false }` [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking int-code-machine v0.1.0 (/opt/rustwide/workdir/int-code-machine) [INFO] [stderr] Checking day1 v0.1.0 (/opt/rustwide/workdir/day1) [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking day2 v0.1.0 (/opt/rustwide/workdir/day2) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> day2/src/main.rs:10:46 [INFO] [stdout] | [INFO] [stdout] 10 | let value = run_int_code_program(&initial_state, noun, verb); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `initial_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> day2/src/main.rs:10:46 [INFO] [stdout] | [INFO] [stdout] 10 | let value = run_int_code_program(&initial_state, noun, verb); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `initial_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking day3 v0.1.0 (/opt/rustwide/workdir/day3) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day3/src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> day3/src/main.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | if range1.to < range2.from { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 28 | | None [INFO] [stdout] 29 | | } else if range1.from > range2.to { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> day3/src/main.rs:29:39 [INFO] [stdout] | [INFO] [stdout] 29 | } else if range1.from > range2.to { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 30 | | None [INFO] [stdout] 31 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> day3/src/main.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | if !(horz_line.y < vert_line.y.from || horz_line.y > vert_line.y.to) [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | && !(vert_line.x < horz_line.x.from || vert_line.x > horz_line.x.to) [INFO] [stdout] | |____________________________________________________________________________^ help: try: `!(horz_line.y < vert_line.y.from || horz_line.y > vert_line.y.to || vert_line.x < horz_line.x.from || vert_line.x > horz_line.x.to)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day3/src/main.rs:221:54 [INFO] [stdout] | [INFO] [stdout] 221 | let moves: Vec> = contents.lines().map(|line| parse_moves(line)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_moves` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> day3/src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use regex; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> day3/src/main.rs:27:32 [INFO] [stdout] | [INFO] [stdout] 27 | if range1.to < range2.from { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 28 | | None [INFO] [stdout] 29 | | } else if range1.from > range2.to { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> day3/src/main.rs:29:39 [INFO] [stdout] | [INFO] [stdout] 29 | } else if range1.from > range2.to { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 30 | | None [INFO] [stdout] 31 | | } else { [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.98s [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> day3/src/main.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | if !(horz_line.y < vert_line.y.from || horz_line.y > vert_line.y.to) [INFO] [stdout] | ________^ [INFO] [stdout] 80 | | && !(vert_line.x < horz_line.x.from || vert_line.x > horz_line.x.to) [INFO] [stdout] | |____________________________________________________________________________^ help: try: `!(horz_line.y < vert_line.y.from || horz_line.y > vert_line.y.to || vert_line.x < horz_line.x.from || vert_line.x > horz_line.x.to)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> day3/src/main.rs:221:54 [INFO] [stdout] | [INFO] [stdout] 221 | let moves: Vec> = contents.lines().map(|line| parse_moves(line)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `parse_moves` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "70e7fd941a104242115f8e3e43f5e5c3f2a0f9f6522108d019b0df47e57e2303", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70e7fd941a104242115f8e3e43f5e5c3f2a0f9f6522108d019b0df47e57e2303", kill_on_drop: false }` [INFO] [stdout] 70e7fd941a104242115f8e3e43f5e5c3f2a0f9f6522108d019b0df47e57e2303