[INFO] cloning repository https://github.com/dchristle/sfsig [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dchristle/sfsig" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdchristle%2Fsfsig", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdchristle%2Fsfsig'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4078f33c4bb627846924e39795e4e5486d860a6 [INFO] linting dchristle/sfsig against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdchristle%2Fsfsig" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/dchristle/sfsig [INFO] finished tweaking git repo https://github.com/dchristle/sfsig [INFO] tweaked toml for git repo https://github.com/dchristle/sfsig written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/dchristle/sfsig on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/dchristle/sfsig already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded digest v0.11.0-pre.9 [INFO] [stderr] Downloaded block-buffer v0.11.0-rc.1 [INFO] [stderr] Downloaded const-oid v0.10.0-rc.0 [INFO] [stderr] Downloaded blst v0.3.13 [INFO] [stderr] Downloaded crypto-common v0.2.0-rc.1 [INFO] [stderr] Downloaded hybrid-array v0.2.0-rc.9 [INFO] [stderr] Downloaded algebra v0.2.0 [INFO] [stderr] Downloaded cc v1.1.17 [INFO] [stderr] Downloaded sha2 v0.11.0-pre.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] be3c9af33e022c1467a36c6227c3089868ced629bf7e8d7445a023436d17df22 [INFO] running `Command { std: "docker" "start" "-a" "be3c9af33e022c1467a36c6227c3089868ced629bf7e8d7445a023436d17df22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "be3c9af33e022c1467a36c6227c3089868ced629bf7e8d7445a023436d17df22", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be3c9af33e022c1467a36c6227c3089868ced629bf7e8d7445a023436d17df22", kill_on_drop: false }` [INFO] [stdout] be3c9af33e022c1467a36c6227c3089868ced629bf7e8d7445a023436d17df22 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 95ab2849cf945a79119f6222e094f0b0eb1cfccc6c03460aaddec0b2d8a6c1c7 [INFO] running `Command { std: "docker" "start" "-a" "95ab2849cf945a79119f6222e094f0b0eb1cfccc6c03460aaddec0b2d8a6c1c7", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling cc v1.1.17 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking const-oid v0.10.0-rc.0 [INFO] [stderr] Checking constant_time_eq v0.3.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking cpufeatures v0.2.14 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking clap_builder v4.5.17 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking algebra v0.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling blake3 v1.5.4 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking hybrid-array v0.2.0-rc.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking crypto-common v0.2.0-rc.1 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking block-buffer v0.11.0-rc.1 [INFO] [stderr] Checking digest v0.11.0-pre.9 [INFO] [stderr] Checking sha2 v0.11.0-pre.4 [INFO] [stderr] Compiling ark-serialize-derive v0.4.2 [INFO] [stderr] Compiling ark-ff-asm v0.4.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling ark-ff-macros v0.4.2 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking clap v4.5.17 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ark-std v0.4.0 [INFO] [stderr] Checking ark-serialize v0.4.2 [INFO] [stderr] Checking ark-ff v0.4.2 [INFO] [stderr] Checking ark-poly v0.4.2 [INFO] [stderr] Checking ark-ec v0.4.2 [INFO] [stderr] Checking ark-bn254 v0.4.0 [INFO] [stderr] Checking ark-bls12-381 v0.4.0 [INFO] [stderr] Checking sfsig v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/superfox_csprng.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | cache: cache [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/superfox_csprng.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | cache: cache [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `cache` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> src/superfox_csprng.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | let mut current_time = validated_csprng_epoch.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*validated_csprng_epoch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/superfox_csprng.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | if time.second() % 15 == 0 && time.nanosecond() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `time.second().is_multiple_of(15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> src/superfox_csprng.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | return time.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/superfox_csprng.rs:126:60 [INFO] [stdout] | [INFO] [stdout] 126 | let valid_time = Self::validate_15_second_interval(¤t_time)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `current_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/superfox_csprng.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | current_time = current_time - Duration::seconds(15); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_time -= Duration::seconds(15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> src/superfox_csprng.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | let mut current_time = validated_csprng_epoch.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*validated_csprng_epoch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/superfox_csprng.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 102 | if time.second() % 15 == 0 && time.nanosecond() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `time.second().is_multiple_of(15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> src/superfox_csprng.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | return time.clone(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/superfox_csprng.rs:126:60 [INFO] [stdout] | [INFO] [stdout] 126 | let valid_time = Self::validate_15_second_interval(¤t_time)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `current_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/superfox_csprng.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | current_time = current_time - Duration::seconds(15); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_time -= Duration::seconds(15)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Fq12` [INFO] [stdout] --> src/main.rs:6:63 [INFO] [stdout] | [INFO] [stdout] 6 | use ark_bn254::{Bn254, G1Affine, G2Affine, Fr as ScalarField, Fq12}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ark_ec::bn::Bn` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use ark_ec::bn::Bn; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Fq12` [INFO] [stdout] --> src/main.rs:6:63 [INFO] [stdout] | [INFO] [stdout] 6 | use ark_bn254::{Bn254, G1Affine, G2Affine, Fr as ScalarField, Fq12}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | use ark_serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | use blake3; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ark_ec::bn::Bn` [INFO] [stdout] --> src/main.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use ark_ec::bn::Bn; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | use ark_serialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | use blake3; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/main.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | use ark_ff::{BigInteger, Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/main.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | use ark_ff::{BigInteger, Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bls12_p` is never used [INFO] [stdout] --> src/main.rs:694:4 [INFO] [stdout] | [INFO] [stdout] 694 | fn bls12_p(z: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bls12_r` is never used [INFO] [stdout] --> src/main.rs:700:4 [INFO] [stdout] | [INFO] [stdout] 700 | fn bls12_r(z: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `miller_rabin_test` is never used [INFO] [stdout] --> src/main.rs:705:4 [INFO] [stdout] | [INFO] [stdout] 705 | fn miller_rabin_test(n: &BigUint, a: &BigUint) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_probably_prime` is never used [INFO] [stdout] --> src/main.rs:744:4 [INFO] [stdout] | [INFO] [stdout] 744 | fn is_probably_prime(n: &BigUint, iterations: u32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_quadratic_non_residue` is never used [INFO] [stdout] --> src/main.rs:763:4 [INFO] [stdout] | [INFO] [stdout] 763 | fn find_quadratic_non_residue(p: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_cubic_non_residue` is never used [INFO] [stdout] --> src/main.rs:777:4 [INFO] [stdout] | [INFO] [stdout] 777 | fn find_cubic_non_residue(p: &BigUint, non_residue: &BigUint) -> (BigUint, BigUint) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bls12_p` is never used [INFO] [stdout] --> src/main.rs:694:4 [INFO] [stdout] | [INFO] [stdout] 694 | fn bls12_p(z: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bls12_r` is never used [INFO] [stdout] --> src/main.rs:700:4 [INFO] [stdout] | [INFO] [stdout] 700 | fn bls12_r(z: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `miller_rabin_test` is never used [INFO] [stdout] --> src/main.rs:705:4 [INFO] [stdout] | [INFO] [stdout] 705 | fn miller_rabin_test(n: &BigUint, a: &BigUint) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_probably_prime` is never used [INFO] [stdout] --> src/main.rs:744:4 [INFO] [stdout] | [INFO] [stdout] 744 | fn is_probably_prime(n: &BigUint, iterations: u32) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_quadratic_non_residue` is never used [INFO] [stdout] --> src/main.rs:763:4 [INFO] [stdout] | [INFO] [stdout] 763 | fn find_quadratic_non_residue(p: &BigUint) -> BigUint { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `find_cubic_non_residue` is never used [INFO] [stdout] --> src/main.rs:777:4 [INFO] [stdout] | [INFO] [stdout] 777 | fn find_cubic_non_residue(p: &BigUint, non_residue: &BigUint) -> (BigUint, BigUint) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:241:111 [INFO] [stdout] | [INFO] [stdout] 241 | ...rent_time.second() == 30) && !((num_periods_to_simulate - i) <= num_final_cq_messages) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((num_periods_to_simulate - i) > num_final_cq_messages)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:241:111 [INFO] [stdout] | [INFO] [stdout] 241 | ...rent_time.second() == 30) && !((num_periods_to_simulate - i) <= num_final_cq_messages) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((num_periods_to_simulate - i) > num_final_cq_messages)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Fp, 4>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:148:47 [INFO] [stdout] | [INFO] [stdout] 148 | println!("Private key: 0x{}", hex::encode(private_key.clone().into_bigint().to_bytes_le())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `private_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Fp, 4>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:149:43 [INFO] [stdout] | [INFO] [stdout] 149 | println!("Private key size: {} bits", private_key.clone().into_bigint().to_bytes_le().len() * 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `private_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Fp, 4>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:148:47 [INFO] [stdout] | [INFO] [stdout] 148 | println!("Private key: 0x{}", hex::encode(private_key.clone().into_bigint().to_bytes_le())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `private_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Fp, 4>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:149:43 [INFO] [stdout] | [INFO] [stdout] 149 | println!("Private key size: {} bits", private_key.clone().into_bigint().to_bytes_le().len() * 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `private_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | if (current_time.minute() % 5 == 0 && current_time.second() == 0) || (num_periods_to_simulate - i) <= num_final_cq_messages { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `current_time.minute().is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.16s [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | ... if (current_time.minute() % 5 != 0) && (current_time.second() == 0 || current_time.second() == 30) && !((num_periods_to_simul... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!current_time.minute().is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:202:13 [INFO] [stdout] | [INFO] [stdout] 202 | if (current_time.minute() % 5 == 0 && current_time.second() == 0) || (num_periods_to_simulate - i) <= num_final_cq_messages { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `current_time.minute().is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:279:52 [INFO] [stdout] | [INFO] [stdout] 279 | for (_, message) in messages_transmitted.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 279 - for (_, message) in messages_transmitted.iter().enumerate() { [INFO] [stdout] 279 + for message in messages_transmitted.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 241 | ... if (current_time.minute() % 5 != 0) && (current_time.second() == 0 || current_time.second() == 30) && !((num_periods_to_simul... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!current_time.minute().is_multiple_of(5)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to use `.enumerate()` and immediately discard the index [INFO] [stdout] --> src/main.rs:279:52 [INFO] [stdout] | [INFO] [stdout] 279 | for (_, message) in messages_transmitted.iter().enumerate() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_enumerate_index [INFO] [stdout] = note: `#[warn(clippy::unused_enumerate_index)]` on by default [INFO] [stdout] help: remove the `.enumerate()` call [INFO] [stdout] | [INFO] [stdout] 279 - for (_, message) in messages_transmitted.iter().enumerate() { [INFO] [stdout] 279 + for message in messages_transmitted.iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:406:52 [INFO] [stdout] | [INFO] [stdout] 406 | concatenated_message_bits.extend_from_bitslice(&csprng_state_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `csprng_state_bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:407:52 [INFO] [stdout] | [INFO] [stdout] 407 | concatenated_message_bits.extend_from_bitslice(×tamp_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `timestamp_bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:406:52 [INFO] [stdout] | [INFO] [stdout] 406 | concatenated_message_bits.extend_from_bitslice(&csprng_state_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `csprng_state_bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:407:52 [INFO] [stdout] | [INFO] [stdout] 407 | concatenated_message_bits.extend_from_bitslice(×tamp_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `timestamp_bits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:641:11 [INFO] [stdout] | [INFO] [stdout] 641 | while padded.len() % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!padded.len().is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:641:11 [INFO] [stdout] | [INFO] [stdout] 641 | while padded.len() % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!padded.len().is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/main.rs:720:11 [INFO] [stdout] | [INFO] [stdout] 720 | while (&d).is_even() { [INFO] [stdout] | ^^^^ help: change this to: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/main.rs:720:11 [INFO] [stdout] | [INFO] [stdout] 720 | while (&d).is_even() { [INFO] [stdout] | ^^^^ help: change this to: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "95ab2849cf945a79119f6222e094f0b0eb1cfccc6c03460aaddec0b2d8a6c1c7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95ab2849cf945a79119f6222e094f0b0eb1cfccc6c03460aaddec0b2d8a6c1c7", kill_on_drop: false }` [INFO] [stdout] 95ab2849cf945a79119f6222e094f0b0eb1cfccc6c03460aaddec0b2d8a6c1c7