[INFO] cloning repository https://github.com/davirieser/Maelstrom [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/davirieser/Maelstrom" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavirieser%2FMaelstrom", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavirieser%2FMaelstrom'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a256bdd87736bd754544736e9fba0a5a3510c0db [INFO] linting davirieser/Maelstrom against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdavirieser%2FMaelstrom" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/davirieser/Maelstrom [INFO] finished tweaking git repo https://github.com/davirieser/Maelstrom [INFO] tweaked toml for git repo https://github.com/davirieser/Maelstrom written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/davirieser/Maelstrom on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/davirieser/Maelstrom already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded debug_print v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 64c55506aacc10e72ecf0835e70c7a788fa6110f918ce51d620ac32181cff31d [INFO] running `Command { std: "docker" "start" "-a" "64c55506aacc10e72ecf0835e70c7a788fa6110f918ce51d620ac32181cff31d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "64c55506aacc10e72ecf0835e70c7a788fa6110f918ce51d620ac32181cff31d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64c55506aacc10e72ecf0835e70c7a788fa6110f918ce51d620ac32181cff31d", kill_on_drop: false }` [INFO] [stdout] 64c55506aacc10e72ecf0835e70c7a788fa6110f918ce51d620ac32181cff31d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b065fb1718d83fc0036f1dc93aedd008a047352899b68da40dbd7de6468eecd7 [INFO] running `Command { std: "docker" "start" "-a" "b065fb1718d83fc0036f1dc93aedd008a047352899b68da40dbd7de6468eecd7", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking debug_print v1.0.0 [INFO] [stderr] Compiling syn v2.0.31 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Checking serde_json v1.0.105 [INFO] [stderr] Checking Maelstrom v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/packet_handler.rs:511:30 [INFO] [stdout] | [INFO] [stdout] 511 | let _ = stdout.write(&[b'\n']); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/packet_handler.rs:511:30 [INFO] [stdout] | [INFO] [stdout] 511 | let _ = stdout.write(&[b'\n']); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:126:47 [INFO] [stdout] | [INFO] [stdout] 126 | fn test_build_broadcast_topology_internal(mut topology: Topology) -> bool { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:137:13 [INFO] [stdout] | [INFO] [stdout] 137 | let mut nodes: HashSet = topology.keys().cloned().collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | let mut nodes: Vec = base_topology.keys().cloned().collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | let mut broadcast_topology = build_broadcast_topology(node, &nodes, &base_topology); [INFO] [stdout] | ----^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:178:13 [INFO] [stdout] | [INFO] [stdout] 178 | let mut nodes: Vec = topologies.keys().cloned().collect(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | let mut vec = complete_topology.get_mut(node).unwrap(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `vec` [INFO] [stdout] --> src/lib.rs:192:17 [INFO] [stdout] | [INFO] [stdout] 192 | let mut vec = complete_topology.get_mut(node).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_vec` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `cmp_node_ids` is never used [INFO] [stdout] --> src/lib.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | fn cmp_node_ids(id1: &str, id2: &str) -> Ordering { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/packet_handler.rs:530:27 [INFO] [stdout] | [INFO] [stdout] 530 | .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 530 - .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] 530 + .position(|m| m.msg_id == Some(msg_id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/packet_handler.rs:530:27 [INFO] [stdout] | [INFO] [stdout] 530 | .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 530 - .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] 530 + .position(|m| m.msg_id == Some(msg_id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/lib.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:145:16 [INFO] [stdout] | [INFO] [stdout] 145 | if !pos.is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `pos.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `pos` after checking its variant with `is_some` [INFO] [stdout] --> src/lib.rs:149:29 [INFO] [stdout] | [INFO] [stdout] 145 | if !pos.is_some() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 149 | diff.remove(pos.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/packet_handler.rs:511:30 [INFO] [stdout] | [INFO] [stdout] 511 | let _ = stdout.write(&[b'\n']); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> src/packet_handler.rs:511:30 [INFO] [stdout] | [INFO] [stdout] 511 | let _ = stdout.write(&[b'\n']); [INFO] [stdout] | ^^^^^^^^ help: try: `b"\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/packet_handler.rs:530:27 [INFO] [stdout] | [INFO] [stdout] 530 | .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 530 - .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] 530 + .position(|m| m.msg_id == Some(msg_id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/packet_handler.rs:530:27 [INFO] [stdout] | [INFO] [stdout] 530 | .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use a standard comparison instead [INFO] [stdout] | [INFO] [stdout] 530 - .position(|m| m.msg_id.map_or(false, |id| id == msg_id)) [INFO] [stdout] 530 + .position(|m| m.msg_id == Some(msg_id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.30s [INFO] running `Command { std: "docker" "inspect" "b065fb1718d83fc0036f1dc93aedd008a047352899b68da40dbd7de6468eecd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b065fb1718d83fc0036f1dc93aedd008a047352899b68da40dbd7de6468eecd7", kill_on_drop: false }` [INFO] [stdout] b065fb1718d83fc0036f1dc93aedd008a047352899b68da40dbd7de6468eecd7