[INFO] cloning repository https://github.com/davidWnguyen/physics-simulation [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/davidWnguyen/physics-simulation" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdavidWnguyen%2Fphysics-simulation", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdavidWnguyen%2Fphysics-simulation'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0655e2be6458a8598c02c343de62b000f586b565 [INFO] linting davidWnguyen/physics-simulation against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FdavidWnguyen%2Fphysics-simulation" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/davidWnguyen/physics-simulation [INFO] finished tweaking git repo https://github.com/davidWnguyen/physics-simulation [INFO] tweaked toml for git repo https://github.com/davidWnguyen/physics-simulation written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/davidWnguyen/physics-simulation on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/davidWnguyen/physics-simulation already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 588346bb754fa564f1e84ef611b0908399a675099ce5c5e6301908bda938c1ef [INFO] running `Command { std: "docker" "start" "-a" "588346bb754fa564f1e84ef611b0908399a675099ce5c5e6301908bda938c1ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "588346bb754fa564f1e84ef611b0908399a675099ce5c5e6301908bda938c1ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "588346bb754fa564f1e84ef611b0908399a675099ce5c5e6301908bda938c1ef", kill_on_drop: false }` [INFO] [stdout] 588346bb754fa564f1e84ef611b0908399a675099ce5c5e6301908bda938c1ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0245e271f2a7501867aba92da17436b9c0e83100cc3201b718304be99a47c2ff [INFO] running `Command { std: "docker" "start" "-a" "0245e271f2a7501867aba92da17436b9c0e83100cc3201b718304be99a47c2ff", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking physics_simulation v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | const APPLICATIONS: &'static [&'static str] = &["1. Vector Addition", "2. Planar Movement", "3. Kinematic Equations", "4. Work, Energ... [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | const APPLICATIONS: &'static [&'static str] = &["1. Vector Addition", "2. Planar Movement", "3. Kinematic Equations", "4. Work, Energ... [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector_addition.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return MathVector{ [INFO] [stdout] 15 | | scalar: result_hypotenuse, [INFO] [stdout] 16 | | angle: result_angle, [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ MathVector{ [INFO] [stdout] 15 + scalar: result_hypotenuse, [INFO] [stdout] 16 + angle: result_angle, [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 35 | vec1.scalar = get_user_number(format!("What's the magnitude of vector #1?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the magnitude of vector #1?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:36:34 [INFO] [stdout] | [INFO] [stdout] 36 | vec1.angle = get_user_number(format!("What's the angle of vector #1?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the angle of vector #1?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | vec2.scalar = get_user_number(format!("What's the magnitude of vector #2?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the magnitude of vector #2?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | vec2.angle = get_user_number(format!("What's the angle of vector #2?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the angle of vector #2?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:5:48 [INFO] [stdout] | [INFO] [stdout] 5 | let mut acceleration:f64 = get_user_number(format!("What's the acceleration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the acceleration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:6:44 [INFO] [stdout] | [INFO] [stdout] 6 | let mut velocity:f64 = get_user_number(format!("What's the initial velocity?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the initial velocity?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | let mut time:f64 = get_user_number(format!("How long is the duration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How long is the duration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:8:48 [INFO] [stdout] | [INFO] [stdout] 8 | let mut displacement:f64 = get_user_number(format!("How far did it travel?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How far did it travel?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:24:48 [INFO] [stdout] | [INFO] [stdout] 24 | let table_amount:i32 = get_user_number(format!("How many rows of data do you want?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How many rows of data do you want?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/planar_movement.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 && velocity != -1.0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 && velocity != -1.0 [INFO] [stdout] 106 + else if !(displacement != -1.0 || velocity == -1.0 || acceleration == -1.0) [INFO] [stdout] | [INFO] [stdout] 106 - else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 && velocity != -1.0 [INFO] [stdout] 106 + else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/planar_movement.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 && velocity != -1.0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 && velocity != -1.0 [INFO] [stdout] 110 + else if !(acceleration != -1.0 || velocity == -1.0 || displacement == -1.0) [INFO] [stdout] | [INFO] [stdout] 110 - else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 && velocity != -1.0 [INFO] [stdout] 110 + else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:38:48 [INFO] [stdout] | [INFO] [stdout] 38 | let mut acceleration:f64 = get_user_number(format!("What's the acceleration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the acceleration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:39:44 [INFO] [stdout] | [INFO] [stdout] 39 | let mut velocity:f64 = get_user_number(format!("What's the initial velocity?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the initial velocity?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:40:45 [INFO] [stdout] | [INFO] [stdout] 40 | let mut fvelocity:f64 = get_user_number(format!("What's the final velocity?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the final velocity?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | let mut time:f64 = get_user_number(format!("How long is the duration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How long is the duration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:42:48 [INFO] [stdout] | [INFO] [stdout] 42 | let mut displacement:f64 = get_user_number(format!("How far did it travel?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How far did it travel?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/stocks.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | / match std::io::stdin().read_line(&mut input){ [INFO] [stdout] 6 | | Err(error) => { [INFO] [stdout] 7 | | println!("Error: {}", error); [INFO] [stdout] 8 | | continue; [INFO] [stdout] 9 | | } [INFO] [stdout] 10 | | Ok(_) => {} [INFO] [stdout] 11 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 5 ~ if let Err(error) = std::io::stdin().read_line(&mut input) { [INFO] [stdout] 6 + println!("Error: {}", error); [INFO] [stdout] 7 + continue; [INFO] [stdout] 8 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:9:38 [INFO] [stdout] | [INFO] [stdout] 9 | let option:i32 = get_user_number(format!("Which one do you want to choose?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Which one do you want to choose?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:14:52 [INFO] [stdout] | [INFO] [stdout] 14 | let mut work:f64 = get_user_number(format!("How much work was done?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How much work was done?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:15:53 [INFO] [stdout] | [INFO] [stdout] 15 | let mut force:f64 = get_user_number(format!("How much force was applied? (mass x distance)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How much force was applied? (mass x distance)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:16:56 [INFO] [stdout] | [INFO] [stdout] 16 | let mut distance:f64 = get_user_number(format!("How much displacement on the object was applied?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How much displacement on the object was applied?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:17:53 [INFO] [stdout] | [INFO] [stdout] 17 | ... get_user_number(format!("At what angle was the force applied? (in degrees to normal, 0 for direct.)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"At what angle was the force applied? (in degrees to normal, 0 for direct.)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | const APPLICATIONS: &'static [&'static str] = &["1. Vector Addition", "2. Planar Movement", "3. Kinematic Equations", "4. Work, Energ... [INFO] [stdout] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | const APPLICATIONS: &'static [&'static str] = &["1. Vector Addition", "2. Planar Movement", "3. Kinematic Equations", "4. Work, Energ... [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vector_addition.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return MathVector{ [INFO] [stdout] 15 | | scalar: result_hypotenuse, [INFO] [stdout] 16 | | angle: result_angle, [INFO] [stdout] 17 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ MathVector{ [INFO] [stdout] 15 + scalar: result_hypotenuse, [INFO] [stdout] 16 + angle: result_angle, [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 35 | vec1.scalar = get_user_number(format!("What's the magnitude of vector #1?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the magnitude of vector #1?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:36:34 [INFO] [stdout] | [INFO] [stdout] 36 | vec1.angle = get_user_number(format!("What's the angle of vector #1?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the angle of vector #1?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | vec2.scalar = get_user_number(format!("What's the magnitude of vector #2?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the magnitude of vector #2?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/vector_addition.rs:38:34 [INFO] [stdout] | [INFO] [stdout] 38 | vec2.angle = get_user_number(format!("What's the angle of vector #2?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the angle of vector #2?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:5:48 [INFO] [stdout] | [INFO] [stdout] 5 | let mut acceleration:f64 = get_user_number(format!("What's the acceleration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the acceleration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:6:44 [INFO] [stdout] | [INFO] [stdout] 6 | let mut velocity:f64 = get_user_number(format!("What's the initial velocity?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the initial velocity?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:7:40 [INFO] [stdout] | [INFO] [stdout] 7 | let mut time:f64 = get_user_number(format!("How long is the duration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How long is the duration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:8:48 [INFO] [stdout] | [INFO] [stdout] 8 | let mut displacement:f64 = get_user_number(format!("How far did it travel?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How far did it travel?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:24:48 [INFO] [stdout] | [INFO] [stdout] 24 | let table_amount:i32 = get_user_number(format!("How many rows of data do you want?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How many rows of data do you want?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/planar_movement.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 && velocity != -1.0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 106 - else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 && velocity != -1.0 [INFO] [stdout] 106 + else if !(displacement != -1.0 || velocity == -1.0 || acceleration == -1.0) [INFO] [stdout] | [INFO] [stdout] 106 - else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 && velocity != -1.0 [INFO] [stdout] 106 + else if displacement == -1.0 && velocity != -1.0 && acceleration != -1.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/planar_movement.rs:110:13 [INFO] [stdout] | [INFO] [stdout] 110 | else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 && velocity != -1.0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 110 - else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 && velocity != -1.0 [INFO] [stdout] 110 + else if !(acceleration != -1.0 || velocity == -1.0 || displacement == -1.0) [INFO] [stdout] | [INFO] [stdout] 110 - else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 && velocity != -1.0 [INFO] [stdout] 110 + else if acceleration == -1.0 && velocity != -1.0 && displacement != -1.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:38:48 [INFO] [stdout] | [INFO] [stdout] 38 | let mut acceleration:f64 = get_user_number(format!("What's the acceleration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the acceleration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:39:44 [INFO] [stdout] | [INFO] [stdout] 39 | let mut velocity:f64 = get_user_number(format!("What's the initial velocity?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the initial velocity?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:40:45 [INFO] [stdout] | [INFO] [stdout] 40 | let mut fvelocity:f64 = get_user_number(format!("What's the final velocity?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"What's the final velocity?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:41:40 [INFO] [stdout] | [INFO] [stdout] 41 | let mut time:f64 = get_user_number(format!("How long is the duration?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How long is the duration?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/planar_movement.rs:42:48 [INFO] [stdout] | [INFO] [stdout] 42 | let mut displacement:f64 = get_user_number(format!("How far did it travel?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How far did it travel?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/stocks.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | / match std::io::stdin().read_line(&mut input){ [INFO] [stdout] 6 | | Err(error) => { [INFO] [stdout] 7 | | println!("Error: {}", error); [INFO] [stdout] 8 | | continue; [INFO] [stdout] 9 | | } [INFO] [stdout] 10 | | Ok(_) => {} [INFO] [stdout] 11 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 5 ~ if let Err(error) = std::io::stdin().read_line(&mut input) { [INFO] [stdout] 6 + println!("Error: {}", error); [INFO] [stdout] 7 + continue; [INFO] [stdout] 8 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:9:38 [INFO] [stdout] | [INFO] [stdout] 9 | let option:i32 = get_user_number(format!("Which one do you want to choose?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Which one do you want to choose?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:14:52 [INFO] [stdout] | [INFO] [stdout] 14 | let mut work:f64 = get_user_number(format!("How much work was done?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How much work was done?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:15:53 [INFO] [stdout] | [INFO] [stdout] 15 | let mut force:f64 = get_user_number(format!("How much force was applied? (mass x distance)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How much force was applied? (mass x distance)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:16:56 [INFO] [stdout] | [INFO] [stdout] 16 | let mut distance:f64 = get_user_number(format!("How much displacement on the object was applied?")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"How much displacement on the object was applied?".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/energy.rs:17:53 [INFO] [stdout] | [INFO] [stdout] 17 | ... get_user_number(format!("At what angle was the force applied? (in degrees to normal, 0 for direct.)")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"At what angle was the force applied? (in degrees to normal, 0 for direct.)".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.84s [INFO] running `Command { std: "docker" "inspect" "0245e271f2a7501867aba92da17436b9c0e83100cc3201b718304be99a47c2ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0245e271f2a7501867aba92da17436b9c0e83100cc3201b718304be99a47c2ff", kill_on_drop: false }` [INFO] [stdout] 0245e271f2a7501867aba92da17436b9c0e83100cc3201b718304be99a47c2ff