[INFO] cloning repository https://github.com/dav-anderson/cargo-piston
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/dav-anderson/cargo-piston" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdav-anderson%2Fcargo-piston", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdav-anderson%2Fcargo-piston'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] b1138c83c09410d25ec07bf7e53c156b381381c5
[INFO] linting dav-anderson/cargo-piston against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdav-anderson%2Fcargo-piston" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/dav-anderson/cargo-piston
[INFO] finished tweaking git repo https://github.com/dav-anderson/cargo-piston
[INFO] tweaked toml for git repo https://github.com/dav-anderson/cargo-piston written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/dav-anderson/cargo-piston on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/dav-anderson/cargo-piston already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded current_platform v0.2.0
[INFO] [stderr]   Downloaded cargo-platform v0.3.1
[INFO] [stderr]   Downloaded cargo-subcommand v0.12.0
[INFO] [stderr]   Downloaded camino v1.2.1
[INFO] [stderr]   Downloaded jsonwebtoken v10.3.0
[INFO] [stderr]   Downloaded zune-jpeg v0.5.7
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] bcf310eba1283979018b6cad38b24f124b6ac74d4cb7d77e370225467b4d1750
[INFO] running `Command { std: "docker" "start" "-a" "bcf310eba1283979018b6cad38b24f124b6ac74d4cb7d77e370225467b4d1750", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "bcf310eba1283979018b6cad38b24f124b6ac74d4cb7d77e370225467b4d1750", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "bcf310eba1283979018b6cad38b24f124b6ac74d4cb7d77e370225467b4d1750", kill_on_drop: false }`
[INFO] [stdout] bcf310eba1283979018b6cad38b24f124b6ac74d4cb7d77e370225467b4d1750
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] a5c8fee274633cf4d616207a9795b0fe8146d73fc2998af5dfbe47b16ecbc239
[INFO] running `Command { std: "docker" "start" "-a" "a5c8fee274633cf4d616207a9795b0fe8146d73fc2998af5dfbe47b16ecbc239", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.178
[INFO] [stderr]    Compiling generic-array v0.14.9
[INFO] [stderr]     Checking memchr v2.7.6
[INFO] [stderr]     Checking base64ct v1.8.3
[INFO] [stderr]    Compiling serde_core v1.0.228
[INFO] [stderr]     Checking num-traits v0.2.19
[INFO] [stderr]    Compiling zerocopy v0.8.31
[INFO] [stderr]    Compiling zerocopy-derive v0.8.31
[INFO] [stderr]     Checking pem-rfc7468 v0.7.0
[INFO] [stderr]     Checking der v0.7.10
[INFO] [stderr]     Checking smallvec v1.15.1
[INFO] [stderr]     Checking simd-adler32 v0.3.8
[INFO] [stderr]    Compiling thiserror-impl v2.0.17
[INFO] [stderr]    Compiling equator-macro v0.4.2
[INFO] [stderr]     Checking crypto-common v0.1.6
[INFO] [stderr]     Checking block-buffer v0.10.4
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]     Checking digest v0.10.7
[INFO] [stderr]     Checking hmac v0.12.1
[INFO] [stderr]     Checking num-bigint v0.4.6
[INFO] [stderr]    Compiling cc v1.2.49
[INFO] [stderr]     Checking spki v0.7.3
[INFO] [stderr]     Checking equator v0.4.2
[INFO] [stderr]     Checking getrandom v0.2.17
[INFO] [stderr]     Checking pkcs8 v0.10.2
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking miniz_oxide v0.8.9
[INFO] [stderr]     Checking sec1 v0.7.3
[INFO] [stderr]     Checking ff v0.13.1
[INFO] [stderr]     Checking signature v2.2.0
[INFO] [stderr]     Checking group v0.13.0
[INFO] [stderr]     Checking crypto-bigint v0.5.5
[INFO] [stderr]     Checking aligned-vec v0.6.4
[INFO] [stderr]     Checking hkdf v0.12.4
[INFO] [stderr]     Checking thiserror v2.0.17
[INFO] [stderr]     Checking as-slice v0.2.1
[INFO] [stderr]    Compiling serde_json v1.0.145
[INFO] [stderr]     Checking aligned v0.4.3
[INFO] [stderr]     Checking v_frame v0.3.9
[INFO] [stderr]     Checking num-rational v0.4.2
[INFO] [stderr]     Checking icu_normalizer v2.1.1
[INFO] [stderr]     Checking flate2 v1.1.5
[INFO] [stderr]     Checking icu_properties v2.1.2
[INFO] [stderr]    Compiling curve25519-dalek v4.1.3
[INFO] [stderr]     Checking sha2 v0.10.9
[INFO] [stderr]     Checking rfc6979 v0.4.0
[INFO] [stderr]     Checking core2 v0.4.0
[INFO] [stderr]    Compiling ring v0.17.14
[INFO] [stderr]     Checking nom v8.0.0
[INFO] [stderr]    Compiling profiling-procmacros v1.0.17
[INFO] [stderr]    Compiling arg_enum_proc_macro v0.3.4
[INFO] [stderr]    Compiling num-conv v0.2.0
[INFO] [stderr]    Compiling time-core v0.1.8
[INFO] [stderr]     Checking ppv-lite86 v0.2.21
[INFO] [stderr]    Compiling num-bigint-dig v0.8.6
[INFO] [stderr]     Checking serde v1.0.228
[INFO] [stderr]     Checking av-scenechange v0.14.1
[INFO] [stderr]     Checking elliptic-curve v0.13.8
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking ecdsa v0.16.9
[INFO] [stderr]     Checking primeorder v0.13.6
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking idna_adapter v1.2.1
[INFO] [stderr]    Compiling time-macros v0.2.27
[INFO] [stderr]     Checking half v2.7.1
[INFO] [stderr]     Checking profiling v1.0.17
[INFO] [stderr]     Checking bitstream-io v4.9.0
[INFO] [stderr]     Checking maybe-rayon v0.1.1
[INFO] [stderr]     Checking num-iter v0.1.45
[INFO] [stderr]     Checking aho-corasick v1.1.4
[INFO] [stderr]    Compiling curve25519-dalek-derive v0.1.1
[INFO] [stderr]    Compiling fax_derive v0.2.0
[INFO] [stderr]    Compiling num-derive v0.4.2
[INFO] [stderr]    Compiling simd_helpers v0.1.0
[INFO] [stderr]    Compiling rustls v0.23.37
[INFO] [stderr]    Compiling camino v1.2.1
[INFO] [stderr]     Checking regex-syntax v0.8.8
[INFO] [stderr]     Checking imgref v1.12.0
[INFO] [stderr]     Checking weezl v0.1.12
[INFO] [stderr]     Checking percent-encoding v2.3.2
[INFO] [stderr]    Compiling current_platform v0.2.0
[INFO] [stderr]     Checking time v0.3.47
[INFO] [stderr]     Checking form_urlencoded v1.2.2
[INFO] [stderr]     Checking loop9 v0.1.5
[INFO] [stderr]     Checking zune-jpeg v0.4.21
[INFO] [stderr]     Checking idna v1.1.0
[INFO] [stderr]     Checking fax v0.2.6
[INFO] [stderr]     Checking webpki-roots v1.0.6
[INFO] [stderr]     Checking ed25519 v2.2.3
[INFO] [stderr]     Checking pkcs1 v0.7.5
[INFO] [stderr]     Checking pxfm v0.1.27
[INFO] [stderr]     Checking zune-inflate v0.2.54
[INFO] [stderr]     Checking fdeflate v0.3.7
[INFO] [stderr]     Checking av1-grain v0.2.5
[INFO] [stderr]     Checking bytemuck v1.24.0
[INFO] [stderr]     Checking lebe v0.5.3
[INFO] [stderr]     Checking bitflags v2.10.0
[INFO] [stderr]     Checking zune-jpeg v0.5.7
[INFO] [stderr]     Checking png v0.18.0
[INFO] [stderr]     Checking rsa v0.9.10
[INFO] [stderr]     Checking regex-automata v0.4.13
[INFO] [stderr]     Checking rav1e v0.8.1
[INFO] [stderr]     Checking simple_asn1 v0.6.4
[INFO] [stderr]     Checking rustls-webpki v0.103.9
[INFO] [stderr]     Checking gif v0.14.1
[INFO] [stderr]     Checking qoi v0.4.1
[INFO] [stderr]     Checking exr v1.74.0
[INFO] [stderr]     Checking ed25519-dalek v2.2.0
[INFO] [stderr]     Checking tiff v0.10.3
[INFO] [stderr]     Checking webpki-roots v0.26.11
[INFO] [stderr]     Checking url v2.5.8
[INFO] [stderr]     Checking pem v3.0.6
[INFO] [stderr]     Checking p256 v0.13.2
[INFO] [stderr]     Checking p384 v0.13.1
[INFO] [stderr]     Checking moxcms v0.7.11
[INFO] [stderr]     Checking toml v0.5.11
[INFO] [stderr]     Checking cargo-platform v0.3.1
[INFO] [stderr]     Checking semver v1.0.27
[INFO] [stderr]     Checking is-terminal v0.4.17
[INFO] [stderr]     Checking humantime v2.3.0
[INFO] [stderr]     Checking cargo_metadata v0.23.1
[INFO] [stderr]     Checking regex v1.12.2
[INFO] [stderr]     Checking jsonwebtoken v10.3.0
[INFO] [stderr]     Checking cargo-subcommand v0.12.0
[INFO] [stderr]     Checking env_logger v0.10.2
[INFO] [stderr]     Checking ureq v2.12.1
[INFO] [stderr]     Checking ravif v0.12.0
[INFO] [stderr]     Checking image v0.25.9
[INFO] [stderr]     Checking cargo-piston v0.4.1 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `regex::Regex`
[INFO] [stdout]  --> src/devices.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 5 | use regex::Regex;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:297:13
[INFO] [stdout]     |
[INFO] [stdout] 297 |             release: release, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:299:13
[INFO] [stdout]     |
[INFO] [stdout] 299 |             cwd: cwd,
[INFO] [stdout]     |             ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:300:13
[INFO] [stdout]     |
[INFO] [stdout] 300 |             build_path: build_path, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:302:13
[INFO] [stdout]     |
[INFO] [stdout] 302 |             icon_path: icon_path, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:303:13
[INFO] [stdout]     |
[INFO] [stdout] 303 |             cargo_path: cargo_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:304:13
[INFO] [stdout]     |
[INFO] [stdout] 304 |             gpg_path: gpg_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:305:13
[INFO] [stdout]     |
[INFO] [stdout] 305 |             app_name: app_name, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:306:13
[INFO] [stdout]     |
[INFO] [stdout] 306 |             lib_name: lib_name,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:307:13
[INFO] [stdout]     |
[INFO] [stdout] 307 |             app_version: app_version, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:308:13
[INFO] [stdout]     |
[INFO] [stdout] 308 |             manifest: manifest, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:309:13
[INFO] [stdout]     |
[INFO] [stdout] 309 |             manifest_path: manifest_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:314:13
[INFO] [stdout]     |
[INFO] [stdout] 314 |             build_tools_version: build_tools_version,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_tools_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:316:13
[INFO] [stdout]     |
[INFO] [stdout] 316 |             key_id: key_id,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:317:13
[INFO] [stdout]     |
[INFO] [stdout] 317 |             key_pass: key_pass,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Value`
[INFO] [stdout]  --> src/ios.rs:8:19
[INFO] [stdout]   |
[INFO] [stdout] 8 | use serde_json::{ Value, json };
[INFO] [stdout]   |                   ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::thread::sleep`
[INFO] [stdout]  --> src/ios.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 | use std::thread::sleep;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::time::Duration`
[INFO] [stdout]   --> src/ios.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use std::time::Duration;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:49:94
[INFO] [stdout]    |
[INFO] [stdout] 49 |             return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target})
[INFO] [stdout]    |                                                                                              ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:95:13
[INFO] [stdout]    |
[INFO] [stdout] 95 |             release: release, 
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:97:13
[INFO] [stdout]    |
[INFO] [stdout] 97 |             cwd: cwd, 
[INFO] [stdout]    |             ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:99:13
[INFO] [stdout]    |
[INFO] [stdout] 99 |             icon_path: icon_path, 
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:100:13
[INFO] [stdout]     |
[INFO] [stdout] 100 |             cargo_path: cargo_path, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:101:13
[INFO] [stdout]     |
[INFO] [stdout] 101 |             app_name: app_name, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:102:13
[INFO] [stdout]     |
[INFO] [stdout] 102 |             app_version: app_version, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:103:13
[INFO] [stdout]     |
[INFO] [stdout] 103 |             bundle_id: bundle_id, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:104:13
[INFO] [stdout]     |
[INFO] [stdout] 104 |             min_os_version: min_os_version, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_os_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:105:13
[INFO] [stdout]     |
[INFO] [stdout] 105 |             asc_api_key: asc_api_key,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `asc_api_key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:106:13
[INFO] [stdout]     |
[INFO] [stdout] 106 |             device_target: device_target, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:107:13
[INFO] [stdout]     |
[INFO] [stdout] 107 |             idp_path: idp_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `idp_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:108:13
[INFO] [stdout]     |
[INFO] [stdout] 108 |             keystore_path: keystore_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keystore_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:436:99
[INFO] [stdout]     |
[INFO] [stdout] 436 |         Ok(Self { key_id: key_id.unwrap().to_string(), issuer_id: issuer_id.unwrap().to_string(), priv_key: priv_key})
[INFO] [stdout]     |                                                                                                   ^^^^^^^^^^^^^^^^^^ help: replace it with: `priv_key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:25
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...   Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:71
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...   Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                                                                     ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:100
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_pa...
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:122
[INFO] [stdout]    |
[INFO] [stdout] 71 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homeb...
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:146
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...h: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: a...
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:166
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...argo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, ke...
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zigbuild_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:196
[INFO] [stdout]    |
[INFO] [stdout] 71 | ... zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `homebrew_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:226
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...d_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:246
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:262
[INFO] [stdout]    |
[INFO] [stdout] 71 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/linux.rs:188:24
[INFO] [stdout]     |
[INFO] [stdout] 188 |         Ok(LinuxRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/linux.rs:188:42
[INFO] [stdout]     |
[INFO] [stdout] 188 |         Ok(LinuxRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                          ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/linux.rs:188:52
[INFO] [stdout]     |
[INFO] [stdout] 188 |         Ok(LinuxRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:27:94
[INFO] [stdout]    |
[INFO] [stdout] 27 |             return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target})
[INFO] [stdout]    |                                                                                              ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:25
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...   Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:71
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...   Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                                                                     ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:100
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, ...
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:122
[INFO] [stdout]    |
[INFO] [stdout] 59 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:146
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...h: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:166
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:192
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `regex::Regex`
[INFO] [stdout]  --> src/devices.rs:5:5
[INFO] [stdout]   |
[INFO] [stdout] 5 | use regex::Regex;
[INFO] [stdout]   |     ^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/macos.rs:234:24
[INFO] [stdout]     |
[INFO] [stdout] 234 |         Ok(MacOSRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/macos.rs:234:42
[INFO] [stdout]     |
[INFO] [stdout] 234 |         Ok(MacOSRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                          ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/macos.rs:234:52
[INFO] [stdout]     |
[INFO] [stdout] 234 |         Ok(MacOSRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:27
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...   Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou...
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:73
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...   Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou...
[INFO] [stdout]    |                                                                       ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:102
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_pa...
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:124
[INFO] [stdout]    |
[INFO] [stdout] 65 | ... icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, ke...
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `embed_resources_ok`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:164
[INFO] [stdout]    |
[INFO] [stdout] 65 | ..._resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_...
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:188
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:208
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:228
[INFO] [stdout]    |
[INFO] [stdout] 65 | ... gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:244
[INFO] [stdout]    |
[INFO] [stdout] 65 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:297:13
[INFO] [stdout]     |
[INFO] [stdout] 297 |             release: release, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]     = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:299:13
[INFO] [stdout]     |
[INFO] [stdout] 299 |             cwd: cwd,
[INFO] [stdout]     |             ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:300:13
[INFO] [stdout]     |
[INFO] [stdout] 300 |             build_path: build_path, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:302:13
[INFO] [stdout]     |
[INFO] [stdout] 302 |             icon_path: icon_path, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:303:13
[INFO] [stdout]     |
[INFO] [stdout] 303 |             cargo_path: cargo_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:304:13
[INFO] [stdout]     |
[INFO] [stdout] 304 |             gpg_path: gpg_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:305:13
[INFO] [stdout]     |
[INFO] [stdout] 305 |             app_name: app_name, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:306:13
[INFO] [stdout]     |
[INFO] [stdout] 306 |             lib_name: lib_name,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:307:13
[INFO] [stdout]     |
[INFO] [stdout] 307 |             app_version: app_version, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:308:13
[INFO] [stdout]     |
[INFO] [stdout] 308 |             manifest: manifest, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:309:13
[INFO] [stdout]     |
[INFO] [stdout] 309 |             manifest_path: manifest_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:314:13
[INFO] [stdout]     |
[INFO] [stdout] 314 |             build_tools_version: build_tools_version,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_tools_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:316:13
[INFO] [stdout]     |
[INFO] [stdout] 316 |             key_id: key_id,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/android.rs:317:13
[INFO] [stdout]     |
[INFO] [stdout] 317 |             key_pass: key_pass,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `Value`
[INFO] [stdout]  --> src/ios.rs:8:19
[INFO] [stdout]   |
[INFO] [stdout] 8 | use serde_json::{ Value, json };
[INFO] [stdout]   |                   ^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::thread::sleep`
[INFO] [stdout]  --> src/ios.rs:9:5
[INFO] [stdout]   |
[INFO] [stdout] 9 | use std::thread::sleep;
[INFO] [stdout]   |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `std::time::Duration`
[INFO] [stdout]   --> src/ios.rs:10:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | use std::time::Duration;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:49:94
[INFO] [stdout]    |
[INFO] [stdout] 49 |             return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target})
[INFO] [stdout]    |                                                                                              ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:95:13
[INFO] [stdout]    |
[INFO] [stdout] 95 |             release: release, 
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:97:13
[INFO] [stdout]    |
[INFO] [stdout] 97 |             cwd: cwd, 
[INFO] [stdout]    |             ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/ios.rs:99:13
[INFO] [stdout]    |
[INFO] [stdout] 99 |             icon_path: icon_path, 
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:100:13
[INFO] [stdout]     |
[INFO] [stdout] 100 |             cargo_path: cargo_path, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:101:13
[INFO] [stdout]     |
[INFO] [stdout] 101 |             app_name: app_name, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:102:13
[INFO] [stdout]     |
[INFO] [stdout] 102 |             app_version: app_version, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:103:13
[INFO] [stdout]     |
[INFO] [stdout] 103 |             bundle_id: bundle_id, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:104:13
[INFO] [stdout]     |
[INFO] [stdout] 104 |             min_os_version: min_os_version, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_os_version`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:105:13
[INFO] [stdout]     |
[INFO] [stdout] 105 |             asc_api_key: asc_api_key,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `asc_api_key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:106:13
[INFO] [stdout]     |
[INFO] [stdout] 106 |             device_target: device_target, 
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `device_target`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:107:13
[INFO] [stdout]     |
[INFO] [stdout] 107 |             idp_path: idp_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `idp_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:108:13
[INFO] [stdout]     |
[INFO] [stdout] 108 |             keystore_path: keystore_path,
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keystore_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/ios.rs:436:99
[INFO] [stdout]     |
[INFO] [stdout] 436 |         Ok(Self { key_id: key_id.unwrap().to_string(), issuer_id: issuer_id.unwrap().to_string(), priv_key: priv_key})
[INFO] [stdout]     |                                                                                                   ^^^^^^^^^^^^^^^^^^ help: replace it with: `priv_key`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:25
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...   Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:71
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...   Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                                                                     ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:100
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_pa...
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:122
[INFO] [stdout]    |
[INFO] [stdout] 71 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homeb...
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:146
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...h: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: a...
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:166
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...argo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, ke...
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zigbuild_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:196
[INFO] [stdout]    |
[INFO] [stdout] 71 | ... zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `homebrew_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:226
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...d_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:246
[INFO] [stdout]    |
[INFO] [stdout] 71 | ...path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/linux.rs:71:262
[INFO] [stdout]    |
[INFO] [stdout] 71 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/linux.rs:188:24
[INFO] [stdout]     |
[INFO] [stdout] 188 |         Ok(LinuxRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/linux.rs:188:42
[INFO] [stdout]     |
[INFO] [stdout] 188 |         Ok(LinuxRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                          ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/linux.rs:188:52
[INFO] [stdout]     |
[INFO] [stdout] 188 |         Ok(LinuxRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:27:94
[INFO] [stdout]    |
[INFO] [stdout] 27 |             return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target})
[INFO] [stdout]    |                                                                                              ^^^^^^^^^^^^^^ help: replace it with: `target`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:25
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...   Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                       ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:71
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...   Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c...
[INFO] [stdout]    |                                                                     ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:100
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, ...
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:122
[INFO] [stdout]    |
[INFO] [stdout] 59 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:146
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...h: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:166
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/macos.rs:59:192
[INFO] [stdout]    |
[INFO] [stdout] 59 | ...: app_name, app_version: app_version, key_path: key_path})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/macos.rs:234:24
[INFO] [stdout]     |
[INFO] [stdout] 234 |         Ok(MacOSRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                        ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/macos.rs:234:42
[INFO] [stdout]     |
[INFO] [stdout] 234 |         Ok(MacOSRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                          ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]    --> src/macos.rs:234:52
[INFO] [stdout]     |
[INFO] [stdout] 234 |         Ok(MacOSRunner{release: release, cwd: cwd, cargo_path: cargo_path})
[INFO] [stdout]     |                                                    ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:27
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...   Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou...
[INFO] [stdout]    |                         ^^^^^^^^^^^^^^^^ help: replace it with: `release`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:73
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...   Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou...
[INFO] [stdout]    |                                                                       ^^^^^^^^ help: replace it with: `cwd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:102
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_pa...
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:124
[INFO] [stdout]    |
[INFO] [stdout] 65 | ... icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, ke...
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `embed_resources_ok`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:164
[INFO] [stdout]    |
[INFO] [stdout] 65 | ..._resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_...
[INFO] [stdout]    |                                       ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:188
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:208
[INFO] [stdout]    |
[INFO] [stdout] 65 | ...path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:228
[INFO] [stdout]    |
[INFO] [stdout] 65 | ... gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                             ^^^^^^^^^^^^^^ help: replace it with: `key_id`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/windows.rs:65:244
[INFO] [stdout]    |
[INFO] [stdout] 65 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass})
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `base64::decode`: Use Engine::decode
[INFO] [stdout]    --> src/ios.rs:614:32
[INFO] [stdout]     |
[INFO] [stdout] 614 |         let cert_der = base64::decode(cert_b64)
[INFO] [stdout]     |                                ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `base64::decode`: Use Engine::decode
[INFO] [stdout]    --> src/ios.rs:885:36
[INFO] [stdout]     |
[INFO] [stdout] 885 |         let profile_data = base64::decode(b64)
[INFO] [stdout]     |                                    ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `base64::decode`: Use Engine::decode
[INFO] [stdout]    --> src/ios.rs:614:32
[INFO] [stdout]     |
[INFO] [stdout] 614 |         let cert_der = base64::decode(cert_b64)
[INFO] [stdout]     |                                ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(deprecated)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: use of deprecated function `base64::decode`: Use Engine::decode
[INFO] [stdout]    --> src/ios.rs:885:36
[INFO] [stdout]     |
[INFO] [stdout] 885 |         let profile_data = base64::decode(b64)
[INFO] [stdout]     |                                    ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `base_zip`
[INFO] [stdout]    --> src/android.rs:605:41
[INFO] [stdout]     |
[INFO] [stdout] 605 |     fn zip_base(&self, base_dir: &Path, base_zip: &Path) -> Result<(), PistonError> {
[INFO] [stdout]     |                                         ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_zip`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `release`
[INFO] [stdout]    --> src/android.rs:673:18
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                  ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_release`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cwd`
[INFO] [stdout]    --> src/android.rs:673:33
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                                 ^^^ help: if this is intentional, prefix it with an underscore: `_cwd`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `env_vars`
[INFO] [stdout]    --> src/android.rs:673:47
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                                               ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_env_vars`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `device`
[INFO] [stdout]    --> src/android.rs:673:82
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                                                                                  ^^^^^^ help: if this is intentional, prefix it with an underscore: `_device`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `e`
[INFO] [stdout]    --> src/ios.rs:143:23
[INFO] [stdout]     |
[INFO] [stdout] 143 | ...   .map_err(|e| PistonError::XcodeBuildError("Failed to run xcodebuild -showsdks. Something is likely missing from your installa...
[INFO] [stdout]     |                 ^ help: if this is intentional, prefix it with an underscore: `_e`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `e`
[INFO] [stdout]    --> src/ios.rs:125:23
[INFO] [stdout]     |
[INFO] [stdout] 125 |             .map_err(|e| PistonError::XcodeSelectInstallError("Failed to verify xcode tools installation".to_string()));
[INFO] [stdout]     |                       ^ help: if this is intentional, prefix it with an underscore: `_e`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `runner`
[INFO] [stdout]    --> src/ios.rs:379:13
[INFO] [stdout]     |
[INFO] [stdout] 379 |         let runner = IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout]     |             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_runner`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cache_dir`
[INFO] [stdout]    --> src/ios.rs:700:13
[INFO] [stdout]     |
[INFO] [stdout] 700 |         let cache_dir = self.get_cache_dir();
[INFO] [stdout]     |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cache_dir`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `device_id`
[INFO] [stdout]    --> src/ios.rs:978:9
[INFO] [stdout]     |
[INFO] [stdout] 978 |         device_id: &str,
[INFO] [stdout]     |         ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `base_zip`
[INFO] [stdout]    --> src/android.rs:605:41
[INFO] [stdout]     |
[INFO] [stdout] 605 |     fn zip_base(&self, base_dir: &Path, base_zip: &Path) -> Result<(), PistonError> {
[INFO] [stdout]     |                                         ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_zip`
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `release`
[INFO] [stdout]    --> src/android.rs:673:18
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                  ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_release`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cwd`
[INFO] [stdout]    --> src/android.rs:673:33
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                                 ^^^ help: if this is intentional, prefix it with an underscore: `_cwd`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `env_vars`
[INFO] [stdout]    --> src/android.rs:673:47
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                                               ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_env_vars`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `device`
[INFO] [stdout]    --> src/android.rs:673:82
[INFO] [stdout]     |
[INFO] [stdout] 673 |     pub fn start(release: bool, cwd: PathBuf, env_vars: HashMap<String, String>, device: &AndroidDevice) -> Result<(), PistonError> {
[INFO] [stdout]     |                                                                                  ^^^^^^ help: if this is intentional, prefix it with an underscore: `_device`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `e`
[INFO] [stdout]    --> src/ios.rs:143:23
[INFO] [stdout]     |
[INFO] [stdout] 143 | ...   .map_err(|e| PistonError::XcodeBuildError("Failed to run xcodebuild -showsdks. Something is likely missing from your installa...
[INFO] [stdout]     |                 ^ help: if this is intentional, prefix it with an underscore: `_e`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `e`
[INFO] [stdout]    --> src/ios.rs:125:23
[INFO] [stdout]     |
[INFO] [stdout] 125 |             .map_err(|e| PistonError::XcodeSelectInstallError("Failed to verify xcode tools installation".to_string()));
[INFO] [stdout]     |                       ^ help: if this is intentional, prefix it with an underscore: `_e`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `runner`
[INFO] [stdout]    --> src/ios.rs:379:13
[INFO] [stdout]     |
[INFO] [stdout] 379 |         let runner = IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout]     |             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_runner`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `model` is never read
[INFO] [stdout]   --> src/devices.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct AndroidDevice {
[INFO] [stdout]    |            ------------- field in this struct
[INFO] [stdout] 17 |     model: String,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `AndroidDevice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `cargo_path`, `gpg_path`, `app_version`, `key_id`, and `key_pass` are never read
[INFO] [stdout]    --> src/android.rs:228:5
[INFO] [stdout]     |
[INFO] [stdout] 221 | pub struct AndroidBuilder {
[INFO] [stdout]     |            -------------- fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 228 |     cargo_path: String,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 229 |     gpg_path: Option<String>,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 232 |     app_version: String,
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 241 |     key_id: Option<String>,
[INFO] [stdout]     |     ^^^^^^
[INFO] [stdout] 242 |     key_pass: Option<String>,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `device` is never read
[INFO] [stdout]    --> src/android.rs:668:1
[INFO] [stdout]     |
[INFO] [stdout] 667 | pub struct AndroidRunner{
[INFO] [stdout]     |            ------------- field in this struct
[INFO] [stdout] 668 | device: String, 
[INFO] [stdout]     | ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `new` is never used
[INFO] [stdout]    --> src/android.rs:678:8
[INFO] [stdout]     |
[INFO] [stdout] 671 | impl AndroidRunner{
[INFO] [stdout]     | ------------------ associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 678 |     fn new() -> Self{
[INFO] [stdout]     |        ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `IOSMetadata` is never constructed
[INFO] [stdout]   --> src/ios.rs:19:8
[INFO] [stdout]    |
[INFO] [stdout] 19 | struct IOSMetadata {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `device` is never read
[INFO] [stdout]    --> src/ios.rs:364:1
[INFO] [stdout]     |
[INFO] [stdout] 363 | pub struct IOSRunner{
[INFO] [stdout]     |            --------- field in this struct
[INFO] [stdout] 364 | device: IOSDevice, 
[INFO] [stdout]     | ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `icon_path` is never read
[INFO] [stdout]   --> src/linux.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | pub struct LinuxBuilder {
[INFO] [stdout]    |            ------------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 16 |     icon_path: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `key_path` is never read
[INFO] [stdout]   --> src/macos.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | pub struct MacOSBuilder {
[INFO] [stdout]    |            ------------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 19 |     key_path: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `gpg_path`, `key_id`, and `key_pass` are never read
[INFO] [stdout]   --> src/windows.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | pub struct WindowsBuilder {
[INFO] [stdout]    |            -------------- fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 19 |     gpg_path: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 20 |     app_name: String,
[INFO] [stdout] 21 |     key_id: Option<String>,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 22 |     key_pass: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated functions `gpg_valid` and `gpg_sign` are never used
[INFO] [stdout]    --> src/helper.rs:239:12
[INFO] [stdout]     |
[INFO] [stdout]  22 | impl Helper {
[INFO] [stdout]     | ----------- associated functions in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 239 |     pub fn gpg_valid(key_id: Option<String>, gpg_bin: Option<String>) -> bool {
[INFO] [stdout]     |            ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 256 |     pub fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &PathBuf) -> String{
[INFO] [stdout]     |            ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `cache_dir`
[INFO] [stdout]    --> src/ios.rs:700:13
[INFO] [stdout]     |
[INFO] [stdout] 700 |         let cache_dir = self.get_cache_dir();
[INFO] [stdout]     |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cache_dir`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `device_id`
[INFO] [stdout]    --> src/ios.rs:978:9
[INFO] [stdout]     |
[INFO] [stdout] 978 |         device_id: &str,
[INFO] [stdout]     |         ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_device_id`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default()
[INFO] [stdout]    --> src/android.rs:140:9
[INFO] [stdout]     |
[INFO] [stdout] 140 | /         manifest.package = android_meta.package
[INFO] [stdout] 141 | |             .unwrap_or(format!("com.example.{}", crate_name));
[INFO] [stdout]     | |______________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout] note: consider initializing the variable with `android::AndroidManifest { package: android_meta.package
[INFO] [stdout]                   .unwrap_or(format!("com.example.{}", crate_name)), version_code: android_meta.version_code
[INFO] [stdout]                   .unwrap_or(1), version_name: android_meta.version_name
[INFO] [stdout]                   .unwrap_or("1.0".to_string()), min_sdk_version: android_meta.min_sdk_version
[INFO] [stdout]                   .unwrap_or(21), target_sdk_version: android_meta.target_sdk_version
[INFO] [stdout]                   .unwrap_or(34), app_label: android_meta.label
[INFO] [stdout]                   .unwrap_or(format!("{} App", crate_name)), app_name: app_name.to_string(), icon: "@mipmap/ic_launcher".to_string() }` and removing relevant reassignments
[INFO] [stdout]    --> src/android.rs:139:9
[INFO] [stdout]     |
[INFO] [stdout] 139 |         let mut manifest = Self::default();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
[INFO] [stdout]     = note: `#[warn(clippy::field_reassign_with_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/android.rs:202:33
[INFO] [stdout]     |
[INFO] [stdout] 202 |         let file = File::create(&dir)
[INFO] [stdout]     |                                 ^^^^ help: change this to: `dir`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:273:75
[INFO] [stdout]     |
[INFO] [stdout] 273 |         let build_tools_version: String = Helper::get_build_tools_version(&sdk_path)?;
[INFO] [stdout]     |                                                                           ^^^^^^^^^ help: change this to: `sdk_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:295:27
[INFO] [stdout]     |
[INFO] [stdout] 295 |         manifest.write_to(&manifest_path.as_path())?;
[INFO] [stdout]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `manifest_path.as_path()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:385:28
[INFO] [stdout]     |
[INFO] [stdout] 385 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &hdpi_target.display().to_string(), 48, 48)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:387:28
[INFO] [stdout]     |
[INFO] [stdout] 387 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &mdpi_target.display().to_string(), 72, 72)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:389:28
[INFO] [stdout]     |
[INFO] [stdout] 389 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xhdpi_target.display().to_string(), 96, 96)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:391:28
[INFO] [stdout]     |
[INFO] [stdout] 391 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxhdpi_target.display().to_string(), 144, 144)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:393:28
[INFO] [stdout]     |
[INFO] [stdout] 393 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxxhdpi_target.display().to_string(), 192, 192)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/android.rs:636:25
[INFO] [stdout]     |
[INFO] [stdout] 636 |             remove_file(&aab_path).map_err(|e| PistonError::RemoveFileError {
[INFO] [stdout]     |                         ^^^^^^^^^ help: change this to: `aab_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ios.rs:263:12
[INFO] [stdout]     |
[INFO] [stdout] 263 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none`
[INFO] [stdout]    --> src/ios.rs:267:33
[INFO] [stdout]     |
[INFO] [stdout] 263 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |             ------------------------ the check is happening here
[INFO] [stdout] ...
[INFO] [stdout] 267 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?;
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none`
[INFO] [stdout]    --> src/ios.rs:269:33
[INFO] [stdout]     |
[INFO] [stdout] 263 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |             ------------------------ the check is happening here
[INFO] [stdout] ...
[INFO] [stdout] 269 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?;
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/ios.rs:158:53
[INFO] [stdout]     |
[INFO] [stdout] 158 |           let partial_path: PathBuf = if self.release {
[INFO] [stdout]     |  _____________________________________________________^
[INFO] [stdout] 159 | |             format!("target/{}/ios/{}.app",release, capitalized).into()
[INFO] [stdout] 160 | |         }else {
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/ios.rs:160:15
[INFO] [stdout]     |
[INFO] [stdout] 160 |           }else {
[INFO] [stdout]     |  _______________^
[INFO] [stdout] 161 | |             format!("target/{}/ios/{}.app",release, capitalized).into()
[INFO] [stdout] 162 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/ios.rs:176:9
[INFO] [stdout]     |
[INFO] [stdout] 176 | /         if let Some(path) = &self.output_path {
[INFO] [stdout] 177 | |             if path.exists() {
[INFO] [stdout] 178 | |                 let _ = fs::remove_dir_all(path);
[INFO] [stdout] 179 | |             }
[INFO] [stdout] 180 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 176 ~         if let Some(path) = &self.output_path
[INFO] [stdout] 177 ~             && path.exists() {
[INFO] [stdout] 178 |                 let _ = fs::remove_dir_all(path);
[INFO] [stdout] 179 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:267:32
[INFO] [stdout]     |
[INFO] [stdout] 267 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?;
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:269:32
[INFO] [stdout]     |
[INFO] [stdout] 269 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?;
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ios.rs:338:16
[INFO] [stdout]     |
[INFO] [stdout] 338 |             if !self.device_target.is_none() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.device_target.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ios.rs:345:44
[INFO] [stdout]     |
[INFO] [stdout] 345 |                 if provisioned == false && !self.asc_api_key.is_none() {
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.asc_api_key.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]    --> src/ios.rs:345:20
[INFO] [stdout]     |
[INFO] [stdout] 345 |                 if provisioned == false && !self.asc_api_key.is_none() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `!provisioned`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/ios.rs:379:9
[INFO] [stdout]     |
[INFO] [stdout] 379 |         let runner = IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 379 -         let runner = IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout] 379 +         IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:392:73
[INFO] [stdout]     |
[INFO] [stdout] 392 |             .args(["devicectl", "device", "install", "app", "--device", &device_id, &output_path])
[INFO] [stdout]     |                                                                         ^^^^^^^^^^ help: change this to: `device_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:392:85
[INFO] [stdout]     |
[INFO] [stdout] 392 |             .args(["devicectl", "device", "install", "app", "--device", &device_id, &output_path])
[INFO] [stdout]     |                                                                                     ^^^^^^^^^^^^ help: change this to: `output_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:401:76
[INFO] [stdout]     |
[INFO] [stdout] 401 |             .args(["devicectl", "device", "process", "launch", "--device", &device_id, &bundle_id])
[INFO] [stdout]     |                                                                            ^^^^^^^^^^ help: change this to: `device_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:401:88
[INFO] [stdout]     |
[INFO] [stdout] 401 |             .args(["devicectl", "device", "process", "launch", "--device", &device_id, &bundle_id])
[INFO] [stdout]     |                                                                                        ^^^^^^^^^^ help: change this to: `bundle_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Result<&String, &str>` which implements the `Copy` trait
[INFO] [stdout]    --> src/ios.rs:421:22
[INFO] [stdout]     |
[INFO] [stdout] 421 |           let key_id = env.get("asc_key_id")
[INFO] [stdout]     |  ______________________^
[INFO] [stdout] 422 | |             .ok_or("Missing ASC_KEY_ID in .env")
[INFO] [stdout] 423 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] help: try removing the `clone` call
[INFO] [stdout]     |
[INFO] [stdout] 421 ~         let key_id = env.get("asc_key_id")
[INFO] [stdout] 422 ~             .ok_or("Missing ASC_KEY_ID in .env");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Result<&String, &str>` which implements the `Copy` trait
[INFO] [stdout]    --> src/ios.rs:425:25
[INFO] [stdout]     |
[INFO] [stdout] 425 |           let issuer_id = env.get("asc_issuer_id")
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 426 | |             .ok_or("Missing ASC_ISSUER_ID in .env")
[INFO] [stdout] 427 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] help: try removing the `clone` call
[INFO] [stdout]     |
[INFO] [stdout] 425 ~         let issuer_id = env.get("asc_issuer_id")
[INFO] [stdout] 426 ~             .ok_or("Missing ASC_ISSUER_ID in .env");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Result<&String, &str>` which implements the `Copy` trait
[INFO] [stdout]    --> src/ios.rs:429:23
[INFO] [stdout]     |
[INFO] [stdout] 429 |           let p8_path = env.get("asc_key_path")
[INFO] [stdout]     |  _______________________^
[INFO] [stdout] 430 | |             .ok_or("Missing ASC_KEY_PATH in .env")
[INFO] [stdout] 431 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] help: try removing the `clone` call
[INFO] [stdout]     |
[INFO] [stdout] 429 ~         let p8_path = env.get("asc_key_path")
[INFO] [stdout] 430 ~             .ok_or("Missing ASC_KEY_PATH in .env");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/ios.rs:433:43
[INFO] [stdout]     |
[INFO] [stdout] 433 |         let priv_key = fs::read_to_string(&p8_path.unwrap())
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^ help: change this to: `p8_path.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/ios.rs:455:9
[INFO] [stdout]     |
[INFO] [stdout] 455 | /         if let Ok(content) = fs::read_to_string(&path) {
[INFO] [stdout] 456 | |             if let Ok(json) = serde_json::from_str::<serde_json::Value>(&content) {
[INFO] [stdout] 457 | |                 let cert_id = json["cert_id"].as_str()?.to_string();
[INFO] [stdout] 458 | |                 let signing_identity = json["signing_identity"].as_str()?.to_string();
[INFO] [stdout] ...   |
[INFO] [stdout] 461 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 455 ~         if let Ok(content) = fs::read_to_string(&path)
[INFO] [stdout] 456 ~             && let Ok(json) = serde_json::from_str::<serde_json::Value>(&content) {
[INFO] [stdout] 457 |                 let cert_id = json["cert_id"].as_str()?.to_string();
[INFO] [stdout] 458 |                 let signing_identity = json["signing_identity"].as_str()?.to_string();
[INFO] [stdout] 459 |                 return Some((cert_id, signing_identity));
[INFO] [stdout] 460 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `model` is never read
[INFO] [stdout]   --> src/devices.rs:17:5
[INFO] [stdout]    |
[INFO] [stdout] 16 | pub struct AndroidDevice {
[INFO] [stdout]    |            ------------- field in this struct
[INFO] [stdout] 17 |     model: String,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `AndroidDevice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `cargo_path`, `gpg_path`, `app_version`, `key_id`, and `key_pass` are never read
[INFO] [stdout]    --> src/android.rs:228:5
[INFO] [stdout]     |
[INFO] [stdout] 221 | pub struct AndroidBuilder {
[INFO] [stdout]     |            -------------- fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 228 |     cargo_path: String,
[INFO] [stdout]     |     ^^^^^^^^^^
[INFO] [stdout] 229 |     gpg_path: Option<String>,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 232 |     app_version: String,
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 241 |     key_id: Option<String>,
[INFO] [stdout]     |     ^^^^^^
[INFO] [stdout] 242 |     key_pass: Option<String>,
[INFO] [stdout]     |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `device` is never read
[INFO] [stdout]    --> src/android.rs:668:1
[INFO] [stdout]     |
[INFO] [stdout] 667 | pub struct AndroidRunner{
[INFO] [stdout]     |            ------------- field in this struct
[INFO] [stdout] 668 | device: String, 
[INFO] [stdout]     | ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated function `new` is never used
[INFO] [stdout]    --> src/android.rs:678:8
[INFO] [stdout]     |
[INFO] [stdout] 671 | impl AndroidRunner{
[INFO] [stdout]     | ------------------ associated function in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 678 |     fn new() -> Self{
[INFO] [stdout]     |        ^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: struct `IOSMetadata` is never constructed
[INFO] [stdout]   --> src/ios.rs:19:8
[INFO] [stdout]    |
[INFO] [stdout] 19 | struct IOSMetadata {
[INFO] [stdout]    |        ^^^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `device` is never read
[INFO] [stdout]    --> src/ios.rs:364:1
[INFO] [stdout]     |
[INFO] [stdout] 363 | pub struct IOSRunner{
[INFO] [stdout]     |            --------- field in this struct
[INFO] [stdout] 364 | device: IOSDevice, 
[INFO] [stdout]     | ^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `icon_path` is never read
[INFO] [stdout]   --> src/linux.rs:16:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | pub struct LinuxBuilder {
[INFO] [stdout]    |            ------------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 16 |     icon_path: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field `key_path` is never read
[INFO] [stdout]   --> src/macos.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 10 | pub struct MacOSBuilder {
[INFO] [stdout]    |            ------------ field in this struct
[INFO] [stdout] ...
[INFO] [stdout] 19 |     key_path: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `gpg_path`, `key_id`, and `key_pass` are never read
[INFO] [stdout]   --> src/windows.rs:19:5
[INFO] [stdout]    |
[INFO] [stdout] 11 | pub struct WindowsBuilder {
[INFO] [stdout]    |            -------------- fields in this struct
[INFO] [stdout] ...
[INFO] [stdout] 19 |     gpg_path: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 20 |     app_name: String,
[INFO] [stdout] 21 |     key_id: Option<String>,
[INFO] [stdout]    |     ^^^^^^
[INFO] [stdout] 22 |     key_pass: Option<String>,
[INFO] [stdout]    |     ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: associated functions `gpg_valid` and `gpg_sign` are never used
[INFO] [stdout]    --> src/helper.rs:239:12
[INFO] [stdout]     |
[INFO] [stdout]  22 | impl Helper {
[INFO] [stdout]     | ----------- associated functions in this implementation
[INFO] [stdout] ...
[INFO] [stdout] 239 |     pub fn gpg_valid(key_id: Option<String>, gpg_bin: Option<String>) -> bool {
[INFO] [stdout]     |            ^^^^^^^^^
[INFO] [stdout] ...
[INFO] [stdout] 256 |     pub fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &PathBuf) -> String{
[INFO] [stdout]     |            ^^^^^^^^
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:916:40
[INFO] [stdout]     |
[INFO] [stdout] 916 |         AscClient::ensure_entitlements(&app_bundle_path)?;
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^ help: change this to: `app_bundle_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/ios.rs:928:49
[INFO] [stdout]     |
[INFO] [stdout] 928 |     pub fn ensure_entitlements(app_bundle_path: &PathBuf) -> Result<(), PistonError> {
[INFO] [stdout]     |                                                 ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 928 -     pub fn ensure_entitlements(app_bundle_path: &PathBuf) -> Result<(), PistonError> {
[INFO] [stdout] 928 +     pub fn ensure_entitlements(app_bundle_path: &Path) -> Result<(), PistonError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]     --> src/ios.rs:1026:53
[INFO] [stdout]      |
[INFO] [stdout] 1026 |                     return Err(PistonError::Generic(format!("Failed to list provisioning profiles with IDP")))
[INFO] [stdout]      |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to list provisioning profiles with IDP".to_string()`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]      = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default()
[INFO] [stdout]    --> src/android.rs:140:9
[INFO] [stdout]     |
[INFO] [stdout] 140 | /         manifest.package = android_meta.package
[INFO] [stdout] 141 | |             .unwrap_or(format!("com.example.{}", crate_name));
[INFO] [stdout]     | |______________________________________________________________^
[INFO] [stdout]     |
[INFO] [stdout] note: consider initializing the variable with `android::AndroidManifest { package: android_meta.package
[INFO] [stdout]                   .unwrap_or(format!("com.example.{}", crate_name)), version_code: android_meta.version_code
[INFO] [stdout]                   .unwrap_or(1), version_name: android_meta.version_name
[INFO] [stdout]                   .unwrap_or("1.0".to_string()), min_sdk_version: android_meta.min_sdk_version
[INFO] [stdout]                   .unwrap_or(21), target_sdk_version: android_meta.target_sdk_version
[INFO] [stdout]                   .unwrap_or(34), app_label: android_meta.label
[INFO] [stdout]                   .unwrap_or(format!("{} App", crate_name)), app_name: app_name.to_string(), icon: "@mipmap/ic_launcher".to_string() }` and removing relevant reassignments
[INFO] [stdout]    --> src/android.rs:139:9
[INFO] [stdout]     |
[INFO] [stdout] 139 |         let mut manifest = Self::default();
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default
[INFO] [stdout]     = note: `#[warn(clippy::field_reassign_with_default)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]     --> src/ios.rs:1047:40
[INFO] [stdout]      |
[INFO] [stdout] 1047 |             let _ = fs::remove_dir_all(&code_signature_path);
[INFO] [stdout]      |                                        ^^^^^^^^^^^^^^^^^^^^ help: change this to: `code_signature_path`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]     --> src/ios.rs:1049:40
[INFO] [stdout]      |
[INFO] [stdout] 1049 |         AscClient::ensure_entitlements(&app_bundle_path)?;
[INFO] [stdout]      |                                        ^^^^^^^^^^^^^^^^ help: change this to: `app_bundle_path`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/android.rs:202:33
[INFO] [stdout]     |
[INFO] [stdout] 202 |         let file = File::create(&dir)
[INFO] [stdout]     |                                 ^^^^ help: change this to: `dir`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:273:75
[INFO] [stdout]     |
[INFO] [stdout] 273 |         let build_tools_version: String = Helper::get_build_tools_version(&sdk_path)?;
[INFO] [stdout]     |                                                                           ^^^^^^^^^ help: change this to: `sdk_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:295:27
[INFO] [stdout]     |
[INFO] [stdout] 295 |         manifest.write_to(&manifest_path.as_path())?;
[INFO] [stdout]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `manifest_path.as_path()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:385:28
[INFO] [stdout]     |
[INFO] [stdout] 385 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &hdpi_target.display().to_string(), 48, 48)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:387:28
[INFO] [stdout]     |
[INFO] [stdout] 387 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &mdpi_target.display().to_string(), 72, 72)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:389:28
[INFO] [stdout]     |
[INFO] [stdout] 389 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xhdpi_target.display().to_string(), 96, 96)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:391:28
[INFO] [stdout]     |
[INFO] [stdout] 391 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxhdpi_target.display().to_string(), 144, 144)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/linux.rs:214:29
[INFO] [stdout]     |
[INFO] [stdout] 214 |           if key_id.is_none() {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 215 | |             return false
[INFO] [stdout] 216 | |         }else if gpg_bin.is_none() {
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/linux.rs:216:36
[INFO] [stdout]     |
[INFO] [stdout] 216 |           }else if gpg_bin.is_none() {
[INFO] [stdout]     |  ____________________________________^
[INFO] [stdout] 217 | |             return false
[INFO] [stdout] 218 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/android.rs:393:28
[INFO] [stdout]     |
[INFO] [stdout] 393 |         Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxxhdpi_target.display().to_string(), 192, 192)?;
[INFO] [stdout]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/linux.rs:224:9
[INFO] [stdout]     |
[INFO] [stdout] 224 | /         match output {
[INFO] [stdout] 225 | |             Ok(o) if o.status.success() => true,
[INFO] [stdout] 226 | |             _=> false,
[INFO] [stdout] 227 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 224 -         match output {
[INFO] [stdout] 225 -             Ok(o) if o.status.success() => true,
[INFO] [stdout] 226 -             _=> false,
[INFO] [stdout] 227 -         }
[INFO] [stdout] 224 +         matches!(output, Ok(o) if o.status.success())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/linux.rs:283:9
[INFO] [stdout]     |
[INFO] [stdout] 283 |         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 283 -         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout] 283 +         format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/linux.rs:230:106
[INFO] [stdout]     |
[INFO] [stdout] 230 |     fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &PathBuf) -> String{
[INFO] [stdout]     |                                                                                                          ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 230 ~     fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &Path) -> String{
[INFO] [stdout] 231 |         //prepare signature path: <binary>.asc
[INFO] [stdout] 232 ~         let mut sig_path = bundle_path.to_path_buf();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/linux.rs:250:18
[INFO] [stdout]     |
[INFO] [stdout] 250 |             .arg(&key_id.unwrap())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^ help: change this to: `key_id.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/linux.rs:253:18
[INFO] [stdout]     |
[INFO] [stdout] 253 |             .arg(&bundle_path.display().to_string())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bundle_path.display().to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/linux.rs:265:9
[INFO] [stdout]     |
[INFO] [stdout] 265 | /         if let Some(pass) = key_pass {
[INFO] [stdout] 266 | |             if let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 267 | |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] 268 | |                     Ok(res) => res,
[INFO] [stdout] ...   |
[INFO] [stdout] 272 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 265 ~         if let Some(pass) = key_pass
[INFO] [stdout] 266 ~             && let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 267 |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] ...
[INFO] [stdout] 270 |                 };
[INFO] [stdout] 271 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/linux.rs:280:20
[INFO] [stdout]     |
[INFO] [stdout] 280 |             return format!("GPG signing failed: {}", err_msg).into();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("GPG signing failed: {}", err_msg)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/macos.rs:149:12
[INFO] [stdout]     |
[INFO] [stdout] 149 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]   --> src/macos.rs:76:53
[INFO] [stdout]    |
[INFO] [stdout] 76 |           let partial_path: PathBuf = if self.release {
[INFO] [stdout]    |  _____________________________________________________^
[INFO] [stdout] 77 | |             format!("target/{}/macos/{}.app/Contents",release, capitalized).into()
[INFO] [stdout] 78 | |         }else {
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout] note: same as this
[INFO] [stdout]   --> src/macos.rs:78:15
[INFO] [stdout]    |
[INFO] [stdout] 78 |           }else {
[INFO] [stdout]    |  _______________^
[INFO] [stdout] 79 | |             format!("target/{}/macos/{}.app/Contents",release, capitalized).into()
[INFO] [stdout] 80 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/android.rs:636:25
[INFO] [stdout]     |
[INFO] [stdout] 636 |             remove_file(&aab_path).map_err(|e| PistonError::RemoveFileError {
[INFO] [stdout]     |                         ^^^^^^^^^ help: change this to: `aab_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/windows.rs:99:12
[INFO] [stdout]    |
[INFO] [stdout] 99 |         if !self.icon_path.is_none() && self.embed_resources_ok{
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none`
[INFO] [stdout]    --> src/windows.rs:135:69
[INFO] [stdout]     |
[INFO] [stdout]  99 |         if !self.icon_path.is_none() && self.embed_resources_ok{
[INFO] [stdout]     |             ------------------------ the check is happening here
[INFO] [stdout] ...
[INFO] [stdout] 135 |             println!("Converted {} to ICO ({}x{}) and saved as {}", self.icon_path.as_ref().unwrap(), 64, 64, icon_output.display());
[INFO] [stdout]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/windows.rs:134:23
[INFO] [stdout]     |
[INFO] [stdout] 134 |             ).map_err(|e| PistonError::WriteImageError(e))?;
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `PistonError::WriteImageError`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ios.rs:263:12
[INFO] [stdout]     |
[INFO] [stdout] 263 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none`
[INFO] [stdout]    --> src/ios.rs:267:33
[INFO] [stdout]     |
[INFO] [stdout] 263 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |             ------------------------ the check is happening here
[INFO] [stdout] ...
[INFO] [stdout] 267 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?;
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none`
[INFO] [stdout]    --> src/ios.rs:269:33
[INFO] [stdout]     |
[INFO] [stdout] 263 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |             ------------------------ the check is happening here
[INFO] [stdout] ...
[INFO] [stdout] 269 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?;
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/ios.rs:158:53
[INFO] [stdout]     |
[INFO] [stdout] 158 |           let partial_path: PathBuf = if self.release {
[INFO] [stdout]     |  _____________________________________________________^
[INFO] [stdout] 159 | |             format!("target/{}/ios/{}.app",release, capitalized).into()
[INFO] [stdout] 160 | |         }else {
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/ios.rs:160:15
[INFO] [stdout]     |
[INFO] [stdout] 160 |           }else {
[INFO] [stdout]     |  _______________^
[INFO] [stdout] 161 | |             format!("target/{}/ios/{}.app",release, capitalized).into()
[INFO] [stdout] 162 | |         };
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout]     = note: `#[warn(clippy::if_same_then_else)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/ios.rs:176:9
[INFO] [stdout]     |
[INFO] [stdout] 176 | /         if let Some(path) = &self.output_path {
[INFO] [stdout] 177 | |             if path.exists() {
[INFO] [stdout] 178 | |                 let _ = fs::remove_dir_all(path);
[INFO] [stdout] 179 | |             }
[INFO] [stdout] 180 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 176 ~         if let Some(path) = &self.output_path
[INFO] [stdout] 177 ~             && path.exists() {
[INFO] [stdout] 178 |                 let _ = fs::remove_dir_all(path);
[INFO] [stdout] 179 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:267:32
[INFO] [stdout]     |
[INFO] [stdout] 267 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?;
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:269:32
[INFO] [stdout]     |
[INFO] [stdout] 269 |             Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?;
[INFO] [stdout]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/helper.rs:97:22
[INFO] [stdout]    |
[INFO] [stdout] 97 |                 .arg(&target_name)
[INFO] [stdout]    |                      ^^^^^^^^^^^^ help: change this to: `target_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ios.rs:338:16
[INFO] [stdout]     |
[INFO] [stdout] 338 |             if !self.device_target.is_none() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.device_target.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/ios.rs:345:44
[INFO] [stdout]     |
[INFO] [stdout] 345 |                 if provisioned == false && !self.asc_api_key.is_none() {
[INFO] [stdout]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.asc_api_key.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/helper.rs:135:13
[INFO] [stdout]     |
[INFO] [stdout] 135 | /             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() {
[INFO] [stdout] 136 | |                 if let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 137 | |                     host_dirs.push(name.to_string());
[INFO] [stdout] 138 | |                 }
[INFO] [stdout] 139 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 135 ~             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir()
[INFO] [stdout] 136 ~                 && let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 137 |                     host_dirs.push(name.to_string());
[INFO] [stdout] 138 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/helper.rs:161:13
[INFO] [stdout]     |
[INFO] [stdout] 161 | /             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() {
[INFO] [stdout] 162 | |                 if let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 163 | |                     host_dirs.push(name.to_string());
[INFO] [stdout] 164 | |                 }
[INFO] [stdout] 165 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 161 ~             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir()
[INFO] [stdout] 162 ~                 && let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 163 |                     host_dirs.push(name.to_string());
[INFO] [stdout] 164 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]    --> src/ios.rs:345:20
[INFO] [stdout]     |
[INFO] [stdout] 345 |                 if provisioned == false && !self.asc_api_key.is_none() {
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^ help: try: `!provisioned`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this let-binding has unit value
[INFO] [stdout]    --> src/ios.rs:379:9
[INFO] [stdout]     |
[INFO] [stdout] 379 |         let runner = IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value
[INFO] [stdout]     = note: `#[warn(clippy::let_unit_value)]` on by default
[INFO] [stdout] help: omit the `let` binding
[INFO] [stdout]     |
[INFO] [stdout] 379 -         let runner = IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout] 379 +         IOSRunner::deploy_usb(device.id.as_ref(), &builder.0.display().to_string(), &builder.1)?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:392:73
[INFO] [stdout]     |
[INFO] [stdout] 392 |             .args(["devicectl", "device", "install", "app", "--device", &device_id, &output_path])
[INFO] [stdout]     |                                                                         ^^^^^^^^^^ help: change this to: `device_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:392:85
[INFO] [stdout]     |
[INFO] [stdout] 392 |             .args(["devicectl", "device", "install", "app", "--device", &device_id, &output_path])
[INFO] [stdout]     |                                                                                     ^^^^^^^^^^^^ help: change this to: `output_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/helper.rs:240:29
[INFO] [stdout]     |
[INFO] [stdout] 240 |           if key_id.is_none() {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 241 | |             return false
[INFO] [stdout] 242 | |         }else if gpg_bin.is_none() {
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/helper.rs:242:36
[INFO] [stdout]     |
[INFO] [stdout] 242 |           }else if gpg_bin.is_none() {
[INFO] [stdout]     |  ____________________________________^
[INFO] [stdout] 243 | |             return false
[INFO] [stdout] 244 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/helper.rs:250:9
[INFO] [stdout]     |
[INFO] [stdout] 250 | /         match output {
[INFO] [stdout] 251 | |             Ok(o) if o.status.success() => true,
[INFO] [stdout] 252 | |             _=> false,
[INFO] [stdout] 253 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 250 -         match output {
[INFO] [stdout] 251 -             Ok(o) if o.status.success() => true,
[INFO] [stdout] 252 -             _=> false,
[INFO] [stdout] 253 -         }
[INFO] [stdout] 250 +         matches!(output, Ok(o) if o.status.success())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/helper.rs:309:9
[INFO] [stdout]     |
[INFO] [stdout] 309 |         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 309 -         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout] 309 +         format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/helper.rs:256:110
[INFO] [stdout]     |
[INFO] [stdout] 256 |     pub fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &PathBuf) -> String{
[INFO] [stdout]     |                                                                                                              ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 256 ~     pub fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &Path) -> String{
[INFO] [stdout] 257 |         //prepare signature path: <binary>.asc
[INFO] [stdout] 258 ~         let mut sig_path = bundle_path.to_path_buf();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/helper.rs:276:18
[INFO] [stdout]     |
[INFO] [stdout] 276 |             .arg(&key_id.unwrap())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^ help: change this to: `key_id.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/helper.rs:279:18
[INFO] [stdout]     |
[INFO] [stdout] 279 |             .arg(&bundle_path.display().to_string())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bundle_path.display().to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:401:76
[INFO] [stdout]     |
[INFO] [stdout] 401 |             .args(["devicectl", "device", "process", "launch", "--device", &device_id, &bundle_id])
[INFO] [stdout]     |                                                                            ^^^^^^^^^^ help: change this to: `device_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:401:88
[INFO] [stdout]     |
[INFO] [stdout] 401 |             .args(["devicectl", "device", "process", "launch", "--device", &device_id, &bundle_id])
[INFO] [stdout]     |                                                                                        ^^^^^^^^^^ help: change this to: `bundle_id`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/helper.rs:291:9
[INFO] [stdout]     |
[INFO] [stdout] 291 | /         if let Some(pass) = key_pass {
[INFO] [stdout] 292 | |             if let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 293 | |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] 294 | |                     Ok(res) => res,
[INFO] [stdout] ...   |
[INFO] [stdout] 298 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 291 ~         if let Some(pass) = key_pass
[INFO] [stdout] 292 ~             && let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 293 |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] ...
[INFO] [stdout] 296 |                 };
[INFO] [stdout] 297 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/helper.rs:306:20
[INFO] [stdout]     |
[INFO] [stdout] 306 |             return format!("GPG signing failed: {}", err_msg).into();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("GPG signing failed: {}", err_msg)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Result<&String, &str>` which implements the `Copy` trait
[INFO] [stdout]    --> src/ios.rs:421:22
[INFO] [stdout]     |
[INFO] [stdout] 421 |           let key_id = env.get("asc_key_id")
[INFO] [stdout]     |  ______________________^
[INFO] [stdout] 422 | |             .ok_or("Missing ASC_KEY_ID in .env")
[INFO] [stdout] 423 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout]     = note: `#[warn(clippy::clone_on_copy)]` on by default
[INFO] [stdout] help: try removing the `clone` call
[INFO] [stdout]     |
[INFO] [stdout] 421 ~         let key_id = env.get("asc_key_id")
[INFO] [stdout] 422 ~             .ok_or("Missing ASC_KEY_ID in .env");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Result<&String, &str>` which implements the `Copy` trait
[INFO] [stdout]    --> src/ios.rs:425:25
[INFO] [stdout]     |
[INFO] [stdout] 425 |           let issuer_id = env.get("asc_issuer_id")
[INFO] [stdout]     |  _________________________^
[INFO] [stdout] 426 | |             .ok_or("Missing ASC_ISSUER_ID in .env")
[INFO] [stdout] 427 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] help: try removing the `clone` call
[INFO] [stdout]     |
[INFO] [stdout] 425 ~         let issuer_id = env.get("asc_issuer_id")
[INFO] [stdout] 426 ~             .ok_or("Missing ASC_ISSUER_ID in .env");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: using `clone` on type `Result<&String, &str>` which implements the `Copy` trait
[INFO] [stdout]    --> src/ios.rs:429:23
[INFO] [stdout]     |
[INFO] [stdout] 429 |           let p8_path = env.get("asc_key_path")
[INFO] [stdout]     |  _______________________^
[INFO] [stdout] 430 | |             .ok_or("Missing ASC_KEY_PATH in .env")
[INFO] [stdout] 431 | |             .clone();
[INFO] [stdout]     | |____________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stdout] help: try removing the `clone` call
[INFO] [stdout]     |
[INFO] [stdout] 429 ~         let p8_path = env.get("asc_key_path")
[INFO] [stdout] 430 ~             .ok_or("Missing ASC_KEY_PATH in .env");
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/ios.rs:433:43
[INFO] [stdout]     |
[INFO] [stdout] 433 |         let priv_key = fs::read_to_string(&p8_path.unwrap())
[INFO] [stdout]     |                                           ^^^^^^^^^^^^^^^^^ help: change this to: `p8_path.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/ios.rs:455:9
[INFO] [stdout]     |
[INFO] [stdout] 455 | /         if let Ok(content) = fs::read_to_string(&path) {
[INFO] [stdout] 456 | |             if let Ok(json) = serde_json::from_str::<serde_json::Value>(&content) {
[INFO] [stdout] 457 | |                 let cert_id = json["cert_id"].as_str()?.to_string();
[INFO] [stdout] 458 | |                 let signing_identity = json["signing_identity"].as_str()?.to_string();
[INFO] [stdout] ...   |
[INFO] [stdout] 461 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 455 ~         if let Ok(content) = fs::read_to_string(&path)
[INFO] [stdout] 456 ~             && let Ok(json) = serde_json::from_str::<serde_json::Value>(&content) {
[INFO] [stdout] 457 |                 let cert_id = json["cert_id"].as_str()?.to_string();
[INFO] [stdout] 458 |                 let signing_identity = json["signing_identity"].as_str()?.to_string();
[INFO] [stdout] 459 |                 return Some((cert_id, signing_identity));
[INFO] [stdout] 460 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:390:23
[INFO] [stdout]     |
[INFO] [stdout] 390 |             } else if !android_device.is_none() {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `android_device.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:394:23
[INFO] [stdout]     |
[INFO] [stdout] 394 |             } else if !ios_device.is_none() {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `ios_device.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `args.device` after checking its variant with `is_none`
[INFO] [stdout]    --> src/main.rs:370:30
[INFO] [stdout]     |
[INFO] [stdout] 356 |         if args.device.is_none() {
[INFO] [stdout]     |         ------------------------ help: try: `if let Some(<item>) = args.device`
[INFO] [stdout] ...
[INFO] [stdout] 370 |             let tgt_unwrap = args.device.unwrap();
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `android_device` after checking its variant with `is_none`
[INFO] [stdout]    --> src/main.rs:392:63
[INFO] [stdout]     |
[INFO] [stdout] 390 |             } else if !android_device.is_none() {
[INFO] [stdout]     |                        ------------------------ the check is happening here
[INFO] [stdout] 391 |                 println!("explicit Android runner target: {:?}", &android_device);
[INFO] [stdout] 392 |                 AndroidRunner::start(release, cwd, env_vars, &android_device.unwrap())?;
[INFO] [stdout]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/main.rs:286:13
[INFO] [stdout]     |
[INFO] [stdout] 282 | /             let value = stdout_str.lines()
[INFO] [stdout] 283 | |                 .find(|line| line.starts_with("host:"))
[INFO] [stdout] 284 | |                 .map(|line| line.trim_start_matches("host: ").trim().to_string())
[INFO] [stdout] 285 | |                 .unwrap_or_else(|| "Unknown".to_string());
[INFO] [stdout]     | |__________________________________________________________- unnecessary `let` binding
[INFO] [stdout] 286 |               value
[INFO] [stdout]     |               ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 282 ~             
[INFO] [stdout] 283 ~             stdout_str.lines()
[INFO] [stdout] 284 +                 .find(|line| line.starts_with("host:"))
[INFO] [stdout] 285 +                 .map(|line| line.trim_start_matches("host: ").trim().to_string())
[INFO] [stdout] 286 +                 .unwrap_or_else(|| "Unknown".to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/ios.rs:916:40
[INFO] [stdout]     |
[INFO] [stdout] 916 |         AscClient::ensure_entitlements(&app_bundle_path)?;
[INFO] [stdout]     |                                        ^^^^^^^^^^^^^^^^ help: change this to: `app_bundle_path`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:382:58
[INFO] [stdout]     |
[INFO] [stdout] 382 |                 IOSRunner::start(release, cwd, env_vars, &device)?;
[INFO] [stdout]     |                                                          ^^^^^^^ help: change this to: `device`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/ios.rs:928:49
[INFO] [stdout]     |
[INFO] [stdout] 928 |     pub fn ensure_entitlements(app_bundle_path: &PathBuf) -> Result<(), PistonError> {
[INFO] [stdout]     |                                                 ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 928 -     pub fn ensure_entitlements(app_bundle_path: &PathBuf) -> Result<(), PistonError> {
[INFO] [stdout] 928 +     pub fn ensure_entitlements(app_bundle_path: &Path) -> Result<(), PistonError> {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:388:62
[INFO] [stdout]     |
[INFO] [stdout] 388 |                 AndroidRunner::start(release, cwd, env_vars, &device)?;
[INFO] [stdout]     |                                                              ^^^^^^^ help: change this to: `device`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:392:62
[INFO] [stdout]     |
[INFO] [stdout] 392 |                 AndroidRunner::start(release, cwd, env_vars, &android_device.unwrap())?;
[INFO] [stdout]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `android_device.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:396:58
[INFO] [stdout]     |
[INFO] [stdout] 396 |                 IOSRunner::start(release, cwd, env_vars, &ios_device.unwrap())?;
[INFO] [stdout]     |                                                          ^^^^^^^^^^^^^^^^^^^^ help: change this to: `ios_device.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]     --> src/ios.rs:1026:53
[INFO] [stdout]      |
[INFO] [stdout] 1026 |                     return Err(PistonError::Generic(format!("Failed to list provisioning profiles with IDP")))
[INFO] [stdout]      |                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Failed to list provisioning profiles with IDP".to_string()`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]      = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/main.rs:371:50
[INFO] [stdout]     |
[INFO] [stdout] 371 |             let target_device = tgt_unwrap.trim().clone();
[INFO] [stdout]     |                                                  ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]     --> src/ios.rs:1047:40
[INFO] [stdout]      |
[INFO] [stdout] 1047 |             let _ = fs::remove_dir_all(&code_signature_path);
[INFO] [stdout]      |                                        ^^^^^^^^^^^^^^^^^^^^ help: change this to: `code_signature_path`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]     --> src/ios.rs:1049:40
[INFO] [stdout]      |
[INFO] [stdout] 1049 |         AscClient::ensure_entitlements(&app_bundle_path)?;
[INFO] [stdout]      |                                        ^^^^^^^^^^^^^^^^ help: change this to: `app_bundle_path`
[INFO] [stdout]      |
[INFO] [stdout]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/linux.rs:214:29
[INFO] [stdout]     |
[INFO] [stdout] 214 |           if key_id.is_none() {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 215 | |             return false
[INFO] [stdout] 216 | |         }else if gpg_bin.is_none() {
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/linux.rs:216:36
[INFO] [stdout]     |
[INFO] [stdout] 216 |           }else if gpg_bin.is_none() {
[INFO] [stdout]     |  ____________________________________^
[INFO] [stdout] 217 | |             return false
[INFO] [stdout] 218 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/linux.rs:224:9
[INFO] [stdout]     |
[INFO] [stdout] 224 | /         match output {
[INFO] [stdout] 225 | |             Ok(o) if o.status.success() => true,
[INFO] [stdout] 226 | |             _=> false,
[INFO] [stdout] 227 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout]     = note: `#[warn(clippy::match_like_matches_macro)]` on by default
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 224 -         match output {
[INFO] [stdout] 225 -             Ok(o) if o.status.success() => true,
[INFO] [stdout] 226 -             _=> false,
[INFO] [stdout] 227 -         }
[INFO] [stdout] 224 +         matches!(output, Ok(o) if o.status.success())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/linux.rs:283:9
[INFO] [stdout]     |
[INFO] [stdout] 283 |         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 283 -         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout] 283 +         format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/linux.rs:230:106
[INFO] [stdout]     |
[INFO] [stdout] 230 |     fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &PathBuf) -> String{
[INFO] [stdout]     |                                                                                                          ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 230 ~     fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &Path) -> String{
[INFO] [stdout] 231 |         //prepare signature path: <binary>.asc
[INFO] [stdout] 232 ~         let mut sig_path = bundle_path.to_path_buf();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/linux.rs:250:18
[INFO] [stdout]     |
[INFO] [stdout] 250 |             .arg(&key_id.unwrap())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^ help: change this to: `key_id.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/linux.rs:253:18
[INFO] [stdout]     |
[INFO] [stdout] 253 |             .arg(&bundle_path.display().to_string())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bundle_path.display().to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/linux.rs:265:9
[INFO] [stdout]     |
[INFO] [stdout] 265 | /         if let Some(pass) = key_pass {
[INFO] [stdout] 266 | |             if let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 267 | |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] 268 | |                     Ok(res) => res,
[INFO] [stdout] ...   |
[INFO] [stdout] 272 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 265 ~         if let Some(pass) = key_pass
[INFO] [stdout] 266 ~             && let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 267 |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] ...
[INFO] [stdout] 270 |                 };
[INFO] [stdout] 271 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/linux.rs:280:20
[INFO] [stdout]     |
[INFO] [stdout] 280 |             return format!("GPG signing failed: {}", err_msg).into();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("GPG signing failed: {}", err_msg)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]     = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/macos.rs:149:12
[INFO] [stdout]     |
[INFO] [stdout] 149 |         if !self.icon_path.is_none(){
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]   --> src/macos.rs:76:53
[INFO] [stdout]    |
[INFO] [stdout] 76 |           let partial_path: PathBuf = if self.release {
[INFO] [stdout]    |  _____________________________________________________^
[INFO] [stdout] 77 | |             format!("target/{}/macos/{}.app/Contents",release, capitalized).into()
[INFO] [stdout] 78 | |         }else {
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout] note: same as this
[INFO] [stdout]   --> src/macos.rs:78:15
[INFO] [stdout]    |
[INFO] [stdout] 78 |           }else {
[INFO] [stdout]    |  _______________^
[INFO] [stdout] 79 | |             format!("target/{}/macos/{}.app/Contents",release, capitalized).into()
[INFO] [stdout] 80 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/windows.rs:99:12
[INFO] [stdout]    |
[INFO] [stdout] 99 |         if !self.icon_path.is_none() && self.embed_resources_ok{
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none`
[INFO] [stdout]    --> src/windows.rs:135:69
[INFO] [stdout]     |
[INFO] [stdout]  99 |         if !self.icon_path.is_none() && self.embed_resources_ok{
[INFO] [stdout]     |             ------------------------ the check is happening here
[INFO] [stdout] ...
[INFO] [stdout] 135 |             println!("Converted {} to ICO ({}x{}) and saved as {}", self.icon_path.as_ref().unwrap(), 64, 64, icon_output.display());
[INFO] [stdout]     |                                                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant closure
[INFO] [stdout]    --> src/windows.rs:134:23
[INFO] [stdout]     |
[INFO] [stdout] 134 |             ).map_err(|e| PistonError::WriteImageError(e))?;
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `PistonError::WriteImageError`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stdout]     = note: `#[warn(clippy::redundant_closure)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/helper.rs:97:22
[INFO] [stdout]    |
[INFO] [stdout] 97 |                 .arg(&target_name)
[INFO] [stdout]    |                      ^^^^^^^^^^^^ help: change this to: `target_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/helper.rs:135:13
[INFO] [stdout]     |
[INFO] [stdout] 135 | /             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() {
[INFO] [stdout] 136 | |                 if let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 137 | |                     host_dirs.push(name.to_string());
[INFO] [stdout] 138 | |                 }
[INFO] [stdout] 139 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 135 ~             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir()
[INFO] [stdout] 136 ~                 && let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 137 |                     host_dirs.push(name.to_string());
[INFO] [stdout] 138 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/helper.rs:161:13
[INFO] [stdout]     |
[INFO] [stdout] 161 | /             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() {
[INFO] [stdout] 162 | |                 if let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 163 | |                     host_dirs.push(name.to_string());
[INFO] [stdout] 164 | |                 }
[INFO] [stdout] 165 | |             }
[INFO] [stdout]     | |_____________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 161 ~             if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir()
[INFO] [stdout] 162 ~                 && let Some(name) = entry.file_name().to_str() {
[INFO] [stdout] 163 |                     host_dirs.push(name.to_string());
[INFO] [stdout] 164 ~                 }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` has identical blocks
[INFO] [stdout]    --> src/helper.rs:240:29
[INFO] [stdout]     |
[INFO] [stdout] 240 |           if key_id.is_none() {
[INFO] [stdout]     |  _____________________________^
[INFO] [stdout] 241 | |             return false
[INFO] [stdout] 242 | |         }else if gpg_bin.is_none() {
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout] note: same as this
[INFO] [stdout]    --> src/helper.rs:242:36
[INFO] [stdout]     |
[INFO] [stdout] 242 |           }else if gpg_bin.is_none() {
[INFO] [stdout]     |  ____________________________________^
[INFO] [stdout] 243 | |             return false
[INFO] [stdout] 244 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: match expression looks like `matches!` macro
[INFO] [stdout]    --> src/helper.rs:250:9
[INFO] [stdout]     |
[INFO] [stdout] 250 | /         match output {
[INFO] [stdout] 251 | |             Ok(o) if o.status.success() => true,
[INFO] [stdout] 252 | |             _=> false,
[INFO] [stdout] 253 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
[INFO] [stdout] help: use `matches!` directly
[INFO] [stdout]     |
[INFO] [stdout] 250 -         match output {
[INFO] [stdout] 251 -             Ok(o) if o.status.success() => true,
[INFO] [stdout] 252 -             _=> false,
[INFO] [stdout] 253 -         }
[INFO] [stdout] 250 +         matches!(output, Ok(o) if o.status.success())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/helper.rs:309:9
[INFO] [stdout]     |
[INFO] [stdout] 309 |         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 309 -         return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display());
[INFO] [stdout] 309 +         format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do
[INFO] [stdout]    --> src/helper.rs:256:110
[INFO] [stdout]     |
[INFO] [stdout] 256 |     pub fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &PathBuf) -> String{
[INFO] [stdout]     |                                                                                                              ^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 256 ~     pub fn gpg_sign(key_id: Option<String>, key_pass: Option<String>, gpg_path: Option<String>, bundle_path: &Path) -> String{
[INFO] [stdout] 257 |         //prepare signature path: <binary>.asc
[INFO] [stdout] 258 ~         let mut sig_path = bundle_path.to_path_buf();
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/helper.rs:276:18
[INFO] [stdout]     |
[INFO] [stdout] 276 |             .arg(&key_id.unwrap())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^ help: change this to: `key_id.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/helper.rs:279:18
[INFO] [stdout]     |
[INFO] [stdout] 279 |             .arg(&bundle_path.display().to_string())
[INFO] [stdout]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bundle_path.display().to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/helper.rs:291:9
[INFO] [stdout]     |
[INFO] [stdout] 291 | /         if let Some(pass) = key_pass {
[INFO] [stdout] 292 | |             if let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 293 | |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] 294 | |                     Ok(res) => res,
[INFO] [stdout] ...   |
[INFO] [stdout] 298 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 291 ~         if let Some(pass) = key_pass
[INFO] [stdout] 292 ~             && let Some(mut stdin) = child.stdin.take() {
[INFO] [stdout] 293 |                 match stdin.write(pass.as_bytes()) {
[INFO] [stdout] ...
[INFO] [stdout] 296 |                 };
[INFO] [stdout] 297 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::string::String`
[INFO] [stdout]    --> src/helper.rs:306:20
[INFO] [stdout]     |
[INFO] [stdout] 306 |             return format!("GPG signing failed: {}", err_msg).into();
[INFO] [stdout]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("GPG signing failed: {}", err_msg)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:390:23
[INFO] [stdout]     |
[INFO] [stdout] 390 |             } else if !android_device.is_none() {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `android_device.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:394:23
[INFO] [stdout]     |
[INFO] [stdout] 394 |             } else if !ios_device.is_none() {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `ios_device.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `args.device` after checking its variant with `is_none`
[INFO] [stdout]    --> src/main.rs:370:30
[INFO] [stdout]     |
[INFO] [stdout] 356 |         if args.device.is_none() {
[INFO] [stdout]     |         ------------------------ help: try: `if let Some(<item>) = args.device`
[INFO] [stdout] ...
[INFO] [stdout] 370 |             let tgt_unwrap = args.device.unwrap();
[INFO] [stdout]     |                              ^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `android_device` after checking its variant with `is_none`
[INFO] [stdout]    --> src/main.rs:392:63
[INFO] [stdout]     |
[INFO] [stdout] 390 |             } else if !android_device.is_none() {
[INFO] [stdout]     |                        ------------------------ the check is happening here
[INFO] [stdout] 391 |                 println!("explicit Android runner target: {:?}", &android_device);
[INFO] [stdout] 392 |                 AndroidRunner::start(release, cwd, env_vars, &android_device.unwrap())?;
[INFO] [stdout]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: try using `if let` or `match`
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/main.rs:286:13
[INFO] [stdout]     |
[INFO] [stdout] 282 | /             let value = stdout_str.lines()
[INFO] [stdout] 283 | |                 .find(|line| line.starts_with("host:"))
[INFO] [stdout] 284 | |                 .map(|line| line.trim_start_matches("host: ").trim().to_string())
[INFO] [stdout] 285 | |                 .unwrap_or_else(|| "Unknown".to_string());
[INFO] [stdout]     | |__________________________________________________________- unnecessary `let` binding
[INFO] [stdout] 286 |               value
[INFO] [stdout]     |               ^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 282 ~             
[INFO] [stdout] 283 ~             stdout_str.lines()
[INFO] [stdout] 284 +                 .find(|line| line.starts_with("host:"))
[INFO] [stdout] 285 +                 .map(|line| line.trim_start_matches("host: ").trim().to_string())
[INFO] [stdout] 286 +                 .unwrap_or_else(|| "Unknown".to_string())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:382:58
[INFO] [stdout]     |
[INFO] [stdout] 382 |                 IOSRunner::start(release, cwd, env_vars, &device)?;
[INFO] [stdout]     |                                                          ^^^^^^^ help: change this to: `device`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:388:62
[INFO] [stdout]     |
[INFO] [stdout] 388 |                 AndroidRunner::start(release, cwd, env_vars, &device)?;
[INFO] [stdout]     |                                                              ^^^^^^^ help: change this to: `device`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:392:62
[INFO] [stdout]     |
[INFO] [stdout] 392 |                 AndroidRunner::start(release, cwd, env_vars, &android_device.unwrap())?;
[INFO] [stdout]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `android_device.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/main.rs:396:58
[INFO] [stdout]     |
[INFO] [stdout] 396 |                 IOSRunner::start(release, cwd, env_vars, &ios_device.unwrap())?;
[INFO] [stdout]     |                                                          ^^^^^^^^^^^^^^^^^^^^ help: change this to: `ios_device.unwrap()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]    --> src/main.rs:371:50
[INFO] [stdout]     |
[INFO] [stdout] 371 |             let target_device = tgt_unwrap.trim().clone();
[INFO] [stdout]     |                                                  ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]     |
[INFO] [stdout]     = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed
[INFO] [stdout]     = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 19s
[INFO] running `Command { std: "docker" "inspect" "a5c8fee274633cf4d616207a9795b0fe8146d73fc2998af5dfbe47b16ecbc239", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "a5c8fee274633cf4d616207a9795b0fe8146d73fc2998af5dfbe47b16ecbc239", kill_on_drop: false }`
[INFO] [stdout] a5c8fee274633cf4d616207a9795b0fe8146d73fc2998af5dfbe47b16ecbc239