[INFO] cloning repository https://github.com/databoose/stopwatch-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/databoose/stopwatch-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdataboose%2Fstopwatch-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdataboose%2Fstopwatch-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9abe582119db68d177ecddddcc7584d3f9fe3deb [INFO] linting databoose/stopwatch-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fdataboose%2Fstopwatch-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/databoose/stopwatch-rs [INFO] finished tweaking git repo https://github.com/databoose/stopwatch-rs [INFO] tweaked toml for git repo https://github.com/databoose/stopwatch-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/databoose/stopwatch-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/databoose/stopwatch-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97cad73271fe5d1ee9faaea8c80bf554da9627c27c29030d12edb1c8221f4a2e [INFO] running `Command { std: "docker" "start" "-a" "97cad73271fe5d1ee9faaea8c80bf554da9627c27c29030d12edb1c8221f4a2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97cad73271fe5d1ee9faaea8c80bf554da9627c27c29030d12edb1c8221f4a2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97cad73271fe5d1ee9faaea8c80bf554da9627c27c29030d12edb1c8221f4a2e", kill_on_drop: false }` [INFO] [stdout] 97cad73271fe5d1ee9faaea8c80bf554da9627c27c29030d12edb1c8221f4a2e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7bebee27e7012fed55de63df20371a75e73b4be44c3e93de4236276927d9859b [INFO] running `Command { std: "docker" "start" "-a" "7bebee27e7012fed55de63df20371a75e73b4be44c3e93de4236276927d9859b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking signal-hook v0.3.18 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling instability v0.3.9 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking stopwatch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Interval` and `interval_at` [INFO] [stdout] --> src/main.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use tokio::time::{interval_at, Duration, Instant, Interval}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Interval` and `interval_at` [INFO] [stdout] --> src/main.rs:4:19 [INFO] [stdout] | [INFO] [stdout] 4 | use tokio::time::{interval_at, Duration, Instant, Interval}; [INFO] [stdout] | ^^^^^^^^^^^ ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | / match &self.timers[self.selected_timer].task_handle { [INFO] [stdout] 103 | | Some(handle) => handle.abort(), [INFO] [stdout] 104 | | None => {} [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(handle) = &self.timers[self.selected_timer].task_handle { handle.abort() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:517:32 [INFO] [stdout] | [INFO] [stdout] 517 | ... if !(state.ui_update_rate_ms <= 10) { // cap at 100fps [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.ui_update_rate_ms > 10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:523:32 [INFO] [stdout] | [INFO] [stdout] 523 | ... if !(state.ui_update_rate_ms >= 100) { // no lower than 10fps because it starts being unresponsive to key events [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.ui_update_rate_ms < 100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | / match &self.timers[self.selected_timer].task_handle { [INFO] [stdout] 103 | | Some(handle) => handle.abort(), [INFO] [stdout] 104 | | None => {} [INFO] [stdout] 105 | | } [INFO] [stdout] | |_____________^ help: try: `if let Some(handle) = &self.timers[self.selected_timer].task_handle { handle.abort() }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:487:29 [INFO] [stdout] | [INFO] [stdout] 487 | / ... if state.timers.len() < 8 { [INFO] [stdout] 488 | | ... state.add_timer(); [INFO] [stdout] 489 | | ... [INFO] [stdout] 490 | | ... let idx = state.timers.len() - 1; [INFO] [stdout] ... | [INFO] [stdout] 498 | | ... timer.task_handle = Some(handle); [INFO] [stdout] 499 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 486 ~ KeyCode::Char('a') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 487 ~ && state.timers.len() < 8 => { [INFO] [stdout] 488 | state.add_timer(); [INFO] [stdout] ... [INFO] [stdout] 498 | timer.task_handle = Some(handle); [INFO] [stdout] 499 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:502:29 [INFO] [stdout] | [INFO] [stdout] 502 | / ... if state.timers.len() > 1 { [INFO] [stdout] 503 | | ... state.remove_timer(); [INFO] [stdout] 504 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 501 ~ KeyCode::Char('d') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 502 ~ && state.timers.len() > 1 => { [INFO] [stdout] 503 | state.remove_timer(); [INFO] [stdout] 504 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:517:29 [INFO] [stdout] | [INFO] [stdout] 517 | / ... if !(state.ui_update_rate_ms <= 10) { // cap at 100fps [INFO] [stdout] 518 | | ... state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_sub(5); [INFO] [stdout] 519 | | ... interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 520 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 516 ~ KeyCode::Up [INFO] [stdout] 517 ~ if !(state.ui_update_rate_ms <= 10) => { // cap at 100fps [INFO] [stdout] 518 | state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_sub(5); [INFO] [stdout] 519 | interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 520 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:523:29 [INFO] [stdout] | [INFO] [stdout] 523 | / ... if !(state.ui_update_rate_ms >= 100) { // no lower than 10fps because it starts being unresponsive to key events [INFO] [stdout] 524 | | ... state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_add(5); [INFO] [stdout] 525 | | ... interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 526 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 522 ~ KeyCode::Down [INFO] [stdout] 523 ~ if !(state.ui_update_rate_ms >= 100) => { // no lower than 10fps because it starts being unresponsive to key events [INFO] [stdout] 524 | state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_add(5); [INFO] [stdout] 525 | interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 526 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:517:32 [INFO] [stdout] | [INFO] [stdout] 517 | ... if !(state.ui_update_rate_ms <= 10) { // cap at 100fps [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.ui_update_rate_ms > 10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:523:32 [INFO] [stdout] | [INFO] [stdout] 523 | ... if !(state.ui_update_rate_ms >= 100) { // no lower than 10fps because it starts being unresponsive to key events [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(state.ui_update_rate_ms < 100)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:487:29 [INFO] [stdout] | [INFO] [stdout] 487 | / ... if state.timers.len() < 8 { [INFO] [stdout] 488 | | ... state.add_timer(); [INFO] [stdout] 489 | | ... [INFO] [stdout] 490 | | ... let idx = state.timers.len() - 1; [INFO] [stdout] ... | [INFO] [stdout] 498 | | ... timer.task_handle = Some(handle); [INFO] [stdout] 499 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 486 ~ KeyCode::Char('a') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 487 ~ && state.timers.len() < 8 => { [INFO] [stdout] 488 | state.add_timer(); [INFO] [stdout] ... [INFO] [stdout] 498 | timer.task_handle = Some(handle); [INFO] [stdout] 499 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:502:29 [INFO] [stdout] | [INFO] [stdout] 502 | / ... if state.timers.len() > 1 { [INFO] [stdout] 503 | | ... state.remove_timer(); [INFO] [stdout] 504 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 501 ~ KeyCode::Char('d') if key.modifiers.contains(KeyModifiers::CONTROL) [INFO] [stdout] 502 ~ && state.timers.len() > 1 => { [INFO] [stdout] 503 | state.remove_timer(); [INFO] [stdout] 504 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:517:29 [INFO] [stdout] | [INFO] [stdout] 517 | / ... if !(state.ui_update_rate_ms <= 10) { // cap at 100fps [INFO] [stdout] 518 | | ... state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_sub(5); [INFO] [stdout] 519 | | ... interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 520 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 516 ~ KeyCode::Up [INFO] [stdout] 517 ~ if !(state.ui_update_rate_ms <= 10) => { // cap at 100fps [INFO] [stdout] 518 | state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_sub(5); [INFO] [stdout] 519 | interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 520 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/main.rs:523:29 [INFO] [stdout] | [INFO] [stdout] 523 | / ... if !(state.ui_update_rate_ms >= 100) { // no lower than 10fps because it starts being unresponsive to key events [INFO] [stdout] 524 | | ... state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_add(5); [INFO] [stdout] 525 | | ... interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 526 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 522 ~ KeyCode::Down [INFO] [stdout] 523 ~ if !(state.ui_update_rate_ms >= 100) => { // no lower than 10fps because it starts being unresponsive to key events [INFO] [stdout] 524 | state.ui_update_rate_ms = state.ui_update_rate_ms.saturating_add(5); [INFO] [stdout] 525 | interval = time::interval_at(Instant::now(), Duration::from_millis(state.ui_update_rate_ms)); [INFO] [stdout] 526 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.57s [INFO] running `Command { std: "docker" "inspect" "7bebee27e7012fed55de63df20371a75e73b4be44c3e93de4236276927d9859b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bebee27e7012fed55de63df20371a75e73b4be44c3e93de4236276927d9859b", kill_on_drop: false }` [INFO] [stdout] 7bebee27e7012fed55de63df20371a75e73b4be44c3e93de4236276927d9859b